OpenBSD CVS

CVS log for src/bin/csh/file.c


[BACK] Up to [local] / src / bin / csh

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.40 / (download) - annotate - [select for diffs], Tue Oct 6 01:40:43 2020 UTC (3 years, 8 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, HEAD
Changes since 1.39: +15 -8 lines
Diff to previous 1.39 (colored)

I observed "csh i < file-containing-^T" to hit tenex(), which proceeds to
perform tty(4) ioctl operations against a non-tty.  That is a pledge
violation, you can only do a subset of tty(4) ioctl against a fd which
references a tty device.  Sidestep this problem if the input descriptor is
not a tty
ok anton millert

Revision 1.39 / (download) - annotate - [select for diffs], Fri Nov 29 05:28:32 2019 UTC (4 years, 6 months ago) by nayden
Branch: MAIN
CVS Tags: OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7
Changes since 1.38: +2 -2 lines
Diff to previous 1.38 (colored)

typo fix.

ok deraadt@

Revision 1.38 / (download) - annotate - [select for diffs], Fri Jun 28 13:34:58 2019 UTC (4 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.37: +2 -2 lines
Diff to previous 1.37 (colored)

When system calls indicate an error they return -1, not some arbitrary
value < 0.  errno is only updated in this case.  Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Revision 1.37 / (download) - annotate - [select for diffs], Thu Nov 16 19:22:33 2017 UTC (6 years, 6 months ago) by anton
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3
Changes since 1.36: +2 -2 lines
Diff to previous 1.36 (colored)

In revision 1.35 of file.c, tenex() was modified to respect the inputline_size
argument but I forgot to adapt one conditional. Still no functional change since
tenex() only has one call site where `inputline_size == sizeof(buf)`.

Revision 1.36 / (download) - annotate - [select for diffs], Thu Nov 16 19:08:16 2017 UTC (6 years, 6 months ago) by anton
Branch: MAIN
Changes since 1.35: +2 -3 lines
Diff to previous 1.35 (colored)

Zap a redundant cast.

Revision 1.35 / (download) - annotate - [select for diffs], Wed Aug 30 06:57:48 2017 UTC (6 years, 9 months ago) by anton
Branch: MAIN
CVS Tags: OPENBSD_6_2_BASE, OPENBSD_6_2
Changes since 1.34: +3 -1 lines
Diff to previous 1.34 (colored)

Respect inputline_size argument. No functional change since tenex() only has one
call site where `inputline_size == sizeof(buf)`.

Revision 1.34 / (download) - annotate - [select for diffs], Wed Aug 30 06:42:21 2017 UTC (6 years, 9 months ago) by anton
Branch: MAIN
Changes since 1.33: +14 -4 lines
Diff to previous 1.33 (colored)

Fix pasting of long (>BUFSIZ) lines in csh with filec enabled. NUL-terminating
the input buffer instructs csh that the buffer contains a complete command. This
is wrong and should only happen when buffer is not full, otherwise more data has
to be read in order form a complete command.

While here, do not print the prompt again when the input exceeds the input
buffer and while inserting a line continuation (backslash).

Revision 1.33 / (download) - annotate - [select for diffs], Wed Jul 26 19:20:51 2017 UTC (6 years, 10 months ago) by anton
Branch: MAIN
Changes since 1.32: +12 -12 lines
Diff to previous 1.32 (colored)

Align variables and put logical operators at EOL. No binary change.

Revision 1.32 / (download) - annotate - [select for diffs], Wed Jul 26 19:15:09 2017 UTC (6 years, 10 months ago) by anton
Branch: MAIN
Changes since 1.31: +3 -1 lines
Diff to previous 1.31 (colored)

Postpone printing of prompt if filec is enabled in csh. Any I/O should be
performed first when canonical mode has been disabled on the tty just like ksh
does. Discovered by the regress tests.

Joint work with bluhm@, ok deraadt@

Revision 1.31 / (download) - annotate - [select for diffs], Tue Jul 18 17:24:42 2017 UTC (6 years, 10 months ago) by anton
Branch: MAIN
Changes since 1.30: +4 -2 lines
Diff to previous 1.30 (colored)

Restore tty when aborting loop.

ok deraadt@

Revision 1.30 / (download) - annotate - [select for diffs], Thu Jun 29 04:23:12 2017 UTC (6 years, 11 months ago) by deraadt
Branch: MAIN
Changes since 1.29: +2 -4 lines
Diff to previous 1.29 (colored)

Switch TIOCSTAT to _IO().  Two decades ago it was mistakenly defined to
take an argument.  Discussed with millert and tedu.

Revision 1.29 / (download) - annotate - [select for diffs], Tue Jun 27 15:02:18 2017 UTC (6 years, 11 months ago) by anton
Branch: MAIN
Changes since 1.28: +6 -6 lines
Diff to previous 1.28 (colored)

Tweak previous: align declarations and rename local variable.

Revision 1.28 / (download) - annotate - [select for diffs], Tue Jun 27 14:37:08 2017 UTC (6 years, 11 months ago) by deraadt
Branch: MAIN
Changes since 1.27: +9 -7 lines
Diff to previous 1.27 (colored)

in recently commited TIOCSTI replacement code, do not assume
little-endian or unsigned char :-)
ok anton

Revision 1.27 / (download) - annotate - [select for diffs], Thu Jun 22 18:05:31 2017 UTC (6 years, 11 months ago) by anton
Branch: MAIN
Changes since 1.26: +6 -1 lines
Diff to previous 1.26 (colored)


Make sure to abort loops when pressing ^C in csh.

Regression found by deraadt@

Revision 1.26 / (download) - annotate - [select for diffs], Wed Jun 21 19:36:23 2017 UTC (6 years, 11 months ago) by anton
Branch: MAIN
Changes since 1.25: +9 -10 lines
Diff to previous 1.25 (colored)

Minor style(9) corrections and whitespace cleanup to csh.

ok deraadt@ tb@

Revision 1.25 / (download) - annotate - [select for diffs], Wed Jun 21 18:55:15 2017 UTC (6 years, 11 months ago) by anton
Branch: MAIN
Changes since 1.24: +344 -175 lines
Diff to previous 1.24 (colored)

Replace usage of TIOCSTI in csh using a more common IO-loop where ICANON is
disabled and a single char of input is read at a time. This requires the line
editing capabilities provided when ICANON is enabled to be implemented.

With help and feedback from deraadt@

Revision 1.24 / (download) - annotate - [select for diffs], Sat Jun 17 18:14:47 2017 UTC (6 years, 11 months ago) by anton
Branch: MAIN
Changes since 1.23: +2 -3 lines
Diff to previous 1.23 (colored)

Move win variable.

ok deraadt@ tb@

Revision 1.23 / (download) - annotate - [select for diffs], Sat Dec 26 13:48:38 2015 UTC (8 years, 5 months ago) by mestre
Branch: MAIN
CVS Tags: OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.22: +3 -3 lines
Diff to previous 1.22 (colored)

Replace handrolled xfree() function by directly using free(3)

OK mmcc@

Revision 1.22 / (download) - annotate - [select for diffs], Mon Oct 26 15:01:15 2015 UTC (8 years, 7 months ago) by naddy
Branch: MAIN
Changes since 1.21: +1 -4 lines
Diff to previous 1.21 (colored)

unifdef BUILTIN (unused), NLS (always set), SHORT_STRINGS (always set)
and remove a few unused defines; no binary changes; ok tedu@ zhuk@

Revision 1.21 / (download) - annotate - [select for diffs], Wed Jun 17 03:48:21 2015 UTC (8 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8
Changes since 1.20: +1 -3 lines
Diff to previous 1.20 (colored)

remove -DFILEC; code does not compile for the -UFILEC case, and anyways,
who wants csh without FILEC??
from Peter Brottveit Bock, but redone using unifdef

Revision 1.20 / (download) - annotate - [select for diffs], Wed Jun 3 01:49:35 2015 UTC (9 years ago) by deraadt
Branch: MAIN
Changes since 1.19: +2 -3 lines
Diff to previous 1.19 (colored)

better description of internal copyn() function

Revision 1.19 / (download) - annotate - [select for diffs], Sun Feb 8 05:47:28 2015 UTC (9 years, 4 months ago) by tedu
Branch: MAIN
CVS Tags: OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.18: +4 -4 lines
Diff to previous 1.18 (colored)

delete lots of unnecessary ptr_t casts, and drop a little NULL in as well

Revision 1.18 / (download) - annotate - [select for diffs], Fri Jan 16 06:39:31 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
Changes since 1.17: +9 -8 lines
Diff to previous 1.17 (colored)

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible.  Annotate <sys/param.h> lines with their current reasons.  Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc.  Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution.  These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Revision 1.17 / (download) - annotate - [select for diffs], Thu Oct 16 19:43:31 2014 UTC (9 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.16: +3 -8 lines
Diff to previous 1.16 (colored)

Use reallocarray() and remove a few archaic memory allocation practices.
ok deraadt

Revision 1.16 / (download) - annotate - [select for diffs], Tue Oct 27 23:59:21 2009 UTC (14 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.15: +1 -9 lines
Diff to previous 1.15 (colored)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable).  these days, people use source.  these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Revision 1.15 / (download) - annotate - [select for diffs], Wed Jun 11 21:09:50 2003 UTC (21 years ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3, OPENBSD_4_2_BASE, OPENBSD_4_2, OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0, OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6, OPENBSD_3_5_BASE, OPENBSD_3_5, OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.14: +41 -68 lines
Diff to previous 1.14 (colored)

de-register and ansify functions

Revision 1.14 / (download) - annotate - [select for diffs], Mon Jun 2 23:32:07 2003 UTC (21 years ago) by millert
Branch: MAIN
Changes since 1.13: +3 -7 lines
Diff to previous 1.13 (colored)

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999.  Proofed by myself and Theo.

Revision 1.13 / (download) - annotate - [select for diffs], Wed Jan 8 06:54:16 2003 UTC (21 years, 5 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3
Changes since 1.12: +11 -8 lines
Diff to previous 1.12 (colored)

bring in strlcpy and strlcat-like things for dealing with Char types,
this fixes at least 15 buffer overflows; some help from dhartmei.
Anyone want to go do the same in ksh, and help with some of the while
(*s++ = *p++) loops in here?

Revision 1.12 / (download) - annotate - [select for diffs], Wed Jul 24 19:53:50 2002 UTC (21 years, 10 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_2_BASE, OPENBSD_3_2
Changes since 1.11: +12 -11 lines
Diff to previous 1.11 (colored)

Fix a bug I inadvertanly introduced while fixing the last problem in here.
The item list really did want to be zero-filled since free_items() relies
on this to find the end point.  However, this is really pretty dumb since
we *know* how many items are in the list.

This highlights the elusive bug I was trying to fix--free_items() expects
the list to be NULL-terminated which was not the case if the list was full.
The fix is to simply pass free_items() the number of elements in the list.

Revision 1.11 / (download) - annotate - [select for diffs], Mon Jul 15 22:10:13 2002 UTC (21 years, 11 months ago) by millert
Branch: MAIN
Changes since 1.10: +11 -16 lines
Diff to previous 1.10 (colored)

Remove 1024 directory entry limit for tenex-style file completion.
This fixes a mysterious segv when doing file completion twice in
directories w/ more than 1024 files.

Revision 1.10 / (download) - annotate - [select for diffs], Sun Jun 9 05:47:27 2002 UTC (22 years ago) by todd
Branch: MAIN
Changes since 1.9: +3 -3 lines
Diff to previous 1.9 (colored)

knf

Revision 1.9 / (download) - annotate - [select for diffs], Tue Feb 19 19:39:35 2002 UTC (22 years, 3 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.8: +3 -7 lines
Diff to previous 1.8 (colored)

We live in an ANSI C world.  Remove lots of gratuitous #ifdef __STDC__ cruft.

Revision 1.8 / (download) - annotate - [select for diffs], Sat Feb 16 21:27:06 2002 UTC (22 years, 3 months ago) by millert
Branch: MAIN
Changes since 1.7: +22 -22 lines
Diff to previous 1.7 (colored)

Part one of userland __P removal.  Done with a simple regexp with some minor hand editing to make comments line up correctly.  Another pass is forthcoming that handles the cases that could not be done automatically.

Revision 1.7 / (download) - annotate - [select for diffs], Sat Dec 1 19:10:39 2001 UTC (22 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.6: +4 -4 lines
Diff to previous 1.6 (colored)

KNF

Revision 1.6 / (download) - annotate - [select for diffs], Mon May 18 20:38:20 1998 UTC (26 years ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0, OPENBSD_2_9_BASE, OPENBSD_2_9, OPENBSD_2_8_BASE, OPENBSD_2_8, OPENBSD_2_7_BASE, OPENBSD_2_7, OPENBSD_2_6_BASE, OPENBSD_2_6, OPENBSD_2_5_BASE, OPENBSD_2_5, OPENBSD_2_4_BASE, OPENBSD_2_4
Changes since 1.5: +3 -3 lines
Diff to previous 1.5 (colored)

MAXPATHLEN not MAXPATHLEN+1

Revision 1.5 / (download) - annotate - [select for diffs], Sat Nov 15 21:51:29 1997 UTC (26 years, 7 months ago) by todd
Branch: MAIN
CVS Tags: OPENBSD_2_3_BASE, OPENBSD_2_3
Changes since 1.4: +3 -3 lines
Diff to previous 1.4 (colored)

spelling

Revision 1.4 / (download) - annotate - [select for diffs], Fri Jul 25 18:58:06 1997 UTC (26 years, 10 months ago) by mickey
Branch: MAIN
CVS Tags: OPENBSD_2_2_BASE, OPENBSD_2_2
Changes since 1.3: +3 -3 lines
Diff to previous 1.3 (colored)

#if __STDC__ --> #ifdef __STDC__

Revision 1.3 / (download) - annotate - [select for diffs], Wed Dec 4 17:46:07 1996 UTC (27 years, 6 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_1_BASE, OPENBSD_2_1
Changes since 1.2: +8 -8 lines
Diff to previous 1.2 (colored)

use TCSADRAIN instead of TCSANOW, to avoid dropping characters.
Fix from NetBSD (christos), reported by Chris Torek.

Revision 1.2 / (download) - annotate - [select for diffs], Sun Jun 23 14:19:22 1996 UTC (27 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.1: +2 -1 lines
Diff to previous 1.1 (colored)

update rcsid

Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Wed Oct 18 08:37:03 1995 UTC (28 years, 8 months ago) by deraadt
CVS Tags: netbsd_1_1
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)

initial import of NetBSD tree

Revision 1.1 / (download) - annotate - [select for diffs], Wed Oct 18 08:37:03 1995 UTC (28 years, 8 months ago) by deraadt
Branch: MAIN

Initial revision

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.