OpenBSD CVS

CVS log for src/bin/dd/dd.c


[BACK] Up to [local] / src / bin / dd

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.28 / (download) - annotate - [select for diffs], Sun Oct 24 21:24:21 2021 UTC (2 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, HEAD
Changes since 1.27: +2 -2 lines
Diff to previous 1.27 (colored)

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant.  Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk.  They could all be 0xdeafbeef.
ok millert

Revision 1.27 / (download) - annotate - [select for diffs], Fri Jun 28 13:34:59 2019 UTC (4 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.26: +8 -8 lines
Diff to previous 1.26 (colored)

When system calls indicate an error they return -1, not some arbitrary
value < 0.  errno is only updated in this case.  Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Revision 1.26 / (download) - annotate - [select for diffs], Sat Feb 16 10:54:00 2019 UTC (5 years, 3 months ago) by bluhm
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5
Changes since 1.25: +5 -1 lines
Diff to previous 1.25 (colored)

Implement the conv=fsync feature which does an fsync(2) after the
final write to output.  GNU dd also has this.  It is useful for
write performance measurement or guaranteed writes to reliable
storage.
OK kn@ tedu@ deraadt@

Revision 1.25 / (download) - annotate - [select for diffs], Mon Jul 23 23:09:37 2018 UTC (5 years, 10 months ago) by cheloha
Branch: MAIN
CVS Tags: OPENBSD_6_4_BASE, OPENBSD_6_4
Changes since 1.24: +9 -5 lines
Diff to previous 1.24 (colored)

Don't cast malloc(3) size to u_int.

Large buffer sizes on 64-bit platforms cause the sum to wrap, leading
read(2) to fail later.

We check prior to this point that all buffer sizes are <= SSIZE_MAX.
SSIZE_MAX * 2 < SIZE_MAX on all platforms, so the addition here will
not overflow and cause a similar issue.

Discovered by tobias@ a while back.

ok deraadt millert tobias

Revision 1.24 / (download) - annotate - [select for diffs], Sun Aug 13 02:06:42 2017 UTC (6 years, 9 months ago) by tedu
Branch: MAIN
CVS Tags: OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2
Changes since 1.23: +2 -2 lines
Diff to previous 1.23 (colored)

convert gettimeofday to mono clock.
from Scott Cheloha

Revision 1.23 / (download) - annotate - [select for diffs], Fri Oct 9 01:37:06 2015 UTC (8 years, 8 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.22: +3 -3 lines
Diff to previous 1.22 (colored)

Change all tame callers to namechange to pledge(2).

Revision 1.22 / (download) - annotate - [select for diffs], Sun Oct 4 15:01:47 2015 UTC (8 years, 8 months ago) by deraadt
Branch: MAIN
Changes since 1.21: +4 -1 lines
Diff to previous 1.21 (colored)

after dd has opened it's files and done the tape positioning ioctl, we
can tame "stdio" it.
ok semarie

Revision 1.21 / (download) - annotate - [select for diffs], Fri Jan 16 06:39:31 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.20: +5 -3 lines
Diff to previous 1.20 (colored)

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible.  Annotate <sys/param.h> lines with their current reasons.  Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc.  Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution.  These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Revision 1.20 / (download) - annotate - [select for diffs], Mon Jan 5 13:52:47 2015 UTC (9 years, 5 months ago) by tedu
Branch: MAIN
Changes since 1.19: +2 -2 lines
Diff to previous 1.19 (colored)

use the correct read count when determining how swabbing is necessary.
bug report from Martin Wolters

Revision 1.19 / (download) - annotate - [select for diffs], Thu Dec 11 20:39:06 2014 UTC (9 years, 6 months ago) by tedu
Branch: MAIN
Changes since 1.18: +18 -2 lines
Diff to previous 1.18 (colored)

use a local swapbytes function instead of relying on undefined
overlapping swab behavior. vaguely ok kettenis

Revision 1.18 / (download) - annotate - [select for diffs], Sat Jun 1 16:46:49 2013 UTC (11 years ago) by tedu
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4
Changes since 1.17: +2 -5 lines
Diff to previous 1.17 (colored)

consolidate ifdef blocks by moving a variable

Revision 1.17 / (download) - annotate - [select for diffs], Thu Jul 12 14:28:13 2012 UTC (11 years, 11 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2
Changes since 1.16: +3 -3 lines
Diff to previous 1.16 (colored)

Use S_ISFIFO and S_ISSOCK instead of lseek() to determine whether
an fd is a socket, pipe or named pipe.  OK deraadt@ matthew@

Revision 1.16 / (download) - annotate - [select for diffs], Tue Oct 27 23:59:21 2009 UTC (14 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.15: +1 -15 lines
Diff to previous 1.15 (colored)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable).  these days, people use source.  these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Revision 1.15 / (download) - annotate - [select for diffs], Sat Nov 10 13:45:17 2007 UTC (16 years, 7 months ago) by chl
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.14: +4 -2 lines
Diff to previous 1.14 (colored)

remove "unused variable" warning appearing when building release

ok millert@

Revision 1.14 / (download) - annotate - [select for diffs], Wed Jun 11 23:42:12 2003 UTC (21 years ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_2_BASE, OPENBSD_4_2, OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0, OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6, OPENBSD_3_5_BASE, OPENBSD_3_5, OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.13: +8 -12 lines
Diff to previous 1.13 (colored)

ansification, art ok

Revision 1.13 / (download) - annotate - [select for diffs], Mon Jun 2 23:32:07 2003 UTC (21 years ago) by millert
Branch: MAIN
Changes since 1.12: +3 -7 lines
Diff to previous 1.12 (colored)

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999.  Proofed by myself and Theo.

Revision 1.12 / (download) - annotate - [select for diffs], Sat Feb 16 21:27:06 2002 UTC (22 years, 3 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3, OPENBSD_3_2_BASE, OPENBSD_3_2, OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.11: +7 -7 lines
Diff to previous 1.11 (colored)

Part one of userland __P removal.  Done with a simple regexp with some minor hand editing to make comments line up correctly.  Another pass is forthcoming that handles the cases that could not be done automatically.

Revision 1.11 / (download) - annotate - [select for diffs], Sat Oct 6 22:31:54 2001 UTC (22 years, 8 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0
Changes since 1.10: +3 -3 lines
Diff to previous 1.10 (colored)

Fix ``echo foo |dd'' which was broken by the last commit.

Revision 1.10 / (download) - annotate - [select for diffs], Thu Oct 4 20:32:27 2001 UTC (22 years, 8 months ago) by millert
Branch: MAIN
Changes since 1.9: +6 -4 lines
Diff to previous 1.9 (colored)

Move check for count=0 into dd's main.  We want to do normal setup
in this case and just don't want to actually copy any data.
Fixes a problem noted by aaron@ where the time portion of the summary
would be wrong and also gives us sane behavior when seek is non-zero
but count is 0.

Revision 1.9 / (download) - annotate - [select for diffs], Tue Aug 7 14:39:27 2001 UTC (22 years, 10 months ago) by hugh
Branch: MAIN
Changes since 1.8: +4 -3 lines
Diff to previous 1.8 (colored)

Modify timekeeping in an effort to produce a sane bandwidth measure
for a short running dd process. Some floating point is used so that
microsecond precision can be kept without shortening the off_t
excessively. millert says ok.

Revision 1.8 / (download) - annotate - [select for diffs], Thu Apr 30 05:55:02 1998 UTC (26 years, 1 month ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_9_BASE, OPENBSD_2_9, OPENBSD_2_8_BASE, OPENBSD_2_8, OPENBSD_2_7_BASE, OPENBSD_2_7, OPENBSD_2_6_BASE, OPENBSD_2_6, OPENBSD_2_5_BASE, OPENBSD_2_5, OPENBSD_2_4_BASE, OPENBSD_2_4
Changes since 1.7: +4 -3 lines
Diff to previous 1.7 (colored)

Wall

Revision 1.7 / (download) - annotate - [select for diffs], Sat Nov 15 22:10:22 1997 UTC (26 years, 7 months ago) by todd
Branch: MAIN
CVS Tags: OPENBSD_2_3_BASE, OPENBSD_2_3
Changes since 1.6: +3 -3 lines
Diff to previous 1.6 (colored)

spelling

Revision 1.6 / (download) - annotate - [select for diffs], Mon Aug 25 15:24:07 1997 UTC (26 years, 9 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_2_BASE, OPENBSD_2_2
Changes since 1.5: +12 -11 lines
Diff to previous 1.5 (colored)

clear input buffer to ' ' or \0 correctly; jlemon@freebsd

Revision 1.5 / (download) - annotate - [select for diffs], Fri Feb 14 07:05:20 1997 UTC (27 years, 4 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_1_BASE, OPENBSD_2_1
Changes since 1.4: +15 -13 lines
Diff to previous 1.4 (colored)

Deal with 64-bit offsets and report bytes copied as a 64-bit quantity.
Closes OpenBSD PR system/107.

Revision 1.4 / (download) - annotate - [select for diffs], Sat Dec 14 12:17:49 1996 UTC (27 years, 6 months ago) by mickey
Branch: MAIN
Changes since 1.3: +5 -5 lines
Diff to previous 1.3 (colored)

-Wall'ing.

Revision 1.3 / (download) - annotate - [select for diffs], Sun Jun 23 14:19:47 1996 UTC (27 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.2: +2 -1 lines
Diff to previous 1.2 (colored)

update rcsid

Revision 1.2 / (download) - annotate - [select for diffs], Sun Mar 3 12:38:51 1996 UTC (28 years, 3 months ago) by niklas
Branch: MAIN
Changes since 1.1: +12 -15 lines
Diff to previous 1.1 (colored)

From NetBSD: Use const qualifier with conversion, args and clist tables

Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Wed Oct 18 08:37:06 1995 UTC (28 years, 8 months ago) by deraadt
CVS Tags: netbsd_1_1
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)

initial import of NetBSD tree

Revision 1.1 / (download) - annotate - [select for diffs], Wed Oct 18 08:37:06 1995 UTC (28 years, 8 months ago) by deraadt
Branch: MAIN

Initial revision

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.