![[BACK]](/icons/back.gif){kind=icon}
Up to [local] / src / bin / ksh
Request diff between arbitrary revisions
Default branch: MAIN
Revision 1.19 / (download) - annotate - [select for diffs], Sun Oct 24 21:24:21 2021 UTC (2 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE,
OPENBSD_7_5,
OPENBSD_7_4_BASE,
OPENBSD_7_4,
OPENBSD_7_3_BASE,
OPENBSD_7_3,
OPENBSD_7_2_BASE,
OPENBSD_7_2,
OPENBSD_7_1_BASE,
OPENBSD_7_1,
HEAD
Changes since 1.18: +2 -2 lines
Diff to previous 1.18 (colored)
For open/openat, if the flags parameter does not contain O_CREAT, the 3rd (variadic) mode_t parameter is irrelevant. Many developers in the past have passed mode_t (0, 044, 0644, or such), which might lead future people to copy this broken idiom, and perhaps even believe this parameter has some meaning or implication or application. Delete them all. This comes out of a conversation where tb@ noticed that a strange (but intentional) pledge behaviour is to always knock-out high-bits from mode_t on a number of system calls as a safety factor, and his bewilderment that this appeared to be happening against valid modes (at least visually), but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef. ok millert
Revision 1.18 / (download) - annotate - [select for diffs], Fri Jun 28 13:34:59 2019 UTC (4 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE,
OPENBSD_7_0,
OPENBSD_6_9_BASE,
OPENBSD_6_9,
OPENBSD_6_8_BASE,
OPENBSD_6_8,
OPENBSD_6_7_BASE,
OPENBSD_6_7,
OPENBSD_6_6_BASE,
OPENBSD_6_6
Changes since 1.17: +3 -3 lines
Diff to previous 1.17 (colored)
When system calls indicate an error they return -1, not some arbitrary value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.
Revision 1.17 / (download) - annotate - [select for diffs], Thu Mar 15 16:51:29 2018 UTC (6 years, 2 months ago) by anton
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE,
OPENBSD_6_5,
OPENBSD_6_4_BASE,
OPENBSD_6_4,
OPENBSD_6_3_BASE,
OPENBSD_6_3
Changes since 1.16: +3 -3 lines
Diff to previous 1.16 (colored)
Favor usage of __func__ in warning/error messages. Some of them referred to the wrong function and fix the rest for consistency. Diff from Michael W. Bombardieri with some cosmetic cleanup applied. ok benno@ tb@
Revision 1.16 / (download) - annotate - [select for diffs], Mon Dec 14 13:59:42 2015 UTC (8 years, 5 months ago) by tb
Branch: MAIN
CVS Tags: OPENBSD_6_2_BASE,
OPENBSD_6_2,
OPENBSD_6_1_BASE,
OPENBSD_6_1,
OPENBSD_6_0_BASE,
OPENBSD_6_0,
OPENBSD_5_9_BASE,
OPENBSD_5_9
Changes since 1.15: +4 -1 lines
Diff to previous 1.15 (colored)
Move system headers from sh.h to those files that actually need them. ok mmcc@ a while ago
Revision 1.15 / (download) - annotate - [select for diffs], Wed Dec 2 05:06:26 2015 UTC (8 years, 6 months ago) by mmcc
Branch: MAIN
Changes since 1.14: +2 -2 lines
Diff to previous 1.14 (colored)
comment typo
Revision 1.14 / (download) - annotate - [select for diffs], Mon Oct 19 14:42:16 2015 UTC (8 years, 7 months ago) by mmcc
Branch: MAIN
Changes since 1.13: +3 -1 lines
Diff to previous 1.13 (colored)
Move string.h include from sh.h to the files that use it. ok nicm@
Revision 1.13 / (download) - annotate - [select for diffs], Thu Oct 15 20:01:53 2015 UTC (8 years, 7 months ago) by mmcc
Branch: MAIN
Changes since 1.12: +1 -2 lines
Diff to previous 1.12 (colored)
Remove an unused included header (sys/stat.h).
Revision 1.12 / (download) - annotate - [select for diffs], Fri Sep 25 11:58:14 2015 UTC (8 years, 8 months ago) by nicm
Branch: MAIN
Changes since 1.11: +5 -3 lines
Diff to previous 1.11 (colored)
Remove EXTERN from tty.[ch], from Michael McConville. No binary change.
Revision 1.11 / (download) - annotate - [select for diffs], Sun Sep 13 19:46:36 2015 UTC (8 years, 9 months ago) by tedu
Branch: MAIN
Changes since 1.10: +13 -17 lines
Diff to previous 1.10 (colored)
move tty_close up a bit so we can use it. combine two equiv if blocks. from Michael McConville
Revision 1.10 / (download) - annotate - [select for diffs], Sun Aug 10 02:44:26 2014 UTC (9 years, 10 months ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE,
OPENBSD_5_8,
OPENBSD_5_7_BASE,
OPENBSD_5_7
Changes since 1.9: +2 -7 lines
Diff to previous 1.9 (colored)
Replace F_DUPFD followed by setting FD_CLOEXEC with just F_DUPFD_CLOEXEC ok matthew@ millert@
Revision 1.9 / (download) - annotate - [select for diffs], Tue Mar 14 22:08:01 2006 UTC (18 years, 3 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE,
OPENBSD_5_6,
OPENBSD_5_5_BASE,
OPENBSD_5_5,
OPENBSD_5_4_BASE,
OPENBSD_5_4,
OPENBSD_5_3_BASE,
OPENBSD_5_3,
OPENBSD_5_2_BASE,
OPENBSD_5_2,
OPENBSD_5_1_BASE,
OPENBSD_5_1,
OPENBSD_5_0_BASE,
OPENBSD_5_0,
OPENBSD_4_9_BASE,
OPENBSD_4_9,
OPENBSD_4_8_BASE,
OPENBSD_4_8,
OPENBSD_4_7_BASE,
OPENBSD_4_7,
OPENBSD_4_6_BASE,
OPENBSD_4_6,
OPENBSD_4_5_BASE,
OPENBSD_4_5,
OPENBSD_4_4_BASE,
OPENBSD_4_4,
OPENBSD_4_3_BASE,
OPENBSD_4_3,
OPENBSD_4_2_BASE,
OPENBSD_4_2,
OPENBSD_4_1_BASE,
OPENBSD_4_1,
OPENBSD_4_0_BASE,
OPENBSD_4_0
Changes since 1.8: +4 -7 lines
Diff to previous 1.8 (colored)
only santa checks things twice; from adobriyan@gmail; ok tedu
Revision 1.8 / (download) - annotate - [select for diffs], Wed Mar 30 17:16:37 2005 UTC (19 years, 2 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_9_BASE,
OPENBSD_3_9,
OPENBSD_3_8_BASE,
OPENBSD_3_8
Changes since 1.7: +5 -6 lines
Diff to previous 1.7 (colored)
lots of indentation cleanup, now ksh is readable like our other code. double checked to make sure no binaries change, and eyed by niallo
Revision 1.7 / (download) - annotate - [select for diffs], Wed Dec 22 17:14:34 2004 UTC (19 years, 5 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_7_BASE,
OPENBSD_3_7
Changes since 1.6: +5 -5 lines
Diff to previous 1.6 (colored)
Use stdbool.h instead of rolling our own bools.
Revision 1.6 / (download) - annotate - [select for diffs], Mon Dec 20 11:34:26 2004 UTC (19 years, 5 months ago) by otto
Branch: MAIN
Changes since 1.5: +3 -4 lines
Diff to previous 1.5 (colored)
Ansification plus some minor knf. No binary change on i386 and sparc64, binary change in lex.o on macppc due to introduction of dopprompt() prototype. ok millert@
Revision 1.5 / (download) - annotate - [select for diffs], Sat Dec 18 22:35:41 2004 UTC (19 years, 5 months ago) by millert
Branch: MAIN
Changes since 1.4: +2 -2 lines
Diff to previous 1.4 (colored)
Replace fd_clexec() with calls to fcntl(fd, F_SETFD, FD_CLOEXEC)
Revision 1.4 / (download) - annotate - [select for diffs], Sat Dec 18 22:12:23 2004 UTC (19 years, 5 months ago) by millert
Branch: MAIN
Changes since 1.3: +2 -20 lines
Diff to previous 1.3 (colored)
Use struct termios instead of TTY_state typedef Use tc[gs]etattr() instead of [gs]et_tty() abstraction
Revision 1.3 / (download) - annotate - [select for diffs], Sat Dec 18 20:55:52 2004 UTC (19 years, 5 months ago) by millert
Branch: MAIN
Changes since 1.2: +5 -99 lines
Diff to previous 1.2 (colored)
Remove unused OS dependent #ifdef blocks, #defines and macro abstraction. First step in making the ksh code easier to read. From Matthias Kilian
Revision 1.2 / (download) - annotate - [select for diffs], Tue Oct 1 02:05:51 1996 UTC (27 years, 8 months ago) by downsj
Branch: MAIN
CVS Tags: OPENBSD_3_6_BASE,
OPENBSD_3_6,
OPENBSD_3_5_BASE,
OPENBSD_3_5,
OPENBSD_3_4_BASE,
OPENBSD_3_4,
OPENBSD_3_3_BASE,
OPENBSD_3_3,
OPENBSD_3_2_BASE,
OPENBSD_3_2,
OPENBSD_3_1_BASE,
OPENBSD_3_1,
OPENBSD_3_0_BASE,
OPENBSD_3_0,
OPENBSD_2_9_BASE,
OPENBSD_2_9,
OPENBSD_2_8_BASE,
OPENBSD_2_8,
OPENBSD_2_7_BASE,
OPENBSD_2_7,
OPENBSD_2_6_BASE,
OPENBSD_2_6,
OPENBSD_2_5_BASE,
OPENBSD_2_5,
OPENBSD_2_4_BASE,
OPENBSD_2_4,
OPENBSD_2_3_BASE,
OPENBSD_2_3
Changes since 1.1: +23 -4 lines
Diff to previous 1.1 (colored)
Integrate pdksh 5.2.9.
Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Wed Aug 14 06:19:12 1996 UTC (27 years, 10 months ago) by downsj
Branch: pdksh
CVS Tags: pdksh-527
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)
Import pdksh 5.2.7.
Revision 1.1 / (download) - annotate - [select for diffs], Wed Aug 14 06:19:12 1996 UTC (27 years, 10 months ago) by downsj
Branch: MAIN
Initial revision