OpenBSD CVS

CVS log for src/games/bs/bs.c


[BACK] Up to [local] / src / games / bs

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.42 / (download) - annotate - [select for diffs], Sat Oct 23 11:22:48 2021 UTC (2 years, 7 months ago) by mestre
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, HEAD
Changes since 1.41: +1 -4 lines
Diff to previous 1.41 (colored)

if both stdout and stderr are redirected to a non-tty, pledge(2) will kill
ncurses applications, e.g.:

/usr/games/worms 2>&1 | cat

solve this by only calling pledge(2) after initscr(3) is set and done, or
whatever function that calls it. since pledge(2) is called later now the
promises might be reduced, but this a diff for another day.

found by naddy@ almost a year ago, discussed with him deraadt@ and tb@
ok tb@

Revision 1.41 / (download) - annotate - [select for diffs], Fri Aug 24 11:14:49 2018 UTC (5 years, 9 months ago) by mestre
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4
Changes since 1.40: +5 -1 lines
Diff to previous 1.40 (colored)

Remove a few too early pledge(2)s on games/ and apply them a little bit later
but with much reduced permissions ("stdio tty" if ncurses based and "stdio"
for the ones that only perform basic operations).

There's still a few games that we cannot yet remove their fs access, through
pledge(2), since they open files on demand and too late, this might get
revisited in the future.

OK tb@

Revision 1.40 / (download) - annotate - [select for diffs], Sun Aug 5 13:32:25 2018 UTC (5 years, 10 months ago) by schwarze
Branch: MAIN
Changes since 1.39: +1 -2 lines
Diff to previous 1.39 (colored)

remove duplicate installation of the SIGINT handler;
from Martin Kopta <martin at kopta dot eu>

Revision 1.39 / (download) - annotate - [select for diffs], Mon Mar 7 12:07:55 2016 UTC (8 years, 3 months ago) by mestre
Branch: MAIN
CVS Tags: OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0
Changes since 1.38: +2 -2 lines
Diff to previous 1.38 (colored)

- General changes:
- Remove -? from getopt(3) options, but still keep (or add) -h where applicable
- Replace hardcoded program strings by getprogname(3)

- Specific changes:
- atc(6): this used -? and -u for usage(), remove both from game and manpage
- bcd(6): use __progname instead of getprogname(3), no need to include stdlib.h
- hunt(6): replace fputs(3) by fprintf(3)

OK tb@ after his suggestions

Revision 1.38 / (download) - annotate - [select for diffs], Sun Jan 10 14:10:39 2016 UTC (8 years, 5 months ago) by mestre
Branch: MAIN
CVS Tags: OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.37: +4 -4 lines
Diff to previous 1.37 (colored)

Remove needless casts to (char *) NULL. Some were kept, namely for execl(3)
last arguments since "The list of arguments must be terminated by a null
null pointer" of type char *

Suggested by and OK tb@

Revision 1.37 / (download) - annotate - [select for diffs], Fri Jan 8 20:19:06 2016 UTC (8 years, 5 months ago) by mestre
Branch: MAIN
Changes since 1.36: +2 -3 lines
Diff to previous 1.36 (colored)

Remove unnecessary headers an sort

Revision 1.36 / (download) - annotate - [select for diffs], Thu Jan 7 16:00:32 2016 UTC (8 years, 5 months ago) by tb
Branch: MAIN
Changes since 1.35: +2 -3 lines
Diff to previous 1.35 (colored)

Some basic code maintenance in games/

- in main() replace exit with return
- drop some /* NOTREACHED */ lint comments along the way.
- make more use of standard CFLAGS, esp. -Wimplicit-function-declaration
- add and sort some headers when needed
- add straightforward pledges to some programs used at compile time

discussed with and ok mestre@

Revision 1.35 / (download) - annotate - [select for diffs], Sun Jan 3 14:38:17 2016 UTC (8 years, 5 months ago) by mestre
Branch: MAIN
Changes since 1.34: +1 -2 lines
Diff to previous 1.34 (colored)

About 13 years ago when the idiom srandom(time()), and sometimes
srandom(time()+getpid()), was changed by srandomdev(), but #include <time.h>
lived up until this day so remove it.

Additionally, earlier than that, 18 years ago, random(6) was one of the first
consumers of arc4random(3) family, and was pulling it from dev/rndvar.h but
these days we pull it from stdlib.h, which is already done, so while here
remove dev/rndvar.h also.

"seems comprehensive to me" deraadt@ and OK tb@

Revision 1.34 / (download) - annotate - [select for diffs], Sat Dec 26 00:26:39 2015 UTC (8 years, 5 months ago) by mestre
Branch: MAIN
Changes since 1.33: +2 -2 lines
Diff to previous 1.33 (colored)

Set as __dead a few more functions, that don't return, on games/

With precious tip, help and also OK from tb@

Revision 1.33 / (download) - annotate - [select for diffs], Fri Dec 25 03:20:57 2015 UTC (8 years, 5 months ago) by mestre
Branch: MAIN
Changes since 1.32: +49 -29 lines
Diff to previous 1.32 (colored)

Apply some more KNF to the declaration of functions, but keep style to the rest of code for now.

OK tb@

Revision 1.32 / (download) - annotate - [select for diffs], Thu Dec 24 16:55:13 2015 UTC (8 years, 5 months ago) by tb
Branch: MAIN
Changes since 1.31: +48 -28 lines
Diff to previous 1.31 (colored)

Function prototypes and a little bit of KNF.

Committing on behalf of mestre@ who has more to come.

Revision 1.31 / (download) - annotate - [select for diffs], Fri Dec 4 10:41:35 2015 UTC (8 years, 6 months ago) by tedu
Branch: MAIN
Changes since 1.30: +1 -50 lines
Diff to previous 1.30 (colored)

assume modern curses and unifdef ancient feature tests

Revision 1.30 / (download) - annotate - [select for diffs], Mon Nov 30 08:33:29 2015 UTC (8 years, 6 months ago) by tb
Branch: MAIN
Changes since 1.29: +4 -1 lines
Diff to previous 1.29 (colored)

pledge "stdio rpath tty" for bs

Revision 1.29 / (download) - annotate - [select for diffs], Sat Oct 24 17:29:03 2015 UTC (8 years, 7 months ago) by mmcc
Branch: MAIN
Changes since 1.28: +2 -2 lines
Diff to previous 1.28 (colored)

Cast toupper()'s argument to unsigned char.

ok guenther@

Revision 1.28 / (download) - annotate - [select for diffs], Sun Sep 27 05:27:42 2015 UTC (8 years, 8 months ago) by guenther
Branch: MAIN
Changes since 1.27: +14 -8 lines
Diff to previous 1.27 (colored)

Make prompt() properly printf-like, eliminating empty dummy args

Revision 1.27 / (download) - annotate - [select for diffs], Wed Feb 18 23:41:31 2015 UTC (9 years, 3 months ago) by tedu
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.26: +23 -23 lines
Diff to previous 1.26 (colored)

improve ship placement interface. per the instructions, 2468 should work,
but the first loop didn't allow them. also allow arrow keys to work, since
they work in other modes.

Revision 1.26 / (download) - annotate - [select for diffs], Sun Nov 16 04:49:48 2014 UTC (9 years, 6 months ago) by guenther
Branch: MAIN
Changes since 1.25: +3 -3 lines
Diff to previous 1.25 (colored)

Eliminate pointless use of <sys/param.h>, <sys/file.h>, <sys/sockio.h>,
    and <sys/ttydefaults.h>
Replace MAXPATHLEN with PATH_MAX and MAXLOGNAME with LOGIN_NAME_MAX
Pull in <limits.h> where needed
Prefer sizeof(var) over MAXFOO or FOO_MAX

ok deraadt@

Revision 1.25 / (download) - annotate - [select for diffs], Sat Jul 12 08:29:56 2014 UTC (9 years, 11 months ago) by tedu
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6
Changes since 1.24: +6 -8 lines
Diff to previous 1.24 (colored)

mlarkin found disabled code to print a battleship. improve it and enable.
ok mlarkin

Revision 1.24 / (download) - annotate - [select for diffs], Thu Aug 29 20:22:11 2013 UTC (10 years, 9 months ago) by naddy
Branch: MAIN
CVS Tags: OPENBSD_5_5_BASE, OPENBSD_5_5
Changes since 1.23: +2 -6 lines
Diff to previous 1.23 (colored)

replace srandomdev()+random() with the arc4random*() family
tweaks and ok millert@, ok deraadt@

Revision 1.23 / (download) - annotate - [select for diffs], Sat Nov 14 02:20:43 2009 UTC (14 years, 6 months ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.22: +29 -43 lines
Diff to previous 1.22 (colored)

Use getopt() to parse the argument list, shrinking the code and
permitting options to be grouped

ok deraadt@

Revision 1.22 / (download) - annotate - [select for diffs], Tue Oct 27 23:59:24 2009 UTC (14 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.21: +1 -5 lines
Diff to previous 1.21 (colored)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable).  these days, people use source.  these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Revision 1.21 / (download) - annotate - [select for diffs], Sat Oct 17 21:45:50 2009 UTC (14 years, 7 months ago) by sobrado
Branch: MAIN
Changes since 1.20: +4 -4 lines
Diff to previous 1.20 (colored)

sort flags; "usage:" is lowercase.

Revision 1.20 / (download) - annotate - [select for diffs], Wed Jun 11 08:47:44 2003 UTC (21 years ago) by pjanzen
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3, OPENBSD_4_2_BASE, OPENBSD_4_2, OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0, OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6, OPENBSD_3_5_BASE, OPENBSD_3_5, OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.19: +31 -2 lines
Diff to previous 1.19 (colored)

Original author agreed to permit bs to be released under BSD license.
Many thanks to Nick Stott for his detective work on this.

Revision 1.19 / (download) - annotate - [select for diffs], Mon May 19 08:18:23 2003 UTC (21 years ago) by pjanzen
Branch: MAIN
Changes since 1.18: +2 -11 lines
Diff to previous 1.18 (colored)

Remove #ifdef'ed out unnecessary defines.

Revision 1.18 / (download) - annotate - [select for diffs], Fri Dec 6 21:48:51 2002 UTC (21 years, 6 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3
Changes since 1.17: +3 -3 lines
Diff to previous 1.17 (colored)

Replace things like srandom(time(NULL)) with srandomdev(3).  random(3)
good enough for games but we should at least use a decent seed.
pjanzen@ OK

Revision 1.17 / (download) - annotate - [select for diffs], Fri Aug 9 09:54:30 2002 UTC (21 years, 10 months ago) by pjanzen
Branch: MAIN
CVS Tags: OPENBSD_3_2_BASE, OPENBSD_3_2
Changes since 1.16: +4 -4 lines
Diff to previous 1.16 (colored)

Only target in the playing field when using mouse.

Revision 1.16 / (download) - annotate - [select for diffs], Fri Aug 9 08:42:30 2002 UTC (21 years, 10 months ago) by pjanzen
Branch: MAIN
Changes since 1.15: +3 -2 lines
Diff to previous 1.15 (colored)

Fix an error in the CPU random fire routine that could cause a segfault.

Revision 1.15 / (download) - annotate - [select for diffs], Fri Aug 9 08:36:33 2002 UTC (21 years, 10 months ago) by pjanzen
Branch: MAIN
Changes since 1.14: +5 -7 lines
Diff to previous 1.14 (colored)

Bug fix in random placement code from Erik Sigra.

Revision 1.14 / (download) - annotate - [select for diffs], Fri May 31 04:21:29 2002 UTC (22 years ago) by pjanzen
Branch: MAIN
Changes since 1.13: +8 -8 lines
Diff to previous 1.13 (colored)

de-register

Revision 1.13 / (download) - annotate - [select for diffs], Fri May 31 03:40:00 2002 UTC (22 years ago) by pjanzen
Branch: MAIN
Changes since 1.12: +3 -7 lines
Diff to previous 1.12 (colored)

No dm -> no need to revoke setegid.

Revision 1.12 / (download) - annotate - [select for diffs], Mon Feb 18 06:45:26 2002 UTC (22 years, 3 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.11: +3 -3 lines
Diff to previous 1.11 (colored)

more signed char issues

Revision 1.11 / (download) - annotate - [select for diffs], Sat Jun 23 23:04:33 2001 UTC (22 years, 11 months ago) by pjanzen
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0
Changes since 1.10: +11 -5 lines
Diff to previous 1.10 (colored)

Make sure screen is big enough to play.

Revision 1.10 / (download) - annotate - [select for diffs], Sat Feb 17 23:00:05 2001 UTC (23 years, 3 months ago) by pjanzen
Branch: MAIN
CVS Tags: OPENBSD_2_9_BASE, OPENBSD_2_9
Changes since 1.9: +18 -17 lines
Diff to previous 1.9 (colored)

long usernames, and some -Wall-age

Revision 1.9 / (download) - annotate - [select for diffs], Fri Sep 8 02:23:11 2000 UTC (23 years, 9 months ago) by pjanzen
Branch: MAIN
CVS Tags: OPENBSD_2_8_BASE, OPENBSD_2_8
Changes since 1.8: +19 -14 lines
Diff to previous 1.8 (colored)

bools should only be TRUE or FALSE.  Negative numbers are right out.

Revision 1.8 / (download) - annotate - [select for diffs], Sun Jul 23 22:23:42 2000 UTC (23 years, 10 months ago) by pjanzen
Branch: MAIN
Changes since 1.7: +5 -2 lines
Diff to previous 1.7 (colored)

Handle EOF on stdin.

Revision 1.7 / (download) - annotate - [select for diffs], Thu Mar 12 09:03:49 1998 UTC (26 years, 3 months ago) by pjanzen
Branch: MAIN
CVS Tags: OPENBSD_2_7_BASE, OPENBSD_2_7, OPENBSD_2_6_BASE, OPENBSD_2_6, OPENBSD_2_5_BASE, OPENBSD_2_5, OPENBSD_2_4_BASE, OPENBSD_2_4, OPENBSD_2_3_BASE, OPENBSD_2_3
Changes since 1.6: +9 -4 lines
Diff to previous 1.6 (colored)

OpenBSD rscid and proper gid revoke (again)

Revision 1.6 / (download) - annotate - [select for diffs], Thu Mar 12 06:17:25 1998 UTC (26 years, 3 months ago) by pjanzen
Branch: MAIN
Changes since 1.5: +331 -196 lines
Diff to previous 1.5 (colored)

Bugfixes and strategical improvements

Revision 1.5 / (download) - annotate - [select for diffs], Wed Jul 23 20:04:49 1997 UTC (26 years, 10 months ago) by kstailey
Branch: MAIN
CVS Tags: OPENBSD_2_2_BASE, OPENBSD_2_2
Changes since 1.4: +6 -6 lines
Diff to previous 1.4 (colored)

tabify

Revision 1.4 / (download) - annotate - [select for diffs], Fri Feb 14 10:28:17 1997 UTC (27 years, 4 months ago) by niklas
Branch: MAIN
CVS Tags: OPENBSD_2_1_BASE, OPENBSD_2_1
Changes since 1.3: +6 -11 lines
Diff to previous 1.3 (colored)

Use standard header files instead of declaring system funcs explicitly

Revision 1.3 / (download) - annotate - [select for diffs], Sun Dec 22 20:01:00 1996 UTC (27 years, 5 months ago) by deraadt
Branch: MAIN
Changes since 1.2: +3 -1 lines
Diff to previous 1.2 (colored)

proper gid revoke

Revision 1.2 / (download) - annotate - [select for diffs], Thu Dec 19 22:21:13 1996 UTC (27 years, 5 months ago) by deraadt
Branch: MAIN
Changes since 1.1: +3 -1 lines
Diff to previous 1.1 (colored)

setgid games, not setuid games. closes a neat set of holes

Revision 1.1 / (download) - annotate - [select for diffs], Wed Aug 21 08:18:36 1996 UTC (27 years, 9 months ago) by downsj
Branch: MAIN
CVS Tags: OPENBSD_2_0_BASE, OPENBSD_2_0

battleships, from FreeBSD

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.