OpenBSD CVS

CVS log for src/games/factor/factor.c


[BACK] Up to [local] / src / games / factor

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.30 / (download) - annotate - [select for diffs], Thu Sep 1 10:48:38 2016 UTC (7 years, 9 months ago) by tb
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, HEAD
Changes since 1.29: +4 -4 lines
Diff to previous 1.29 (colored)

In 32 bits sqrt(val) + 1 can overflow, so some big primes still
aren't recognized as such, for example 18446744073709551577 given
in the commit message of factor.c r1.7 from NetBSD.  Move the
return type of usqrt() from u_int32_t to u_int64_t.

ok guenther, tom, otto

Revision 1.29 / (download) - annotate - [select for diffs], Sun Aug 14 18:34:48 2016 UTC (7 years, 9 months ago) by guenther
Branch: MAIN
Changes since 1.28: +3 -3 lines
Diff to previous 1.28 (colored)

Convert remaining calls to strtoq/strtouq in base with strtoll/strtoull.
Fix a type mismatch in ftp's "page" command and could make transfers restart
at the wrong position.

ok and a ull->ll tweak from natano@, ok tedu@

Revision 1.28 / (download) - annotate - [select for diffs], Mon Jul 11 18:30:21 2016 UTC (7 years, 11 months ago) by tb
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE, OPENBSD_6_0
Changes since 1.27: +38 -19 lines
Diff to previous 1.27 (colored)

Instead of using the floating point square root, use an integer version
of the Newton method from ping.c.  Fixes a rounding issue that caused
failure to factor numbers close to 2^64, e.g. 18446744030759878681.
While there, fix an off by one error that caused 4295360521 to be
reported as a prime.  Issues reported by Paul Stoeber and Michael Bozon.

ok tedu, deraadt

Revision 1.27 / (download) - annotate - [select for diffs], Mon Mar 7 12:07:56 2016 UTC (8 years, 3 months ago) by mestre
Branch: MAIN
Changes since 1.26: +4 -4 lines
Diff to previous 1.26 (colored)

- General changes:
- Remove -? from getopt(3) options, but still keep (or add) -h where applicable
- Replace hardcoded program strings by getprogname(3)

- Specific changes:
- atc(6): this used -? and -u for usage(), remove both from game and manpage
- bcd(6): use __progname instead of getprogname(3), no need to include stdlib.h
- hunt(6): replace fputs(3) by fprintf(3)

OK tb@ after his suggestions

Revision 1.26 / (download) - annotate - [select for diffs], Thu Jan 7 16:00:32 2016 UTC (8 years, 5 months ago) by tb
Branch: MAIN
CVS Tags: OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.25: +3 -3 lines
Diff to previous 1.25 (colored)

Some basic code maintenance in games/

- in main() replace exit with return
- drop some /* NOTREACHED */ lint comments along the way.
- make more use of standard CFLAGS, esp. -Wimplicit-function-declaration
- add and sort some headers when needed
- add straightforward pledges to some programs used at compile time

discussed with and ok mestre@

Revision 1.25 / (download) - annotate - [select for diffs], Mon Jan 4 11:58:35 2016 UTC (8 years, 5 months ago) by mestre
Branch: MAIN
Changes since 1.24: +2 -4 lines
Diff to previous 1.24 (colored)

More headers removal and sorted the remaining alphabetically.

Most noticeable that were removed are sys/types.h which will be included from
stdlib.h and in turn also brings along sys/cdefs.h. The other one is limits.h
that was used with the old idiom (denom * random() / LONG_MAX), although it was
only removed were applicable (some files still need that header).

OK tb@

Revision 1.24 / (download) - annotate - [select for diffs], Wed Dec 30 14:07:53 2015 UTC (8 years, 5 months ago) by tb
Branch: MAIN
Changes since 1.23: +4 -5 lines
Diff to previous 1.23 (colored)

Michal Mazurek pointed out on tech@ that the factor.6 manual needs a bit
of clarification.  Thus, express the description both more concisely and
more precisely.  Drop details about spaces in the output formatting.
While there, update the corresponding comment in the source code.

With input from jmc@ and mestre@; detailed discussion with sobrado@.

ok sobrado@

Revision 1.23 / (download) - annotate - [select for diffs], Fri Dec 25 20:59:09 2015 UTC (8 years, 5 months ago) by mestre
Branch: MAIN
Changes since 1.22: +2 -2 lines
Diff to previous 1.22 (colored)

Declare usage() functions as __dead void, if they don't return, on games section.

Found another one in arithmetic(6) which also didn't return, and removed a function from number(6) which is not used anymore.

OK tb@

Revision 1.22 / (download) - annotate - [select for diffs], Sat Oct 24 17:31:00 2015 UTC (8 years, 7 months ago) by mmcc
Branch: MAIN
Changes since 1.21: +3 -3 lines
Diff to previous 1.21 (colored)

Cast isblank()'s argument to unsigned char.

ok guenther@

Revision 1.21 / (download) - annotate - [select for diffs], Wed Oct 14 08:12:12 2015 UTC (8 years, 7 months ago) by doug
Branch: MAIN
Changes since 1.20: +4 -1 lines
Diff to previous 1.20 (colored)

Pledge "stdio" for simple games.

ok semarie@

Revision 1.20 / (download) - annotate - [select for diffs], Mon Sep 7 00:49:20 2015 UTC (8 years, 9 months ago) by tedu
Branch: MAIN
Changes since 1.19: +10 -6 lines
Diff to previous 1.19 (colored)

cosmetic fixes

Revision 1.19 / (download) - annotate - [select for diffs], Tue Oct 27 23:59:24 2009 UTC (14 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7, OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.18: +1 -15 lines
Diff to previous 1.18 (colored)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable).  these days, people use source.  these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Revision 1.18 / (download) - annotate - [select for diffs], Mon Mar 17 09:17:56 2008 UTC (16 years, 2 months ago) by sobrado
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4
Changes since 1.17: +4 -4 lines
Diff to previous 1.17 (colored)

synchronization between usage and synopsis; add some missing "usage:"'s

ok jmc@

Revision 1.17 / (download) - annotate - [select for diffs], Thu Sep 6 20:50:55 2007 UTC (16 years, 9 months ago) by chl
Branch: MAIN
CVS Tags: OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.16: +3 -4 lines
Diff to previous 1.16 (colored)

use strcspn to properly overwrite '\n' in fgets returned buffer

ok moritz@ ray@

Revision 1.16 / (download) - annotate - [select for diffs], Sun Mar 12 00:32:50 2006 UTC (18 years, 3 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_2_BASE, OPENBSD_4_2, OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0
Changes since 1.15: +3 -3 lines
Diff to previous 1.15 (colored)

exit code 1 on usage; adobriyan@gmail

Revision 1.15 / (download) - annotate - [select for diffs], Fri Jul 9 15:59:26 2004 UTC (19 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6
Changes since 1.14: +6 -10 lines
Diff to previous 1.14 (colored)

ansi; khalek@linuxgamers.net

Revision 1.14 / (download) - annotate - [select for diffs], Tue Jun 3 03:01:39 2003 UTC (21 years ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_5_BASE, OPENBSD_3_5, OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.13: +3 -7 lines
Diff to previous 1.13 (colored)

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999.  Proofed by myself and Theo.

Revision 1.13 / (download) - annotate - [select for diffs], Fri May 31 03:40:00 2002 UTC (22 years ago) by pjanzen
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3, OPENBSD_3_2_BASE, OPENBSD_3_2
Changes since 1.12: +2 -6 lines
Diff to previous 1.12 (colored)

No dm -> no need to revoke setegid.

Revision 1.12 / (download) - annotate - [select for diffs], Sat Feb 16 21:27:09 2002 UTC (22 years, 3 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.11: +5 -5 lines
Diff to previous 1.11 (colored)

Part one of userland __P removal.  Done with a simple regexp with some minor hand editing to make comments line up correctly.  Another pass is forthcoming that handles the cases that could not be done automatically.

Revision 1.11 / (download) - annotate - [select for diffs], Wed Oct 24 14:32:56 2001 UTC (22 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.10: +3 -3 lines
Diff to previous 1.10 (colored)

typo; ericyu@mail2000.com.tw

Revision 1.10 / (download) - annotate - [select for diffs], Sun Aug 19 23:19:46 2001 UTC (22 years, 9 months ago) by pjanzen
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0
Changes since 1.9: +106 -9 lines
Diff to previous 1.9 (colored)

If primes(6) will generate 32-bit primes, factor should factor 64-bit numbers.

Revision 1.9 / (download) - annotate - [select for diffs], Sun Aug 19 17:12:40 2001 UTC (22 years, 9 months ago) by pjanzen
Branch: MAIN
Changes since 1.8: +5 -5 lines
Diff to previous 1.8 (colored)

Use u_int32_t rather than unsigned long, both for platform invariance and
because the primes generation table really depends on there not being more
than 32 bits.

Revision 1.8 / (download) - annotate - [select for diffs], Sun Aug 19 15:22:43 2001 UTC (22 years, 9 months ago) by pjanzen
Branch: MAIN
Changes since 1.7: +7 -4 lines
Diff to previous 1.7 (colored)

remove extraneous newline from error output; PR 2014 and patch from
Tim J. Robbins <tim@robbins.dropbear.id.au>, with one line added so
that trailing whitespace doesn't make a number seem badly formatted.

Revision 1.7 / (download) - annotate - [select for diffs], Sun Sep 26 05:29:41 1999 UTC (24 years, 8 months ago) by pjanzen
Branch: MAIN
CVS Tags: OPENBSD_2_9_BASE, OPENBSD_2_9, OPENBSD_2_8_BASE, OPENBSD_2_8, OPENBSD_2_7_BASE, OPENBSD_2_7, OPENBSD_2_6_BASE, OPENBSD_2_6
Changes since 1.6: +3 -3 lines
Diff to previous 1.6 (colored)

Correct documentation:  rogoyski@cs.utexas.edu in PR 927.

Revision 1.6 / (download) - annotate - [select for diffs], Sat Sep 25 15:52:19 1999 UTC (24 years, 8 months ago) by pjanzen
Branch: MAIN
Changes since 1.5: +6 -6 lines
Diff to previous 1.5 (colored)

Tidying and minor changes from or based on jsm28@cam.ac.uk's work for the
Linux bsd-games package and NetBSD.  Mainly using 'const'.

Revision 1.5 / (download) - annotate - [select for diffs], Wed Aug 19 07:40:28 1998 UTC (25 years, 9 months ago) by pjanzen
Branch: MAIN
CVS Tags: OPENBSD_2_5_BASE, OPENBSD_2_5, OPENBSD_2_4_BASE, OPENBSD_2_4
Changes since 1.4: +4 -1 lines
Diff to previous 1.4 (colored)

tags, formatting, ANSI-fication, prototypes, de-typos, and the occasional
initialization, removal of unused variable, or other minor fix.  Most
changes are from or inspired by NetBSD.

Revision 1.4 / (download) - annotate - [select for diffs], Wed Jan 15 23:40:35 1997 UTC (27 years, 5 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_3_BASE, OPENBSD_2_3, OPENBSD_2_2_BASE, OPENBSD_2_2, OPENBSD_2_1_BASE, OPENBSD_2_1
Changes since 1.3: +1 -1 lines
Diff to previous 1.3 (colored)

getopt(3) returns -1 when out of args, not EOF, whee!

Revision 1.3 / (download) - annotate - [select for diffs], Sun Dec 22 20:01:12 1996 UTC (27 years, 5 months ago) by deraadt
Branch: MAIN
Changes since 1.2: +2 -0 lines
Diff to previous 1.2 (colored)

proper gid revoke

Revision 1.2 / (download) - annotate - [select for diffs], Thu Dec 19 22:21:26 1996 UTC (27 years, 5 months ago) by deraadt
Branch: MAIN
Changes since 1.1: +2 -0 lines
Diff to previous 1.1 (colored)

setgid games, not setuid games. closes a neat set of holes

Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Wed Oct 18 08:48:49 1995 UTC (28 years, 8 months ago) by deraadt
CVS Tags: netbsd_1_1, OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)

initial import of NetBSD tree

Revision 1.1 / (download) - annotate - [select for diffs], Wed Oct 18 08:48:49 1995 UTC (28 years, 8 months ago) by deraadt
Branch: MAIN

Initial revision

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.