OpenBSD CVS

CVS log for src/lib/libevent/buffer.c


[BACK] Up to [local] / src / lib / libevent

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.33 / (download) - annotate - [select for diffs], Tue Dec 27 23:05:55 2022 UTC (17 months, 1 week ago) by jmc
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, HEAD
Changes since 1.32: +2 -2 lines
Diff to previous 1.32 (colored)

spelling fixes; from paul tagliamonte
ok nicm

Revision 1.32 / (download) - annotate - [select for diffs], Fri May 3 16:31:34 2019 UTC (5 years, 1 month ago) by tobias
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.31: +3 -3 lines
Diff to previous 1.31 (colored)

Fixed endless loop/ OOB write on 64 bit systems with large buffers.

If a buffer exceeds UINT_MAX (which is only possible on 64 bit systems)
an endless loop or OOB write can occur in buffer-specific readline
functions.

Switching variables in function scope to size_t solves these issue because
relevant fields in struct buffer are already size_t.

ok cheloha, deraadt, nicm, tedu

Revision 1.31 / (download) - annotate - [select for diffs], Sat Mar 18 01:48:43 2017 UTC (7 years, 2 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1
Changes since 1.30: +3 -2 lines
Diff to previous 1.30 (colored)

Use recallocarray() to avoid leaving detritus in memory when resizing
the string buffer.
ok jsing millert

Revision 1.30 / (download) - annotate - [select for diffs], Sat Sep 3 11:31:17 2016 UTC (7 years, 9 months ago) by nayden
Branch: MAIN
Changes since 1.29: +2 -3 lines
Diff to previous 1.29 (colored)

Remove NULL pointer checks before calls to free().
OK bluhm@ nicm@

Revision 1.29 / (download) - annotate - [select for diffs], Thu Feb 5 12:59:57 2015 UTC (9 years, 4 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9, OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.28: +2 -2 lines
Diff to previous 1.28 (colored)

Include stdint.h, not limits.h to get SIZE_MAX.  OK guenther@

Revision 1.19.18.1 / (download) - annotate - [select for diffs], Wed Jan 7 20:12:02 2015 UTC (9 years, 5 months ago) by bluhm
Branch: OPENBSD_5_5
Changes since 1.19: +23 -9 lines
Diff to previous 1.19 (colored) next main 1.20 (colored)

Security fix for libevent 1.4 CVE-2014-6272 in 5.5-stable.
OK deraadt@

Revision 1.19.20.1 / (download) - annotate - [select for diffs], Wed Jan 7 20:05:46 2015 UTC (9 years, 5 months ago) by bluhm
Branch: OPENBSD_5_6
Changes since 1.19: +23 -9 lines
Diff to previous 1.19 (colored) next main 1.20 (colored)

Security fix for libevent 1.4 CVE-2014-6272 in 5.6-stable.
OK deraadt@

Revision 1.28 / (download) - annotate - [select for diffs], Mon Jan 5 23:14:36 2015 UTC (9 years, 5 months ago) by bluhm
Branch: MAIN
Changes since 1.27: +23 -9 lines
Diff to previous 1.27 (colored)

Fix CVE-2014-6272 in Libevent 1.4 from upstream:
- https://github.com/libevent/libevent/commit/7b21c4eabf1f3946d3f63cce1319c490caab8ecf
- For this fix, we need to make sure that passing too-large inputs to
  the evbuffer functions can't make us do bad things with the heap.
On top of that do:
- Update libevent version to 1.4.15-stable.
- Use SIZE_MAX from limits.h instead of a private define.
- Do not declare 'size_t need' twice to avoid a compiler warning.
OK sthen

Revision 1.27 / (download) - annotate - [select for diffs], Fri Nov 21 07:44:25 2014 UTC (9 years, 6 months ago) by dlg
Branch: MAIN
Changes since 1.26: +3 -3 lines
Diff to previous 1.26 (colored)

libraries shouldnt print to stderr when things dont go their way.

switch fprintf(stderr) over to event_warn() on malloc failure. fix
up an errant newline in an existing event_warn while there.

originally i just wanted to delete the fprintf
diff from nicm@ who is away from a keyboard right now so cant commit
guenther@ agrees with the idea

Revision 1.26 / (download) - annotate - [select for diffs], Thu Oct 30 16:45:37 2014 UTC (9 years, 7 months ago) by bluhm
Branch: MAIN
Changes since 1.25: +6 -6 lines
Diff to previous 1.25 (colored)

Fix whitespace errors in libevent.
OK nicm@

Revision 1.25 / (download) - annotate - [select for diffs], Wed Oct 29 22:47:29 2014 UTC (9 years, 7 months ago) by bluhm
Branch: MAIN
Changes since 1.24: +2 -3 lines
Diff to previous 1.24 (colored)

After removing all the #ifdef, the wrappers in evutil are rather
useless.  Let libevent call the libc functions directly.
OK nicm@

Revision 1.24 / (download) - annotate - [select for diffs], Sat Oct 18 21:56:44 2014 UTC (9 years, 7 months ago) by bluhm
Branch: MAIN
Changes since 1.23: +1 -6 lines
Diff to previous 1.23 (colored)

Remove some #ifdef from libevent.
OK nicm@

Revision 1.23 / (download) - annotate - [select for diffs], Sat Oct 18 16:48:28 2014 UTC (9 years, 7 months ago) by bluhm
Branch: MAIN
Changes since 1.22: +1 -6 lines
Diff to previous 1.22 (colored)

Remove the remaining #ifdef HAVE_ and the #define _GNU_SOURCE.
OK nicm@

Revision 1.22 / (download) - annotate - [select for diffs], Fri Oct 17 19:16:01 2014 UTC (9 years, 7 months ago) by bluhm
Branch: MAIN
Changes since 1.21: +2 -12 lines
Diff to previous 1.21 (colored)

Remove #ifdef HAVE_.*_H, just include the header files.
Do not include sys/param.h.
OK nicm@

Revision 1.21 / (download) - annotate - [select for diffs], Thu Oct 16 07:38:06 2014 UTC (9 years, 7 months ago) by bluhm
Branch: MAIN
Changes since 1.20: +1 -5 lines
Diff to previous 1.20 (colored)

Remove #ifdef HAVE_CONFIG_H, there is no config.h file.
OK nicm@

Revision 1.20 / (download) - annotate - [select for diffs], Wed Oct 8 20:14:19 2014 UTC (9 years, 8 months ago) by bluhm
Branch: MAIN
Changes since 1.19: +1 -19 lines
Diff to previous 1.19 (colored)

iRemove the #ifdef WIN32 implementation from libevent.
OK nicm@

Revision 1.19 / (download) - annotate - [select for diffs], Sat Jul 17 17:16:47 2010 UTC (13 years, 10 months ago) by chl
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_5_BASE, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8
Branch point for: OPENBSD_5_6, OPENBSD_5_5
Changes since 1.18: +2 -1 lines
Diff to previous 1.18 (colored)

add missing header needed by event_warn()

ok nicm@

Revision 1.18 / (download) - annotate - [select for diffs], Mon Jul 12 18:03:38 2010 UTC (13 years, 11 months ago) by nicm
Branch: MAIN
Changes since 1.17: +5 -3 lines
Diff to previous 1.17 (colored)

Update to 1.4.14b.

From their change log:
 o Fix memory-leak of signal handler array with kqueue. [backport]
 o Make evutil_make_socket_nonblocking() leave any other flags alone.
 o Adjusted fcntl() retval comparison on evutil_make_socket_nonblocking().
 o Re-add event_siglcb; some old code _was_ still using it. :(
 o Fix a free(NULL) in min_heap.h
 o Clean up properly when adding a signal handler fails.

Also a local change to use an int rather than a long for fcntl().

ok guenther deraadt

Revision 1.17 / (download) - annotate - [select for diffs], Wed Apr 21 20:02:40 2010 UTC (14 years, 1 month ago) by nicm
Branch: MAIN
Changes since 1.16: +112 -38 lines
Diff to previous 1.16 (colored)

Update libevent to 1.4.13.

This is the core library only, the DNS parts are removed and it does not
include the other extra bits (HTTP, DNS, and RPC), a separate port for
these will appear in due course.

Thanks to jsg, sthen, alek, gilles, jacekm, bernd and any others I've
forgotten for testing/comments.

Note that /usr/include/evdns.h should be removed after updating.

ok deraadt

Revision 1.16 / (download) - annotate - [select for diffs], Tue Oct 13 12:16:33 2009 UTC (14 years, 8 months ago) by jacekm
Branch: MAIN
CVS Tags: OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.15: +1 -2 lines
Diff to previous 1.15 (colored)

In evbuffer_readline, do not lose data upon malloc failure.  From mainstream:
http://levent.svn.sourceforge.net/viewvc/levent?view=rev&revision=1436
ok gilles@

Revision 1.15 / (download) - annotate - [select for diffs], Fri May 2 06:09:11 2008 UTC (16 years, 1 month ago) by brad
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4
Changes since 1.14: +13 -9 lines
Diff to previous 1.14 (colored)

Update to libevent 1.3e while retaining our local changes.

"No objection" millert@
"the diff looks and works fine" reyk@

Revision 1.14 / (download) - annotate - [select for diffs], Mon Mar 19 15:12:49 2007 UTC (17 years, 2 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_4_3_BASE, OPENBSD_4_3, OPENBSD_4_2_BASE, OPENBSD_4_2
Changes since 1.13: +11 -8 lines
Diff to previous 1.13 (colored)

Update to libevent-1.3b while retaining our local changes.  beck@ OK

Revision 1.13 / (download) - annotate - [select for diffs], Sun Feb 4 18:59:12 2007 UTC (17 years, 4 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_4_1_BASE, OPENBSD_4_1
Changes since 1.12: +5 -4 lines
Diff to previous 1.12 (colored)

Two libevent fixes from the SVN repo:
allow gotsig to terminate active event loop and evbuffer_find fix.
OK brad@ pyr@

Revision 1.12 / (download) - annotate - [select for diffs], Thu Dec 21 02:28:47 2006 UTC (17 years, 5 months ago) by krw
Branch: MAIN
Changes since 1.11: +2 -2 lines
Diff to previous 1.11 (colored)

'tranfer' -> 'transfer' in comments.

Revision 1.11 / (download) - annotate - [select for diffs], Sun Nov 26 15:25:14 2006 UTC (17 years, 6 months ago) by brad
Branch: MAIN
Changes since 1.10: +10 -4 lines
Diff to previous 1.10 (colored)

fix a potential problem in multiple handling of va_list; use va_copy instead.

From Niels Provos via the libevent SVN, by Alejo.

ok deraadt@

Revision 1.10 / (download) - annotate - [select for diffs], Sat Mar 18 20:23:42 2006 UTC (18 years, 2 months ago) by brad
Branch: MAIN
CVS Tags: OPENBSD_4_0_BASE, OPENBSD_4_0
Changes since 1.9: +18 -3 lines
Diff to previous 1.9 (colored)

- limit the amount of data bufferevents are going to consume to something
  reasonable; in some circumstances it could happen that libevent happily
  allocated 100MB in read buffers without telling the user; found by
  christopher maxwell - parts of these changes are from his patch.

- allow setting an event base for bufferevents; from phil oleson

- improved manpage from Phil Oleson

From libevent CVS

Revision 1.9 / (download) - annotate - [select for diffs], Wed Jan 25 05:25:33 2006 UTC (18 years, 4 months ago) by brad
Branch: MAIN
CVS Tags: OPENBSD_3_9_BASE, OPENBSD_3_9
Changes since 1.8: +3 -3 lines
Diff to previous 1.8 (colored)

another fix from art.

From libevent CVS

Revision 1.8 / (download) - annotate - [select for diffs], Mon Jan 23 20:18:20 2006 UTC (18 years, 4 months ago) by brad
Branch: MAIN
Changes since 1.7: +36 -28 lines
Diff to previous 1.7 (colored)

add evbuffer_add_vprintf interface from artur grabowski

From libevent CVS

ok markus@

Revision 1.7 / (download) - annotate - [select for diffs], Sat Jul 2 07:15:13 2005 UTC (18 years, 11 months ago) by grunk
Branch: MAIN
CVS Tags: OPENBSD_3_8_BASE, OPENBSD_3_8
Changes since 1.6: +3 -3 lines
Diff to previous 1.6 (colored)

zap trailing whitespaces, no binary change

ok brad@ beck@

Revision 1.6 / (download) - annotate - [select for diffs], Sat Jun 18 01:52:22 2005 UTC (18 years, 11 months ago) by brad
Branch: MAIN
Changes since 1.5: +4 -4 lines
Diff to previous 1.5 (colored)

update to libevent 1.1a; keep local changes

ok grunk@

Revision 1.5 / (download) - annotate - [select for diffs], Wed May 4 03:17:48 2005 UTC (19 years, 1 month ago) by brad
Branch: MAIN
Changes since 1.4: +49 -2 lines
Diff to previous 1.4 (colored)

update to libevent 1.0d; keep local changes

thanks to Alexander von Gernler for testing
and some bug fixes

ok mpf@ norby@

Revision 1.4 / (download) - annotate - [select for diffs], Fri Apr 22 00:56:25 2005 UTC (19 years, 1 month ago) by brad
Branch: MAIN
Changes since 1.3: +179 -23 lines
Diff to previous 1.3 (colored)

update to libevent 1.0c; keep local changes

no shared lib so no ABI/API check is necessary

thanks to Alexander von Gernler for submitting
another diff in an attempt to update libevent
and for a use-after-free fix.

ok henning@ deraadt@

Revision 1.3 / (download) - annotate - [select for diffs], Tue Apr 19 08:07:45 2005 UTC (19 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.2: +22 -178 lines
Diff to previous 1.2 (colored)

backout.  not discussed, and very wrong.  bad brad

Revision 1.2 / (download) - annotate - [select for diffs], Tue Apr 19 02:03:12 2005 UTC (19 years, 1 month ago) by brad
Branch: MAIN
Changes since 1.1: +179 -23 lines
Diff to previous 1.1 (colored)

update to libevent 1.0c; keep local changes

Revision 1.1 / (download) - annotate - [select for diffs], Wed Apr 28 06:53:12 2004 UTC (20 years, 1 month ago) by brad
Branch: MAIN
CVS Tags: OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6

update to libevent 0.8; keep local changes

ok markus@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.