OpenBSD CVS

CVS log for src/lib/libssl/d1_lib.c


[BACK] Up to [local] / src / lib / libssl

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.64 / (download) - annotate - [select for diffs], Sat Nov 26 16:08:55 2022 UTC (18 months, 2 weeks ago) by tb
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, HEAD
Changes since 1.63: +3 -3 lines
Diff to previous 1.63 (colored)

Make internal header file names consistent

Libcrypto currently has a mess of *_lcl.h, *_locl.h, and *_local.h names
used for internal headers. Move all these headers we inherited from
OpenSSL to *_local.h, reserving the name *_internal.h for our own code.
Similarly, move dtls_locl.h and ssl_locl.h to dtls_local and ssl_local.h.
constant_time_locl.h is moved to constant_time.h since it's special.

Adjust all .c files in libcrypto, libssl and regress.

The diff is mechanical with the exception of tls13_quic.c, where
#include <ssl_locl.h> was fixed manually.

discussed with jsing,
no objection bcook

Revision 1.63 / (download) - annotate - [select for diffs], Fri Nov 11 17:15:26 2022 UTC (18 months, 4 weeks ago) by jsing
Branch: MAIN
Changes since 1.62: +19 -2 lines
Diff to previous 1.62 (colored)

Convert the legacy TLS stack to tls_content.

This converts the legacy TLS stack to tls_content - records are now
opened into a tls_content structure, rather than being written back into
the same buffer that the sealed record was read into.

This will allow for further clean up of the legacy record layer.

ok tb@

Revision 1.62 / (download) - annotate - [select for diffs], Sun Oct 2 16:36:41 2022 UTC (20 months, 1 week ago) by jsing
Branch: MAIN
Changes since 1.61: +2 -2 lines
Diff to previous 1.61 (colored)

Get rid of SSL_CTX_INTERNAL and SSL_INTERNAL.

These are no longer necessary due to SSL_CTX and SSL now being fully
opaque. Merge SSL_CTX_INTERNAL back into SSL_CTX and SSL_INTERNAL back
into SSL.

Prompted by tb@

Revision 1.61 / (download) - annotate - [select for diffs], Sat Oct 23 13:36:03 2021 UTC (2 years, 7 months ago) by jsing
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1
Changes since 1.60: +30 -40 lines
Diff to previous 1.60 (colored)

Fold DTLS1_STATE_INTERNAL into DTLS1_STATE.

Now that DTLS1_STATE is opaque, fold DTLS1_STATE_INTERNAL back into
DTLS1_STATE and remove D1I() usage.

ok tb@

Revision 1.60 / (download) - annotate - [select for diffs], Thu Oct 21 08:30:14 2021 UTC (2 years, 7 months ago) by tb
Branch: MAIN
Changes since 1.59: +7 -2 lines
Diff to previous 1.59 (colored)

Avoid potential NULL dereferences in dtls1_free()

ok jsing

Revision 1.59 / (download) - annotate - [select for diffs], Mon Aug 30 19:12:25 2021 UTC (2 years, 9 months ago) by jsing
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0
Changes since 1.58: +3 -5 lines
Diff to previous 1.58 (colored)

Replace DTLS r_epoch with the read epoch from the TLSv1.2 record layer.

ok inoguchi@ tb@

Revision 1.58 / (download) - annotate - [select for diffs], Wed Jul 21 08:42:14 2021 UTC (2 years, 10 months ago) by jsing
Branch: MAIN
Changes since 1.57: +1 -9 lines
Diff to previous 1.57 (colored)

Remove DTLS processed_rcds queue.

When DTLS handshake records are received from the next epoch, we will
potentially queue them on the unprocessed_rcds queue - this is usually
a Finished message that has been received without the ChangeCipherSuite
(CCS) message (which may have been dropped or reordered).

After the epoch increments (due to the CCS being received), the current
code processes all records on the unprocessed queue and immediate queues
them on the processed queue, which dtls1_get_record() then pulls from.
This form of processing only adds more complexity and another queue.

Instead, once the epoch increments, pull a single record from the
unprocessed queue and process it, allowing the contents to be consumed
by the caller. We repeat this process until the unprocessed queue is
empty, at which point we go back to consuming messages from the wire.

ok inoguchi@ tb@

Revision 1.57 / (download) - annotate - [select for diffs], Thu Jul 1 17:53:39 2021 UTC (2 years, 11 months ago) by jsing
Branch: MAIN
Changes since 1.56: +2 -2 lines
Diff to previous 1.56 (colored)

Merge SSL_METHOD_INTERNAL into SSL_METHOD.

Now that SSL_METHOD is opaque and in internal headers, we can remove
SSL_METHOD_INTERNAL by merging it back into SSL_METHOD.

ok tb@

Revision 1.56 / (download) - annotate - [select for diffs], Sat Jun 19 16:52:47 2021 UTC (2 years, 11 months ago) by jsing
Branch: MAIN
Changes since 1.55: +4 -1 lines
Diff to previous 1.55 (colored)

Provide the ability to set the initial DTLS epoch value.

This allows for regress to test edge cases for epoch handling.

ok tb@

Revision 1.55 / (download) - annotate - [select for diffs], Sat Jun 19 16:38:27 2021 UTC (2 years, 11 months ago) by jsing
Branch: MAIN
Changes since 1.54: +4 -1 lines
Diff to previous 1.54 (colored)

Initialise the epoch for the DTLS processed and unprocessed queues.

Currently these only get correctly initialised when
dtls1_process_buffered_records() is called - while this works it is more
accidental than intentional.

ok tb@

Revision 1.54 / (download) - annotate - [select for diffs], Sun May 16 13:56:30 2021 UTC (3 years ago) by jsing
Branch: MAIN
Changes since 1.53: +2 -1 lines
Diff to previous 1.53 (colored)

Move DTLS structs/definitions/prototypes to dtls_locl.h.

Now that the DTLS structs are opaque, add a dtls_locl.h header and move
internal-only structs from dtls1.h, along with prototypes from ssl_locl.h.
Only pull this header in where DTLS code actually exists.

ok inoguchi@ tb@

Revision 1.53 / (download) - annotate - [select for diffs], Sat Feb 20 07:29:07 2021 UTC (3 years, 3 months ago) by jsing
Branch: MAIN
CVS Tags: OPENBSD_6_9_BASE, OPENBSD_6_9
Changes since 1.52: +8 -7 lines
Diff to previous 1.52 (colored)

Clean up/simplify dtls1_get_cipher().

ok tb@

Revision 1.52 / (download) - annotate - [select for diffs], Thu Jan 21 18:48:56 2021 UTC (3 years, 4 months ago) by jsing
Branch: MAIN
Changes since 1.51: +1 -22 lines
Diff to previous 1.51 (colored)

Mop up unused dtls1_build_sequence_number() function.

Revision 1.51 / (download) - annotate - [select for diffs], Sat Oct 3 17:54:27 2020 UTC (3 years, 8 months ago) by jsing
Branch: MAIN
Changes since 1.50: +1 -5 lines
Diff to previous 1.50 (colored)

Use TLSv1_1_enc_data instead of DTLSv1_enc_data.

DTLSv1 is TLSv1.1 over datagrams - there is no need for a separate
SSL3_ENC_METHOD struct, just use TLSv1_1_enc_data and remove
DTLSv1_enc_data entirely.

ok tb@

Revision 1.50 / (download) - annotate - [select for diffs], Sat Sep 26 14:43:17 2020 UTC (3 years, 8 months ago) by jsing
Branch: MAIN
CVS Tags: OPENBSD_6_8_BASE, OPENBSD_6_8
Changes since 1.49: +4 -5 lines
Diff to previous 1.49 (colored)

Call dtls1_hm_fragment_free() from dtls1_drain_fragments()

Currently dtls1_drain_fragments() has a incomplete handrolled version of
dtls1_hm_fragment_free(), which has the potential to leak memory. Replace
the handrolled free with a call to dtls1_hm_fragment_free().

ok inoguchi@ tb@

Revision 1.49 / (download) - annotate - [select for diffs], Sat Sep 26 09:01:05 2020 UTC (3 years, 8 months ago) by jsing
Branch: MAIN
Changes since 1.48: +25 -39 lines
Diff to previous 1.48 (colored)

Have dtls1_new() call dtls1_free() on failure.

Allocate into the appropriate structures and call dtls1_free() on failure,
rather than allocating into local variables and then remembering to free
various things on failure.

ok tb@

Revision 1.48 / (download) - annotate - [select for diffs], Sat Sep 26 07:36:51 2020 UTC (3 years, 8 months ago) by tb
Branch: MAIN
Changes since 1.47: +26 -25 lines
Diff to previous 1.47 (colored)

Refactor dtls1_clear_queues()

An upcoming cleanup diff by jsing needs dtls1_clear_queues() to be
able to handle NULL pqueues. While one can easily add a NULL check
to pqueue_pop(), this does not really fit in with the rest of the
code. There are two kinds of while loops in dtls1_clear_queues that
drain pqueues, so add two helper functions with a NULL check each.

ok jsing

Revision 1.47 / (download) - annotate - [select for diffs], Thu Sep 24 17:59:54 2020 UTC (3 years, 8 months ago) by jsing
Branch: MAIN
Changes since 1.46: +4 -4 lines
Diff to previous 1.46 (colored)

Release read and write buffers using freezero().

Provide a ssl3_release_buffer() function that correctly frees a buffer
and call it from the appropriate locations. While here also change
ssl3_release_{read,write}_buffer() to void since they cannot fail and
no callers check the return value currently.

ok beck@ inoguchi@ tb@

Revision 1.46 / (download) - annotate - [select for diffs], Tue Jul 7 19:31:11 2020 UTC (3 years, 11 months ago) by jsing
Branch: MAIN
Changes since 1.45: +1 -9 lines
Diff to previous 1.45 (colored)

Remove some unnecessary function pointers from SSL_METHOD_INTERNAL.

ssl_version is completely unused and get_timeout is the same everywhere.

ok beck@ inoguchi@ tb@

Revision 1.45 / (download) - annotate - [select for diffs], Thu Mar 12 17:01:53 2020 UTC (4 years, 3 months ago) by jsing
Branch: MAIN
CVS Tags: OPENBSD_6_7_BASE, OPENBSD_6_7
Changes since 1.44: +5 -5 lines
Diff to previous 1.44 (colored)

Use internal versions of SSL3_BUFFER, SSL3_RECORD and DTLS1_RECORD_DATA.

SSL3_BUFFER, SSL3_RECORD and DTLS1_RECORD_DATA are currently still in
public headers, even though their usage is internal. This moves to
using _INTERNAL suffixed versions that are in internal headers, which
then allows us to change them without any potential public API fallout.

ok inoguchi@ tb@

Revision 1.44 / (download) - annotate - [select for diffs], Tue Mar 10 17:02:21 2020 UTC (4 years, 3 months ago) by jsing
Branch: MAIN
Changes since 1.43: +1 -2 lines
Diff to previous 1.43 (colored)

Remove the enc function pointers.

The enc function pointers do not serve any purpose these days - remove
a layer of indirection and call dtls1_enc()/tls1_enc() directly.

ok inoguchi@ tb@

Revision 1.43 / (download) - annotate - [select for diffs], Fri Feb 21 16:12:18 2020 UTC (4 years, 3 months ago) by jsing
Branch: MAIN
Changes since 1.42: +15 -7 lines
Diff to previous 1.42 (colored)

Convert dtls1_build_sequence_number() to CBB.

ok inoguchi@ tb@

Revision 1.42 / (download) - annotate - [select for diffs], Mon Apr 10 17:27:33 2017 UTC (7 years, 2 months ago) by jsing
Branch: MAIN
CVS Tags: OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2
Changes since 1.41: +3 -6 lines
Diff to previous 1.41 (colored)

Use freezero() for the internal opaque structures, instead of the current
explicit_bzero()/free(). Less code and potentially less overhead.

Revision 1.41 / (download) - annotate - [select for diffs], Tue Feb 7 02:08:38 2017 UTC (7 years, 4 months ago) by beck
Branch: MAIN
CVS Tags: OPENBSD_6_1_BASE, OPENBSD_6_1
Changes since 1.40: +2 -2 lines
Diff to previous 1.40 (colored)

Change SSLerror() back to taking two args, with the first one being an SSL *.
Make a table of "function codes" which maps the internal state of the SSL *
to something like a useful name so in a typical error in the connection you
know in what sort of place in the handshake things happened. (instead of
by arcane function name).
Add SSLerrorx() for when we don't have an SSL *
ok jsing@ after us both being prodded by bluhm@ to make it not terrible

Revision 1.40 / (download) - annotate - [select for diffs], Thu Jan 26 10:40:21 2017 UTC (7 years, 4 months ago) by beck
Branch: MAIN
Changes since 1.39: +2 -2 lines
Diff to previous 1.39 (colored)

Send the error function codes to rot in the depths of hell where they belong
We leave a single funciton code (0xFFF) to say "SSL_internal" so the public
API will not break, and we replace all internal use of the two argument
SSL_err() with the internal only SSL_error() that only takes a reason code.
ok jsing@

Revision 1.39 / (download) - annotate - [select for diffs], Thu Jan 26 06:32:58 2017 UTC (7 years, 4 months ago) by jsing
Branch: MAIN
Changes since 1.38: +1 -14 lines
Diff to previous 1.38 (colored)

Remove most of SSL3_ENC_METHOD - we can just inline the function calls
and defines since they are the same everywhere.

ok beck@

Revision 1.38 / (download) - annotate - [select for diffs], Wed Jan 25 06:38:01 2017 UTC (7 years, 4 months ago) by jsing
Branch: MAIN
Changes since 1.37: +2 -2 lines
Diff to previous 1.37 (colored)

Change the SSL_IS_DTLS() macro to check the version, rather than using a
flag in the encryption methods. We can do this since there is currently
only one DTLS version. This makes upcoming changes easier.

ok beck@

Revision 1.37 / (download) - annotate - [select for diffs], Mon Jan 23 13:36:13 2017 UTC (7 years, 4 months ago) by jsing
Branch: MAIN
Changes since 1.36: +2 -2 lines
Diff to previous 1.36 (colored)

Split most of SSL_METHOD out into an internal variant, which is opaque.

Discussed with beck@

Revision 1.36 / (download) - annotate - [select for diffs], Sun Jan 22 07:16:38 2017 UTC (7 years, 4 months ago) by beck
Branch: MAIN
Changes since 1.35: +42 -42 lines
Diff to previous 1.35 (colored)

Move most of DTLS1_STATE to internal.
ok jsing@

Revision 1.35 / (download) - annotate - [select for diffs], Sun Jan 22 03:50:45 2017 UTC (7 years, 4 months ago) by jsing
Branch: MAIN
Changes since 1.34: +17 -4 lines
Diff to previous 1.34 (colored)

Convert publically visible structs to translucent structs.

This change adds an internal opaque struct for each of the significant
publically visible structs. The opaque struct is then allocated and
attached to the publically visible struct when the appropriate *_new()
function is called, then cleared and freed as necessary.

This will allow for changes to be made to the internals of libssl, without
requiring a major bump each time the publically visible structs are
modified.

ok beck@

Revision 1.34 / (download) - annotate - [select for diffs], Fri Nov 4 18:33:11 2016 UTC (7 years, 7 months ago) by guenther
Branch: MAIN
Changes since 1.33: +2 -2 lines
Diff to previous 1.33 (colored)

Mark a couple local functions as static

ok jsing@ beck@

Revision 1.33 / (download) - annotate - [select for diffs], Mon Feb 29 06:48:03 2016 UTC (8 years, 3 months ago) by mmcc
Branch: MAIN
Changes since 1.32: +6 -11 lines
Diff to previous 1.32 (colored)

remove NULL checks for pqueue_free()

ok doug@

Revision 1.32 / (download) - annotate - [select for diffs], Wed Oct 7 13:20:48 2015 UTC (8 years, 8 months ago) by bcook
Branch: MAIN
Changes since 1.31: +2 -1 lines
Diff to previous 1.31 (colored)

include <sys/time.h> for gettimeofday(2)

Revision 1.31 / (download) - annotate - [select for diffs], Thu Sep 10 17:57:50 2015 UTC (8 years, 9 months ago) by jsing
Branch: MAIN
Changes since 1.30: +3 -5 lines
Diff to previous 1.30 (colored)

Remove support for DTLS_BAD_VER. We do not support non-standard and
incomplete implementations just so that we can interoperate with products
from vendors who have not bothered to fix things in the last ~10 years.

ok bcook@ miod@

Revision 1.30 / (download) - annotate - [select for diffs], Thu Sep 10 15:56:26 2015 UTC (8 years, 9 months ago) by jsing
Branch: MAIN
Changes since 1.29: +2 -2 lines
Diff to previous 1.29 (colored)

Correct spelling of OPENSSL_cleanse.

ok miod@

Revision 1.29 / (download) - annotate - [select for diffs], Sun Jul 19 20:32:18 2015 UTC (8 years, 10 months ago) by doug
Branch: MAIN
Changes since 1.28: +4 -1 lines
Diff to previous 1.28 (colored)

Allow *_free() functions in libssl to handle NULL input.

This mimics free()'s behavior which makes error handling simpler.

ok bcook@ miod@

Revision 1.24.4.1 / (download) - annotate - [select for diffs], Thu Mar 19 14:02:23 2015 UTC (9 years, 2 months ago) by tedu
Changes since 1.24: +4 -1 lines
Diff to previous 1.24 (colored) next main 1.25 (colored)

Fix several crash causing defects from OpenSSL.
These include:
CVE-2015-0209 - Use After Free following d2i_ECPrivatekey error
CVE-2015-0286 - Segmentation fault in ASN1_TYPE_cmp
CVE-2015-0287 - ASN.1 structure reuse memory corruption
CVE-2015-0288 - X509_to_X509_REQ NULL pointer deref
CVE-2015-0289 - PKCS7 NULL pointer dereferences

Several other issues did not apply or were already fixed.
Refer to https://www.openssl.org/news/secadv_20150319.txt

joint work with beck, doug, guenther, jsing, miod

Revision 1.27.4.1 / (download) - annotate - [select for diffs], Thu Mar 19 14:01:16 2015 UTC (9 years, 2 months ago) by tedu
Changes since 1.27: +4 -1 lines
Diff to previous 1.27 (colored) next main 1.28 (colored)

Fix several crash causing defects from OpenSSL.
These include:
CVE-2015-0209 - Use After Free following d2i_ECPrivatekey error
CVE-2015-0286 - Segmentation fault in ASN1_TYPE_cmp
CVE-2015-0287 - ASN.1 structure reuse memory corruption
CVE-2015-0288 - X509_to_X509_REQ NULL pointer deref
CVE-2015-0289 - PKCS7 NULL pointer dereferences

Several other issues did not apply or were already fixed.
Refer to https://www.openssl.org/news/secadv_20150319.txt

joint work with beck, doug, guenther, jsing, miod

Revision 1.28 / (download) - annotate - [select for diffs], Thu Mar 19 14:00:22 2015 UTC (9 years, 2 months ago) by tedu
Branch: MAIN
Changes since 1.27: +4 -1 lines
Diff to previous 1.27 (colored)

Fix several crash causing defects from OpenSSL.
These include:
CVE-2015-0209 - Use After Free following d2i_ECPrivatekey error
CVE-2015-0286 - Segmentation fault in ASN1_TYPE_cmp
CVE-2015-0287 - ASN.1 structure reuse memory corruption
CVE-2015-0289 - PKCS7 NULL pointer dereferences

Several other issues did not apply or were already fixed.
Refer to https://www.openssl.org/news/secadv_20150319.txt

joint work with beck, doug, guenther, jsing, miod

Revision 1.27 / (download) - annotate - [select for diffs], Mon Feb 9 10:53:28 2015 UTC (9 years, 4 months ago) by jsing
Branch: MAIN
Changes since 1.26: +1 -8 lines
Diff to previous 1.26 (colored)

Jettison DTLS over SCTP.

OpenBSD does not have SCTP support and it sees little use in the wild.
OPENSSL_NO_SCTP is already specified via opensslfeatures.h, hence this
is a code removal only and symbols should remain unchanged.

ok beck@ miod@ tedu@

Revision 1.26 / (download) - annotate - [select for diffs], Sun Dec 14 15:30:50 2014 UTC (9 years, 5 months ago) by jsing
Branch: MAIN
Changes since 1.25: +4 -4 lines
Diff to previous 1.25 (colored)

Remove trailing whitespace.

Revision 1.25 / (download) - annotate - [select for diffs], Sun Nov 16 14:12:47 2014 UTC (9 years, 6 months ago) by jsing
Branch: MAIN
Changes since 1.24: +2 -1 lines
Diff to previous 1.24 (colored)

Sort and group includes.

Revision 1.24 / (download) - annotate - [select for diffs], Thu Jul 17 23:48:24 2014 UTC (9 years, 10 months ago) by deraadt
Branch: MAIN
Changes since 1.23: +2 -2 lines
Diff to previous 1.23 (colored)

avoid sys/param.h; Jonas Termansen

Revision 1.23 / (download) - annotate - [select for diffs], Fri Jul 11 13:09:04 2014 UTC (9 years, 11 months ago) by miod
Branch: MAIN
Changes since 1.22: +4 -4 lines
Diff to previous 1.22 (colored)

In dtls1_clear_queues(), free buffered_add_data.q correctly, it's made of
DTLS1_RECORD_DATA, not hm_fragment.

OpenSSL PR #3286 via OpenSSL trunk.

Revision 1.22 / (download) - annotate - [select for diffs], Wed Jul 9 11:10:51 2014 UTC (9 years, 11 months ago) by bcook
Branch: MAIN
Changes since 1.21: +1 -2 lines
Diff to previous 1.21 (colored)

remove unused, private version strings except SSL_version_str

Also remove unused des_ver.h, which exports some of these strings, but is not installed.

ok miod@ tedu@

Revision 1.21 / (download) - annotate - [select for diffs], Sat Jun 21 17:02:25 2014 UTC (9 years, 11 months ago) by jsing
Branch: MAIN
Changes since 1.20: +14 -1 lines
Diff to previous 1.20 (colored)

Pull the code that builds a DTLS sequence number out into its own function
to avoid duplication. Also use fewer magic numbers.

ok miod@

Revision 1.20 / (download) - annotate - [select for diffs], Fri Jun 13 04:29:13 2014 UTC (10 years ago) by miod
Branch: MAIN
Changes since 1.19: +3 -1 lines
Diff to previous 1.19 (colored)

Remove support for the `opaque PRF input' extension, which draft has expired
7 years ago and never made it into an RFC. That code wasn't compiled in
anyway unless one would define the actual on-the-wire extension id bytes;
crank libssl major.

With help and enlightenment from Brendan MacDonell.

Revision 1.19 / (download) - annotate - [select for diffs], Thu Jun 12 15:49:31 2014 UTC (10 years ago) by deraadt
Branch: MAIN
Changes since 1.18: +1 -1 lines
Diff to previous 1.18 (colored)

tags as requested by miod and tedu

Revision 1.18 / (download) - annotate - [select for diffs], Wed Jun 11 13:19:53 2014 UTC (10 years ago) by logan
Branch: MAIN
Changes since 1.17: +3 -1 lines
Diff to previous 1.17 (colored)

Fix memory leak: free s if calloc fails.

(From Jonas Maebe)

OK from beck@

Revision 1.17 / (download) - annotate - [select for diffs], Thu May 29 16:00:16 2014 UTC (10 years ago) by jsing
Branch: MAIN
Changes since 1.16: +1 -0 lines
Diff to previous 1.16 (colored)

Make it substantially easier to identify protocol version requirements
by adding an enc_flags field to the ssl3_enc_method, specifying four flags
that are used with this field and providing macros for evaluating these
conditions. Currently the version requirements are identified by
continually checking the version number and other criteria.

This change also adds separate SSL3_ENC_METHOD data for TLS v1.1 and v1.2,
since they have different enc_flags from TLS v1.

Based on changes in OpenSSL head.

No objection from miod@

Revision 1.16 / (download) - annotate - [select for diffs], Wed May 28 13:03:24 2014 UTC (10 years ago) by jsing
Branch: MAIN
Changes since 1.15: +2 -6 lines
Diff to previous 1.15 (colored)

There is no point in checking if a pointer is non-NULL before calling free,
since free already does this for us. Also remove some pointless NULL
assignments, where the result from malloc(3) is immediately assigned to the
same variable.

ok miod@

Revision 1.15 / (download) - annotate - [select for diffs], Mon May 26 12:11:38 2014 UTC (10 years ago) by deraadt
Branch: MAIN
Changes since 1.14: +10 -6 lines
Diff to previous 1.14 (colored)

repair some KNF missed by the script; ok jsing

Revision 1.14 / (download) - annotate - [select for diffs], Sat May 24 16:06:28 2014 UTC (10 years ago) by jsing
Branch: MAIN
Changes since 1.13: +14 -12 lines
Diff to previous 1.13 (colored)

Use C99 initialisers for SSL3_ENC_METHOD structs.

ok miod@

Revision 1.13 / (download) - annotate - [select for diffs], Thu May 22 17:37:06 2014 UTC (10 years ago) by jsing
Branch: MAIN
Changes since 1.12: +2 -0 lines
Diff to previous 1.12 (colored)

Stop pulling pqueue.h into ssl_locl.h since only a small part of libssl
actually needs it. Instead, just include it in the files where it is
actually necessary.

Also remove standard includes from pqueue.h so that they are not available
as a side effect. Just add the two includes that are needed to pqueue.c.

ok miod@

Revision 1.12 / (download) - annotate - [select for diffs], Sun Apr 20 14:14:52 2014 UTC (10 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.11: +2 -9 lines
Diff to previous 1.11 (colored)

gettimeofday() is portable enough and does not need a wrapper

Revision 1.11 / (download) - annotate - [select for diffs], Sun Apr 20 14:03:55 2014 UTC (10 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.10: +2 -2 lines
Diff to previous 1.10 (colored)

calloc() rather than malloc+memset

Revision 1.10 / (download) - annotate - [select for diffs], Sat Apr 19 08:52:32 2014 UTC (10 years, 1 month ago) by guenther
Branch: MAIN
Changes since 1.9: +2 -2 lines
Diff to previous 1.9 (colored)

More KNF and style consistency tweaks

Revision 1.9 / (download) - annotate - [select for diffs], Thu Apr 17 13:37:49 2014 UTC (10 years, 1 month ago) by beck
Branch: MAIN
Changes since 1.8: +13 -13 lines
Diff to previous 1.8 (colored)

Change library to use intrinsic memory allocation functions instead of
OPENSSL_foo wrappers. This changes:
OPENSSL_malloc->malloc
OPENSSL_free->free
OPENSSL_relloc->realloc
OPENSSL_freeFunc->free

Revision 1.8 / (download) - annotate - [select for diffs], Mon Apr 14 18:45:55 2014 UTC (10 years, 1 month ago) by tedu
Branch: MAIN
Changes since 1.7: +0 -7 lines
Diff to previous 1.7 (colored)

make OPENSSL_NO_HEARTBLEED the default and only option. ok deraadt miod

Revision 1.7 / (download) - annotate - [select for diffs], Mon Apr 14 14:16:33 2014 UTC (10 years, 1 month ago) by jsing
Branch: MAIN
Changes since 1.6: +179 -183 lines
Diff to previous 1.6 (colored)

First pass at applying KNF to the OpenSSL code, which almost makes it
readable. This pass is whitespace only and can readily be verified using
tr and md5.

Revision 1.6 / (download) - annotate - [select for diffs], Mon Apr 14 11:08:35 2014 UTC (10 years, 2 months ago) by mpi
Branch: MAIN
Changes since 1.5: +292 -27 lines
Diff to previous 1.5 (colored)

Revert previous.  I don't known why cvs blame tells me I committed this,
but after cross-checking with 1.0.1g sources, they are not coming from
my change.

Revision 1.5 / (download) - annotate - [select for diffs], Mon Apr 14 10:49:12 2014 UTC (10 years, 2 months ago) by mpi
Branch: MAIN
Changes since 1.4: +27 -292 lines
Diff to previous 1.4 (colored)

Revert to 1.1 minus the VMS stuff, I accidentally committed this chunk
in my last change.

Revision 1.4 / (download) - annotate - [select for diffs], Sun Apr 13 22:37:35 2014 UTC (10 years, 2 months ago) by beck
Branch: MAIN
Changes since 1.3: +0 -6 lines
Diff to previous 1.3 (colored)

Fix the gettimeofday function that I broke with my last commit.
noticed by mattheew and deraadt
ok deraadt@

Revision 1.3 / (download) - annotate - [select for diffs], Sun Apr 13 22:11:45 2014 UTC (10 years, 2 months ago) by beck
Branch: MAIN
Changes since 1.2: +0 -10 lines
Diff to previous 1.2 (colored)

Remove vms support stuff.
ok deraadt@

Revision 1.2 / (download) - annotate - [select for diffs], Sun Apr 13 21:11:19 2014 UTC (10 years, 2 months ago) by mpi
Branch: MAIN
Changes since 1.1: +308 -31 lines
Diff to previous 1.1 (colored)

Do not include "e_os.h" anymore.  Simply pull in the necessary headers.

ok miod@, deraadt@

Revision 1.1.1.7 / (download) - annotate - [select for diffs] (vendor branch), Sun Apr 13 15:16:36 2014 UTC (10 years, 2 months ago) by miod
Changes since 1.1.1.6: +1 -0 lines
Diff to previous 1.1.1.6 (colored)

Import OpenSSL 1.0.1g

Revision 1.1.1.6 / (download) - annotate - [select for diffs] (vendor branch), Sat Oct 13 21:23:49 2012 UTC (11 years, 8 months ago) by djm
Changes since 1.1.1.5: +43 -11 lines
Diff to previous 1.1.1.5 (colored)

import OpenSSL-1.0.1c

Revision 1.1.1.5 / (download) - annotate - [select for diffs] (vendor branch), Thu Jan 5 22:59:08 2012 UTC (12 years, 5 months ago) by djm
Changes since 1.1.1.4: +8 -1 lines
Diff to previous 1.1.1.4 (colored)

OpenSSL 1.0.0f: import upstream source

Revision 1.1.1.4 / (download) - annotate - [select for diffs] (vendor branch), Thu Nov 3 02:32:19 2011 UTC (12 years, 7 months ago) by djm
Changes since 1.1.1.3: +57 -8 lines
Diff to previous 1.1.1.3 (colored)

import OpenSSL 1.0.0e

Revision 1.1.1.3 / (download) - annotate - [select for diffs] (vendor branch), Fri Oct 1 22:54:16 2010 UTC (13 years, 8 months ago) by djm
Changes since 1.1.1.2: +209 -26 lines
Diff to previous 1.1.1.2 (colored)

import OpenSSL-1.0.0a

Revision 1.1.1.2 / (download) - annotate - [select for diffs] (vendor branch), Fri Jan 9 12:14:06 2009 UTC (15 years, 5 months ago) by djm
Changes since 1.1.1.1: +1 -0 lines
Diff to previous 1.1.1.1 (colored)

import openssl-0.9.8j

Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Sat Sep 6 12:15:51 2008 UTC (15 years, 9 months ago) by djm
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)

import of OpenSSL 0.9.8h

Revision 1.1 / (download) - annotate - [select for diffs], Sat Sep 6 12:15:51 2008 UTC (15 years, 9 months ago) by djm
Branch: MAIN

Initial revision

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.