OpenBSD CVS

CVS log for src/lib/libutil/opendev.3


[BACK] Up to [local] / src / lib / libutil

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.24 / (download) - annotate - [select for diffs], Fri Aug 26 21:47:16 2022 UTC (21 months, 2 weeks ago) by kn
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, HEAD
Changes since 1.23: +5 -7 lines
Diff to previous 1.23 (colored)

Backout "Only return file descriptors to block or character devices"

mount_mfs(8) no monger mounts "/build" with the following fstab(5) entry:
	/dev/sd0b /build mfs rw,noperm,nodev,nosuid,-s=2064348,noauto

as found out by bluhm the hard way.

Revision 1.23 / (download) - annotate - [select for diffs], Thu Aug 25 17:09:54 2022 UTC (21 months, 2 weeks ago) by kn
Branch: MAIN
Changes since 1.22: +7 -5 lines
Diff to previous 1.22 (colored)

Only return file descriptors to block or character devices

If the requested path contained a slash, opendev(3) blindly opened the file
and returned a file descriptor to it.

Check for block or character devices (according to OPENDEV_BLCK) and fail
for other types.

Spotted through installboot(8) which happily opened a stage file as device
when forgetting the device argument:
	# installboot -v ./biosboot
	Using / as root
	installing bootstrap on ./biosboot
	using first-stage /usr/mdec/biosboot, second-stage /usr/mdec/boot
	installboot: disklabel: ./biosboot: Inappropriate ioctl for device

This makes it fail earlier, as expected:
	# installboot -v ./biosboot
	installboot: open: ./biosboot: Block device required

The case where opendev(3) is passed a string not containing a slash, i.e.
a supposed DUID, is fine, as diskmap(4) will ensure that only valid device
paths are returned, if the DUID is valid.

Feedback OK millert

Revision 1.22 / (download) - annotate - [select for diffs], Thu Jan 15 19:06:32 2015 UTC (9 years, 4 months ago) by schwarze
Branch: MAIN
CVS Tags: OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9, OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.21: +3 -5 lines
Diff to previous 1.21 (colored)

remove .Tn; from Jan Stary <hans at stare dot cz>

Revision 1.21 / (download) - annotate - [select for diffs], Wed Jun 5 03:40:26 2013 UTC (11 years ago) by tedu
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4
Changes since 1.20: +3 -3 lines
Diff to previous 1.20 (colored)

use fancy .In macro for includes. from Jan Klemkow. ok jmc schwarze

Revision 1.20 / (download) - annotate - [select for diffs], Mon Jan 3 14:26:51 2011 UTC (13 years, 5 months ago) by krw
Branch: MAIN
CVS Tags: OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9
Changes since 1.19: +24 -10 lines
Diff to previous 1.19 (colored)

Update to better describe reality, i.e. disklabel(8) UID usage.

ok jmc@ jsing@

Revision 1.19 / (download) - annotate - [select for diffs], Fri Dec 17 19:35:34 2010 UTC (13 years, 5 months ago) by millert
Branch: MAIN
Changes since 1.18: +3 -3 lines
Diff to previous 1.18 (colored)

opendev() path argument should be const.  OK deraadt@

Revision 1.18 / (download) - annotate - [select for diffs], Thu Apr 1 17:06:55 2010 UTC (14 years, 2 months ago) by jmc
Branch: MAIN
CVS Tags: OPENBSD_4_8_BASE, OPENBSD_4_8
Changes since 1.17: +9 -9 lines
Diff to previous 1.17 (colored)

WARNINGS -> CAVEATS, and a little neccessary cleanup;

Revision 1.17 / (download) - annotate - [select for diffs], Thu May 31 19:19:38 2007 UTC (17 years ago) by jmc
Branch: MAIN
CVS Tags: OPENBSD_4_7_BASE, OPENBSD_4_7, OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3, OPENBSD_4_2_BASE, OPENBSD_4_2
Changes since 1.16: +2 -2 lines
Diff to previous 1.16 (colored)

convert to new .Dd format;

Revision 1.16 / (download) - annotate - [select for diffs], Tue Feb 6 20:07:15 2007 UTC (17 years, 4 months ago) by jmc
Branch: MAIN
CVS Tags: OPENBSD_4_1_BASE, OPENBSD_4_1
Changes since 1.15: +2 -3 lines
Diff to previous 1.15 (colored)

fix some dodgy displays;

Revision 1.15 / (download) - annotate - [select for diffs], Wed May 1 08:03:30 2002 UTC (22 years, 1 month ago) by mpech
Branch: MAIN
CVS Tags: OPENBSD_4_0_BASE, OPENBSD_4_0, OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6, OPENBSD_3_5_BASE, OPENBSD_3_5, OPENBSD_3_4_BASE, OPENBSD_3_4, OPENBSD_3_3_BASE, OPENBSD_3_3, OPENBSD_3_2_BASE, OPENBSD_3_2
Changes since 1.14: +3 -2 lines
Diff to previous 1.14 (colored)

o) start new sentence on a new line;
o) always close .Bl tags;
o) fix usage of .Xr;

millert@ ok

Revision 1.14 / (download) - annotate - [select for diffs], Tue Apr 30 16:31:42 2002 UTC (22 years, 1 month ago) by mpech
Branch: MAIN
Changes since 1.13: +2 -2 lines
Diff to previous 1.13 (colored)

Initial cleanup:
o) remove extra space in the end of line;
o) remove extra blank lines in the end of file;
o) remove .Pp before .Ss;
o) CAVEAT -> CAVEATS;
o) fix usage of .Fa;
o) <blank-line> -> .Pp;
o) wrap long lines;

millert@ ok

Revision 1.13 / (download) - annotate - [select for diffs], Tue Feb 26 21:16:26 2002 UTC (22 years, 3 months ago) by pvalchev
Branch: MAIN
CVS Tags: OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.12: +6 -2 lines
Diff to previous 1.12 (colored)

mdoc fixes from pjanzen

Revision 1.12 / (download) - annotate - [select for diffs], Tue Feb 26 07:28:51 2002 UTC (22 years, 3 months ago) by pvalchev
Branch: MAIN
Changes since 1.11: +3 -3 lines
Diff to previous 1.11 (colored)

rephrase warning; from miod

Revision 1.11 / (download) - annotate - [select for diffs], Mon Feb 25 22:19:45 2002 UTC (22 years, 3 months ago) by pvalchev
Branch: MAIN
Changes since 1.10: +4 -1 lines
Diff to previous 1.10 (colored)

print a warning that realpath points to internal static storage space that
will be overwritten by subsequent calls; suggested by pjanzen, ok millert

Revision 1.10 / (download) - annotate - [select for diffs], Mon May 1 06:05:33 2000 UTC (24 years, 1 month ago) by hugh
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0, OPENBSD_2_9_BASE, OPENBSD_2_9, OPENBSD_2_8_BASE, OPENBSD_2_8, OPENBSD_2_7_BASE, OPENBSD_2_7
Changes since 1.9: +10 -1 lines
Diff to previous 1.9 (colored)

Document device lookup semantics.

Revision 1.9 / (download) - annotate - [select for diffs], Sun Apr 30 17:37:46 2000 UTC (24 years, 1 month ago) by millert
Branch: MAIN
Changes since 1.8: +6 -4 lines
Diff to previous 1.8 (colored)

Add OPENDEV_BLCK flag for opening the block devices (the character
device is opened by default).

Don't open the file w/o adding a /dev/ prefix unless the file has
a '/' in it.  This prevents problems where someone says "disklabel
sd0" with a file called "sd0" in the cwd.

The OPENDEV_DRCT flag has been deprecated as it is the the default
behavior and always has been.

Add checks for >= MAXPATHLEN and return ENAMETOOLONG in that case.

Revision 1.8 / (download) - annotate - [select for diffs], Wed Jul 7 10:50:06 1999 UTC (24 years, 11 months ago) by aaron
Branch: MAIN
CVS Tags: OPENBSD_2_6_BASE, OPENBSD_2_6
Changes since 1.7: +2 -2 lines
Diff to previous 1.7 (colored)

The proper order of the ``introductory'' macros in a man page is .Dd/.Dt/.Os.
Out of the approximately 1450 man pages, only about 90 of them were wrong.
Thanks to kwesterback@home.com for coming up with a script and patch to repair
this. The patch also inserted a .Os macro in the few man pages that were
missing one.

Revision 1.7 / (download) - annotate - [select for diffs], Fri Jul 2 21:13:07 1999 UTC (24 years, 11 months ago) by aaron
Branch: MAIN
Changes since 1.6: +20 -13 lines
Diff to previous 1.6 (colored)

remove redundant .Pp macros

Revision 1.6 / (download) - annotate - [select for diffs], Thu May 27 16:21:00 1999 UTC (25 years ago) by aaron
Branch: MAIN
Changes since 1.5: +2 -2 lines
Diff to previous 1.5 (colored)

or'ing -> OR'ing

Revision 1.5 / (download) - annotate - [select for diffs], Tue Mar 10 04:50:37 1998 UTC (26 years, 3 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_5_BASE, OPENBSD_2_5, OPENBSD_2_4_BASE, OPENBSD_2_4, OPENBSD_2_3_BASE, OPENBSD_2_3
Changes since 1.4: +3 -2 lines
Diff to previous 1.4 (colored)

use .Ox

Revision 1.4 / (download) - annotate - [select for diffs], Thu Jun 20 10:46:01 1996 UTC (27 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_2_BASE, OPENBSD_2_2, OPENBSD_2_1_BASE, OPENBSD_2_1, OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.3: +4 -3 lines
Diff to previous 1.3 (colored)

only write to realpath if non-NULL

Revision 1.3 / (download) - annotate - [select for diffs], Tue Jun 18 09:13:41 1996 UTC (28 years ago) by downsj
Branch: MAIN
Changes since 1.2: +2 -2 lines
Diff to previous 1.2 (colored)

oops, still missed a typo

Revision 1.2 / (download) - annotate - [select for diffs], Tue Jun 18 09:12:03 1996 UTC (28 years ago) by downsj
Branch: MAIN
Changes since 1.1: +7 -4 lines
Diff to previous 1.1 (colored)

slight cleaning

Revision 1.1 / (download) - annotate - [select for diffs], Mon Jun 17 08:17:33 1996 UTC (28 years ago) by downsj
Branch: MAIN

opendev.3: opendev(3) man page

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.