OpenBSD CVS

CVS log for src/libexec/ftpd/popen.c


[BACK] Up to [local] / src / libexec / ftpd

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.31 / (download) - annotate - [select for diffs], Fri Feb 17 17:59:36 2023 UTC (15 months, 1 week ago) by miod
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, HEAD
Changes since 1.30: +1 -2 lines
Diff to previous 1.30 (colored)

Remove unused variables; ok millert@

Revision 1.30 / (download) - annotate - [select for diffs], Sun Dec 27 15:11:04 2020 UTC (3 years, 5 months ago) by florian
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9
Changes since 1.29: +1 -2 lines
Diff to previous 1.29 (colored)

We know about optreset from unistd.h.
From Jan Stary, thanks.
OK martijn

Revision 1.29 / (download) - annotate - [select for diffs], Wed Jan 15 22:06:59 2020 UTC (4 years, 4 months ago) by jan
Branch: MAIN
CVS Tags: OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7
Changes since 1.28: +20 -29 lines
Diff to previous 1.28 (colored)

Simplify globbing of ftpd(8)s list and nlst commands.
Also avoid command option injection for ls(1).

OK martijn@

Revision 1.28 / (download) - annotate - [select for diffs], Fri Jun 28 13:32:53 2019 UTC (4 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.27: +4 -4 lines
Diff to previous 1.27 (colored)

When system calls indicate an error they return -1, not some arbitrary
value < 0.  errno is only updated in this case.  Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Revision 1.27 / (download) - annotate - [select for diffs], Wed May 8 23:56:48 2019 UTC (5 years ago) by tedu
Branch: MAIN
Changes since 1.26: +21 -39 lines
Diff to previous 1.26 (colored)

rm dead code and simplify ftpd_popen. this code has only called
its statically linked ls_main for some time now.
from Jan Klemkow
ok deraadt

Revision 1.26 / (download) - annotate - [select for diffs], Mon Feb 29 17:50:34 2016 UTC (8 years, 3 months ago) by jca
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0
Changes since 1.25: +2 -2 lines
Diff to previous 1.25 (colored)

Kill unused variable.

Revision 1.25 / (download) - annotate - [select for diffs], Sun Oct 4 11:58:09 2015 UTC (8 years, 8 months ago) by tedu
Branch: MAIN
CVS Tags: OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.24: +7 -23 lines
Diff to previous 1.24 (colored)

fix custom popen to return pid to caller instead of tracking in a giant
array. this implies we can't use a function pointer for close, but also
means we get to repair some abuse of the comma operator.
ok miod

Revision 1.22.4.1 / (download) - annotate - [select for diffs], Fri Mar 12 13:27:38 2010 UTC (14 years, 2 months ago) by jasper
Branch: OPENBSD_4_5
Changes since 1.22: +4 -3 lines
Diff to previous 1.22 (colored) next main 1.23 (colored)

MFC, original commit by kettenis@:
---------------------------
Check that gl_pathc is bigger than zero before derefencing gl_pathv.  While
this shouldn't happen since we specifiy GLOB_NOMAGIC, it doesn't hurt to be
paranoid, even if we fix the bug in glob(3) that causes gl_pathc to be zero
even if we specify GLOB_NOMAGIC.

ok deraadt@

---------------------------

ok sthen@

Revision 1.22.8.1 / (download) - annotate - [select for diffs], Fri Mar 12 13:27:11 2010 UTC (14 years, 2 months ago) by jasper
Branch: OPENBSD_4_6
Changes since 1.22: +4 -3 lines
Diff to previous 1.22 (colored) next main 1.23 (colored)

MFC, original commit by kettenis@:
---------------------------
Check that gl_pathc is bigger than zero before derefencing gl_pathv.  While
this shouldn't happen since we specifiy GLOB_NOMAGIC, it doesn't hurt to be
paranoid, even if we fix the bug in glob(3) that causes gl_pathc to be zero
even if we specify GLOB_NOMAGIC.

ok deraadt@

---------------------------

ok sthen@

Revision 1.24 / (download) - annotate - [select for diffs], Mon Mar 8 19:34:44 2010 UTC (14 years, 2 months ago) by kettenis
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7, OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.23: +3 -2 lines
Diff to previous 1.23 (colored)

Check that gl_pathc is bigger than zero before derefencing gl_pathv.  While
this shouldn't happen since we specifiy GLOB_NOMAGIC, it doesn't hurt to be
paranoid, even if we fix the bug in glob(3) that causes gl_pathc to be zero
even if we specify GLOB_NOMAGIC.

ok deraadt@

Revision 1.23 / (download) - annotate - [select for diffs], Tue Oct 27 23:59:31 2009 UTC (14 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.22: +1 -10 lines
Diff to previous 1.22 (colored)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable).  these days, people use source.  these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Revision 1.22 / (download) - annotate - [select for diffs], Mon Jun 30 12:03:51 2008 UTC (15 years, 11 months ago) by ragge
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_5_BASE, OPENBSD_4_4_BASE, OPENBSD_4_4
Branch point for: OPENBSD_4_6, OPENBSD_4_5
Changes since 1.21: +4 -2 lines
Diff to previous 1.21 (colored)

Include file order must be "monitor.h" before "extern.h" otherwise enum
auth_ret is referenced before it is declared, which is not allowed by C99.

Ok krw@, millert@, gilles@

Revision 1.21 / (download) - annotate - [select for diffs], Sun Apr 2 21:38:56 2006 UTC (18 years, 2 months ago) by djm
Branch: MAIN
CVS Tags: OPENBSD_4_3_BASE, OPENBSD_4_3, OPENBSD_4_2_BASE, OPENBSD_4_2, OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0
Changes since 1.20: +3 -4 lines
Diff to previous 1.20 (colored)

malloc(x * y) -> calloc(x, y) from adobriyan AT gmail.com, with tweaks
suggested by kjell@; ok otto@ pat@ millert@ jaredy@

Revision 1.20 / (download) - annotate - [select for diffs], Wed Dec 10 22:57:12 2003 UTC (20 years, 5 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6, OPENBSD_3_5_BASE, OPENBSD_3_5
Changes since 1.19: +3 -3 lines
Diff to previous 1.19 (colored)

spacing

Revision 1.19 / (download) - annotate - [select for diffs], Wed Jun 11 14:24:46 2003 UTC (20 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.18: +4 -6 lines
Diff to previous 1.18 (colored)

ansi cleanup; ok ian markus

Revision 1.18 / (download) - annotate - [select for diffs], Mon Jun 2 19:38:24 2003 UTC (21 years ago) by millert
Branch: MAIN
Changes since 1.17: +3 -7 lines
Diff to previous 1.17 (colored)

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999.  Proofed by myself and Theo.

Revision 1.17 / (download) - annotate - [select for diffs], Tue Jul 2 18:09:54 2002 UTC (21 years, 11 months ago) by danh
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3, OPENBSD_3_2_BASE, OPENBSD_3_2
Changes since 1.16: +4 -3 lines
Diff to previous 1.16 (colored)

* use lostconn() as the SIGALRM handler in receive_data() as originally
  done by downsj@ in revision 1.54.

* some -Wall cleanup
  - only declare check_host() if TCPWRAPPERS is defined.
  - use socklen_t where appropriate instead of int (pointer signedness
    warnings).
  - {u_}char * pointer signedness warnings.

ok millert@

Revision 1.16 / (download) - annotate - [select for diffs], Wed May 29 20:35:27 2002 UTC (22 years ago) by mpech
Branch: MAIN
Changes since 1.15: +5 -5 lines
Diff to previous 1.15 (colored)

More pid_t cleanup. Since 'pid' is pid_t we should:
o) in ftpd_popen() convert 'pids' from int to pid_t too;
o) in ftpd_pclose() return '-1', not pid_t, because it returns int;

millert@ ok

Revision 1.15 / (download) - annotate - [select for diffs], Sun May 26 09:32:07 2002 UTC (22 years ago) by deraadt
Branch: MAIN
Changes since 1.14: +4 -3 lines
Diff to previous 1.14 (colored)

pid_t cleanup

Revision 1.14 / (download) - annotate - [select for diffs], Wed Jan 23 16:31:18 2002 UTC (22 years, 4 months ago) by mpech
Branch: MAIN
CVS Tags: OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.13: +3 -3 lines
Diff to previous 1.13 (colored)

Use always '.' in the end of the fatal() message. Consistency is good.

millert@ ok.

Revision 1.11.4.1 / (download) - annotate - [select for diffs], Mon Apr 23 21:13:54 2001 UTC (23 years, 1 month ago) by jason
Branch: OPENBSD_2_8
Changes since 1.11: +4 -3 lines
Diff to previous 1.11 (colored) next main 1.12 (colored)

Pull in patch from current:
Fix (deraadt):
Use the GLOB_LIMIT support in glob(3) to constrain a remote denial of
service against ftpd(1).

Revision 1.13 / (download) - annotate - [select for diffs], Sun Mar 18 17:20:13 2001 UTC (23 years, 2 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0, OPENBSD_2_9_BASE, OPENBSD_2_9
Changes since 1.12: +4 -3 lines
Diff to previous 1.12 (colored)

use GLOB_LIMIT

Revision 1.12 / (download) - annotate - [select for diffs], Wed Jan 24 11:50:55 2001 UTC (23 years, 4 months ago) by deraadt
Branch: MAIN
Changes since 1.11: +3 -1 lines
Diff to previous 1.11 (colored)

proto ls_main()

Revision 1.11 / (download) - annotate - [select for diffs], Wed Dec 8 13:15:21 1999 UTC (24 years, 5 months ago) by itojun
Branch: MAIN
CVS Tags: OPENBSD_2_8_BASE, OPENBSD_2_7_BASE, OPENBSD_2_7
Branch point for: OPENBSD_2_8
Changes since 1.10: +2 -1 lines
Diff to previous 1.10 (colored)

IPv6 support from KAME.
XXX kerberos and tcp_wrapper needs checking

Revision 1.10 / (download) - annotate - [select for diffs], Fri Feb 26 00:15:54 1999 UTC (25 years, 3 months ago) by art
Branch: MAIN
CVS Tags: OPENBSD_2_6_BASE, OPENBSD_2_6, OPENBSD_2_5_BASE, OPENBSD_2_5
Changes since 1.9: +10 -2 lines
Diff to previous 1.9 (colored)

implement internal ls

Revision 1.9 / (download) - annotate - [select for diffs], Sun Jun 29 07:35:48 1997 UTC (26 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_4_BASE, OPENBSD_2_4, OPENBSD_2_3_BASE, OPENBSD_2_3, OPENBSD_2_2_BASE, OPENBSD_2_2
Changes since 1.8: +3 -3 lines
Diff to previous 1.8 (colored)

partial Wall

Revision 1.8 / (download) - annotate - [select for diffs], Sat Dec 7 10:52:06 1996 UTC (27 years, 6 months ago) by bitblt
Branch: MAIN
CVS Tags: OPENBSD_2_1_BASE, OPENBSD_2_1
Changes since 1.7: +9 -2 lines
Diff to previous 1.7 (colored)

Checks to see that strdup() worked, dies with error message on failure.

Revision 1.7 / (download) - annotate - [select for diffs], Fri Oct 25 23:59:18 1996 UTC (27 years, 7 months ago) by imp
Branch: MAIN
Changes since 1.6: +4 -4 lines
Diff to previous 1.6 (colored)

Spacing nits

Revision 1.6 / (download) - annotate - [select for diffs], Fri Oct 25 23:37:01 1996 UTC (27 years, 7 months ago) by imp
Branch: MAIN
Changes since 1.5: +8 -4 lines
Diff to previous 1.5 (colored)

Better bounds checking on argv and gargv to eliminate a fencepost error
on argv and gargv variables.

Revision 1.5 / (download) - annotate - [select for diffs], Tue Oct 15 08:24:06 1996 UTC (27 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.4: +5 -4 lines
Diff to previous 1.4 (colored)

nearly impossible oflow

Revision 1.4 / (download) - annotate - [select for diffs], Tue Jul 30 02:01:16 1996 UTC (27 years, 10 months ago) by downsj
Branch: MAIN
CVS Tags: OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.3: +1 -0 lines
Diff to previous 1.3 (colored)

*** empty log message ***

Revision 1.3 / (download) - annotate - [select for diffs], Tue Jul 30 01:59:17 1996 UTC (27 years, 10 months ago) by downsj
Branch: MAIN
Changes since 1.2: +3 -0 lines
Diff to previous 1.2 (colored)

closelog() before exec.

Revision 1.2 / (download) - annotate - [select for diffs], Sat Jul 27 06:16:28 1996 UTC (27 years, 10 months ago) by joshd
Branch: MAIN
Changes since 1.1: +2 -2 lines
Diff to previous 1.1 (colored)

bounds check on argv and gargv

Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Wed Oct 18 08:43:16 1995 UTC (28 years, 7 months ago) by deraadt
CVS Tags: netbsd_1_1
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)

initial import of NetBSD tree

Revision 1.1 / (download) - annotate - [select for diffs], Wed Oct 18 08:43:16 1995 UTC (28 years, 7 months ago) by deraadt
Branch: MAIN

Initial revision

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.