OpenBSD CVS

CVS log for src/libexec/getty/main.c


[BACK] Up to [local] / src / libexec / getty

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.55 / (download) - annotate - [select for diffs], Sun Apr 28 16:42:53 2024 UTC (4 weeks, 6 days ago) by florian
Branch: MAIN
CVS Tags: HEAD
Changes since 1.54: +7 -5 lines
Diff to previous 1.54 (colored)

gmtime(3) / locatime(3) can fail when timestamps are way off.

Add missing error checks to all calls under libexec/

Input & OK millert

Revision 1.54 / (download) - annotate - [select for diffs], Fri Jun 28 13:32:53 2019 UTC (4 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.53: +5 -5 lines
Diff to previous 1.53 (colored)

When system calls indicate an error they return -1, not some arbitrary
value < 0.  errno is only updated in this case.  Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Revision 1.53 / (download) - annotate - [select for diffs], Sun Jun 23 18:54:24 2019 UTC (4 years, 11 months ago) by rob
Branch: MAIN
Changes since 1.52: +5 -1 lines
Diff to previous 1.52 (colored)

Explicitly lock unveil. Noticed when testing the recent ps(1) commit exposing
the unveil state of running processes.
ok deraadt@

Revision 1.52 / (download) - annotate - [select for diffs], Wed May 1 14:13:12 2019 UTC (5 years, 1 month ago) by florian
Branch: MAIN
Changes since 1.51: +3 -2 lines
Diff to previous 1.51 (colored)

Pull tname initialization up since it's used in an error path.
Pointed out by jsg, just fix it deraadt@

Revision 1.51 / (download) - annotate - [select for diffs], Sat Nov 17 01:40:51 2018 UTC (5 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5
Changes since 1.50: +2 -1 lines
Diff to previous 1.50 (colored)

need to closefrom(0) before execve(), otherwise tty isn't properly
'hung up'; some testing by Theodore Wynnychenko

Revision 1.50 / (download) - annotate - [select for diffs], Thu Nov 15 03:04:10 2018 UTC (5 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.49: +24 -9 lines
Diff to previous 1.49 (colored)

Theodore Wynnychenko discovered the gettytab "lo=path" feature didn't work
anymore with unveil wired to /usr/bin/login.  So let's parse gettytab a bit
earlier to learn which login path to unveil. Later in the loop gettytab is
re-parsed, if the login changes re-exec getty to reach the unveil from the top.
ok millert, also discussed with mestre

Revision 1.49 / (download) - annotate - [select for diffs], Mon Sep 24 21:30:00 2018 UTC (5 years, 8 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_4_BASE, OPENBSD_6_4
Changes since 1.48: +14 -1 lines
Diff to previous 1.48 (colored)

unveil(2) in getty.  This has been in snaps for more than 2 months,
since I worry that a mistake in here will cause significant grief.

Revision 1.48 / (download) - annotate - [select for diffs], Mon May 29 04:40:35 2017 UTC (7 years ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2
Changes since 1.47: +2 -3 lines
Diff to previous 1.47 (colored)

do not need dev[] wasting bss space

Revision 1.47 / (download) - annotate - [select for diffs], Sun May 28 08:51:06 2017 UTC (7 years ago) by deraadt
Branch: MAIN
Changes since 1.46: +18 -7 lines
Diff to previous 1.46 (colored)

Do a better job of not printing sequences we cannot reverse in DELETE or
KILL.  Therefore we can do a better job cleaning up.
testing by benno

Revision 1.46 / (download) - annotate - [select for diffs], Sat May 27 09:34:55 2017 UTC (7 years ago) by deraadt
Branch: MAIN
Changes since 1.45: +6 -2 lines
Diff to previous 1.45 (colored)

Stop echoing ANSI sequences back to the console, by expanding ESC character
to literal ^[.  This makes getty interaction appear more like login, and
stops a mid-ANSI sequence parsing problem that messed up login, making it
freeze the session until timeout.
ok tedu fcambus

Revision 1.45 / (download) - annotate - [select for diffs], Sat May 27 09:31:13 2017 UTC (7 years ago) by deraadt
Branch: MAIN
Changes since 1.44: +3 -3 lines
Diff to previous 1.44 (colored)

Stop supporting primordial # (erase) and @ (kill) sequences.
ok tedu

Revision 1.44 / (download) - annotate - [select for diffs], Sat May 27 09:28:28 2017 UTC (7 years ago) by tedu
Branch: MAIN
Changes since 1.43: +3 -8 lines
Diff to previous 1.43 (colored)

remove the getname() code trying to handle baud < 1200 terminals.
leave the special down under code until somebody unearths why it exists.

Revision 1.43 / (download) - annotate - [select for diffs], Mon Jan 23 04:57:13 2017 UTC (7 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_1_BASE, OPENBSD_6_1
Changes since 1.42: +6 -6 lines
Diff to previous 1.42 (colored)

pledge a tiny bit later.  This results in the specified tty being
opened before the first pledge call.
testing by tb and benno and others

Revision 1.42 / (download) - annotate - [select for diffs], Wed Mar 16 15:41:10 2016 UTC (8 years, 2 months ago) by krw
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE, OPENBSD_6_0
Changes since 1.41: +3 -3 lines
Diff to previous 1.41 (colored)

More "(<blah> *)0" -> NULL, avoiding any stdarg functions.

Feedback millert@ kettenis@

Revision 1.41 / (download) - annotate - [select for diffs], Mon Nov 16 18:37:30 2015 UTC (8 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.40: +9 -3 lines
Diff to previous 1.40 (colored)

Observe that FIOASYNC clearing for stdin is only done in the case where
getty receives the fd from init, so hoist it upwards.  Since revoke(2)
is now allowed by pledge "rpath tty", the pledges can be hoisted much
higher.
ok millert semarie tedu guenther

Revision 1.40 / (download) - annotate - [select for diffs], Fri Nov 6 16:42:30 2015 UTC (8 years, 6 months ago) by tedu
Branch: MAIN
Changes since 1.39: +1 -11 lines
Diff to previous 1.39 (colored)

further PPP reduction, hint from sthen

Revision 1.39 / (download) - annotate - [select for diffs], Fri Nov 6 16:39:53 2015 UTC (8 years, 6 months ago) by tedu
Branch: MAIN
Changes since 1.38: +4 -39 lines
Diff to previous 1.38 (colored)

remove ppplogin support. ok sthen

Revision 1.38 / (download) - annotate - [select for diffs], Fri Oct 16 22:25:50 2015 UTC (8 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.37: +8 -6 lines
Diff to previous 1.37 (colored)

Hoist clearing of FIOASYNC to much earlier, then getty can use
pledge "stdio rpath fattr proc exec tty".

Revision 1.37 / (download) - annotate - [select for diffs], Thu Jul 16 04:31:25 2015 UTC (8 years, 10 months ago) by tedu
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8
Changes since 1.36: +4 -4 lines
Diff to previous 1.36 (colored)

remove ancient support for edited hostnames. ok deraadt (long ago)

Revision 1.36 / (download) - annotate - [select for diffs], Tue Apr 14 02:24:17 2015 UTC (9 years, 1 month ago) by millert
Branch: MAIN
Changes since 1.35: +10 -2 lines
Diff to previous 1.35 (colored)

Log a more useful error message if ttyname() fails.  OK deraadt@

Revision 1.35 / (download) - annotate - [select for diffs], Fri Jan 16 05:53:49 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.34: +4 -4 lines
Diff to previous 1.34 (colored)

adjust to HOST_NAME_MAX+1 & LOGIN_NAME_MAX

Revision 1.34 / (download) - annotate - [select for diffs], Wed Nov 19 13:35:37 2014 UTC (9 years, 6 months ago) by krw
Branch: MAIN
Changes since 1.33: +1 -2 lines
Diff to previous 1.33 (colored)

Nuke yet more obvious #include duplications.

ok deraadt@

Revision 1.33 / (download) - annotate - [select for diffs], Tue Nov 18 20:51:00 2014 UTC (9 years, 6 months ago) by krw
Branch: MAIN
Changes since 1.32: +1 -2 lines
Diff to previous 1.32 (colored)

Nuke some obvious #include duplications.

ok espie@ deraadt@ millert@ tedu@

Revision 1.32 / (download) - annotate - [select for diffs], Wed Nov 27 21:25:25 2013 UTC (10 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5
Changes since 1.31: +4 -4 lines
Diff to previous 1.31 (colored)

unsigned char for ctype
ok okan kettenis

Revision 1.31 / (download) - annotate - [select for diffs], Tue Jun 4 22:23:18 2013 UTC (11 years ago) by benno
Branch: MAIN
CVS Tags: OPENBSD_5_4_BASE, OPENBSD_5_4
Changes since 1.30: +2 -6 lines
Diff to previous 1.30 (colored)

do not go into upper to lower case translation mode when a all-caps
username has been entered.
ok deraadt@

Revision 1.30 / (download) - annotate - [select for diffs], Tue Oct 27 23:59:31 2009 UTC (14 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.29: +1 -12 lines
Diff to previous 1.29 (colored)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable).  these days, people use source.  these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Revision 1.29 / (download) - annotate - [select for diffs], Sat Feb 9 10:13:34 2008 UTC (16 years, 3 months ago) by mbalmer
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.28: +4 -6 lines
Diff to previous 1.28 (colored)

Remove an old workaround that was needed in SCCS times (%M% expanding to the
filename).

ok mikeb, millert

Revision 1.28 / (download) - annotate - [select for diffs], Tue Jul 29 18:39:22 2003 UTC (20 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_2_BASE, OPENBSD_4_2, OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0, OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6, OPENBSD_3_5_BASE, OPENBSD_3_5, OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.27: +3 -3 lines
Diff to previous 1.27 (colored)

spaces

Revision 1.27 / (download) - annotate - [select for diffs], Sat Jul 5 17:02:08 2003 UTC (20 years, 11 months ago) by deraadt
Branch: MAIN
Changes since 1.26: +3 -3 lines
Diff to previous 1.26 (colored)

protos

Revision 1.26 / (download) - annotate - [select for diffs], Wed Jun 25 21:11:10 2003 UTC (20 years, 11 months ago) by deraadt
Branch: MAIN
Changes since 1.25: +3 -6 lines
Diff to previous 1.25 (colored)

protos

Revision 1.25 / (download) - annotate - [select for diffs], Mon Jun 2 19:38:24 2003 UTC (21 years ago) by millert
Branch: MAIN
Changes since 1.24: +3 -7 lines
Diff to previous 1.24 (colored)

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999.  Proofed by myself and Theo.

Revision 1.24 / (download) - annotate - [select for diffs], Wed Jul 3 23:39:03 2002 UTC (21 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3, OPENBSD_3_2_BASE, OPENBSD_3_2
Changes since 1.23: +13 -20 lines
Diff to previous 1.23 (colored)

KNF

Revision 1.23 / (download) - annotate - [select for diffs], Wed May 22 06:35:43 2002 UTC (22 years ago) by deraadt
Branch: MAIN
Changes since 1.22: +3 -3 lines
Diff to previous 1.22 (colored)

a bunch more strcpy -> strlcpy and sprintf -> snprintf

Revision 1.22 / (download) - annotate - [select for diffs], Fri Mar 29 20:35:55 2002 UTC (22 years, 2 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.21: +3 -2 lines
Diff to previous 1.21 (colored)

-Wall

Revision 1.21 / (download) - annotate - [select for diffs], Sat Feb 16 21:27:30 2002 UTC (22 years, 3 months ago) by millert
Branch: MAIN
Changes since 1.20: +9 -9 lines
Diff to previous 1.20 (colored)

Part one of userland __P removal.  Done with a simple regexp with some minor hand editing to make comments line up correctly.  Another pass is forthcoming that handles the cases that could not be done automatically.

Revision 1.20 / (download) - annotate - [select for diffs], Mon Nov 19 22:35:04 2001 UTC (22 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.19: +33 -32 lines
Diff to previous 1.19 (colored)

remove the signal handler races and longjmps, and then do a bit of KNF

Revision 1.19 / (download) - annotate - [select for diffs], Sun Jul 8 21:18:08 2001 UTC (22 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0
Changes since 1.18: +5 -5 lines
Diff to previous 1.18 (colored)

-Wall

Revision 1.18 / (download) - annotate - [select for diffs], Wed Jan 31 19:13:36 2001 UTC (23 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_9_BASE, OPENBSD_2_9
Changes since 1.17: +3 -3 lines
Diff to previous 1.17 (colored)

more fat utmp; ianm@cit.uws.edu.au

Revision 1.17 / (download) - annotate - [select for diffs], Sun Jan 28 19:34:28 2001 UTC (23 years, 4 months ago) by niklas
Branch: MAIN
Changes since 1.16: +3 -1 lines
Diff to previous 1.16 (colored)

$OpenBSD$

Revision 1.16 / (download) - annotate - [select for diffs], Fri Jan 19 18:02:26 2001 UTC (23 years, 4 months ago) by deraadt
Branch: MAIN
Changes since 1.15: +4 -5 lines
Diff to previous 1.15 (colored)

mark remaining signal races

Revision 1.15 / (download) - annotate - [select for diffs], Thu Sep 7 17:02:23 2000 UTC (23 years, 8 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_8_BASE, OPENBSD_2_8
Changes since 1.14: +2 -2 lines
Diff to previous 1.14 (colored)

off by one overflow

Revision 1.14 / (download) - annotate - [select for diffs], Thu Dec 9 20:20:43 1999 UTC (24 years, 5 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_7_BASE, OPENBSD_2_7
Changes since 1.13: +3 -6 lines
Diff to previous 1.13 (colored)

oops

Revision 1.13 / (download) - annotate - [select for diffs], Tue Dec 7 19:24:27 1999 UTC (24 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.12: +7 -5 lines
Diff to previous 1.12 (colored)

do not crash if stdin is not a tty

Revision 1.12 / (download) - annotate - [select for diffs], Fri Jul 10 08:06:04 1998 UTC (25 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_6_BASE, OPENBSD_2_6, OPENBSD_2_5_BASE, OPENBSD_2_5, OPENBSD_2_4_BASE, OPENBSD_2_4
Changes since 1.11: +2 -2 lines
Diff to previous 1.11 (colored)

do not syslog() with "\n"; skipped smtpd/named/ipmon; 12 minutes of dabbling

Revision 1.11 / (download) - annotate - [select for diffs], Thu Nov 20 07:39:27 1997 UTC (26 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_3_BASE, OPENBSD_2_3
Changes since 1.10: +15 -15 lines
Diff to previous 1.10 (colored)

puts -> xputs

Revision 1.10 / (download) - annotate - [select for diffs], Tue Aug 5 23:37:35 1997 UTC (26 years, 10 months ago) by angelos
Branch: MAIN
CVS Tags: OPENBSD_2_2_BASE, OPENBSD_2_2
Changes since 1.9: +1 -2 lines
Diff to previous 1.9 (colored)

Remove duplicate inclusion of signal.h

Revision 1.9 / (download) - annotate - [select for diffs], Wed Jul 23 20:36:25 1997 UTC (26 years, 10 months ago) by kstailey
Branch: MAIN
Changes since 1.8: +7 -7 lines
Diff to previous 1.8 (colored)

tabify

Revision 1.8 / (download) - annotate - [select for diffs], Mon Jun 2 08:12:10 1997 UTC (27 years ago) by deraadt
Branch: MAIN
Changes since 1.7: +4 -1 lines
Diff to previous 1.7 (colored)

if getty to# parameter is used, pp option has timeout problem; kfurge@worldnet.att.net, freebsd pr#3733

Revision 1.7 / (download) - annotate - [select for diffs], Sun Apr 6 08:43:41 1997 UTC (27 years, 2 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_1_BASE, OPENBSD_2_1
Changes since 1.6: +2 -3 lines
Diff to previous 1.6 (colored)

clean -Wall

Revision 1.6 / (download) - annotate - [select for diffs], Tue Dec 17 19:33:53 1996 UTC (27 years, 5 months ago) by tholo
Branch: MAIN
Changes since 1.5: +11 -7 lines
Diff to previous 1.5 (colored)

Add traditional handling of all upper-case input

Revision 1.5 / (download) - annotate - [select for diffs], Tue Dec 10 07:58:34 1996 UTC (27 years, 5 months ago) by deraadt
Branch: MAIN
Changes since 1.4: +49 -4 lines
Diff to previous 1.4 (colored)

PPP autologin code from freebsd; do not use until pppd has been checked for security...

Revision 1.4 / (download) - annotate - [select for diffs], Wed May 22 12:10:13 1996 UTC (28 years ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.3: +2 -1 lines
Diff to previous 1.3 (colored)

libutil

Revision 1.3 / (download) - annotate - [select for diffs], Thu Feb 22 10:39:28 1996 UTC (28 years, 3 months ago) by niklas
Branch: MAIN
Changes since 1.2: +2 -2 lines
Diff to previous 1.2 (colored)

From NetBSD:
Make sure that the user name cannot ever be interpreted as an option to
login(8).  Note: This does *not* fix any security holes.

Revision 1.2 / (download) - annotate - [select for diffs], Mon Nov 13 11:27:23 1995 UTC (28 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.1: +23 -23 lines
Diff to previous 1.1 (colored)

repair indentation

Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Wed Oct 18 08:43:17 1995 UTC (28 years, 7 months ago) by deraadt
CVS Tags: netbsd_1_1
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)

initial import of NetBSD tree

Revision 1.1 / (download) - annotate - [select for diffs], Wed Oct 18 08:43:17 1995 UTC (28 years, 7 months ago) by deraadt
Branch: MAIN

Initial revision

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.