OpenBSD CVS

CVS log for src/libexec/spamd/sync.c


[BACK] Up to [local] / src / libexec / spamd

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.14 / (download) - annotate - [select for diffs], Wed Dec 15 17:06:01 2021 UTC (2 years, 5 months ago) by tb
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, HEAD
Changes since 1.13: +41 -21 lines
Diff to previous 1.13 (colored)

spamd: convert to opaque HMAC_CTX

ok jsing

Revision 1.13 / (download) - annotate - [select for diffs], Fri Jun 28 13:32:53 2019 UTC (4 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.12: +2 -2 lines
Diff to previous 1.12 (colored)

When system calls indicate an error they return -1, not some arbitrary
value < 0.  errno is only updated in this case.  Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Revision 1.12 / (download) - annotate - [select for diffs], Thu Oct 20 21:09:46 2016 UTC (7 years, 7 months ago) by mestre
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1
Changes since 1.11: +17 -17 lines
Diff to previous 1.11 (colored)

- Remove useless var assignment
- Use memset(*b, 0, len) instead of bzero(*b, len)
- Use memcpy(*dst, *src, len) instead of bcopy(*src, *dst, len)
- Use explicit_bzero(3) instead of bzero(3) to clean temporary HMAC

Remarks from deraadt@ (duly noted!!), reviewed and OK by henning@ and tb@

Revision 1.11 / (download) - annotate - [select for diffs], Sun Nov 23 21:19:47 2014 UTC (9 years, 6 months ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9, OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.10: +1 -7 lines
Diff to previous 1.10 (colored)

Delete a bunch of unnecessary #includes
Use <fcntl.h> instead of <sys/{file,fcntl}.h>

ok krw@

Revision 1.10 / (download) - annotate - [select for diffs], Tue Nov 19 18:33:07 2013 UTC (10 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5
Changes since 1.9: +2 -2 lines
Diff to previous 1.9 (colored)

the time being handled here is strictly unsigned 32 bit
ok beck phessler

Revision 1.9 / (download) - annotate - [select for diffs], Tue Dec 4 02:36:38 2012 UTC (11 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3
Changes since 1.8: +2 -3 lines
Diff to previous 1.8 (colored)

rather than a mishmash of headers, this only needs <stdint.h>
with guenther

Revision 1.8 / (download) - annotate - [select for diffs], Mon Apr 20 17:42:21 2009 UTC (15 years, 1 month ago) by beck
Branch: MAIN
CVS Tags: OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7, OPENBSD_4_6_BASE, OPENBSD_4_6
Changes since 1.7: +3 -6 lines
Diff to previous 1.7 (colored)


PR 6090 - from Olli Hauer <ohauer@gmx.de>

A number of small improvements:

- patch for empty lines and comments in alloweddomains_file
- remove some whitespaces at end of line.
- document comment and empty line handling
- Remove unused parameter 'r' from getopt in spamd.c, it is removed in the 'switch statement'
  but not in getopt.
  http://www.openbsd.org/cgi-bin/cvsweb/src/libexec/spamd/spamd.c.diff?r1=1.94;r2=1.95;f=h
- replace atoi with strtonum
- make debug output more usefull, display only what will be synced and not a second
  message which prints always "sync trapped %s"

- some cosemtic and whitespace fixes.

Revision 1.7 / (download) - annotate - [select for diffs], Thu May 22 19:54:11 2008 UTC (16 years ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4
Changes since 1.6: +8 -8 lines
Diff to previous 1.6 (colored)

version 2 of spamd sync protocol for two reasons:
1) ip addresses were accidentally being sent in host-byte order, which
   caused compatibility problems (spotted by jbg)
2) the sub-headers in the frame were not natively aligned, thus timeout
   values were incorrectly sent by 64-bit machines
ok beck

Revision 1.6 / (download) - annotate - [select for diffs], Fri May 9 07:09:17 2008 UTC (16 years ago) by deraadt
Branch: MAIN
Changes since 1.5: +15 -6 lines
Diff to previous 1.5 (colored)

As was done in dhcpd, insert pad blocks after sub-messages to keep the
structures aligned to 16 byte boundaries for maximum portability
(somewhat similar to CMSG's).  Old spamd's and new spamd's can still
communicate with this change.  It would be nice if someone tested spamd
on 64-bit unaligned architectures (with and without this change)
ok beck

Revision 1.5 / (download) - annotate - [select for diffs], Wed May 7 08:50:15 2008 UTC (16 years ago) by reyk
Branch: MAIN
Changes since 1.4: +3 -2 lines
Diff to previous 1.4 (colored)

check if the received buffer of a sync element is even big enough to
hold the header with length field.

ok deraadt@ beck@

Revision 1.4 / (download) - annotate - [select for diffs], Thu Dec 27 10:50:06 2007 UTC (16 years, 5 months ago) by reyk
Branch: MAIN
CVS Tags: OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.3: +3 -2 lines
Diff to previous 1.3 (colored)

Add a missing length check of received spamd sync packet headers.

From Diego Giagio (dgiagio at gmail)
with input from tedu@

Revision 1.1.2.1 / (download) - annotate - [select for diffs], Sat Apr 28 02:25:52 2007 UTC (17 years, 1 month ago) by ckuethe
Branch: OPENBSD_4_1
Changes since 1.1: +11 -9 lines
Diff to previous 1.1 (colored) next main 1.2 (colored)

sync the syncer to the latest syncer.
r1.2 Fix dribbly HMAC leak. patch by beck@, ok reyk@
r1.3 rename h_name to sh_name to avoid memory corruption. patch by otto@, ok reyk@

Revision 1.3 / (download) - annotate - [select for diffs], Fri Apr 13 05:55:03 2007 UTC (17 years, 1 month ago) by otto
Branch: MAIN
CVS Tags: OPENBSD_4_2_BASE, OPENBSD_4_2
Changes since 1.2: +9 -9 lines
Diff to previous 1.2 (colored)

rename h_name to sh_name. hname gets redefined in netdb.h to a zero
sized array, so memory corruption occurs when writing the field.
problem encountered by Jeremy C. Reed. ok reyk@

Revision 1.2 / (download) - annotate - [select for diffs], Fri Mar 16 23:08:06 2007 UTC (17 years, 2 months ago) by beck
Branch: MAIN
Changes since 1.1: +3 -1 lines
Diff to previous 1.1 (colored)

Fix dribbly HMAC leak.
ok reyk@

Revision 1.1 / (download) - annotate - [select for diffs], Sun Mar 4 03:19:41 2007 UTC (17 years, 3 months ago) by beck
Branch: MAIN
CVS Tags: OPENBSD_4_1_BASE
Branch point for: OPENBSD_4_1


Database synchronizaton for spamd/spamlogd

This adds an HMAC protected synchronization protocol for use by spamd and
spamlogd.

- spamd can receive updates from other hosts for GREY, WHITE, and TRAPPED db
entries, and will update the local /var/db/spamd accordingly.

- spamd can send updates when it makes changes to the GREY or TRAPPED
entries in the db to other hosts running spamd. (Note it does not send
WHITE entries because the other spamd will see the GREY changes and have
complete information to make appropritate decisions)

- spamlogd can send updates for WHITE db entries that it performs on the local
db to other hosts running spamd, which will then apply them on remote hosts.

note that while this diff provides synchronization for changes made to the
spamd db by the daemons, it does *not* provide for sychonizing changes
to the spamd db made manually with the spamdb command.

Synchronization protocol and most of the work by reyk@,
with a bunch of the spamd, and spamlogd stuff by me.

testing mostly at the U of A, running happily there under big load.

ok reyk@ jmc@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.