OpenBSD CVS

CVS log for src/sbin/fsck_ffs/pass1.c


[BACK] Up to [local] / src / sbin / fsck_ffs

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.49 / (download) - annotate - [select for diffs], Sat Feb 3 18:51:57 2024 UTC (3 months, 3 weeks ago) by beck
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, HEAD
Changes since 1.48: +1 -26 lines
Diff to previous 1.48 (colored)

Remove Softdep.

Softdep has been a no-op for some time now, this removes it to get
it out of the way.

Flensing mostly done in Talinn, with some help from krw@

ok deraadt@

Revision 1.48 / (download) - annotate - [select for diffs], Tue Jan 9 03:16:00 2024 UTC (4 months, 3 weeks ago) by guenther
Branch: MAIN
Changes since 1.47: +2 -3 lines
Diff to previous 1.47 (colored)

Delete support for FFS filesystems before the in-inode symlink
optimization.  As observed by ali_farzanrad(at)riseup.net, support
for these was broken in the 5.5 release in early 2014 by the time_t
changes.  No one noticed before now, so clearly this isn't something
we need to continue to support; rejecting in ffs_validate() is an
improvement.

Also: simplify DIRSIZ(), drop OLDDIRFMT and NEWDIRFMT, tests of
fs_maxsymlinklen against zero, #ifdef tests of FS_44INODEFMT, and
remove support for newfs -O0, last used in 2016.

ok miod@

Revision 1.47 / (download) - annotate - [select for diffs], Mon Jul 13 06:52:53 2020 UTC (3 years, 10 months ago) by otto
Branch: MAIN
CVS Tags: OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8
Changes since 1.46: +12 -9 lines
Diff to previous 1.46 (colored)

Both phase 1 and phase 5 need the cylinder group meta data, so save those
in phase one to be used in phase 5, unless we're tight on memory.
From FreeBSD; ok bket@

Revision 1.46 / (download) - annotate - [select for diffs], Sat Jun 20 07:49:04 2020 UTC (3 years, 11 months ago) by otto
Branch: MAIN
Changes since 1.45: +2 -2 lines
Diff to previous 1.45 (colored)

With filesystem having many cylinder groups and many inodes per cg the
ncg * ipg calcualtion can overflow if signed types are used.  Move
to uint32_t for the relevant values. Aligned with FreeBSD changes.
Also make sure newfs refuses to create an fs with more that 2^32-1
inodes.  ok millert@

Revision 1.45 / (download) - annotate - [select for diffs], Wed Apr 12 15:23:08 2017 UTC (7 years, 1 month ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2
Changes since 1.44: +8 -3 lines
Diff to previous 1.44 (colored)

Prevent inosused from wrapping when soft updates is enabled while
scanning the used inode map.  The code as written assumes inosused
is signed but this is no longer the case.  OK deraadt@

Revision 1.44 / (download) - annotate - [select for diffs], Mon Apr 10 08:19:12 2017 UTC (7 years, 1 month ago) by fcambus
Branch: MAIN
Changes since 1.43: +2 -4 lines
Diff to previous 1.43 (colored)

Remove always false comparison: inosused type is ino_t, which is
unsigned.

While there, fix a whitespace issue.

OK deraadt@

Revision 1.43 / (download) - annotate - [select for diffs], Sat Aug 22 06:00:27 2015 UTC (8 years, 9 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.42: +2 -2 lines
Diff to previous 1.42 (colored)

spacing

Revision 1.42 / (download) - annotate - [select for diffs], Tue Jan 20 18:22:21 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.41: +2 -2 lines
Diff to previous 1.41 (colored)

Adjust <sys/param.h> comments regarding use of use of MAXFRAG, or
delete <sys/param.h> if now possible
ok guenther

Revision 1.41 / (download) - annotate - [select for diffs], Fri Jan 16 06:39:57 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
Changes since 1.40: +3 -2 lines
Diff to previous 1.40 (colored)

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible.  Annotate <sys/param.h> lines with their current reasons.  Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc.  Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution.  These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Revision 1.40 / (download) - annotate - [select for diffs], Tue Oct 14 15:01:51 2014 UTC (9 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.39: +7 -11 lines
Diff to previous 1.39 (colored)

rely on reallocarray() to give us the overflow detection, rather than
hand-crafting a solution.
ok millert

Revision 1.39 / (download) - annotate - [select for diffs], Sat Sep 6 04:05:40 2014 UTC (9 years, 8 months ago) by guenther
Branch: MAIN
Changes since 1.38: +10 -10 lines
Diff to previous 1.38 (colored)

inodesc.id_entryno holds a file size, so upgrade it from int to u_int64_t;
  this fixes handling of very large files on FFS2.
Correct a copy-n-pasto that rendered useless the check for allocated
  fragmented that are marked free in the bitmap.
allocdir() returns an inode number, so return an ino_t.
sizeof()*N should be printed with %zu, while direct and indirect block
  numbers should be cast to (long long) use %lld

inodesc.id_entryno fix based on a diff from David Vasek <vasek@fido.cz>
ok krw@ otto@

Revision 1.38 / (download) - annotate - [select for diffs], Tue Jun 11 16:42:04 2013 UTC (10 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4
Changes since 1.37: +7 -7 lines
Diff to previous 1.37 (colored)

final removal of daddr64_t.  daddr_t has been 64 bit for a long enough
test period; i think 3 years ago the last bugs fell out.
ok otto beck others

Revision 1.37 / (download) - annotate - [select for diffs], Wed Apr 24 13:46:29 2013 UTC (11 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.36: +14 -11 lines
Diff to previous 1.36 (colored)

pretty print bigger off_t
ok tedu otto

Revision 1.36 / (download) - annotate - [select for diffs], Mon May 2 22:23:59 2011 UTC (13 years, 1 month ago) by chl
Branch: MAIN
CVS Tags: OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0
Changes since 1.35: +1 -2 lines
Diff to previous 1.35 (colored)

Remove unused variable

ok krw@ otto@

Revision 1.35 / (download) - annotate - [select for diffs], Sun Apr 24 07:07:03 2011 UTC (13 years, 1 month ago) by otto
Branch: MAIN
Changes since 1.34: +1 -39 lines
Diff to previous 1.34 (colored)

remove support for (very) old ffs on-disk formats; ok krw@ and no
objection form the usual suspects

Revision 1.34 / (download) - annotate - [select for diffs], Sat Apr 16 16:37:21 2011 UTC (13 years, 1 month ago) by otto
Branch: MAIN
Changes since 1.33: +87 -6 lines
Diff to previous 1.33 (colored)

Blend in some code from netbsd and freebsd that reduces memory consumption
and speeds things up in a lot of cases.
Prompted by Amit Kulkarni; ok krw@ on a slighly diffrenent incarnation

Revision 1.33 / (download) - annotate - [select for diffs], Fri Jul 9 06:41:17 2010 UTC (13 years, 10 months ago) by otto
Branch: MAIN
CVS Tags: OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8
Changes since 1.32: +3 -2 lines
Diff to previous 1.32 (colored)

Avoid crashes by using correct types for block numbers, which can grow
large on very large filesystems; reported by Benny Lofgren; partly
from FreeBSD. ok deraadt@ beck@ millert@

Revision 1.32 / (download) - annotate - [select for diffs], Tue Oct 27 23:59:32 2009 UTC (14 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.31: +1 -9 lines
Diff to previous 1.31 (colored)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable).  these days, people use source.  these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Revision 1.31 / (download) - annotate - [select for diffs], Fri May 29 07:57:43 2009 UTC (15 years ago) by otto
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6
Changes since 1.30: +6 -4 lines
Diff to previous 1.30 (colored)

catch funny values of cg_initediblk; make fsck_ffs more robust
against forms of cg header corruption as experienced by todd@; ok
millert@

Revision 1.30 / (download) - annotate - [select for diffs], Sun Nov 9 15:54:54 2008 UTC (15 years, 6 months ago) by chl
Branch: MAIN
CVS Tags: OPENBSD_4_5_BASE, OPENBSD_4_5
Changes since 1.29: +3 -2 lines
Diff to previous 1.29 (colored)

add missing header needed by getpagesize().

ok millert@

Revision 1.29 / (download) - annotate - [select for diffs], Thu Nov 6 18:01:44 2008 UTC (15 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.28: +3 -3 lines
Diff to previous 1.28 (colored)

Have called pass pagesize into FS_KERNMAXFILESIZE(), because there is no
automatic symbol that has this information.  PAGE_SIZE is simply not
portable, or even fixed on some systems.
ok otto

Revision 1.28 / (download) - annotate - [select for diffs], Sun Nov 2 08:54:10 2008 UTC (15 years, 7 months ago) by otto
Branch: MAIN
Changes since 1.27: +8 -4 lines
Diff to previous 1.27 (colored)

check for the maximum file size to avoid some out-of-bounds accesses;
ok millert@

Revision 1.27 / (download) - annotate - [select for diffs], Tue Jun 10 23:10:29 2008 UTC (15 years, 11 months ago) by otto
Branch: MAIN
CVS Tags: OPENBSD_4_4_BASE, OPENBSD_4_4
Changes since 1.26: +9 -9 lines
Diff to previous 1.26 (colored)

reduce mem usage by about 20% by packing state and type of an inode in a single
byte. Original diff by drahn@; twists by me; ok millert@ thib@

Revision 1.26 / (download) - annotate - [select for diffs], Mon Jun 25 19:59:55 2007 UTC (16 years, 11 months ago) by otto
Branch: MAIN
CVS Tags: OPENBSD_4_3_BASE, OPENBSD_4_3, OPENBSD_4_2_BASE, OPENBSD_4_2
Changes since 1.25: +5 -5 lines
Diff to previous 1.25 (colored)

Teach fsck_ffs about 64-bit block addresses. ok (and help) moritz@ pedro@

Revision 1.25 / (download) - annotate - [select for diffs], Fri Jun 1 23:42:35 2007 UTC (17 years ago) by pedro
Branch: MAIN
Changes since 1.24: +6 -6 lines
Diff to previous 1.24 (colored)

ufs1_daddr_t cleanup, okay otto@

Revision 1.24 / (download) - annotate - [select for diffs], Fri Jun 1 06:41:33 2007 UTC (17 years ago) by deraadt
Branch: MAIN
Changes since 1.23: +5 -5 lines
Diff to previous 1.23 (colored)

convert ufs2_daddr_t -> daddr64_t for greater clarity; ok pedro otto thib

Revision 1.23 / (download) - annotate - [select for diffs], Tue Apr 10 16:08:17 2007 UTC (17 years, 1 month ago) by millert
Branch: MAIN
Changes since 1.22: +73 -47 lines
Diff to previous 1.22 (colored)

Add support for checking ffs2 filesystems.  From pedro@ based on
the ufs2 changes in FreeBSD by Kirk Mckusick.

Revision 1.22 / (download) - annotate - [select for diffs], Mon Mar 19 13:27:47 2007 UTC (17 years, 2 months ago) by pedro
Branch: MAIN
Changes since 1.21: +3 -3 lines
Diff to previous 1.21 (colored)

Add FFS2 fields to the superblock, change file system tools to keep
accessing FFS1 fields, okay art@, quite some testing by ckuethe@, simon@
and thib@, thanks.

Revision 1.21 / (download) - annotate - [select for diffs], Mon Feb 12 16:35:55 2007 UTC (17 years, 3 months ago) by otto
Branch: MAIN
CVS Tags: OPENBSD_4_1_BASE, OPENBSD_4_1
Changes since 1.20: +5 -3 lines
Diff to previous 1.20 (colored)

detect truncation of block number, which can happen which trashed
inodes; ok pedro@ millert@

Revision 1.20 / (download) - annotate - [select for diffs], Wed Mar 22 20:24:32 2006 UTC (18 years, 2 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_0_BASE, OPENBSD_4_0
Changes since 1.19: +2 -2 lines
Diff to previous 1.19 (colored)

earlier asprintf diff caused malloc in signal handler.  clarify the
code a bit more so that this mistake will not be done again

Revision 1.19 / (download) - annotate - [select for diffs], Sun Mar 12 02:28:28 2006 UTC (18 years, 2 months ago) by deraadt
Branch: MAIN
Changes since 1.18: +4 -4 lines
Diff to previous 1.18 (colored)

use asprintf instead of a static buffer; dhill, tested by pedro

Revision 1.18 / (download) - annotate - [select for diffs], Mon Dec 19 15:18:01 2005 UTC (18 years, 5 months ago) by pedro
Branch: MAIN
CVS Tags: OPENBSD_3_9_BASE, OPENBSD_3_9
Changes since 1.17: +3 -3 lines
Diff to previous 1.17 (colored)

Add and use a few more constants and macros needed by UFS2
No functional change

Revision 1.17 / (download) - annotate - [select for diffs], Sat Apr 16 18:15:41 2005 UTC (19 years, 1 month ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_8_BASE, OPENBSD_3_8
Changes since 1.16: +4 -6 lines
Diff to previous 1.16 (colored)

Since the return value from the *_info functions is only actually used as a
boolean, make it so.  OK deraadt@

Revision 1.16 / (download) - annotate - [select for diffs], Sat Apr 16 17:37:25 2005 UTC (19 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.15: +6 -4 lines
Diff to previous 1.15 (colored)

while snprintf and strlcpy and strlcat have this nice >buflen API (and the
-1 mess as well), it is probably not wise to make other functions do the same
thing.  make them return strlen().  ok uwe marco

Revision 1.15 / (download) - annotate - [select for diffs], Sat Oct 11 01:43:45 2003 UTC (20 years, 7 months ago) by tedu
Branch: MAIN
CVS Tags: OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6, OPENBSD_3_5_BASE, OPENBSD_3_5
Changes since 1.14: +3 -3 lines
Diff to previous 1.14 (colored)

consistent newlines, from tom cosgrove at arches-consulting.com.

Revision 1.14 / (download) - annotate - [select for diffs], Mon Aug 25 23:28:15 2003 UTC (20 years, 9 months ago) by tedu
Branch: MAIN
CVS Tags: OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.13: +3 -3 lines
Diff to previous 1.13 (colored)

rename struct dinode to ufs1_dinode.  clears the namespace and makes
way for some future work.  no function changes yet.
help testing otto@ and markus@

Revision 1.13 / (download) - annotate - [select for diffs], Mon Jun 2 20:06:15 2003 UTC (21 years ago) by millert
Branch: MAIN
Changes since 1.12: +3 -7 lines
Diff to previous 1.12 (colored)

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999.  Proofed by myself and Theo.

Revision 1.12 / (download) - annotate - [select for diffs], Fri Aug 23 09:09:04 2002 UTC (21 years, 9 months ago) by gluk
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3, OPENBSD_3_2_BASE, OPENBSD_3_2
Changes since 1.11: +9 -15 lines
Diff to previous 1.11 (colored)

- Convert function definitions to new style
- eliminate trailing whitespace
- remove casts that aren't needed.
- make rcsid strings const, for -Wall compilation.

 from tedu <grendel@zeitbombe.org>

Revision 1.11 / (download) - annotate - [select for diffs], Sat Feb 16 21:27:34 2002 UTC (22 years, 3 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.10: +3 -3 lines
Diff to previous 1.10 (colored)

Part one of userland __P removal.  Done with a simple regexp with some minor hand editing to make comments line up correctly.  Another pass is forthcoming that handles the cases that could not be done automatically.

Revision 1.10 / (download) - annotate - [select for diffs], Mon Nov 5 07:39:16 2001 UTC (22 years, 7 months ago) by mpech
Branch: MAIN
Changes since 1.9: +6 -6 lines
Diff to previous 1.9 (colored)

kill more registers;

millert@ ok

Revision 1.9 / (download) - annotate - [select for diffs], Sat Jul 7 18:26:12 2001 UTC (22 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0
Changes since 1.8: +8 -7 lines
Diff to previous 1.8 (colored)

major -Wall cleanup, almost complete

Revision 1.8 / (download) - annotate - [select for diffs], Fri Mar 2 08:33:55 2001 UTC (23 years, 3 months ago) by art
Branch: MAIN
CVS Tags: OPENBSD_2_9_BASE, OPENBSD_2_9
Changes since 1.7: +14 -6 lines
Diff to previous 1.7 (colored)

Make fsck aware of soft updates.
We had this in the tree 1997, but it went away because it was too close to
release.
Ok: csapuntz@
(as a size note: It's really good to test fsck when you are torture testing
the filesystems)

Revision 1.7 / (download) - annotate - [select for diffs], Mon Mar 1 07:45:17 1999 UTC (25 years, 3 months ago) by d
Branch: MAIN
CVS Tags: OPENBSD_2_8_BASE, OPENBSD_2_8, OPENBSD_2_7_BASE, OPENBSD_2_7, OPENBSD_2_6_BASE, OPENBSD_2_6, OPENBSD_2_5_BASE, OPENBSD_2_5
Changes since 1.6: +18 -3 lines
Diff to previous 1.6 (colored)

SIGINFO support

Revision 1.6 / (download) - annotate - [select for diffs], Mon Oct 6 20:22:34 1997 UTC (26 years, 8 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_4_BASE, OPENBSD_2_4, OPENBSD_2_3_BASE, OPENBSD_2_3, OPENBSD_2_2_BASE, OPENBSD_2_2
Changes since 1.5: +4 -12 lines
Diff to previous 1.5 (colored)

back out vfs lite2 till after 2.2

Revision 1.5 / (download) - annotate - [select for diffs], Mon Oct 6 15:33:34 1997 UTC (26 years, 8 months ago) by csapuntz
Branch: MAIN
Changes since 1.4: +14 -6 lines
Diff to previous 1.4 (colored)

VFS Lite2 Changes

Revision 1.4 / (download) - annotate - [select for diffs], Sun Oct 20 08:36:36 1996 UTC (27 years, 7 months ago) by tholo
Branch: MAIN
CVS Tags: OPENBSD_2_1_BASE, OPENBSD_2_1
Changes since 1.3: +19 -20 lines
Diff to previous 1.3 (colored)

Sync with NetBSD 961019

Revision 1.3 / (download) - annotate - [select for diffs], Sun Jun 23 14:30:30 1996 UTC (27 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.2: +2 -1 lines
Diff to previous 1.2 (colored)

update rcsid

Revision 1.2 / (download) - annotate - [select for diffs], Mon Jan 29 01:37:11 1996 UTC (28 years, 4 months ago) by deraadt
Branch: MAIN
Changes since 1.1: +8 -5 lines
Diff to previous 1.1 (colored)

use fs_csaddr to find the cg summary area; from mouse@collatz.mccrim.mcgill.edu; netbsd pr#1366

Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Wed Oct 18 08:43:32 1995 UTC (28 years, 7 months ago) by deraadt
CVS Tags: netbsd_1_1
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)

initial import of NetBSD tree

Revision 1.1 / (download) - annotate - [select for diffs], Wed Oct 18 08:43:32 1995 UTC (28 years, 7 months ago) by deraadt
Branch: MAIN

Initial revision

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.