OpenBSD CVS

CVS log for src/sbin/mknod/mknod.c


[BACK] Up to [local] / src / sbin / mknod

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.31 / (download) - annotate - [select for diffs], Fri Jun 28 13:32:44 2019 UTC (4 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6, HEAD
Changes since 1.30: +2 -2 lines
Diff to previous 1.30 (colored)

When system calls indicate an error they return -1, not some arbitrary
value < 0.  errno is only updated in this case.  Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Revision 1.30 / (download) - annotate - [select for diffs], Thu Oct 20 10:24:40 2016 UTC (7 years, 7 months ago) by schwarze
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1
Changes since 1.29: +1 -4 lines
Diff to previous 1.29 (colored)

delete useless call to setlocale(3);
patch from Jan Stary <hans at stare dot cz>;
OK millert@ natano@

Revision 1.29 / (download) - annotate - [select for diffs], Mon Mar 7 19:16:06 2016 UTC (8 years, 3 months ago) by tb
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE, OPENBSD_6_0
Changes since 1.28: +21 -8 lines
Diff to previous 1.28 (colored)

Use the full idiom for error checking with strtoul(3), as
exemplified in the man page. Requested by deraadt@.

Joint work with natano@
input and ok espie@, deraadt@

Revision 1.28 / (download) - annotate - [select for diffs], Sun Mar 6 19:31:31 2016 UTC (8 years, 3 months ago) by tb
Branch: MAIN
Changes since 1.27: +2 -2 lines
Diff to previous 1.27 (colored)

Drop "rpath" promise. Now that pledge() is called after setlocale(),
this is no longer needed.

ok beck@, natano@

Revision 1.27 / (download) - annotate - [select for diffs], Sun Mar 6 14:38:19 2016 UTC (8 years, 3 months ago) by espie
Branch: MAIN
Changes since 1.26: +3 -3 lines
Diff to previous 1.26 (colored)

my bad. thought it was setlocale "C".

Revision 1.26 / (download) - annotate - [select for diffs], Sun Mar 6 13:40:23 2016 UTC (8 years, 3 months ago) by natano
Branch: MAIN
Changes since 1.25: +2 -2 lines
Diff to previous 1.25 (colored)

Tighten mknod pledge().

The wpath, cpath and fattr promises are not required for calling mknod(2),
dpath is enough.

ok semarie@
testing and ok tb@

Revision 1.25 / (download) - annotate - [select for diffs], Sat Mar 5 21:15:41 2016 UTC (8 years, 3 months ago) by espie
Branch: MAIN
Changes since 1.24: +9 -9 lines
Diff to previous 1.24 (colored)

better error messages, common work with natano@

Revision 1.24 / (download) - annotate - [select for diffs], Sat Mar 5 19:29:41 2016 UTC (8 years, 3 months ago) by natano
Branch: MAIN
Changes since 1.23: +4 -7 lines
Diff to previous 1.23 (colored)

Remove unused node type; ok espie@

Revision 1.23 / (download) - annotate - [select for diffs], Sat Mar 5 17:15:43 2016 UTC (8 years, 3 months ago) by tb
Branch: MAIN
Changes since 1.22: +4 -15 lines
Diff to previous 1.22 (colored)

Remove debugging code, extra whitespace and a lint annotation.

"just clean it", deraadt@; ok sha256

Revision 1.22 / (download) - annotate - [select for diffs], Sat Mar 5 16:32:54 2016 UTC (8 years, 3 months ago) by millert
Branch: MAIN
Changes since 1.21: +4 -6 lines
Diff to previous 1.21 (colored)

Use mknod(2) to create FIFOs by setting S_IFIFO in the mode.
Simplifies the logic in domakenodes() slightly.  OK espie@

Revision 1.21 / (download) - annotate - [select for diffs], Sat Mar 5 10:47:08 2016 UTC (8 years, 3 months ago) by espie
Branch: MAIN
Changes since 1.20: +164 -120 lines
Diff to previous 1.20 (colored)

Almost complete rewrite of mknod.

With this, none of the original code survives, so the Copyright notice
can be changed accordingly.

This does pledge upfront, because having fifos or devices with
setuid/gid/sticky makes no sense anyway.

The reorganization was done to allow a "create multiple devices" at once
mode, in order to speed up MAKEDEV (eventually) now that the ksh builtin
is gone.  The code is picky and checks all parameters before doing anything.

Inputs from natano, deraadt, rpe, millert, tb, jmc...

okay tb@, deraadt@

Revision 1.20 / (download) - annotate - [select for diffs], Fri Mar 4 16:48:13 2016 UTC (8 years, 3 months ago) by natano
Branch: MAIN
Changes since 1.19: +4 -6 lines
Diff to previous 1.19 (colored)

Invert the pledge() condition.

The only case where we don't want to pledge() is when a mode containing
the suid, sgid or sticky is is passed on the command line. mknod() in a
pledged binary would always strip those bits.

discussion and ok espie@
ok deraadt@ semarie@ tb@

Revision 1.19 / (download) - annotate - [select for diffs], Fri Dec 18 15:34:27 2015 UTC (8 years, 5 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.18: +6 -2 lines
Diff to previous 1.18 (colored)

pledge "stdio rpath wpath cpath dpath fattr", as long as the -m option
wasn't used

Revision 1.18 / (download) - annotate - [select for diffs], Sat Mar 27 09:10:02 2010 UTC (14 years, 2 months ago) by jmc
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7, OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8
Changes since 1.17: +2 -2 lines
Diff to previous 1.17 (colored)

`b' and `c' arguments to mknod are not optional; from LEVAI Daniel
c_sh.c part from sobrado;

ok millert guenther

Revision 1.17 / (download) - annotate - [select for diffs], Tue Oct 27 23:59:33 2009 UTC (14 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.16: +1 -15 lines
Diff to previous 1.16 (colored)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable).  these days, people use source.  these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Revision 1.16 / (download) - annotate - [select for diffs], Sun Dec 30 13:52:40 2007 UTC (16 years, 5 months ago) by sobrado
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.15: +5 -4 lines
Diff to previous 1.15 (colored)

do not repeat "usage:" twice

ok jmc@

Revision 1.15 / (download) - annotate - [select for diffs], Sat Dec 16 08:49:18 2006 UTC (17 years, 5 months ago) by jmc
Branch: MAIN
CVS Tags: OPENBSD_4_2_BASE, OPENBSD_4_2, OPENBSD_4_1_BASE, OPENBSD_4_1
Changes since 1.14: +3 -3 lines
Diff to previous 1.14 (colored)

various small improvements;

Revision 1.14 / (download) - annotate - [select for diffs], Sat Apr 8 23:51:33 2006 UTC (18 years, 2 months ago) by dhill
Branch: MAIN
CVS Tags: OPENBSD_4_0_BASE, OPENBSD_4_0
Changes since 1.13: +8 -8 lines
Diff to previous 1.13 (colored)

Remove unused variables.

ok ray@

Revision 1.13 / (download) - annotate - [select for diffs], Mon Jun 2 20:06:15 2003 UTC (21 years ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6, OPENBSD_3_5_BASE, OPENBSD_3_5, OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.12: +3 -7 lines
Diff to previous 1.12 (colored)

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999.  Proofed by myself and Theo.

Revision 1.12 / (download) - annotate - [select for diffs], Wed Jul 3 22:32:33 2002 UTC (21 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3, OPENBSD_3_2_BASE, OPENBSD_3_2
Changes since 1.11: +6 -15 lines
Diff to previous 1.11 (colored)

ansi

Revision 1.11 / (download) - annotate - [select for diffs], Sun Jun 9 08:13:07 2002 UTC (22 years ago) by todd
Branch: MAIN
Changes since 1.10: +3 -3 lines
Diff to previous 1.10 (colored)

rm trailing whitespace

Revision 1.10 / (download) - annotate - [select for diffs], Sat Feb 16 21:27:35 2002 UTC (22 years, 3 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.9: +5 -5 lines
Diff to previous 1.9 (colored)

Part one of userland __P removal.  Done with a simple regexp with some minor hand editing to make comments line up correctly.  Another pass is forthcoming that handles the cases that could not be done automatically.

Revision 1.9 / (download) - annotate - [select for diffs], Sat Jul 7 18:26:14 2001 UTC (22 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0
Changes since 1.8: +4 -4 lines
Diff to previous 1.8 (colored)

major -Wall cleanup, almost complete

Revision 1.8 / (download) - annotate - [select for diffs], Mon Feb 28 17:03:26 2000 UTC (24 years, 3 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_9_BASE, OPENBSD_2_9, OPENBSD_2_8_BASE, OPENBSD_2_8, OPENBSD_2_7_BASE, OPENBSD_2_7
Changes since 1.7: +4 -4 lines
Diff to previous 1.7 (colored)

Use a base of 0 when calling stroul() as per the man page; gagnocg@ev1.net

Revision 1.7 / (download) - annotate - [select for diffs], Mon Jan 3 22:05:54 2000 UTC (24 years, 5 months ago) by millert
Branch: MAIN
Changes since 1.6: +14 -7 lines
Diff to previous 1.6 (colored)

When a mode is specified via the -m flag, don't allow the umask
to modify the mode.

Revision 1.6 / (download) - annotate - [select for diffs], Sun Apr 18 19:40:41 1999 UTC (25 years, 1 month ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_6_BASE, OPENBSD_2_6
Changes since 1.5: +109 -22 lines
Diff to previous 1.5 (colored)

merge mknod and mkfifo, support 'p' in mknod

Revision 1.5 / (download) - annotate - [select for diffs], Sat Oct 4 19:30:16 1997 UTC (26 years, 8 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_5_BASE, OPENBSD_2_5, OPENBSD_2_4_BASE, OPENBSD_2_4, OPENBSD_2_3_BASE, OPENBSD_2_3, OPENBSD_2_2_BASE, OPENBSD_2_2
Changes since 1.4: +4 -4 lines
Diff to previous 1.4 (colored)

freeze strtoul() base to 10

Revision 1.4 / (download) - annotate - [select for diffs], Wed Jun 18 09:59:36 1997 UTC (26 years, 11 months ago) by deraadt
Branch: MAIN
Changes since 1.3: +3 -3 lines
Diff to previous 1.3 (colored)

fix non-numeric minor number checking; bde

Revision 1.3 / (download) - annotate - [select for diffs], Fri Aug 2 11:16:47 1996 UTC (27 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_1_BASE, OPENBSD_2_1, OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.2: +21 -3 lines
Diff to previous 1.2 (colored)

use strtoul and check errors; from freebsd

Revision 1.2 / (download) - annotate - [select for diffs], Sun Jun 23 14:31:03 1996 UTC (27 years, 11 months ago) by deraadt
Branch: MAIN
Changes since 1.1: +2 -1 lines
Diff to previous 1.1 (colored)

update rcsid

Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Wed Oct 18 08:43:36 1995 UTC (28 years, 8 months ago) by deraadt
CVS Tags: netbsd_1_1
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)

initial import of NetBSD tree

Revision 1.1 / (download) - annotate - [select for diffs], Wed Oct 18 08:43:36 1995 UTC (28 years, 8 months ago) by deraadt
Branch: MAIN

Initial revision

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.