OpenBSD CVS

CVS log for src/sbin/newfs_ext2fs/newfs_ext2fs.c


[BACK] Up to [local] / src / sbin / newfs_ext2fs

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.29 / (download) - annotate - [select for diffs], Sun Dec 4 23:50:47 2022 UTC (18 months ago) by cheloha
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, HEAD
Changes since 1.28: +1 -2 lines
Diff to previous 1.28 (colored)

userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument.  We can
handle this case with the "default" failure case with no loss of
legibility.  Hence, remove all the redundant "case '?':" lines.

Prompted by dlg@.  With help from dlg@ and millert@.

Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2

ok naddy@ millert@ dlg@

Revision 1.28 / (download) - annotate - [select for diffs], Sat Jun 26 15:42:58 2021 UTC (2 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0
Changes since 1.27: +1 -22 lines
Diff to previous 1.27 (colored)

delete extra explanations in the usage: messages which are described
far better in the manual pages
ok jmc

Revision 1.27 / (download) - annotate - [select for diffs], Fri Jun 28 13:32:45 2019 UTC (4 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.26: +4 -4 lines
Diff to previous 1.26 (colored)

When system calls indicate an error they return -1, not some arbitrary
value < 0.  errno is only updated in this case.  Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Revision 1.26 / (download) - annotate - [select for diffs], Sun Nov 25 17:12:10 2018 UTC (5 years, 6 months ago) by krw
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5
Changes since 1.25: +1 -4 lines
Diff to previous 1.25 (colored)

Remove (unused) FS_BOOT training wheels. If you are allowed to newfs a
partition, you obviously know what you are doing. Even (especially?)
if the new file system will be ffs or ext2fs.

ok deraadt@ as part of larger diff

Revision 1.25 / (download) - annotate - [select for diffs], Wed Mar 16 08:34:11 2016 UTC (8 years, 2 months ago) by natano
Branch: MAIN
CVS Tags: OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0
Changes since 1.24: +2 -2 lines
Diff to previous 1.24 (colored)

There's no reason to have execute permissions on a file system image.

ok millert

Revision 1.24 / (download) - annotate - [select for diffs], Mon Mar 14 20:30:34 2016 UTC (8 years, 2 months ago) by natano
Branch: MAIN
Changes since 1.23: +22 -54 lines
Diff to previous 1.23 (colored)

Replace an ad-hoc implementation of opendev(), with said function and
open the device only once with the correct flags, instead of twice (one
file handle for reading and one for writing). Committing this at once
because the changes are interrelated.

ok stefan

Revision 1.23 / (download) - annotate - [select for diffs], Mon Mar 14 20:14:30 2016 UTC (8 years, 2 months ago) by natano
Branch: MAIN
Changes since 1.22: +2 -2 lines
Diff to previous 1.22 (colored)

Add a missing "cpath" promise; newfs_ext2fs can create files when used
with the -F and -s flags.

ok stefan

Revision 1.22 / (download) - annotate - [select for diffs], Sun Dec 6 11:56:47 2015 UTC (8 years, 6 months ago) by tobias
Branch: MAIN
CVS Tags: OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.21: +6 -4 lines
Diff to previous 1.21 (colored)

Avoid out of boundary access on illegal command line arguments.

ok deraadt, mmcc, tedu

Revision 1.21 / (download) - annotate - [select for diffs], Sat Nov 28 06:12:09 2015 UTC (8 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.20: +2 -2 lines
Diff to previous 1.20 (colored)

Oops, left the pledge "tty" active in the previous commited
pointed out by Chris Hettrick

Revision 1.20 / (download) - annotate - [select for diffs], Thu Nov 26 06:59:12 2015 UTC (8 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.19: +9 -1 lines
Diff to previous 1.19 (colored)

Instead, hoist TIOCGWINSZ up to the top, then "tty" pledge is not needed.

Revision 1.19 / (download) - annotate - [select for diffs], Thu Nov 26 06:45:08 2015 UTC (8 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.18: +2 -2 lines
Diff to previous 1.18 (colored)

unbelievable.. this uses TIOCGWINSZ.. how did i miss that.  pledge "tty".

Revision 1.18 / (download) - annotate - [select for diffs], Mon Nov 23 19:19:30 2015 UTC (8 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.17: +4 -1 lines
Diff to previous 1.17 (colored)

Use pledge "disklabel" as needed.  The theory here is these tools become more
resistant against memory correctup, if a corrupt filesystem is given to them.
ok krw

Revision 1.17 / (download) - annotate - [select for diffs], Wed Oct 14 15:54:49 2015 UTC (8 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.16: +0 -4 lines
Diff to previous 1.16 (colored)

unfortunately rewritelabel() just before termination does a non-permitted
ioctl to rewrite the label, in support of the old-school "frag info in
the disklabel" concept.  disklabel folk, please come talk to me...

Revision 1.16 / (download) - annotate - [select for diffs], Tue Oct 13 15:15:30 2015 UTC (8 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.15: +5 -1 lines
Diff to previous 1.15 (colored)

can pledge "stdio" after opening device.

Revision 1.15 / (download) - annotate - [select for diffs], Fri Jan 16 06:40:00 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.14: +7 -4 lines
Diff to previous 1.14 (colored)

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible.  Annotate <sys/param.h> lines with their current reasons.  Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc.  Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution.  These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Revision 1.14 / (download) - annotate - [select for diffs], Thu Nov 20 15:22:39 2014 UTC (9 years, 6 months ago) by tedu
Branch: MAIN
Changes since 1.13: +2 -2 lines
Diff to previous 1.13 (colored)

remove sys/file.h includes in favor of fcntl.h where needed.
ok deraadt guenther

Revision 1.13 / (download) - annotate - [select for diffs], Sun Jun 29 00:32:50 2014 UTC (9 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6
Changes since 1.12: +1 -2 lines
Diff to previous 1.12 (colored)

do not need sys/disk.h

Revision 1.12 / (download) - annotate - [select for diffs], Wed May 21 06:23:01 2014 UTC (10 years ago) by guenther
Branch: MAIN
Changes since 1.11: +2 -2 lines
Diff to previous 1.11 (colored)

Use errc/warnc to simplify code.

ok jca@ krw@

Revision 1.11 / (download) - annotate - [select for diffs], Tue Apr 22 00:23:35 2014 UTC (10 years, 1 month ago) by guenther
Branch: MAIN
Changes since 1.10: +2 -2 lines
Diff to previous 1.10 (colored)

Clarify an err() message

Revision 1.10 / (download) - annotate - [select for diffs], Mon Apr 21 09:22:15 2014 UTC (10 years, 1 month ago) by guenther
Branch: MAIN
Changes since 1.9: +3 -3 lines
Diff to previous 1.9 (colored)

While we don't recommend using ext2fs, the directions for doing so
shouldn't be misleading

ok krw@

Revision 1.9 / (download) - annotate - [select for diffs], Fri Nov 22 04:14:01 2013 UTC (10 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_5_BASE, OPENBSD_5_5
Changes since 1.8: +3 -3 lines
Diff to previous 1.8 (colored)

Whole bunch of (unsigned char) casts carefully added for ctype calls.
Careful second audit by millert

Revision 1.8 / (download) - annotate - [select for diffs], Sun Oct 27 18:54:03 2013 UTC (10 years, 7 months ago) by guenther
Branch: MAIN
Changes since 1.7: +4 -4 lines
Diff to previous 1.7 (colored)

If a constant string needs a name, use a static const array instead of a
pointer or non-const array, as that minimizes the symbols, maximizes the
placement into read-only memory, and avoids warnings from gcc -Wformat=2
when they're used as format strings.

ok deraadt@

Revision 1.7 / (download) - annotate - [select for diffs], Tue Dec 4 02:27:00 2012 UTC (11 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3
Changes since 1.6: +1 -3 lines
Diff to previous 1.6 (colored)

remove some unnecessary sys/cdefs.h inclusions

Revision 1.6 / (download) - annotate - [select for diffs], Tue May 18 04:41:14 2010 UTC (14 years ago) by dlg
Branch: MAIN
CVS Tags: OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8
Changes since 1.5: +2 -1 lines
Diff to previous 1.5 (colored)

dont let sys/ioctl.h imply that you get the ioctls in dkio.h. this
gets rid of #include <sys/dkio.h> in sys/ioctl.h and adds #include
<sys/dkio.h> to the places that actually want and use the disk
ioctls.

this became an issue when krw@'s X build failed when he was testing
a change to dkio.h.
tested by krw@
help from and ok miod@

Revision 1.5 / (download) - annotate - [select for diffs], Thu Feb 18 07:58:14 2010 UTC (14 years, 3 months ago) by otto
Branch: MAIN
CVS Tags: OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.4: +5 -2 lines
Diff to previous 1.4 (colored)

Add -q flag for compatiblity with newfs as requested by miod@

Revision 1.4 / (download) - annotate - [select for diffs], Wed Feb 17 19:26:10 2010 UTC (14 years, 3 months ago) by otto
Branch: MAIN
Changes since 1.3: +5 -2 lines
Diff to previous 1.3 (colored)

handle -t for when being called by newfs

Revision 1.3 / (download) - annotate - [select for diffs], Tue Feb 16 12:25:35 2010 UTC (14 years, 3 months ago) by otto
Branch: MAIN
Changes since 1.2: +1 -1 lines
Diff to previous 1.2 (colored)

fix OpenBSD rcs tags, prompted by Tim van der Molen

Revision 1.2 / (download) - annotate - [select for diffs], Tue Feb 16 08:29:50 2010 UTC (14 years, 3 months ago) by otto
Branch: MAIN
Changes since 1.1: +1 -1 lines
Diff to previous 1.1 (colored)

default verbosity to 4

Revision 1.1 / (download) - annotate - [select for diffs], Tue Feb 16 08:25:55 2010 UTC (14 years, 3 months ago) by otto
Branch: MAIN

Port of newfs_ext2fs from NetBSD. not hooked to the build yet.
ok miod@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.