OpenBSD CVS

CVS log for src/sbin/pflogd/pflogd.c


[BACK] Up to [local] / src / sbin / pflogd

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.66 / (download) - annotate - [select for diffs], Fri Nov 17 12:10:23 2023 UTC (6 months, 3 weeks ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, HEAD
Changes since 1.65: +2 -2 lines
Diff to previous 1.65 (colored)

Do not log errors form pcap_dispatch() caused by signals.

pcap_dispatch() returns -1 (PCAP_ERROR) or -2 (PCAP_ERROR_BREAK) the
latter is used when a signal is received and is not an error. So limit
the code to log errors to np == -1.
OK semarie@ sashan@

Revision 1.65 / (download) - annotate - [select for diffs], Sun Nov 12 15:18:04 2023 UTC (6 months, 3 weeks ago) by dlg
Branch: MAIN
Changes since 1.64: +5 -5 lines
Diff to previous 1.64 (colored)

fix the signal numbers passed to siginterrupt.

from dhill@

Revision 1.64 / (download) - annotate - [select for diffs], Thu Nov 9 18:36:19 2023 UTC (6 months, 4 weeks ago) by dlg
Branch: MAIN
Changes since 1.63: +9 -1 lines
Diff to previous 1.63 (colored)

avoid restartable syscalls with siginterrupt() against all our handlers.

pflogd uses blocking bpf reads, but installs a bunch of signal
handlers to handle cleanly closing and (re)opening the log file.
signal() by default sets the handlers up so they're restartable.
this has the effect that when pflogd receives a signal while waiting
in bpfread, the signal handler runs and sets a flag saying the file
should be rotated or closed or whatever, but then the kernel restarts
the read.

when pflogd used a bpf read timeout, pflogd would run it's "event"
loop every time the read timeout expired. this meant even though
the bpf read was restarted, by having the read timeout expire every
500ms the flag the signal handlers set would be processed in a
relatively short period of time.

after moving bpf to a wait timeout, pflogd basically has to wait
for a packet to be captured before the bpf read will return. if
you're trying to kill pflogd on an idle firewall then you're basically
stuck.

making the signal handlers not restartable allows bpfread to fail
with EINTR so pflogd can go around it's even loop and exit as
expected.

reported by Mikhail on bugs@
ok claudio@

pflogd needs a rewrite though.

Revision 1.63 / (download) - annotate - [select for diffs], Tue May 9 00:01:59 2023 UTC (13 months ago) by dlg
Branch: MAIN
CVS Tags: OPENBSD_7_4_BASE, OPENBSD_7_4
Changes since 1.62: +3 -3 lines
Diff to previous 1.62 (colored)

switch pflogd from using a bpf read timeout to a wait timeout.

a bpf read timeout means every read will end after the timeout
expires. because pflogd has a half second read timeout it would sit
in a loop doing reads all the time even if there were no packets
to log.

the wait timeout means that when bpf catches a packet, it will wait
a bit for more packets to arrive before waking up the pending read.

pflogd now sits in the read syscall until packets are actually
available to log.

found by deraadt@ and ktrace
discussed with and ok sashan@

Revision 1.62 / (download) - annotate - [select for diffs], Thu Jul 25 17:32:33 2019 UTC (4 years, 10 months ago) by brynet
Branch: MAIN
CVS Tags: OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.61: +2 -1 lines
Diff to previous 1.61 (colored)

Fix copy pasto, re-add missing goto in error path.

Revision 1.61 / (download) - annotate - [select for diffs], Thu Jul 25 14:53:21 2019 UTC (4 years, 10 months ago) by brynet
Branch: MAIN
Changes since 1.60: +88 -2 lines
Diff to previous 1.60 (colored)

Yet another workaround for crappy libpcap API design

Add an internal version of pcap_open_live that ensures bpf(4) devices
are opened read-only before locking. Neither pflogd(8) or spamlogd(8)
require write access to bpf(4). Inspired by similar solution in
OpenBSD tcpdump(8).

pflogd(8) was safe since being unveiled last year, but spamlogd(8)
was having /dev/bpf opened O_RDWR.

Issue discovered by bluhm@'s unveil(2) accounting commit.

ok deraadt@, mestre@ (thanks for testing spamlogd!)

Revision 1.60 / (download) - annotate - [select for diffs], Fri Jun 28 13:32:45 2019 UTC (4 years, 11 months ago) by deraadt
Branch: MAIN
Changes since 1.59: +2 -2 lines
Diff to previous 1.59 (colored)

When system calls indicate an error they return -1, not some arbitrary
value < 0.  errno is only updated in this case.  Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Revision 1.59 / (download) - annotate - [select for diffs], Sun Aug 26 18:24:46 2018 UTC (5 years, 9 months ago) by brynet
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4
Changes since 1.58: +12 -31 lines
Diff to previous 1.58 (colored)

pflogd(8): don't try to rename(2) broken/invalid pflog files, instead,
suspend logging until the log file has been moved out of the way, and
we have received either SIGHUP or SIGALRM.

ok florian@ deraadt@

Revision 1.58 / (download) - annotate - [select for diffs], Sat Sep 9 13:02:52 2017 UTC (6 years, 9 months ago) by brynet
Branch: MAIN
CVS Tags: OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2
Changes since 1.57: +13 -15 lines
Diff to previous 1.57 (colored)

Rework pflogd(8)'s fork+exec model; re-exec the unpriv child, not the
privileged parent.

Based on feedback from deraadt@ and bluhm@ (worked on syslogd).

ok deraadt@

Revision 1.57 / (download) - annotate - [select for diffs], Fri Sep 8 13:34:29 2017 UTC (6 years, 9 months ago) by bluhm
Branch: MAIN
Changes since 1.56: +3 -2 lines
Diff to previous 1.56 (colored)

Bring back the "Exiting" log message in pflogd(8), but do not set
the LOG_CONS flag in openlog(3).  This avoids output to the console
on shutdown.  Discussed with benno@ who wants to see when a deamon
stops during normal system operation.
OK brynet@

Revision 1.56 / (download) - annotate - [select for diffs], Wed Sep 6 12:43:16 2017 UTC (6 years, 9 months ago) by brynet
Branch: MAIN
Changes since 1.55: +1 -2 lines
Diff to previous 1.55 (colored)

pflogd(8) currently spams the console on shutdown if syslogd(8) wins the
race to die, so just stop logging pflogd exits.

This logging probably comes from the fact that pflogd was largely based
on syslogd.

Removes the annoying "pflogd[23954]: Exiting" messages pointed out by
deraadt@

Also cleanup some missed SIGCHLD handling code that is no longer needed.

"LGTM" mikeb@

Revision 1.55 / (download) - annotate - [select for diffs], Tue Sep 5 15:41:25 2017 UTC (6 years, 9 months ago) by brynet
Branch: MAIN
Changes since 1.54: +18 -20 lines
Diff to previous 1.54 (colored)

fork+exec model for pflogd(8); move pcap init to the re-exec'd privsep
parent and use 'legit' fdpassing primitives to send the bpf fd to the
unprivileged child process.

Also reduces the pledge(2) promises in the unpriv child to just
   "stdio recvfd"

with help from deraadt, pcap feedback from canacar

ok deraadt@

Revision 1.54 / (download) - annotate - [select for diffs], Sun Jul 23 14:28:22 2017 UTC (6 years, 10 months ago) by jca
Branch: MAIN
Changes since 1.53: +2 -18 lines
Diff to previous 1.53 (colored)

Don't hit pledge(2) restrictions on interface departure

if_exists() can't be used after dropping privileges, since it uses
socket(2) and ioctl(SIOCGIFDATA).  We're just trying to know whether an
interface exists, and if_nametoindex(3) is enough for that.

ok deraadt@

Revision 1.53 / (download) - annotate - [select for diffs], Sat Jan 16 03:17:48 2016 UTC (8 years, 4 months ago) by canacar
Branch: MAIN
CVS Tags: OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.52: +2 -30 lines
Diff to previous 1.52 (colored)

Interface status printing (at exit and USR1) was broken for a while.
Remove it completely to simplify the code.
even better deraadt@

Revision 1.52 / (download) - annotate - [select for diffs], Sat Oct 10 22:36:06 2015 UTC (8 years, 8 months ago) by deraadt
Branch: MAIN
Changes since 1.51: +10 -3 lines
Diff to previous 1.51 (colored)

pflogd contained the same "privsep error" as tcpdump -- assuming that
it can ioctl()'s against a bpf device node.  Privsep that operation
via a message to the parent process.  Unfortunately "rpath wpath cpath"
is still needed due to SIGHUP handling, but I have asked canacar the
expert to look into this.

Revision 1.51 / (download) - annotate - [select for diffs], Sat Feb 7 02:09:13 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.50: +2 -2 lines
Diff to previous 1.50 (colored)

When getopt processing flags, many should be flag=1 instead of flag++
ok tedu miod

Revision 1.50 / (download) - annotate - [select for diffs], Thu Nov 20 15:22:39 2014 UTC (9 years, 6 months ago) by tedu
Branch: MAIN
Changes since 1.49: +1 -2 lines
Diff to previous 1.49 (colored)

remove sys/file.h includes in favor of fcntl.h where needed.
ok deraadt guenther

Revision 1.49 / (download) - annotate - [select for diffs], Tue Nov 6 02:50:47 2012 UTC (11 years, 7 months ago) by lteo
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3
Changes since 1.48: +5 -5 lines
Diff to previous 1.48 (colored)

Ensure that if_exists() always closes its socket before returning.

Also fix a bug where the return value of if_exists() was not checked
correctly if the interface disappears while pflogd is running.

ok beck henning

Revision 1.48 / (download) - annotate - [select for diffs], Mon Mar 5 11:50:16 2012 UTC (12 years, 3 months ago) by henning
Branch: MAIN
CVS Tags: OPENBSD_5_2_BASE, OPENBSD_5_2
Changes since 1.47: +2 -2 lines
Diff to previous 1.47 (colored)

fix format string:
use %zu for size_t and %d for signed ints
first one triggered by a mail from joerg @ netbsd, thanks.
ok millert dlg

Revision 1.47 / (download) - annotate - [select for diffs], Tue Nov 3 20:47:41 2009 UTC (14 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.46: +4 -9 lines
Diff to previous 1.46 (colored)

Get rid of pflogd.pid because the privsep child cannot delete the pidfile;
use pkill(1) in /etc/newsyslog.conf instead
together with otto and suggestions from tedu

Revision 1.46 / (download) - annotate - [select for diffs], Wed Oct 22 08:16:49 2008 UTC (15 years, 7 months ago) by henning
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5
Changes since 1.45: +29 -10 lines
Diff to previous 1.45 (colored)

log pcap stats upon SIGUSR1; ok canacar
From: Dave Harrison <dave@nullcube.com>

Revision 1.45 / (download) - annotate - [select for diffs], Wed Jun 6 14:11:26 2007 UTC (17 years ago) by henning
Branch: MAIN
CVS Tags: OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3, OPENBSD_4_2_BASE, OPENBSD_4_2
Changes since 1.44: +2 -2 lines
Diff to previous 1.44 (colored)

fix oups, mlist@scapa.dnsalias.net

Revision 1.44 / (download) - annotate - [select for diffs], Wed Jun 6 09:40:48 2007 UTC (17 years ago) by henning
Branch: MAIN
Changes since 1.43: +7 -7 lines
Diff to previous 1.43 (colored)

reverse logic of if_exists so that if_exists(interface) is true if
interface exists and !if_exists(interface) is when it doesn't

Revision 1.43 / (download) - annotate - [select for diffs], Mon Jun 4 13:55:24 2007 UTC (17 years ago) by henning
Branch: MAIN
Changes since 1.42: +7 -4 lines
Diff to previous 1.42 (colored)

use warn() where warn() is intended, not err()
exit nonzero if the inetrface does not exist
From: tbert <bret.lambert@gmail.com>

Revision 1.42 / (download) - annotate - [select for diffs], Sat Jun 2 20:38:58 2007 UTC (17 years ago) by henning
Branch: MAIN
Changes since 1.41: +3 -3 lines
Diff to previous 1.41 (colored)

do not shadow globals (in if_exists)

Revision 1.41 / (download) - annotate - [select for diffs], Sat Jun 2 20:38:14 2007 UTC (17 years ago) by henning
Branch: MAIN
Changes since 1.40: +10 -5 lines
Diff to previous 1.40 (colored)

on pcap error, check wether the interface went away and exit if it did.
spinning and flooding syslog in that case was not so nice.

Revision 1.40 / (download) - annotate - [select for diffs], Sun May 27 20:07:42 2007 UTC (17 years ago) by jdixon
Branch: MAIN
Changes since 1.39: +36 -1 lines
Diff to previous 1.39 (colored)

Complain to stderr if cloned pflog interface doesn't exist.  Previously only logged LOG_ERR to syslog.  ok henning@

Revision 1.39 / (download) - annotate - [select for diffs], Sat Apr 7 07:48:50 2007 UTC (17 years, 2 months ago) by jmc
Branch: MAIN
Changes since 1.38: +3 -3 lines
Diff to previous 1.38 (colored)

- use .Bk/.Ek to avoid SYNOPSIS splitting
- put -p in the correct place
- sync the -p argument name and tweak its description
- add -p to usage()

Revision 1.38 / (download) - annotate - [select for diffs], Fri Apr 6 16:30:49 2007 UTC (17 years, 2 months ago) by canacar
Branch: MAIN
Changes since 1.37: +7 -3 lines
Diff to previous 1.37 (colored)

Adds a pidfile argument to pflogd so that individual
instances can be rotated via newsyslog.
From Berk Demir < bdd at mindcast org >
ok henning@

Revision 1.37 / (download) - annotate - [select for diffs], Thu Oct 26 13:34:47 2006 UTC (17 years, 7 months ago) by jmc
Branch: MAIN
CVS Tags: OPENBSD_4_1_BASE, OPENBSD_4_1
Changes since 1.36: +3 -3 lines
Diff to previous 1.36 (colored)

- sort options
- sync usage()

Revision 1.36 / (download) - annotate - [select for diffs], Wed Oct 25 20:20:19 2006 UTC (17 years, 7 months ago) by henning
Branch: MAIN
Changes since 1.35: +11 -6 lines
Diff to previous 1.35 (colored)

allow pflogd to listen on alternate pflog interfaces
"Berk D. Demir" <bdd@mindcast.org> sent a diff in private, and then it
evolved quite a bit... ok djm canacar berk

Revision 1.35 / (download) - annotate - [select for diffs], Sun Jan 15 16:38:04 2006 UTC (18 years, 4 months ago) by canacar
Branch: MAIN
CVS Tags: OPENBSD_4_0_BASE, OPENBSD_4_0, OPENBSD_3_9_BASE, OPENBSD_3_9
Changes since 1.34: +37 -12 lines
Diff to previous 1.34 (colored)

If the log file is invalid/incompatible, try to rename the bad log file
and continue with a new name instead of suspending.
ok mcbride@

Revision 1.34 / (download) - annotate - [select for diffs], Mon Jul 4 22:35:48 2005 UTC (18 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_8_BASE, OPENBSD_3_8
Changes since 1.33: +5 -7 lines
Diff to previous 1.33 (colored)

do not whack errno before using it; Andrey Matveev

Revision 1.33 / (download) - annotate - [select for diffs], Wed Feb 9 12:09:30 2005 UTC (19 years, 4 months ago) by henning
Branch: MAIN
CVS Tags: OPENBSD_3_7_BASE, OPENBSD_3_7
Changes since 1.32: +2 -1 lines
Diff to previous 1.32 (colored)

missing tzset(), noticed by Chris Kuethe <chris.kuethe@gmail.com>

Revision 1.32 / (download) - annotate - [select for diffs], Sat Jan 8 18:51:18 2005 UTC (19 years, 5 months ago) by canacar
Branch: MAIN
Changes since 1.31: +2 -2 lines
Diff to previous 1.31 (colored)

Use the handler specified in phandler instead of always using
dump_packet. Report and patch from Peter Postma, thanks.

Revision 1.31 / (download) - annotate - [select for diffs], Fri Sep 17 07:11:55 2004 UTC (19 years, 8 months ago) by deraadt
Branch: MAIN
Changes since 1.30: +3 -2 lines
Diff to previous 1.30 (colored)

ugly spacing

Revision 1.30 / (download) - annotate - [select for diffs], Sun Aug 8 19:04:25 2004 UTC (19 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_6_BASE, OPENBSD_3_6
Changes since 1.29: +2 -2 lines
Diff to previous 1.29 (colored)

spacing

Revision 1.29 / (download) - annotate - [select for diffs], Sun May 23 19:00:26 2004 UTC (20 years ago) by deraadt
Branch: MAIN
Changes since 1.28: +7 -5 lines
Diff to previous 1.28 (colored)

use strtonum instead of atoi; dhartmei ok

Revision 1.28 / (download) - annotate - [select for diffs], Wed Apr 28 06:59:58 2004 UTC (20 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.27: +5 -1 lines
Diff to previous 1.27 (colored)

fd leaks; henning ok

Revision 1.27 / (download) - annotate - [select for diffs], Fri Feb 13 19:01:57 2004 UTC (20 years, 3 months ago) by otto
Branch: MAIN
CVS Tags: OPENBSD_3_5_BASE, OPENBSD_3_5
Changes since 1.26: +3 -1 lines
Diff to previous 1.26 (colored)

cleanup signal handling; close descriptors.
ok avsm@ millert@ canacar@

Revision 1.26 / (download) - annotate - [select for diffs], Fri Jan 16 10:45:49 2004 UTC (20 years, 4 months ago) by jmc
Branch: MAIN
Changes since 1.25: +2 -2 lines
Diff to previous 1.25 (colored)

- standard option order
- sync usage()
- new sentence, new line
- Dv (not Va) for signals
- other nits

ok canacar@

Revision 1.25 / (download) - annotate - [select for diffs], Thu Jan 15 20:15:14 2004 UTC (20 years, 4 months ago) by canacar
Branch: MAIN
Changes since 1.24: +297 -61 lines
Diff to previous 1.24 (colored)

Try to preserve the integrity of the log file in case of errors/unexpected
shutdowns etc. Also check logfile integrity on startup and suspend
logging if an inconsistency is detected.
ok dhartmei@

Revision 1.24 / (download) - annotate - [select for diffs], Wed Oct 22 19:53:15 2003 UTC (20 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.23: +2 -2 lines
Diff to previous 1.23 (colored)

spacing

Revision 1.23 / (download) - annotate - [select for diffs], Wed Oct 22 18:51:55 2003 UTC (20 years, 7 months ago) by canacar
Branch: MAIN
Changes since 1.22: +61 -55 lines
Diff to previous 1.22 (colored)

privilege seperated pflogd

_pflogd user and group must be created for proper operation.

ok frantzen@ henning@ mcbride@ deraadt@

Revision 1.22 / (download) - annotate - [select for diffs], Fri Sep 26 16:14:33 2003 UTC (20 years, 8 months ago) by deraadt
Branch: MAIN
Changes since 1.21: +1 -2 lines
Diff to previous 1.21 (colored)

Walking up to a firewall box which had the console logged in, to see
the entire screen full of "Reopened logfile" is CLEAR and OBVIOUS reason
that that message is UTTERLY USELESS and is wiping important stuff off
the screen.

Revision 1.21 / (download) - annotate - [select for diffs], Fri Aug 22 21:50:34 2003 UTC (20 years, 9 months ago) by david
Branch: MAIN
CVS Tags: OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.20: +2 -2 lines
Diff to previous 1.20 (colored)

pf spelling police
ok dhartmei@ jmc@

Revision 1.20 / (download) - annotate - [select for diffs], Wed May 14 08:56:12 2003 UTC (21 years, 1 month ago) by canacar
Branch: MAIN
Changes since 1.19: +12 -6 lines
Diff to previous 1.19 (colored)

pflogd now uses the new pflog link type. Trying to append to an existing
old-style logfile will fail. Move away old log files.

ok henning@ dhartmei@ frantzen@

Revision 1.19 / (download) - annotate - [select for diffs], Wed Apr 23 22:44:53 2003 UTC (21 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.18: +1 -3 lines
Diff to previous 1.18 (colored)

most programs do not syslog at startup.  especially this one

Revision 1.18 / (download) - annotate - [select for diffs], Tue Mar 11 02:35:34 2003 UTC (21 years, 3 months ago) by kjc
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3
Changes since 1.17: +6 -7 lines
Diff to previous 1.17 (colored)

always compile and set pcap filters even when filters are not specified.
bpf implements snaplen by filters and captures full packets when filters
are not set.

ok deraadt@, dhartmei@

Revision 1.17 / (download) - annotate - [select for diffs], Sat Mar 1 06:11:20 2003 UTC (21 years, 3 months ago) by cloder
Branch: MAIN
Changes since 1.16: +30 -15 lines
Diff to previous 1.16 (colored)

Add ANSI prototypes.  Get rid of shadow warnings.  Use correct
printf format specifiers where needed.  Clarify one comment.
Now compiles with -Wmissing-prototypes -Wshadow, and this is
reflected in the Makefile.
OK deraadt@

Revision 1.16 / (download) - annotate - [select for diffs], Sat Nov 30 23:02:10 2002 UTC (21 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.15: +2 -2 lines
Diff to previous 1.15 (colored)

oops

Revision 1.15 / (download) - annotate - [select for diffs], Sat Nov 30 19:36:05 2002 UTC (21 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.14: +26 -25 lines
Diff to previous 1.14 (colored)

do not syslog with extra newline

Revision 1.14 / (download) - annotate - [select for diffs], Thu Oct 17 09:12:04 2002 UTC (21 years, 7 months ago) by dhartmei
Branch: MAIN
Changes since 1.13: +13 -12 lines
Diff to previous 1.13 (colored)

Style nits and missing free(), from david@phobia.ms

Revision 1.13 / (download) - annotate - [select for diffs], Tue Sep 3 18:28:49 2002 UTC (21 years, 9 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_2_BASE, OPENBSD_3_2
Changes since 1.12: +3 -2 lines
Diff to previous 1.12 (colored)

use sig_atomic_t; cloder

Revision 1.12 / (download) - annotate - [select for diffs], Thu May 23 09:51:12 2002 UTC (22 years ago) by deraadt
Branch: MAIN
Changes since 1.11: +5 -5 lines
Diff to previous 1.11 (colored)

minor KNF encountered while doing yet another boring 4AM source code audit...

Revision 1.11 / (download) - annotate - [select for diffs], Wed May 8 17:28:34 2002 UTC (22 years, 1 month ago) by jasoni
Branch: MAIN
Changes since 1.10: +3 -3 lines
Diff to previous 1.10 (colored)

add a newline after pcap error string (as pcap_geterr() doesn't).
- ok dhartmei@ (a long time ago)

Revision 1.10 / (download) - annotate - [select for diffs], Mon Jan 21 07:46:09 2002 UTC (22 years, 4 months ago) by dhartmei
Branch: MAIN
CVS Tags: OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.9: +2 -2 lines
Diff to previous 1.9 (colored)

deamon -> daemon, from Alexander Yurchenko

Revision 1.9 / (download) - annotate - [select for diffs], Sat Dec 1 23:27:23 2001 UTC (22 years, 6 months ago) by miod
Branch: MAIN
Changes since 1.8: +3 -9 lines
Diff to previous 1.8 (colored)

Use pidfile() instead of doing the equivalent thing by hand, and sometimes
forgetting to unlink the pid file at exit.
ok millert@ deraadt@

Revision 1.8 / (download) - annotate - [select for diffs], Wed Oct 10 14:30:08 2001 UTC (22 years, 8 months ago) by mpech
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0
Changes since 1.7: +3 -1 lines
Diff to previous 1.7 (colored)

umask. spotted by form@

deraadt@, dhartmei@ ok

Revision 1.7 / (download) - annotate - [select for diffs], Wed Aug 29 17:42:28 2001 UTC (22 years, 9 months ago) by deraadt
Branch: MAIN
Changes since 1.6: +3 -6 lines
Diff to previous 1.6 (colored)

kill the -i option; it just causes all sorts of grief; canacar@eee.metu.edu.tr

Revision 1.6 / (download) - annotate - [select for diffs], Fri Aug 24 19:48:37 2001 UTC (22 years, 9 months ago) by deraadt
Branch: MAIN
Changes since 1.5: +12 -1 lines
Diff to previous 1.5 (colored)

move back to requested snaplen after SIGHUP; canacar@eee.metu.edu.tr

Revision 1.5 / (download) - annotate - [select for diffs], Fri Aug 24 19:46:32 2001 UTC (22 years, 9 months ago) by deraadt
Branch: MAIN
Changes since 1.4: +71 -42 lines
Diff to previous 1.4 (colored)

rearrange so that snaplen cannot be changed; canacar@eee.metu.edu.tr

Revision 1.4 / (download) - annotate - [select for diffs], Thu Aug 23 04:07:33 2001 UTC (22 years, 9 months ago) by deraadt
Branch: MAIN
Changes since 1.3: +3 -3 lines
Diff to previous 1.3 (colored)

fix usage

Revision 1.3 / (download) - annotate - [select for diffs], Thu Aug 23 04:06:12 2001 UTC (22 years, 9 months ago) by deraadt
Branch: MAIN
Changes since 1.2: +21 -1 lines
Diff to previous 1.2 (colored)

do not permit snaplen change on an active log file

Revision 1.2 / (download) - annotate - [select for diffs], Wed Aug 22 14:49:37 2001 UTC (22 years, 9 months ago) by deraadt
Branch: MAIN
Changes since 1.1: +8 -4 lines
Diff to previous 1.1 (colored)

properly handle empty log file

Revision 1.1 / (download) - annotate - [select for diffs], Tue Aug 21 22:29:14 2001 UTC (22 years, 9 months ago) by deraadt
Branch: MAIN

pflogd; work by canacar@eee.metu.edu.tr and myself

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.