OpenBSD CVS

CVS log for src/sys/dev/ipmi.c


[BACK] Up to [local] / src / sys / dev

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.119 / (download) - annotate - [select for diffs], Wed Apr 3 18:32:47 2024 UTC (2 months, 1 week ago) by gkoehler
Branch: MAIN
CVS Tags: HEAD
Changes since 1.118: +3 -2 lines
Diff to previous 1.118 (colored)

Change ipmi(4)'s taskq from IPL_NONE to IPL_MPFLOOR

The IPL_NONE mutex didn't block interrupts that can cause a powerpc64
kernel with option WITNESS to "panic: acquiring blockable sleep lock
with spinlock or critical section held (kernel_lock) &kernel_lock".

ok mpi@

Revision 1.118 / (download) - annotate - [select for diffs], Fri Apr 8 13:13:14 2022 UTC (2 years, 2 months ago) by mbuhl
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2
Changes since 1.117: +4 -3 lines
Diff to previous 1.117 (colored)

fix leaking memory in get_sdr on failure.
Found by LLVM scan-build.
ok sthen@

Revision 1.117 / (download) - annotate - [select for diffs], Thu Apr 7 17:36:38 2022 UTC (2 years, 2 months ago) by sthen
Branch: MAIN
Changes since 1.116: +36 -13 lines
Diff to previous 1.116 (colored)

Support more power sensors in IPMI. Tested on several Supermicro and Dell
amd64 boxes and Lenovo (Ampere) aarch64. tweak/OK mbuhl@

Revision 1.116 / (download) - annotate - [select for diffs], Wed Apr 6 18:59:27 2022 UTC (2 years, 2 months ago) by naddy
Branch: MAIN
Changes since 1.115: +2 -2 lines
Diff to previous 1.115 (colored)

constify struct cfattach

Revision 1.115 / (download) - annotate - [select for diffs], Sat Jan 23 12:10:08 2021 UTC (3 years, 4 months ago) by kettenis
Branch: MAIN
CVS Tags: OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9
Changes since 1.114: +1 -5 lines
Diff to previous 1.114 (colored)

OPAL implements firmware calls that abstract communicating with the BMC over
IPMI.  Use these calls to add support for impi(4) on PowerNV systems.

ok dlg@

Revision 1.114 / (download) - annotate - [select for diffs], Fri Dec 11 19:48:58 2020 UTC (3 years, 5 months ago) by cheloha
Branch: MAIN
Changes since 1.113: +2 -4 lines
Diff to previous 1.113 (colored)

ipmi(4): ipmi_poll_thread(): remove sleep loop

This tsleep_nsec(9) call does not set PCATCH and there are no other
threads calling wakeup(9) so there is no need to spin until we get
EWOULDBLOCK.  It always returns EWOULDBLOCK.

Idea from claudio@.

ok claudio@

Revision 1.113 / (download) - annotate - [select for diffs], Fri Dec 11 04:00:33 2020 UTC (3 years, 6 months ago) by cheloha
Branch: MAIN
Changes since 1.112: +3 -2 lines
Diff to previous 1.112 (colored)

ipmi(4): tsleep(9) -> tsleep_nsec(9)

Tested by sthen@.

ok mpi@

Revision 1.112 / (download) - annotate - [select for diffs], Sun Mar 29 09:31:10 2020 UTC (4 years, 2 months ago) by kettenis
Branch: MAIN
CVS Tags: OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7
Changes since 1.111: +15 -5 lines
Diff to previous 1.111 (colored)

Add glue to make ipmi(4) attach to FDT.

ok deraadt@

Revision 1.111 / (download) - annotate - [select for diffs], Thu Mar 19 16:17:51 2020 UTC (4 years, 2 months ago) by tracey
Branch: MAIN
Changes since 1.110: +3 -2 lines
Diff to previous 1.110 (colored)

Plug memory leak of psensor if read_sensor does not return zero.
CID 1491654
ok mpi@ kn@ florian@

Revision 1.110 / (download) - annotate - [select for diffs], Mon Mar 9 04:51:24 2020 UTC (4 years, 3 months ago) by yasuoka
Branch: MAIN
Changes since 1.109: +6 -1 lines
Diff to previous 1.109 (colored)

Return error value when sending "sensor reading" is failed. This fixes
"ipmi0: sendcmd fails" errors when there is a sensor which is
enumurated but reading it is failed.

ok mpi

Revision 1.109 / (download) - annotate - [select for diffs], Tue Feb 18 00:06:12 2020 UTC (4 years, 3 months ago) by cheloha
Branch: MAIN
Changes since 1.108: +4 -3 lines
Diff to previous 1.108 (colored)

ipmi(4): tsleep(9) -> tsleep_nsec(9)

There remains a polling sleep in this driver.  We can fix it separately.

ok mpi@

Revision 1.108 / (download) - annotate - [select for diffs], Sat Jan 11 18:51:54 2020 UTC (4 years, 5 months ago) by kettenis
Branch: MAIN
Changes since 1.107: +3 -3 lines
Diff to previous 1.107 (colored)

Make sure we use signed types in the sensor value calculation; 'char' is
unsigned on some of our hardware platforms!

ok deraadt@

Revision 1.107 / (download) - annotate - [select for diffs], Tue Dec 31 10:05:32 2019 UTC (4 years, 5 months ago) by mpi
Branch: MAIN
Changes since 1.106: +2 -2 lines
Diff to previous 1.106 (colored)

Convert infinite sleeps to {m,t}sleep_nsec(9).

ok kn@

Revision 1.106 / (download) - annotate - [select for diffs], Thu Dec 19 09:01:50 2019 UTC (4 years, 5 months ago) by kettenis
Branch: MAIN
Changes since 1.105: +3 -3 lines
Diff to previous 1.105 (colored)

Use bus_size_t as the type for the base address.

ok deraadt@, dlg@

Revision 1.105 / (download) - annotate - [select for diffs], Mon Aug 19 18:31:02 2019 UTC (4 years, 9 months ago) by kettenis
Branch: MAIN
CVS Tags: OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.104: +15 -9 lines
Diff to previous 1.104 (colored)

Add support for SMBus System Interface (SSIF).

ok jmatthew@

Revision 1.104 / (download) - annotate - [select for diffs], Tue Aug 13 18:31:23 2019 UTC (4 years, 9 months ago) by kettenis
Branch: MAIN
Changes since 1.103: +217 -185 lines
Diff to previous 1.103 (colored)

Reorganize the ipmi(4) code a bit in anticipation of adding SSIF support:
- Put function prototypes in more logical places.
- Inroduce a ipmi_attach_common() function.
- Move all the SMBIOS related code to the end of the file and only
  compile it in on amd64 & i386.

ok jmatthew@ and deraadt@

Revision 1.103 / (download) - annotate - [select for diffs], Mon Aug 12 09:56:47 2019 UTC (4 years, 10 months ago) by kettenis
Branch: MAIN
Changes since 1.102: +1 -7 lines
Diff to previous 1.102 (colored)

Remlve command mutex.  It is unnecessary since commands are already
serialized by the use of a taskq and it prevents sendmsg/endmsg from
being able to sleep.  This hurts when implementing SSIF since some
i2c controllers sleep while waiting for transactions on the i2c bus to
complete.

ok jmatthew@, deraadt@

Revision 1.102 / (download) - annotate - [select for diffs], Fri Jun 15 12:21:41 2018 UTC (5 years, 11 months ago) by yasuoka
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4
Changes since 1.101: +3 -3 lines
Diff to previous 1.101 (colored)

Use IPL_MPFLOOR for ipmi mutex to prevent a interrupt which requires
KERNEL_LOCK().  This fixes the panic with with witness.
diff from fukaumi at soum.co.jp.

input and ok mpi

Revision 1.101 / (download) - annotate - [select for diffs], Fri Apr 13 05:33:38 2018 UTC (6 years, 2 months ago) by yasuoka
Branch: MAIN
Changes since 1.100: +5 -7 lines
Diff to previous 1.100 (colored)

Don't panic if ipmi_sendcmd() fails
diff from fukaumi at soum.co.jp.

ok deraadt mpi

Revision 1.100 / (download) - annotate - [select for diffs], Mon Jan 1 16:16:23 2018 UTC (6 years, 5 months ago) by bluhm
Branch: MAIN
CVS Tags: OPENBSD_6_3_BASE, OPENBSD_6_3
Changes since 1.99: +2 -2 lines
Diff to previous 1.99 (colored)

The missing NULL check for the return value of malloc(9) with
M_NOWAIT is wrong.  Use M_WAITOK in ipmi_match() during attach.
OK kettenis@

Revision 1.99 / (download) - annotate - [select for diffs], Fri Sep 8 05:36:52 2017 UTC (6 years, 9 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_2_BASE, OPENBSD_6_2
Changes since 1.98: +1 -2 lines
Diff to previous 1.98 (colored)

If you use sys/param.h, you don't need sys/types.h

Revision 1.98 / (download) - annotate - [select for diffs], Thu Jun 29 03:48:44 2017 UTC (6 years, 11 months ago) by tedu
Branch: MAIN
Changes since 1.97: +2 -1 lines
Diff to previous 1.97 (colored)

set c.c_maxrxlen to something. apparently lost a line somewhere.
maybe it works now? :)
from Colin Stolley via Paul B. Henson

Revision 1.97 / (download) - annotate - [select for diffs], Tue Jun 7 01:31:54 2016 UTC (8 years ago) by tedu
Branch: MAIN
CVS Tags: OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0
Changes since 1.96: +2 -2 lines
Diff to previous 1.96 (colored)

per trending style, add continue to empty loops.
ok mglocker

Revision 1.96 / (download) - annotate - [select for diffs], Sun Mar 27 12:45:47 2016 UTC (8 years, 2 months ago) by mpi
Branch: MAIN
Changes since 1.95: +2 -2 lines
Diff to previous 1.95 (colored)

Always sleep at same priority.

ok uebayasi@

Revision 1.95 / (download) - annotate - [select for diffs], Thu Feb 11 04:02:22 2016 UTC (8 years, 4 months ago) by uebayasi
Branch: MAIN
CVS Tags: OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.94: +28 -10 lines
Diff to previous 1.94 (colored)

ipmi(4) - Check sensor name length more carefully

Don't blindly trust sensor name info returned from BMC.  Check them more
carefully.  Prevent DELL R210 II from panic'ing.

Problem reported & tested by sthen@
Much feedback & close review & OK by jsg@

Revision 1.94 / (download) - annotate - [select for diffs], Sun Feb 7 12:19:14 2016 UTC (8 years, 4 months ago) by uebayasi
Branch: MAIN
Changes since 1.93: +2 -1 lines
Diff to previous 1.93 (colored)

Comment.

Revision 1.93 / (download) - annotate - [select for diffs], Sun Feb 7 12:17:33 2016 UTC (8 years, 4 months ago) by uebayasi
Branch: MAIN
Changes since 1.92: +2 -3 lines
Diff to previous 1.92 (colored)

Remove a too strict assertion.

Revision 1.92 / (download) - annotate - [select for diffs], Fri Feb 5 06:29:01 2016 UTC (8 years, 4 months ago) by uebayasi
Branch: MAIN
Changes since 1.91: +210 -147 lines
Diff to previous 1.91 (colored)

Implement FreeBSD-compatible IOCTL to access BMC in ipmi(4)

Initial help & testing by jmatthew@
Code review & input by mpi@
Final review & OK by jsg@

Revision 1.91 / (download) - annotate - [select for diffs], Mon Jan 25 06:36:47 2016 UTC (8 years, 4 months ago) by uebayasi
Branch: MAIN
Changes since 1.90: +3 -3 lines
Diff to previous 1.90 (colored)

Replace magic numbers.

Revision 1.90 / (download) - annotate - [select for diffs], Tue Jan 12 10:44:32 2016 UTC (8 years, 5 months ago) by uebayasi
Branch: MAIN
Changes since 1.89: +46 -3 lines
Diff to previous 1.89 (colored)

Use task to execute command except polling context.

Revision 1.89 / (download) - annotate - [select for diffs], Tue Jan 12 09:11:59 2016 UTC (8 years, 5 months ago) by uebayasi
Branch: MAIN
Changes since 1.88: +10 -1 lines
Diff to previous 1.88 (colored)

Use task to execute watchdog tickle.

Revision 1.88 / (download) - annotate - [select for diffs], Tue Jan 12 07:43:05 2016 UTC (8 years, 5 months ago) by uebayasi
Branch: MAIN
Changes since 1.87: +45 -27 lines
Diff to previous 1.87 (colored)

Refactor ipmi_watchdog(); split tickle and set into separate functions.

Revision 1.87 / (download) - annotate - [select for diffs], Mon Jan 11 14:39:23 2016 UTC (8 years, 5 months ago) by uebayasi
Branch: MAIN
Changes since 1.86: +52 -49 lines
Diff to previous 1.86 (colored)

Make sendmsg() and recvmsg() functions take only struct ipmi_cmd *.
Handle interface specific command length more nicely.  No functional
changes.

Revision 1.86 / (download) - annotate - [select for diffs], Mon Jan 11 14:29:40 2016 UTC (8 years, 5 months ago) by uebayasi
Branch: MAIN
Changes since 1.85: +18 -41 lines
Diff to previous 1.85 (colored)

Allocate command data buffer on softc and use it from both ipmi_sendcmd()
and ipmi_recvcmd().  No functional changes.

Revision 1.85 / (download) - annotate - [select for diffs], Mon Jan 11 14:08:58 2016 UTC (8 years, 5 months ago) by uebayasi
Branch: MAIN
Changes since 1.84: +22 -23 lines
Diff to previous 1.84 (colored)

Refactor buildmsg() functions to take struct ipmi_cmd * instead of 6
arguments.  No functional changes.

Revision 1.84 / (download) - annotate - [select for diffs], Mon Jan 11 13:12:50 2016 UTC (8 years, 5 months ago) by uebayasi
Branch: MAIN
Changes since 1.83: +119 -77 lines
Diff to previous 1.83 (colored)

Introduce struct ipmi_cmd and have ipmi_cmd() function.  IPMI command
sequence is always a pair of send and receive; call both from ipmi_cmd().
By making ipmi_cmd() take only one argument struct ipmi_cmd *, this also
helps to prepare to call ipmi_cmd() as a task.

No functional changes intended.

Revision 1.83 / (download) - annotate - [select for diffs], Mon Jan 11 12:54:33 2016 UTC (8 years, 5 months ago) by uebayasi
Branch: MAIN
Changes since 1.82: +2 -10 lines
Diff to previous 1.82 (colored)

Remove useless sc_poll flag because it is always 1.  Remove unused global
ipmi_poll too.

Revision 1.82 / (download) - annotate - [select for diffs], Mon Jan 11 12:52:24 2016 UTC (8 years, 5 months ago) by uebayasi
Branch: MAIN
Changes since 1.81: +3 -3 lines
Diff to previous 1.81 (colored)

Read values from disabled sensors if possible.  From jmatthew@.

Revision 1.81 / (download) - annotate - [select for diffs], Sun Jan 10 14:44:09 2016 UTC (8 years, 5 months ago) by uebayasi
Branch: MAIN
Changes since 1.80: +6 -2 lines
Diff to previous 1.80 (colored)

Print a message to console when ipmi(4) watchdog is either enabled or
disabled.  Replace a magic number while here.

Revision 1.80 / (download) - annotate - [select for diffs], Sun Jan 10 14:17:00 2016 UTC (8 years, 5 months ago) by uebayasi
Branch: MAIN
Changes since 1.79: +2 -0 lines
Diff to previous 1.79 (colored)

When stopping wdog (via wdog_shutdown() e.g. before entering shutdown),
clear DONTSTOP bits.  Without this, BMC records, at least on some NEC
servers, watchdog timer expiration event, which only confuses admins.

OK kettenis@

Revision 1.79 / (download) - annotate - [select for diffs], Sat Jan 9 05:51:54 2016 UTC (8 years, 5 months ago) by uebayasi
Branch: MAIN
Changes since 1.78: +7 -36 lines
Diff to previous 1.78 (colored)

Correct sensor threashold handling by properly checking response of Get Sensor
Reading Command.

Patch from jmatthew@.  Extra review by kettenis@.  Tested by me.

Revision 1.78 / (download) - annotate - [select for diffs], Thu Jan 7 03:21:28 2016 UTC (8 years, 5 months ago) by uebayasi
Branch: MAIN
Changes since 1.77: +3 -2 lines
Diff to previous 1.77 (colored)

Copy received data only if it exists.  Avoid panics in odd situations.

Revision 1.77 / (download) - annotate - [select for diffs], Tue Sep 8 11:58:58 2015 UTC (8 years, 9 months ago) by deraadt
Branch: MAIN
Changes since 1.76: +6 -6 lines
Diff to previous 1.76 (colored)

sizes for free(); ok semarie

Revision 1.76 / (download) - annotate - [select for diffs], Sun Jun 21 00:15:12 2015 UTC (8 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8
Changes since 1.75: +4 -2 lines
Diff to previous 1.75 (colored)

memory leak on failure; from Maxime Villard

Revision 1.75 / (download) - annotate - [select for diffs], Wed Jan 7 07:49:18 2015 UTC (9 years, 5 months ago) by yasuoka
Branch: MAIN
CVS Tags: OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.74: +17 -10 lines
Diff to previous 1.74 (colored)

Fix impi(4) to make watchdog work and not to panic.

diff from uebayasi jsg
ok uebayasi

Revision 1.74 / (download) - annotate - [select for diffs], Wed Dec 10 12:27:57 2014 UTC (9 years, 6 months ago) by mikeb
Branch: MAIN
Changes since 1.73: +16 -2 lines
Diff to previous 1.73 (colored)

Convert watchdog(4) devices to use autoconf(9) framework.

ok deraadt, tests on glxpcib and ok mpi

Revision 1.73 / (download) - annotate - [select for diffs], Tue Oct 21 08:48:38 2014 UTC (9 years, 7 months ago) by uebayasi
Branch: MAIN
Changes since 1.72: +7 -5 lines
Diff to previous 1.72 (colored)

Style + typos in debug printfs.

Revision 1.72 / (download) - annotate - [select for diffs], Sat Jul 12 18:48:17 2014 UTC (9 years, 11 months ago) by tedu
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6
Changes since 1.71: +5 -5 lines
Diff to previous 1.71 (colored)

add a size argument to free. will be used soon, but for now default to 0.
after discussions with beck deraadt kettenis.

Revision 1.71 / (download) - annotate - [select for diffs], Tue Jul 8 17:19:25 2014 UTC (9 years, 11 months ago) by deraadt
Branch: MAIN
Changes since 1.70: +1 -3 lines
Diff to previous 1.70 (colored)

decouple struct uvmexp into a new file, so that uvm_extern.h and sysctl.h
don't need to be married.
ok guenther miod beck jsing kettenis

Revision 1.70 / (download) - annotate - [select for diffs], Sun May 4 18:18:36 2014 UTC (10 years, 1 month ago) by sf
Branch: MAIN
Changes since 1.69: +3 -3 lines
Diff to previous 1.69 (colored)

format string fix for bus_space_tag_t

bus_space_tag_t is a pointer everywhere, except on i386, where it's an int.
Cast to long.

ok kettenis@
'Right idiom' deraadt@

Revision 1.69 / (download) - annotate - [select for diffs], Wed Jul 3 15:10:57 2013 UTC (10 years, 11 months ago) by bluhm
Branch: MAIN
CVS Tags: OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4
Changes since 1.68: +13 -7 lines
Diff to previous 1.68 (colored)

The ipmi threshold value may be negative.  Respect the sign bit
when checking wether an ipmi sensor is critial.
From Matthias Pitzl; OK deraadt@

Revision 1.68 / (download) - annotate - [select for diffs], Wed Apr 10 01:35:55 2013 UTC (11 years, 2 months ago) by guenther
Branch: MAIN
Changes since 1.67: +2 -2 lines
Diff to previous 1.67 (colored)

Fix various glitches in queue macro usage.

ok millert@

Revision 1.67 / (download) - annotate - [select for diffs], Fri Dec 21 17:30:39 2012 UTC (11 years, 5 months ago) by gsoares
Branch: MAIN
CVS Tags: OPENBSD_5_3_BASE, OPENBSD_5_3
Changes since 1.66: +7 -9 lines
Diff to previous 1.66 (colored)

tweak for malloc(9) calls:
- M_CANFAIL is useless here since that M_NOWAIT will return NULL immediately if no resources.

OK mikeb@ mpi@

Revision 1.66 / (download) - annotate - [select for diffs], Wed Oct 17 22:32:01 2012 UTC (11 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.65: +2 -2 lines
Diff to previous 1.65 (colored)

Swap arguments to wdog_register() since it is nicer, and prepare
wdog_shutdown() for external usage.

Revision 1.65 / (download) - annotate - [select for diffs], Mon May 24 14:25:20 2010 UTC (14 years ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8
Changes since 1.64: +2 -2 lines
Diff to previous 1.64 (colored)

We sometimes compile kernels with -Wvariable-decl because it makes us
happier regarding potential kernel stack overflows, so just use the
(small) maximum buffer size in one case.
ok marco

Revision 1.64 / (download) - annotate - [select for diffs], Wed Jun 11 23:22:07 2008 UTC (16 years ago) by cnst
Branch: MAIN
CVS Tags: OPENBSD_4_7_BASE, OPENBSD_4_7, OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4
Changes since 1.63: +3 -2 lines
Diff to previous 1.63 (colored)

replace the last missing xname header before an error message in get_sdr(); ok deraadt

Revision 1.63 / (download) - annotate - [select for diffs], Sat Feb 16 05:20:31 2008 UTC (16 years, 3 months ago) by cnst
Branch: MAIN
CVS Tags: OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.62: +5 -5 lines
Diff to previous 1.62 (colored)

Call sensordev_install() iff we find and sensor_attach() the individual sensors.
The call got misplaced in ipmi.c#rev1.59 on 2007-08-31.
ok marco; tested todd

Revision 1.62 / (download) - annotate - [select for diffs], Sun Nov 25 23:37:01 2007 UTC (16 years, 6 months ago) by marco
Branch: MAIN
Changes since 1.61: +10 -8 lines
Diff to previous 1.61 (colored)

KNF and remove a bad free right before kthread_exit

Revision 1.61 / (download) - annotate - [select for diffs], Thu Nov 1 19:24:46 2007 UTC (16 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.60: +4 -4 lines
Diff to previous 1.60 (colored)

correct ipmi attach time failure messages (why this one machine fails...
still has to be looked at by marco when he has time)

Revision 1.60 / (download) - annotate - [select for diffs], Mon Oct 8 04:15:15 2007 UTC (16 years, 8 months ago) by krw
Branch: MAIN
Changes since 1.59: +3 -5 lines
Diff to previous 1.59 (colored)

More simple memset(,0,) -> M_ZERO changes. In this batch move to
size(*p) as the first malloc() parameter where p is declared locally
and thus easy to check. Add M_ZERO to gpe_table allocation in acpi.c
even though there is no obvious bzero or memset nearby.

Revision 1.59 / (download) - annotate - [select for diffs], Fri Aug 31 18:44:50 2007 UTC (16 years, 9 months ago) by marco
Branch: MAIN
Changes since 1.58: +25 -23 lines
Diff to previous 1.58 (colored)

Defer ipmi sensor creation after kernel goes multi user.  This removes the
annoying waiting period during kernel boots.

pushed for by deraadt and beck
Lots of testing todd, ckuethe and others
ok beck

Revision 1.58 / (download) - annotate - [select for diffs], Tue May 29 06:36:56 2007 UTC (17 years ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_4_2_BASE, OPENBSD_4_2
Changes since 1.57: +3 -1 lines
Diff to previous 1.57 (colored)

Correct fix for the last backout use strlcpy() to fill dv_xname. OK beck@

Revision 1.57 / (download) - annotate - [select for diffs], Tue May 29 06:28:23 2007 UTC (17 years ago) by claudio
Branch: MAIN
Changes since 1.56: +1 -2 lines
Diff to previous 1.56 (colored)

back out last commit. It helps to compile before commiting. OK beck@ art@

Revision 1.56 / (download) - annotate - [select for diffs], Tue May 29 05:54:00 2007 UTC (17 years ago) by deraadt
Branch: MAIN
Changes since 1.55: +2 -1 lines
Diff to previous 1.55 (colored)

work around really bad softc abuse by marco; proper fixes for this will
be part of a later rototilling

Revision 1.55 / (download) - annotate - [select for diffs], Fri Apr 13 18:57:56 2007 UTC (17 years, 2 months ago) by reyk
Branch: MAIN
Changes since 1.54: +16 -5 lines
Diff to previous 1.54 (colored)

move the debugging messages into #ifdef IPMI_DEBUG, we do not need to
compile them by default.

ok marco@

Revision 1.54 / (download) - annotate - [select for diffs], Sun Apr 8 05:48:18 2007 UTC (17 years, 2 months ago) by marco
Branch: MAIN
Changes since 1.53: +3 -1 lines
Diff to previous 1.53 (colored)

x4100 machines need a hold off in between reads and write to the bmc

Revision 1.53 / (download) - annotate - [select for diffs], Thu Mar 22 16:55:31 2007 UTC (17 years, 2 months ago) by deraadt
Branch: MAIN
Changes since 1.52: +2 -2 lines
Diff to previous 1.52 (colored)

split userland & kernel struct sensor/sensordev so that the addition
of new fields in the future is less disruptive.  This is done similar
to how struct proc is handled for ps(1).  ok jmc (man page changes)
tested fkr simon, and more suggestions from millert

Revision 1.52 / (download) - annotate - [select for diffs], Sat Dec 23 17:46:39 2006 UTC (17 years, 5 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_1_BASE, OPENBSD_4_1
Changes since 1.51: +5 -3 lines
Diff to previous 1.51 (colored)

adapt to new two-level sensor api; Constantine A. Murenin

Revision 1.51 / (download) - annotate - [select for diffs], Sat Dec 23 17:36:59 2006 UTC (17 years, 5 months ago) by deraadt
Branch: MAIN
Changes since 1.50: +13 -9 lines
Diff to previous 1.50 (colored)

if errors happen while reading the sdr list, give up on handling the
device as cleanly as possible.  ok marco

Revision 1.50 / (download) - annotate - [select for diffs], Sat Dec 23 00:36:24 2006 UTC (17 years, 5 months ago) by deraadt
Branch: MAIN
Changes since 1.49: +5 -6 lines
Diff to previous 1.49 (colored)

wrong printing; ok marco

Revision 1.49 / (download) - annotate - [select for diffs], Tue Sep 19 09:30:03 2006 UTC (17 years, 8 months ago) by mickey
Branch: MAIN
Changes since 1.48: +18 -20 lines
Diff to previous 1.48 (colored)

fix all malloc()s to nowait|canfail and do not ignore errors reading sensor status; marco@ ok

Revision 1.48 / (download) - annotate - [select for diffs], Sun Sep 17 19:09:20 2006 UTC (17 years, 8 months ago) by marco
Branch: MAIN
Changes since 1.47: +22 -25 lines
Diff to previous 1.47 (colored)

Move get ipmi id into the match function.  This prevents attach from being
called whenever there is no BMC and hence suppresses a ugly message when a
bios lied that it had ipmi.

tested beck@

Revision 1.47 / (download) - annotate - [select for diffs], Tue Aug 1 22:49:37 2006 UTC (17 years, 10 months ago) by marco
Branch: MAIN
CVS Tags: OPENBSD_4_0_BASE, OPENBSD_4_0
Changes since 1.46: +18 -7 lines
Diff to previous 1.46 (colored)

Add a wait between send and receive command.  Talked through with jordan.

Revision 1.46 / (download) - annotate - [select for diffs], Tue Aug 1 20:02:04 2006 UTC (17 years, 10 months ago) by marco
Branch: MAIN
Changes since 1.45: +14 -8 lines
Diff to previous 1.45 (colored)

Silence intermittent read errors.
Fix a bug in bt where the "get id" command fails by giving the bmc some
extra time to gather the data.

Revision 1.45 / (download) - annotate - [select for diffs], Fri Jul 28 20:50:43 2006 UTC (17 years, 10 months ago) by marco
Branch: MAIN
Changes since 1.44: +4 -3 lines
Diff to previous 1.44 (colored)

KNF

Revision 1.44 / (download) - annotate - [select for diffs], Fri Jul 28 20:46:12 2006 UTC (17 years, 10 months ago) by marco
Branch: MAIN
Changes since 1.43: +22 -10 lines
Diff to previous 1.43 (colored)

Only read 1 sensor at a time instead of all of them.  This should help
systems that have a burst of activity every 10 seconds.

Also lower the polling frequency from 10 to 5 seconds.

ok jordan@

Revision 1.43 / (download) - annotate - [select for diffs], Fri Jul 28 20:41:02 2006 UTC (17 years, 10 months ago) by jordan
Branch: MAIN
Changes since 1.42: +37 -19 lines
Diff to previous 1.42 (colored)

Fix BT interface by waiting for BMC_BUSY on writes.

Found and ok marco

Revision 1.42 / (download) - annotate - [select for diffs], Sun May 21 20:55:26 2006 UTC (18 years ago) by alek
Branch: MAIN
Changes since 1.41: +4 -4 lines
Diff to previous 1.41 (colored)

Replace lockmgr with rwlock; help and ok marco@

Revision 1.41 / (download) - annotate - [select for diffs], Mon May 15 01:10:07 2006 UTC (18 years, 1 month ago) by marco
Branch: MAIN
Changes since 1.40: +21 -17 lines
Diff to previous 1.40 (colored)

Add device name when printing out errors.  Pointed out by deraadt@

Revision 1.40 / (download) - annotate - [select for diffs], Mon May 15 00:46:55 2006 UTC (18 years, 1 month ago) by marco
Branch: MAIN
Changes since 1.39: +16 -7 lines
Diff to previous 1.39 (colored)

Make _bmc_io_wait 1 second instead of 500ms.
Prevent multiple reads and writes to the bmc at the same time which could
interrupt a complete bmc transaction.

tested by various people.

Revision 1.39 / (download) - annotate - [select for diffs], Fri May 12 02:11:53 2006 UTC (18 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.38: +3 -2 lines
Diff to previous 1.38 (colored)

code we can read

Revision 1.38 / (download) - annotate - [select for diffs], Mon May 8 22:51:18 2006 UTC (18 years, 1 month ago) by gwk
Branch: MAIN
Changes since 1.37: +11 -100 lines
Diff to previous 1.37 (colored)

Add smbios support for i386 and amd64, fix ipmi to use this new functionallity,
hook up some sysctls to add system vendor/product/version and UUID reporting.

"get it in" deraadt@

Revision 1.37 / (download) - annotate - [select for diffs], Sat May 6 15:04:38 2006 UTC (18 years, 1 month ago) by wilfried
Branch: MAIN
Changes since 1.36: +3 -1 lines
Diff to previous 1.36 (colored)

if the fan data rate is per second convert it to per minute, ok marco

Revision 1.36 / (download) - annotate - [select for diffs], Thu Apr 27 15:28:21 2006 UTC (18 years, 1 month ago) by mickey
Branch: MAIN
Changes since 1.35: +2 -2 lines
Diff to previous 1.35 (colored)

from PAE work:
since we are only interested in the page offset bits
cast paddr_t to (smaller) u_long to shuddup gcc (;

Revision 1.35 / (download) - annotate - [select for diffs], Thu Apr 20 20:31:10 2006 UTC (18 years, 1 month ago) by miod
Branch: MAIN
Changes since 1.34: +2 -2 lines
Diff to previous 1.34 (colored)

Fix various printf() issues: too many arguments, not enough arguments, argument
order reversed, wrong modifiers. ok deraadt@ marco@ mickey@

Revision 1.34 / (download) - annotate - [select for diffs], Sun Jan 29 17:29:29 2006 UTC (18 years, 4 months ago) by marco
Branch: MAIN
CVS Tags: OPENBSD_3_9_BASE, OPENBSD_3_9
Changes since 1.33: +5 -1 lines
Diff to previous 1.33 (colored)

Disable iic whenever ipmi is enabled.  This fixes boxes like Sun x4200 that
freak out when more than one device driver touch the i2c devices.
Reported by: Srebrenko Sehic <ssehic at gmail dot com>

ok kettenis@

Revision 1.33 / (download) - annotate - [select for diffs], Thu Jan 19 17:08:39 2006 UTC (18 years, 4 months ago) by grange
Branch: MAIN
Changes since 1.32: +2 -2 lines
Diff to previous 1.32 (colored)

Replace SENSOR_ADD() macro with a pair of functions
sensor_add()/sensor_del() so that sensors can be attached
and detached dynamicaly.

ok kettenis@ deraadt@ dlg@

Revision 1.32 / (download) - annotate - [select for diffs], Wed Jan 18 04:46:04 2006 UTC (18 years, 4 months ago) by marco
Branch: MAIN
Changes since 1.31: +3 -3 lines
Diff to previous 1.31 (colored)

Fix false positives of ipmi on older machines.

ok jordan@
tested by others

Revision 1.31 / (download) - annotate - [select for diffs], Thu Jan 5 21:28:29 2006 UTC (18 years, 5 months ago) by marco
Branch: MAIN
Changes since 1.30: +29 -29 lines
Diff to previous 1.30 (colored)

Kill all typedef struct goo.

Revision 1.30 / (download) - annotate - [select for diffs], Thu Jan 5 19:04:39 2006 UTC (18 years, 5 months ago) by marco
Branch: MAIN
Changes since 1.29: +18 -1 lines
Diff to previous 1.29 (colored)

Work around flawed IBM 325 eServer IPMI implementation.

Help and ok deraadt@ jordan@

Revision 1.29 / (download) - annotate - [select for diffs], Thu Jan 5 17:38:00 2006 UTC (18 years, 5 months ago) by marco
Branch: MAIN
Changes since 1.28: +5 -5 lines
Diff to previous 1.28 (colored)

Better debug verbosity values.

Revision 1.28 / (download) - annotate - [select for diffs], Thu Jan 5 17:09:15 2006 UTC (18 years, 5 months ago) by marco
Branch: MAIN
Changes since 1.27: +8 -8 lines
Diff to previous 1.27 (colored)

Adjust debug levels.

Revision 1.27 / (download) - annotate - [select for diffs], Thu Jan 5 15:16:26 2006 UTC (18 years, 5 months ago) by marco
Branch: MAIN
Changes since 1.26: +4 -4 lines
Diff to previous 1.26 (colored)

I got the time scale wrong with the previous commit.  Now the advertised
50ms timeout is actually 50ms during runtime.

Revision 1.26 / (download) - annotate - [select for diffs], Wed Jan 4 23:51:16 2006 UTC (18 years, 5 months ago) by marco
Branch: MAIN
Changes since 1.25: +3 -3 lines
Diff to previous 1.25 (colored)

Adjust timeout values.  This was determined by using beck's ibm e325.

ok jordan

Revision 1.25 / (download) - annotate - [select for diffs], Fri Dec 16 03:16:47 2005 UTC (18 years, 5 months ago) by marco
Branch: MAIN
Changes since 1.24: +90 -21 lines
Diff to previous 1.24 (colored)

Fix 2 issues reported by beck.

1. Sun v20z rebooted dunring autoconf.  This was due to reading a byte and
   discarding it at an inapropriate time.
2. The Sun is so fast that it could exhaust the busy counter.  This has been
   replaced with a timeout/tsleep mechanism that is more predictable.  As
   a bonus we no longer busy wait in ipmi which should improve overall
   throughput.

ok beck@ jordan@ dlg@

Revision 1.24 / (download) - annotate - [select for diffs], Tue Dec 13 04:00:18 2005 UTC (18 years, 6 months ago) by marco
Branch: MAIN
Changes since 1.23: +5 -2 lines
Diff to previous 1.23 (colored)

Add check for return value in recvcmd.
Unmap ipmi registers if attach fails.

ok jordan@

Revision 1.23 / (download) - annotate - [select for diffs], Tue Dec 13 03:49:32 2005 UTC (18 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.22: +4 -7 lines
Diff to previous 1.22 (colored)

no need for device name before fail

Revision 1.22 / (download) - annotate - [select for diffs], Tue Dec 13 03:36:12 2005 UTC (18 years, 6 months ago) by marco
Branch: MAIN
Changes since 1.21: +11 -3 lines
Diff to previous 1.21 (colored)

Don't continue to poke ipmi registers if the ID command fails.
ok jordan@

Revision 1.21 / (download) - annotate - [select for diffs], Wed Nov 30 18:02:53 2005 UTC (18 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.20: +7 -8 lines
Diff to previous 1.20 (colored)

spacing

Revision 1.20 / (download) - annotate - [select for diffs], Mon Nov 28 23:47:42 2005 UTC (18 years, 6 months ago) by jordan
Branch: MAIN
Changes since 1.19: +66 -19 lines
Diff to previous 1.19 (colored)

Added ipmi watchdog code, based on esm watchdog code by dlg@
Added signextend function to cleanup conversion routine
ok marco@

Revision 1.19 / (download) - annotate - [select for diffs], Tue Nov 22 04:28:14 2005 UTC (18 years, 6 months ago) by marco
Branch: MAIN
Changes since 1.18: +8 -3 lines
Diff to previous 1.18 (colored)

Some BIOS' lie about location of ports.  Prevent panic by checking bus_space_map.

This works around bob's ipmi panic issue on the amd64 e325 IBM box.

ok jordan@

Revision 1.18 / (download) - annotate - [select for diffs], Mon Oct 24 18:36:21 2005 UTC (18 years, 7 months ago) by marco
Branch: MAIN
Changes since 1.17: +6 -3 lines
Diff to previous 1.17 (colored)

Remove panic if polling thread can not be created.

ok jordan@

Revision 1.17 / (download) - annotate - [select for diffs], Fri Oct 21 16:44:24 2005 UTC (18 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.16: +14 -15 lines
Diff to previous 1.16 (colored)

pretty up dmesg output

Revision 1.16 / (download) - annotate - [select for diffs], Thu Oct 20 02:02:20 2005 UTC (18 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.15: +50 -69 lines
Diff to previous 1.15 (colored)

KNF; marco ok

Revision 1.15 / (download) - annotate - [select for diffs], Wed Oct 19 23:47:44 2005 UTC (18 years, 7 months ago) by jordan
Branch: MAIN
Changes since 1.14: +27 -16 lines
Diff to previous 1.14 (colored)

Fixup case statements to use #define's
suggested by deraadt
ok marco@

Revision 1.14 / (download) - annotate - [select for diffs], Wed Oct 19 23:28:28 2005 UTC (18 years, 7 months ago) by jordan
Branch: MAIN
Changes since 1.13: +19 -14 lines
Diff to previous 1.13 (colored)

Added readable case names for ipmi device types
ok marco@

Revision 1.13 / (download) - annotate - [select for diffs], Wed Oct 19 23:00:22 2005 UTC (18 years, 7 months ago) by jordan
Branch: MAIN
Changes since 1.12: +8 -1 lines
Diff to previous 1.12 (colored)

Added length test for ipmi_sensor_name string
ok marco@

Revision 1.12 / (download) - annotate - [select for diffs], Wed Oct 19 22:35:39 2005 UTC (18 years, 7 months ago) by jordan
Branch: MAIN
Changes since 1.11: +43 -17 lines
Diff to previous 1.11 (colored)

Changed poll to use kernel threads instead of in timer context
ok marco@

Revision 1.11 / (download) - annotate - [select for diffs], Wed Oct 19 22:06:59 2005 UTC (18 years, 7 months ago) by jordan
Branch: MAIN
Changes since 1.10: +3 -1 lines
Diff to previous 1.10 (colored)

Added status for chassis intrusion (critical if open)
ok marco@

Revision 1.10 / (download) - annotate - [select for diffs], Wed Oct 19 22:01:08 2005 UTC (18 years, 7 months ago) by jordan
Branch: MAIN
Changes since 1.9: +20 -19 lines
Diff to previous 1.9 (colored)

Changed order of reading sensor vs sensor status, failed sensors had invalid
reading
ok marco@

Revision 1.9 / (download) - annotate - [select for diffs], Wed Oct 19 21:52:30 2005 UTC (18 years, 7 months ago) by jordan
Branch: MAIN
Changes since 1.8: +15 -2 lines
Diff to previous 1.8 (colored)

Added code to properly read power supply installed/power state
ok marco@

Revision 1.8 / (download) - annotate - [select for diffs], Wed Oct 19 21:43:09 2005 UTC (18 years, 7 months ago) by jordan
Branch: MAIN
Changes since 1.7: +83 -25 lines
Diff to previous 1.7 (colored)

Added SMIC interface code
ok marco@

Revision 1.7 / (download) - annotate - [select for diffs], Tue Oct 18 23:26:33 2005 UTC (18 years, 7 months ago) by marco
Branch: MAIN
Changes since 1.6: +3 -3 lines
Diff to previous 1.6 (colored)

Use MI trunc_page() & round_page().  Suggested by miod@ and grange@

Revision 1.6 / (download) - annotate - [select for diffs], Tue Oct 18 23:11:00 2005 UTC (18 years, 7 months ago) by marco
Branch: MAIN
Changes since 1.5: +2 -1 lines
Diff to previous 1.5 (colored)

Document Dell PowerEdge 8450 hack

Revision 1.5 / (download) - annotate - [select for diffs], Tue Oct 18 23:08:23 2005 UTC (18 years, 7 months ago) by marco
Branch: MAIN
Changes since 1.4: +24 -10 lines
Diff to previous 1.4 (colored)

Scan SMBIOS before calling config_attach() to prevent unnecessary kernel print.

Written with jordan@ help.
ok deraadt@

Revision 1.4 / (download) - annotate - [select for diffs], Mon Oct 17 23:54:21 2005 UTC (18 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.3: +18 -19 lines
Diff to previous 1.3 (colored)

knf

Revision 1.3 / (download) - annotate - [select for diffs], Mon Oct 17 22:56:53 2005 UTC (18 years, 7 months ago) by jordan
Branch: MAIN
Changes since 1.2: +340 -172 lines
Diff to previous 1.2 (colored)

* Fix SMBIOS Table address
	mapped memory instead of ISA_HOLE_VADDR for SMBIOS tables in high memory
* Added ipmi_poll variable to control sensor polling
* Add Power Supply sensor type
* Fixed chassis intrusion reading
* Added Block-Transfer interface
	BT is transport protocol to BMC
* Fixed threshold values
	Bits in Sensor reading did not contain correct values for threshold
	vioation; must compare reading against actual threshold.
* KNF

ok: marco@

Revision 1.2 / (download) - annotate - [select for diffs], Wed Oct 5 02:02:11 2005 UTC (18 years, 8 months ago) by deraadt
Branch: MAIN
Changes since 1.1: +97 -102 lines
Diff to previous 1.1 (colored)

pretty print & minor knf; ok marco

Revision 1.1 / (download) - annotate - [select for diffs], Tue Oct 4 21:59:41 2005 UTC (18 years, 8 months ago) by marco
Branch: MAIN

Add initial IPMI implementation.  Currently only the KCS retrieval method is
supported.  SMIC and BMC are being worked on.  IPMI will remain disabled for
now.

Code written by Jordan Hargrave <jordan underscore hargrave at hotmail dot com>

help grange@ and deraadt@
ok deraadt@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.