CVS log for src/sys/nfs/nfs_vnops.c

Up to [local] / src / sys / nfs

Request diff between arbitrary revisions

Default branch: MAIN

Revision 1.200 / (download) - annotate - [select for diffs], Tue May 14 06:26:05 2024 UTC (4 weeks ago) by jsg
Branch: MAIN
CVS Tags: HEAD
Changes since 1.199: +1 -2 lines
Diff to previous 1.199 (colored)

remove unneeded nfs_getreq() prototype

nfs_getreq() is in nfs_socket.c and not called from nfs_vnops.c

Revision 1.199 / (download) - annotate - [select for diffs], Mon May 13 11:17:40 2024 UTC (4 weeks ago) by semarie
Branch: MAIN
Changes since 1.198: +1 -6 lines
Diff to previous 1.198 (colored)

vfs: VOP_REMOVE: move vnode unlocking and ref dropping to FS-indep part

while here, ensure all vop_remove field are set, and always call the function.

the change is very conservative: it only adds vnode ref drop/unlock where it was
absent because it should be unreachable (and if it wasn't, it should fix
things).

ok miod@

Revision 1.198 / (download) - annotate - [select for diffs], Wed May 1 13:15:59 2024 UTC (5 weeks, 5 days ago) by jsg
Branch: MAIN
Changes since 1.197: +1 -9 lines
Diff to previous 1.197 (colored)

remove unneeded includes
ok miod@ mpi@

Revision 1.197 / (download) - annotate - [select for diffs], Tue Apr 30 17:05:20 2024 UTC (5 weeks, 6 days ago) by miod
Branch: MAIN
Changes since 1.196: +2 -2 lines
Diff to previous 1.196 (colored)

Constify NFS data whenever possible. Also make a few more const data static.

ok jsg@ semarie@

Revision 1.196 / (download) - annotate - [select for diffs], Tue Apr 30 17:04:23 2024 UTC (5 weeks, 6 days ago) by miod
Branch: MAIN
Changes since 1.195: +389 -161 lines
Diff to previous 1.195 (colored)

Convert all the NFS macros (in nfsm_subs.h) into inline functions with the
appropriate extra arguments.

This (hopefully) completes the unmessyfication work started by thib@ a long,
long time ago (in a galaxy far away).

The conversion logic has been:
- nfsm_dissect has been turned into an rvalue expression, leaving the
  cast operation up to its caller.
- macros which had three different exit paths (return, goto nfsmout or
  fallthrough) have been split so that no macros have more than two exit paths.
- then they have been modified to return a value, which lets the caller
  figure out what exit path is needed.
- local variables abused by the macros are now local variables of the new
  inline functions.

This single commit is the sum of 25 intermediate diffs, which have all been
carefully reviewed by (at least) jsg@ and semarie@.

Tested with v2 and v3 servers and clients.

ok jsg@ semarie@

Revision 1.195 / (download) - annotate - [select for diffs], Sat Apr 13 23:44:11 2024 UTC (8 weeks, 2 days ago) by jsg
Branch: MAIN
Changes since 1.194: +5 -5 lines
Diff to previous 1.194 (colored)

correct indentation

no functional change, found by smatch warnings
ok miod@ bluhm@

Revision 1.194 / (download) - annotate - [select for diffs], Mon Mar 25 17:57:07 2024 UTC (2 months, 2 weeks ago) by guenther
Branch: MAIN
Changes since 1.193: +1 -6 lines
Diff to previous 1.193 (colored)

Move the "no (hard) linking directories" and "no cross-mount links"
checks from all the filesystems that support hardlinks at all into
the VFS layer.  Simplify, EPERM description in link(2).

ok miod@ mpi@

Revision 1.193 / (download) - annotate - [select for diffs], Wed Apr 26 10:00:37 2023 UTC (13 months, 2 weeks ago) by beck
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4
Changes since 1.192: +2 -2 lines
Diff to previous 1.192 (colored)

Don't redeclare s, it's already there.

noticed by miod@
ok kettenis@

Revision 1.192 / (download) - annotate - [select for diffs], Wed Apr 26 09:53:55 2023 UTC (13 months, 2 weeks ago) by beck
Branch: MAIN
Changes since 1.191: +3 -1 lines
Diff to previous 1.191 (colored)

Fix missing splbio() needed in nfs

ok claudio@ kettenis@

Revision 1.191 / (download) - annotate - [select for diffs], Wed Mar 8 04:43:09 2023 UTC (15 months ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_7_3_BASE, OPENBSD_7_3
Changes since 1.190: +1 -2 lines
Diff to previous 1.190 (colored)

Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

Revision 1.190 / (download) - annotate - [select for diffs], Fri Aug 12 14:30:53 2022 UTC (21 months, 4 weeks ago) by visa
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2
Changes since 1.189: +6 -5 lines
Diff to previous 1.189 (colored)

Put more struct vnode fields under splbio().

Buffer cache related struct vnode fields can be accessed in interrupt
context. Be more consistent with the use of splbio().

OK mpi@

Revision 1.189 / (download) - annotate - [select for diffs], Sun Jun 26 05:20:42 2022 UTC (23 months, 2 weeks ago) by visa
Branch: MAIN
Changes since 1.188: +1 -17 lines
Diff to previous 1.188 (colored)

Remove unused VOP_POLL().

OK mpi@

Revision 1.188 / (download) - annotate - [select for diffs], Sun Dec 12 09:14:59 2021 UTC (2 years, 5 months ago) by visa
Branch: MAIN
CVS Tags: OPENBSD_7_1_BASE, OPENBSD_7_1
Changes since 1.187: +2 -2 lines
Diff to previous 1.187 (colored)

Add vnode parameter to VOP_STRATEGY()

Pass the device vnode as a parameter to VOP_STRATEGY() to allow calling
the correct vop_strategy callback. Now the vnode is also available
in the callback.

OK mpi@

Revision 1.187 / (download) - annotate - [select for diffs], Sat Oct 2 08:51:41 2021 UTC (2 years, 8 months ago) by semarie
Branch: MAIN
Changes since 1.186: +24 -24 lines
Diff to previous 1.186 (colored)

vfs: merge *_badop to vop_generic_badop

It replaces spec_badop, fifo_badop, dead_badop and mfs_badop, which
are only calls to panic(9), to one unique function vop_generic_badop().

No intented behaviour changes (outside the panic message which isn't
the same).

ok mpi@

Revision 1.186 / (download) - annotate - [select for diffs], Thu Mar 11 13:31:35 2021 UTC (3 years, 3 months ago) by jsg
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9
Changes since 1.185: +3 -3 lines
Diff to previous 1.185 (colored)

spelling

Revision 1.185 / (download) - annotate - [select for diffs], Sun Sep 27 17:25:19 2020 UTC (3 years, 8 months ago) by matthieu
Branch: MAIN
CVS Tags: OPENBSD_6_8_BASE, OPENBSD_6_8
Changes since 1.184: +3 -3 lines
Diff to previous 1.184 (colored)

In the previous commit, check tv_nsec, not tv_sec as VNOVAL is a
valid valuse of tv_sec but an invalid value for tv_nsec.
Noticed by guenther@. ok beck@ deraadt@

Revision 1.184 / (download) - annotate - [select for diffs], Sun Sep 27 16:40:44 2020 UTC (3 years, 8 months ago) by matthieu
Branch: MAIN
Changes since 1.183: +9 -2 lines
Diff to previous 1.183 (colored)

nfs_create: after an exclusive create rpc, make sure to update
timestamps.

This issue was iscovered after rsync 3.2 changed behaviour on an NFS
mounted partition.. Change lifted from NetBSD (r 1.204).

ok beck@, kn@, deraadt@

Revision 1.183 / (download) - annotate - [select for diffs], Wed Jun 24 22:03:44 2020 UTC (3 years, 11 months ago) by cheloha
Branch: MAIN
Changes since 1.182: +3 -3 lines
Diff to previous 1.182 (colored)

kernel: use gettime(9)/getuptime(9) in lieu of time_second(9)/time_uptime(9)

time_second(9) and time_uptime(9) are widely used in the kernel to
quickly get the system UTC or system uptime as a time_t.  However,
time_t is 64-bit everywhere, so it is not generally safe to use them
on 32-bit platforms: you have a split-read problem if your hardware
cannot perform atomic 64-bit reads.

This patch replaces time_second(9) with gettime(9), a safer successor
interface, throughout the kernel.  Similarly, time_uptime(9) is replaced
with getuptime(9).

There is a performance cost on 32-bit platforms in exchange for
eliminating the split-read problem: instead of two register reads you
now have a lockless read loop to pull the values from the timehands.
This is really not *too* bad in the grand scheme of things, but
compared to what we were doing before it is several times slower.

There is no performance cost on 64-bit (__LP64__) platforms.

With input from visa@, dlg@, and tedu@.

Several bugs squashed by visa@.

ok kettenis@

Revision 1.182 / (download) - annotate - [select for diffs], Mon Jan 20 23:21:56 2020 UTC (4 years, 4 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_6_7_BASE, OPENBSD_6_7
Changes since 1.181: +4 -4 lines
Diff to previous 1.181 (colored)

struct vops is not modified during runtime so use const which moves each
into read-only data segment.
OK deraadt@ tedu@

Revision 1.181 / (download) - annotate - [select for diffs], Fri Jul 19 00:54:59 2019 UTC (4 years, 10 months ago) by cheloha
Branch: MAIN
CVS Tags: OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.180: +7 -6 lines
Diff to previous 1.180 (colored)

vwaitforio(9): tsleep(9) -> tsleep_nsec(9); ok visa@

Revision 1.171.2.1 / (download) - annotate - [select for diffs], Sun Jan 27 22:10:57 2019 UTC (5 years, 4 months ago) by bluhm
Branch: OPENBSD_6_3
Changes since 1.171: +4 -3 lines
Diff to previous 1.171 (colored) next main 1.172 (colored)

Check for negative length integers in NFS server.  A malicious
client could crash the server.
from bluhm@; OK tedu@

Check for negative length integers in NFS client.  A malicious
server could confuse the client file system code.
from bluhm@; OK beck@

Check for negative length in NFS strings.  This affects both, the
client and server.
from bluhm@; OK beck@

OpenBSD 6.3 errata 029

Revision 1.179.2.1 / (download) - annotate - [select for diffs], Sun Jan 27 22:09:51 2019 UTC (5 years, 4 months ago) by bluhm
Branch: OPENBSD_6_4
Changes since 1.179: +4 -3 lines
Diff to previous 1.179 (colored) next main 1.180 (colored)

Check for negative length integers in NFS server.  A malicious
client could crash the server.
from bluhm@; OK tedu@

Check for negative length integers in NFS client.  A malicious
server could confuse the client file system code.
from bluhm@; OK beck@

Check for negative length in NFS strings.  This affects both, the
client and server.
from bluhm@; OK beck@

OpenBSD 6.4 errata 012

Revision 1.180 / (download) - annotate - [select for diffs], Fri Jan 18 13:40:34 2019 UTC (5 years, 4 months ago) by bluhm
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5
Changes since 1.179: +4 -3 lines
Diff to previous 1.179 (colored)

Check for negative length integers in NFS client.  A malicious
server could confuse the client file system code.
OK beck@

Revision 1.179 / (download) - annotate - [select for diffs], Mon Jul 2 20:56:22 2018 UTC (5 years, 11 months ago) by bluhm
Branch: MAIN
CVS Tags: OPENBSD_6_4_BASE
Branch point for: OPENBSD_6_4
Changes since 1.178: +5 -9 lines
Diff to previous 1.178 (colored)

Use more list macros for v_dirtyblkhd.
OK mpi@

Revision 1.178 / (download) - annotate - [select for diffs], Thu Jun 21 14:17:23 2018 UTC (5 years, 11 months ago) by visa
Branch: MAIN
Changes since 1.177: +1 -8 lines
Diff to previous 1.177 (colored)

Drop redundant "node == parent node" checks from VOP_RMDIR()
implementations. Rely on the VFS layer to do the checking.

OK mpi@, helg@

Revision 1.177 / (download) - annotate - [select for diffs], Thu Jun 7 13:37:28 2018 UTC (6 years ago) by visa
Branch: MAIN
Changes since 1.176: +3 -8 lines
Diff to previous 1.176 (colored)

Make callers of VOP_CREATE(9) and VOP_MKNOD(9) responsible for
unlocking the directory vnode.

OK mpi@, helg@

Revision 1.176 / (download) - annotate - [select for diffs], Sat May 5 11:54:11 2018 UTC (6 years, 1 month ago) by mpi
Branch: MAIN
Changes since 1.175: +57 -11 lines
Diff to previous 1.175 (colored)

Implement proper locking for NFS nodes.

Tested in bulks by many. ok visa@, beck@

Revision 1.175 / (download) - annotate - [select for diffs], Wed May 2 02:24:56 2018 UTC (6 years, 1 month ago) by visa
Branch: MAIN
Changes since 1.174: +4 -5 lines
Diff to previous 1.174 (colored)

Remove proc from the parameters of vn_lock(). The parameter is
unnecessary because curproc always does the locking.

OK mpi@

Revision 1.174 / (download) - annotate - [select for diffs], Sat Apr 28 03:13:05 2018 UTC (6 years, 1 month ago) by visa
Branch: MAIN
Changes since 1.173: +5 -5 lines
Diff to previous 1.173 (colored)

Clean up the parameters of VOP_LOCK() and VOP_UNLOCK(). It is always
curproc that does the locking or unlocking, so the proc parameter
is pointless and can be dropped.

OK mpi@, deraadt@

Revision 1.173 / (download) - annotate - [select for diffs], Wed Apr 25 15:53:08 2018 UTC (6 years, 1 month ago) by visa
Branch: MAIN
Changes since 1.172: +4 -3 lines
Diff to previous 1.172 (colored)

Fix use of unreferenced vnode by decrementing the vnode's reference
count after unlocking. To improve consistency, use vput() instead of
VOP_UNLOCK() + vrele().

OK guenther@, mpi@, tedu@

Revision 1.172 / (download) - annotate - [select for diffs], Tue Apr 17 07:45:24 2018 UTC (6 years, 1 month ago) by mpi
Branch: MAIN
Changes since 1.171: +48 -36 lines
Diff to previous 1.171 (colored)

Prepare vnops to be locked.

- Use vput(9) instead of vrele(9) when a "locked" node is returned
  by nfs_nget().

- Make sure VN_KNOTE() is always called with a valid reference.

- Add a missing PDIRUNLOCK in nfs_lookup()

These changes are mostly noops as long as nfs_lock()/unlock() do
nothing.

Tested by bluhm@, visa@ and myself.

ok visa@

Revision 1.171 / (download) - annotate - [select for diffs], Wed Feb 22 11:42:46 2017 UTC (7 years, 3 months ago) by mpi
Branch: MAIN
CVS Tags: OPENBSD_6_3_BASE, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1
Branch point for: OPENBSD_6_3
Changes since 1.170: +55 -1 lines
Diff to previous 1.170 (colored)

Keep local definitions local.

"good work" deraadt@, ok visa@

Revision 1.170 / (download) - annotate - [select for diffs], Mon Jun 13 19:00:22 2016 UTC (7 years, 11 months ago) by tedu
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE, OPENBSD_6_0
Changes since 1.169: +2 -2 lines
Diff to previous 1.169 (colored)

make sure attrflag is initialized. from clang via david hill

Revision 1.169 / (download) - annotate - [select for diffs], Fri Apr 29 14:40:36 2016 UTC (8 years, 1 month ago) by beck
Branch: MAIN
Changes since 1.168: +4 -3 lines
Diff to previous 1.168 (colored)

Fix some gibbering horrors due to uninitialized struct nameidata's

1) turn NDINITAT into a function and make the macros point to it
with the later goal of getting rid of them.

2) Sweep the kernel for places where people make a struct nameidata manually
on the stack and fill in what they hope are the required fields and count
on prayer and clean living to always get them right. Instead use NDINIT
everywhere. NFS was especially bad for this and there have likely
been things lurking there for a while.

3) Add a couple of strategic KASSERT's to catch future offenders.

ok krw@ sthen@ deraadt@

Revision 1.168 / (download) - annotate - [select for diffs], Sat Mar 19 12:04:16 2016 UTC (8 years, 2 months ago) by natano
Branch: MAIN
Changes since 1.167: +6 -6 lines
Diff to previous 1.167 (colored)

Remove the unused flags argument from VOP_UNLOCK().

torture tested on amd64, i386 and macppc
ok beck mpi stefan
"the change looks right" deraadt

Revision 1.167 / (download) - annotate - [select for diffs], Sat Feb 13 15:45:05 2016 UTC (8 years, 3 months ago) by stefan
Branch: MAIN
CVS Tags: OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.166: +2 -2 lines
Diff to previous 1.166 (colored)

Convert to uiomove. From Martin Natano.

Revision 1.166 / (download) - annotate - [select for diffs], Tue Dec 22 21:36:57 2015 UTC (8 years, 5 months ago) by mmcc
Branch: MAIN
Changes since 1.165: +2 -2 lines
Diff to previous 1.165 (colored)

commited -> committed

Revision 1.164.4.1 / (download) - annotate - [select for diffs], Tue Dec 8 03:38:10 2015 UTC (8 years, 6 months ago) by beck
Branch: OPENBSD_5_8
Changes since 1.164: +2 -1 lines
Diff to previous 1.164 (colored) next main 1.165 (colored)

Bring in fix for NFS panic from current.
ok deraadt@

Revision 1.165 / (download) - annotate - [select for diffs], Mon Dec 7 01:51:39 2015 UTC (8 years, 6 months ago) by beck
Branch: MAIN
Changes since 1.164: +2 -1 lines
Diff to previous 1.164 (colored)

NFS can pass a buffer cache buffer straight to VOP_STRATEGY here, so dma_flip is
needed.   Found by henning@ - thanks!
ok deraadt@

Revision 1.164 / (download) - annotate - [select for diffs], Sun May 3 02:02:15 2015 UTC (9 years, 1 month ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE
Branch point for: OPENBSD_5_8
Changes since 1.163: +3 -3 lines
Diff to previous 1.163 (colored)

Make sure we don't leak bytes from malloced memory in the padding of struct
dirent.  (The memset in previous commit was both wrong and insufficient.)

problem with memset noted by brad@ and jsg@
ok millert@

Revision 1.163 / (download) - annotate - [select for diffs], Fri Apr 17 04:43:21 2015 UTC (9 years, 1 month ago) by guenther
Branch: MAIN
Changes since 1.162: +10 -7 lines
Diff to previous 1.162 (colored)

Tweaks utimensat/futimens handling to always update ctime, even when both
atime and mtime are UTIME_OMIT (at least for ufs, tmpfs, and ext2fs), and
to correctly handle a timestamp of -1.

ok millert@

Revision 1.162 / (download) - annotate - [select for diffs], Sat Mar 14 03:38:52 2015 UTC (9 years, 3 months ago) by jsg
Branch: MAIN
Changes since 1.161: +1 -2 lines
Diff to previous 1.161 (colored)

Remove some includes include-what-you-use claims don't
have any direct symbols used.  Tested for indirect use by compiling
amd64/i386/sparc64 kernels.

ok tedu@ deraadt@

Revision 1.161 / (download) - annotate - [select for diffs], Tue Feb 10 21:56:10 2015 UTC (9 years, 4 months ago) by miod
Branch: MAIN
CVS Tags: OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.160: +2 -2 lines
Diff to previous 1.160 (colored)

First step towards making uiomove() take a size_t size argument:
- rename uiomove() to uiomovei() and update all its users.
- introduce uiomove(), which is similar to uiomovei() but with a size_t.
- rewrite uiomovei() as an uiomove() wrapper.
ok kettenis@

Revision 1.160 / (download) - annotate - [select for diffs], Mon Dec 29 05:29:28 2014 UTC (9 years, 5 months ago) by miod
Branch: MAIN
Changes since 1.159: +3 -1 lines
Diff to previous 1.159 (colored)

Explicitely include <uvm/uvm_extern.h> in order to build on variable page size
architectures.

Revision 1.159 / (download) - annotate - [select for diffs], Thu Dec 18 20:59:21 2014 UTC (9 years, 5 months ago) by tedu
Branch: MAIN
Changes since 1.158: +9 -9 lines
Diff to previous 1.158 (colored)

delete a whole mess of unnecessary caddr_t casts

Revision 1.158 / (download) - annotate - [select for diffs], Tue Dec 16 18:30:04 2014 UTC (9 years, 5 months ago) by tedu
Branch: MAIN
Changes since 1.157: +2 -1 lines
Diff to previous 1.157 (colored)

primary change: move uvm_vnode out of vnode, keeping only a pointer.
objective: vnode.h doesn't include uvm_extern.h anymore.
followup changes: include uvm_extern.h or lock.h where necessary.
ok and help from deraadt

Revision 1.157 / (download) - annotate - [select for diffs], Wed Dec 3 04:16:58 2014 UTC (9 years, 6 months ago) by tedu
Branch: MAIN
Changes since 1.156: +1 -2 lines
Diff to previous 1.156 (colored)

stale header: this code hasn't used hash.h in a while

Revision 1.156 / (download) - annotate - [select for diffs], Tue Nov 18 02:37:31 2014 UTC (9 years, 6 months ago) by tedu
Branch: MAIN
Changes since 1.155: +1 -3 lines
Diff to previous 1.155 (colored)

move arc4random prototype to systm.h. more appropriate for most code
to include that than rdnvar.h. ok deraadt dlg

Revision 1.155 / (download) - annotate - [select for diffs], Sat Nov 15 02:42:38 2014 UTC (9 years, 6 months ago) by doug
Branch: MAIN
Changes since 1.154: +2 -2 lines
Diff to previous 1.154 (colored)

Fix a mistake in a comment.

Revert NFS_DIRBLKSIZE back to data.  This matches an identical comment
in another part of this file.

Revision 1.154 / (download) - annotate - [select for diffs], Fri Nov 14 23:11:35 2014 UTC (9 years, 6 months ago) by tedu
Branch: MAIN
Changes since 1.153: +5 -5 lines
Diff to previous 1.153 (colored)

simplest free(size)

Revision 1.153 / (download) - annotate - [select for diffs], Sun Sep 14 14:17:26 2014 UTC (9 years, 8 months ago) by jsg
Branch: MAIN
Changes since 1.152: +1 -2 lines
Diff to previous 1.152 (colored)

remove uneeded proc.h includes
ok mpi@ kspillner@

Revision 1.152 / (download) - annotate - [select for diffs], Sat Jul 12 18:43:52 2014 UTC (9 years, 11 months ago) by tedu
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6
Changes since 1.151: +3 -3 lines
Diff to previous 1.151 (colored)

add a size argument to free. will be used soon, but for now default to 0.
after discussions with beck deraadt kettenis.

Revision 1.151 / (download) - annotate - [select for diffs], Tue Jul 8 17:19:26 2014 UTC (9 years, 11 months ago) by deraadt
Branch: MAIN
Changes since 1.150: +1 -3 lines
Diff to previous 1.150 (colored)

decouple struct uvmexp into a new file, so that uvm_extern.h and sysctl.h
don't need to be married.
ok guenther miod beck jsing kettenis

Revision 1.150 / (download) - annotate - [select for diffs], Sat Jan 18 07:10:26 2014 UTC (10 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_5_BASE, OPENBSD_5_5
Changes since 1.149: +6 -4 lines
Diff to previous 1.149 (colored)

Use arc4random_buf() for fetching 64-bits of data because it is faster
than calling arc4random() twice
ok jsing

Revision 1.149 / (download) - annotate - [select for diffs], Thu Dec 26 07:17:15 2013 UTC (10 years, 5 months ago) by espie
Branch: MAIN
Changes since 1.148: +2 -5 lines
Diff to previous 1.148 (colored)

either dvp == vp or dvp != vp: zap extra test.
okay guenther@

Revision 1.148 / (download) - annotate - [select for diffs], Thu Oct 17 16:27:47 2013 UTC (10 years, 7 months ago) by bluhm
Branch: MAIN
Changes since 1.147: +1 -2 lines
Diff to previous 1.147 (colored)

The header file netinet/in_var.h included netinet6/in6_var.h.  This
created a bunch of useless dependencies.  Remove this implicit
inclusion and do an explicit #include <netinet6/in6_var.h> when it
is needed.
OK mpi@ henning@

Revision 1.147 / (download) - annotate - [select for diffs], Wed Oct 2 21:28:11 2013 UTC (10 years, 8 months ago) by sf
Branch: MAIN
Changes since 1.146: +2 -2 lines
Diff to previous 1.146 (colored)

format string fix: int64_t

Revision 1.146 / (download) - annotate - [select for diffs], Sat Sep 14 01:35:01 2013 UTC (10 years, 8 months ago) by guenther
Branch: MAIN
Changes since 1.145: +9 -42 lines
Diff to previous 1.145 (colored)

Snapshots for all archs have been built, so remove the T32 code

Revision 1.145 / (download) - annotate - [select for diffs], Tue Aug 13 05:52:25 2013 UTC (10 years, 10 months ago) by guenther
Branch: MAIN
Changes since 1.144: +58 -53 lines
Diff to previous 1.144 (colored)

Switch time_t, ino_t, clock_t, and struct kevent's ident and data
members to 64bit types.  Assign new syscall numbers for (almost
all) the syscalls that involve the affected types, including anything
with time_t, timeval, itimerval, timespec, rusage, dirent, stat,
or kevent arguments.  Add a d_off member to struct dirent and replace
getdirentries() with getdents(), thus immensely simplifying and
accelerating telldir/seekdir.  Build perl with -DBIG_TIME.

Bump the major on every single base library: the compat bits included
here are only good enough to make the transition; the T32 compat
option will be burned as soon as we've reached the new world are
are happy with the snapshots for all architectures.

DANGER: ABI incompatibility.  Updating to this kernel requires extra
work or you won't be able to login: install a snapshot instead.

Much assistance in fixing userland issues from deraadt@ and tedu@
and build assistance from todd@ and otto@

Revision 1.144 / (download) - annotate - [select for diffs], Thu Mar 28 03:29:44 2013 UTC (11 years, 2 months ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_5_4_BASE, OPENBSD_5_4
Changes since 1.143: +4 -1 lines
Diff to previous 1.143 (colored)

Add support for _PC_TIMESTAMP_RESOLUTION for ffs/mfs, cd9600, ext2,
msdos, NFS, fifos and devices, plus support for querying it in
getconf(2) and the requisite pathconf(2) manpage blurb

ok tedu@

Revision 1.143 / (download) - annotate - [select for diffs], Thu Mar 28 02:27:27 2013 UTC (11 years, 2 months ago) by tedu
Branch: MAIN
Changes since 1.142: +3 -1 lines
Diff to previous 1.142 (colored)

add a comment that we are faking it until code to ask the server is written.
requested by deraadt

Revision 1.142 / (download) - annotate - [select for diffs], Thu Mar 28 02:17:16 2013 UTC (11 years, 2 months ago) by tedu
Branch: MAIN
Changes since 1.141: +47 -7 lines
Diff to previous 1.141 (colored)

a better try at pathconf for nfs. there may be lies, but they are better
lies than EINVAL, until we can uncover the truth.

Revision 1.141 / (download) - annotate - [select for diffs], Wed Mar 27 01:56:50 2013 UTC (11 years, 2 months ago) by tedu
Branch: MAIN
Changes since 1.140: +3 -2 lines
Diff to previous 1.140 (colored)

rename NCHNAMLEN to NAMECACHE_MAXLEN. easier to read, easier to type.
ok beck deraadt after a style issue noticed by kettenis

Revision 1.140 / (download) - annotate - [select for diffs], Sat Nov 17 22:28:26 2012 UTC (11 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_3_BASE, OPENBSD_5_3
Changes since 1.139: +6 -3 lines
Diff to previous 1.139 (colored)

buf_acquire() can sleep, so advance down b_vnbufs afterwards
ok beck guenther

Revision 1.139 / (download) - annotate - [select for diffs], Fri Mar 23 15:51:26 2012 UTC (12 years, 2 months ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_5_2_BASE, OPENBSD_5_2
Changes since 1.138: +3 -3 lines
Diff to previous 1.138 (colored)

Make rusage totals, itimers, and profile settings per-process instead
of per-rthread.  Handling of per-thread tick and runtime counters
inspired by how FreeBSD does it.

ok kettenis@

Revision 1.138 / (download) - annotate - [select for diffs], Sat Jul 9 00:24:44 2011 UTC (12 years, 11 months ago) by beck
Branch: MAIN
CVS Tags: OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0
Changes since 1.137: +204 -204 lines
Diff to previous 1.137 (colored)

KNF
ok md5  "can't be worse" thib@

Revision 1.137 / (download) - annotate - [select for diffs], Fri Jul 8 23:06:54 2011 UTC (12 years, 11 months ago) by beck
Branch: MAIN
Changes since 1.136: +14 -5 lines
Diff to previous 1.136 (colored)

fix nfs pending writes, which were not handled correctly in the commit
case.

ok guenther@ thib@

Revision 1.136 / (download) - annotate - [select for diffs], Tue Jul 5 00:37:59 2011 UTC (12 years, 11 months ago) by guenther
Branch: MAIN
Changes since 1.135: +8 -6 lines
Diff to previous 1.135 (colored)

When calling nfs_request() for what could be an async request, pass
down curproc instead of the struct proc from the I/O request...which
may gone away behind our back.  Assert that the supplied request
*is* curproc in a couple other places.

Reproduction and testing by sthen@
ok deraadt@, beck@, art@

Revision 1.135 / (download) - annotate - [select for diffs], Mon Jul 4 21:00:10 2011 UTC (12 years, 11 months ago) by deraadt
Branch: MAIN
Changes since 1.134: +2 -2 lines
Diff to previous 1.134 (colored)

move the specfs code to a place people can see it; ok guenther thib krw

Revision 1.134 / (download) - annotate - [select for diffs], Tue Apr 5 14:14:07 2011 UTC (13 years, 2 months ago) by thib
Branch: MAIN
Changes since 1.133: +1 -4 lines
Diff to previous 1.133 (colored)

Every single vop_default is set to eopnotsupp, so retire it
and return EOPNOTSUPP directly from the VOP_* functions.

Filesystems should, at some point fill in every function
in the vop_default struct so we can get rid of the 'if'
statements in VOP_*.

Revision 1.133 / (download) - annotate - [select for diffs], Tue Dec 21 20:14:43 2010 UTC (13 years, 5 months ago) by thib
Branch: MAIN
CVS Tags: OPENBSD_4_9_BASE, OPENBSD_4_9
Changes since 1.132: +124 -96 lines
Diff to previous 1.132 (colored)

Bring back the "End the VOP experiment." diff, naddy's issues where
unrelated, and his alpha is much happier now.

OK deraadt@

Revision 1.132 / (download) - annotate - [select for diffs], Fri Sep 10 16:34:09 2010 UTC (13 years, 9 months ago) by thib
Branch: MAIN
Changes since 1.131: +96 -124 lines
Diff to previous 1.131 (colored)

Backout the VOP diff until the issues naddy was seeing on alpha (gcc3)
have been resolved.

Revision 1.131 / (download) - annotate - [select for diffs], Mon Sep 6 23:44:10 2010 UTC (13 years, 9 months ago) by thib
Branch: MAIN
Changes since 1.130: +124 -96 lines
Diff to previous 1.130 (colored)

End the VOP experiment. Instead of the ridicolusly complicated operation
vector setup that has questionable features (that have, as far as I can
tell never been used in practice, atleast not in OpenBSD), remove all
the gunk and favor a simple struct full of function pointers that get
set directly by each of the filesystems.

Removes gobs of ugly code and makes things simpler by a magnitude.

The only downside of this is that we loose the vnoperate feature so
the spec/fifo operations of the filesystems need to be kept in sync
with specfs and fifofs, this is no big deal as the API it self is pretty
static.

Many thanks to armani@ who pulled an earlier version of this diff to
current after c2k10 and Gabriel Kihlman on tech@ for testing.

Liked by many. "come on, find your balls" deraadt@.

Revision 1.130 / (download) - annotate - [select for diffs], Wed May 19 08:31:23 2010 UTC (14 years ago) by thib
Branch: MAIN
CVS Tags: OPENBSD_4_8_BASE, OPENBSD_4_8
Changes since 1.129: +1 -4 lines
Diff to previous 1.129 (colored)

clean up a few things that where left to rot after bob's vfs cache work.
sync a few comments to reality (or remove them), remove the cn_hash member
from struct componentname, spacing.

ok beck@

Revision 1.129 / (download) - annotate - [select for diffs], Mon Apr 12 16:37:38 2010 UTC (14 years, 2 months ago) by beck
Branch: MAIN
Changes since 1.128: +2 -2 lines
Diff to previous 1.128 (colored)

Don't jump the queue if we have to wait on the client side because
the nfs_bufq is full - instead tsleep waiting for one of our nfsiod's
to free up space for us in the queue so we can enqueue on the end.

ok blambert@, tedu@, oga@

Revision 1.128 / (download) - annotate - [select for diffs], Mon Mar 29 23:33:39 2010 UTC (14 years, 2 months ago) by krw
Branch: MAIN
Changes since 1.127: +2 -2 lines
Diff to previous 1.127 (colored)

Initialize various uninitialized variables. Found by jsg@ via Clang.

Feedback from miod@ and kettenis@.

ok beck@

Revision 1.127 / (download) - annotate - [select for diffs], Tue Dec 15 15:53:48 2009 UTC (14 years, 5 months ago) by beck
Branch: MAIN
CVS Tags: OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.126: +12 -15 lines
Diff to previous 1.126 (colored)

Make sillyrename not so damn silly. The kindergarten algorithm here for
picking a name meant that more than 58 sillys in a directory and we fail
with EINVAL, resulting in strange problems for nfs which in turn causes
pain and stress in building, and PTSD in nfs and vfs hackers. Has bit us
in the butt since the vienna f2k7 hackathon.

good suggestions from deraadt@ guenther@ and otto@

ok deraadt@,oga@,blambert@,krw@,guenther@, and a "very special ok" tedu@

Oh god, I'm an nfs hacker..

Revision 1.126 / (download) - annotate - [select for diffs], Thu Dec 10 16:41:45 2009 UTC (14 years, 6 months ago) by beck
Branch: MAIN
Changes since 1.125: +11 -2 lines
Diff to previous 1.125 (colored)

"fix" from freebsd to hide potential race in silly renames, where
a directory gets reclaimed on a forced unmount before the silly file
in it gets blown away...  fixes an issue seen by phessler@

ok oga@, art@

Revision 1.125 / (download) - annotate - [select for diffs], Mon Oct 19 22:24:18 2009 UTC (14 years, 7 months ago) by jsg
Branch: MAIN
Changes since 1.124: +57 -138 lines
Diff to previous 1.124 (colored)

antsy
no binary change apart from nfsm_reqhead() which is clearly correct.

ok thib@

Revision 1.124 / (download) - annotate - [select for diffs], Wed Sep 2 18:20:54 2009 UTC (14 years, 9 months ago) by thib
Branch: MAIN
Changes since 1.123: +2 -0 lines
Diff to previous 1.123 (colored)

Backout the asyncio/aiod change, as it causes buf's to get hung.
problem noticed by deraadt@

ok beck@

Revision 1.123 / (download) - annotate - [select for diffs], Thu Aug 20 15:04:24 2009 UTC (14 years, 9 months ago) by thib
Branch: MAIN
Changes since 1.122: +0 -2 lines
Diff to previous 1.122 (colored)

Rework the way we do async I/O in nfs. Introduce separate buf queues for
each mount, and when work is "found", peg an aiod to that mount todo the
I/O. Make nfs_asyncio() a bit smarter when deciding when to do asyncio
and when to force it sync, this is done by keeping the aiod's one two lists,
an "idle" and an "all" list, so asyncio is only done when there are aiods
hanging around todo it for us or are already pegged to the mount.

Idea liked by at least beck@ (and I think art@).
Extensive testing done by myself and jasper and a few others on various
arch's.

Ideas/Code from Net/Free.

OK blambert@.

Revision 1.122 / (download) - annotate - [select for diffs], Thu Aug 13 15:18:16 2009 UTC (14 years, 10 months ago) by blambert
Branch: MAIN
Changes since 1.121: +22 -22 lines
Diff to previous 1.121 (colored)

Teach nfsm_fhtom about nfsm_info structs

ok thib@

Revision 1.121 / (download) - annotate - [select for diffs], Thu Aug 13 15:00:14 2009 UTC (14 years, 10 months ago) by jasper
Branch: MAIN
Changes since 1.120: +61 -61 lines
Diff to previous 1.120 (colored)

- remove super-obvious comments from $fs_vnodeop_entries[]

prodded by and ok thib@
agreed by art@ and blambert@

Revision 1.120 / (download) - annotate - [select for diffs], Tue Aug 4 17:12:39 2009 UTC (14 years, 10 months ago) by thib
Branch: MAIN
Changes since 1.119: +320 -265 lines
Diff to previous 1.119 (colored)

group all of the on-stack variables that are uses by the nfsm_macros
to keep the data munging "state" into an nfsm_info structure. Each
function now has this structure on its stack, and it and its members
are now passed around so that the macros/functions can work there magic.

this will make removing the nfsm_* macros way easier.

Idea/code picked up from DragonflyBSD.

Tested by krw@, jacekm@ and myself.

OK blambert@.

Revision 1.119 / (download) - annotate - [select for diffs], Mon Jul 20 16:49:40 2009 UTC (14 years, 10 months ago) by thib
Branch: MAIN
Changes since 1.118: +19 -19 lines
Diff to previous 1.118 (colored)

(struct foo *)0 -> NULL, every where I could find it.

OK blambert@

Revision 1.118 / (download) - annotate - [select for diffs], Sat Jul 18 14:40:31 2009 UTC (14 years, 10 months ago) by thib
Branch: MAIN
Changes since 1.117: +51 -47 lines
Diff to previous 1.117 (colored)

Fixes for the NFSERR_RETERR commit.

- Make sure to set the mbuf pointers and the dpos pointer correctly
in nfs_request() before returning an error.

- Fix potential mbufs leaks in nfs_{read,write}rpc for v2. The reply
mbuf was not being freed before the jump to nfsmout.
- Reorder error handling to prevent an error case being treated as a
non-error case.

Fixes issues noticed by sthen@ and ajacoutot@. Tested by both of them.
Reviewd by oga@
OK blambert@

Revision 1.117 / (download) - annotate - [select for diffs], Mon Jul 13 15:39:55 2009 UTC (14 years, 11 months ago) by thib
Branch: MAIN
Changes since 1.116: +117 -167 lines
Diff to previous 1.116 (colored)

Make the callers of nfs_request() responsible for freeing the reply mbuf,
if the reply is an error and retire the NFS_RETERR hack. For NFSv3 mounts
the flag was set and reply mbuf not freed to allow the callers to handle
the post-op attributes, or just free the mbuf for NFSv2.

Tested by myself and jasper@ on various arch's.
OK blambert@.

Revision 1.116 / (download) - annotate - [select for diffs], Thu Jul 9 22:29:56 2009 UTC (14 years, 11 months ago) by thib
Branch: MAIN
Changes since 1.115: +4 -4 lines
Diff to previous 1.115 (colored)

Remove the VREF() macro and replaces all instances with a call to verf(),
which is exactly what the macro does.

Macro's that are nothing more then:
#define FUNCTION(arg) function(arg)
are almost always pointless and should go away.

OK blambert@
Agreed by many.

Revision 1.115 / (download) - annotate - [select for diffs], Thu Jun 25 15:49:26 2009 UTC (14 years, 11 months ago) by thib
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6
Changes since 1.114: +2 -0 lines
Diff to previous 1.114 (colored)

backout the buf_acquire() does the bremfree() since all callers
where doing bremfree() befure calling buf_acquire().

This is causing us headache pinning down a bug that showed up
when deraadt@ too cvs to current, and will have to be done
anyway as a preperation for backouts.

OK deraadt@

Revision 1.114 / (download) - annotate - [select for diffs], Sat Jun 6 18:06:22 2009 UTC (15 years ago) by art
Branch: MAIN
Changes since 1.113: +1 -3 lines
Diff to previous 1.113 (colored)

All caller of buf_acquire were doing bremfree before the call.
Just put it in the buf_acquire function.
oga@ ok

Revision 1.113 / (download) - annotate - [select for diffs], Thu Jun 4 00:31:42 2009 UTC (15 years ago) by blambert
Branch: MAIN
Changes since 1.112: +141 -23 lines
Diff to previous 1.112 (colored)

Demacro nfsm_lookup for great justice.

Thanks to ckuethe for saving much typing with a drive-by perl script.

ok thib@

Revision 1.112 / (download) - annotate - [select for diffs], Mon Apr 13 17:51:57 2009 UTC (15 years, 2 months ago) by blambert
Branch: MAIN
Changes since 1.111: +22 -22 lines
Diff to previous 1.111 (colored)

Convert macros to functions to reduce kernel memory usage.

In snaps for a while (way too long, according to deraadt@)

Revision 1.111 / (download) - annotate - [select for diffs], Sat Jan 24 23:37:56 2009 UTC (15 years, 4 months ago) by thib
Branch: MAIN
CVS Tags: OPENBSD_4_5_BASE, OPENBSD_4_5
Changes since 1.110: +1 -2 lines
Diff to previous 1.110 (colored)

oops. forgot to remove a debug printf from the diff.
(that I applied to a clean tree to commit)

Revision 1.110 / (download) - annotate - [select for diffs], Sat Jan 24 23:30:42 2009 UTC (15 years, 4 months ago) by thib
Branch: MAIN
Changes since 1.109: +6 -6 lines
Diff to previous 1.109 (colored)

Use a timespec instead of a time_t for the clients nfsnode
mtime, gives us better granularity, helps with cache consistency.

Idea lifted from NetBSD.

OK blambert@

Revision 1.109 / (download) - annotate - [select for diffs], Sat Jan 24 23:25:17 2009 UTC (15 years, 4 months ago) by thib
Branch: MAIN
Changes since 1.108: +7 -12 lines
Diff to previous 1.108 (colored)

propagate the O_EXCL flag down to the file systems, by setting
VA_EXCLUSIVE. Handle this in NFS, also in NFS use arc4random()
for the create verifier instead of an uninitialized long and
the address of the first interface (which is likely to be lo0).

Lifted from NetBSD with small tweaks;
"looks good", miod@
OK blambert@

Revision 1.108 / (download) - annotate - [select for diffs], Mon Jan 19 23:40:36 2009 UTC (15 years, 4 months ago) by thib
Branch: MAIN
Changes since 1.107: +16 -15 lines
Diff to previous 1.107 (colored)

Introduce a macro to invalidate the attribute
cache instead of setting n_attrstamp to 0 directly.

Lift the macro name from NetBSD.
prompted by and OK blambert@

Revision 1.107 / (download) - annotate - [select for diffs], Sun Jan 18 15:42:31 2009 UTC (15 years, 4 months ago) by bluhm
Branch: MAIN
Changes since 1.106: +6 -6 lines
Diff to previous 1.106 (colored)

Replace #ifndef DIAGNOSTIC with #ifdef to make the additional checks
in diagnostic kernels.  The typo comes from 4.4BSD-Lite2 via NetBSD.

Found with pedro@,  ok pedro@, blambert@, thib@

Revision 1.106 / (download) - annotate - [select for diffs], Tue Jan 13 19:44:20 2009 UTC (15 years, 5 months ago) by grange
Branch: MAIN
Changes since 1.105: +16 -7 lines
Diff to previous 1.105 (colored)

Trivial lvalue abuse fixes, no binary changes.
ok millert@ tedu@

Revision 1.105 / (download) - annotate - [select for diffs], Wed Dec 24 02:43:52 2008 UTC (15 years, 5 months ago) by thib
Branch: MAIN
Changes since 1.104: +6 -10 lines
Diff to previous 1.104 (colored)

Replace the TRUE/FALSE defines with 1/0 respectively. This doesn't
hurt readability and it was just plain annoying seeing them defined
in every other .c file.

OK blambert@

Revision 1.104 / (download) - annotate - [select for diffs], Thu Oct 16 07:57:06 2008 UTC (15 years, 7 months ago) by blambert
Branch: MAIN
Changes since 1.103: +11 -11 lines
Diff to previous 1.103 (colored)

Don't hide the fact that NFS uses vop_generic_* functions behind
#define's in nfs_var.h

ok thib@

Revision 1.103 / (download) - annotate - [select for diffs], Fri Sep 12 16:17:57 2008 UTC (15 years, 9 months ago) by thib
Branch: MAIN
Changes since 1.102: +6 -2 lines
Diff to previous 1.102 (colored)

provide a NOTE_TRUNCATED kq hint in nfs_setattr() if the file
shrinks, same thing as UFS does.

ok/pointers pedro@
ok blambert@

Revision 1.102 / (download) - annotate - [select for diffs], Thu Aug 21 01:17:39 2008 UTC (15 years, 9 months ago) by pedro
Branch: MAIN
Changes since 1.101: +2 -2 lines
Diff to previous 1.101 (colored)

Fix 'if ();' construction introduced in last commit, okay deraadt@

Revision 1.101 / (download) - annotate - [select for diffs], Sat Aug 9 10:14:02 2008 UTC (15 years, 10 months ago) by thib
Branch: MAIN
Changes since 1.100: +10 -10 lines
Diff to previous 1.100 (colored)

o nfs_vinvalbuf() is always called with the intrflag as 1, and then
  checks if the mount is actually interrutable, and if not sets it 0.
  remove this argument from nfs_vinvalbuf and just do the checking inside
  the function.
o give nfs_vinvalbuf() a makeover so it looks nice. (spacing, casts, &c);
o Actually pass PCATCH too tsleep() if the mount it interrutable.

ok art@, blambert@

Revision 1.100 / (download) - annotate - [select for diffs], Fri Aug 8 20:44:38 2008 UTC (15 years, 10 months ago) by blambert
Branch: MAIN
Changes since 1.99: +1 -2 lines
Diff to previous 1.99 (colored)

After beck@ changed the way nfsiod's are notified of work, the
nfs_iodwant array became unused. Garbage collect and free up
a few bytes.

ok thib@

Revision 1.99 / (download) - annotate - [select for diffs], Fri Aug 8 20:40:24 2008 UTC (15 years, 10 months ago) by blambert
Branch: MAIN
Changes since 1.98: +2 -6 lines
Diff to previous 1.98 (colored)

Remove code for variable-sized allocations of NFS filehandles by malloc(),
as it was never used because there were 64-bit buffers already allocated
for filehandles in nfsnode structs.

ok thib@

Revision 1.98 / (download) - annotate - [select for diffs], Fri Jul 25 14:56:47 2008 UTC (15 years, 10 months ago) by beck
Branch: MAIN
CVS Tags: OPENBSD_4_4_BASE, OPENBSD_4_4
Changes since 1.97: +1 -3 lines
Diff to previous 1.97 (colored)

much more correct way of dealing with nfs pending reads/writes
ok thib@

Revision 1.97 / (download) - annotate - [select for diffs], Wed Jul 23 17:40:29 2008 UTC (15 years, 10 months ago) by deraadt
Branch: MAIN
Changes since 1.96: +4 -2 lines
Diff to previous 1.96 (colored)

make this real C

Revision 1.96 / (download) - annotate - [select for diffs], Wed Jul 23 16:24:43 2008 UTC (15 years, 10 months ago) by beck
Branch: MAIN
Changes since 1.95: +2 -1 lines
Diff to previous 1.95 (colored)

Correct cases of mishandling of pending reads and writes to prevent
them going negative - this consists of identifying a number of cases of
IO not going through the buffer cache and marking those buffers with
B_RAW - as well as fixing nfs_bio to show pending writes and reads through
the buffer cache via NFS

still has a problem with mishandling the counters I believe in the
async/sync fallback case where counters stay positive which will be
addressed seperately.

ok tedu@ deraadt@

Revision 1.95 / (download) - annotate - [select for diffs], Wed Jul 23 11:53:07 2008 UTC (15 years, 10 months ago) by art
Branch: MAIN
Changes since 1.94: +3 -2 lines
Diff to previous 1.94 (colored)

 - in nfs_mknodrpc - initialize the node we pass to nfs_lookitup. It's
   not just a return value, nfs_lookitup treats it specially when *npp
   is not NULL.
 - nfs_lookitup - When we match the file handle to the directory
   filehandle (lookup on '.'), initialize np so that we don't return
   stack garbage to the caller. The function shouldn't ever be
   called with '.' at this moment, but that's no reason to not do the
   right thing in case future callers use it that way.

blambert@ thib@ ok

Revision 1.94 / (download) - annotate - [select for diffs], Sun Jul 6 16:54:48 2008 UTC (15 years, 11 months ago) by thib
Branch: MAIN
Changes since 1.93: +2 -3 lines
Diff to previous 1.93 (colored)

remove #ifndef nolint goo

ok blambert@

Revision 1.93 / (download) - annotate - [select for diffs], Sat Jun 14 22:44:07 2008 UTC (16 years ago) by blambert
Branch: MAIN
Changes since 1.92: +1 -18 lines
Diff to previous 1.92 (colored)

Replace nfsm_build/bcopy with nfsm_{buf,str}tombuf functions in
filehandle -> mbuf write macros.

Removes `magic' variable cp which was used only in these macros,
and should lead to marginally better mbuf packing as well.

`slap it in' thib@

Revision 1.92 / (download) - annotate - [select for diffs], Fri Jun 13 22:11:32 2008 UTC (16 years ago) by blambert
Branch: MAIN
Changes since 1.91: +30 -34 lines
Diff to previous 1.91 (colored)

Kill one-liner macro which obfuscated mbuf pointer assignment.

Rescue nfsm_reqhead macro name and rename nfsm_reqh.

End of one-liners from nfsm_subs.h.

ok thib@

Revision 1.91 / (download) - annotate - [select for diffs], Fri Jun 13 17:21:13 2008 UTC (16 years ago) by thib
Branch: MAIN
Changes since 1.90: +1 -6 lines
Diff to previous 1.90 (colored)

nuke a bunch of bogus ARGSUSED;

ok blambert@

Revision 1.90 / (download) - annotate - [select for diffs], Thu Jun 12 20:24:06 2008 UTC (16 years ago) by blambert
Branch: MAIN
Changes since 1.89: +45 -45 lines
Diff to previous 1.89 (colored)

Remove now-vestigial bpos pointer from NFS. For building outgoing
NFS mbufs, mbufs now contain all their internal buffer state internally,
the way god intended.

ok thib@

testing johan@ (and possibly merdely@; this diff's been around for a bit...)

Revision 1.89 / (download) - annotate - [select for diffs], Thu Jun 12 06:58:40 2008 UTC (16 years ago) by deraadt
Branch: MAIN
Changes since 1.88: +11 -6 lines
Diff to previous 1.88 (colored)

Bring biomem diff back into the tree after the nfs_bio.c fix went in.
ok thib beck art

Revision 1.88 / (download) - annotate - [select for diffs], Wed Jun 11 12:35:46 2008 UTC (16 years ago) by deraadt
Branch: MAIN
Changes since 1.87: +6 -11 lines
Diff to previous 1.87 (colored)

back out biomem diff since it is not right yet.  Doing very large
file copies to nfsv2 causes the system to eventually peg the console.
On the console ^T indicates that the load is increasing rapidly, ddb
indicates many calls to getbuf, there is some very slow nfs traffic
making none (or extremely slow) progress.  Eventually some machines
seize up entirely.

Revision 1.87 / (download) - annotate - [select for diffs], Wed Jun 11 04:52:27 2008 UTC (16 years ago) by blambert
Branch: MAIN
Changes since 1.86: +2 -1 lines
Diff to previous 1.86 (colored)

Canonical for() -> queue.h FOREACH macro conversions.
Also, it is historical practice to #include <sys/queue.h>
when using queue.h macros.

ok thib@ krw@

special thanks to krw@ for reminders vice violence

Revision 1.86 / (download) - annotate - [select for diffs], Tue Jun 10 22:59:09 2008 UTC (16 years ago) by thib
Branch: MAIN
Changes since 1.85: +74 -14 lines
Diff to previous 1.85 (colored)

o Avoid putting duplicate entries into the name cache,
  add a function to handle cache_enter()'s for us since
  we need to update the appropriate timestamps so we don't
  miss on lookup;
o Do not purge the dvp in nfs_rmdir(), since there's no need;
o cache the new entry created in nfs_mkdir();
o Do caching of the access modes, this drastically reduces the
  amount of over the wire access RPCs we do in the NFSv3 case.

This diff was written by Pedro Martelletto, sometime in 2004.
A lot of people have been running with it at one time or another,
this includes at least markus and matthieu.

OK deraadt@, blambert@

Revision 1.85 / (download) - annotate - [select for diffs], Tue Jun 10 20:14:37 2008 UTC (16 years ago) by beck
Branch: MAIN
Changes since 1.84: +11 -6 lines
Diff to previous 1.84 (colored)

Buffer cache revamp

1) remove multiple size queues, introduced as a stopgap.
2) decouple pages containing data from their mappings
3) only keep buffers mapped when they actually have to be mapped
  (right now, this is when buffers are B_BUSY)
4) New functions to make a buffer busy, and release the busy flag
   (buf_acquire and buf_release)
5) Move high/low water marks and statistics counters into a structure
6) Add a sysctl to retrieve buffer cache statistics

Tested in several variants and beat upon by bob and art for a year. run
accidentally on henning's nfs server for a few months...

ok deraadt@, krw@, art@ - who promises to be around to deal with any fallout

Revision 1.84 / (download) - annotate - [select for diffs], Mon Jun 9 23:38:37 2008 UTC (16 years ago) by millert
Branch: MAIN
Changes since 1.83: +3 -3 lines
Diff to previous 1.83 (colored)

Update access(2) to have modern semantics with respect to X_OK and
the superuser.  access(2) will now only indicate success for X_OK on
non-directories if there is at least one execute bit set on the file.
OK deraadt@ thib@ otto@

Revision 1.83 / (download) - annotate - [select for diffs], Thu May 8 17:45:45 2008 UTC (16 years, 1 month ago) by thib
Branch: MAIN
Changes since 1.82: +2 -2 lines
Diff to previous 1.82 (colored)

retire vn_default_error() and replace all instances
with eopnotsupp() instead;

ok blambert@

Revision 1.82 / (download) - annotate - [select for diffs], Tue Apr 22 20:59:37 2008 UTC (16 years, 1 month ago) by thib
Branch: MAIN
Changes since 1.81: +3 -20 lines
Diff to previous 1.81 (colored)

Remove kludges that map EEXIST errors too a 0 return (success) for certain
operations (non-idempotent ones) under the assumption that the reply from
the server is for a duplicate of the original request.

However, most (all) NFS server today have a duplicate reply cache that
address this problem and these kludges have been shown to cause problems
with some applications (most notably dovecot as pointed out by brad@).

For more information:
http://lists.freebsd.org/pipermail/freebsd-current/2007-November/079961.html
And revision 1.277 of sys/nfsclient/nfs_vnops.c in FreeBSD.

Diff from rwatson@freebsd.org

OK blambert@, "no objections" krw@
tested by many;

Revision 1.81 / (download) - annotate - [select for diffs], Mon Apr 14 13:46:13 2008 UTC (16 years, 2 months ago) by blambert
Branch: MAIN
Changes since 1.80: +21 -26 lines
Diff to previous 1.80 (colored)

Rework NFS mbuf write routines:

nfsm_uiotombuf():
- no meaningful return, function becomes void
- replace frankensteined uiomove/MGET with actual call to uiomove

nfsm_strtmbuf():
- no meaningful return, becomes void
- rename and reorder parameters to be consistent with other functions
- becomes wrapper to nfsm_uiotombuf

nfsm_buftombuf():
- new function; unused but slated for future use
- wrapper to nfsm_uiotombuf

As a bonus, making these functions void removes much unneeded code and
garbage collects `magic' variable t2 which was only used (invisibly)
by the macros from nfsm_subs.h

Preps the way for removing much more NFS goo...

testing by myself, thib@ and merdely@
ok thib@

Revision 1.80 / (download) - annotate - [select for diffs], Sun Jan 6 17:38:23 2008 UTC (16 years, 5 months ago) by blambert
Branch: MAIN
CVS Tags: OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.79: +38 -38 lines
Diff to previous 1.79 (colored)

More NFS-related kernel shrinkage...

When you use a macro ~200 times, it tends to bloat your code, so make a
function out of it.

Shaves ~8.5 kB from my kernel.

ok thib@, "looks good" krw@

In snaps for 1+ week with no negative reports.

Revision 1.79 / (download) - annotate - [select for diffs], Thu Dec 13 18:32:55 2007 UTC (16 years, 6 months ago) by blambert
Branch: MAIN
Changes since 1.78: +6 -6 lines
Diff to previous 1.78 (colored)

convert massive (expanded to 150+ lines) nfsm_v3attr macro to a function

shaves an insane (~8K) amount from an i386 kernel

ok thib@

Revision 1.78 / (download) - annotate - [select for diffs], Wed Sep 26 16:00:55 2007 UTC (16 years, 8 months ago) by blambert
Branch: MAIN
Changes since 1.77: +6 -2 lines
Diff to previous 1.77 (colored)

nfsm_uiotom macro does nothing but hide error-handling code; replace
inline in the one place that it's called

ok thib@, weingart@
"I don't see why not" fgsch@

Revision 1.77 / (download) - annotate - [select for diffs], Thu Sep 20 12:54:31 2007 UTC (16 years, 8 months ago) by thib
Branch: MAIN
Changes since 1.76: +9 -12 lines
Diff to previous 1.76 (colored)

MALLOC/FREE -> malloc/free + M_ZERO.
Uneeded includes and casts...

ok krw@

Revision 1.76 / (download) - annotate - [select for diffs], Tue Sep 11 13:41:52 2007 UTC (16 years, 9 months ago) by blambert
Branch: MAIN
Changes since 1.75: +34 -18 lines
Diff to previous 1.75 (colored)

Replace nfsm_reqdone and nfsm_srvdone macros inline. No binary change.

ok thib@

Revision 1.75 / (download) - annotate - [select for diffs], Fri Jun 1 23:47:57 2007 UTC (17 years ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_2_BASE, OPENBSD_4_2
Changes since 1.74: +32 -186 lines
Diff to previous 1.74 (colored)

pedro ok'd this ~3500 line diff which removes the vop argument
"ap = v" comments in under 8 seconds, so it must be ok.  and it compiles
too.

Revision 1.74 / (download) - annotate - [select for diffs], Fri Jun 1 07:13:47 2007 UTC (17 years ago) by thib
Branch: MAIN
Changes since 1.73: +3 -3 lines
Diff to previous 1.73 (colored)

daddr_t -> daddr64_t;
Basically the usage of daddr_t was to math out arguments to
nfs_getcacheblk, wich calls getblk();

ok deraadt@

Revision 1.73 / (download) - annotate - [select for diffs], Sun Mar 18 15:05:33 2007 UTC (17 years, 2 months ago) by mickey
Branch: MAIN
Changes since 1.72: +1 -2 lines
Diff to previous 1.72 (colored)

get rid of noop vop_reallocblks; pedro@ miod@ ok

Revision 1.72 / (download) - annotate - [select for diffs], Fri Feb 23 14:27:06 2007 UTC (17 years, 3 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_1_BASE, OPENBSD_4_1
Changes since 1.71: +1 -10 lines
Diff to previous 1.71 (colored)

backout previous revision -- on nfs2 mounts (perhaps only automounted?) it
tends to .nfs silly files lying around during high filesystem activity.
whatever bug it was trying to fix, it made things worse.

Revision 1.71 / (download) - annotate - [select for diffs], Sun Jan 21 15:52:39 2007 UTC (17 years, 4 months ago) by pedro
Branch: MAIN
Changes since 1.70: +11 -2 lines
Diff to previous 1.70 (colored)

don't assume our directory vnode will be flushed out after us, fixes
crash when unmounting nfs volumes, okay thib@, krw@ and mickey@

Revision 1.70 / (download) - annotate - [select for diffs], Tue Jan 16 17:52:18 2007 UTC (17 years, 4 months ago) by thib
Branch: MAIN
Changes since 1.69: +1 -2 lines
Diff to previous 1.69 (colored)

Retire VOP_LEASE(); It was a bit for NQNFS and has
effectively been a no-op for quite some time now,
without promise for future usage.

ok pedro@
Testing by krw@ (earlier diff)
and Johan Mson Lindman (tybollt@solace.miun.se)

Revision 1.69 / (download) - annotate - [select for diffs], Fri Dec 29 13:04:37 2006 UTC (17 years, 5 months ago) by pedro
Branch: MAIN
Changes since 1.68: +7 -7 lines
Diff to previous 1.68 (colored)

Avoid void * arithmetic, okay deraadt@, suggestions from millert@

Revision 1.68 / (download) - annotate - [select for diffs], Wed Dec 6 17:49:58 2006 UTC (17 years, 6 months ago) by thib
Branch: MAIN
Changes since 1.67: +11 -9 lines
Diff to previous 1.67 (colored)

nfs_readdirplusrpc():
Replace the pointer aerobics used to construct the
namecache hash with a more saner approach since the
former could lead to a null deref (PR5305).

Also make sure that the current buf is bigenough
before caching the current entry.

comments&ok pedro@

Revision 1.67 / (download) - annotate - [select for diffs], Wed Apr 26 21:37:37 2006 UTC (18 years, 1 month ago) by pedro
Branch: MAIN
CVS Tags: OPENBSD_4_0_BASE, OPENBSD_4_0
Changes since 1.66: +2 -1 lines
Diff to previous 1.66 (colored)

In nfs_readdir(), if the buffer provided by the user is not big enough
to hold all the entries a directory has, we can't signal EOF.
Okay deraadt@ and miod@.

Revision 1.66 / (download) - annotate - [select for diffs], Thu Apr 20 14:43:32 2006 UTC (18 years, 1 month ago) by pedro
Branch: MAIN
Changes since 1.65: +1 -6 lines
Diff to previous 1.65 (colored)

Remove unused debug code that sneaked in by accident long ago

Revision 1.65 / (download) - annotate - [select for diffs], Thu Sep 29 00:45:51 2005 UTC (18 years, 8 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_9_BASE, OPENBSD_3_9
Changes since 1.64: +3 -3 lines
Diff to previous 1.64 (colored)

toast cast of lvalue; pr 4289

Revision 1.64 / (download) - annotate - [select for diffs], Thu Apr 21 23:29:04 2005 UTC (19 years, 1 month ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_8_BASE, OPENBSD_3_8
Changes since 1.63: +3 -1 lines
Diff to previous 1.63 (colored)

careful strlcpy and snprintf return handling; ok pedro beck

Revision 1.63 / (download) - annotate - [select for diffs], Tue Aug 3 17:11:48 2004 UTC (19 years, 10 months ago) by marius
Branch: MAIN
CVS Tags: OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6
Changes since 1.62: +46 -5 lines
Diff to previous 1.62 (colored)

NFS commit coalescion: instead of sending a commit for each block, coalesce
these into larger ranges wherever possible.

this should speed up NFS writes quite a bit.

ok art@ millert@ pedro@ tedu@

Revision 1.62 / (download) - annotate - [select for diffs], Wed Jul 21 17:30:56 2004 UTC (19 years, 10 months ago) by marius
Branch: MAIN
Changes since 1.61: +28 -3 lines
Diff to previous 1.61 (colored)

kqueue support for NFS, adapted from netbsd.

ok art@ pedro@, "get it in" deraadt@

Revision 1.61 / (download) - annotate - [select for diffs], Thu Jun 24 19:35:26 2004 UTC (19 years, 11 months ago) by tholo
Branch: MAIN
Changes since 1.60: +7 -13 lines
Diff to previous 1.60 (colored)

This moves access to wall and uptime variables in MI code,
encapsulating all such access into wall-defined functions
that makes sure locking is done as needed.

It also cleans up some uses of wall time vs. uptime some
places, but there is sure to be more of these needed as
well, particularily in MD code.  Also, many current calls
to microtime() should probably be changed to getmicrotime(),
or to the {,get}microuptime() versions.

ok art@ deraadt@ aaron@ matthieu@ beck@ sturm@ millert@ others
"Oh, that is not your problem!" from miod@

Revision 1.26.2.12 / (download) - annotate - [select for diffs], Sat Jun 5 23:13:08 2004 UTC (20 years ago) by niklas
Branch: SMP
Changes since 1.26.2.11: +38 -12 lines
Diff to previous 1.26.2.11 (colored) to branchpoint 1.26 (colored) next main 1.27 (colored)

Merge with the trunk

Revision 1.60 / (download) - annotate - [select for diffs], Fri May 14 04:00:34 2004 UTC (20 years, 1 month ago) by tedu
Branch: MAIN
CVS Tags: SMP_SYNC_B, SMP_SYNC_A
Changes since 1.59: +11 -10 lines
Diff to previous 1.59 (colored)

use pool for namei pathbuf.  testing ok millert@ tdeval@

Revision 1.59 / (download) - annotate - [select for diffs], Mon Apr 26 18:57:36 2004 UTC (20 years, 1 month ago) by millert
Branch: MAIN
Changes since 1.58: +19 -1 lines
Diff to previous 1.58 (colored)

nfs_poll cannot simply be defined to seltrue so use a stub nfs_poll
duplicated from UFS.  Closes PR 3757; OK deraadt@

Revision 1.53.2.2 / (download) - annotate - [select for diffs], Wed Mar 3 08:50:13 2004 UTC (20 years, 3 months ago) by brad
Branch: OPENBSD_3_3
Changes since 1.53.2.1: +9 -2 lines
Diff to previous 1.53.2.1 (colored) to branchpoint 1.53 (colored) next main 1.54 (colored)

MFC:
Fix from tedu@

prevent memory leak on revoke by freeing resources in a real reclaim
function.
also check fifoinfo is valid before deref.

ok deraadt@

Revision 1.55.2.2 / (download) - annotate - [select for diffs], Wed Mar 3 08:32:11 2004 UTC (20 years, 3 months ago) by brad
Branch: OPENBSD_3_4
Changes since 1.55.2.1: +9 -2 lines
Diff to previous 1.55.2.1 (colored) to branchpoint 1.55 (colored) next main 1.56 (colored)

MFC:
Fix from tedu@

prevent memory leak on revoke by freeing resources in a real reclaim
function.
also check fifoinfo is valid before deref.

ok deraadt@

Revision 1.58 / (download) - annotate - [select for diffs], Tue Mar 2 05:46:00 2004 UTC (20 years, 3 months ago) by tedu
Branch: MAIN
CVS Tags: OPENBSD_3_5_BASE, OPENBSD_3_5
Changes since 1.57: +9 -2 lines
Diff to previous 1.57 (colored)

silly fifos aren't a real fs, so we have to be sure to call reclaim
in the host fs.

Revision 1.53.2.1 / (download) - annotate - [select for diffs], Mon Mar 1 08:33:36 2004 UTC (20 years, 3 months ago) by brad
Branch: OPENBSD_3_3
Changes since 1.53: +3 -3 lines
Diff to previous 1.53 (colored)

MFC:
Fix by millert@

Defer use of NFS_ISV3 macro in nfs_link until sanity checks have been done.
Fixes a panic that can occur when trying to link from a local filesystem
to an nfs-mounted one.  Problem pointed out by Jim Rees, fix exists
in Net and Free.

ok deraadt@

Revision 1.55.2.1 / (download) - annotate - [select for diffs], Mon Mar 1 03:12:56 2004 UTC (20 years, 3 months ago) by brad
Branch: OPENBSD_3_4
Changes since 1.55: +3 -3 lines
Diff to previous 1.55 (colored)

MFC:
Fix by millert@

Defer use of NFS_ISV3 macro in nfs_link until sanity checks have been done.
Fixes a panic that can occur when trying to link from a local filesystem
to an nfs-mounted one.  Problem pointed out by Jim Rees, fix exists
in Net and Free.

ok deraadt@

Revision 1.57 / (download) - annotate - [select for diffs], Fri Feb 27 17:40:17 2004 UTC (20 years, 3 months ago) by millert
Branch: MAIN
Changes since 1.56: +3 -3 lines
Diff to previous 1.56 (colored)

Defer use of NFS_ISV3 macro in nfs_link until sanity checks have been done.
Fixes a panic that can occur when trying to link from a local filesystem
to an nfs-mounted one.  Problem pointed out by Jim Rees, fix exists
in Net and Free.  OK tedu@ csapuntz@

Revision 1.26.2.11 / (download) - annotate - [select for diffs], Thu Feb 19 10:57:27 2004 UTC (20 years, 3 months ago) by niklas
Branch: SMP
Changes since 1.26.2.10: +2 -2 lines
Diff to previous 1.26.2.10 (colored) to branchpoint 1.26 (colored)

Merge of current from two weeks agointo the SMP branch

Revision 1.56 / (download) - annotate - [select for diffs], Tue Sep 23 16:51:13 2003 UTC (20 years, 8 months ago) by millert
Branch: MAIN
Changes since 1.55: +2 -2 lines
Diff to previous 1.55 (colored)

Replace select backends with poll backends.  selscan() and pollscan()
now call the poll backend.  With this change we implement greater
poll(2) functionality instead of emulating it via the select backend.
Adapted from NetBSD and including some changes from FreeBSD.
Tested by many, deraadt@ OK

Revision 1.26.2.10 / (download) - annotate - [select for diffs], Sat Jun 7 11:07:44 2003 UTC (21 years ago) by ho
Branch: SMP
Changes since 1.26.2.9: +2 -6 lines
Diff to previous 1.26.2.9 (colored) to branchpoint 1.26 (colored)

Sync SMP branch to -current

Revision 1.55 / (download) - annotate - [select for diffs], Mon Jun 2 23:28:20 2003 UTC (21 years ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_4_BASE
Branch point for: OPENBSD_3_4
Changes since 1.54: +2 -6 lines
Diff to previous 1.54 (colored)

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999.  Proofed by myself and Theo.

Revision 1.44.2.6 / (download) - annotate - [select for diffs], Mon May 19 22:36:43 2003 UTC (21 years ago) by tedu
Branch: UBC
Changes since 1.44.2.5: +152 -97 lines
Diff to previous 1.44.2.5 (colored) to branchpoint 1.44 (colored) next main 1.45 (colored)

sync

Revision 1.26.2.9 / (download) - annotate - [select for diffs], Tue May 13 19:36:57 2003 UTC (21 years, 1 month ago) by ho
Branch: SMP
Changes since 1.26.2.8: +3 -2 lines
Diff to previous 1.26.2.8 (colored) to branchpoint 1.26 (colored)

Sync the SMP branch to -current. This includes moving to ELF.

Revision 1.54 / (download) - annotate - [select for diffs], Tue May 6 21:43:26 2003 UTC (21 years, 1 month ago) by deraadt
Branch: MAIN
CVS Tags: UBC_SYNC_A
Changes since 1.53: +3 -2 lines
Diff to previous 1.53 (colored)

string cleaning; tedu ok

Revision 1.26.2.8 / (download) - annotate - [select for diffs], Fri Mar 28 00:08:46 2003 UTC (21 years, 2 months ago) by niklas
Branch: SMP
Changes since 1.26.2.7: +147 -85 lines
Diff to previous 1.26.2.7 (colored) to branchpoint 1.26 (colored)

Sync the SMP branch with 3.3

Revision 1.53 / (download) - annotate - [select for diffs], Fri Jan 31 17:37:50 2003 UTC (21 years, 4 months ago) by art
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE
Branch point for: OPENBSD_3_3
Changes since 1.52: +139 -34 lines
Diff to previous 1.52 (colored)

File system locking fixups, mostly from NetBSD:
- cache_lookup
        move common code from various fs's here
        always return with vnode and parent locked
        adjust return codes
- PDIRUNLOCK - new flag set if lookup couldn't lock parent vnode
- kernfs and procfs
        lock vnode in get_root
        don't unlock (again) in kernfs_freevp
        fix memory leak in procfs

From tedu@stanford.edu
deraadt@ and various other ok

Revision 1.52 / (download) - annotate - [select for diffs], Fri Nov 8 04:34:17 2002 UTC (21 years, 7 months ago) by art
Branch: MAIN
Changes since 1.51: +6 -51 lines
Diff to previous 1.51 (colored)

Implement simple vnodeop inheritance for specfs and fifofs.

The inheritace is implemented by setting the default vnodeop to a
bypass op that repeats the operation on the spec/fifo vnodeop vector.
The overhead of one extra indirect function call is worth the cleanup
and improved correctness.

This actually solves a few bugs where some vnode ops were missing from
some vectors (like kqfilter or revoke). (and even more on the ubc
branch).

Inspired by the same thing done in FreeBSD.

Revision 1.44.2.5 / (download) - annotate - [select for diffs], Mon Nov 4 18:02:32 2002 UTC (21 years, 7 months ago) by art
Branch: UBC
Changes since 1.44.2.4: +82 -104 lines
Diff to previous 1.44.2.4 (colored) to branchpoint 1.44 (colored)

Huge sync to NetBSD plus lots of bugfixes.
 - uvm is as in netbsd-current minus uvm_map forward merge.
 - various locking bugfixes in nfs.
 - make sure that all specops and fifoops are correct in all vnodeop vectors.
 - make the filesystem code more like filsystem code and less like vm code.

Revision 1.44.2.4 / (download) - annotate - [select for diffs], Tue Oct 29 18:31:51 2002 UTC (21 years, 7 months ago) by art
Branch: UBC
Changes since 1.44.2.3: +128 -39 lines
Diff to previous 1.44.2.3 (colored) to branchpoint 1.44 (colored)

Resurrect Costas nfs locking on the UBC branch. It's needed here.

Revision 1.44.2.3 / (download) - annotate - [select for diffs], Tue Jun 11 03:32:04 2002 UTC (22 years ago) by art
Branch: UBC
Changes since 1.44.2.2: +8 -8 lines
Diff to previous 1.44.2.2 (colored) to branchpoint 1.44 (colored)

Sync UBC branch to -current

Revision 1.51 / (download) - annotate - [select for diffs], Tue May 21 21:07:09 2002 UTC (22 years ago) by art
Branch: MAIN
CVS Tags: UBC_SYNC_B, OPENBSD_3_2_BASE, OPENBSD_3_2
Changes since 1.50: +4 -2 lines
Diff to previous 1.50 (colored)

Protect calls to biodone with splbio. Some functions called
by biodone assume splbio (probably just on other filesystems) and some
callbacks from b_iodone assume it too. It's just much safer.
costa@ ok.

Revision 1.26.2.7 / (download) - annotate - [select for diffs], Thu Mar 28 15:02:48 2002 UTC (22 years, 2 months ago) by niklas
Branch: SMP
Changes since 1.26.2.6: +9 -9 lines
Diff to previous 1.26.2.6 (colored) to branchpoint 1.26 (colored)

Merge in -current from roughly a week ago

Revision 1.50 / (download) - annotate - [select for diffs], Thu Mar 14 01:27:13 2002 UTC (22 years, 3 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.49: +10 -10 lines
Diff to previous 1.49 (colored)

First round of __P removal in sys

Revision 1.26.2.6 / (download) - annotate - [select for diffs], Wed Mar 6 02:17:12 2002 UTC (22 years, 3 months ago) by niklas
Branch: SMP
Changes since 1.26.2.5: +351 -145 lines
Diff to previous 1.26.2.5 (colored) to branchpoint 1.26 (colored)

Merge in trunk

Revision 1.49 / (download) - annotate - [select for diffs], Sat Feb 23 23:47:13 2002 UTC (22 years, 3 months ago) by art
Branch: MAIN
Changes since 1.48: +38 -127 lines
Diff to previous 1.48 (colored)

Sigh. The diff is out for testing for three months without a single problem.
Two days after commit people report serious lockups all over the place.
Back out nfs locking changes.

Revision 1.48 / (download) - annotate - [select for diffs], Fri Feb 22 20:19:14 2002 UTC (22 years, 3 months ago) by csapuntz
Branch: MAIN
Changes since 1.47: +128 -39 lines
Diff to previous 1.47 (colored)

More locking in the NFS code

Revision 1.44.2.2 / (download) - annotate - [select for diffs], Sat Feb 2 03:28:26 2002 UTC (22 years, 4 months ago) by art
Branch: UBC
Changes since 1.44.2.1: +14 -15 lines
Diff to previous 1.44.2.1 (colored) to branchpoint 1.44 (colored)

Merge in UBC performance changes from NetBSD.
Fix a bunch of merge errors from yesterday.

Revision 1.44.2.1 / (download) - annotate - [select for diffs], Thu Jan 31 22:55:47 2002 UTC (22 years, 4 months ago) by niklas
Branch: UBC
Changes since 1.44: +127 -127 lines
Diff to previous 1.44 (colored)

Merge in -current, builds on i386, otherwise untested

Revision 1.47 / (download) - annotate - [select for diffs], Wed Jan 16 21:51:16 2002 UTC (22 years, 4 months ago) by ericj
Branch: MAIN
Changes since 1.46: +137 -137 lines
Diff to previous 1.46 (colored)

use queue.h macro's
remove register

Revision 1.46 / (download) - annotate - [select for diffs], Sat Dec 22 09:58:04 2001 UTC (22 years, 5 months ago) by art
Branch: MAIN
Changes since 1.45: +21 -1 lines
Diff to previous 1.45 (colored)

Init the creds in nfs_open too.
Repairs swap over nfs. Tested by hugh@

Revision 1.45 / (download) - annotate - [select for diffs], Wed Dec 19 08:58:06 2001 UTC (22 years, 5 months ago) by art
Branch: MAIN
Changes since 1.44: +228 -45 lines
Diff to previous 1.44 (colored)

UBC was a disaster. It worked very good when it worked, but on some
machines or some configurations or in some phase of the moon (we actually
don't know when or why) files disappeared. Since we've not been able to
track down the problem in two weeks intense debugging and we need -current
to be stable, back out everything to a state it had before UBC.

We apologise for the inconvenience.

Revision 1.44 / (download) - annotate - [select for diffs], Tue Dec 11 09:32:46 2001 UTC (22 years, 6 months ago) by art
Branch: MAIN
CVS Tags: UBC_BASE
Branch point for: UBC
Changes since 1.43: +2 -2 lines
Diff to previous 1.43 (colored)

minor fixes.

Revision 1.43 / (download) - annotate - [select for diffs], Mon Dec 10 04:45:31 2001 UTC (22 years, 6 months ago) by art
Branch: MAIN
Changes since 1.42: +2 -2 lines
Diff to previous 1.42 (colored)

Big cleanup inspired by NetBSD with some parts of the code from NetBSD.
 - get rid of VOP_BALLOCN and VOP_SIZE
 - move the generic getpages and putpages into miscfs/genfs
 - create a genfs_node which must be added to the top of the private portion
   of each vnode for filsystems that want to use genfs_{get,put}pages
 - rename genfs_mmap to vop_generic_mmap

Revision 1.42 / (download) - annotate - [select for diffs], Mon Dec 10 02:19:34 2001 UTC (22 years, 6 months ago) by art
Branch: MAIN
Changes since 1.41: +2 -2 lines
Diff to previous 1.41 (colored)

Merge in struct uvm_vnode into struct vnode.

Revision 1.26.2.5 / (download) - annotate - [select for diffs], Wed Dec 5 01:02:40 2001 UTC (22 years, 6 months ago) by niklas
Branch: SMP
Changes since 1.26.2.4: +68 -290 lines
Diff to previous 1.26.2.4 (colored) to branchpoint 1.26 (colored)

Merge in -current

Revision 1.41 / (download) - annotate - [select for diffs], Tue Dec 4 22:44:32 2001 UTC (22 years, 6 months ago) by art
Branch: MAIN
Changes since 1.40: +6 -3 lines
Diff to previous 1.40 (colored)

Readd VOP_MMAP, will be used soon. Right now it's just a question to
the filesystem if we're allowed to mmap the file.

Revision 1.40 / (download) - annotate - [select for diffs], Tue Nov 27 05:27:12 2001 UTC (22 years, 6 months ago) by art
Branch: MAIN
Changes since 1.39: +39 -225 lines
Diff to previous 1.39 (colored)

Merge in the unified buffer cache code as found in NetBSD 2001/03/10. The
code is written mostly by Chuck Silvers <chuq@chuq.com>/<chs@netbsd.org>.

Tested for the past few weeks by many developers, should be in a pretty stable
state, but will require optimizations and additional cleanups.

Revision 1.39 / (download) - annotate - [select for diffs], Thu Nov 15 23:15:15 2001 UTC (22 years, 7 months ago) by art
Branch: MAIN
Changes since 1.38: +35 -71 lines
Diff to previous 1.38 (colored)

Remove creds from struct buf, move the creds that nfs need into the nfs node.
While in the area, convert nfs node allocation from malloc to pool and do
some cleanups.
Based on the UBC changes in NetBSD. niklas@ ok.

Revision 1.26.2.4 / (download) - annotate - [select for diffs], Tue Nov 13 22:59:59 2001 UTC (22 years, 7 months ago) by niklas
Branch: SMP
Changes since 1.26.2.3: +2 -2 lines
Diff to previous 1.26.2.3 (colored) to branchpoint 1.26 (colored)

merge in -current

Revision 1.38 / (download) - annotate - [select for diffs], Tue Nov 6 19:53:21 2001 UTC (22 years, 7 months ago) by miod
Branch: MAIN
Changes since 1.37: +2 -2 lines
Diff to previous 1.37 (colored)

Replace inclusion of <vm/foo.h> with the correct <uvm/bar.h> when necessary.
(Look ma, I might have broken the tree)

Revision 1.26.2.3 / (download) - annotate - [select for diffs], Wed Oct 31 03:30:30 2001 UTC (22 years, 7 months ago) by nate
Branch: SMP
Changes since 1.26.2.2: +2 -1 lines
Diff to previous 1.26.2.2 (colored) to branchpoint 1.26 (colored)

Sync the SMP branch to something just after 3.0

Revision 1.37 / (download) - annotate - [select for diffs], Thu Jul 26 20:24:47 2001 UTC (22 years, 10 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0
Changes since 1.36: +9 -19 lines
Diff to previous 1.36 (colored)

Back out changes to symlink and mknod that were not well tested.
A simple mknod at causes a kernel panic (uvm_fault).

Revision 1.36 / (download) - annotate - [select for diffs], Thu Jul 26 02:10:41 2001 UTC (22 years, 10 months ago) by assar
Branch: MAIN
Changes since 1.35: +20 -10 lines
Diff to previous 1.35 (colored)

change vop_symlink and vop_mknod to return vpp (the created node)
refed, so that the caller can actually use it.  update callers and
file systems that implement these vnode operations

ok'd by art

Revision 1.26.2.2 / (download) - annotate - [select for diffs], Wed Jul 4 10:55:52 2001 UTC (22 years, 11 months ago) by niklas
Branch: SMP
Changes since 1.26.2.1: +227 -342 lines
Diff to previous 1.26.2.1 (colored) to branchpoint 1.26 (colored)

Merge in -current from two days ago in the SMP branch.
As usual with merges, they do not indicate progress, so do not hold
your breath for working SMP, and do not mail me and ask about the
state of it.  It has not changed.  There is work ongoing, but very, very
slowly.  The commit is done in parts as to not lock up the tree in too
big chunks at a time.

Revision 1.35 / (download) - annotate - [select for diffs], Tue Jul 3 01:55:13 2001 UTC (22 years, 11 months ago) by csapuntz
Branch: MAIN
Changes since 1.34: +2 -1 lines
Diff to previous 1.34 (colored)

In readdir, set the calling process in the constructed uio structures.
Fixes problems with interruptible NFS mounts.

Revision 1.34 / (download) - annotate - [select for diffs], Wed Jun 27 04:58:46 2001 UTC (22 years, 11 months ago) by art
Branch: MAIN
Changes since 1.33: +1 -17 lines
Diff to previous 1.33 (colored)

Remove old vm.

Revision 1.33 / (download) - annotate - [select for diffs], Mon Jun 25 03:28:13 2001 UTC (22 years, 11 months ago) by csapuntz
Branch: MAIN
Changes since 1.32: +27 -67 lines
Diff to previous 1.32 (colored)

Remove NQNFS

Revision 1.32 / (download) - annotate - [select for diffs], Mon Jun 25 02:15:48 2001 UTC (22 years, 11 months ago) by csapuntz
Branch: MAIN
Changes since 1.31: +205 -122 lines
Diff to previous 1.31 (colored)

Get rid of old directory caching scheme which caused persistent duplicates.

Still not correct for NFSv3 but that's hard.

Revision 1.31 / (download) - annotate - [select for diffs], Sat Jun 23 02:14:26 2001 UTC (22 years, 11 months ago) by csapuntz
Branch: MAIN
Changes since 1.30: +1 -144 lines
Diff to previous 1.30 (colored)

Get rid of several unused vnode operations

Revision 1.30 / (download) - annotate - [select for diffs], Tue Jun 5 21:56:14 2001 UTC (23 years ago) by provos
Branch: MAIN
Changes since 1.29: +2 -1 lines
Diff to previous 1.29 (colored)

make kqueue behave like select

Revision 1.26.2.1 / (download) - annotate - [select for diffs], Mon May 14 22:44:58 2001 UTC (23 years, 1 month ago) by niklas
Branch: SMP
Changes since 1.26: +18 -28 lines
Diff to previous 1.26 (colored)

merge in approximately 2.9 into SMP branch

Revision 1.29 / (download) - annotate - [select for diffs], Sat Feb 24 19:07:11 2001 UTC (23 years, 3 months ago) by csapuntz
Branch: MAIN
CVS Tags: OPENBSD_2_9_BASE, OPENBSD_2_9
Changes since 1.28: +8 -12 lines
Diff to previous 1.28 (colored)

Cleanup of vnode interface continues. Get rid of VHOLD/HOLDRELE.
Change VM/UVM to use buf_replacevnode to change the vnode associated
with a buffer.

Addition v_bioflag for flags written in interrupt handlers
(and read at splbio, though not strictly necessary)

Add vwaitforio and use it instead of a while loop of v_numoutput.

Fix race conditions when manipulation vnode free list

Revision 1.28 / (download) - annotate - [select for diffs], Fri Feb 23 14:52:51 2001 UTC (23 years, 3 months ago) by csapuntz
Branch: MAIN
Changes since 1.27: +10 -16 lines
Diff to previous 1.27 (colored)

Change the B_DELWRI flag using buf_dirty and buf_undirty instead of
manually twiddling it. This allows the buffer cache to more easily
keep track of dirty buffers and decide when it is appropriate to speed
up the syncer.

Insipired by FreeBSD.
Look over by art@

Revision 1.27 / (download) - annotate - [select for diffs], Fri Feb 9 22:26:05 2001 UTC (23 years, 4 months ago) by mickey
Branch: MAIN
Changes since 1.26: +2 -2 lines
Diff to previous 1.26 (colored)

use correct FREE() do dispose sillyrename on fail; deraadt@ ok

Revision 1.26 / (download) - annotate - [select for diffs], Wed Feb 2 04:59:07 2000 UTC (24 years, 4 months ago) by millert
Branch: MAIN
CVS Tags: SMP_BASE, OPENBSD_2_8_BASE, OPENBSD_2_8, OPENBSD_2_7_BASE, OPENBSD_2_7
Branch point for: SMP
Changes since 1.25: +13 -15 lines
Diff to previous 1.25 (colored)

o Don't call nfs_sillyrename() form nfs_remove if v_type == VDIR
  (from FreeBSD).  This avoids the panic described below.
o In nfs_sillyrename(), change a panic if v_type == VDIR to just
  a printf (ifdef DIAGNOSTIC) and return EINVAL.
o When building the .nfs file in nfs_sillyrename() don't assume a pid
  is only 4 chars long since PID_MAX is 5 chars and use sprintf()
  instead of converting the pid to ascii by hand.
Thanks to Theo for assistance and sanity checking.

Revision 1.25 / (download) - annotate - [select for diffs], Fri Feb 26 03:16:26 1999 UTC (25 years, 3 months ago) by art
Branch: MAIN
CVS Tags: kame_19991208, OPENBSD_2_6_BASE, OPENBSD_2_6, OPENBSD_2_5_BASE, OPENBSD_2_5
Changes since 1.24: +21 -1 lines
Diff to previous 1.24 (colored)

compatibility with uvm vnode pager

Revision 1.24 / (download) - annotate - [select for diffs], Sat Feb 6 23:07:46 1999 UTC (25 years, 4 months ago) by millert
Branch: MAIN
Changes since 1.23: +4 -4 lines
Diff to previous 1.23 (colored)

Use bitwise operations to extract high and low words from the quad
in txdr_hyper.  This should be more portable than casting to an array
of ints and pulling out the two 32-bit words (this produced incorrect
results on alpha for the high word for filesystems < 4gig).  As a side
effect, txdr_hyper now takes a u_quad_t as its first arg, not u_quad_t *.

Revision 1.23 / (download) - annotate - [select for diffs], Sun Jan 10 20:06:51 1999 UTC (25 years, 5 months ago) by millert
Branch: MAIN
Changes since 1.22: +18 -85 lines
Diff to previous 1.22 (colored)

Fix for creating files on a Solaris 7 server with NFSv3 (the request was
slightly garbled but older servers seemed to understand it); dfr@freebsd.org

Revision 1.22 / (download) - annotate - [select for diffs], Wed Aug 19 22:26:57 1998 UTC (25 years, 9 months ago) by csapuntz
Branch: MAIN
CVS Tags: OPENBSD_2_4_BASE, OPENBSD_2_4
Changes since 1.21: +3 -3 lines
Diff to previous 1.21 (colored)

Change fxdr_hyper to return a u_quad_t. This minimizes the evil clobbering
of lvalues that ANSI abhors.

And it fixes df on NFS version 3 mounts on Sparcs.

Revision 1.21 / (download) - annotate - [select for diffs], Thu Aug 6 19:35:00 1998 UTC (25 years, 10 months ago) by csapuntz
Branch: MAIN
Changes since 1.20: +5 -5 lines
Diff to previous 1.20 (colored)

Rename vop_revoke, vn_bwrite, vop_noislocked, vop_nolock, vop_nounlock
to be vop_generic_revoke, vop_generic_bwrite, vop_generic_islocked,
vop_generic_lock and vop_generic_unlock.

Create vop_generic_abortop and propogate change to all file systems.

Fix PR/371.

Get rid of locking in NULLFS (should be mostly unnecessary now except for
forced unmounts).

Revision 1.20 / (download) - annotate - [select for diffs], Mon May 11 05:42:01 1998 UTC (26 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.19: +8 -8 lines
Diff to previous 1.19 (colored)

compile if iov_base is void *

Revision 1.19 / (download) - annotate - [select for diffs], Tue Dec 2 16:57:59 1997 UTC (26 years, 6 months ago) by csapuntz
Branch: MAIN
CVS Tags: OPENBSD_2_3_BASE, OPENBSD_2_3
Changes since 1.18: +13 -1 lines
Diff to previous 1.18 (colored)

More splbio()'s added so that reassignbuf can do its thing.

Revision 1.18 / (download) - annotate - [select for diffs], Thu Nov 6 05:59:05 1997 UTC (26 years, 7 months ago) by csapuntz
Branch: MAIN
Changes since 1.17: +15 -19 lines
Diff to previous 1.17 (colored)

Updates for VFS Lite 2 + soft update.

Revision 1.17 / (download) - annotate - [select for diffs], Mon Oct 6 20:20:54 1997 UTC (26 years, 8 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_2_BASE, OPENBSD_2_2
Changes since 1.16: +18 -14 lines
Diff to previous 1.16 (colored)

back out vfs lite2 till after 2.2

Revision 1.16 / (download) - annotate - [select for diffs], Mon Oct 6 15:23:45 1997 UTC (26 years, 8 months ago) by csapuntz
Branch: MAIN
Changes since 1.15: +15 -19 lines
Diff to previous 1.15 (colored)

VFS Lite2 Changes

Revision 1.15 / (download) - annotate - [select for diffs], Fri Apr 18 09:57:29 1997 UTC (27 years, 2 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_1_BASE, OPENBSD_2_1
Changes since 1.14: +2 -2 lines
Diff to previous 1.14 (colored)

indent

Revision 1.14 / (download) - annotate - [select for diffs], Tue Apr 8 22:46:50 1997 UTC (27 years, 2 months ago) by deraadt
Branch: MAIN
Changes since 1.13: +8 -2 lines
Diff to previous 1.13 (colored)

chflags not permitted

Revision 1.13 / (download) - annotate - [select for diffs], Fri Jan 31 10:33:46 1997 UTC (27 years, 4 months ago) by deraadt
Branch: MAIN
Changes since 1.12: +2 -2 lines
Diff to previous 1.12 (colored)

do not sillyrename directories; from freebsd

Revision 1.12 / (download) - annotate - [select for diffs], Tue Nov 12 15:51:34 1996 UTC (27 years, 7 months ago) by mickey
Branch: MAIN
Changes since 1.11: +2 -2 lines
Diff to previous 1.11 (colored)

typo

Revision 1.11 / (download) - annotate - [select for diffs], Sat Jul 27 11:08:48 1996 UTC (27 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.10: +3 -3 lines
Diff to previous 1.10 (colored)

use mtime for v3 setattr

Revision 1.10 / (download) - annotate - [select for diffs], Tue Jul 23 21:32:33 1996 UTC (27 years, 10 months ago) by deraadt
Branch: MAIN
Changes since 1.9: +2 -2 lines
Diff to previous 1.9 (colored)

sync

Revision 1.9 / (download) - annotate - [select for diffs], Fri Jun 14 04:41:09 1996 UTC (28 years ago) by tholo
Branch: MAIN
Changes since 1.8: +5 -1 lines
Diff to previous 1.8 (colored)

Keep dirty list used by in-kernel update(8) in sync with buffers

Revision 1.8 / (download) - annotate - [select for diffs], Wed May 22 11:47:16 1996 UTC (28 years ago) by deraadt
Branch: MAIN
Changes since 1.7: +3 -3 lines
Diff to previous 1.7 (colored)

Change VOP_UPDATE() semantics:
* Make 2nd and 3rd args timespecs, not timevals.
* Consistently pass a Boolean as the 4th arg (except in LFS).
Also, fix ffs_update() and lfs_update() to actually change the nsec fields.

Revision 1.7 / (download) - annotate - [select for diffs], Sun Apr 21 22:30:36 1996 UTC (28 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.6: +35 -28 lines
Diff to previous 1.6 (colored)

partial sync with netbsd 960418, more to come

Revision 1.6 / (download) - annotate - [select for diffs], Wed Apr 17 04:50:35 1996 UTC (28 years, 2 months ago) by mickey
Branch: MAIN
Changes since 1.5: +27 -28 lines
Diff to previous 1.5 (colored)

Minor cleanups. Checked against Lite2.
(NetBSD's was really just a Lite2's, but w/ 64bit support)

Revision 1.5 / (download) - annotate - [select for diffs], Sun Mar 31 13:16:03 1996 UTC (28 years, 2 months ago) by mickey
Branch: MAIN
Changes since 1.4: +1539 -820 lines
Diff to previous 1.4 (colored)

From NetBSD: NFSv3 import (tomorrow's Net's kernel)
Open's patches kept in. i'll possibly take a look at Lite2 soon,
is there smth usefull ?..

Revision 1.4 / (download) - annotate - [select for diffs], Thu Feb 29 09:24:59 1996 UTC (28 years, 3 months ago) by niklas
Branch: MAIN
Changes since 1.3: +250 -211 lines
Diff to previous 1.3 (colored)

From NetBSD: merge with 960217 (still NFSv2)

Revision 1.3 / (download) - annotate - [select for diffs], Thu Dec 21 14:42:27 1995 UTC (28 years, 5 months ago) by deraadt
Branch: MAIN
Changes since 1.2: +67 -67 lines
Diff to previous 1.2 (colored)

from cgd; handle 64-bit pointers and longs

Revision 1.2 / (download) - annotate - [select for diffs], Thu Oct 26 01:38:38 1995 UTC (28 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.1: +35 -8 lines
Diff to previous 1.1 (colored)

update from netbsd

Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Wed Oct 18 08:53:22 1995 UTC (28 years, 8 months ago) by deraadt
CVS Tags: netbsd_1_1
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)

initial import of NetBSD tree

Revision 1.1 / (download) - annotate - [select for diffs], Wed Oct 18 08:53:22 1995 UTC (28 years, 8 months ago) by deraadt
Branch: MAIN

Initial revision

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.