Annotation of src/usr.bin/awk/FIXES, Revision 1.15
1.15 ! millert 1: /* $OpenBSD: FIXES,v 1.14 2008/10/06 20:38:33 millert Exp $ */
1.1 tholo 2: /****************************************************************
1.6 kstailey 3: Copyright (C) Lucent Technologies 1997
1.1 tholo 4: All Rights Reserved
5:
6: Permission to use, copy, modify, and distribute this software and
7: its documentation for any purpose and without fee is hereby
8: granted, provided that the above copyright notice appear in all
9: copies and that both that the copyright notice and this
10: permission notice and warranty disclaimer appear in supporting
1.6 kstailey 11: documentation, and that the name Lucent Technologies or any of
12: its entities not be used in advertising or publicity pertaining
13: to distribution of the software without specific, written prior
14: permission.
15:
16: LUCENT DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE,
17: INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS.
18: IN NO EVENT SHALL LUCENT OR ANY OF ITS ENTITIES BE LIABLE FOR ANY
19: SPECIAL, INDIRECT OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
20: WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER
21: IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION,
22: ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF
23: THIS SOFTWARE.
1.1 tholo 24: ****************************************************************/
25:
26: This file lists all bug fixes, changes, etc., made since the AWK book
27: was sent to the printers in August, 1987.
1.15 ! millert 28:
! 29: May 23, 2010:
! 30: fixed long-standing overflow bug in run.c; many thanks to
! 31: nelson beebe for spotting it and providing the fix.
! 32:
! 33: fixed bug that didn't parse -vd=1 properly; thanks to santiago
! 34: vila for spotting it.
! 35:
! 36: Feb 8, 2010:
! 37: i give up. replaced isblank with isspace in b.c; there are
! 38: no consistent header files.
! 39:
! 40: Nov 26, 2009:
! 41: fixed a long-standing issue with when FS takes effect. a
! 42: change to FS is now noticed immediately for subsequent splits.
! 43:
! 44: changed the name getline() to awkgetline() to avoid yet another
! 45: name conflict somewhere.
! 46:
! 47: Feb 11, 2009:
! 48: temporarily for now defined HAS_ISBLANK, since that seems to
! 49: be the best way through the thicket. isblank arrived in C99,
! 50: but seems to be arriving at different systems at different
! 51: times.
! 52:
! 53: Oct 8, 2008:
! 54: fixed typo in b.c that set tmpvec wrongly. no one had ever
! 55: run into the problem, apparently. thanks to alistair crooks.
1.14 millert 56:
57: Oct 23, 2007:
58: minor fix in lib.c: increase inputFS to 100, change malloc
59: for fields to n+1.
60:
61: fixed memory fault caused by out of order test in setsval.
62:
63: thanks to david o'brien, freebsd, for both fixes.
64:
65: May 1, 2007:
66: fiddle in makefile to fix for BSD make; thanks to igor sobrado.
67:
68: Mar 31, 2007:
69: fixed some null pointer refs calling adjbuf.
70:
71: Feb 21, 2007:
72: fixed a bug in matching the null RE in sub and gsub. thanks to al aho
73: who actually did the fix (in b.c), and to wolfgang seeberg for finding
74: it and providing a very compact test case.
75:
76: fixed quotation in b.c; thanks to Hal Pratt and the Princeton Dante
77: Project.
78:
79: removed some no-effect asserts in run.c.
80:
81: fiddled maketab.c to not complain about bison-generated values.
82:
83: removed the obsolete -V argument; fixed --version to print the
84: version and exit.
85:
86: fixed wording and an outright error in the usage message; thanks to igor
87: sobrado and jason mcintyre.
88:
89: fixed a bug in -d that caused core dump if no program followed.
90:
91: Jan 1, 2007:
92: dropped mac.code from makefile; there are few non-MacOSX
93: mac's these days.
94:
95: Jan 17, 2006:
96: system() not flagged as unsafe in the unadvertised -safe option.
97: found it while enhancing tests before shipping the ;login: article.
98: practice what you preach.
99:
100: removed the 9-years-obsolete -mr and -mf flags.
101:
102: added -version and --version options.
103:
104: core dump on linux with BEGIN {nextfile}, now fixed.
105:
106: removed some #ifdef's in run.c and lex.c that appear to no
107: longer be necessary.
108:
109: Apr 24, 2005:
110: modified lib.c so that values of $0 et al are preserved in the END
111: block, apparently as required by posix. thanks to havard eidnes
112: for the report and code.
113:
114: Jan 14, 2005:
115: fixed infinite loop in parsing, originally found by brian tsang.
116: thanks to arnold robbins for a suggestion that started me
117: rethinking it.
118:
119: Dec 31, 2004:
120: prevent overflow of -f array in main, head off potential error in
121: call of SYNTAX(), test malloc return in lib.c, all with thanks to
122: todd miller.
1.13 millert 123:
124: Dec 22, 2004:
125: cranked up size of NCHARS; coverity thinks it can be overrun with
126: smaller size, and i think that's right. added some assertions to b.c
127: to catch places where it might overrun. the RE code is still fragile.
128:
129: Dec 5, 2004:
130: fixed a couple of overflow problems with ridiculous field numbers:
131: e.g., print $(2^32-1). thanks to ruslan ermilov, giorgos keramidas
132: and david o'brien at freebsd.org for patches. this really should
133: be re-done from scratch.
134:
135: Nov 21, 2004:
136: fixed another 25-year-old RE bug, in split. it's another failure
137: to (re-)initialize. thanks to steve fisher for spotting this and
138: providing a good test case.
139:
140: Nov 22, 2003:
141: fixed a bug in regular expressions that dates (so help me) from 1977;
142: it's been there from the beginning. an anchored longest match that
143: was longer than the number of states triggered a failure to initialize
144: the machine properly. many thanks to moinak ghosh for not only finding
145: this one but for providing a fix, in some of the most mysterious
146: code known to man.
147:
148: fixed a storage leak in call() that appears to have been there since
149: 1983 or so -- a function without an explicit return that assigns a
150: string to a parameter leaked a Cell. thanks to moinak ghosh for
151: spotting this very subtle one.
152:
153: Jul 31, 2003:
154: fixed, thanks to andrey chernov and ruslan ermilov, a bug in lex.c
155: that mis-handled the character 255 in input. (it was being compared
156: to EOF with a signed comparison.)
157:
158: Jul 29, 2003:
159: fixed (i think) the long-standing botch that included the beginning of
160: line state ^ for RE's in the set of valid characters; this led to a
161: variety of odd problems, including failure to properly match certain
162: regular expressions in non-US locales. thanks to ruslan for keeping
163: at this one.
164:
165: Jul 28, 2003:
166: n-th try at getting internationalization right, with thanks to volker
167: kiefel, arnold robbins and ruslan ermilov for advice, though they
168: should not be blamed for the outcome. according to posix, "." is the
169: radix character in programs and command line arguments regardless of
170: the locale; otherwise, the locale should prevail for input and output
171: of numbers. so it's intended to work that way.
172:
173: i have rescinded the attempt to use strcoll in expanding shorthands in
174: regular expressions (cclenter). its properties are much too
175: surprising; for example [a-c] matches aAbBc in locale en_US but abBcC
176: in locale fr_CA. i can see how this might arise by implementation
177: but i cannot explain it to a human user. (this behavior can be seen
178: in gawk as well; we're leaning on the same library.)
179:
180: the issue appears to be that strcoll is meant for sorting, where
181: merging upper and lower case may make sense (though note that unix
182: sort does not do this by default either). it is not appropriate
183: for regular expressions, where the goal is to match specific
184: patterns of characters. in any case, the notations [:lower:], etc.,
185: are available in awk, and they are more likely to work correctly in
186: most locales.
187:
188: a moratorium is hereby declared on internationalization changes.
189: i apologize to friends and colleagues in other parts of the world.
190: i would truly like to get this "right", but i don't know what
191: that is, and i do not want to keep making changes until it's clear.
192:
193: Jul 4, 2003:
194: fixed bug that permitted non-terminated RE, as in "awk /x".
195:
196: Jun 1, 2003:
197: subtle change to split: if source is empty, number of elems
198: is always 0 and the array is not set.
199:
200: Mar 21, 2003:
201: added some parens to isblank, in another attempt to make things
202: internationally portable.
203:
204: Mar 14, 2003:
205: the internationalization changes, somewhat modified, are now
206: reinstated. in theory awk will now do character comparisons
207: and case conversions in national language, but "." will always
208: be the decimal point separator on input and output regardless
209: of national language. isblank(){} has an #ifndef.
210:
211: this no longer compiles on windows: LC_MESSAGES isn't defined
212: in vc6++.
213:
214: fixed subtle behavior in field and record splitting: if FS is
215: a single character and RS is not empty, \n is NOT a separator.
216: this tortuous reading is found in the awk book; behavior now
217: matches gawk and mawk.
1.11 millert 218:
219: Dec 13, 2002:
220: for the moment, the internationalization changes of nov 29 are
221: rolled back -- programs like x = 1.2 don't work in some locales,
222: because the parser is expecting x = 1,2. until i understand this
223: better, this will have to wait.
224:
225: Nov 29, 2002:
226: modified b.c (with tiny changes in main and run) to support
227: locales, using strcoll and iswhatever tests for posix character
228: classes. thanks to ruslan ermilov (ru@freebsd.org) for code.
229: the function isblank doesn't seem to have propagated to any
230: header file near me, so it's there explicitly. not properly
231: tested on non-ascii character sets by me.
232:
233: Jun 28, 2002:
234: modified run/format() and tran/getsval() to do a slightly better
235: job on using OFMT for output from print and CONVFMT for other
236: number->string conversions, as promised by posix and done by
237: gawk and mawk. there are still places where it doesn't work
238: right if CONVFMT is changed; by then the STR attribute of the
239: variable has been irrevocably set. thanks to arnold robbins for
240: code and examples.
241:
242: fixed subtle bug in format that could get core dump. thanks to
243: Jaromir Dolecek <jdolecek@NetBSD.org> for finding and fixing.
244: minor cleanup in run.c / format() at the same time.
245:
246: added some tests for null pointers to debugging printf's, which
247: were never intended for external consumption. thanks to dave
248: kerns (dkerns@lucent.com) for pointing this out.
249:
250: GNU compatibility: an empty regexp matches anything (thanks to
251: dag-erling smorgrav, des@ofug.org). subject to reversion if
252: this does more harm than good.
253:
254: pervasive small changes to make things more const-correct, as
255: reported by gcc's -Wwrite-strings. as it says in the gcc manual,
256: this may be more nuisance than useful. provoked by a suggestion
257: and code from arnaud desitter, arnaud@nimbus.geog.ox.ac.uk
258:
259: minor documentation changes to note that this now compiles out
260: of the box on Mac OS X.
261:
262: Feb 10, 2002:
263: changed types in posix chars structure to quiet solaris cc.
264:
265: Jan 1, 2002:
266: fflush() or fflush("") flushes all files and pipes.
267:
268: length(arrayname) returns number of elements; thanks to
269: arnold robbins for suggestion.
270:
271: added a makefile.win to make it easier to build on windows.
272: based on dan allen's buildwin.bat.
273:
274: Nov 16, 2001:
275: added support for posix character class names like [:digit:],
276: which are not exactly shorter than [0-9] and perhaps no more
277: portable. thanks to dag-erling smorgrav for code.
278:
279: Feb 16, 2001:
280: removed -m option; no longer needed, and it was actually
281: broken (noted thanks to volker kiefel).
282:
283: Feb 10, 2001:
284: fixed an appalling bug in gettok: any sequence of digits, +,-, E, e,
285: and period was accepted as a valid number if it started with a period.
286: this would never have happened with the lex version.
287:
288: other 1-character botches, now fixed, include a bare $ and a
289: bare " at the end of the input.
290:
291: Feb 7, 2001:
292: more (const char *) casts in b.c and tran.c to silence warnings.
1.8 millert 293:
1.10 millert 294: Nov 15, 2000:
295: fixed a bug introduced in august 1997 that caused expressions
296: like $f[1] to be syntax errors. thanks to arnold robbins for
297: noticing this and providing a fix.
298:
299: Oct 30, 2000:
300: fixed some nextfile bugs: not handling all cases. thanks to
301: arnold robbins for pointing this out. new regressions added.
302:
303: close() is now a function. it returns whatever the library
304: fclose returns, and -1 for closing a file or pipe that wasn't
305: opened.
306:
307: Sep 24, 2000:
308: permit \n explicitly in character classes; won't work right
309: if comes in as "[\n]" but ok as /[\n]/, because of multiple
310: processing of \'s. thanks to arnold robbins.
311:
312: July 5, 2000:
313: minor fiddles in tran.c to keep compilers happy about uschar.
314: thanks to norman wilson.
315:
316: May 25, 2000:
317: yet another attempt at making 8-bit input work, with another
318: band-aid in b.c (member()), and some (uschar) casts to head
319: off potential errors in subscripts (like isdigit). also
320: changed HAT to NCHARS-2. thanks again to santiago vila.
321:
322: changed maketab.c to ignore apparently out of range definitions
323: instead of halting; new freeBSD generates one. thanks to
324: jon snader <jsnader@ix.netcom.com> for pointing out the problem.
325:
326: May 2, 2000:
327: fixed an 8-bit problem in b.c by making several char*'s into
328: unsigned char*'s. not clear i have them all yet. thanks to
329: Santiago Vila <sanvila@unex.es> for the bug report.
330:
331: Apr 21, 2000:
332: finally found and fixed a memory leak in function call; it's
333: been there since functions were added ~1983. thanks to
334: jon bentley for the test case that found it.
335:
336: added test in envinit to catch environment "variables" with
1.12 otto 337: names beginning with '='; thanks to Berend Hasselman.
1.10 millert 338:
339: Jul 28, 1999:
340: added test in defn() to catch function foo(foo), which
341: otherwise recurses until core dump. thanks to arnold
342: robbins for noticing this.
343:
1.9 millert 344: Jun 20, 1999:
345: added *bp in gettok in lex.c; appears possible to exit function
346: without terminating the string. thanks to russ cox.
347:
348: Jun 2, 1999:
349: added function stdinit() to run to initialize files[] array,
350: in case stdin, etc., are not constants; some compilers care.
351:
352: May 10, 1999:
353: replaced the ERROR ... FATAL, etc., macros with functions
354: based on vprintf, to avoid problems caused by overrunning
355: fixed-size errbuf array. thanks to ralph corderoy for the
356: impetus, and for pointing out a string termination bug in
357: qstring as well.
358:
359: Apr 21, 1999:
360: fixed bug that caused occasional core dumps with commandline
361: variable with value ending in \. (thanks to nelson beebe for
362: the test case.)
363:
1.8 millert 364: Apr 16, 1999:
365: with code kindly provided by Bruce Lilly, awk now parses
366: /=/ and similar constructs more sensibly in more places.
1.10 millert 367: Bruce also provided some helpful test cases.
1.8 millert 368:
369: Apr 5, 1999:
370: changed true/false to True/False in run.c to make it
371: easier to compile with C++. Added some casts on malloc
372: and realloc to be honest about casts; ditto. changed
373: ltype int to long in struct rrow to reduce some 64-bit
374: complaints; other changes scattered throughout for the
375: same purpose. thanks to Nelson Beebe for these portability
376: improvements.
377:
378: removed some horrible pointer-int casting in b.c and elsewhere
379: by adding ptoi and itonp to localize the casts, which are
380: all benign. fixed one incipient bug that showed up on sgi
381: in 64-bit mode.
382:
383: reset lineno for new source file; include filename in error
384: message. also fixed line number error in continuation lines.
385: (thanks to Nelson Beebe for both of these.)
386:
387: Mar 24, 1999:
388: Nelson Beebe notes that irix 5.3 yacc dies with a bogus
389: error; use a newer version or switch to bison, since sgi
390: is unlikely to fix it.
1.1 tholo 391:
1.7 millert 392: Mar 5, 1999:
1.9 millert 393: changed isnumber to is_number to avoid the problem caused by
394: versions of ctype.h that include the name isnumber.
1.7 millert 395:
396: distribution now includes a script for building on a Mac,
397: thanks to Dan Allen.
398:
399: Feb 20, 1999:
400: fixed memory leaks in run.c (call) and tran.c (setfval).
401: thanks to Stephen Nutt for finding these and providing the fixes.
402:
403: Jan 13, 1999:
404: replaced srand argument by (unsigned int) in run.c;
405: avoids problem on Mac and potentially on Unix & Windows.
406: thanks to Dan Allen.
407:
408: added a few (int) casts to silence useless compiler warnings.
409: e.g., errorflag= in run.c jump().
410:
411: added proctab.c to the bundle outout; one less thing
412: to have to compile out of the box.
413:
414: added calls to _popen and _pclose to the win95 stub for
415: pipes (thanks to Steve Adams for this helpful suggestion).
416: seems to work, though properties are not well understood
417: by me, and it appears that under some circumstances the
418: pipe output is truncated. Be careful.
419:
420: Oct 19, 1998:
421: fixed a couple of bugs in getrec: could fail to update $0
422: after a getline var; because inputFS wasn't initialized,
423: could split $0 on every character, a misleading diversion.
424:
425: fixed caching bug in makedfa: LRU was actually removing
426: least often used.
427:
428: thanks to ross ridge for finding these, and for providing
429: great bug reports.
430:
431: May 12, 1998:
432: fixed potential bug in readrec: might fail to update record
433: pointer after growing. thanks to dan levy for spotting this
434: and suggesting the fix.
435:
436: Mar 12, 1998:
437: added -V to print version number and die.
438:
439: Feb 11, 1998:
440: subtle silent bug in lex.c: if the program ended with a number
441: longer than 1 digit, part of the input would be pushed back and
442: parsed again because token buffer wasn't terminated right.
443: example: awk 'length($0) > 10'. blush. at least i found it
444: myself.
445:
446: Aug 31, 1997:
447: s/adelete/awkdelete/: SGI uses this in malloc.h.
448: thanks to nelson beebe for pointing this one out.
449:
450: Aug 21, 1997:
451: fixed some bugs in sub and gsub when replacement includes \\.
452: this is a dark, horrible corner, but at least now i believe that
453: the behavior is the same as gawk and the intended posix standard.
454: thanks to arnold robbins for advice here.
455:
456: Aug 9, 1997:
457: somewhat regretfully, replaced the ancient lex-based lexical
458: analyzer with one written in C. it's longer, generates less code,
459: and more portable; the old one depended too much on mysterious
460: properties of lex that were not preserved in other environments.
461: in theory these recognize the same language.
462:
463: now using strtod to test whether a string is a number, instead of
464: the convoluted original function. should be more portable and
465: reliable if strtod is implemented right.
466:
467: removed now-pointless optimization in makefile that tries to avoid
468: recompilation when awkgram.y is changed but symbols are not.
469:
470: removed most fixed-size arrays, though a handful remain, some
471: of which are unchecked. you have been warned.
472:
473: Aug 4, 1997:
474: with some trepidation, replaced the ancient code that managed
475: fields and $0 in fixed-size arrays with arrays that grow on
476: demand. there is still some tension between trying to make this
477: run fast and making it clean; not sure it's right yet.
478:
479: the ill-conceived -mr and -mf arguments are now useful only
480: for debugging. previous dynamic string code removed.
481:
482: numerous other minor cleanups along the way.
1.1 tholo 483:
1.7 millert 484: Jul 30, 1997:
485: using code provided by dan levy (to whom profuse thanks), replaced
486: fixed-size arrays and awkward kludges by a fairly uniform mechanism
487: to grow arrays as needed for printf, sub, gsub, etc.
1.1 tholo 488:
1.7 millert 489: Jul 23, 1997:
490: falling off the end of a function returns "" and 0, not 0.
491: thanks to arnold robbins.
1.1 tholo 492:
1.7 millert 493: Jun 17, 1997:
494: replaced several fixed-size arrays by dynamically-created ones
495: in run.c; added overflow tests to some previously unchecked cases.
496: getline, toupper, tolower.
1.1 tholo 497:
1.7 millert 498: getline code is still broken in that recursive calls may wind
499: up using the same space. [fixed later]
1.1 tholo 500:
1.7 millert 501: increased RECSIZE to 8192 to push problems further over the horizon.
1.1 tholo 502:
1.7 millert 503: added \r to \n as input line separator for programs, not data.
504: damn CRLFs.
1.1 tholo 505:
1.7 millert 506: modified format() to permit explicit printf("%c", 0) to include
507: a null byte in output. thanks to ken stailey for the fix.
1.1 tholo 508:
1.7 millert 509: added a "-safe" argument that disables file output (print >,
510: print >>), process creation (cmd|getline, print |, system), and
511: access to the environment (ENVIRON). this is a first approximation
512: to a "safe" version of awk, but don't rely on it too much. thanks
513: to joan feigenbaum and matt blaze for the inspiration long ago.
1.1 tholo 514:
1.7 millert 515: Jul 8, 1996:
516: fixed long-standing bug in sub, gsub(/a/, "\\\\&"); thanks to
517: ralph corderoy.
1.1 tholo 518:
1.7 millert 519: Jun 29, 1996:
520: fixed awful bug in new field splitting; didn't get all the places
521: where input was done.
1.1 tholo 522:
1.7 millert 523: Jun 28, 1996:
524: changed field-splitting to conform to posix definition: fields are
525: split using the value of FS at the time of input; it used to be
526: the value when the field or NF was first referred to, a much less
527: predictable definition. thanks to arnold robbins for encouragement
528: to do the right thing.
1.1 tholo 529:
1.7 millert 530: May 28, 1996:
531: fixed appalling but apparently unimportant bug in parsing octal
532: numbers in reg exprs.
1.1 tholo 533:
1.7 millert 534: explicit hex in reg exprs now limited to 2 chars: \xa, \xaa.
1.1 tholo 535:
1.7 millert 536: May 27, 1996:
537: cleaned up some declarations so gcc -Wall is now almost silent.
1.1 tholo 538:
1.7 millert 539: makefile now includes backup copies of ytab.c and lexyy.c in case
540: one makes before looking; it also avoids recreating lexyy.c unless
541: really needed.
1.1 tholo 542:
1.7 millert 543: s/aprintf/awkprint, s/asprintf/awksprintf/ to avoid some name clashes
544: with unwisely-written header files.
1.1 tholo 545:
1.7 millert 546: thanks to jeffrey friedl for several of these.
1.1 tholo 547:
1.7 millert 548: May 26, 1996:
549: an attempt to rationalize the (unsigned) char issue. almost all
550: instances of unsigned char have been removed; the handful of places
551: in b.c where chars are used as table indices have been hand-crafted.
552: added some latin-1 tests to the regression, but i'm not confident;
553: none of my compilers seem to care much. thanks to nelson beebe for
554: pointing out some others that do care.
1.1 tholo 555:
1.7 millert 556: May 2, 1996:
557: removed all register declarations.
1.1 tholo 558:
1.7 millert 559: enhanced split(), as in gawk, etc: split(s, a, "") splits s into
560: a[1]...a[length(s)] with each character a single element.
1.1 tholo 561:
1.7 millert 562: made the same changes for field-splitting if FS is "".
1.1 tholo 563:
1.7 millert 564: added nextfile, as in gawk: causes immediate advance to next
565: input file. (thanks to arnold robbins for inspiration and code).
1.1 tholo 566:
1.7 millert 567: small fixes to regexpr code: can now handle []], [[], and
568: variants; [] is now a syntax error, rather than matching
569: everything; [z-a] is now empty, not z. far from complete
570: or correct, however. (thanks to jeffrey friedl for pointing out
571: some awful behaviors.)
1.1 tholo 572:
1.7 millert 573: Apr 29, 1996:
1.12 otto 574: replaced uchar by uschar everywhere; apparently some compilers
1.7 millert 575: usurp this name and this causes conflicts.
1.1 tholo 576:
1.7 millert 577: fixed call to time in run.c (bltin); arg is time_t *.
1.1 tholo 578:
1.7 millert 579: replaced horrible pointer/long punning in b.c by a legitimate
580: union. should be safer on 64-bit machines and cleaner everywhere.
581: (thanks to nelson beebe for pointing out some of these problems.)
1.1 tholo 582:
1.7 millert 583: replaced nested comments by #if 0...#endif in run.c, lib.c.
1.1 tholo 584:
1.7 millert 585: removed getsval, setsval, execute macros from run.c and lib.c.
586: machines are 100x faster than they were when these macros were
587: first used.
1.1 tholo 588:
1.7 millert 589: revised filenames: awk.g.y => awkgram.y, awk.lx.l => awklex.l,
590: y.tab.[ch] => ytab.[ch], lex.yy.c => lexyy.c, all in the aid of
591: portability to nameless systems.
1.1 tholo 592:
1.7 millert 593: "make bundle" now includes yacc and lex output files for recipients
594: who don't have yacc or lex.
1.1 tholo 595:
1.7 millert 596: Aug 15, 1995:
597: initialized Cells in setsymtab more carefully; some fields
598: were not set. (thanks to purify, all of whose complaints i
599: think i now understand.)
1.1 tholo 600:
1.7 millert 601: fixed at least one error in gsub that looked at -1-th element
602: of an array when substituting for a null match (e.g., $).
1.1 tholo 603:
1.7 millert 604: delete arrayname is now legal; it clears the elements but leaves
605: the array, which may not be the right behavior.
1.1 tholo 606:
1.7 millert 607: modified makefile: my current make can't cope with the test used
608: to avoid unnecessary yacc invocations.
1.1 tholo 609:
1.7 millert 610: Jul 17, 1995:
611: added dynamically growing strings to awk.lx.l and b.c
612: to permit regular expressions to be much bigger.
613: the state arrays can still overflow.
1.1 tholo 614:
1.7 millert 615: Aug 24, 1994:
616: detect duplicate arguments in function definitions (mdm).
1.1 tholo 617:
1.7 millert 618: May 11, 1994:
619: trivial fix to printf to limit string size in sub().
1.1 tholo 620:
1.7 millert 621: Apr 22, 1994:
622: fixed yet another subtle self-assignment problem:
623: $1 = $2; $1 = $1 clobbered $1.
1.1 tholo 624:
1.7 millert 625: Regression tests now use private echo, to avoid quoting problems.
1.1 tholo 626:
1.7 millert 627: Feb 2, 1994:
628: changed error() to print line number as %d, not %g.
1.1 tholo 629:
1.7 millert 630: Jul 23, 1993:
631: cosmetic changes: increased sizes of some arrays,
632: reworded some error messages.
1.1 tholo 633:
1.7 millert 634: added CONVFMT as in posix (just replaced OFMT in getsval)
1.1 tholo 635:
1.7 millert 636: FILENAME is now "" until the first thing that causes a file
637: to be opened.
1.1 tholo 638:
1.7 millert 639: Nov 28, 1992:
640: deleted yyunput and yyoutput from proto.h;
641: different versions of lex give these different declarations.
1.1 tholo 642:
1.7 millert 643: May 31, 1992:
644: added -mr N and -mf N options: more record and fields.
645: these really ought to adjust automatically.
1.1 tholo 646:
1.7 millert 647: cleaned up some error messages; "out of space" now means
648: malloc returned NULL in all cases.
1.1 tholo 649:
1.7 millert 650: changed rehash so that if it runs out, it just returns;
651: things will continue to run slow, but maybe a bit longer.
1.1 tholo 652:
1.7 millert 653: Apr 24, 1992:
654: remove redundant close of stdin when using -f -.
1.1 tholo 655:
1.7 millert 656: got rid of core dump with -d; awk -d just prints date.
1.1 tholo 657:
1.7 millert 658: Apr 12, 1992:
659: added explicit check for /dev/std(in,out,err) in redirection.
660: unlike gawk, no /dev/fd/n yet.
1.1 tholo 661:
1.7 millert 662: added (file/pipe) builtin. hard to test satisfactorily.
663: not posix.
1.1 tholo 664:
1.7 millert 665: Feb 20, 1992:
666: recompile after abortive changes; should be unchanged.
1.1 tholo 667:
1.7 millert 668: Dec 2, 1991:
669: die-casting time: converted to ansi C, installed that.
1.1 tholo 670:
1.7 millert 671: Nov 30, 1991:
672: fixed storage leak in freefa, failing to recover [N]CCL.
673: thanks to Bill Jones (jones@cs.usask.ca)
1.1 tholo 674:
1.7 millert 675: Nov 19, 1991:
676: use RAND_MAX instead of literal in builtin().
1.1 tholo 677:
1.7 millert 678: Nov 12, 1991:
679: cranked up some fixed-size arrays in b.c, and added a test for
680: overflow in penter. thanks to mark larsen.
1.1 tholo 681:
1.7 millert 682: Sep 24, 1991:
683: increased buffer in gsub. a very crude fix to a general problem.
684: and again on Sep 26.
1.1 tholo 685:
1.7 millert 686: Aug 18, 1991:
687: enforce variable name syntax for commandline variables: has to
688: start with letter or _.
1.1 tholo 689:
1.7 millert 690: Jul 27, 1991:
691: allow newline after ; in for statements.
1.1 tholo 692:
1.7 millert 693: Jul 21, 1991:
694: fixed so that in self-assignment like $1=$1, side effects
695: like recomputing $0 take place. (this is getting subtle.)
1.1 tholo 696:
1.7 millert 697: Jun 30, 1991:
698: better test for detecting too-long output record.
1.1 tholo 699:
1.7 millert 700: Jun 2, 1991:
701: better defense against very long printf strings.
702: made break and continue illegal outside of loops.
1.1 tholo 703:
1.7 millert 704: May 13, 1991:
705: removed extra arg on gettemp, tempfree. minor error message rewording.
1.1 tholo 706:
707: May 6, 1991:
708: fixed silly bug in hex parsing in hexstr().
709: removed an apparently unnecessary test in isnumber().
710: warn about weird printf conversions.
711: fixed unchecked array overwrite in relex().
712:
713: changed for (i in array) to access elements in sorted order.
714: then unchanged it -- it really does run slower in too many cases.
715: left the code in place, commented out.
716:
1.7 millert 717: Feb 10, 1991:
718: check error status on all writes, to avoid banging on full disks.
1.1 tholo 719:
1.7 millert 720: Jan 28, 1991:
721: awk -f - reads the program from stdin.
1.1 tholo 722:
1.7 millert 723: Jan 11, 1991:
724: failed to set numeric state on $0 in cmd|getline context in run.c.
1.1 tholo 725:
1.7 millert 726: Nov 2, 1990:
727: fixed sleazy test for integrality in getsval; use modf.
1.1 tholo 728:
1.7 millert 729: Oct 29, 1990:
730: fixed sleazy buggy code in lib.c that looked (incorrectly) for
731: too long input lines.
1.1 tholo 732:
1.7 millert 733: Oct 14, 1990:
734: fixed the bug on p. 198 in which it couldn't deduce that an
735: argument was an array in some contexts. replaced the error
736: message in intest() by code that damn well makes it an array.
1.1 tholo 737:
1.7 millert 738: Oct 8, 1990:
739: fixed horrible bug: types and values were not preserved in
740: some kinds of self-assignment. (in assign().)
1.1 tholo 741:
1.7 millert 742: Aug 24, 1990:
743: changed NCHARS to 256 to handle 8-bit characters in strings
744: presented to match(), etc.
1.1 tholo 745:
1.7 millert 746: Jun 26, 1990:
747: changed struct rrow (awk.h) to use long instead of int for lval,
748: since cfoll() stores a pointer in it. now works better when int's
749: are smaller than pointers!
1.1 tholo 750:
1.7 millert 751: May 6, 1990:
752: AVA fixed the grammar so that ! is uniformly of the same precedence as
753: unary + and -. This renders illegal some constructs like !x=y, which
754: now has to be parenthesized as !(x=y), and makes others work properly:
755: !x+y is (!x)+y, and x!y is x !y, not two pattern-action statements.
756: (These problems were pointed out by Bob Lenk of Posix.)
1.1 tholo 757:
1.7 millert 758: Added \x to regular expressions (already in strings).
759: Limited octal to octal digits; \8 and \9 are not octal.
760: Centralized the code for parsing escapes in regular expressions.
761: Added a bunch of tests to T.re and T.sub to verify some of this.
1.1 tholo 762:
1.7 millert 763: Feb 9, 1990:
764: fixed null pointer dereference bug in main.c: -F[nothing]. sigh.
1.1 tholo 765:
1.7 millert 766: restored srand behavior: it returns the current seed.
1.1 tholo 767:
1.7 millert 768: Jan 18, 1990:
769: srand now returns previous seed value (0 to start).
1.1 tholo 770:
1.7 millert 771: Jan 5, 1990:
772: fix potential problem in tran.c -- something was freed,
773: then used in freesymtab.
1.1 tholo 774:
1.7 millert 775: Oct 18, 1989:
776: another try to get the max number of open files set with
777: relatively machine-independent code.
1.1 tholo 778:
1.7 millert 779: small fix to input() in case of multiple reads after EOF.
1.1 tholo 780:
1.7 millert 781: Oct 11, 1989:
782: FILENAME is now defined in the BEGIN block -- too many old
783: programs broke.
1.1 tholo 784:
1.7 millert 785: "-" means stdin in getline as well as on the commandline.
1.1 tholo 786:
1.7 millert 787: added a bunch of casts to the code to tell the truth about
788: char * vs. unsigned char *, a right royal pain. added a
789: setlocale call to the front of main, though probably no one
790: has it usefully implemented yet.
1.1 tholo 791:
1.7 millert 792: Aug 24, 1989:
793: removed redundant relational tests against nullnode if parse
794: tree already had a relational at that point.
1.1 tholo 795:
1.7 millert 796: Aug 11, 1989:
797: fixed bug: commandline variable assignment has to look like
798: var=something. (consider the man page for =, in file =.1)
1.1 tholo 799:
1.7 millert 800: changed number of arguments to functions to static arrays
801: to avoid repeated malloc calls.
1.1 tholo 802:
1.7 millert 803: Aug 2, 1989:
804: restored -F (space) separator
1.1 tholo 805:
1.7 millert 806: Jul 30, 1989:
807: added -v x=1 y=2 ... for immediate commandline variable assignment;
808: done before the BEGIN block for sure. they have to precede the
809: program if the program is on the commandline.
810: Modified Aug 2 to require a separate -v for each assignment.
1.1 tholo 811:
1.7 millert 812: Jul 10, 1989:
813: fixed ref-thru-zero bug in environment code in tran.c
1.1 tholo 814:
1.7 millert 815: Jun 23, 1989:
816: add newline to usage message.
1.1 tholo 817:
1.7 millert 818: Jun 14, 1989:
819: added some missing ansi printf conversion letters: %i %X %E %G.
820: no sensible meaning for h or L, so they may not do what one expects.
1.1 tholo 821:
1.7 millert 822: made %* conversions work.
1.1 tholo 823:
1.7 millert 824: changed x^y so that if n is a positive integer, it's done
825: by explicit multiplication, thus achieving maximum accuracy.
826: (this should be done by pow() but it seems not to be locally.)
827: done to x ^= y as well.
1.1 tholo 828:
1.7 millert 829: Jun 4, 1989:
830: ENVIRON array contains environment: if shell variable V=thing,
831: ENVIRON["V"] is "thing"
1.1 tholo 832:
1.7 millert 833: multiple -f arguments permitted. error reporting is naive.
834: (they were permitted before, but only the last was used.)
1.1 tholo 835:
1.7 millert 836: fixed a really stupid botch in the debugging macro dprintf
1.1 tholo 837:
1.7 millert 838: fixed order of evaluation of commandline assignments to match
839: what the book claims: an argument of the form x=e is evaluated
840: at the time it would have been opened if it were a filename (p 63).
841: this invalidates the suggested answer to ex 4-1 (p 195).
1.1 tholo 842:
1.7 millert 843: removed some code that permitted -F (space) fieldseparator,
844: since it didn't quite work right anyway. (restored aug 2)
1.1 tholo 845:
1.7 millert 846: Apr 27, 1989:
847: Line number now accumulated correctly for comment lines.
1.1 tholo 848:
1.7 millert 849: Apr 26, 1989:
850: Debugging output now includes a version date,
851: if one compiles it into the source each time.
1.1 tholo 852:
1.7 millert 853: Apr 9, 1989:
854: Changed grammar to prohibit constants as 3rd arg of sub and gsub;
855: prevents class of overwriting-a-constant errors. (Last one?)
856: This invalidates the "banana" example on page 43 of the book.
1.1 tholo 857:
1.7 millert 858: Added \a ("alert"), \v (vertical tab), \xhhh (hexadecimal),
859: as in ANSI, for strings. Rescinded the sloppiness that permitted
860: non-octal digits in \ooo. Warning: not all compilers and libraries
861: will be able to deal with \x correctly.
1.1 tholo 862:
1.7 millert 863: Jan 9, 1989:
864: Fixed bug that caused tempcell list to contain a duplicate.
865: The fix is kludgy.
1.1 tholo 866:
1.7 millert 867: Dec 17, 1988:
868: Catches some more commandline errors in main.
869: Removed redundant decl of modf in run.c (confuses some compilers).
870: Warning: there's no single declaration of malloc, etc., in awk.h
871: that seems to satisfy all compilers.
1.1 tholo 872:
1.7 millert 873: Dec 7, 1988:
874: Added a bit of code to error printing to avoid printing nulls.
875: (Not clear that it actually would.)
1.1 tholo 876:
1.7 millert 877: Nov 27, 1988:
878: With fear and trembling, modified the grammar to permit
879: multiple pattern-action statements on one line without
880: an explicit separator. By definition, this capitulation
881: to the ghost of ancient implementations remains undefined
882: and thus subject to change without notice or apology.
883: DO NOT COUNT ON IT.
1.1 tholo 884:
1.7 millert 885: Oct 30, 1988:
886: Fixed bug in call() that failed to recover storage.
1.1 tholo 887:
1.7 millert 888: A warning is now generated if there are more arguments
889: in the call than in the definition (in lieu of fixing
890: another storage leak).
1.2 millert 891:
1.7 millert 892: Oct 20, 1988:
893: Fixed %c: if expr is numeric, use numeric value;
894: otherwise print 1st char of string value. still
895: doesn't work if the value is 0 -- won't print \0.
1.2 millert 896:
1.7 millert 897: Added a few more checks for running out of malloc.
1.2 millert 898:
1.7 millert 899: Oct 12, 1988:
900: Fixed bug in call() that freed local arrays twice.
1.5 kstailey 901:
1.7 millert 902: Fixed to handle deletion of non-existent array right;
903: complains about attempt to delete non-array element.
1.6 kstailey 904:
1.7 millert 905: Sep 30, 1988:
906: Now guarantees to evaluate all arguments of built-in
907: functions, as in C; the appearance is that arguments
908: are evaluated before the function is called. Places
909: affected are sub (gsub was ok), substr, printf, and
910: all the built-in arithmetic functions in bltin().
911: A warning is generated if a bltin() is called with
912: the wrong number of arguments.
1.6 kstailey 913:
1.7 millert 914: This requires changing makeprof on p167 of the book.
1.6 kstailey 915:
1.7 millert 916: Aug 23, 1988:
917: setting FILENAME in BEGIN caused core dump, apparently
918: because it was freeing space not allocated by malloc.
1.6 kstailey 919:
1.7 millert 920: July 24, 1988:
921: fixed egregious error in toupper/tolower functions.
922: still subject to rescinding, however.
1.6 kstailey 923:
1.7 millert 924: July 2, 1988:
925: flush stdout before opening file or pipe
1.6 kstailey 926:
1.7 millert 927: July 2, 1988:
928: performance bug in b.c/cgoto(): not freeing some sets of states.
929: partial fix only right now, and the number of states increased
930: to make it less obvious.
1.6 kstailey 931:
1.7 millert 932: June 1, 1988:
933: check error status on close
1.6 kstailey 934:
1.7 millert 935: May 28, 1988:
936: srand returns seed value it's using.
937: see 1/18/90
1.6 kstailey 938:
1.7 millert 939: May 22, 1988:
940: Removed limit on depth of function calls.
1.6 kstailey 941:
1.7 millert 942: May 10, 1988:
943: Fixed lib.c to permit _ in commandline variable names.
1.6 kstailey 944:
1.7 millert 945: Mar 25, 1988:
946: main.c fixed to recognize -- as terminator of command-
947: line options. Illegal options flagged.
948: Error reporting slightly cleaned up.
1.6 kstailey 949:
1.7 millert 950: Dec 2, 1987:
951: Newer C compilers apply a strict scope rule to extern
952: declarations within functions. Two extern declarations in
953: lib.c and tran.c have been moved to obviate this problem.
1.6 kstailey 954:
1.7 millert 955: Oct xx, 1987:
956: Reluctantly added toupper and tolower functions.
957: Subject to rescinding without notice.
1.6 kstailey 958:
1.7 millert 959: Sep 17, 1987:
960: Error-message printer had printf(s) instead of
961: printf("%s",s); got core dumps when the message
962: included a %.
1.6 kstailey 963:
1.7 millert 964: Sep 12, 1987:
965: Very long printf strings caused core dump;
966: fixed aprintf, asprintf, format to catch them.
967: Can still get a core dump in printf itself.
1.6 kstailey 968:
969:
![[BACK]](/icons/back.gif){kind=icon}
Return to FIXES CVS log ![[TXT]](/icons/text.gif){kind=icon}
![[DIR]](/icons/dir.gif){kind=icon}
Up to [local] / src / usr.bin / awk