Annotation of src/usr.bin/awk/FIXES, Revision 1.16
1.16 ! millert 1: /* $OpenBSD: FIXES,v 1.15 2010/06/13 17:58:19 millert Exp $ */
1.1 tholo 2: /****************************************************************
1.6 kstailey 3: Copyright (C) Lucent Technologies 1997
1.1 tholo 4: All Rights Reserved
5:
6: Permission to use, copy, modify, and distribute this software and
7: its documentation for any purpose and without fee is hereby
8: granted, provided that the above copyright notice appear in all
9: copies and that both that the copyright notice and this
10: permission notice and warranty disclaimer appear in supporting
1.6 kstailey 11: documentation, and that the name Lucent Technologies or any of
12: its entities not be used in advertising or publicity pertaining
13: to distribution of the software without specific, written prior
14: permission.
15:
16: LUCENT DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE,
17: INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS.
18: IN NO EVENT SHALL LUCENT OR ANY OF ITS ENTITIES BE LIABLE FOR ANY
19: SPECIAL, INDIRECT OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
20: WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER
21: IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION,
22: ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF
23: THIS SOFTWARE.
1.1 tholo 24: ****************************************************************/
25:
26: This file lists all bug fixes, changes, etc., made since the AWK book
27: was sent to the printers in August, 1987.
1.16 ! millert 28:
! 29: Aug 10, 2011:
! 30: another fix to avoid core dump with delete(ARGV); again, many thanks
! 31: to ruslan ermilov.
! 32:
! 33: Aug 7, 2011:
! 34: split(s, a, //) now behaves the same as split(s, a, "")
! 35:
! 36: Jun 12, 2011:
! 37: /pat/, \n /pat/ {...} is now legal, though bad style to use.
! 38:
! 39: added checks to new -v code that permits -vnospace; thanks to
! 40: ruslan ermilov for spotting this and providing the patch.
! 41:
! 42: removed fixed limit on number of open files; thanks to aleksey
! 43: cheusov and christos zoulos.
! 44:
! 45: fixed day 1 bug that resurrected deleted elements of ARGV when
! 46: used as filenames (in lib.c).
! 47:
! 48: minor type fiddles to make gcc -Wall -pedantic happier (but not
! 49: totally so); turned on -fno-strict-aliasing in makefile.
! 50:
! 51: May 6, 2011:
! 52: added #ifdef for isblank.
! 53: now allows -ffoo as well as -f foo arguments.
! 54: (thanks, ruslan)
! 55:
! 56: May 1, 2011:
! 57: after advice from todd miller, kevin lo, ruslan ermilov,
! 58: and arnold robbins, changed srand() to return the previous
! 59: seed (which is 1 on the first call of srand). the seed is
! 60: an Awkfloat internally though converted to unsigned int to
! 61: pass to the library srand(). thanks, everyone.
! 62:
! 63: fixed a subtle (and i hope low-probability) overflow error
! 64: in fldbld, by adding space for one extra \0. thanks to
! 65: robert bassett for spotting this one and providing a fix.
! 66:
! 67: removed the files related to compilation on windows. i no
! 68: longer have anything like a current windows environment, so
! 69: i can't test any of it.
1.15 millert 70:
71: May 23, 2010:
72: fixed long-standing overflow bug in run.c; many thanks to
73: nelson beebe for spotting it and providing the fix.
74:
75: fixed bug that didn't parse -vd=1 properly; thanks to santiago
76: vila for spotting it.
77:
78: Feb 8, 2010:
79: i give up. replaced isblank with isspace in b.c; there are
80: no consistent header files.
81:
82: Nov 26, 2009:
83: fixed a long-standing issue with when FS takes effect. a
84: change to FS is now noticed immediately for subsequent splits.
85:
86: changed the name getline() to awkgetline() to avoid yet another
87: name conflict somewhere.
88:
89: Feb 11, 2009:
90: temporarily for now defined HAS_ISBLANK, since that seems to
91: be the best way through the thicket. isblank arrived in C99,
92: but seems to be arriving at different systems at different
93: times.
94:
95: Oct 8, 2008:
96: fixed typo in b.c that set tmpvec wrongly. no one had ever
97: run into the problem, apparently. thanks to alistair crooks.
1.14 millert 98:
99: Oct 23, 2007:
100: minor fix in lib.c: increase inputFS to 100, change malloc
101: for fields to n+1.
102:
103: fixed memory fault caused by out of order test in setsval.
104:
105: thanks to david o'brien, freebsd, for both fixes.
106:
107: May 1, 2007:
108: fiddle in makefile to fix for BSD make; thanks to igor sobrado.
109:
110: Mar 31, 2007:
111: fixed some null pointer refs calling adjbuf.
112:
113: Feb 21, 2007:
114: fixed a bug in matching the null RE in sub and gsub. thanks to al aho
115: who actually did the fix (in b.c), and to wolfgang seeberg for finding
116: it and providing a very compact test case.
117:
118: fixed quotation in b.c; thanks to Hal Pratt and the Princeton Dante
119: Project.
120:
121: removed some no-effect asserts in run.c.
122:
123: fiddled maketab.c to not complain about bison-generated values.
124:
125: removed the obsolete -V argument; fixed --version to print the
126: version and exit.
127:
128: fixed wording and an outright error in the usage message; thanks to igor
129: sobrado and jason mcintyre.
130:
131: fixed a bug in -d that caused core dump if no program followed.
132:
133: Jan 1, 2007:
134: dropped mac.code from makefile; there are few non-MacOSX
135: mac's these days.
136:
137: Jan 17, 2006:
138: system() not flagged as unsafe in the unadvertised -safe option.
139: found it while enhancing tests before shipping the ;login: article.
140: practice what you preach.
141:
142: removed the 9-years-obsolete -mr and -mf flags.
143:
144: added -version and --version options.
145:
146: core dump on linux with BEGIN {nextfile}, now fixed.
147:
148: removed some #ifdef's in run.c and lex.c that appear to no
149: longer be necessary.
150:
151: Apr 24, 2005:
152: modified lib.c so that values of $0 et al are preserved in the END
153: block, apparently as required by posix. thanks to havard eidnes
154: for the report and code.
155:
156: Jan 14, 2005:
157: fixed infinite loop in parsing, originally found by brian tsang.
158: thanks to arnold robbins for a suggestion that started me
159: rethinking it.
160:
161: Dec 31, 2004:
162: prevent overflow of -f array in main, head off potential error in
163: call of SYNTAX(), test malloc return in lib.c, all with thanks to
164: todd miller.
1.13 millert 165:
166: Dec 22, 2004:
167: cranked up size of NCHARS; coverity thinks it can be overrun with
168: smaller size, and i think that's right. added some assertions to b.c
169: to catch places where it might overrun. the RE code is still fragile.
170:
171: Dec 5, 2004:
172: fixed a couple of overflow problems with ridiculous field numbers:
173: e.g., print $(2^32-1). thanks to ruslan ermilov, giorgos keramidas
174: and david o'brien at freebsd.org for patches. this really should
175: be re-done from scratch.
176:
177: Nov 21, 2004:
178: fixed another 25-year-old RE bug, in split. it's another failure
179: to (re-)initialize. thanks to steve fisher for spotting this and
180: providing a good test case.
181:
182: Nov 22, 2003:
183: fixed a bug in regular expressions that dates (so help me) from 1977;
184: it's been there from the beginning. an anchored longest match that
185: was longer than the number of states triggered a failure to initialize
186: the machine properly. many thanks to moinak ghosh for not only finding
187: this one but for providing a fix, in some of the most mysterious
188: code known to man.
189:
190: fixed a storage leak in call() that appears to have been there since
191: 1983 or so -- a function without an explicit return that assigns a
192: string to a parameter leaked a Cell. thanks to moinak ghosh for
193: spotting this very subtle one.
194:
195: Jul 31, 2003:
196: fixed, thanks to andrey chernov and ruslan ermilov, a bug in lex.c
197: that mis-handled the character 255 in input. (it was being compared
198: to EOF with a signed comparison.)
199:
200: Jul 29, 2003:
201: fixed (i think) the long-standing botch that included the beginning of
202: line state ^ for RE's in the set of valid characters; this led to a
203: variety of odd problems, including failure to properly match certain
204: regular expressions in non-US locales. thanks to ruslan for keeping
205: at this one.
206:
207: Jul 28, 2003:
208: n-th try at getting internationalization right, with thanks to volker
209: kiefel, arnold robbins and ruslan ermilov for advice, though they
210: should not be blamed for the outcome. according to posix, "." is the
211: radix character in programs and command line arguments regardless of
212: the locale; otherwise, the locale should prevail for input and output
213: of numbers. so it's intended to work that way.
214:
215: i have rescinded the attempt to use strcoll in expanding shorthands in
216: regular expressions (cclenter). its properties are much too
217: surprising; for example [a-c] matches aAbBc in locale en_US but abBcC
218: in locale fr_CA. i can see how this might arise by implementation
219: but i cannot explain it to a human user. (this behavior can be seen
220: in gawk as well; we're leaning on the same library.)
221:
222: the issue appears to be that strcoll is meant for sorting, where
223: merging upper and lower case may make sense (though note that unix
224: sort does not do this by default either). it is not appropriate
225: for regular expressions, where the goal is to match specific
226: patterns of characters. in any case, the notations [:lower:], etc.,
227: are available in awk, and they are more likely to work correctly in
228: most locales.
229:
230: a moratorium is hereby declared on internationalization changes.
231: i apologize to friends and colleagues in other parts of the world.
232: i would truly like to get this "right", but i don't know what
233: that is, and i do not want to keep making changes until it's clear.
234:
235: Jul 4, 2003:
236: fixed bug that permitted non-terminated RE, as in "awk /x".
237:
238: Jun 1, 2003:
239: subtle change to split: if source is empty, number of elems
240: is always 0 and the array is not set.
241:
242: Mar 21, 2003:
243: added some parens to isblank, in another attempt to make things
244: internationally portable.
245:
246: Mar 14, 2003:
247: the internationalization changes, somewhat modified, are now
248: reinstated. in theory awk will now do character comparisons
249: and case conversions in national language, but "." will always
250: be the decimal point separator on input and output regardless
251: of national language. isblank(){} has an #ifndef.
252:
253: this no longer compiles on windows: LC_MESSAGES isn't defined
254: in vc6++.
255:
256: fixed subtle behavior in field and record splitting: if FS is
257: a single character and RS is not empty, \n is NOT a separator.
258: this tortuous reading is found in the awk book; behavior now
259: matches gawk and mawk.
1.11 millert 260:
261: Dec 13, 2002:
262: for the moment, the internationalization changes of nov 29 are
263: rolled back -- programs like x = 1.2 don't work in some locales,
264: because the parser is expecting x = 1,2. until i understand this
265: better, this will have to wait.
266:
267: Nov 29, 2002:
268: modified b.c (with tiny changes in main and run) to support
269: locales, using strcoll and iswhatever tests for posix character
270: classes. thanks to ruslan ermilov (ru@freebsd.org) for code.
271: the function isblank doesn't seem to have propagated to any
272: header file near me, so it's there explicitly. not properly
273: tested on non-ascii character sets by me.
274:
275: Jun 28, 2002:
276: modified run/format() and tran/getsval() to do a slightly better
277: job on using OFMT for output from print and CONVFMT for other
278: number->string conversions, as promised by posix and done by
279: gawk and mawk. there are still places where it doesn't work
280: right if CONVFMT is changed; by then the STR attribute of the
281: variable has been irrevocably set. thanks to arnold robbins for
282: code and examples.
283:
284: fixed subtle bug in format that could get core dump. thanks to
285: Jaromir Dolecek <jdolecek@NetBSD.org> for finding and fixing.
286: minor cleanup in run.c / format() at the same time.
287:
288: added some tests for null pointers to debugging printf's, which
289: were never intended for external consumption. thanks to dave
290: kerns (dkerns@lucent.com) for pointing this out.
291:
292: GNU compatibility: an empty regexp matches anything (thanks to
293: dag-erling smorgrav, des@ofug.org). subject to reversion if
294: this does more harm than good.
295:
296: pervasive small changes to make things more const-correct, as
297: reported by gcc's -Wwrite-strings. as it says in the gcc manual,
298: this may be more nuisance than useful. provoked by a suggestion
299: and code from arnaud desitter, arnaud@nimbus.geog.ox.ac.uk
300:
301: minor documentation changes to note that this now compiles out
302: of the box on Mac OS X.
303:
304: Feb 10, 2002:
305: changed types in posix chars structure to quiet solaris cc.
306:
307: Jan 1, 2002:
308: fflush() or fflush("") flushes all files and pipes.
309:
310: length(arrayname) returns number of elements; thanks to
311: arnold robbins for suggestion.
312:
313: added a makefile.win to make it easier to build on windows.
314: based on dan allen's buildwin.bat.
315:
316: Nov 16, 2001:
317: added support for posix character class names like [:digit:],
318: which are not exactly shorter than [0-9] and perhaps no more
319: portable. thanks to dag-erling smorgrav for code.
320:
321: Feb 16, 2001:
322: removed -m option; no longer needed, and it was actually
323: broken (noted thanks to volker kiefel).
324:
325: Feb 10, 2001:
326: fixed an appalling bug in gettok: any sequence of digits, +,-, E, e,
327: and period was accepted as a valid number if it started with a period.
328: this would never have happened with the lex version.
329:
330: other 1-character botches, now fixed, include a bare $ and a
331: bare " at the end of the input.
332:
333: Feb 7, 2001:
334: more (const char *) casts in b.c and tran.c to silence warnings.
1.8 millert 335:
1.10 millert 336: Nov 15, 2000:
337: fixed a bug introduced in august 1997 that caused expressions
338: like $f[1] to be syntax errors. thanks to arnold robbins for
339: noticing this and providing a fix.
340:
341: Oct 30, 2000:
342: fixed some nextfile bugs: not handling all cases. thanks to
343: arnold robbins for pointing this out. new regressions added.
344:
345: close() is now a function. it returns whatever the library
346: fclose returns, and -1 for closing a file or pipe that wasn't
347: opened.
348:
349: Sep 24, 2000:
350: permit \n explicitly in character classes; won't work right
351: if comes in as "[\n]" but ok as /[\n]/, because of multiple
352: processing of \'s. thanks to arnold robbins.
353:
354: July 5, 2000:
355: minor fiddles in tran.c to keep compilers happy about uschar.
356: thanks to norman wilson.
357:
358: May 25, 2000:
359: yet another attempt at making 8-bit input work, with another
360: band-aid in b.c (member()), and some (uschar) casts to head
361: off potential errors in subscripts (like isdigit). also
362: changed HAT to NCHARS-2. thanks again to santiago vila.
363:
364: changed maketab.c to ignore apparently out of range definitions
365: instead of halting; new freeBSD generates one. thanks to
366: jon snader <jsnader@ix.netcom.com> for pointing out the problem.
367:
368: May 2, 2000:
369: fixed an 8-bit problem in b.c by making several char*'s into
370: unsigned char*'s. not clear i have them all yet. thanks to
371: Santiago Vila <sanvila@unex.es> for the bug report.
372:
373: Apr 21, 2000:
374: finally found and fixed a memory leak in function call; it's
375: been there since functions were added ~1983. thanks to
376: jon bentley for the test case that found it.
377:
378: added test in envinit to catch environment "variables" with
1.12 otto 379: names beginning with '='; thanks to Berend Hasselman.
1.10 millert 380:
381: Jul 28, 1999:
382: added test in defn() to catch function foo(foo), which
383: otherwise recurses until core dump. thanks to arnold
384: robbins for noticing this.
385:
1.9 millert 386: Jun 20, 1999:
387: added *bp in gettok in lex.c; appears possible to exit function
388: without terminating the string. thanks to russ cox.
389:
390: Jun 2, 1999:
391: added function stdinit() to run to initialize files[] array,
392: in case stdin, etc., are not constants; some compilers care.
393:
394: May 10, 1999:
395: replaced the ERROR ... FATAL, etc., macros with functions
396: based on vprintf, to avoid problems caused by overrunning
397: fixed-size errbuf array. thanks to ralph corderoy for the
398: impetus, and for pointing out a string termination bug in
399: qstring as well.
400:
401: Apr 21, 1999:
402: fixed bug that caused occasional core dumps with commandline
403: variable with value ending in \. (thanks to nelson beebe for
404: the test case.)
405:
1.8 millert 406: Apr 16, 1999:
407: with code kindly provided by Bruce Lilly, awk now parses
408: /=/ and similar constructs more sensibly in more places.
1.10 millert 409: Bruce also provided some helpful test cases.
1.8 millert 410:
411: Apr 5, 1999:
412: changed true/false to True/False in run.c to make it
413: easier to compile with C++. Added some casts on malloc
414: and realloc to be honest about casts; ditto. changed
415: ltype int to long in struct rrow to reduce some 64-bit
416: complaints; other changes scattered throughout for the
417: same purpose. thanks to Nelson Beebe for these portability
418: improvements.
419:
420: removed some horrible pointer-int casting in b.c and elsewhere
421: by adding ptoi and itonp to localize the casts, which are
422: all benign. fixed one incipient bug that showed up on sgi
423: in 64-bit mode.
424:
425: reset lineno for new source file; include filename in error
426: message. also fixed line number error in continuation lines.
427: (thanks to Nelson Beebe for both of these.)
428:
429: Mar 24, 1999:
430: Nelson Beebe notes that irix 5.3 yacc dies with a bogus
431: error; use a newer version or switch to bison, since sgi
432: is unlikely to fix it.
1.1 tholo 433:
1.7 millert 434: Mar 5, 1999:
1.9 millert 435: changed isnumber to is_number to avoid the problem caused by
436: versions of ctype.h that include the name isnumber.
1.7 millert 437:
438: distribution now includes a script for building on a Mac,
439: thanks to Dan Allen.
440:
441: Feb 20, 1999:
442: fixed memory leaks in run.c (call) and tran.c (setfval).
443: thanks to Stephen Nutt for finding these and providing the fixes.
444:
445: Jan 13, 1999:
446: replaced srand argument by (unsigned int) in run.c;
447: avoids problem on Mac and potentially on Unix & Windows.
448: thanks to Dan Allen.
449:
450: added a few (int) casts to silence useless compiler warnings.
451: e.g., errorflag= in run.c jump().
452:
453: added proctab.c to the bundle outout; one less thing
454: to have to compile out of the box.
455:
456: added calls to _popen and _pclose to the win95 stub for
457: pipes (thanks to Steve Adams for this helpful suggestion).
458: seems to work, though properties are not well understood
459: by me, and it appears that under some circumstances the
460: pipe output is truncated. Be careful.
461:
462: Oct 19, 1998:
463: fixed a couple of bugs in getrec: could fail to update $0
464: after a getline var; because inputFS wasn't initialized,
465: could split $0 on every character, a misleading diversion.
466:
467: fixed caching bug in makedfa: LRU was actually removing
468: least often used.
469:
470: thanks to ross ridge for finding these, and for providing
471: great bug reports.
472:
473: May 12, 1998:
474: fixed potential bug in readrec: might fail to update record
475: pointer after growing. thanks to dan levy for spotting this
476: and suggesting the fix.
477:
478: Mar 12, 1998:
479: added -V to print version number and die.
480:
481: Feb 11, 1998:
482: subtle silent bug in lex.c: if the program ended with a number
483: longer than 1 digit, part of the input would be pushed back and
484: parsed again because token buffer wasn't terminated right.
485: example: awk 'length($0) > 10'. blush. at least i found it
486: myself.
487:
488: Aug 31, 1997:
489: s/adelete/awkdelete/: SGI uses this in malloc.h.
490: thanks to nelson beebe for pointing this one out.
491:
492: Aug 21, 1997:
493: fixed some bugs in sub and gsub when replacement includes \\.
494: this is a dark, horrible corner, but at least now i believe that
495: the behavior is the same as gawk and the intended posix standard.
496: thanks to arnold robbins for advice here.
497:
498: Aug 9, 1997:
499: somewhat regretfully, replaced the ancient lex-based lexical
500: analyzer with one written in C. it's longer, generates less code,
501: and more portable; the old one depended too much on mysterious
502: properties of lex that were not preserved in other environments.
503: in theory these recognize the same language.
504:
505: now using strtod to test whether a string is a number, instead of
506: the convoluted original function. should be more portable and
507: reliable if strtod is implemented right.
508:
509: removed now-pointless optimization in makefile that tries to avoid
510: recompilation when awkgram.y is changed but symbols are not.
511:
512: removed most fixed-size arrays, though a handful remain, some
513: of which are unchecked. you have been warned.
514:
515: Aug 4, 1997:
516: with some trepidation, replaced the ancient code that managed
517: fields and $0 in fixed-size arrays with arrays that grow on
518: demand. there is still some tension between trying to make this
519: run fast and making it clean; not sure it's right yet.
520:
521: the ill-conceived -mr and -mf arguments are now useful only
522: for debugging. previous dynamic string code removed.
523:
524: numerous other minor cleanups along the way.
1.1 tholo 525:
1.7 millert 526: Jul 30, 1997:
527: using code provided by dan levy (to whom profuse thanks), replaced
528: fixed-size arrays and awkward kludges by a fairly uniform mechanism
529: to grow arrays as needed for printf, sub, gsub, etc.
1.1 tholo 530:
1.7 millert 531: Jul 23, 1997:
532: falling off the end of a function returns "" and 0, not 0.
533: thanks to arnold robbins.
1.1 tholo 534:
1.7 millert 535: Jun 17, 1997:
536: replaced several fixed-size arrays by dynamically-created ones
537: in run.c; added overflow tests to some previously unchecked cases.
538: getline, toupper, tolower.
1.1 tholo 539:
1.7 millert 540: getline code is still broken in that recursive calls may wind
541: up using the same space. [fixed later]
1.1 tholo 542:
1.7 millert 543: increased RECSIZE to 8192 to push problems further over the horizon.
1.1 tholo 544:
1.7 millert 545: added \r to \n as input line separator for programs, not data.
546: damn CRLFs.
1.1 tholo 547:
1.7 millert 548: modified format() to permit explicit printf("%c", 0) to include
549: a null byte in output. thanks to ken stailey for the fix.
1.1 tholo 550:
1.7 millert 551: added a "-safe" argument that disables file output (print >,
552: print >>), process creation (cmd|getline, print |, system), and
553: access to the environment (ENVIRON). this is a first approximation
554: to a "safe" version of awk, but don't rely on it too much. thanks
555: to joan feigenbaum and matt blaze for the inspiration long ago.
1.1 tholo 556:
1.7 millert 557: Jul 8, 1996:
558: fixed long-standing bug in sub, gsub(/a/, "\\\\&"); thanks to
559: ralph corderoy.
1.1 tholo 560:
1.7 millert 561: Jun 29, 1996:
562: fixed awful bug in new field splitting; didn't get all the places
563: where input was done.
1.1 tholo 564:
1.7 millert 565: Jun 28, 1996:
566: changed field-splitting to conform to posix definition: fields are
567: split using the value of FS at the time of input; it used to be
568: the value when the field or NF was first referred to, a much less
569: predictable definition. thanks to arnold robbins for encouragement
570: to do the right thing.
1.1 tholo 571:
1.7 millert 572: May 28, 1996:
573: fixed appalling but apparently unimportant bug in parsing octal
574: numbers in reg exprs.
1.1 tholo 575:
1.7 millert 576: explicit hex in reg exprs now limited to 2 chars: \xa, \xaa.
1.1 tholo 577:
1.7 millert 578: May 27, 1996:
579: cleaned up some declarations so gcc -Wall is now almost silent.
1.1 tholo 580:
1.7 millert 581: makefile now includes backup copies of ytab.c and lexyy.c in case
582: one makes before looking; it also avoids recreating lexyy.c unless
583: really needed.
1.1 tholo 584:
1.7 millert 585: s/aprintf/awkprint, s/asprintf/awksprintf/ to avoid some name clashes
586: with unwisely-written header files.
1.1 tholo 587:
1.7 millert 588: thanks to jeffrey friedl for several of these.
1.1 tholo 589:
1.7 millert 590: May 26, 1996:
591: an attempt to rationalize the (unsigned) char issue. almost all
592: instances of unsigned char have been removed; the handful of places
593: in b.c where chars are used as table indices have been hand-crafted.
594: added some latin-1 tests to the regression, but i'm not confident;
595: none of my compilers seem to care much. thanks to nelson beebe for
596: pointing out some others that do care.
1.1 tholo 597:
1.7 millert 598: May 2, 1996:
599: removed all register declarations.
1.1 tholo 600:
1.7 millert 601: enhanced split(), as in gawk, etc: split(s, a, "") splits s into
602: a[1]...a[length(s)] with each character a single element.
1.1 tholo 603:
1.7 millert 604: made the same changes for field-splitting if FS is "".
1.1 tholo 605:
1.7 millert 606: added nextfile, as in gawk: causes immediate advance to next
607: input file. (thanks to arnold robbins for inspiration and code).
1.1 tholo 608:
1.7 millert 609: small fixes to regexpr code: can now handle []], [[], and
610: variants; [] is now a syntax error, rather than matching
611: everything; [z-a] is now empty, not z. far from complete
612: or correct, however. (thanks to jeffrey friedl for pointing out
613: some awful behaviors.)
1.1 tholo 614:
1.7 millert 615: Apr 29, 1996:
1.12 otto 616: replaced uchar by uschar everywhere; apparently some compilers
1.7 millert 617: usurp this name and this causes conflicts.
1.1 tholo 618:
1.7 millert 619: fixed call to time in run.c (bltin); arg is time_t *.
1.1 tholo 620:
1.7 millert 621: replaced horrible pointer/long punning in b.c by a legitimate
622: union. should be safer on 64-bit machines and cleaner everywhere.
623: (thanks to nelson beebe for pointing out some of these problems.)
1.1 tholo 624:
1.7 millert 625: replaced nested comments by #if 0...#endif in run.c, lib.c.
1.1 tholo 626:
1.7 millert 627: removed getsval, setsval, execute macros from run.c and lib.c.
628: machines are 100x faster than they were when these macros were
629: first used.
1.1 tholo 630:
1.7 millert 631: revised filenames: awk.g.y => awkgram.y, awk.lx.l => awklex.l,
632: y.tab.[ch] => ytab.[ch], lex.yy.c => lexyy.c, all in the aid of
633: portability to nameless systems.
1.1 tholo 634:
1.7 millert 635: "make bundle" now includes yacc and lex output files for recipients
636: who don't have yacc or lex.
1.1 tholo 637:
1.7 millert 638: Aug 15, 1995:
639: initialized Cells in setsymtab more carefully; some fields
640: were not set. (thanks to purify, all of whose complaints i
641: think i now understand.)
1.1 tholo 642:
1.7 millert 643: fixed at least one error in gsub that looked at -1-th element
644: of an array when substituting for a null match (e.g., $).
1.1 tholo 645:
1.7 millert 646: delete arrayname is now legal; it clears the elements but leaves
647: the array, which may not be the right behavior.
1.1 tholo 648:
1.7 millert 649: modified makefile: my current make can't cope with the test used
650: to avoid unnecessary yacc invocations.
1.1 tholo 651:
1.7 millert 652: Jul 17, 1995:
653: added dynamically growing strings to awk.lx.l and b.c
654: to permit regular expressions to be much bigger.
655: the state arrays can still overflow.
1.1 tholo 656:
1.7 millert 657: Aug 24, 1994:
658: detect duplicate arguments in function definitions (mdm).
1.1 tholo 659:
1.7 millert 660: May 11, 1994:
661: trivial fix to printf to limit string size in sub().
1.1 tholo 662:
1.7 millert 663: Apr 22, 1994:
664: fixed yet another subtle self-assignment problem:
665: $1 = $2; $1 = $1 clobbered $1.
1.1 tholo 666:
1.7 millert 667: Regression tests now use private echo, to avoid quoting problems.
1.1 tholo 668:
1.7 millert 669: Feb 2, 1994:
670: changed error() to print line number as %d, not %g.
1.1 tholo 671:
1.7 millert 672: Jul 23, 1993:
673: cosmetic changes: increased sizes of some arrays,
674: reworded some error messages.
1.1 tholo 675:
1.7 millert 676: added CONVFMT as in posix (just replaced OFMT in getsval)
1.1 tholo 677:
1.7 millert 678: FILENAME is now "" until the first thing that causes a file
679: to be opened.
1.1 tholo 680:
1.7 millert 681: Nov 28, 1992:
682: deleted yyunput and yyoutput from proto.h;
683: different versions of lex give these different declarations.
1.1 tholo 684:
1.7 millert 685: May 31, 1992:
686: added -mr N and -mf N options: more record and fields.
687: these really ought to adjust automatically.
1.1 tholo 688:
1.7 millert 689: cleaned up some error messages; "out of space" now means
690: malloc returned NULL in all cases.
1.1 tholo 691:
1.7 millert 692: changed rehash so that if it runs out, it just returns;
693: things will continue to run slow, but maybe a bit longer.
1.1 tholo 694:
1.7 millert 695: Apr 24, 1992:
696: remove redundant close of stdin when using -f -.
1.1 tholo 697:
1.7 millert 698: got rid of core dump with -d; awk -d just prints date.
1.1 tholo 699:
1.7 millert 700: Apr 12, 1992:
701: added explicit check for /dev/std(in,out,err) in redirection.
702: unlike gawk, no /dev/fd/n yet.
1.1 tholo 703:
1.7 millert 704: added (file/pipe) builtin. hard to test satisfactorily.
705: not posix.
1.1 tholo 706:
1.7 millert 707: Feb 20, 1992:
708: recompile after abortive changes; should be unchanged.
1.1 tholo 709:
1.7 millert 710: Dec 2, 1991:
711: die-casting time: converted to ansi C, installed that.
1.1 tholo 712:
1.7 millert 713: Nov 30, 1991:
714: fixed storage leak in freefa, failing to recover [N]CCL.
715: thanks to Bill Jones (jones@cs.usask.ca)
1.1 tholo 716:
1.7 millert 717: Nov 19, 1991:
718: use RAND_MAX instead of literal in builtin().
1.1 tholo 719:
1.7 millert 720: Nov 12, 1991:
721: cranked up some fixed-size arrays in b.c, and added a test for
722: overflow in penter. thanks to mark larsen.
1.1 tholo 723:
1.7 millert 724: Sep 24, 1991:
725: increased buffer in gsub. a very crude fix to a general problem.
726: and again on Sep 26.
1.1 tholo 727:
1.7 millert 728: Aug 18, 1991:
729: enforce variable name syntax for commandline variables: has to
730: start with letter or _.
1.1 tholo 731:
1.7 millert 732: Jul 27, 1991:
733: allow newline after ; in for statements.
1.1 tholo 734:
1.7 millert 735: Jul 21, 1991:
736: fixed so that in self-assignment like $1=$1, side effects
737: like recomputing $0 take place. (this is getting subtle.)
1.1 tholo 738:
1.7 millert 739: Jun 30, 1991:
740: better test for detecting too-long output record.
1.1 tholo 741:
1.7 millert 742: Jun 2, 1991:
743: better defense against very long printf strings.
744: made break and continue illegal outside of loops.
1.1 tholo 745:
1.7 millert 746: May 13, 1991:
747: removed extra arg on gettemp, tempfree. minor error message rewording.
1.1 tholo 748:
749: May 6, 1991:
750: fixed silly bug in hex parsing in hexstr().
751: removed an apparently unnecessary test in isnumber().
752: warn about weird printf conversions.
753: fixed unchecked array overwrite in relex().
754:
755: changed for (i in array) to access elements in sorted order.
756: then unchanged it -- it really does run slower in too many cases.
757: left the code in place, commented out.
758:
1.7 millert 759: Feb 10, 1991:
760: check error status on all writes, to avoid banging on full disks.
1.1 tholo 761:
1.7 millert 762: Jan 28, 1991:
763: awk -f - reads the program from stdin.
1.1 tholo 764:
1.7 millert 765: Jan 11, 1991:
766: failed to set numeric state on $0 in cmd|getline context in run.c.
1.1 tholo 767:
1.7 millert 768: Nov 2, 1990:
769: fixed sleazy test for integrality in getsval; use modf.
1.1 tholo 770:
1.7 millert 771: Oct 29, 1990:
772: fixed sleazy buggy code in lib.c that looked (incorrectly) for
773: too long input lines.
1.1 tholo 774:
1.7 millert 775: Oct 14, 1990:
776: fixed the bug on p. 198 in which it couldn't deduce that an
777: argument was an array in some contexts. replaced the error
778: message in intest() by code that damn well makes it an array.
1.1 tholo 779:
1.7 millert 780: Oct 8, 1990:
781: fixed horrible bug: types and values were not preserved in
782: some kinds of self-assignment. (in assign().)
1.1 tholo 783:
1.7 millert 784: Aug 24, 1990:
785: changed NCHARS to 256 to handle 8-bit characters in strings
786: presented to match(), etc.
1.1 tholo 787:
1.7 millert 788: Jun 26, 1990:
789: changed struct rrow (awk.h) to use long instead of int for lval,
790: since cfoll() stores a pointer in it. now works better when int's
791: are smaller than pointers!
1.1 tholo 792:
1.7 millert 793: May 6, 1990:
794: AVA fixed the grammar so that ! is uniformly of the same precedence as
795: unary + and -. This renders illegal some constructs like !x=y, which
796: now has to be parenthesized as !(x=y), and makes others work properly:
797: !x+y is (!x)+y, and x!y is x !y, not two pattern-action statements.
798: (These problems were pointed out by Bob Lenk of Posix.)
1.1 tholo 799:
1.7 millert 800: Added \x to regular expressions (already in strings).
801: Limited octal to octal digits; \8 and \9 are not octal.
802: Centralized the code for parsing escapes in regular expressions.
803: Added a bunch of tests to T.re and T.sub to verify some of this.
1.1 tholo 804:
1.7 millert 805: Feb 9, 1990:
806: fixed null pointer dereference bug in main.c: -F[nothing]. sigh.
1.1 tholo 807:
1.7 millert 808: restored srand behavior: it returns the current seed.
1.1 tholo 809:
1.7 millert 810: Jan 18, 1990:
811: srand now returns previous seed value (0 to start).
1.1 tholo 812:
1.7 millert 813: Jan 5, 1990:
814: fix potential problem in tran.c -- something was freed,
815: then used in freesymtab.
1.1 tholo 816:
1.7 millert 817: Oct 18, 1989:
818: another try to get the max number of open files set with
819: relatively machine-independent code.
1.1 tholo 820:
1.7 millert 821: small fix to input() in case of multiple reads after EOF.
1.1 tholo 822:
1.7 millert 823: Oct 11, 1989:
824: FILENAME is now defined in the BEGIN block -- too many old
825: programs broke.
1.1 tholo 826:
1.7 millert 827: "-" means stdin in getline as well as on the commandline.
1.1 tholo 828:
1.7 millert 829: added a bunch of casts to the code to tell the truth about
830: char * vs. unsigned char *, a right royal pain. added a
831: setlocale call to the front of main, though probably no one
832: has it usefully implemented yet.
1.1 tholo 833:
1.7 millert 834: Aug 24, 1989:
835: removed redundant relational tests against nullnode if parse
836: tree already had a relational at that point.
1.1 tholo 837:
1.7 millert 838: Aug 11, 1989:
839: fixed bug: commandline variable assignment has to look like
840: var=something. (consider the man page for =, in file =.1)
1.1 tholo 841:
1.7 millert 842: changed number of arguments to functions to static arrays
843: to avoid repeated malloc calls.
1.1 tholo 844:
1.7 millert 845: Aug 2, 1989:
846: restored -F (space) separator
1.1 tholo 847:
1.7 millert 848: Jul 30, 1989:
849: added -v x=1 y=2 ... for immediate commandline variable assignment;
850: done before the BEGIN block for sure. they have to precede the
851: program if the program is on the commandline.
852: Modified Aug 2 to require a separate -v for each assignment.
1.1 tholo 853:
1.7 millert 854: Jul 10, 1989:
855: fixed ref-thru-zero bug in environment code in tran.c
1.1 tholo 856:
1.7 millert 857: Jun 23, 1989:
858: add newline to usage message.
1.1 tholo 859:
1.7 millert 860: Jun 14, 1989:
861: added some missing ansi printf conversion letters: %i %X %E %G.
862: no sensible meaning for h or L, so they may not do what one expects.
1.1 tholo 863:
1.7 millert 864: made %* conversions work.
1.1 tholo 865:
1.7 millert 866: changed x^y so that if n is a positive integer, it's done
867: by explicit multiplication, thus achieving maximum accuracy.
868: (this should be done by pow() but it seems not to be locally.)
869: done to x ^= y as well.
1.1 tholo 870:
1.7 millert 871: Jun 4, 1989:
872: ENVIRON array contains environment: if shell variable V=thing,
873: ENVIRON["V"] is "thing"
1.1 tholo 874:
1.7 millert 875: multiple -f arguments permitted. error reporting is naive.
876: (they were permitted before, but only the last was used.)
1.1 tholo 877:
1.7 millert 878: fixed a really stupid botch in the debugging macro dprintf
1.1 tholo 879:
1.7 millert 880: fixed order of evaluation of commandline assignments to match
881: what the book claims: an argument of the form x=e is evaluated
882: at the time it would have been opened if it were a filename (p 63).
883: this invalidates the suggested answer to ex 4-1 (p 195).
1.1 tholo 884:
1.7 millert 885: removed some code that permitted -F (space) fieldseparator,
886: since it didn't quite work right anyway. (restored aug 2)
1.1 tholo 887:
1.7 millert 888: Apr 27, 1989:
889: Line number now accumulated correctly for comment lines.
1.1 tholo 890:
1.7 millert 891: Apr 26, 1989:
892: Debugging output now includes a version date,
893: if one compiles it into the source each time.
1.1 tholo 894:
1.7 millert 895: Apr 9, 1989:
896: Changed grammar to prohibit constants as 3rd arg of sub and gsub;
897: prevents class of overwriting-a-constant errors. (Last one?)
898: This invalidates the "banana" example on page 43 of the book.
1.1 tholo 899:
1.7 millert 900: Added \a ("alert"), \v (vertical tab), \xhhh (hexadecimal),
901: as in ANSI, for strings. Rescinded the sloppiness that permitted
902: non-octal digits in \ooo. Warning: not all compilers and libraries
903: will be able to deal with \x correctly.
1.1 tholo 904:
1.7 millert 905: Jan 9, 1989:
906: Fixed bug that caused tempcell list to contain a duplicate.
907: The fix is kludgy.
1.1 tholo 908:
1.7 millert 909: Dec 17, 1988:
910: Catches some more commandline errors in main.
911: Removed redundant decl of modf in run.c (confuses some compilers).
912: Warning: there's no single declaration of malloc, etc., in awk.h
913: that seems to satisfy all compilers.
1.1 tholo 914:
1.7 millert 915: Dec 7, 1988:
916: Added a bit of code to error printing to avoid printing nulls.
917: (Not clear that it actually would.)
1.1 tholo 918:
1.7 millert 919: Nov 27, 1988:
920: With fear and trembling, modified the grammar to permit
921: multiple pattern-action statements on one line without
922: an explicit separator. By definition, this capitulation
923: to the ghost of ancient implementations remains undefined
924: and thus subject to change without notice or apology.
925: DO NOT COUNT ON IT.
1.1 tholo 926:
1.7 millert 927: Oct 30, 1988:
928: Fixed bug in call() that failed to recover storage.
1.1 tholo 929:
1.7 millert 930: A warning is now generated if there are more arguments
931: in the call than in the definition (in lieu of fixing
932: another storage leak).
1.2 millert 933:
1.7 millert 934: Oct 20, 1988:
935: Fixed %c: if expr is numeric, use numeric value;
936: otherwise print 1st char of string value. still
937: doesn't work if the value is 0 -- won't print \0.
1.2 millert 938:
1.7 millert 939: Added a few more checks for running out of malloc.
1.2 millert 940:
1.7 millert 941: Oct 12, 1988:
942: Fixed bug in call() that freed local arrays twice.
1.5 kstailey 943:
1.7 millert 944: Fixed to handle deletion of non-existent array right;
945: complains about attempt to delete non-array element.
1.6 kstailey 946:
1.7 millert 947: Sep 30, 1988:
948: Now guarantees to evaluate all arguments of built-in
949: functions, as in C; the appearance is that arguments
950: are evaluated before the function is called. Places
951: affected are sub (gsub was ok), substr, printf, and
952: all the built-in arithmetic functions in bltin().
953: A warning is generated if a bltin() is called with
954: the wrong number of arguments.
1.6 kstailey 955:
1.7 millert 956: This requires changing makeprof on p167 of the book.
1.6 kstailey 957:
1.7 millert 958: Aug 23, 1988:
959: setting FILENAME in BEGIN caused core dump, apparently
960: because it was freeing space not allocated by malloc.
1.6 kstailey 961:
1.7 millert 962: July 24, 1988:
963: fixed egregious error in toupper/tolower functions.
964: still subject to rescinding, however.
1.6 kstailey 965:
1.7 millert 966: July 2, 1988:
967: flush stdout before opening file or pipe
1.6 kstailey 968:
1.7 millert 969: July 2, 1988:
970: performance bug in b.c/cgoto(): not freeing some sets of states.
971: partial fix only right now, and the number of states increased
972: to make it less obvious.
1.6 kstailey 973:
1.7 millert 974: June 1, 1988:
975: check error status on close
1.6 kstailey 976:
1.7 millert 977: May 28, 1988:
978: srand returns seed value it's using.
979: see 1/18/90
1.6 kstailey 980:
1.7 millert 981: May 22, 1988:
982: Removed limit on depth of function calls.
1.6 kstailey 983:
1.7 millert 984: May 10, 1988:
985: Fixed lib.c to permit _ in commandline variable names.
1.6 kstailey 986:
1.7 millert 987: Mar 25, 1988:
988: main.c fixed to recognize -- as terminator of command-
989: line options. Illegal options flagged.
990: Error reporting slightly cleaned up.
1.6 kstailey 991:
1.7 millert 992: Dec 2, 1987:
993: Newer C compilers apply a strict scope rule to extern
994: declarations within functions. Two extern declarations in
995: lib.c and tran.c have been moved to obviate this problem.
1.6 kstailey 996:
1.7 millert 997: Oct xx, 1987:
998: Reluctantly added toupper and tolower functions.
999: Subject to rescinding without notice.
1.6 kstailey 1000:
1.7 millert 1001: Sep 17, 1987:
1002: Error-message printer had printf(s) instead of
1003: printf("%s",s); got core dumps when the message
1004: included a %.
1.6 kstailey 1005:
1.7 millert 1006: Sep 12, 1987:
1007: Very long printf strings caused core dump;
1008: fixed aprintf, asprintf, format to catch them.
1009: Can still get a core dump in printf itself.
1.6 kstailey 1010:
1011:
![[BACK]](/icons/back.gif){kind=icon}
Return to FIXES CVS log ![[TXT]](/icons/text.gif){kind=icon}
![[DIR]](/icons/dir.gif){kind=icon}
Up to [local] / src / usr.bin / awk