Annotation of src/usr.bin/awk/FIXES, Revision 1.17
1.17 ! millert 1: /* $OpenBSD: FIXES,v 1.16 2011/09/28 19:27:18 millert Exp $ */
1.1 tholo 2: /****************************************************************
1.6 kstailey 3: Copyright (C) Lucent Technologies 1997
1.1 tholo 4: All Rights Reserved
5:
6: Permission to use, copy, modify, and distribute this software and
7: its documentation for any purpose and without fee is hereby
8: granted, provided that the above copyright notice appear in all
9: copies and that both that the copyright notice and this
10: permission notice and warranty disclaimer appear in supporting
1.6 kstailey 11: documentation, and that the name Lucent Technologies or any of
12: its entities not be used in advertising or publicity pertaining
13: to distribution of the software without specific, written prior
14: permission.
15:
16: LUCENT DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE,
17: INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS.
18: IN NO EVENT SHALL LUCENT OR ANY OF ITS ENTITIES BE LIABLE FOR ANY
19: SPECIAL, INDIRECT OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
20: WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER
21: IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION,
22: ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF
23: THIS SOFTWARE.
1.1 tholo 24: ****************************************************************/
25:
26: This file lists all bug fixes, changes, etc., made since the AWK book
27: was sent to the printers in August, 1987.
1.17 ! millert 28:
! 29: Dec 20, 2012:
! 30: fiddled makefile to get correct yacc and bison flags. pick yacc
! 31: (linux) or bison (mac) as necessary.
! 32:
! 33: added __attribute__((__noreturn__)) to a couple of lines in
! 34: proto.h, to silence someone's enthusiastic checker.
! 35:
! 36: fixed obscure call by value bug in split(a[1],a) reported on
! 37: 9fans. the management of temporary values is just a mess; i
! 38: took a shortcut by making an extra string copy. thanks
! 39: to paul patience and arnold robbins for passing it on and for
! 40: proposed patches.
! 41:
! 42: tiny fiddle in setfval to eliminate -0 results in T.expr, which
! 43: has irritated me for 20+ years.
1.16 millert 44:
45: Aug 10, 2011:
46: another fix to avoid core dump with delete(ARGV); again, many thanks
47: to ruslan ermilov.
48:
49: Aug 7, 2011:
50: split(s, a, //) now behaves the same as split(s, a, "")
51:
52: Jun 12, 2011:
53: /pat/, \n /pat/ {...} is now legal, though bad style to use.
54:
55: added checks to new -v code that permits -vnospace; thanks to
56: ruslan ermilov for spotting this and providing the patch.
57:
58: removed fixed limit on number of open files; thanks to aleksey
59: cheusov and christos zoulos.
60:
61: fixed day 1 bug that resurrected deleted elements of ARGV when
62: used as filenames (in lib.c).
63:
64: minor type fiddles to make gcc -Wall -pedantic happier (but not
65: totally so); turned on -fno-strict-aliasing in makefile.
66:
67: May 6, 2011:
68: added #ifdef for isblank.
69: now allows -ffoo as well as -f foo arguments.
70: (thanks, ruslan)
71:
72: May 1, 2011:
73: after advice from todd miller, kevin lo, ruslan ermilov,
74: and arnold robbins, changed srand() to return the previous
75: seed (which is 1 on the first call of srand). the seed is
76: an Awkfloat internally though converted to unsigned int to
77: pass to the library srand(). thanks, everyone.
78:
79: fixed a subtle (and i hope low-probability) overflow error
80: in fldbld, by adding space for one extra \0. thanks to
81: robert bassett for spotting this one and providing a fix.
82:
83: removed the files related to compilation on windows. i no
84: longer have anything like a current windows environment, so
85: i can't test any of it.
1.15 millert 86:
87: May 23, 2010:
88: fixed long-standing overflow bug in run.c; many thanks to
89: nelson beebe for spotting it and providing the fix.
90:
91: fixed bug that didn't parse -vd=1 properly; thanks to santiago
92: vila for spotting it.
93:
94: Feb 8, 2010:
95: i give up. replaced isblank with isspace in b.c; there are
96: no consistent header files.
97:
98: Nov 26, 2009:
99: fixed a long-standing issue with when FS takes effect. a
100: change to FS is now noticed immediately for subsequent splits.
101:
102: changed the name getline() to awkgetline() to avoid yet another
103: name conflict somewhere.
104:
105: Feb 11, 2009:
106: temporarily for now defined HAS_ISBLANK, since that seems to
107: be the best way through the thicket. isblank arrived in C99,
108: but seems to be arriving at different systems at different
109: times.
110:
111: Oct 8, 2008:
112: fixed typo in b.c that set tmpvec wrongly. no one had ever
113: run into the problem, apparently. thanks to alistair crooks.
1.14 millert 114:
115: Oct 23, 2007:
116: minor fix in lib.c: increase inputFS to 100, change malloc
117: for fields to n+1.
118:
119: fixed memory fault caused by out of order test in setsval.
120:
121: thanks to david o'brien, freebsd, for both fixes.
122:
123: May 1, 2007:
124: fiddle in makefile to fix for BSD make; thanks to igor sobrado.
125:
126: Mar 31, 2007:
127: fixed some null pointer refs calling adjbuf.
128:
129: Feb 21, 2007:
130: fixed a bug in matching the null RE in sub and gsub. thanks to al aho
131: who actually did the fix (in b.c), and to wolfgang seeberg for finding
132: it and providing a very compact test case.
133:
134: fixed quotation in b.c; thanks to Hal Pratt and the Princeton Dante
135: Project.
136:
137: removed some no-effect asserts in run.c.
138:
139: fiddled maketab.c to not complain about bison-generated values.
140:
141: removed the obsolete -V argument; fixed --version to print the
142: version and exit.
143:
144: fixed wording and an outright error in the usage message; thanks to igor
145: sobrado and jason mcintyre.
146:
147: fixed a bug in -d that caused core dump if no program followed.
148:
149: Jan 1, 2007:
150: dropped mac.code from makefile; there are few non-MacOSX
151: mac's these days.
152:
153: Jan 17, 2006:
154: system() not flagged as unsafe in the unadvertised -safe option.
155: found it while enhancing tests before shipping the ;login: article.
156: practice what you preach.
157:
158: removed the 9-years-obsolete -mr and -mf flags.
159:
160: added -version and --version options.
161:
162: core dump on linux with BEGIN {nextfile}, now fixed.
163:
164: removed some #ifdef's in run.c and lex.c that appear to no
165: longer be necessary.
166:
167: Apr 24, 2005:
168: modified lib.c so that values of $0 et al are preserved in the END
169: block, apparently as required by posix. thanks to havard eidnes
170: for the report and code.
171:
172: Jan 14, 2005:
173: fixed infinite loop in parsing, originally found by brian tsang.
174: thanks to arnold robbins for a suggestion that started me
175: rethinking it.
176:
177: Dec 31, 2004:
178: prevent overflow of -f array in main, head off potential error in
179: call of SYNTAX(), test malloc return in lib.c, all with thanks to
180: todd miller.
1.13 millert 181:
182: Dec 22, 2004:
183: cranked up size of NCHARS; coverity thinks it can be overrun with
184: smaller size, and i think that's right. added some assertions to b.c
185: to catch places where it might overrun. the RE code is still fragile.
186:
187: Dec 5, 2004:
188: fixed a couple of overflow problems with ridiculous field numbers:
189: e.g., print $(2^32-1). thanks to ruslan ermilov, giorgos keramidas
190: and david o'brien at freebsd.org for patches. this really should
191: be re-done from scratch.
192:
193: Nov 21, 2004:
194: fixed another 25-year-old RE bug, in split. it's another failure
195: to (re-)initialize. thanks to steve fisher for spotting this and
196: providing a good test case.
197:
198: Nov 22, 2003:
199: fixed a bug in regular expressions that dates (so help me) from 1977;
200: it's been there from the beginning. an anchored longest match that
201: was longer than the number of states triggered a failure to initialize
202: the machine properly. many thanks to moinak ghosh for not only finding
203: this one but for providing a fix, in some of the most mysterious
204: code known to man.
205:
206: fixed a storage leak in call() that appears to have been there since
207: 1983 or so -- a function without an explicit return that assigns a
208: string to a parameter leaked a Cell. thanks to moinak ghosh for
209: spotting this very subtle one.
210:
211: Jul 31, 2003:
212: fixed, thanks to andrey chernov and ruslan ermilov, a bug in lex.c
213: that mis-handled the character 255 in input. (it was being compared
214: to EOF with a signed comparison.)
215:
216: Jul 29, 2003:
217: fixed (i think) the long-standing botch that included the beginning of
218: line state ^ for RE's in the set of valid characters; this led to a
219: variety of odd problems, including failure to properly match certain
220: regular expressions in non-US locales. thanks to ruslan for keeping
221: at this one.
222:
223: Jul 28, 2003:
224: n-th try at getting internationalization right, with thanks to volker
225: kiefel, arnold robbins and ruslan ermilov for advice, though they
226: should not be blamed for the outcome. according to posix, "." is the
227: radix character in programs and command line arguments regardless of
228: the locale; otherwise, the locale should prevail for input and output
229: of numbers. so it's intended to work that way.
230:
231: i have rescinded the attempt to use strcoll in expanding shorthands in
232: regular expressions (cclenter). its properties are much too
233: surprising; for example [a-c] matches aAbBc in locale en_US but abBcC
234: in locale fr_CA. i can see how this might arise by implementation
235: but i cannot explain it to a human user. (this behavior can be seen
236: in gawk as well; we're leaning on the same library.)
237:
238: the issue appears to be that strcoll is meant for sorting, where
239: merging upper and lower case may make sense (though note that unix
240: sort does not do this by default either). it is not appropriate
241: for regular expressions, where the goal is to match specific
242: patterns of characters. in any case, the notations [:lower:], etc.,
243: are available in awk, and they are more likely to work correctly in
244: most locales.
245:
246: a moratorium is hereby declared on internationalization changes.
247: i apologize to friends and colleagues in other parts of the world.
248: i would truly like to get this "right", but i don't know what
249: that is, and i do not want to keep making changes until it's clear.
250:
251: Jul 4, 2003:
252: fixed bug that permitted non-terminated RE, as in "awk /x".
253:
254: Jun 1, 2003:
255: subtle change to split: if source is empty, number of elems
256: is always 0 and the array is not set.
257:
258: Mar 21, 2003:
259: added some parens to isblank, in another attempt to make things
260: internationally portable.
261:
262: Mar 14, 2003:
263: the internationalization changes, somewhat modified, are now
264: reinstated. in theory awk will now do character comparisons
265: and case conversions in national language, but "." will always
266: be the decimal point separator on input and output regardless
267: of national language. isblank(){} has an #ifndef.
268:
269: this no longer compiles on windows: LC_MESSAGES isn't defined
270: in vc6++.
271:
272: fixed subtle behavior in field and record splitting: if FS is
273: a single character and RS is not empty, \n is NOT a separator.
274: this tortuous reading is found in the awk book; behavior now
275: matches gawk and mawk.
1.11 millert 276:
277: Dec 13, 2002:
278: for the moment, the internationalization changes of nov 29 are
279: rolled back -- programs like x = 1.2 don't work in some locales,
280: because the parser is expecting x = 1,2. until i understand this
281: better, this will have to wait.
282:
283: Nov 29, 2002:
284: modified b.c (with tiny changes in main and run) to support
285: locales, using strcoll and iswhatever tests for posix character
286: classes. thanks to ruslan ermilov (ru@freebsd.org) for code.
287: the function isblank doesn't seem to have propagated to any
288: header file near me, so it's there explicitly. not properly
289: tested on non-ascii character sets by me.
290:
291: Jun 28, 2002:
292: modified run/format() and tran/getsval() to do a slightly better
293: job on using OFMT for output from print and CONVFMT for other
294: number->string conversions, as promised by posix and done by
295: gawk and mawk. there are still places where it doesn't work
296: right if CONVFMT is changed; by then the STR attribute of the
297: variable has been irrevocably set. thanks to arnold robbins for
298: code and examples.
299:
300: fixed subtle bug in format that could get core dump. thanks to
301: Jaromir Dolecek <jdolecek@NetBSD.org> for finding and fixing.
302: minor cleanup in run.c / format() at the same time.
303:
304: added some tests for null pointers to debugging printf's, which
305: were never intended for external consumption. thanks to dave
306: kerns (dkerns@lucent.com) for pointing this out.
307:
308: GNU compatibility: an empty regexp matches anything (thanks to
309: dag-erling smorgrav, des@ofug.org). subject to reversion if
310: this does more harm than good.
311:
312: pervasive small changes to make things more const-correct, as
313: reported by gcc's -Wwrite-strings. as it says in the gcc manual,
314: this may be more nuisance than useful. provoked by a suggestion
315: and code from arnaud desitter, arnaud@nimbus.geog.ox.ac.uk
316:
317: minor documentation changes to note that this now compiles out
318: of the box on Mac OS X.
319:
320: Feb 10, 2002:
321: changed types in posix chars structure to quiet solaris cc.
322:
323: Jan 1, 2002:
324: fflush() or fflush("") flushes all files and pipes.
325:
326: length(arrayname) returns number of elements; thanks to
327: arnold robbins for suggestion.
328:
329: added a makefile.win to make it easier to build on windows.
330: based on dan allen's buildwin.bat.
331:
332: Nov 16, 2001:
333: added support for posix character class names like [:digit:],
334: which are not exactly shorter than [0-9] and perhaps no more
335: portable. thanks to dag-erling smorgrav for code.
336:
337: Feb 16, 2001:
338: removed -m option; no longer needed, and it was actually
339: broken (noted thanks to volker kiefel).
340:
341: Feb 10, 2001:
342: fixed an appalling bug in gettok: any sequence of digits, +,-, E, e,
343: and period was accepted as a valid number if it started with a period.
344: this would never have happened with the lex version.
345:
346: other 1-character botches, now fixed, include a bare $ and a
347: bare " at the end of the input.
348:
349: Feb 7, 2001:
350: more (const char *) casts in b.c and tran.c to silence warnings.
1.8 millert 351:
1.10 millert 352: Nov 15, 2000:
353: fixed a bug introduced in august 1997 that caused expressions
354: like $f[1] to be syntax errors. thanks to arnold robbins for
355: noticing this and providing a fix.
356:
357: Oct 30, 2000:
358: fixed some nextfile bugs: not handling all cases. thanks to
359: arnold robbins for pointing this out. new regressions added.
360:
361: close() is now a function. it returns whatever the library
362: fclose returns, and -1 for closing a file or pipe that wasn't
363: opened.
364:
365: Sep 24, 2000:
366: permit \n explicitly in character classes; won't work right
367: if comes in as "[\n]" but ok as /[\n]/, because of multiple
368: processing of \'s. thanks to arnold robbins.
369:
370: July 5, 2000:
371: minor fiddles in tran.c to keep compilers happy about uschar.
372: thanks to norman wilson.
373:
374: May 25, 2000:
375: yet another attempt at making 8-bit input work, with another
376: band-aid in b.c (member()), and some (uschar) casts to head
377: off potential errors in subscripts (like isdigit). also
378: changed HAT to NCHARS-2. thanks again to santiago vila.
379:
380: changed maketab.c to ignore apparently out of range definitions
381: instead of halting; new freeBSD generates one. thanks to
382: jon snader <jsnader@ix.netcom.com> for pointing out the problem.
383:
384: May 2, 2000:
385: fixed an 8-bit problem in b.c by making several char*'s into
386: unsigned char*'s. not clear i have them all yet. thanks to
387: Santiago Vila <sanvila@unex.es> for the bug report.
388:
389: Apr 21, 2000:
390: finally found and fixed a memory leak in function call; it's
391: been there since functions were added ~1983. thanks to
392: jon bentley for the test case that found it.
393:
394: added test in envinit to catch environment "variables" with
1.12 otto 395: names beginning with '='; thanks to Berend Hasselman.
1.10 millert 396:
397: Jul 28, 1999:
398: added test in defn() to catch function foo(foo), which
399: otherwise recurses until core dump. thanks to arnold
400: robbins for noticing this.
401:
1.9 millert 402: Jun 20, 1999:
403: added *bp in gettok in lex.c; appears possible to exit function
404: without terminating the string. thanks to russ cox.
405:
406: Jun 2, 1999:
407: added function stdinit() to run to initialize files[] array,
408: in case stdin, etc., are not constants; some compilers care.
409:
410: May 10, 1999:
411: replaced the ERROR ... FATAL, etc., macros with functions
412: based on vprintf, to avoid problems caused by overrunning
413: fixed-size errbuf array. thanks to ralph corderoy for the
414: impetus, and for pointing out a string termination bug in
415: qstring as well.
416:
417: Apr 21, 1999:
418: fixed bug that caused occasional core dumps with commandline
419: variable with value ending in \. (thanks to nelson beebe for
420: the test case.)
421:
1.8 millert 422: Apr 16, 1999:
423: with code kindly provided by Bruce Lilly, awk now parses
424: /=/ and similar constructs more sensibly in more places.
1.10 millert 425: Bruce also provided some helpful test cases.
1.8 millert 426:
427: Apr 5, 1999:
428: changed true/false to True/False in run.c to make it
429: easier to compile with C++. Added some casts on malloc
430: and realloc to be honest about casts; ditto. changed
431: ltype int to long in struct rrow to reduce some 64-bit
432: complaints; other changes scattered throughout for the
433: same purpose. thanks to Nelson Beebe for these portability
434: improvements.
435:
436: removed some horrible pointer-int casting in b.c and elsewhere
437: by adding ptoi and itonp to localize the casts, which are
438: all benign. fixed one incipient bug that showed up on sgi
439: in 64-bit mode.
440:
441: reset lineno for new source file; include filename in error
442: message. also fixed line number error in continuation lines.
443: (thanks to Nelson Beebe for both of these.)
444:
445: Mar 24, 1999:
446: Nelson Beebe notes that irix 5.3 yacc dies with a bogus
447: error; use a newer version or switch to bison, since sgi
448: is unlikely to fix it.
1.1 tholo 449:
1.7 millert 450: Mar 5, 1999:
1.9 millert 451: changed isnumber to is_number to avoid the problem caused by
452: versions of ctype.h that include the name isnumber.
1.7 millert 453:
454: distribution now includes a script for building on a Mac,
455: thanks to Dan Allen.
456:
457: Feb 20, 1999:
458: fixed memory leaks in run.c (call) and tran.c (setfval).
459: thanks to Stephen Nutt for finding these and providing the fixes.
460:
461: Jan 13, 1999:
462: replaced srand argument by (unsigned int) in run.c;
463: avoids problem on Mac and potentially on Unix & Windows.
464: thanks to Dan Allen.
465:
466: added a few (int) casts to silence useless compiler warnings.
467: e.g., errorflag= in run.c jump().
468:
469: added proctab.c to the bundle outout; one less thing
470: to have to compile out of the box.
471:
472: added calls to _popen and _pclose to the win95 stub for
473: pipes (thanks to Steve Adams for this helpful suggestion).
474: seems to work, though properties are not well understood
475: by me, and it appears that under some circumstances the
476: pipe output is truncated. Be careful.
477:
478: Oct 19, 1998:
479: fixed a couple of bugs in getrec: could fail to update $0
480: after a getline var; because inputFS wasn't initialized,
481: could split $0 on every character, a misleading diversion.
482:
483: fixed caching bug in makedfa: LRU was actually removing
484: least often used.
485:
486: thanks to ross ridge for finding these, and for providing
487: great bug reports.
488:
489: May 12, 1998:
490: fixed potential bug in readrec: might fail to update record
491: pointer after growing. thanks to dan levy for spotting this
492: and suggesting the fix.
493:
494: Mar 12, 1998:
495: added -V to print version number and die.
496:
497: Feb 11, 1998:
498: subtle silent bug in lex.c: if the program ended with a number
499: longer than 1 digit, part of the input would be pushed back and
500: parsed again because token buffer wasn't terminated right.
501: example: awk 'length($0) > 10'. blush. at least i found it
502: myself.
503:
504: Aug 31, 1997:
505: s/adelete/awkdelete/: SGI uses this in malloc.h.
506: thanks to nelson beebe for pointing this one out.
507:
508: Aug 21, 1997:
509: fixed some bugs in sub and gsub when replacement includes \\.
510: this is a dark, horrible corner, but at least now i believe that
511: the behavior is the same as gawk and the intended posix standard.
512: thanks to arnold robbins for advice here.
513:
514: Aug 9, 1997:
515: somewhat regretfully, replaced the ancient lex-based lexical
516: analyzer with one written in C. it's longer, generates less code,
517: and more portable; the old one depended too much on mysterious
518: properties of lex that were not preserved in other environments.
519: in theory these recognize the same language.
520:
521: now using strtod to test whether a string is a number, instead of
522: the convoluted original function. should be more portable and
523: reliable if strtod is implemented right.
524:
525: removed now-pointless optimization in makefile that tries to avoid
526: recompilation when awkgram.y is changed but symbols are not.
527:
528: removed most fixed-size arrays, though a handful remain, some
529: of which are unchecked. you have been warned.
530:
531: Aug 4, 1997:
532: with some trepidation, replaced the ancient code that managed
533: fields and $0 in fixed-size arrays with arrays that grow on
534: demand. there is still some tension between trying to make this
535: run fast and making it clean; not sure it's right yet.
536:
537: the ill-conceived -mr and -mf arguments are now useful only
538: for debugging. previous dynamic string code removed.
539:
540: numerous other minor cleanups along the way.
1.1 tholo 541:
1.7 millert 542: Jul 30, 1997:
543: using code provided by dan levy (to whom profuse thanks), replaced
544: fixed-size arrays and awkward kludges by a fairly uniform mechanism
545: to grow arrays as needed for printf, sub, gsub, etc.
1.1 tholo 546:
1.7 millert 547: Jul 23, 1997:
548: falling off the end of a function returns "" and 0, not 0.
549: thanks to arnold robbins.
1.1 tholo 550:
1.7 millert 551: Jun 17, 1997:
552: replaced several fixed-size arrays by dynamically-created ones
553: in run.c; added overflow tests to some previously unchecked cases.
554: getline, toupper, tolower.
1.1 tholo 555:
1.7 millert 556: getline code is still broken in that recursive calls may wind
557: up using the same space. [fixed later]
1.1 tholo 558:
1.7 millert 559: increased RECSIZE to 8192 to push problems further over the horizon.
1.1 tholo 560:
1.7 millert 561: added \r to \n as input line separator for programs, not data.
562: damn CRLFs.
1.1 tholo 563:
1.7 millert 564: modified format() to permit explicit printf("%c", 0) to include
565: a null byte in output. thanks to ken stailey for the fix.
1.1 tholo 566:
1.7 millert 567: added a "-safe" argument that disables file output (print >,
568: print >>), process creation (cmd|getline, print |, system), and
569: access to the environment (ENVIRON). this is a first approximation
570: to a "safe" version of awk, but don't rely on it too much. thanks
571: to joan feigenbaum and matt blaze for the inspiration long ago.
1.1 tholo 572:
1.7 millert 573: Jul 8, 1996:
574: fixed long-standing bug in sub, gsub(/a/, "\\\\&"); thanks to
575: ralph corderoy.
1.1 tholo 576:
1.7 millert 577: Jun 29, 1996:
578: fixed awful bug in new field splitting; didn't get all the places
579: where input was done.
1.1 tholo 580:
1.7 millert 581: Jun 28, 1996:
582: changed field-splitting to conform to posix definition: fields are
583: split using the value of FS at the time of input; it used to be
584: the value when the field or NF was first referred to, a much less
585: predictable definition. thanks to arnold robbins for encouragement
586: to do the right thing.
1.1 tholo 587:
1.7 millert 588: May 28, 1996:
589: fixed appalling but apparently unimportant bug in parsing octal
590: numbers in reg exprs.
1.1 tholo 591:
1.7 millert 592: explicit hex in reg exprs now limited to 2 chars: \xa, \xaa.
1.1 tholo 593:
1.7 millert 594: May 27, 1996:
595: cleaned up some declarations so gcc -Wall is now almost silent.
1.1 tholo 596:
1.7 millert 597: makefile now includes backup copies of ytab.c and lexyy.c in case
598: one makes before looking; it also avoids recreating lexyy.c unless
599: really needed.
1.1 tholo 600:
1.7 millert 601: s/aprintf/awkprint, s/asprintf/awksprintf/ to avoid some name clashes
602: with unwisely-written header files.
1.1 tholo 603:
1.7 millert 604: thanks to jeffrey friedl for several of these.
1.1 tholo 605:
1.7 millert 606: May 26, 1996:
607: an attempt to rationalize the (unsigned) char issue. almost all
608: instances of unsigned char have been removed; the handful of places
609: in b.c where chars are used as table indices have been hand-crafted.
610: added some latin-1 tests to the regression, but i'm not confident;
611: none of my compilers seem to care much. thanks to nelson beebe for
612: pointing out some others that do care.
1.1 tholo 613:
1.7 millert 614: May 2, 1996:
615: removed all register declarations.
1.1 tholo 616:
1.7 millert 617: enhanced split(), as in gawk, etc: split(s, a, "") splits s into
618: a[1]...a[length(s)] with each character a single element.
1.1 tholo 619:
1.7 millert 620: made the same changes for field-splitting if FS is "".
1.1 tholo 621:
1.7 millert 622: added nextfile, as in gawk: causes immediate advance to next
623: input file. (thanks to arnold robbins for inspiration and code).
1.1 tholo 624:
1.7 millert 625: small fixes to regexpr code: can now handle []], [[], and
626: variants; [] is now a syntax error, rather than matching
627: everything; [z-a] is now empty, not z. far from complete
628: or correct, however. (thanks to jeffrey friedl for pointing out
629: some awful behaviors.)
1.1 tholo 630:
1.7 millert 631: Apr 29, 1996:
1.12 otto 632: replaced uchar by uschar everywhere; apparently some compilers
1.7 millert 633: usurp this name and this causes conflicts.
1.1 tholo 634:
1.7 millert 635: fixed call to time in run.c (bltin); arg is time_t *.
1.1 tholo 636:
1.7 millert 637: replaced horrible pointer/long punning in b.c by a legitimate
638: union. should be safer on 64-bit machines and cleaner everywhere.
639: (thanks to nelson beebe for pointing out some of these problems.)
1.1 tholo 640:
1.7 millert 641: replaced nested comments by #if 0...#endif in run.c, lib.c.
1.1 tholo 642:
1.7 millert 643: removed getsval, setsval, execute macros from run.c and lib.c.
644: machines are 100x faster than they were when these macros were
645: first used.
1.1 tholo 646:
1.7 millert 647: revised filenames: awk.g.y => awkgram.y, awk.lx.l => awklex.l,
648: y.tab.[ch] => ytab.[ch], lex.yy.c => lexyy.c, all in the aid of
649: portability to nameless systems.
1.1 tholo 650:
1.7 millert 651: "make bundle" now includes yacc and lex output files for recipients
652: who don't have yacc or lex.
1.1 tholo 653:
1.7 millert 654: Aug 15, 1995:
655: initialized Cells in setsymtab more carefully; some fields
656: were not set. (thanks to purify, all of whose complaints i
657: think i now understand.)
1.1 tholo 658:
1.7 millert 659: fixed at least one error in gsub that looked at -1-th element
660: of an array when substituting for a null match (e.g., $).
1.1 tholo 661:
1.7 millert 662: delete arrayname is now legal; it clears the elements but leaves
663: the array, which may not be the right behavior.
1.1 tholo 664:
1.7 millert 665: modified makefile: my current make can't cope with the test used
666: to avoid unnecessary yacc invocations.
1.1 tholo 667:
1.7 millert 668: Jul 17, 1995:
669: added dynamically growing strings to awk.lx.l and b.c
670: to permit regular expressions to be much bigger.
671: the state arrays can still overflow.
1.1 tholo 672:
1.7 millert 673: Aug 24, 1994:
674: detect duplicate arguments in function definitions (mdm).
1.1 tholo 675:
1.7 millert 676: May 11, 1994:
677: trivial fix to printf to limit string size in sub().
1.1 tholo 678:
1.7 millert 679: Apr 22, 1994:
680: fixed yet another subtle self-assignment problem:
681: $1 = $2; $1 = $1 clobbered $1.
1.1 tholo 682:
1.7 millert 683: Regression tests now use private echo, to avoid quoting problems.
1.1 tholo 684:
1.7 millert 685: Feb 2, 1994:
686: changed error() to print line number as %d, not %g.
1.1 tholo 687:
1.7 millert 688: Jul 23, 1993:
689: cosmetic changes: increased sizes of some arrays,
690: reworded some error messages.
1.1 tholo 691:
1.7 millert 692: added CONVFMT as in posix (just replaced OFMT in getsval)
1.1 tholo 693:
1.7 millert 694: FILENAME is now "" until the first thing that causes a file
695: to be opened.
1.1 tholo 696:
1.7 millert 697: Nov 28, 1992:
698: deleted yyunput and yyoutput from proto.h;
699: different versions of lex give these different declarations.
1.1 tholo 700:
1.7 millert 701: May 31, 1992:
702: added -mr N and -mf N options: more record and fields.
703: these really ought to adjust automatically.
1.1 tholo 704:
1.7 millert 705: cleaned up some error messages; "out of space" now means
706: malloc returned NULL in all cases.
1.1 tholo 707:
1.7 millert 708: changed rehash so that if it runs out, it just returns;
709: things will continue to run slow, but maybe a bit longer.
1.1 tholo 710:
1.7 millert 711: Apr 24, 1992:
712: remove redundant close of stdin when using -f -.
1.1 tholo 713:
1.7 millert 714: got rid of core dump with -d; awk -d just prints date.
1.1 tholo 715:
1.7 millert 716: Apr 12, 1992:
717: added explicit check for /dev/std(in,out,err) in redirection.
718: unlike gawk, no /dev/fd/n yet.
1.1 tholo 719:
1.7 millert 720: added (file/pipe) builtin. hard to test satisfactorily.
721: not posix.
1.1 tholo 722:
1.7 millert 723: Feb 20, 1992:
724: recompile after abortive changes; should be unchanged.
1.1 tholo 725:
1.7 millert 726: Dec 2, 1991:
727: die-casting time: converted to ansi C, installed that.
1.1 tholo 728:
1.7 millert 729: Nov 30, 1991:
730: fixed storage leak in freefa, failing to recover [N]CCL.
731: thanks to Bill Jones (jones@cs.usask.ca)
1.1 tholo 732:
1.7 millert 733: Nov 19, 1991:
734: use RAND_MAX instead of literal in builtin().
1.1 tholo 735:
1.7 millert 736: Nov 12, 1991:
737: cranked up some fixed-size arrays in b.c, and added a test for
738: overflow in penter. thanks to mark larsen.
1.1 tholo 739:
1.7 millert 740: Sep 24, 1991:
741: increased buffer in gsub. a very crude fix to a general problem.
742: and again on Sep 26.
1.1 tholo 743:
1.7 millert 744: Aug 18, 1991:
745: enforce variable name syntax for commandline variables: has to
746: start with letter or _.
1.1 tholo 747:
1.7 millert 748: Jul 27, 1991:
749: allow newline after ; in for statements.
1.1 tholo 750:
1.7 millert 751: Jul 21, 1991:
752: fixed so that in self-assignment like $1=$1, side effects
753: like recomputing $0 take place. (this is getting subtle.)
1.1 tholo 754:
1.7 millert 755: Jun 30, 1991:
756: better test for detecting too-long output record.
1.1 tholo 757:
1.7 millert 758: Jun 2, 1991:
759: better defense against very long printf strings.
760: made break and continue illegal outside of loops.
1.1 tholo 761:
1.7 millert 762: May 13, 1991:
763: removed extra arg on gettemp, tempfree. minor error message rewording.
1.1 tholo 764:
765: May 6, 1991:
766: fixed silly bug in hex parsing in hexstr().
767: removed an apparently unnecessary test in isnumber().
768: warn about weird printf conversions.
769: fixed unchecked array overwrite in relex().
770:
771: changed for (i in array) to access elements in sorted order.
772: then unchanged it -- it really does run slower in too many cases.
773: left the code in place, commented out.
774:
1.7 millert 775: Feb 10, 1991:
776: check error status on all writes, to avoid banging on full disks.
1.1 tholo 777:
1.7 millert 778: Jan 28, 1991:
779: awk -f - reads the program from stdin.
1.1 tholo 780:
1.7 millert 781: Jan 11, 1991:
782: failed to set numeric state on $0 in cmd|getline context in run.c.
1.1 tholo 783:
1.7 millert 784: Nov 2, 1990:
785: fixed sleazy test for integrality in getsval; use modf.
1.1 tholo 786:
1.7 millert 787: Oct 29, 1990:
788: fixed sleazy buggy code in lib.c that looked (incorrectly) for
789: too long input lines.
1.1 tholo 790:
1.7 millert 791: Oct 14, 1990:
792: fixed the bug on p. 198 in which it couldn't deduce that an
793: argument was an array in some contexts. replaced the error
794: message in intest() by code that damn well makes it an array.
1.1 tholo 795:
1.7 millert 796: Oct 8, 1990:
797: fixed horrible bug: types and values were not preserved in
798: some kinds of self-assignment. (in assign().)
1.1 tholo 799:
1.7 millert 800: Aug 24, 1990:
801: changed NCHARS to 256 to handle 8-bit characters in strings
802: presented to match(), etc.
1.1 tholo 803:
1.7 millert 804: Jun 26, 1990:
805: changed struct rrow (awk.h) to use long instead of int for lval,
806: since cfoll() stores a pointer in it. now works better when int's
807: are smaller than pointers!
1.1 tholo 808:
1.7 millert 809: May 6, 1990:
810: AVA fixed the grammar so that ! is uniformly of the same precedence as
811: unary + and -. This renders illegal some constructs like !x=y, which
812: now has to be parenthesized as !(x=y), and makes others work properly:
813: !x+y is (!x)+y, and x!y is x !y, not two pattern-action statements.
814: (These problems were pointed out by Bob Lenk of Posix.)
1.1 tholo 815:
1.7 millert 816: Added \x to regular expressions (already in strings).
817: Limited octal to octal digits; \8 and \9 are not octal.
818: Centralized the code for parsing escapes in regular expressions.
819: Added a bunch of tests to T.re and T.sub to verify some of this.
1.1 tholo 820:
1.7 millert 821: Feb 9, 1990:
822: fixed null pointer dereference bug in main.c: -F[nothing]. sigh.
1.1 tholo 823:
1.7 millert 824: restored srand behavior: it returns the current seed.
1.1 tholo 825:
1.7 millert 826: Jan 18, 1990:
827: srand now returns previous seed value (0 to start).
1.1 tholo 828:
1.7 millert 829: Jan 5, 1990:
830: fix potential problem in tran.c -- something was freed,
831: then used in freesymtab.
1.1 tholo 832:
1.7 millert 833: Oct 18, 1989:
834: another try to get the max number of open files set with
835: relatively machine-independent code.
1.1 tholo 836:
1.7 millert 837: small fix to input() in case of multiple reads after EOF.
1.1 tholo 838:
1.7 millert 839: Oct 11, 1989:
840: FILENAME is now defined in the BEGIN block -- too many old
841: programs broke.
1.1 tholo 842:
1.7 millert 843: "-" means stdin in getline as well as on the commandline.
1.1 tholo 844:
1.7 millert 845: added a bunch of casts to the code to tell the truth about
846: char * vs. unsigned char *, a right royal pain. added a
847: setlocale call to the front of main, though probably no one
848: has it usefully implemented yet.
1.1 tholo 849:
1.7 millert 850: Aug 24, 1989:
851: removed redundant relational tests against nullnode if parse
852: tree already had a relational at that point.
1.1 tholo 853:
1.7 millert 854: Aug 11, 1989:
855: fixed bug: commandline variable assignment has to look like
856: var=something. (consider the man page for =, in file =.1)
1.1 tholo 857:
1.7 millert 858: changed number of arguments to functions to static arrays
859: to avoid repeated malloc calls.
1.1 tholo 860:
1.7 millert 861: Aug 2, 1989:
862: restored -F (space) separator
1.1 tholo 863:
1.7 millert 864: Jul 30, 1989:
865: added -v x=1 y=2 ... for immediate commandline variable assignment;
866: done before the BEGIN block for sure. they have to precede the
867: program if the program is on the commandline.
868: Modified Aug 2 to require a separate -v for each assignment.
1.1 tholo 869:
1.7 millert 870: Jul 10, 1989:
871: fixed ref-thru-zero bug in environment code in tran.c
1.1 tholo 872:
1.7 millert 873: Jun 23, 1989:
874: add newline to usage message.
1.1 tholo 875:
1.7 millert 876: Jun 14, 1989:
877: added some missing ansi printf conversion letters: %i %X %E %G.
878: no sensible meaning for h or L, so they may not do what one expects.
1.1 tholo 879:
1.7 millert 880: made %* conversions work.
1.1 tholo 881:
1.7 millert 882: changed x^y so that if n is a positive integer, it's done
883: by explicit multiplication, thus achieving maximum accuracy.
884: (this should be done by pow() but it seems not to be locally.)
885: done to x ^= y as well.
1.1 tholo 886:
1.7 millert 887: Jun 4, 1989:
888: ENVIRON array contains environment: if shell variable V=thing,
889: ENVIRON["V"] is "thing"
1.1 tholo 890:
1.7 millert 891: multiple -f arguments permitted. error reporting is naive.
892: (they were permitted before, but only the last was used.)
1.1 tholo 893:
1.7 millert 894: fixed a really stupid botch in the debugging macro dprintf
1.1 tholo 895:
1.7 millert 896: fixed order of evaluation of commandline assignments to match
897: what the book claims: an argument of the form x=e is evaluated
898: at the time it would have been opened if it were a filename (p 63).
899: this invalidates the suggested answer to ex 4-1 (p 195).
1.1 tholo 900:
1.7 millert 901: removed some code that permitted -F (space) fieldseparator,
902: since it didn't quite work right anyway. (restored aug 2)
1.1 tholo 903:
1.7 millert 904: Apr 27, 1989:
905: Line number now accumulated correctly for comment lines.
1.1 tholo 906:
1.7 millert 907: Apr 26, 1989:
908: Debugging output now includes a version date,
909: if one compiles it into the source each time.
1.1 tholo 910:
1.7 millert 911: Apr 9, 1989:
912: Changed grammar to prohibit constants as 3rd arg of sub and gsub;
913: prevents class of overwriting-a-constant errors. (Last one?)
914: This invalidates the "banana" example on page 43 of the book.
1.1 tholo 915:
1.7 millert 916: Added \a ("alert"), \v (vertical tab), \xhhh (hexadecimal),
917: as in ANSI, for strings. Rescinded the sloppiness that permitted
918: non-octal digits in \ooo. Warning: not all compilers and libraries
919: will be able to deal with \x correctly.
1.1 tholo 920:
1.7 millert 921: Jan 9, 1989:
922: Fixed bug that caused tempcell list to contain a duplicate.
923: The fix is kludgy.
1.1 tholo 924:
1.7 millert 925: Dec 17, 1988:
926: Catches some more commandline errors in main.
927: Removed redundant decl of modf in run.c (confuses some compilers).
928: Warning: there's no single declaration of malloc, etc., in awk.h
929: that seems to satisfy all compilers.
1.1 tholo 930:
1.7 millert 931: Dec 7, 1988:
932: Added a bit of code to error printing to avoid printing nulls.
933: (Not clear that it actually would.)
1.1 tholo 934:
1.7 millert 935: Nov 27, 1988:
936: With fear and trembling, modified the grammar to permit
937: multiple pattern-action statements on one line without
938: an explicit separator. By definition, this capitulation
939: to the ghost of ancient implementations remains undefined
940: and thus subject to change without notice or apology.
941: DO NOT COUNT ON IT.
1.1 tholo 942:
1.7 millert 943: Oct 30, 1988:
944: Fixed bug in call() that failed to recover storage.
1.1 tholo 945:
1.7 millert 946: A warning is now generated if there are more arguments
947: in the call than in the definition (in lieu of fixing
948: another storage leak).
1.2 millert 949:
1.7 millert 950: Oct 20, 1988:
951: Fixed %c: if expr is numeric, use numeric value;
952: otherwise print 1st char of string value. still
953: doesn't work if the value is 0 -- won't print \0.
1.2 millert 954:
1.7 millert 955: Added a few more checks for running out of malloc.
1.2 millert 956:
1.7 millert 957: Oct 12, 1988:
958: Fixed bug in call() that freed local arrays twice.
1.5 kstailey 959:
1.7 millert 960: Fixed to handle deletion of non-existent array right;
961: complains about attempt to delete non-array element.
1.6 kstailey 962:
1.7 millert 963: Sep 30, 1988:
964: Now guarantees to evaluate all arguments of built-in
965: functions, as in C; the appearance is that arguments
966: are evaluated before the function is called. Places
967: affected are sub (gsub was ok), substr, printf, and
968: all the built-in arithmetic functions in bltin().
969: A warning is generated if a bltin() is called with
970: the wrong number of arguments.
1.6 kstailey 971:
1.7 millert 972: This requires changing makeprof on p167 of the book.
1.6 kstailey 973:
1.7 millert 974: Aug 23, 1988:
975: setting FILENAME in BEGIN caused core dump, apparently
976: because it was freeing space not allocated by malloc.
1.6 kstailey 977:
1.7 millert 978: July 24, 1988:
979: fixed egregious error in toupper/tolower functions.
980: still subject to rescinding, however.
1.6 kstailey 981:
1.7 millert 982: July 2, 1988:
983: flush stdout before opening file or pipe
1.6 kstailey 984:
1.7 millert 985: July 2, 1988:
986: performance bug in b.c/cgoto(): not freeing some sets of states.
987: partial fix only right now, and the number of states increased
988: to make it less obvious.
1.6 kstailey 989:
1.7 millert 990: June 1, 1988:
991: check error status on close
1.6 kstailey 992:
1.7 millert 993: May 28, 1988:
994: srand returns seed value it's using.
995: see 1/18/90
1.6 kstailey 996:
1.7 millert 997: May 22, 1988:
998: Removed limit on depth of function calls.
1.6 kstailey 999:
1.7 millert 1000: May 10, 1988:
1001: Fixed lib.c to permit _ in commandline variable names.
1.6 kstailey 1002:
1.7 millert 1003: Mar 25, 1988:
1004: main.c fixed to recognize -- as terminator of command-
1005: line options. Illegal options flagged.
1006: Error reporting slightly cleaned up.
1.6 kstailey 1007:
1.7 millert 1008: Dec 2, 1987:
1009: Newer C compilers apply a strict scope rule to extern
1010: declarations within functions. Two extern declarations in
1011: lib.c and tran.c have been moved to obviate this problem.
1.6 kstailey 1012:
1.7 millert 1013: Oct xx, 1987:
1014: Reluctantly added toupper and tolower functions.
1015: Subject to rescinding without notice.
1.6 kstailey 1016:
1.7 millert 1017: Sep 17, 1987:
1018: Error-message printer had printf(s) instead of
1019: printf("%s",s); got core dumps when the message
1020: included a %.
1.6 kstailey 1021:
1.7 millert 1022: Sep 12, 1987:
1023: Very long printf strings caused core dump;
1024: fixed aprintf, asprintf, format to catch them.
1025: Can still get a core dump in printf itself.
1.6 kstailey 1026:
1027:
![[BACK]](/icons/back.gif){kind=icon}
Return to FIXES CVS log ![[TXT]](/icons/text.gif){kind=icon}
![[DIR]](/icons/dir.gif){kind=icon}
Up to [local] / src / usr.bin / awk