Annotation of src/usr.bin/awk/FIXES, Revision 1.18
1.18 ! millert 1: /* $OpenBSD: FIXES,v 1.17 2020/02/27 21:43:46 millert Exp $ */
1.1 tholo 2: /****************************************************************
1.6 kstailey 3: Copyright (C) Lucent Technologies 1997
1.1 tholo 4: All Rights Reserved
5:
6: Permission to use, copy, modify, and distribute this software and
7: its documentation for any purpose and without fee is hereby
8: granted, provided that the above copyright notice appear in all
9: copies and that both that the copyright notice and this
10: permission notice and warranty disclaimer appear in supporting
1.6 kstailey 11: documentation, and that the name Lucent Technologies or any of
12: its entities not be used in advertising or publicity pertaining
13: to distribution of the software without specific, written prior
14: permission.
15:
16: LUCENT DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE,
17: INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS.
18: IN NO EVENT SHALL LUCENT OR ANY OF ITS ENTITIES BE LIABLE FOR ANY
19: SPECIAL, INDIRECT OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
20: WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER
21: IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION,
22: ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF
23: THIS SOFTWARE.
1.1 tholo 24: ****************************************************************/
25:
26: This file lists all bug fixes, changes, etc., made since the AWK book
27: was sent to the printers in August, 1987.
1.18 ! millert 28:
! 29: Jun 7, 2018:
! 30: (yes, a long layoff)
! 31: Updated some broken tests (beebe.tar, T.lilly)
! 32: [thanks to Arnold Robbins]
! 33:
! 34: Mar 26, 2015:
! 35: buffer overflow in error reporting; thanks to tobias ulmer
! 36: and john-mark gurney for spotting it and the fix.
! 37:
! 38: Feb 4, 2013:
! 39: cleaned up a handful of tests that didn't seem to actually
! 40: test for correct behavior: T.latin1, T.gawk.
! 41:
! 42: Jan 5, 2013:
! 43: added ,NULL initializer to static Cells in run.c; not really
! 44: needed but cleaner. Thanks to Michael Bombardieri.
1.17 millert 45:
46: Dec 20, 2012:
47: fiddled makefile to get correct yacc and bison flags. pick yacc
48: (linux) or bison (mac) as necessary.
49:
50: added __attribute__((__noreturn__)) to a couple of lines in
51: proto.h, to silence someone's enthusiastic checker.
52:
53: fixed obscure call by value bug in split(a[1],a) reported on
54: 9fans. the management of temporary values is just a mess; i
55: took a shortcut by making an extra string copy. thanks
56: to paul patience and arnold robbins for passing it on and for
57: proposed patches.
58:
59: tiny fiddle in setfval to eliminate -0 results in T.expr, which
60: has irritated me for 20+ years.
1.16 millert 61:
62: Aug 10, 2011:
63: another fix to avoid core dump with delete(ARGV); again, many thanks
64: to ruslan ermilov.
65:
66: Aug 7, 2011:
67: split(s, a, //) now behaves the same as split(s, a, "")
68:
69: Jun 12, 2011:
70: /pat/, \n /pat/ {...} is now legal, though bad style to use.
71:
72: added checks to new -v code that permits -vnospace; thanks to
73: ruslan ermilov for spotting this and providing the patch.
74:
75: removed fixed limit on number of open files; thanks to aleksey
76: cheusov and christos zoulos.
77:
78: fixed day 1 bug that resurrected deleted elements of ARGV when
79: used as filenames (in lib.c).
80:
81: minor type fiddles to make gcc -Wall -pedantic happier (but not
82: totally so); turned on -fno-strict-aliasing in makefile.
83:
84: May 6, 2011:
85: added #ifdef for isblank.
86: now allows -ffoo as well as -f foo arguments.
87: (thanks, ruslan)
88:
89: May 1, 2011:
90: after advice from todd miller, kevin lo, ruslan ermilov,
91: and arnold robbins, changed srand() to return the previous
92: seed (which is 1 on the first call of srand). the seed is
93: an Awkfloat internally though converted to unsigned int to
94: pass to the library srand(). thanks, everyone.
95:
96: fixed a subtle (and i hope low-probability) overflow error
97: in fldbld, by adding space for one extra \0. thanks to
98: robert bassett for spotting this one and providing a fix.
99:
100: removed the files related to compilation on windows. i no
101: longer have anything like a current windows environment, so
102: i can't test any of it.
1.15 millert 103:
104: May 23, 2010:
105: fixed long-standing overflow bug in run.c; many thanks to
106: nelson beebe for spotting it and providing the fix.
107:
108: fixed bug that didn't parse -vd=1 properly; thanks to santiago
109: vila for spotting it.
110:
111: Feb 8, 2010:
112: i give up. replaced isblank with isspace in b.c; there are
113: no consistent header files.
114:
115: Nov 26, 2009:
116: fixed a long-standing issue with when FS takes effect. a
117: change to FS is now noticed immediately for subsequent splits.
118:
119: changed the name getline() to awkgetline() to avoid yet another
120: name conflict somewhere.
121:
122: Feb 11, 2009:
123: temporarily for now defined HAS_ISBLANK, since that seems to
124: be the best way through the thicket. isblank arrived in C99,
125: but seems to be arriving at different systems at different
126: times.
127:
128: Oct 8, 2008:
129: fixed typo in b.c that set tmpvec wrongly. no one had ever
130: run into the problem, apparently. thanks to alistair crooks.
1.14 millert 131:
132: Oct 23, 2007:
133: minor fix in lib.c: increase inputFS to 100, change malloc
134: for fields to n+1.
135:
136: fixed memory fault caused by out of order test in setsval.
137:
138: thanks to david o'brien, freebsd, for both fixes.
139:
140: May 1, 2007:
141: fiddle in makefile to fix for BSD make; thanks to igor sobrado.
142:
143: Mar 31, 2007:
144: fixed some null pointer refs calling adjbuf.
145:
146: Feb 21, 2007:
147: fixed a bug in matching the null RE in sub and gsub. thanks to al aho
148: who actually did the fix (in b.c), and to wolfgang seeberg for finding
149: it and providing a very compact test case.
150:
151: fixed quotation in b.c; thanks to Hal Pratt and the Princeton Dante
152: Project.
153:
154: removed some no-effect asserts in run.c.
155:
156: fiddled maketab.c to not complain about bison-generated values.
157:
158: removed the obsolete -V argument; fixed --version to print the
159: version and exit.
160:
161: fixed wording and an outright error in the usage message; thanks to igor
162: sobrado and jason mcintyre.
163:
164: fixed a bug in -d that caused core dump if no program followed.
165:
166: Jan 1, 2007:
167: dropped mac.code from makefile; there are few non-MacOSX
168: mac's these days.
169:
170: Jan 17, 2006:
171: system() not flagged as unsafe in the unadvertised -safe option.
172: found it while enhancing tests before shipping the ;login: article.
173: practice what you preach.
174:
175: removed the 9-years-obsolete -mr and -mf flags.
176:
177: added -version and --version options.
178:
179: core dump on linux with BEGIN {nextfile}, now fixed.
180:
181: removed some #ifdef's in run.c and lex.c that appear to no
182: longer be necessary.
183:
184: Apr 24, 2005:
185: modified lib.c so that values of $0 et al are preserved in the END
186: block, apparently as required by posix. thanks to havard eidnes
187: for the report and code.
188:
189: Jan 14, 2005:
190: fixed infinite loop in parsing, originally found by brian tsang.
191: thanks to arnold robbins for a suggestion that started me
192: rethinking it.
193:
194: Dec 31, 2004:
195: prevent overflow of -f array in main, head off potential error in
196: call of SYNTAX(), test malloc return in lib.c, all with thanks to
197: todd miller.
1.13 millert 198:
199: Dec 22, 2004:
200: cranked up size of NCHARS; coverity thinks it can be overrun with
201: smaller size, and i think that's right. added some assertions to b.c
202: to catch places where it might overrun. the RE code is still fragile.
203:
204: Dec 5, 2004:
205: fixed a couple of overflow problems with ridiculous field numbers:
206: e.g., print $(2^32-1). thanks to ruslan ermilov, giorgos keramidas
207: and david o'brien at freebsd.org for patches. this really should
208: be re-done from scratch.
209:
210: Nov 21, 2004:
211: fixed another 25-year-old RE bug, in split. it's another failure
212: to (re-)initialize. thanks to steve fisher for spotting this and
213: providing a good test case.
214:
215: Nov 22, 2003:
216: fixed a bug in regular expressions that dates (so help me) from 1977;
217: it's been there from the beginning. an anchored longest match that
218: was longer than the number of states triggered a failure to initialize
219: the machine properly. many thanks to moinak ghosh for not only finding
220: this one but for providing a fix, in some of the most mysterious
221: code known to man.
222:
223: fixed a storage leak in call() that appears to have been there since
224: 1983 or so -- a function without an explicit return that assigns a
225: string to a parameter leaked a Cell. thanks to moinak ghosh for
226: spotting this very subtle one.
227:
228: Jul 31, 2003:
229: fixed, thanks to andrey chernov and ruslan ermilov, a bug in lex.c
230: that mis-handled the character 255 in input. (it was being compared
231: to EOF with a signed comparison.)
232:
233: Jul 29, 2003:
234: fixed (i think) the long-standing botch that included the beginning of
235: line state ^ for RE's in the set of valid characters; this led to a
236: variety of odd problems, including failure to properly match certain
237: regular expressions in non-US locales. thanks to ruslan for keeping
238: at this one.
239:
240: Jul 28, 2003:
241: n-th try at getting internationalization right, with thanks to volker
242: kiefel, arnold robbins and ruslan ermilov for advice, though they
243: should not be blamed for the outcome. according to posix, "." is the
244: radix character in programs and command line arguments regardless of
245: the locale; otherwise, the locale should prevail for input and output
246: of numbers. so it's intended to work that way.
247:
248: i have rescinded the attempt to use strcoll in expanding shorthands in
249: regular expressions (cclenter). its properties are much too
250: surprising; for example [a-c] matches aAbBc in locale en_US but abBcC
251: in locale fr_CA. i can see how this might arise by implementation
252: but i cannot explain it to a human user. (this behavior can be seen
253: in gawk as well; we're leaning on the same library.)
254:
255: the issue appears to be that strcoll is meant for sorting, where
256: merging upper and lower case may make sense (though note that unix
257: sort does not do this by default either). it is not appropriate
258: for regular expressions, where the goal is to match specific
259: patterns of characters. in any case, the notations [:lower:], etc.,
260: are available in awk, and they are more likely to work correctly in
261: most locales.
262:
263: a moratorium is hereby declared on internationalization changes.
264: i apologize to friends and colleagues in other parts of the world.
265: i would truly like to get this "right", but i don't know what
266: that is, and i do not want to keep making changes until it's clear.
267:
268: Jul 4, 2003:
269: fixed bug that permitted non-terminated RE, as in "awk /x".
270:
271: Jun 1, 2003:
272: subtle change to split: if source is empty, number of elems
273: is always 0 and the array is not set.
274:
275: Mar 21, 2003:
276: added some parens to isblank, in another attempt to make things
277: internationally portable.
278:
279: Mar 14, 2003:
280: the internationalization changes, somewhat modified, are now
281: reinstated. in theory awk will now do character comparisons
282: and case conversions in national language, but "." will always
283: be the decimal point separator on input and output regardless
284: of national language. isblank(){} has an #ifndef.
285:
286: this no longer compiles on windows: LC_MESSAGES isn't defined
287: in vc6++.
288:
289: fixed subtle behavior in field and record splitting: if FS is
290: a single character and RS is not empty, \n is NOT a separator.
291: this tortuous reading is found in the awk book; behavior now
292: matches gawk and mawk.
1.11 millert 293:
294: Dec 13, 2002:
295: for the moment, the internationalization changes of nov 29 are
296: rolled back -- programs like x = 1.2 don't work in some locales,
297: because the parser is expecting x = 1,2. until i understand this
298: better, this will have to wait.
299:
300: Nov 29, 2002:
301: modified b.c (with tiny changes in main and run) to support
302: locales, using strcoll and iswhatever tests for posix character
303: classes. thanks to ruslan ermilov (ru@freebsd.org) for code.
304: the function isblank doesn't seem to have propagated to any
305: header file near me, so it's there explicitly. not properly
306: tested on non-ascii character sets by me.
307:
308: Jun 28, 2002:
309: modified run/format() and tran/getsval() to do a slightly better
310: job on using OFMT for output from print and CONVFMT for other
311: number->string conversions, as promised by posix and done by
312: gawk and mawk. there are still places where it doesn't work
313: right if CONVFMT is changed; by then the STR attribute of the
314: variable has been irrevocably set. thanks to arnold robbins for
315: code and examples.
316:
317: fixed subtle bug in format that could get core dump. thanks to
318: Jaromir Dolecek <jdolecek@NetBSD.org> for finding and fixing.
319: minor cleanup in run.c / format() at the same time.
320:
321: added some tests for null pointers to debugging printf's, which
322: were never intended for external consumption. thanks to dave
323: kerns (dkerns@lucent.com) for pointing this out.
324:
325: GNU compatibility: an empty regexp matches anything (thanks to
326: dag-erling smorgrav, des@ofug.org). subject to reversion if
327: this does more harm than good.
328:
329: pervasive small changes to make things more const-correct, as
330: reported by gcc's -Wwrite-strings. as it says in the gcc manual,
331: this may be more nuisance than useful. provoked by a suggestion
332: and code from arnaud desitter, arnaud@nimbus.geog.ox.ac.uk
333:
334: minor documentation changes to note that this now compiles out
335: of the box on Mac OS X.
336:
337: Feb 10, 2002:
338: changed types in posix chars structure to quiet solaris cc.
339:
340: Jan 1, 2002:
341: fflush() or fflush("") flushes all files and pipes.
342:
343: length(arrayname) returns number of elements; thanks to
344: arnold robbins for suggestion.
345:
346: added a makefile.win to make it easier to build on windows.
347: based on dan allen's buildwin.bat.
348:
349: Nov 16, 2001:
350: added support for posix character class names like [:digit:],
351: which are not exactly shorter than [0-9] and perhaps no more
352: portable. thanks to dag-erling smorgrav for code.
353:
354: Feb 16, 2001:
355: removed -m option; no longer needed, and it was actually
356: broken (noted thanks to volker kiefel).
357:
358: Feb 10, 2001:
359: fixed an appalling bug in gettok: any sequence of digits, +,-, E, e,
360: and period was accepted as a valid number if it started with a period.
361: this would never have happened with the lex version.
362:
363: other 1-character botches, now fixed, include a bare $ and a
364: bare " at the end of the input.
365:
366: Feb 7, 2001:
367: more (const char *) casts in b.c and tran.c to silence warnings.
1.8 millert 368:
1.10 millert 369: Nov 15, 2000:
370: fixed a bug introduced in august 1997 that caused expressions
371: like $f[1] to be syntax errors. thanks to arnold robbins for
372: noticing this and providing a fix.
373:
374: Oct 30, 2000:
375: fixed some nextfile bugs: not handling all cases. thanks to
376: arnold robbins for pointing this out. new regressions added.
377:
378: close() is now a function. it returns whatever the library
379: fclose returns, and -1 for closing a file or pipe that wasn't
380: opened.
381:
382: Sep 24, 2000:
383: permit \n explicitly in character classes; won't work right
384: if comes in as "[\n]" but ok as /[\n]/, because of multiple
385: processing of \'s. thanks to arnold robbins.
386:
387: July 5, 2000:
388: minor fiddles in tran.c to keep compilers happy about uschar.
389: thanks to norman wilson.
390:
391: May 25, 2000:
392: yet another attempt at making 8-bit input work, with another
393: band-aid in b.c (member()), and some (uschar) casts to head
394: off potential errors in subscripts (like isdigit). also
395: changed HAT to NCHARS-2. thanks again to santiago vila.
396:
397: changed maketab.c to ignore apparently out of range definitions
398: instead of halting; new freeBSD generates one. thanks to
399: jon snader <jsnader@ix.netcom.com> for pointing out the problem.
400:
401: May 2, 2000:
402: fixed an 8-bit problem in b.c by making several char*'s into
403: unsigned char*'s. not clear i have them all yet. thanks to
404: Santiago Vila <sanvila@unex.es> for the bug report.
405:
406: Apr 21, 2000:
407: finally found and fixed a memory leak in function call; it's
408: been there since functions were added ~1983. thanks to
409: jon bentley for the test case that found it.
410:
411: added test in envinit to catch environment "variables" with
1.12 otto 412: names beginning with '='; thanks to Berend Hasselman.
1.10 millert 413:
414: Jul 28, 1999:
415: added test in defn() to catch function foo(foo), which
416: otherwise recurses until core dump. thanks to arnold
417: robbins for noticing this.
418:
1.9 millert 419: Jun 20, 1999:
420: added *bp in gettok in lex.c; appears possible to exit function
421: without terminating the string. thanks to russ cox.
422:
423: Jun 2, 1999:
424: added function stdinit() to run to initialize files[] array,
425: in case stdin, etc., are not constants; some compilers care.
426:
427: May 10, 1999:
428: replaced the ERROR ... FATAL, etc., macros with functions
429: based on vprintf, to avoid problems caused by overrunning
430: fixed-size errbuf array. thanks to ralph corderoy for the
431: impetus, and for pointing out a string termination bug in
432: qstring as well.
433:
434: Apr 21, 1999:
435: fixed bug that caused occasional core dumps with commandline
436: variable with value ending in \. (thanks to nelson beebe for
437: the test case.)
438:
1.8 millert 439: Apr 16, 1999:
440: with code kindly provided by Bruce Lilly, awk now parses
441: /=/ and similar constructs more sensibly in more places.
1.10 millert 442: Bruce also provided some helpful test cases.
1.8 millert 443:
444: Apr 5, 1999:
445: changed true/false to True/False in run.c to make it
446: easier to compile with C++. Added some casts on malloc
447: and realloc to be honest about casts; ditto. changed
448: ltype int to long in struct rrow to reduce some 64-bit
449: complaints; other changes scattered throughout for the
450: same purpose. thanks to Nelson Beebe for these portability
451: improvements.
452:
453: removed some horrible pointer-int casting in b.c and elsewhere
454: by adding ptoi and itonp to localize the casts, which are
455: all benign. fixed one incipient bug that showed up on sgi
456: in 64-bit mode.
457:
458: reset lineno for new source file; include filename in error
459: message. also fixed line number error in continuation lines.
460: (thanks to Nelson Beebe for both of these.)
461:
462: Mar 24, 1999:
463: Nelson Beebe notes that irix 5.3 yacc dies with a bogus
464: error; use a newer version or switch to bison, since sgi
465: is unlikely to fix it.
1.1 tholo 466:
1.7 millert 467: Mar 5, 1999:
1.9 millert 468: changed isnumber to is_number to avoid the problem caused by
469: versions of ctype.h that include the name isnumber.
1.7 millert 470:
471: distribution now includes a script for building on a Mac,
472: thanks to Dan Allen.
473:
474: Feb 20, 1999:
475: fixed memory leaks in run.c (call) and tran.c (setfval).
476: thanks to Stephen Nutt for finding these and providing the fixes.
477:
478: Jan 13, 1999:
479: replaced srand argument by (unsigned int) in run.c;
480: avoids problem on Mac and potentially on Unix & Windows.
481: thanks to Dan Allen.
482:
483: added a few (int) casts to silence useless compiler warnings.
484: e.g., errorflag= in run.c jump().
485:
486: added proctab.c to the bundle outout; one less thing
487: to have to compile out of the box.
488:
489: added calls to _popen and _pclose to the win95 stub for
490: pipes (thanks to Steve Adams for this helpful suggestion).
491: seems to work, though properties are not well understood
492: by me, and it appears that under some circumstances the
493: pipe output is truncated. Be careful.
494:
495: Oct 19, 1998:
496: fixed a couple of bugs in getrec: could fail to update $0
497: after a getline var; because inputFS wasn't initialized,
498: could split $0 on every character, a misleading diversion.
499:
500: fixed caching bug in makedfa: LRU was actually removing
501: least often used.
502:
503: thanks to ross ridge for finding these, and for providing
504: great bug reports.
505:
506: May 12, 1998:
507: fixed potential bug in readrec: might fail to update record
508: pointer after growing. thanks to dan levy for spotting this
509: and suggesting the fix.
510:
511: Mar 12, 1998:
512: added -V to print version number and die.
513:
514: Feb 11, 1998:
515: subtle silent bug in lex.c: if the program ended with a number
516: longer than 1 digit, part of the input would be pushed back and
517: parsed again because token buffer wasn't terminated right.
518: example: awk 'length($0) > 10'. blush. at least i found it
519: myself.
520:
521: Aug 31, 1997:
522: s/adelete/awkdelete/: SGI uses this in malloc.h.
523: thanks to nelson beebe for pointing this one out.
524:
525: Aug 21, 1997:
526: fixed some bugs in sub and gsub when replacement includes \\.
527: this is a dark, horrible corner, but at least now i believe that
528: the behavior is the same as gawk and the intended posix standard.
529: thanks to arnold robbins for advice here.
530:
531: Aug 9, 1997:
532: somewhat regretfully, replaced the ancient lex-based lexical
533: analyzer with one written in C. it's longer, generates less code,
534: and more portable; the old one depended too much on mysterious
535: properties of lex that were not preserved in other environments.
536: in theory these recognize the same language.
537:
538: now using strtod to test whether a string is a number, instead of
539: the convoluted original function. should be more portable and
540: reliable if strtod is implemented right.
541:
542: removed now-pointless optimization in makefile that tries to avoid
543: recompilation when awkgram.y is changed but symbols are not.
544:
545: removed most fixed-size arrays, though a handful remain, some
546: of which are unchecked. you have been warned.
547:
548: Aug 4, 1997:
549: with some trepidation, replaced the ancient code that managed
550: fields and $0 in fixed-size arrays with arrays that grow on
551: demand. there is still some tension between trying to make this
552: run fast and making it clean; not sure it's right yet.
553:
554: the ill-conceived -mr and -mf arguments are now useful only
555: for debugging. previous dynamic string code removed.
556:
557: numerous other minor cleanups along the way.
1.1 tholo 558:
1.7 millert 559: Jul 30, 1997:
560: using code provided by dan levy (to whom profuse thanks), replaced
561: fixed-size arrays and awkward kludges by a fairly uniform mechanism
562: to grow arrays as needed for printf, sub, gsub, etc.
1.1 tholo 563:
1.7 millert 564: Jul 23, 1997:
565: falling off the end of a function returns "" and 0, not 0.
566: thanks to arnold robbins.
1.1 tholo 567:
1.7 millert 568: Jun 17, 1997:
569: replaced several fixed-size arrays by dynamically-created ones
570: in run.c; added overflow tests to some previously unchecked cases.
571: getline, toupper, tolower.
1.1 tholo 572:
1.7 millert 573: getline code is still broken in that recursive calls may wind
574: up using the same space. [fixed later]
1.1 tholo 575:
1.7 millert 576: increased RECSIZE to 8192 to push problems further over the horizon.
1.1 tholo 577:
1.7 millert 578: added \r to \n as input line separator for programs, not data.
579: damn CRLFs.
1.1 tholo 580:
1.7 millert 581: modified format() to permit explicit printf("%c", 0) to include
582: a null byte in output. thanks to ken stailey for the fix.
1.1 tholo 583:
1.7 millert 584: added a "-safe" argument that disables file output (print >,
585: print >>), process creation (cmd|getline, print |, system), and
586: access to the environment (ENVIRON). this is a first approximation
587: to a "safe" version of awk, but don't rely on it too much. thanks
588: to joan feigenbaum and matt blaze for the inspiration long ago.
1.1 tholo 589:
1.7 millert 590: Jul 8, 1996:
591: fixed long-standing bug in sub, gsub(/a/, "\\\\&"); thanks to
592: ralph corderoy.
1.1 tholo 593:
1.7 millert 594: Jun 29, 1996:
595: fixed awful bug in new field splitting; didn't get all the places
596: where input was done.
1.1 tholo 597:
1.7 millert 598: Jun 28, 1996:
599: changed field-splitting to conform to posix definition: fields are
600: split using the value of FS at the time of input; it used to be
601: the value when the field or NF was first referred to, a much less
602: predictable definition. thanks to arnold robbins for encouragement
603: to do the right thing.
1.1 tholo 604:
1.7 millert 605: May 28, 1996:
606: fixed appalling but apparently unimportant bug in parsing octal
607: numbers in reg exprs.
1.1 tholo 608:
1.7 millert 609: explicit hex in reg exprs now limited to 2 chars: \xa, \xaa.
1.1 tholo 610:
1.7 millert 611: May 27, 1996:
612: cleaned up some declarations so gcc -Wall is now almost silent.
1.1 tholo 613:
1.7 millert 614: makefile now includes backup copies of ytab.c and lexyy.c in case
615: one makes before looking; it also avoids recreating lexyy.c unless
616: really needed.
1.1 tholo 617:
1.7 millert 618: s/aprintf/awkprint, s/asprintf/awksprintf/ to avoid some name clashes
619: with unwisely-written header files.
1.1 tholo 620:
1.7 millert 621: thanks to jeffrey friedl for several of these.
1.1 tholo 622:
1.7 millert 623: May 26, 1996:
624: an attempt to rationalize the (unsigned) char issue. almost all
625: instances of unsigned char have been removed; the handful of places
626: in b.c where chars are used as table indices have been hand-crafted.
627: added some latin-1 tests to the regression, but i'm not confident;
628: none of my compilers seem to care much. thanks to nelson beebe for
629: pointing out some others that do care.
1.1 tholo 630:
1.7 millert 631: May 2, 1996:
632: removed all register declarations.
1.1 tholo 633:
1.7 millert 634: enhanced split(), as in gawk, etc: split(s, a, "") splits s into
635: a[1]...a[length(s)] with each character a single element.
1.1 tholo 636:
1.7 millert 637: made the same changes for field-splitting if FS is "".
1.1 tholo 638:
1.7 millert 639: added nextfile, as in gawk: causes immediate advance to next
640: input file. (thanks to arnold robbins for inspiration and code).
1.1 tholo 641:
1.7 millert 642: small fixes to regexpr code: can now handle []], [[], and
643: variants; [] is now a syntax error, rather than matching
644: everything; [z-a] is now empty, not z. far from complete
645: or correct, however. (thanks to jeffrey friedl for pointing out
646: some awful behaviors.)
1.1 tholo 647:
1.7 millert 648: Apr 29, 1996:
1.12 otto 649: replaced uchar by uschar everywhere; apparently some compilers
1.7 millert 650: usurp this name and this causes conflicts.
1.1 tholo 651:
1.7 millert 652: fixed call to time in run.c (bltin); arg is time_t *.
1.1 tholo 653:
1.7 millert 654: replaced horrible pointer/long punning in b.c by a legitimate
655: union. should be safer on 64-bit machines and cleaner everywhere.
656: (thanks to nelson beebe for pointing out some of these problems.)
1.1 tholo 657:
1.7 millert 658: replaced nested comments by #if 0...#endif in run.c, lib.c.
1.1 tholo 659:
1.7 millert 660: removed getsval, setsval, execute macros from run.c and lib.c.
661: machines are 100x faster than they were when these macros were
662: first used.
1.1 tholo 663:
1.7 millert 664: revised filenames: awk.g.y => awkgram.y, awk.lx.l => awklex.l,
665: y.tab.[ch] => ytab.[ch], lex.yy.c => lexyy.c, all in the aid of
666: portability to nameless systems.
1.1 tholo 667:
1.7 millert 668: "make bundle" now includes yacc and lex output files for recipients
669: who don't have yacc or lex.
1.1 tholo 670:
1.7 millert 671: Aug 15, 1995:
672: initialized Cells in setsymtab more carefully; some fields
673: were not set. (thanks to purify, all of whose complaints i
674: think i now understand.)
1.1 tholo 675:
1.7 millert 676: fixed at least one error in gsub that looked at -1-th element
677: of an array when substituting for a null match (e.g., $).
1.1 tholo 678:
1.7 millert 679: delete arrayname is now legal; it clears the elements but leaves
680: the array, which may not be the right behavior.
1.1 tholo 681:
1.7 millert 682: modified makefile: my current make can't cope with the test used
683: to avoid unnecessary yacc invocations.
1.1 tholo 684:
1.7 millert 685: Jul 17, 1995:
686: added dynamically growing strings to awk.lx.l and b.c
687: to permit regular expressions to be much bigger.
688: the state arrays can still overflow.
1.1 tholo 689:
1.7 millert 690: Aug 24, 1994:
691: detect duplicate arguments in function definitions (mdm).
1.1 tholo 692:
1.7 millert 693: May 11, 1994:
694: trivial fix to printf to limit string size in sub().
1.1 tholo 695:
1.7 millert 696: Apr 22, 1994:
697: fixed yet another subtle self-assignment problem:
698: $1 = $2; $1 = $1 clobbered $1.
1.1 tholo 699:
1.7 millert 700: Regression tests now use private echo, to avoid quoting problems.
1.1 tholo 701:
1.7 millert 702: Feb 2, 1994:
703: changed error() to print line number as %d, not %g.
1.1 tholo 704:
1.7 millert 705: Jul 23, 1993:
706: cosmetic changes: increased sizes of some arrays,
707: reworded some error messages.
1.1 tholo 708:
1.7 millert 709: added CONVFMT as in posix (just replaced OFMT in getsval)
1.1 tholo 710:
1.7 millert 711: FILENAME is now "" until the first thing that causes a file
712: to be opened.
1.1 tholo 713:
1.7 millert 714: Nov 28, 1992:
715: deleted yyunput and yyoutput from proto.h;
716: different versions of lex give these different declarations.
1.1 tholo 717:
1.7 millert 718: May 31, 1992:
719: added -mr N and -mf N options: more record and fields.
720: these really ought to adjust automatically.
1.1 tholo 721:
1.7 millert 722: cleaned up some error messages; "out of space" now means
723: malloc returned NULL in all cases.
1.1 tholo 724:
1.7 millert 725: changed rehash so that if it runs out, it just returns;
726: things will continue to run slow, but maybe a bit longer.
1.1 tholo 727:
1.7 millert 728: Apr 24, 1992:
729: remove redundant close of stdin when using -f -.
1.1 tholo 730:
1.7 millert 731: got rid of core dump with -d; awk -d just prints date.
1.1 tholo 732:
1.7 millert 733: Apr 12, 1992:
734: added explicit check for /dev/std(in,out,err) in redirection.
735: unlike gawk, no /dev/fd/n yet.
1.1 tholo 736:
1.7 millert 737: added (file/pipe) builtin. hard to test satisfactorily.
738: not posix.
1.1 tholo 739:
1.7 millert 740: Feb 20, 1992:
741: recompile after abortive changes; should be unchanged.
1.1 tholo 742:
1.7 millert 743: Dec 2, 1991:
744: die-casting time: converted to ansi C, installed that.
1.1 tholo 745:
1.7 millert 746: Nov 30, 1991:
747: fixed storage leak in freefa, failing to recover [N]CCL.
748: thanks to Bill Jones (jones@cs.usask.ca)
1.1 tholo 749:
1.7 millert 750: Nov 19, 1991:
751: use RAND_MAX instead of literal in builtin().
1.1 tholo 752:
1.7 millert 753: Nov 12, 1991:
754: cranked up some fixed-size arrays in b.c, and added a test for
755: overflow in penter. thanks to mark larsen.
1.1 tholo 756:
1.7 millert 757: Sep 24, 1991:
758: increased buffer in gsub. a very crude fix to a general problem.
759: and again on Sep 26.
1.1 tholo 760:
1.7 millert 761: Aug 18, 1991:
762: enforce variable name syntax for commandline variables: has to
763: start with letter or _.
1.1 tholo 764:
1.7 millert 765: Jul 27, 1991:
766: allow newline after ; in for statements.
1.1 tholo 767:
1.7 millert 768: Jul 21, 1991:
769: fixed so that in self-assignment like $1=$1, side effects
770: like recomputing $0 take place. (this is getting subtle.)
1.1 tholo 771:
1.7 millert 772: Jun 30, 1991:
773: better test for detecting too-long output record.
1.1 tholo 774:
1.7 millert 775: Jun 2, 1991:
776: better defense against very long printf strings.
777: made break and continue illegal outside of loops.
1.1 tholo 778:
1.7 millert 779: May 13, 1991:
780: removed extra arg on gettemp, tempfree. minor error message rewording.
1.1 tholo 781:
782: May 6, 1991:
783: fixed silly bug in hex parsing in hexstr().
784: removed an apparently unnecessary test in isnumber().
785: warn about weird printf conversions.
786: fixed unchecked array overwrite in relex().
787:
788: changed for (i in array) to access elements in sorted order.
789: then unchanged it -- it really does run slower in too many cases.
790: left the code in place, commented out.
791:
1.7 millert 792: Feb 10, 1991:
793: check error status on all writes, to avoid banging on full disks.
1.1 tholo 794:
1.7 millert 795: Jan 28, 1991:
796: awk -f - reads the program from stdin.
1.1 tholo 797:
1.7 millert 798: Jan 11, 1991:
799: failed to set numeric state on $0 in cmd|getline context in run.c.
1.1 tholo 800:
1.7 millert 801: Nov 2, 1990:
802: fixed sleazy test for integrality in getsval; use modf.
1.1 tholo 803:
1.7 millert 804: Oct 29, 1990:
805: fixed sleazy buggy code in lib.c that looked (incorrectly) for
806: too long input lines.
1.1 tholo 807:
1.7 millert 808: Oct 14, 1990:
809: fixed the bug on p. 198 in which it couldn't deduce that an
810: argument was an array in some contexts. replaced the error
811: message in intest() by code that damn well makes it an array.
1.1 tholo 812:
1.7 millert 813: Oct 8, 1990:
814: fixed horrible bug: types and values were not preserved in
815: some kinds of self-assignment. (in assign().)
1.1 tholo 816:
1.7 millert 817: Aug 24, 1990:
818: changed NCHARS to 256 to handle 8-bit characters in strings
819: presented to match(), etc.
1.1 tholo 820:
1.7 millert 821: Jun 26, 1990:
822: changed struct rrow (awk.h) to use long instead of int for lval,
823: since cfoll() stores a pointer in it. now works better when int's
824: are smaller than pointers!
1.1 tholo 825:
1.7 millert 826: May 6, 1990:
827: AVA fixed the grammar so that ! is uniformly of the same precedence as
828: unary + and -. This renders illegal some constructs like !x=y, which
829: now has to be parenthesized as !(x=y), and makes others work properly:
830: !x+y is (!x)+y, and x!y is x !y, not two pattern-action statements.
831: (These problems were pointed out by Bob Lenk of Posix.)
1.1 tholo 832:
1.7 millert 833: Added \x to regular expressions (already in strings).
834: Limited octal to octal digits; \8 and \9 are not octal.
835: Centralized the code for parsing escapes in regular expressions.
836: Added a bunch of tests to T.re and T.sub to verify some of this.
1.1 tholo 837:
1.7 millert 838: Feb 9, 1990:
839: fixed null pointer dereference bug in main.c: -F[nothing]. sigh.
1.1 tholo 840:
1.7 millert 841: restored srand behavior: it returns the current seed.
1.1 tholo 842:
1.7 millert 843: Jan 18, 1990:
844: srand now returns previous seed value (0 to start).
1.1 tholo 845:
1.7 millert 846: Jan 5, 1990:
847: fix potential problem in tran.c -- something was freed,
848: then used in freesymtab.
1.1 tholo 849:
1.7 millert 850: Oct 18, 1989:
851: another try to get the max number of open files set with
852: relatively machine-independent code.
1.1 tholo 853:
1.7 millert 854: small fix to input() in case of multiple reads after EOF.
1.1 tholo 855:
1.7 millert 856: Oct 11, 1989:
857: FILENAME is now defined in the BEGIN block -- too many old
858: programs broke.
1.1 tholo 859:
1.7 millert 860: "-" means stdin in getline as well as on the commandline.
1.1 tholo 861:
1.7 millert 862: added a bunch of casts to the code to tell the truth about
863: char * vs. unsigned char *, a right royal pain. added a
864: setlocale call to the front of main, though probably no one
865: has it usefully implemented yet.
1.1 tholo 866:
1.7 millert 867: Aug 24, 1989:
868: removed redundant relational tests against nullnode if parse
869: tree already had a relational at that point.
1.1 tholo 870:
1.7 millert 871: Aug 11, 1989:
872: fixed bug: commandline variable assignment has to look like
873: var=something. (consider the man page for =, in file =.1)
1.1 tholo 874:
1.7 millert 875: changed number of arguments to functions to static arrays
876: to avoid repeated malloc calls.
1.1 tholo 877:
1.7 millert 878: Aug 2, 1989:
879: restored -F (space) separator
1.1 tholo 880:
1.7 millert 881: Jul 30, 1989:
882: added -v x=1 y=2 ... for immediate commandline variable assignment;
883: done before the BEGIN block for sure. they have to precede the
884: program if the program is on the commandline.
885: Modified Aug 2 to require a separate -v for each assignment.
1.1 tholo 886:
1.7 millert 887: Jul 10, 1989:
888: fixed ref-thru-zero bug in environment code in tran.c
1.1 tholo 889:
1.7 millert 890: Jun 23, 1989:
891: add newline to usage message.
1.1 tholo 892:
1.7 millert 893: Jun 14, 1989:
894: added some missing ansi printf conversion letters: %i %X %E %G.
895: no sensible meaning for h or L, so they may not do what one expects.
1.1 tholo 896:
1.7 millert 897: made %* conversions work.
1.1 tholo 898:
1.7 millert 899: changed x^y so that if n is a positive integer, it's done
900: by explicit multiplication, thus achieving maximum accuracy.
901: (this should be done by pow() but it seems not to be locally.)
902: done to x ^= y as well.
1.1 tholo 903:
1.7 millert 904: Jun 4, 1989:
905: ENVIRON array contains environment: if shell variable V=thing,
906: ENVIRON["V"] is "thing"
1.1 tholo 907:
1.7 millert 908: multiple -f arguments permitted. error reporting is naive.
909: (they were permitted before, but only the last was used.)
1.1 tholo 910:
1.7 millert 911: fixed a really stupid botch in the debugging macro dprintf
1.1 tholo 912:
1.7 millert 913: fixed order of evaluation of commandline assignments to match
914: what the book claims: an argument of the form x=e is evaluated
915: at the time it would have been opened if it were a filename (p 63).
916: this invalidates the suggested answer to ex 4-1 (p 195).
1.1 tholo 917:
1.7 millert 918: removed some code that permitted -F (space) fieldseparator,
919: since it didn't quite work right anyway. (restored aug 2)
1.1 tholo 920:
1.7 millert 921: Apr 27, 1989:
922: Line number now accumulated correctly for comment lines.
1.1 tholo 923:
1.7 millert 924: Apr 26, 1989:
925: Debugging output now includes a version date,
926: if one compiles it into the source each time.
1.1 tholo 927:
1.7 millert 928: Apr 9, 1989:
929: Changed grammar to prohibit constants as 3rd arg of sub and gsub;
930: prevents class of overwriting-a-constant errors. (Last one?)
931: This invalidates the "banana" example on page 43 of the book.
1.1 tholo 932:
1.7 millert 933: Added \a ("alert"), \v (vertical tab), \xhhh (hexadecimal),
934: as in ANSI, for strings. Rescinded the sloppiness that permitted
935: non-octal digits in \ooo. Warning: not all compilers and libraries
936: will be able to deal with \x correctly.
1.1 tholo 937:
1.7 millert 938: Jan 9, 1989:
939: Fixed bug that caused tempcell list to contain a duplicate.
940: The fix is kludgy.
1.1 tholo 941:
1.7 millert 942: Dec 17, 1988:
943: Catches some more commandline errors in main.
944: Removed redundant decl of modf in run.c (confuses some compilers).
945: Warning: there's no single declaration of malloc, etc., in awk.h
946: that seems to satisfy all compilers.
1.1 tholo 947:
1.7 millert 948: Dec 7, 1988:
949: Added a bit of code to error printing to avoid printing nulls.
950: (Not clear that it actually would.)
1.1 tholo 951:
1.7 millert 952: Nov 27, 1988:
953: With fear and trembling, modified the grammar to permit
954: multiple pattern-action statements on one line without
955: an explicit separator. By definition, this capitulation
956: to the ghost of ancient implementations remains undefined
957: and thus subject to change without notice or apology.
958: DO NOT COUNT ON IT.
1.1 tholo 959:
1.7 millert 960: Oct 30, 1988:
961: Fixed bug in call() that failed to recover storage.
1.1 tholo 962:
1.7 millert 963: A warning is now generated if there are more arguments
964: in the call than in the definition (in lieu of fixing
965: another storage leak).
1.2 millert 966:
1.7 millert 967: Oct 20, 1988:
968: Fixed %c: if expr is numeric, use numeric value;
969: otherwise print 1st char of string value. still
970: doesn't work if the value is 0 -- won't print \0.
1.2 millert 971:
1.7 millert 972: Added a few more checks for running out of malloc.
1.2 millert 973:
1.7 millert 974: Oct 12, 1988:
975: Fixed bug in call() that freed local arrays twice.
1.5 kstailey 976:
1.7 millert 977: Fixed to handle deletion of non-existent array right;
978: complains about attempt to delete non-array element.
1.6 kstailey 979:
1.7 millert 980: Sep 30, 1988:
981: Now guarantees to evaluate all arguments of built-in
982: functions, as in C; the appearance is that arguments
983: are evaluated before the function is called. Places
984: affected are sub (gsub was ok), substr, printf, and
985: all the built-in arithmetic functions in bltin().
986: A warning is generated if a bltin() is called with
987: the wrong number of arguments.
1.6 kstailey 988:
1.7 millert 989: This requires changing makeprof on p167 of the book.
1.6 kstailey 990:
1.7 millert 991: Aug 23, 1988:
992: setting FILENAME in BEGIN caused core dump, apparently
993: because it was freeing space not allocated by malloc.
1.6 kstailey 994:
1.7 millert 995: July 24, 1988:
996: fixed egregious error in toupper/tolower functions.
997: still subject to rescinding, however.
1.6 kstailey 998:
1.7 millert 999: July 2, 1988:
1000: flush stdout before opening file or pipe
1.6 kstailey 1001:
1.7 millert 1002: July 2, 1988:
1003: performance bug in b.c/cgoto(): not freeing some sets of states.
1004: partial fix only right now, and the number of states increased
1005: to make it less obvious.
1.6 kstailey 1006:
1.7 millert 1007: June 1, 1988:
1008: check error status on close
1.6 kstailey 1009:
1.7 millert 1010: May 28, 1988:
1011: srand returns seed value it's using.
1012: see 1/18/90
1.6 kstailey 1013:
1.7 millert 1014: May 22, 1988:
1015: Removed limit on depth of function calls.
1.6 kstailey 1016:
1.7 millert 1017: May 10, 1988:
1018: Fixed lib.c to permit _ in commandline variable names.
1.6 kstailey 1019:
1.7 millert 1020: Mar 25, 1988:
1021: main.c fixed to recognize -- as terminator of command-
1022: line options. Illegal options flagged.
1023: Error reporting slightly cleaned up.
1.6 kstailey 1024:
1.7 millert 1025: Dec 2, 1987:
1026: Newer C compilers apply a strict scope rule to extern
1027: declarations within functions. Two extern declarations in
1028: lib.c and tran.c have been moved to obviate this problem.
1.6 kstailey 1029:
1.7 millert 1030: Oct xx, 1987:
1031: Reluctantly added toupper and tolower functions.
1032: Subject to rescinding without notice.
1.6 kstailey 1033:
1.7 millert 1034: Sep 17, 1987:
1035: Error-message printer had printf(s) instead of
1036: printf("%s",s); got core dumps when the message
1037: included a %.
1.6 kstailey 1038:
1.7 millert 1039: Sep 12, 1987:
1040: Very long printf strings caused core dump;
1041: fixed aprintf, asprintf, format to catch them.
1042: Can still get a core dump in printf itself.
1.6 kstailey 1043:
1044:
![[BACK]](/icons/back.gif){kind=icon}
Return to FIXES CVS log ![[TXT]](/icons/text.gif){kind=icon}
![[DIR]](/icons/dir.gif){kind=icon}
Up to [local] / src / usr.bin / awk