=================================================================== RCS file: /cvsrepo/anoncvs/cvs/src/usr.bin/calendar/io.c,v retrieving revision 1.10 retrieving revision 1.50 diff -u -r1.10 -r1.50 --- src/usr.bin/calendar/io.c 2000/12/07 19:36:37 1.10 +++ src/usr.bin/calendar/io.c 2021/10/24 21:24:16 1.50 @@ -1,4 +1,4 @@ -/* $OpenBSD: io.c,v 1.10 2000/12/07 19:36:37 deraadt Exp $ */ +/* $OpenBSD: io.c,v 1.50 2021/10/24 21:24:16 deraadt Exp $ */ /* * Copyright (c) 1989, 1993, 1994 @@ -12,11 +12,7 @@ * 2. Redistributions in binary form must reproduce the above copyright * notice, this list of conditions and the following disclaimer in the * documentation and/or other materials provided with the distribution. - * 3. All advertising materials mentioning features or use of this software - * must display the following acknowledgement: - * This product includes software developed by the University of - * California, Berkeley and its contributors. - * 4. Neither the name of the University nor the names of its contributors + * 3. Neither the name of the University nor the names of its contributors * may be used to endorse or promote products derived from this software * without specific prior written permission. * @@ -33,71 +29,48 @@ * SUCH DAMAGE. */ -#ifndef lint -static const char copyright[] = -"@(#) Copyright (c) 1989, 1993\n\ - The Regents of the University of California. All rights reserved.\n"; -#endif /* not lint */ - -#ifndef lint -#if 0 -static const char sccsid[] = "@(#)calendar.c 8.3 (Berkeley) 3/25/94"; -#else -static char rcsid[] = "$OpenBSD: io.c,v 1.10 2000/12/07 19:36:37 deraadt Exp $"; -#endif -#endif /* not lint */ - -#include #include #include #include #include #include -#include #include #include #include +#include #include #include #include #include #include -#include #include +#include #include "pathnames.h" #include "calendar.h" -char *calendarFile = "calendar"; /* default calendar file */ -char *calendarHome = ".calendar"; /* HOME */ -char *calendarNoMail = "nomail"; /* don't sent mail if this file exist */ - struct iovec header[] = { - {"From: ", 6}, - {NULL, 0}, - {" (Reminder Service)\nTo: ", 24}, - {NULL, 0}, - {"\nSubject: ", 10}, - {NULL, 0}, - {"'s Calendar\nPrecedence: bulk\n\n", 30}, + { "From: ", 6 }, + { NULL, 0 }, + { " (Reminder Service)\nTo: ", 24 }, + { NULL, 0 }, + { "\nSubject: ", 10 }, + { NULL, 0 }, + { "'s Calendar\nPrecedence: bulk\n", 29 }, + { "Auto-Submitted: auto-generated\n\n", 32 }, }; -int openf(char *path); - void -cal() +cal(void) { - register int printing; - register char *p; - FILE *fp; - int ch, l, i; - int var; - char buf[2048 + 1]; + int ch, l, i, bodun = 0, bodun_maybe = 0, var, printing; struct event *events, *cur_evt, *ev1, *tmp; + char buf[2048 + 1], *prefix = NULL, *p; struct match *m; + FILE *fp; events = NULL; cur_evt = NULL; @@ -116,27 +89,61 @@ if (strncmp(buf, "LANG=", 5) == 0) { (void) setlocale(LC_ALL, buf + 5); setnnames(); + if (!strcmp(buf + 5, "ru_RU.UTF-8") || + !strcmp(buf + 5, "uk_UA.UTF-8") || + !strcmp(buf + 5, "by_BY.UTF-8")) { + bodun_maybe++; + bodun = 0; + free(prefix); + prefix = NULL; + } else + bodun_maybe = 0; continue; + } else if (strncmp(buf, "CALENDAR=", 9) == 0) { + char *ep; + + if (buf[9] == '\0') + calendar = 0; + else if (!strcasecmp(buf + 9, "julian")) { + calendar = JULIAN; + errno = 0; + julian = strtoul(buf + 14, &ep, 10); + if (buf[0] == '\0' || *ep != '\0') + julian = 13; + if ((errno == ERANGE && julian == ULONG_MAX) || + julian > 14) + errx(1, "Julian calendar offset is too large"); + } else if (!strcasecmp(buf + 9, "gregorian")) + calendar = GREGORIAN; + else if (!strcasecmp(buf + 9, "lunar")) + calendar = LUNAR; + } else if (bodun_maybe && strncmp(buf, "BODUN=", 6) == 0) { + bodun++; + free(prefix); + if ((prefix = strdup(buf + 6)) == NULL) + err(1, NULL); + continue; } /* User defined names for special events */ if ((p = strchr(buf, '='))) { for (i = 0; i < NUMEV; i++) { - if (strncasecmp(buf, spev[i].name, spev[i].nlen) == 0 && - (p - buf == spev[i].nlen) && buf[spev[i].nlen + 1]) { - p++; - if (spev[i].uname != NULL) + if (strncasecmp(buf, spev[i].name, + spev[i].nlen) == 0 && + (p - buf == spev[i].nlen) && + buf[spev[i].nlen + 1]) { + p++; free(spev[i].uname); - if ((spev[i].uname = strdup(p)) == NULL) - errx(1, "cannot allocate memory"); - spev[i].ulen = strlen(p); - i = NUMEV + 1; + if ((spev[i].uname = strdup(p)) == NULL) + err(1, NULL); + spev[i].ulen = strlen(p); + i = NUMEV + 1; + } } - } - if (i > NUMEV) - continue; + if (i > NUMEV) + continue; } if (buf[0] != '\t') { - printing = (m = isnow(buf)) ? 1 : 0; + printing = (m = isnow(buf, bodun)) ? 1 : 0; if ((p = strchr(buf, '\t')) == NULL) { printing = 0; continue; @@ -149,40 +156,45 @@ var = 0; if (printing) { struct match *foo; - + ev1 = NULL; while (m) { - cur_evt = (struct event *) malloc(sizeof(struct event)); - if (cur_evt == NULL) - errx(1, "cannot allocate memory"); + cur_evt = malloc(sizeof(struct event)); + if (cur_evt == NULL) + err(1, NULL); - cur_evt->when = m->when; - snprintf(cur_evt->print_date, - sizeof(cur_evt->print_date), "%s%c", - m->print_date, (var + m->var) ? '*' : ' '); - if (ev1) { - cur_evt->desc = ev1->desc; - cur_evt->ldesc = NULL; - } else { - if ((cur_evt->ldesc = strdup(p)) == NULL) - errx(1, "cannot allocate memory"); - cur_evt->desc = &(cur_evt->ldesc); - ev1 = cur_evt; + cur_evt->when = m->when; + snprintf(cur_evt->print_date, + sizeof(cur_evt->print_date), "%s%c", + m->print_date, (var + m->var) ? '*' : ' '); + if (ev1) { + cur_evt->desc = ev1->desc; + cur_evt->ldesc = NULL; + } else { + if (m->bodun && prefix) { + if (asprintf(&cur_evt->ldesc, + "\t%s %s", prefix, + p + 1) == -1) + err(1, NULL); + } else if ((cur_evt->ldesc = + strdup(p)) == NULL) + err(1, NULL); + cur_evt->desc = &(cur_evt->ldesc); + ev1 = cur_evt; + } + insert(&events, cur_evt); + foo = m; + m = m->next; + free(foo); } - insert(&events, cur_evt); - foo = m; - m = m->next; - free(foo); - } } + } else if (printing) { + if (asprintf(&p, "%s\n%s", ev1->ldesc, + buf) == -1) + err(1, NULL); + free(ev1->ldesc); + ev1->ldesc = p; } - else if (printing) { - if ((ev1->ldesc = realloc(ev1->ldesc, - (2 + strlen(ev1->ldesc) + strlen(buf)))) == NULL) - errx(1, "cannot allocate memory"); - strcat(ev1->ldesc, "\n"); - strcat(ev1->ldesc, buf); - } } tmp = events; while (tmp) { @@ -192,8 +204,7 @@ tmp = events; while (tmp) { events = tmp; - if (tmp->ldesc) - free(tmp->ldesc); + free(tmp->ldesc); tmp = tmp->next; free(events); } @@ -201,34 +212,34 @@ } int -getfield(p, endp, flags) - char *p, **endp; - int *flags; +getfield(char *p, char **endp, int *flags) { int val, var, i; char *start, savech; - for (; !isdigit(*p) && !isalpha(*p) && *p != '*' && *p != '\t'; ++p) + for (; !isdigit((unsigned char)*p) && !isalpha((unsigned char)*p) && + *p != '*' && *p != '\t'; ++p) ; if (*p == '*') { /* `*' is every month */ *flags |= F_ISMONTH; *endp = p+1; return (-1); /* means 'every month' */ } - if (isdigit(*p)) { + if (isdigit((unsigned char)*p)) { val = strtol(p, &p, 10); /* if 0, it's failure */ - for (; !isdigit(*p) && !isalpha(*p) && *p != '*'; ++p) + for (; !isdigit((unsigned char)*p) && + !isalpha((unsigned char)*p) && *p != '*'; ++p) ; *endp = p; return (val); } - for (start = p; isalpha(*++p);) + for (start = p; isalpha((unsigned char)*++p);) ; /* Sunday-1 */ if (*p == '+' || *p == '-') - for(; isdigit(*++p);) - ; + for(; isdigit((unsigned char)*++p); ) + ; savech = *p; *p = '\0'; @@ -239,16 +250,16 @@ /* Day */ else if ((val = getday(start)) != 0) { - *flags |= F_ISDAY; + *flags |= F_ISDAY; - /* variable weekday */ - if ((var = getdayvar(start)) != 0) { - if (var <= 5 && var >= -4) - val += var * 10; + /* variable weekday */ + if ((var = getdayvar(start)) != 0) { + if (var <= 5 && var >= -4) + val += var * 10; #ifdef DEBUG - printf("var: %d\n", var); + printf("var: %d\n", var); #endif - } + } } /* Try specials (Easter, Paskha, ...) */ @@ -266,91 +277,69 @@ } } if (i > NUMEV) { - switch(*start) { + const char *errstr; + + switch (*start) { case '-': case '+': - var = atoi(start); - if (var > 365 || var < -365) - return (0); /* Someone is just being silly */ - val += (NUMEV + 1) * var; - /* We add one to the matching event and multiply by - * (NUMEV + 1) so as not to return 0 if there's a match. - * val will overflow if there is an obscenely large - * number of special events. */ - break; + var = strtonum(start + 1, 0, 365, &errstr); + if (errstr) + return (0); /* Someone is just being silly */ + if (*start == '-') + var = -var; + val += (NUMEV + 1) * var; + /* We add one to the matching event and multiply by + * (NUMEV + 1) so as not to return 0 if there's a match. + * val will overflow if there is an obscenely large + * number of special events. */ + break; } - *flags |= F_SPECIAL; + *flags |= F_SPECIAL; } if (!(*flags & F_SPECIAL)) { - /* undefined rest */ + /* undefined rest */ *p = savech; return (0); } } - for (*p = savech; !isdigit(*p) && !isalpha(*p) && *p != '*' && *p != '\t'; ++p) + for (*p = savech; !isdigit((unsigned char)*p) && + !isalpha((unsigned char)*p) && *p != '*' && *p != '\t'; ++p) ; *endp = p; return (val); } -char path[MAXPATHLEN]; -int -openf(path) - char *path; +FILE * +opencal(void) { + int pdes[2], fdin; struct stat st; - int fd; - fd = open(path, O_RDONLY|O_NONBLOCK); - if (fd == -1) - return (-1); - if (fstat(fd, &st) == -1) { - close(fd); - return (-1); - } - if ((st.st_mode & S_IFMT) != S_IFREG) { - close (fd); - return (-1); - } - - fcntl(fd, F_SETFD, fcntl(fd, F_GETFD, 0) &~ O_NONBLOCK); - return (fd); -} - -FILE * -opencal() -{ - int fd, pdes[2]; - int fdin; - struct stat sbuf; - /* open up calendar file as stdin */ - if ((fdin = openf(calendarFile)) == -1) { - if (doall) { - if (chdir(calendarHome) != 0) - return (NULL); - if (stat(calendarNoMail, &sbuf) == 0) - return (NULL); - if ((fdin = openf(calendarFile)) == -1) - return (NULL); - } else { + if ((fdin = open(calendarFile, O_RDONLY)) == -1 || + fstat(fdin, &st) == -1 || !S_ISREG(st.st_mode)) { + if (!doall) { char *home = getenv("HOME"); if (home == NULL || *home == '\0') errx(1, "cannot get home directory"); if (!(chdir(home) == 0 && chdir(calendarHome) == 0 && - (fdin = openf(calendarFile)) != -1)) - errx(1, "no calendar file: ``%s'' or ``~/%s/%s", + (fdin = open(calendarFile, O_RDONLY)) != -1)) + errx(1, "no calendar file: \"%s\" or \"~/%s/%s\"", calendarFile, calendarHome, calendarFile); } } - if (pipe(pdes) < 0) + + if (pipe(pdes) == -1) { + close(fdin); return (NULL); + } switch (vfork()) { case -1: /* error */ (void)close(pdes[0]); (void)close(pdes[1]); + close(fdin); return (NULL); case 0: dup2(fdin, STDIN_FILENO); @@ -360,9 +349,20 @@ (void)close(pdes[1]); } (void)close(pdes[0]); - (void)setuid(geteuid()); - (void)setgid(getegid()); - execl(_PATH_CPP, "cpp", "-P", "-I.", _PATH_INCLUDE, NULL); + /* + * Set stderr to /dev/null. Necessary so that cron does not + * wait for cpp to finish if it's running calendar -a. + */ + if (doall) { + int fderr; + fderr = open(_PATH_DEVNULL, O_WRONLY); + if (fderr == -1) + _exit(0); + (void)dup2(fderr, STDERR_FILENO); + (void)close(fderr); + } + execl(_PATH_CPP, "cpp", "-traditional", "-undef", "-U__GNUC__", + "-P", "-I.", _PATH_INCLUDE, (char *)NULL); warn(_PATH_CPP); _exit(1); } @@ -376,19 +376,16 @@ return (stdout); /* set output to a temporary file, so if no output don't send mail */ - (void)snprintf(path, sizeof(path), "%s/_calXXXXXX", _PATH_TMP); - if ((fd = mkstemp(path)) < 0) - return (NULL); - return (fdopen(fd, "w+")); + return(tmpfile()); } void -closecal(fp) - FILE *fp; +closecal(FILE *fp) { struct stat sbuf; int nread, pdes[2], status; char buf[1024]; + pid_t pid = -1; if (!doall) return; @@ -396,9 +393,9 @@ (void)rewind(fp); if (fstat(fileno(fp), &sbuf) || !sbuf.st_size) goto done; - if (pipe(pdes) < 0) + if (pipe(pdes) == -1) goto done; - switch (vfork()) { + switch ((pid = vfork())) { case -1: /* error */ (void)close(pdes[0]); (void)close(pdes[1]); @@ -410,10 +407,8 @@ (void)close(pdes[0]); } (void)close(pdes[1]); - (void)setuid(geteuid()); - (void)setgid(getegid()); execl(_PATH_SENDMAIL, "sendmail", "-i", "-t", "-F", - "\"Reminder Service\"", NULL); + "\"Reminder Service\"", (char *)NULL); warn(_PATH_SENDMAIL); _exit(1); } @@ -422,21 +417,22 @@ header[1].iov_base = header[3].iov_base = pw->pw_name; header[1].iov_len = header[3].iov_len = strlen(pw->pw_name); - writev(pdes[1], header, 7); + writev(pdes[1], header, 8); while ((nread = read(fileno(fp), buf, sizeof(buf))) > 0) (void)write(pdes[1], buf, nread); (void)close(pdes[1]); done: (void)fclose(fp); - (void)unlink(path); - while (wait(&status) >= 0) - ; + if (pid != -1) { + while (waitpid(pid, &status, 0) == -1) { + if (errno != EINTR) + break; + } + } } void -insert(head, cur_evt) - struct event **head; - struct event *cur_evt; +insert(struct event **head, struct event *cur_evt) { struct event *tmp, *tmp2;