=================================================================== RCS file: /cvsrepo/anoncvs/cvs/src/usr.bin/calendar/io.c,v retrieving revision 1.29 retrieving revision 1.42 diff -u -r1.29 -r1.42 --- src/usr.bin/calendar/io.c 2005/04/15 14:28:56 1.29 +++ src/usr.bin/calendar/io.c 2015/10/23 12:36:23 1.42 @@ -1,4 +1,4 @@ -/* $OpenBSD: io.c,v 1.29 2005/04/15 14:28:56 otto Exp $ */ +/* $OpenBSD: io.c,v 1.42 2015/10/23 12:36:23 deraadt Exp $ */ /* * Copyright (c) 1989, 1993, 1994 @@ -29,21 +29,6 @@ * SUCH DAMAGE. */ -#ifndef lint -static const char copyright[] = -"@(#) Copyright (c) 1989, 1993\n\ - The Regents of the University of California. All rights reserved.\n"; -#endif /* not lint */ - -#ifndef lint -#if 0 -static const char sccsid[] = "@(#)calendar.c 8.3 (Berkeley) 3/25/94"; -#else -static const char rcsid[] = "$OpenBSD: io.c,v 1.29 2005/04/15 14:28:56 otto Exp $"; -#endif -#endif /* not lint */ - -#include #include #include #include @@ -59,36 +44,33 @@ #include #include #include -#include #include +#include #include "pathnames.h" #include "calendar.h" struct iovec header[] = { - {"From: ", 6}, - {NULL, 0}, - {" (Reminder Service)\nTo: ", 24}, - {NULL, 0}, - {"\nSubject: ", 10}, - {NULL, 0}, - {"'s Calendar\nPrecedence: bulk\n\n", 30}, + { "From: ", 6 }, + { NULL, 0 }, + { " (Reminder Service)\nTo: ", 24 }, + { NULL, 0 }, + { "\nSubject: ", 10 }, + { NULL, 0 }, + { "'s Calendar\nPrecedence: bulk\n", 29 }, + { "Auto-Submitted: auto-generated\n\n", 32 }, }; void cal(void) { - int printing; - char *p; - FILE *fp; - int ch, l, i, bodun = 0, bodun_maybe = 0; - int var; - char buf[2048 + 1], *prefix = NULL; + int ch, l, i, bodun = 0, bodun_maybe = 0, var, printing; struct event *events, *cur_evt, *ev1, *tmp; + char buf[2048 + 1], *prefix = NULL, *p; struct match *m; - size_t nlen; + FILE *fp; events = NULL; cur_evt = NULL; @@ -107,7 +89,11 @@ if (strncmp(buf, "LANG=", 5) == 0) { (void) setlocale(LC_ALL, buf + 5); setnnames(); - if (!strcmp(buf + 5, "ru_RU.KOI8-R") || + /* XXX remove KOI8 lines after 5.9 is out */ + if (!strcmp(buf + 5, "ru_RU.UTF-8") || + !strcmp(buf + 5, "uk_UA.UTF-8") || + !strcmp(buf + 5, "by_BY.UTF-8") || + !strcmp(buf + 5, "ru_RU.KOI8-R") || !strcmp(buf + 5, "uk_UA.KOI8-U") || !strcmp(buf + 5, "by_BY.KOI8-B")) { bodun_maybe++; @@ -147,19 +133,21 @@ /* User defined names for special events */ if ((p = strchr(buf, '='))) { for (i = 0; i < NUMEV; i++) { - if (strncasecmp(buf, spev[i].name, spev[i].nlen) == 0 && - (p - buf == spev[i].nlen) && buf[spev[i].nlen + 1]) { - p++; - if (spev[i].uname != NULL) - free(spev[i].uname); - if ((spev[i].uname = strdup(p)) == NULL) - err(1, NULL); - spev[i].ulen = strlen(p); - i = NUMEV + 1; + if (strncasecmp(buf, spev[i].name, + spev[i].nlen) == 0 && + (p - buf == spev[i].nlen) && + buf[spev[i].nlen + 1]) { + p++; + if (spev[i].uname != NULL) + free(spev[i].uname); + if ((spev[i].uname = strdup(p)) == NULL) + err(1, NULL); + spev[i].ulen = strlen(p); + i = NUMEV + 1; + } } - } - if (i > NUMEV) - continue; + if (i > NUMEV) + continue; } if (buf[0] != '\t') { printing = (m = isnow(buf, bodun)) ? 1 : 0; @@ -175,48 +163,44 @@ var = 0; if (printing) { struct match *foo; - + ev1 = NULL; while (m) { - cur_evt = (struct event *) malloc(sizeof(struct event)); - if (cur_evt == NULL) - err(1, NULL); + cur_evt = malloc(sizeof(struct event)); + if (cur_evt == NULL) + err(1, NULL); - cur_evt->when = m->when; - snprintf(cur_evt->print_date, - sizeof(cur_evt->print_date), "%s%c", - m->print_date, (var + m->var) ? '*' : ' '); - if (ev1) { - cur_evt->desc = ev1->desc; - cur_evt->ldesc = NULL; - } else { - if (m->bodun && prefix) { - int l1 = strlen(prefix); - int l2 = strlen(p); - int len = l1 + l2 + 2; - if ((cur_evt->ldesc = - malloc(len)) == NULL) + cur_evt->when = m->when; + snprintf(cur_evt->print_date, + sizeof(cur_evt->print_date), "%s%c", + m->print_date, (var + m->var) ? '*' : ' '); + if (ev1) { + cur_evt->desc = ev1->desc; + cur_evt->ldesc = NULL; + } else { + if (m->bodun && prefix) { + if (asprintf(&cur_evt->ldesc, + "\t%s %s", prefix, + p + 1) == -1) + err(1, NULL); + } else if ((cur_evt->ldesc = + strdup(p)) == NULL) err(1, NULL); - snprintf(cur_evt->ldesc, len, - "\t%s %s", prefix, p + 1); - } else if ((cur_evt->ldesc = - strdup(p)) == NULL) - err(1, NULL); - cur_evt->desc = &(cur_evt->ldesc); - ev1 = cur_evt; + cur_evt->desc = &(cur_evt->ldesc); + ev1 = cur_evt; + } + insert(&events, cur_evt); + foo = m; + m = m->next; + free(foo); } - insert(&events, cur_evt); - foo = m; - m = m->next; - free(foo); - } } - } - else if (printing) { - nlen = strlen(ev1->ldesc) + strlen(buf) + 2; - if ((ev1->ldesc = realloc(ev1->ldesc, nlen)) == NULL) + } else if (printing) { + if (asprintf(&p, "%s\n%s", ev1->ldesc, + buf) == -1) err(1, NULL); - snprintf(ev1->ldesc, nlen, "%s\n%s", ev1->ldesc, buf); + free(ev1->ldesc); + ev1->ldesc = p; } } tmp = events; @@ -236,34 +220,34 @@ } int -getfield(p, endp, flags) - char *p, **endp; - int *flags; +getfield(char *p, char **endp, int *flags) { int val, var, i; char *start, savech; - for (; !isdigit(*p) && !isalpha(*p) && *p != '*' && *p != '\t'; ++p) + for (; !isdigit((unsigned char)*p) && !isalpha((unsigned char)*p) && + *p != '*' && *p != '\t'; ++p) ; if (*p == '*') { /* `*' is every month */ *flags |= F_ISMONTH; *endp = p+1; return (-1); /* means 'every month' */ } - if (isdigit(*p)) { + if (isdigit((unsigned char)*p)) { val = strtol(p, &p, 10); /* if 0, it's failure */ - for (; !isdigit(*p) && !isalpha(*p) && *p != '*'; ++p) + for (; !isdigit((unsigned char)*p) && + !isalpha((unsigned char)*p) && *p != '*'; ++p) ; *endp = p; return (val); } - for (start = p; isalpha(*++p);) + for (start = p; isalpha((unsigned char)*++p);) ; /* Sunday-1 */ if (*p == '+' || *p == '-') - for(; isdigit(*++p);) - ; + for(; isdigit((unsigned char)*++p); ) + ; savech = *p; *p = '\0'; @@ -274,16 +258,16 @@ /* Day */ else if ((val = getday(start)) != 0) { - *flags |= F_ISDAY; + *flags |= F_ISDAY; - /* variable weekday */ - if ((var = getdayvar(start)) != 0) { - if (var <= 5 && var >= -4) - val += var * 10; + /* variable weekday */ + if ((var = getdayvar(start)) != 0) { + if (var <= 5 && var >= -4) + val += var * 10; #ifdef DEBUG - printf("var: %d\n", var); + printf("var: %d\n", var); #endif - } + } } /* Try specials (Easter, Paskha, ...) */ @@ -301,28 +285,33 @@ } } if (i > NUMEV) { - switch(*start) { + const char *errstr; + + switch (*start) { case '-': case '+': - var = atoi(start); - if (var > 365 || var < -365) - return (0); /* Someone is just being silly */ - val += (NUMEV + 1) * var; - /* We add one to the matching event and multiply by - * (NUMEV + 1) so as not to return 0 if there's a match. - * val will overflow if there is an obscenely large - * number of special events. */ - break; + var = strtonum(start + 1, 0, 365, &errstr); + if (errstr) + return (0); /* Someone is just being silly */ + if (*start == '-') + var = -var; + val += (NUMEV + 1) * var; + /* We add one to the matching event and multiply by + * (NUMEV + 1) so as not to return 0 if there's a match. + * val will overflow if there is an obscenely large + * number of special events. */ + break; } - *flags |= F_SPECIAL; + *flags |= F_SPECIAL; } if (!(*flags & F_SPECIAL)) { - /* undefined rest */ + /* undefined rest */ *p = savech; return (0); } } - for (*p = savech; !isdigit(*p) && !isalpha(*p) && *p != '*' && *p != '\t'; ++p) + for (*p = savech; !isdigit((unsigned char)*p) && + !isalpha((unsigned char)*p) && *p != '*' && *p != '\t'; ++p) ; *endp = p; return (val); @@ -365,7 +354,7 @@ (void)close(pdes[1]); } (void)close(pdes[0]); - /* + /* * Set stderr to /dev/null. Necessary so that cron does not * wait for cpp to finish if it's running calendar -a. */ @@ -396,8 +385,7 @@ } void -closecal(fp) - FILE *fp; +closecal(FILE *fp) { struct stat sbuf; int nread, pdes[2], status; @@ -433,7 +421,7 @@ header[1].iov_base = header[3].iov_base = pw->pw_name; header[1].iov_len = header[3].iov_len = strlen(pw->pw_name); - writev(pdes[1], header, 7); + writev(pdes[1], header, 8); while ((nread = read(fileno(fp), buf, sizeof(buf))) > 0) (void)write(pdes[1], buf, nread); (void)close(pdes[1]); @@ -444,9 +432,7 @@ void -insert(head, cur_evt) - struct event **head; - struct event *cur_evt; +insert(struct event **head, struct event *cur_evt) { struct event *tmp, *tmp2;