OpenBSD CVS

CVS log for src/usr.bin/cdio/cddb.c


[BACK] Up to [local] / src / usr.bin / cdio

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.23 / (download) - annotate - [select for diffs], Fri Jun 26 19:51:14 2020 UTC (3 years, 10 months ago) by naddy
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, HEAD
Changes since 1.22: +2 -2 lines
Diff to previous 1.22 (colored)

Switch cdio's default CDDB database to gnudb.gnudb.org:8880.
The freedb.org CD track database has been discontinued.

Retire cddb/888 from /etc/services.  Nothing uses this any longer.
gnudb.org uses the "cddbp-alt" port of 8880, but we don't need a
services(5) entry for a single site.

ok deraadt@

Revision 1.22 / (download) - annotate - [select for diffs], Thu Dec 7 02:08:44 2017 UTC (6 years, 5 months ago) by krw
Branch: MAIN
CVS Tags: OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3
Changes since 1.21: +2 -2 lines
Diff to previous 1.21 (colored)

Let it compile again.

Revision 1.21 / (download) - annotate - [select for diffs], Wed Dec 6 17:15:43 2017 UTC (6 years, 5 months ago) by espie
Branch: MAIN
Changes since 1.20: +2 -2 lines
Diff to previous 1.20 (colored)

be consistent in where we call fflush

okay millert@

Revision 1.20 / (download) - annotate - [select for diffs], Fri Jan 16 06:40:06 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9, OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.19: +3 -3 lines
Diff to previous 1.19 (colored)

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible.  Annotate <sys/param.h> lines with their current reasons.  Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc.  Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution.  These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Revision 1.19 / (download) - annotate - [select for diffs], Mon Jan 6 12:38:10 2014 UTC (10 years, 4 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5
Changes since 1.18: +3 -1 lines
Diff to previous 1.18 (colored)

fgetln may return incomplete lines (Tobias Stoeckmann <tobias@stoeckmann.org>)

simple solution: error out. This is not a correct cddb answer anyways.

Revision 1.18 / (download) - annotate - [select for diffs], Sat Jan 4 15:39:17 2014 UTC (10 years, 4 months ago) by tobias
Branch: MAIN
Changes since 1.17: +7 -5 lines
Diff to previous 1.17 (colored)

Properly validate index value received from CDDB server.

ok deraadt@, millert@

Revision 1.17 / (download) - annotate - [select for diffs], Thu Mar 7 16:54:28 2013 UTC (11 years, 2 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_5_4_BASE, OPENBSD_5_4
Changes since 1.16: +9 -2 lines
Diff to previous 1.16 (colored)

fix atrocious code, do socket -> FILE* conversion correctly, with proper
error handling.

okay millert@, otto@

Revision 1.16 / (download) - annotate - [select for diffs], Wed Apr 6 11:36:26 2011 UTC (13 years, 1 month ago) by miod
Branch: MAIN
CVS Tags: OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0
Changes since 1.15: +2 -2 lines
Diff to previous 1.15 (colored)

Avoid using NULL in non-pointer contexts: use 0 for integer values and '\0'
for chars.

Revision 1.15 / (download) - annotate - [select for diffs], Sun Apr 27 23:06:40 2008 UTC (16 years ago) by fgsch
Branch: MAIN
CVS Tags: OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7, OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4
Changes since 1.14: +5 -3 lines
Diff to previous 1.14 (colored)

o if no argument is passed to cddbinfo, treat it as 0 in order to print
  the list in case of multiple/inexact matches
o if the argument to cddb is invalid, do not exit, just print and error
  and ignore the command
espie@ ok.

Revision 1.14 / (download) - annotate - [select for diffs], Mon Sep 10 16:31:35 2007 UTC (16 years, 8 months ago) by cloder
Branch: MAIN
CVS Tags: OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.13: +2 -2 lines
Diff to previous 1.13 (colored)

Make sure we don't skip the code which sends the QUIT command to the CDDB
server and validates the returned track names. Unreachable code spotted
by lint.
OK krw@, deraadt@, espie@

Revision 1.13 / (download) - annotate - [select for diffs], Sun Sep 2 15:19:31 2007 UTC (16 years, 8 months ago) by deraadt
Branch: MAIN
Changes since 1.12: +2 -2 lines
Diff to previous 1.12 (colored)

use calloc() to avoid malloc(n * m) overflows; checked by djm canacar jsg

Revision 1.12 / (download) - annotate - [select for diffs], Tue May 1 01:26:12 2007 UTC (17 years ago) by jdixon
Branch: MAIN
CVS Tags: OPENBSD_4_2_BASE, OPENBSD_4_2
Changes since 1.11: +5 -2 lines
Diff to previous 1.11 (colored)

use strtonum; ok millert@

Revision 1.11 / (download) - annotate - [select for diffs], Mon Jan 23 17:29:22 2006 UTC (18 years, 3 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0, OPENBSD_3_9_BASE, OPENBSD_3_9
Changes since 1.10: +2 -2 lines
Diff to previous 1.10 (colored)

Include <sys/param.h> instead of <sys/types.h> so we get MAXHOSTNAMELEN

Revision 1.10 / (download) - annotate - [select for diffs], Tue Jan 17 00:56:04 2006 UTC (18 years, 4 months ago) by aaron
Branch: MAIN
Changes since 1.9: +2 -2 lines
Diff to previous 1.9 (colored)

Fix malloc calculation to avoid memory bounds error.  deraadt@ ok

Revision 1.9 / (download) - annotate - [select for diffs], Sat Nov 12 15:26:23 2005 UTC (18 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.8: +4 -5 lines
Diff to previous 1.8 (colored)

more asprintf; ok dhill@mindcry.org

Revision 1.8 / (download) - annotate - [select for diffs], Mon Jun 9 11:33:14 2003 UTC (20 years, 11 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6, OPENBSD_3_5_BASE, OPENBSD_3_5, OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.7: +3 -3 lines
Diff to previous 1.7 (colored)

Protect all get_line calls against null pointers.
Problem pointed out by Pedro Bastos, thanks Pedro.

Revision 1.7 / (download) - annotate - [select for diffs], Thu Mar 13 09:32:06 2003 UTC (21 years, 2 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3
Changes since 1.6: +2 -2 lines
Diff to previous 1.6 (colored)

my style: length is size_t, not int.

Revision 1.6 / (download) - annotate - [select for diffs], Thu Mar 13 09:09:29 2003 UTC (21 years, 2 months ago) by deraadt
Branch: MAIN
Changes since 1.5: +5 -5 lines
Diff to previous 1.5 (colored)

lots of sprintf -> snprintf and strcpy -> strlcpy; checked by tedu

Revision 1.5 / (download) - annotate - [select for diffs], Sat Dec 14 21:28:08 2002 UTC (21 years, 5 months ago) by espie
Branch: MAIN
Changes since 1.4: +16 -6 lines
Diff to previous 1.4 (colored)

handle multiline replies from the server.
this actually happens on the 3.2 audio CD.
ok millert@

Revision 1.4 / (download) - annotate - [select for diffs], Thu Apr 18 22:17:04 2002 UTC (22 years, 1 month ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_3_2_BASE, OPENBSD_3_2
Changes since 1.3: +1 -2 lines
Diff to previous 1.3 (colored)

Reuse cddb code to support FreeBSD new cdid command.
(who knows ? scripts might use it).
ok fgs@, pval@

Revision 1.3 / (download) - annotate - [select for diffs], Thu Apr 18 22:07:04 2002 UTC (22 years, 1 month ago) by espie
Branch: MAIN
Changes since 1.2: +17 -17 lines
Diff to previous 1.2 (colored)

remove extra spaces, fix rcsid (noticed by millert)

Revision 1.2 / (download) - annotate - [select for diffs], Thu Apr 18 21:48:36 2002 UTC (22 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.1: +3 -3 lines
Diff to previous 1.1 (colored)

KNF

Revision 1.1 / (download) - annotate - [select for diffs], Thu Apr 18 20:18:31 2002 UTC (22 years, 1 month ago) by espie
Branch: MAIN

Add cddb support.

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.