OpenBSD CVS

CVS log for src/usr.bin/col/col.c


[BACK] Up to [local] / src / usr.bin / col

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.20 / (download) - annotate - [select for diffs], Sun Dec 4 23:50:47 2022 UTC (17 months, 2 weeks ago) by cheloha
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, HEAD
Changes since 1.19: +1 -2 lines
Diff to previous 1.19 (colored)

userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument.  We can
handle this case with the "default" failure case with no loss of
legibility.  Hence, remove all the redundant "case '?':" lines.

Prompted by dlg@.  With help from dlg@ and millert@.

Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2

ok naddy@ millert@ dlg@

Revision 1.19 / (download) - annotate - [select for diffs], Fri Oct 9 01:37:06 2015 UTC (8 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.18: +3 -3 lines
Diff to previous 1.18 (colored)

Change all tame callers to namechange to pledge(2).

Revision 1.18 / (download) - annotate - [select for diffs], Mon Oct 5 06:04:18 2015 UTC (8 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.17: +4 -1 lines
Diff to previous 1.17 (colored)

col can be locked down with tame "stdio", in case it is fed nasty input,
or if it has bugs.  The previous commits by schwarze indicate the latter
case was very true until recently...
ok doug

Revision 1.17 / (download) - annotate - [select for diffs], Sat May 9 20:36:18 2015 UTC (9 years ago) by schwarze
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8
Changes since 1.16: +20 -8 lines
Diff to previous 1.16 (colored)

For half and reverse line feeds, recognize SUSv2-style escape-digit
sequences in the input stream in addition to traditional BSD-style
escape-control-char sequences because traditional tools, for example
Heirloom roff, produce SUSv2-style sequences.  Switch the encoding
of forward half line feeds in the output of -f back to SUSv2 style
because that's likely to work with more tools than the non-standard
traditional BSD-style sequence.  Fully document these choices.

Issues originally reported by bapt at FreeBSD.
OK millert@ jmc@, and bapt@ also more or less agrees with the direction.

Revision 1.16 / (download) - annotate - [select for diffs], Fri May 8 16:30:07 2015 UTC (9 years ago) by schwarze
Branch: MAIN
Changes since 1.15: +5 -5 lines
Diff to previous 1.15 (colored)

Avoid scattering octal escapes all over the place,
use the definitions given at the top of the file.
No functional change.
From bapt at FreeBSD.

Revision 1.15 / (download) - annotate - [select for diffs], Fri May 8 12:30:27 2015 UTC (9 years ago) by schwarze
Branch: MAIN
Changes since 1.14: +65 -47 lines
Diff to previous 1.14 (colored)

Fix about ten integer overflows and underflows and a handful of logic
errors in line number handling.  Detailed explanations were sent to tech@
on October 18, 2014.
OK doug@, and bapt at FreeBSD says he likes the direction

Revision 1.14 / (download) - annotate - [select for diffs], Fri Oct 17 21:27:10 2014 UTC (9 years, 7 months ago) by schwarze
Branch: MAIN
CVS Tags: OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.13: +2 -2 lines
Diff to previous 1.13 (colored)

Correctly encode half line feed in the output stream for -f;
this patch only changes two bits, note that '\011' != '9' == '\071'.
Bug introduced by the original author, Michael Rendell, and
committed by Keith Bostic on May 22, 1990 (CSRG SCCS rev. 5.1).

The following operating systems are affected: 4.3BSD Reno, BSD Net/2,
4.4BSD, 4.4BSD Lite1, 4.4BSD Lite2, and all versions of 386BSD,
NetBSD, OpenBSD, FreeBSD, DragonFly, Debian GNU/Linux (package
bsdmainutils) and probably many others.

"that's a fun one" millert@, "nice find" deraadt@

Revision 1.13 / (download) - annotate - [select for diffs], Thu Oct 16 13:45:12 2014 UTC (9 years, 7 months ago) by schwarze
Branch: MAIN
Changes since 1.12: +19 -17 lines
Diff to previous 1.12 (colored)

1) Fix a segfault triggered by an input line containing two consecutive
backspace characters beyond column MAX_SHRT, overflowing c_column.
2) Fix imcomplete initialization of the final element of the *count
array by adding a missing pair of parentheses.
3) For code clarity and extra safety, change all variables dealing
with column numbers from int to size_t such that they cannot overflow.
Found while reviewing the patch from deraadt@'s reallocarray() rampage.
Feedback and OK millert@.

Revision 1.12 / (download) - annotate - [select for diffs], Wed Oct 8 19:59:58 2014 UTC (9 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.11: +13 -13 lines
Diff to previous 1.11 (colored)

use the reallocarray idiom; ok ingo

Revision 1.11 / (download) - annotate - [select for diffs], Tue Oct 27 23:59:36 2009 UTC (14 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.10: +1 -14 lines
Diff to previous 1.10 (colored)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable).  these days, people use source.  these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Revision 1.10 / (download) - annotate - [select for diffs], Tue May 1 01:26:19 2007 UTC (17 years ago) by jdixon
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3, OPENBSD_4_2_BASE, OPENBSD_4_2
Changes since 1.9: +8 -7 lines
Diff to previous 1.9 (colored)

use strtonum; ok millert@

Revision 1.9 / (download) - annotate - [select for diffs], Tue Jun 10 22:20:45 2003 UTC (20 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0, OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6, OPENBSD_3_5_BASE, OPENBSD_3_5, OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.8: +11 -19 lines
Diff to previous 1.8 (colored)

mostly ansi cleanup; pval ok

Revision 1.8 / (download) - annotate - [select for diffs], Tue Jun 3 02:56:06 2003 UTC (20 years, 11 months ago) by millert
Branch: MAIN
Changes since 1.7: +3 -7 lines
Diff to previous 1.7 (colored)

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999.  Proofed by myself and Theo.

Revision 1.7 / (download) - annotate - [select for diffs], Sat Feb 16 21:27:45 2002 UTC (22 years, 3 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3, OPENBSD_3_2_BASE, OPENBSD_3_2, OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.6: +10 -10 lines
Diff to previous 1.6 (colored)

Part one of userland __P removal.  Done with a simple regexp with some minor hand editing to make comments line up correctly.  Another pass is forthcoming that handles the cases that could not be done automatically.

Revision 1.6 / (download) - annotate - [select for diffs], Tue Nov 21 18:15:09 2000 UTC (23 years, 6 months ago) by aaron
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0, OPENBSD_2_9_BASE, OPENBSD_2_9
Changes since 1.5: +3 -4 lines
Diff to previous 1.5 (colored)

Sync usage() output with man page; mpech@prosoft.org.lv

Revision 1.5 / (download) - annotate - [select for diffs], Fri Jul 25 21:30:12 1997 UTC (26 years, 10 months ago) by mickey
Branch: MAIN
CVS Tags: OPENBSD_2_8_BASE, OPENBSD_2_8, OPENBSD_2_7_BASE, OPENBSD_2_7, OPENBSD_2_6_BASE, OPENBSD_2_6, OPENBSD_2_5_BASE, OPENBSD_2_5, OPENBSD_2_4_BASE, OPENBSD_2_4, OPENBSD_2_3_BASE, OPENBSD_2_3, OPENBSD_2_2_BASE, OPENBSD_2_2
Changes since 1.4: +3 -12 lines
Diff to previous 1.4 (colored)

use err(3)

Revision 1.4 / (download) - annotate - [select for diffs], Tue Jun 17 20:53:58 1997 UTC (26 years, 11 months ago) by kstailey
Branch: MAIN
Changes since 1.3: +4 -4 lines
Diff to previous 1.3 (colored)

(foo *)NULL -> NULL + err msg for realloc failure

Revision 1.3 / (download) - annotate - [select for diffs], Wed Jan 15 23:42:20 1997 UTC (27 years, 4 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_1_BASE, OPENBSD_2_1
Changes since 1.2: +3 -3 lines
Diff to previous 1.2 (colored)

getopt(3) returns -1 when out of args, not EOF, whee!

Revision 1.2 / (download) - annotate - [select for diffs], Wed Jun 26 05:32:10 1996 UTC (27 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.1: +2 -1 lines
Diff to previous 1.1 (colored)

rcsid

Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Wed Oct 18 08:45:01 1995 UTC (28 years, 7 months ago) by deraadt
CVS Tags: netbsd_1_1
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)

initial import of NetBSD tree

Revision 1.1 / (download) - annotate - [select for diffs], Wed Oct 18 08:45:01 1995 UTC (28 years, 7 months ago) by deraadt
Branch: MAIN

Initial revision

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.