OpenBSD CVS

CVS log for src/usr.bin/cvs/logmsg.c


[BACK] Up to [local] / src / usr.bin / cvs

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.61 / (download) - annotate - [select for diffs], Mon Oct 19 19:51:20 2020 UTC (3 years, 6 months ago) by naddy
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, HEAD
Changes since 1.60: +32 -13 lines
Diff to previous 1.60 (colored)

Accommodate POSIX basename(3) that takes a non-const parameter and
may modify the string buffer.

ok florian@ millert@

Revision 1.60 / (download) - annotate - [select for diffs], Sun May 28 16:57:01 2017 UTC (6 years, 11 months ago) by joris
Branch: MAIN
CVS Tags: OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2
Changes since 1.59: +5 -5 lines
Diff to previous 1.59 (colored)

Bring the opencvs log message template inline with other cvs implementations.

ok stsp@

Revision 1.59 / (download) - annotate - [select for diffs], Sat Oct 15 22:20:17 2016 UTC (7 years, 7 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_6_1_BASE, OPENBSD_6_1
Changes since 1.58: +3 -3 lines
Diff to previous 1.58 (colored)

Quiet compiler warnings.  OK tomc@ tb@

Revision 1.58 / (download) - annotate - [select for diffs], Tue Aug 16 19:00:59 2016 UTC (7 years, 9 months ago) by tb
Branch: MAIN
Changes since 1.57: +5 -5 lines
Diff to previous 1.57 (colored)

When the commit message is empty, don't default to c)ontinue
(committing without log message) but a)bort.  Also, accept
the uppercase versions of the choices.

Matches the corresponding change of behavior of GNU cvs.

suggested by & ok jcs

Revision 1.57 / (download) - annotate - [select for diffs], Thu Nov 5 09:48:21 2015 UTC (8 years, 6 months ago) by nicm
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.56: +8 -10 lines
Diff to previous 1.56 (colored)

Remove xfree(), like already done for RCS. From Michael W Bombardieri,
ok mmcc

Revision 1.56 / (download) - annotate - [select for diffs], Thu Feb 5 12:59:57 2015 UTC (9 years, 3 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.55: +2 -1 lines
Diff to previous 1.55 (colored)

Include stdint.h, not limits.h to get SIZE_MAX.  OK guenther@

Revision 1.55 / (download) - annotate - [select for diffs], Fri Jan 16 06:40:07 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
Changes since 1.54: +2 -2 lines
Diff to previous 1.54 (colored)

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible.  Annotate <sys/param.h> lines with their current reasons.  Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc.  Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution.  These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Revision 1.54 / (download) - annotate - [select for diffs], Fri Jul 23 21:46:05 2010 UTC (13 years, 9 months ago) by ray
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8
Changes since 1.53: +6 -6 lines
Diff to previous 1.53 (colored)

Reduce variable/function name and whitespace differences between
cvs/rcs.

OK xsa zinovik

Revision 1.53 / (download) - annotate - [select for diffs], Fri Jul 23 08:31:19 2010 UTC (13 years, 9 months ago) by ray
Branch: MAIN
Changes since 1.52: +2 -2 lines
Diff to previous 1.52 (colored)

Rename a bunch of variables and functions, removing the cvs_/rcs_
prefixes to reduce differences between cvs and rcs files.

"yes!" nicm

Revision 1.52 / (download) - annotate - [select for diffs], Wed Mar 25 21:50:33 2009 UTC (15 years, 1 month ago) by joris
Branch: MAIN
CVS Tags: OPENBSD_4_7_BASE, OPENBSD_4_7, OPENBSD_4_6_BASE, OPENBSD_4_6
Changes since 1.51: +7 -7 lines
Diff to previous 1.51 (colored)

switch our file and directory lists to RB trees (see tree(3)),
so we can benefit from faster lookup times while recursing.

Revision 1.51 / (download) - annotate - [select for diffs], Wed Nov 26 00:09:02 2008 UTC (15 years, 5 months ago) by ray
Branch: MAIN
CVS Tags: OPENBSD_4_5_BASE, OPENBSD_4_5
Changes since 1.50: +2 -3 lines
Diff to previous 1.50 (colored)

Small optimization.

OK tobias@

Revision 1.50 / (download) - annotate - [select for diffs], Tue Jun 10 01:00:34 2008 UTC (15 years, 11 months ago) by joris
Branch: MAIN
CVS Tags: OPENBSD_4_4_BASE, OPENBSD_4_4
Changes since 1.49: +72 -4 lines
Diff to previous 1.49 (colored)

New trigger framework that allows us to run the required scripts
defined in CVSROOT/commitinfo and CVSROOT/loginfo and so on.

This enables the use of log_accum2 and all that other nice stuff we like.

This was mostly written by Jonathan Armani with help from tobias@ and myself.

ok tobias@

Revision 1.49 / (download) - annotate - [select for diffs], Sun Jun 8 20:08:43 2008 UTC (15 years, 11 months ago) by tobias
Branch: MAIN
Changes since 1.48: +43 -12 lines
Diff to previous 1.48 (colored)

Handle commits on a per-directory basis instead handling all of them at
once in local setup.  Also added '!' to reuse typed log message for all
following directories.

ok joris

Revision 1.48 / (download) - annotate - [select for diffs], Thu May 22 15:46:30 2008 UTC (16 years ago) by tobias
Branch: MAIN
Changes since 1.47: +2 -2 lines
Diff to previous 1.47 (colored)

Wrong function names in fatal messages fixed.

Revision 1.47 / (download) - annotate - [select for diffs], Sun Mar 9 01:02:38 2008 UTC (16 years, 2 months ago) by tobias
Branch: MAIN
Changes since 1.46: +4 -1 lines
Diff to previous 1.46 (colored)

While allocation memory, make sure that file sizes are smaller than SIZE_MAX.

ok joris

Revision 1.46 / (download) - annotate - [select for diffs], Mon Feb 11 20:33:11 2008 UTC (16 years, 3 months ago) by tobias
Branch: MAIN
CVS Tags: OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.45: +2 -2 lines
Diff to previous 1.45 (colored)

Cleanup buf implementation:

* Don't check for NULL on buffer creation, because it calls fatal() when
  something's wrong.
* All buffers are supposed to expand if there is no space left in them,
  so zap flags as well.
* Remove code that is now dead.

OK joris@

> Inspired by a diff from Igor Zinovik about unchecked return value.

Revision 1.45 / (download) - annotate - [select for diffs], Tue Sep 25 10:04:47 2007 UTC (16 years, 7 months ago) by chl
Branch: MAIN
Changes since 1.44: +3 -2 lines
Diff to previous 1.44 (colored)

missing header for mkstemp
check mkstemp return value against -1 instead of NULL

ok joris@

Revision 1.44 / (download) - annotate - [select for diffs], Tue Sep 4 17:57:41 2007 UTC (16 years, 8 months ago) by tobias
Branch: MAIN
Changes since 1.43: +2 -2 lines
Diff to previous 1.43 (colored)

Replaced strlen() with sizeof() - 1 when #define'd strings are used.

OK ray@

Revision 1.43 / (download) - annotate - [select for diffs], Tue Sep 4 11:47:14 2007 UTC (16 years, 8 months ago) by tobias
Branch: MAIN
Changes since 1.42: +2 -2 lines
Diff to previous 1.42 (colored)

Handle ^D as a)bort in log message question.

OK joris@

Revision 1.42 / (download) - annotate - [select for diffs], Thu Aug 30 11:07:18 2007 UTC (16 years, 8 months ago) by joris
Branch: MAIN
Changes since 1.41: +1 -3 lines
Diff to previous 1.41 (colored)

properly send our log message to the server using Argumentx, so we
no longer break when the log message has multiple lines.

from Tobias Stoeckmann, thanks for doing my work!

Revision 1.41 / (download) - annotate - [select for diffs], Fri May 11 02:43:24 2007 UTC (17 years ago) by ray
Branch: MAIN
CVS Tags: OPENBSD_4_2_BASE, OPENBSD_4_2
Changes since 1.40: +8 -2 lines
Diff to previous 1.40 (colored)

cvs_logmsg_edit no longer fails with ECHILD.
Add comment describing cvs_logmsg_edit usage.

Revision 1.40 / (download) - annotate - [select for diffs], Fri May 11 02:37:31 2007 UTC (17 years ago) by ray
Branch: MAIN
Changes since 1.39: +19 -29 lines
Diff to previous 1.39 (colored)

Sync with editit from sendbug.

Revision 1.39 / (download) - annotate - [select for diffs], Fri Apr 20 08:36:00 2007 UTC (17 years, 1 month ago) by xsa
Branch: MAIN
Changes since 1.38: +63 -9 lines
Diff to previous 1.38 (colored)

- correct signal handling and process waiting for the EDITOR support code
(From ray's code in sendbug(1))
- nuke cvs_exec() as it is not used anymore

Prompted by deraadt@ a few weeks ago.
OK ray@.

Revision 1.38 / (download) - annotate - [select for diffs], Thu Feb 22 06:42:09 2007 UTC (17 years, 2 months ago) by otto
Branch: MAIN
CVS Tags: OPENBSD_4_1_BASE, OPENBSD_4_1
Changes since 1.37: +7 -5 lines
Diff to previous 1.37 (colored)

general includes cleanup sweep. ok joris@ niallo@

Revision 1.37 / (download) - annotate - [select for diffs], Thu Jan 25 22:49:39 2007 UTC (17 years, 3 months ago) by xsa
Branch: MAIN
Changes since 1.36: +1 -3 lines
Diff to previous 1.36 (colored)

zap uneeded close() calls after fclose(); pointed out by and OK otto@.

Revision 1.36 / (download) - annotate - [select for diffs], Thu Jan 25 08:21:08 2007 UTC (17 years, 3 months ago) by otto
Branch: MAIN
Changes since 1.35: +3 -2 lines
Diff to previous 1.35 (colored)

do not use strlcpuy on a buffer filled by fgetln, since fgetln does
not NUL-terminate. ok xsa@

Revision 1.35 / (download) - annotate - [select for diffs], Thu Jan 11 08:48:59 2007 UTC (17 years, 4 months ago) by xsa
Branch: MAIN
Changes since 1.34: +2 -10 lines
Diff to previous 1.34 (colored)

strl* overload, use xasprintf().

Revision 1.34 / (download) - annotate - [select for diffs], Thu Jan 11 08:33:53 2007 UTC (17 years, 4 months ago) by xsa
Branch: MAIN
Changes since 1.33: +9 -5 lines
Diff to previous 1.33 (colored)

save errno.

Revision 1.33 / (download) - annotate - [select for diffs], Sun Jan 7 18:40:55 2007 UTC (17 years, 4 months ago) by joris
Branch: MAIN
Changes since 1.32: +3 -1 lines
Diff to previous 1.32 (colored)

add the temporary file we create to the temp_files worklist

Revision 1.32 / (download) - annotate - [select for diffs], Sun Jan 7 13:33:04 2007 UTC (17 years, 4 months ago) by jasper
Branch: MAIN
Changes since 1.31: +2 -2 lines
Diff to previous 1.31 (colored)

make the output when interrupting writing the log message consistent.

ok joris@

commiting with opencvs now btw :)

Revision 1.31 / (download) - annotate - [select for diffs], Sun Jan 7 02:47:57 2007 UTC (17 years, 4 months ago) by joris
Branch: MAIN
Changes since 1.30: +4 -4 lines
Diff to previous 1.30 (colored)

and lets make import work with the new logmsg code too!

Revision 1.30 / (download) - annotate - [select for diffs], Sun Jan 7 02:39:24 2007 UTC (17 years, 4 months ago) by joris
Branch: MAIN
Changes since 1.29: +122 -227 lines
Diff to previous 1.29 (colored)

rewrite of the logmessage code, which allows you to
enter a logmessage into your favorite editor when commiting.

Revision 1.29, Sat May 27 03:30:31 2006 UTC (17 years, 11 months ago) by joris
Branch: MAIN
Changes since 1.28: +1 -1 lines
FILE REMOVED

commit the new opencvs code, i have been hacking on
this for the past 2 weeks now and it should go in at
the start of the hackathon so others can help out.

this code is a lot safer, smarter, faster and best of
all it is actually doing what it is suppose to do!

basic checkout, update, status, diff and commit are
working in local mode only.
there is no support for any remote setups now.

Revision 1.28 / (download) - annotate - [select for diffs], Fri Apr 14 02:45:35 2006 UTC (18 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.27: +7 -7 lines
Diff to previous 1.27 (colored)

remove a metric buttload of excessive ()
no binary change; ok ray

Revision 1.27 / (download) - annotate - [select for diffs], Mon Jan 2 08:11:56 2006 UTC (18 years, 4 months ago) by xsa
Branch: MAIN
CVS Tags: OPENBSD_3_9_BASE, OPENBSD_3_9
Changes since 1.26: +2 -9 lines
Diff to previous 1.26 (colored)

#include's cleanup; ok joris@ niallo@.

Revision 1.26 / (download) - annotate - [select for diffs], Fri Dec 30 02:03:28 2005 UTC (18 years, 4 months ago) by joris
Branch: MAIN
Changes since 1.25: +4 -8 lines
Diff to previous 1.25 (colored)

major cleanup of the functions handling the remote cvs protocol.
makes the code a lot more readable and understandable.

ok xsa@ and niallo@

Revision 1.25 / (download) - annotate - [select for diffs], Thu Dec 22 13:19:12 2005 UTC (18 years, 5 months ago) by moritz
Branch: MAIN
Changes since 1.24: +2 -1 lines
Diff to previous 1.24 (colored)

unitialized variable. ok xsa@

Revision 1.24 / (download) - annotate - [select for diffs], Wed Dec 21 20:04:36 2005 UTC (18 years, 5 months ago) by xsa
Branch: MAIN
Changes since 1.23: +23 -52 lines
Diff to previous 1.23 (colored)

fatal()ization! OK joris@.

Revision 1.23 / (download) - annotate - [select for diffs], Tue Dec 20 18:17:01 2005 UTC (18 years, 5 months ago) by xsa
Branch: MAIN
Changes since 1.22: +2 -5 lines
Diff to previous 1.22 (colored)

cvs_buf_putc() and cvs_buf_write_*() functions cannot fail anymore;

Revision 1.22 / (download) - annotate - [select for diffs], Sat Dec 10 20:27:45 2005 UTC (18 years, 5 months ago) by joris
Branch: MAIN
Changes since 1.21: +2 -2 lines
Diff to previous 1.21 (colored)

switch to xmalloc stuff, me and xsa@ agreed on this a long
time ago, but we were being held back by jfb. too bad for him.

next step is to use fatal() through out the code for unrecoverable
errors instead of trying to be all nice and fluffy and reach main() again.

ok niallo@ and xsa@

Revision 1.21 / (download) - annotate - [select for diffs], Sun Aug 14 19:49:18 2005 UTC (18 years, 9 months ago) by xsa
Branch: MAIN
CVS Tags: OPENBSD_3_8_BASE, OPENBSD_3_8
Changes since 1.20: +2 -2 lines
Diff to previous 1.20 (colored)

missing casts; ok joris

Revision 1.20 / (download) - annotate - [select for diffs], Wed Aug 10 14:49:20 2005 UTC (18 years, 9 months ago) by xsa
Branch: MAIN
Changes since 1.19: +4 -4 lines
Diff to previous 1.19 (colored)

fgets() expects the 2nd arg to be an int. OK jfb@ joris@.

Revision 1.19 / (download) - annotate - [select for diffs], Mon Aug 8 14:28:59 2005 UTC (18 years, 9 months ago) by xsa
Branch: MAIN
Changes since 1.18: +3 -3 lines
Diff to previous 1.18 (colored)

use cvs_tmpdir; OK jfb@ joris@.

Revision 1.18 / (download) - annotate - [select for diffs], Mon Jul 25 12:13:08 2005 UTC (18 years, 9 months ago) by xsa
Branch: MAIN
Changes since 1.17: +4 -4 lines
Diff to previous 1.17 (colored)

KNF;

Revision 1.17 / (download) - annotate - [select for diffs], Mon Jul 25 12:05:43 2005 UTC (18 years, 9 months ago) by xsa
Branch: MAIN
Changes since 1.16: +3 -3 lines
Diff to previous 1.16 (colored)

KNF;

Revision 1.16 / (download) - annotate - [select for diffs], Sat Jul 23 00:03:00 2005 UTC (18 years, 10 months ago) by joris
Branch: MAIN
Changes since 1.15: +4 -1 lines
Diff to previous 1.15 (colored)

correctly seperate added, modified and removed files for use in the
construction of the log message in the editor.

ok jfb@

Revision 1.15 / (download) - annotate - [select for diffs], Thu Jun 2 16:05:38 2005 UTC (18 years, 11 months ago) by xsa
Branch: MAIN
Changes since 1.14: +3 -3 lines
Diff to previous 1.14 (colored)

- set LP_ABORT log level when action is abored by user instead of LP_ERR
- missing \n in output of an unchanged log message warning
- always use the command name in error messages instead of aliases

ok jfb@.

Revision 1.14 / (download) - annotate - [select for diffs], Tue May 31 08:58:48 2005 UTC (18 years, 11 months ago) by xsa
Branch: MAIN
Changes since 1.13: +3 -3 lines
Diff to previous 1.13 (colored)

headers ordering (alphabetically) and cleanup, from mbalmer@ and myself;

Revision 1.13 / (download) - annotate - [select for diffs], Mon Apr 18 21:02:50 2005 UTC (19 years, 1 month ago) by jfb
Branch: MAIN
Changes since 1.12: +2 -2 lines
Diff to previous 1.12 (colored)

Modify the CVSFILE structure using a union to keep information about
both files and directories.  We can now keep the revision number for
regular files, and don't need to fetch the appropriate entry in the
command callbacks.  This saves a huge amount of parsing on Entries
files.

ok joris@

Revision 1.12 / (download) - annotate - [select for diffs], Sat Feb 26 21:51:33 2005 UTC (19 years, 2 months ago) by david
Branch: MAIN
CVS Tags: OPENBSD_3_7_BASE, OPENBSD_3_7
Changes since 1.11: +2 -2 lines
Diff to previous 1.11 (colored)

spelling fixes

Revision 1.11 / (download) - annotate - [select for diffs], Mon Jan 3 21:08:12 2005 UTC (19 years, 4 months ago) by jfb
Branch: MAIN
Changes since 1.10: +15 -4 lines
Diff to previous 1.10 (colored)

more error checking on buffer operations and plug a descriptor leak

from Joris Vink

Revision 1.10 / (download) - annotate - [select for diffs], Wed Dec 8 21:49:02 2004 UTC (19 years, 5 months ago) by jfb
Branch: MAIN
Changes since 1.9: +7 -3 lines
Diff to previous 1.9 (colored)

complain if we fail to send the log message so the caller doesn't
have to

Revision 1.9 / (download) - annotate - [select for diffs], Wed Dec 8 18:54:23 2004 UTC (19 years, 5 months ago) by jfb
Branch: MAIN
Changes since 1.8: +3 -2 lines
Diff to previous 1.8 (colored)

rearrange the output loop for file lists in the log message so we don't
have blank lines or extra delimiters in some cases

spotted by and discussed with Joris Vink

Revision 1.8 / (download) - annotate - [select for diffs], Wed Dec 8 17:22:48 2004 UTC (19 years, 5 months ago) by jfb
Branch: MAIN
Changes since 1.7: +41 -23 lines
Diff to previous 1.7 (colored)

embrace and extend (!) cvs_logmsg_get() so we can now display
information based on its availability and have separate sections for
the Added, Modified and Removed file lists.  this will allow us to
use the same call for add, commit, import and possibly others

Original patch by Joris Vink, some rework from me for the other
sections

Revision 1.7 / (download) - annotate - [select for diffs], Tue Dec 7 17:10:56 2004 UTC (19 years, 5 months ago) by tedu
Branch: MAIN
Changes since 1.6: +12 -16 lines
Diff to previous 1.6 (colored)

less whitespace, more pretty.  ok jfb

Revision 1.6 / (download) - annotate - [select for diffs], Mon Dec 6 21:03:12 2004 UTC (19 years, 5 months ago) by deraadt
Branch: MAIN
Changes since 1.5: +3 -5 lines
Diff to previous 1.5 (colored)

tighten vertical spacing for else; jfb ok

Revision 1.5 / (download) - annotate - [select for diffs], Fri Dec 3 19:01:02 2004 UTC (19 years, 5 months ago) by jfb
Branch: MAIN
Changes since 1.4: +10 -10 lines
Diff to previous 1.4 (colored)

Rename variables to make more sense and fix a warning about assigning
to a read-only location.

Revision 1.4 / (download) - annotate - [select for diffs], Thu Dec 2 19:23:44 2004 UTC (19 years, 5 months ago) by jfb
Branch: MAIN
Changes since 1.3: +13 -4 lines
Diff to previous 1.3 (colored)

This commit is brought to you by the brand new improved and better tasting
OpenCVS commit code.

Revision 1.3 / (download) - annotate - [select for diffs], Thu Dec 2 17:45:44 2004 UTC (19 years, 5 months ago) by jfb
Branch: MAIN
Changes since 1.2: +36 -14 lines
Diff to previous 1.2 (colored)

cvs_logmsg_get() now accepts a list of files that it is getting the
message for and displays those files in the commented part of the
log message

Revision 1.2 / (download) - annotate - [select for diffs], Fri Nov 26 16:23:50 2004 UTC (19 years, 5 months ago) by jfb
Branch: MAIN
Changes since 1.1: +24 -0 lines
Diff to previous 1.1 (colored)

Rewrite the internals of the file management code so that we do not keep
a full path to each file we load, and cache file names so we can have
multiple references to a single name.  This saves a lot of memory on large
trees such as /usr/src, especially on 'Makefile', 'README' and such.

Revision 1.1 / (download) - annotate - [select for diffs], Fri Nov 12 17:49:11 2004 UTC (19 years, 6 months ago) by jfb
Branch: MAIN

Functions to extract log messages from files and query users for them

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.