OpenBSD CVS

CVS log for src/usr.bin/cvs/remote.c


[BACK] Up to [local] / src / usr.bin / cvs

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.34 / (download) - annotate - [select for diffs], Sun Nov 28 19:28:42 2021 UTC (2 years, 5 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, HEAD
Changes since 1.33: +7 -6 lines
Diff to previous 1.33 (colored)

Stop using MAXBSIZE to eliminate sys/param.h including (which injects a
ton of namespace intrusion).  Create local sizes, and refactor some code
along the way.
ok millert

Revision 1.33 / (download) - annotate - [select for diffs], Fri Jun 28 13:35:00 2019 UTC (4 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.32: +2 -2 lines
Diff to previous 1.32 (colored)

When system calls indicate an error they return -1, not some arbitrary
value < 0.  errno is only updated in this case.  Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Revision 1.32 / (download) - annotate - [select for diffs], Mon Aug 28 19:33:20 2017 UTC (6 years, 8 months ago) by otto
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2
Changes since 1.31: +2 -2 lines
Diff to previous 1.31 (colored)

fix const related warnings; ok millert@

Revision 1.31 / (download) - annotate - [select for diffs], Thu Nov 5 09:48:21 2015 UTC (8 years, 6 months ago) by nicm
Branch: MAIN
CVS Tags: OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.30: +3 -3 lines
Diff to previous 1.30 (colored)

Remove xfree(), like already done for RCS. From Michael W Bombardieri,
ok mmcc

Revision 1.30 / (download) - annotate - [select for diffs], Fri Jan 16 06:40:07 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.29: +5 -2 lines
Diff to previous 1.29 (colored)

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible.  Annotate <sys/param.h> lines with their current reasons.  Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc.  Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution.  These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Revision 1.29 / (download) - annotate - [select for diffs], Fri Jul 23 21:46:05 2010 UTC (13 years, 9 months ago) by ray
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8
Changes since 1.28: +3 -3 lines
Diff to previous 1.28 (colored)

Reduce variable/function name and whitespace differences between
cvs/rcs.

OK xsa zinovik

Revision 1.28 / (download) - annotate - [select for diffs], Tue Apr 7 21:27:45 2009 UTC (15 years, 1 month ago) by joris
Branch: MAIN
CVS Tags: OPENBSD_4_7_BASE, OPENBSD_4_7, OPENBSD_4_6_BASE, OPENBSD_4_6
Changes since 1.27: +9 -4 lines
Diff to previous 1.27 (colored)

do not try to send a added file that is no longer on disk
towards the server.

problem spotted and diff tested by sthen@

Revision 1.27 / (download) - annotate - [select for diffs], Thu Apr 2 20:57:47 2009 UTC (15 years, 1 month ago) by joris
Branch: MAIN
Changes since 1.26: +3 -2 lines
Diff to previous 1.26 (colored)

if ce_conflict != NULL, the file should be sent
to the server for verification.

commited with opencvs,
permission by deraadt@

Revision 1.26 / (download) - annotate - [select for diffs], Wed Apr 1 06:41:58 2009 UTC (15 years, 1 month ago) by joris
Branch: MAIN
Changes since 1.25: +2 -2 lines
Diff to previous 1.25 (colored)

in client mode, be sure to consider the file modified if a conflict
exists in the CVS/Entries file, otherwise the server has no way
of determining if the user has resolved it or not.

also in client mode, send a conflict as Â"+=" not "+" alone, so other
cvs implementations get it.

commited entirely with opencvs,
with permission by deraadt@

Revision 1.25 / (download) - annotate - [select for diffs], Sat Feb 21 14:50:53 2009 UTC (15 years, 2 months ago) by joris
Branch: MAIN
CVS Tags: OPENBSD_4_5_BASE, OPENBSD_4_5
Changes since 1.24: +6 -3 lines
Diff to previous 1.24 (colored)

use FILE_ON_DISK flags when we need to verify if a file
exists in the working copy or not instead of checking fd being -1
since this can differ in server or local mode.

Revision 1.24 / (download) - annotate - [select for diffs], Sat Jun 14 03:19:15 2008 UTC (15 years, 11 months ago) by joris
Branch: MAIN
CVS Tags: OPENBSD_4_4_BASE, OPENBSD_4_4
Changes since 1.23: +1 -2 lines
Diff to previous 1.23 (colored)

don't always re-open the same CVS/Entries file, instead keep the
last opened CVS/Entries around to operate on and close it whenever
we switch directory. gives us a small performance boost, obviously.

while doing this, switch the way we write revisions to disk by
using fwrite(3) so stuff can get written to disk in chunks
instead of writing everything line by line, another win.

with help from otto@
ok tobias@

Revision 1.23 / (download) - annotate - [select for diffs], Thu Jun 12 07:16:14 2008 UTC (15 years, 11 months ago) by joris
Branch: MAIN
Changes since 1.22: +31 -1 lines
Diff to previous 1.22 (colored)

completely kill the need for TMP_DIR when running checkout,
which gives us better performance among other things.

this is however disabled in a few cases:
1) whenever you run checkout over an existing tree (which acts as update)
2) whenever you specify -d or a module alias

we're planning on enabling this behaviour for case 2 in the future.

anoncvs sysadmins now love us even more.

ok tobias@

Revision 1.22 / (download) - annotate - [select for diffs], Sat Mar 8 11:53:36 2008 UTC (16 years, 2 months ago) by joris
Branch: MAIN
Changes since 1.21: +2 -2 lines
Diff to previous 1.21 (colored)

correct usage of lseek(2);

Revision 1.21 / (download) - annotate - [select for diffs], Wed Feb 27 22:34:04 2008 UTC (16 years, 2 months ago) by joris
Branch: MAIN
CVS Tags: OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.20: +11 -5 lines
Diff to previous 1.20 (colored)

prevent file races

ok tobias@

Revision 1.20 / (download) - annotate - [select for diffs], Sun Feb 10 14:15:36 2008 UTC (16 years, 3 months ago) by joris
Branch: MAIN
Changes since 1.19: +2 -4 lines
Diff to previous 1.19 (colored)

cvs_validate_directory() was too paranoia

Revision 1.19 / (download) - annotate - [select for diffs], Sun Feb 10 14:04:40 2008 UTC (16 years, 3 months ago) by joris
Branch: MAIN
Changes since 1.18: +2 -2 lines
Diff to previous 1.18 (colored)

use cvs_validate_directory() in cvs_get_repository_path() as well,
since we want to make sure we have valid CVS/Repository content

ok tobias@

Revision 1.18 / (download) - annotate - [select for diffs], Sun Feb 10 14:00:41 2008 UTC (16 years, 3 months ago) by joris
Branch: MAIN
Changes since 1.17: +22 -1 lines
Diff to previous 1.17 (colored)

introduce cvs_validate_directory(), which is used to check
directory path to make sure they do not fall outside the CVSROOT
or the working copy directory in a remote setup

Revision 1.17 / (download) - annotate - [select for diffs], Mon Sep 17 10:07:21 2007 UTC (16 years, 8 months ago) by tobias
Branch: MAIN
Changes since 1.16: +20 -13 lines
Diff to previous 1.16 (colored)

Imported atomicio interface.

Requested by ray@, OK joris@

Revision 1.16 / (download) - annotate - [select for diffs], Sun Sep 2 11:11:12 2007 UTC (16 years, 8 months ago) by tobias
Branch: MAIN
Changes since 1.15: +10 -14 lines
Diff to previous 1.15 (colored)

Log all commands sent with cvs_remote_output(), not just
cvs_client_send_request(). Simplified logging code while at it.

OK joris@

Revision 1.15 / (download) - annotate - [select for diffs], Wed May 16 19:40:45 2007 UTC (17 years ago) by xsa
Branch: MAIN
CVS Tags: OPENBSD_4_2_BASE, OPENBSD_4_2
Changes since 1.14: +3 -4 lines
Diff to previous 1.14 (colored)

In remote setup, write sent files to inlog (if specified) instead of outlog.
Matches GNU CVS' behaviour. From Tobias Stoeckmann.

Revision 1.14 / (download) - annotate - [select for diffs], Thu Feb 22 06:42:09 2007 UTC (17 years, 2 months ago) by otto
Branch: MAIN
CVS Tags: OPENBSD_4_1_BASE, OPENBSD_4_1
Changes since 1.13: +8 -4 lines
Diff to previous 1.13 (colored)

general includes cleanup sweep. ok joris@ niallo@

Revision 1.13 / (download) - annotate - [select for diffs], Wed Jan 31 21:07:35 2007 UTC (17 years, 3 months ago) by xsa
Branch: MAIN
Changes since 1.12: +3 -5 lines
Diff to previous 1.12 (colored)

snprintf() -> xsnprintf()

Revision 1.12 / (download) - annotate - [select for diffs], Fri Jan 26 11:19:44 2007 UTC (17 years, 3 months ago) by joris
Branch: MAIN
Changes since 1.11: +2 -4 lines
Diff to previous 1.11 (colored)

Handle CVS/Entries and file timestamp correctly so we do
not mistakenly see a file as Modified while it is not.

As a result, we can remove the very hackish cvs_hack_time() and
GNU cvs and opencvs should almost get along now.

lotsa help and okay The otto@

Revision 1.11 / (download) - annotate - [select for diffs], Fri Jan 26 08:35:23 2007 UTC (17 years, 3 months ago) by otto
Branch: MAIN
Changes since 1.10: +2 -2 lines
Diff to previous 1.10 (colored)

modestring can be 18 long

Revision 1.10 / (download) - annotate - [select for diffs], Thu Jan 25 18:56:33 2007 UTC (17 years, 3 months ago) by otto
Branch: MAIN
Changes since 1.9: +3 -9 lines
Diff to previous 1.9 (colored)

use more stack allocations for fixed size buffers. ok xsa@ joris@

Revision 1.9 / (download) - annotate - [select for diffs], Thu Jan 25 06:44:11 2007 UTC (17 years, 3 months ago) by otto
Branch: MAIN
Changes since 1.8: +4 -6 lines
Diff to previous 1.8 (colored)

plug a mem leak and wrong usage of strlcpy after fgetln. since fgetln
does not NUL-terminate, it is not ok to use strlcpy on the buffer.
ok opencvsgang@

Revision 1.8 / (download) - annotate - [select for diffs], Wed Jan 24 21:24:48 2007 UTC (17 years, 3 months ago) by otto
Branch: MAIN
Changes since 1.7: +6 -5 lines
Diff to previous 1.7 (colored)

user proper format string for size_t; file size is off_t; ok joris@

Revision 1.7 / (download) - annotate - [select for diffs], Thu Jan 18 16:45:52 2007 UTC (17 years, 4 months ago) by joris
Branch: MAIN
Changes since 1.6: +4 -1 lines
Diff to previous 1.6 (colored)

import improvements:
- add support for remote import in opencvs client and server.
- do not free already free'd buffers in import_update()
- do not append a '\0' to the loaded file buffer, this was bad behaviour

makes import work fine both locally and remotely.

Revision 1.6 / (download) - annotate - [select for diffs], Sat Jan 13 15:29:34 2007 UTC (17 years, 4 months ago) by joris
Branch: MAIN
Changes since 1.5: +43 -36 lines
Diff to previous 1.5 (colored)

- remote update now works again, with new rcs api
- we no longer hold the entire file in memory when sending or receiving it

Revision 1.5 / (download) - annotate - [select for diffs], Wed Jan 3 19:27:28 2007 UTC (17 years, 4 months ago) by joris
Branch: MAIN
Changes since 1.4: +29 -1 lines
Diff to previous 1.4 (colored)

fix CVS_CLIENT_LOG logging, we were missing parts
which was making it very hard to correctly debug remote connections.

Revision 1.4 / (download) - annotate - [select for diffs], Mon Jul 10 01:32:32 2006 UTC (17 years, 10 months ago) by joris
Branch: MAIN
CVS Tags: OPENBSD_4_0_BASE, OPENBSD_4_0
Changes since 1.3: +20 -13 lines
Diff to previous 1.3 (colored)

handle 0 sized files correctly, tested by brad@ thanks

Revision 1.3 / (download) - annotate - [select for diffs], Sun Jul 9 01:47:20 2006 UTC (17 years, 10 months ago) by joris
Branch: MAIN
Changes since 1.2: +1 -10 lines
Diff to previous 1.2 (colored)

more straightforward trace (-t) output, too much is just too noisy.

Revision 1.2 / (download) - annotate - [select for diffs], Sat Jul 8 00:34:20 2006 UTC (17 years, 10 months ago) by joris
Branch: MAIN
Changes since 1.1: +8 -1 lines
Diff to previous 1.1 (colored)

allow update in remote mode to work a bit better and
create any missing directories or new directories with -d

Revision 1.1 / (download) - annotate - [select for diffs], Fri Jul 7 17:37:17 2006 UTC (17 years, 10 months ago) by joris
Branch: MAIN

first part of opencvs remote, fairly useable on existing trees
although i advise against using it on real development trees for now.

only a few commands work right so far:
- commit
- diff
- status
- log
- update (partially working)

if you feel like testing remote and run into bugs feel free to
contact me, and please include a full trace (-t).

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.