OpenBSD CVS

CVS log for src/usr.bin/finger/util.c


[BACK] Up to [local] / src / usr.bin / finger

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.37 / (download) - annotate - [select for diffs], Mon Dec 26 19:16:01 2022 UTC (16 months, 3 weeks ago) by jmc
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, HEAD
Changes since 1.36: +2 -2 lines
Diff to previous 1.36 (colored)

spelling fixes; from paul tagliamonte
amendments to his diff are noted on tech

Revision 1.36 / (download) - annotate - [select for diffs], Wed Jul 3 03:24:02 2019 UTC (4 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.35: +2 -2 lines
Diff to previous 1.35 (colored)

snprintf/vsnprintf return < 0 on error, rather than -1.

Revision 1.35 / (download) - annotate - [select for diffs], Fri Jun 28 13:35:01 2019 UTC (4 years, 10 months ago) by deraadt
Branch: MAIN
Changes since 1.34: +2 -2 lines
Diff to previous 1.34 (colored)

When system calls indicate an error they return -1, not some arbitrary
value < 0.  errno is only updated in this case.  Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Revision 1.34 / (download) - annotate - [select for diffs], Sun Jun 17 15:00:29 2018 UTC (5 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4
Changes since 1.33: +2 -2 lines
Diff to previous 1.33 (colored)

use size_t

Revision 1.33 / (download) - annotate - [select for diffs], Sun Jun 17 14:58:27 2018 UTC (5 years, 11 months ago) by deraadt
Branch: MAIN
Changes since 1.32: +2 -2 lines
Diff to previous 1.32 (colored)

incorrect pointer used, hence gecos expansion was ignored
ok millert

Revision 1.32 / (download) - annotate - [select for diffs], Sat Dec 26 20:51:35 2015 UTC (8 years, 4 months ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.31: +7 -8 lines
Diff to previous 1.31 (colored)

Use pread/pwrite instead separate lseek+read/write for lastlog.
Cast to off_t before multiplication to avoid truncation on ILP32

ok kettenis@ mmcc@

Revision 1.31 / (download) - annotate - [select for diffs], Thu Aug 20 22:32:41 2015 UTC (8 years, 9 months ago) by deraadt
Branch: MAIN
Changes since 1.30: +3 -3 lines
Diff to previous 1.30 (colored)

Do not cast result of malloc/calloc/realloc* if stdlib.h is in scope
ok krw millert

Revision 1.30 / (download) - annotate - [select for diffs], Fri Jan 16 06:40:07 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.29: +1 -2 lines
Diff to previous 1.29 (colored)

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible.  Annotate <sys/param.h> lines with their current reasons.  Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc.  Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution.  These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Revision 1.29 / (download) - annotate - [select for diffs], Wed Nov 19 22:07:13 2014 UTC (9 years, 6 months ago) by millert
Branch: MAIN
Changes since 1.28: +27 -36 lines
Diff to previous 1.28 (colored)

Use stravis() instead of a custom() strvis + mallocarray wrapper.
OK tedu@ tobias@

Revision 1.28 / (download) - annotate - [select for diffs], Tue Nov 18 20:54:28 2014 UTC (9 years, 6 months ago) by krw
Branch: MAIN
Changes since 1.27: +1 -2 lines
Diff to previous 1.27 (colored)

Nuke more obvious #include duplications.

ok deraadt@ millert@ tedu@

Revision 1.27 / (download) - annotate - [select for diffs], Fri Oct 17 20:19:15 2014 UTC (9 years, 7 months ago) by millert
Branch: MAIN
Changes since 1.26: +13 -33 lines
Diff to previous 1.26 (colored)

Instead of doing strvis() of gecos string on output, do it when
storing them in struct person since they are only used for output.
Uses reallocarray() for overflow detection. OK deraadt@

Revision 1.26 / (download) - annotate - [select for diffs], Fri Oct 17 20:16:13 2014 UTC (9 years, 7 months ago) by millert
Branch: MAIN
Changes since 1.25: +3 -3 lines
Diff to previous 1.25 (colored)

Use strlcpy() instead of strncpy() when making a copy of pw_gecos.

Revision 1.25 / (download) - annotate - [select for diffs], Fri Oct 17 08:03:04 2014 UTC (9 years, 7 months ago) by doug
Branch: MAIN
Changes since 1.24: +2 -2 lines
Diff to previous 1.24 (colored)

strvis() requires that the buffer is at least 4 * srclen + 1.

ok deraadt@

Revision 1.24 / (download) - annotate - [select for diffs], Tue Nov 26 13:18:55 2013 UTC (10 years, 5 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5
Changes since 1.23: +3 -3 lines
Diff to previous 1.23 (colored)

unsigned char casts for ctype
ok krw

Revision 1.23 / (download) - annotate - [select for diffs], Tue Oct 27 23:59:38 2009 UTC (14 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.22: +1 -6 lines
Diff to previous 1.22 (colored)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable).  these days, people use source.  these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Revision 1.22 / (download) - annotate - [select for diffs], Tue Aug 23 13:43:53 2005 UTC (18 years, 9 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3, OPENBSD_4_2_BASE, OPENBSD_4_2, OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0, OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8
Changes since 1.21: +26 -4 lines
Diff to previous 1.21 (colored)

use vis() consistently in field printing.

Replace vs() with a version that logs its memory usage, so that it
can be cleaned up after each entry.

okay millert@, delegated by deraadt@

Revision 1.21 / (download) - annotate - [select for diffs], Tue Mar 15 12:28:48 2005 UTC (19 years, 2 months ago) by niallo
Branch: MAIN
CVS Tags: OPENBSD_3_7_BASE, OPENBSD_3_7
Changes since 1.20: +4 -4 lines
Diff to previous 1.20 (colored)

change some silly snprintf(buf, buflen, "%s", login) calls to just use
strlcpy(buf, login, buflen)

ok otto@ henning@

Revision 1.20 / (download) - annotate - [select for diffs], Mon Mar 15 02:50:29 2004 UTC (20 years, 2 months ago) by tedu
Branch: MAIN
CVS Tags: OPENBSD_3_6_BASE, OPENBSD_3_6, OPENBSD_3_5_BASE, OPENBSD_3_5
Changes since 1.19: +19 -19 lines
Diff to previous 1.19 (colored)

Wall, commons, little knf

Revision 1.19 / (download) - annotate - [select for diffs], Wed Jul 2 21:04:10 2003 UTC (20 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.18: +6 -4 lines
Diff to previous 1.18 (colored)

protos

Revision 1.18 / (download) - annotate - [select for diffs], Wed Jun 25 21:10:55 2003 UTC (20 years, 10 months ago) by deraadt
Branch: MAIN
Changes since 1.17: +3 -2 lines
Diff to previous 1.17 (colored)

delete junk protos

Revision 1.17 / (download) - annotate - [select for diffs], Tue Jun 10 22:20:46 2003 UTC (20 years, 11 months ago) by deraadt
Branch: MAIN
Changes since 1.16: +15 -33 lines
Diff to previous 1.16 (colored)

mostly ansi cleanup; pval ok

Revision 1.16 / (download) - annotate - [select for diffs], Tue Jun 3 02:56:08 2003 UTC (20 years, 11 months ago) by millert
Branch: MAIN
Changes since 1.15: +3 -7 lines
Diff to previous 1.15 (colored)

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999.  Proofed by myself and Theo.

Revision 1.15 / (download) - annotate - [select for diffs], Mon Jan 15 18:16:06 2001 UTC (23 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3, OPENBSD_3_2_BASE, OPENBSD_3_2, OPENBSD_3_1_BASE, OPENBSD_3_1, OPENBSD_3_0_BASE, OPENBSD_3_0, OPENBSD_2_9_BASE, OPENBSD_2_9
Changes since 1.14: +3 -3 lines
Diff to previous 1.14 (colored)

typo

Revision 1.14 / (download) - annotate - [select for diffs], Mon Jan 15 16:48:07 2001 UTC (23 years, 4 months ago) by deraadt
Branch: MAIN
Changes since 1.13: +3 -3 lines
Diff to previous 1.13 (colored)

oops

Revision 1.13 / (download) - annotate - [select for diffs], Wed Jan 10 20:10:36 2001 UTC (23 years, 4 months ago) by deraadt
Branch: MAIN
Changes since 1.12: +20 -9 lines
Diff to previous 1.12 (colored)

error out for strdup() failures

Revision 1.11.4.1 / (download) - annotate - [select for diffs], Fri Oct 6 21:16:12 2000 UTC (23 years, 7 months ago) by jason
Branch: OPENBSD_2_7
Changes since 1.11: +3 -3 lines
Diff to previous 1.11 (colored) next main 1.12 (colored)

Pull in patch from current (even more to come):
Fix (millert):
warnx?/errx? paranoia (use "%s" not a bare string unless it is a
constant).  These are not security holes but it is worth fixing
them anyway both for robustness and so folks looking for examples
in the tree are not misled into doing something potentially dangerous.
Furthermore, it is a bad idea to assume that pathnames will not
include '%' in them and that error routines don't return strings
with '%' in them (especially in light of the possibility of locales).

Revision 1.12 / (download) - annotate - [select for diffs], Fri Jun 30 16:00:13 2000 UTC (23 years, 10 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_8_BASE, OPENBSD_2_8
Changes since 1.11: +3 -3 lines
Diff to previous 1.11 (colored)

warnx?/errx? paranoia (use "%s" not a bare string unless it is a
constant).  These are not security holes but it is worth fixing
them anyway both for robustness and so folks looking for examples
in the tree are not misled into doing something potentially dangerous.
Furthermore, it is a bad idea to assume that pathnames will not
include '%' in them and that error routines don't return strings
with '%' in them (especially in light of the possibility of locales).

Revision 1.11 / (download) - annotate - [select for diffs], Tue Aug 17 09:13:15 1999 UTC (24 years, 9 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_7_BASE, OPENBSD_2_6_BASE, OPENBSD_2_6
Branch point for: OPENBSD_2_7
Changes since 1.10: +4 -4 lines
Diff to previous 1.10 (colored)

More <sys/file.h> vs. <fcntl.h> and open() flags fixes.

Revision 1.10 / (download) - annotate - [select for diffs], Fri Jul 10 15:45:19 1998 UTC (25 years, 10 months ago) by mickey
Branch: MAIN
CVS Tags: OPENBSD_2_5_BASE, OPENBSD_2_5, OPENBSD_2_4_BASE, OPENBSD_2_4
Changes since 1.9: +8 -12 lines
Diff to previous 1.9 (colored)

err/warn

Revision 1.9 / (download) - annotate - [select for diffs], Fri Jan 9 17:17:39 1998 UTC (26 years, 4 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_3_BASE, OPENBSD_2_3
Changes since 1.8: +4 -7 lines
Diff to previous 1.8 (colored)

Fix PR 379.  Don't recycle the malloc'd space in vs().

Revision 1.8 / (download) - annotate - [select for diffs], Mon Jun 30 06:24:47 1997 UTC (26 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_2_BASE, OPENBSD_2_2
Changes since 1.7: +3 -3 lines
Diff to previous 1.7 (colored)

clarify why the long typecast is there

Revision 1.7 / (download) - annotate - [select for diffs], Tue Jun 17 21:00:01 1997 UTC (26 years, 11 months ago) by kstailey
Branch: MAIN
Changes since 1.6: +3 -3 lines
Diff to previous 1.6 (colored)

(foo *)NULL -> NULL

Revision 1.6 / (download) - annotate - [select for diffs], Mon Jun 2 21:33:28 1997 UTC (26 years, 11 months ago) by kstailey
Branch: MAIN
Changes since 1.5: +25 -2 lines
Diff to previous 1.5 (colored)

do strvis()ing in sprint.c

Revision 1.5 / (download) - annotate - [select for diffs], Fri May 30 23:35:53 1997 UTC (26 years, 11 months ago) by kstailey
Branch: MAIN
Changes since 1.4: +76 -67 lines
Diff to previous 1.4 (colored)

Integrate changed from NetBSD being careful not to step on our important
stuff (like the -M flag and things.)

Revision 1.4 / (download) - annotate - [select for diffs], Fri Aug 30 11:39:36 1996 UTC (27 years, 8 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_1_BASE, OPENBSD_2_1, OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.3: +22 -8 lines
Diff to previous 1.3 (colored)

buf oflow; found by das33@cornell.edu and us crazy calgary night owls

Revision 1.3 / (download) - annotate - [select for diffs], Wed Aug 7 17:49:49 1996 UTC (27 years, 9 months ago) by downsj
Branch: MAIN
Changes since 1.2: +7 -6 lines
Diff to previous 1.2 (colored)

People can be 'logged in' from non-existant devices.

Revision 1.2 / (download) - annotate - [select for diffs], Wed Jun 26 05:33:19 1996 UTC (27 years, 10 months ago) by deraadt
Branch: MAIN
Changes since 1.1: +3 -1 lines
Diff to previous 1.1 (colored)

rcsid

Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Wed Oct 18 08:45:14 1995 UTC (28 years, 7 months ago) by deraadt
CVS Tags: netbsd_1_1
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)

initial import of NetBSD tree

Revision 1.1 / (download) - annotate - [select for diffs], Wed Oct 18 08:45:14 1995 UTC (28 years, 7 months ago) by deraadt
Branch: MAIN

Initial revision

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.