OpenBSD CVS

CVS log for src/usr.bin/ftp/complete.c


[BACK] Up to [local] / src / usr.bin / ftp

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.33 / (download) - annotate - [select for diffs], Thu May 16 12:44:17 2019 UTC (5 years ago) by florian
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6, HEAD
Changes since 1.32: +0 -0 lines
Diff to previous 1.32 (colored)

Revert suni'ls ftp rewrite for now.
We are juggling too many things at the moment and we can't deal with
the differences in behaviour right now.

Revision 1.32, Sun May 12 20:44:39 2019 UTC (5 years ago) by kmos
Branch: MAIN
Changes since 1.31: +1 -1 lines
FILE REMOVED

Move us from old ftp(1) to Sunil's new ftp(1). The necessary modifications
have been made to make it behave. Any new misbehaviors can be fixed in tree.

OK florian@ deraadt@ "Have you committed ftp yet?"

Revision 1.31 / (download) - annotate - [select for diffs], Tue Aug 1 15:04:44 2017 UTC (6 years, 9 months ago) by anton
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2
Changes since 1.30: +1 -2 lines
Diff to previous 1.30 (colored)

Remove self assignment.

ok deraadt@

Revision 1.30 / (download) - annotate - [select for diffs], Sat Jan 21 08:33:07 2017 UTC (7 years, 3 months ago) by krw
Branch: MAIN
CVS Tags: OPENBSD_6_1_BASE, OPENBSD_6_1
Changes since 1.29: +2 -2 lines
Diff to previous 1.29 (colored)

Nuke whitespace foolish enough to expose itself during the great
"warning:" rectification.

Revision 1.29 / (download) - annotate - [select for diffs], Sun Oct 18 03:04:11 2015 UTC (8 years, 7 months ago) by mmcc
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.28: +2 -2 lines
Diff to previous 1.28 (colored)

A whole buncha unsigned char casts for ctype function arguments.

ok guenther@

Revision 1.28 / (download) - annotate - [select for diffs], Fri Jan 16 06:40:08 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.27: +5 -5 lines
Diff to previous 1.27 (colored)

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible.  Annotate <sys/param.h> lines with their current reasons.  Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc.  Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution.  These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Revision 1.27 / (download) - annotate - [select for diffs], Wed Apr 23 11:47:04 2014 UTC (10 years ago) by jca
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6
Changes since 1.26: +1 -2 lines
Diff to previous 1.26 (colored)

Kill useless assignement, matchlen is initialized two lines below.
From Fritjof Bornebusch.

Revision 1.26 / (download) - annotate - [select for diffs], Mon Apr 26 16:51:59 2010 UTC (14 years ago) by stsp
Branch: MAIN
CVS Tags: OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8
Changes since 1.25: +2 -2 lines
Diff to previous 1.25 (colored)

Fix a bug in auto-completion accidentally introduced when support
for auto-completion of filenames containing whitespace was added.
This bug was tracked a decade ago in NetBSD as pr 7014.
ok deraadt

Revision 1.25 / (download) - annotate - [select for diffs], Sun Apr 25 14:32:04 2010 UTC (14 years ago) by tedu
Branch: MAIN
Changes since 1.24: +6 -17 lines
Diff to previous 1.24 (colored)

ftpvis was not ok.  fix it.

Revision 1.24 / (download) - annotate - [select for diffs], Sun Apr 25 09:11:54 2010 UTC (14 years ago) by stsp
Branch: MAIN
Changes since 1.23: +49 -6 lines
Diff to previous 1.23 (colored)

Fix auto-completion of filenames containing whitespace.
Before this change whitespace wasn't escaped during completion which
caused the ftp command to see multiple arguments where a single path
was expected.  Based on similar commit made to NetBSD's ftp in 1999.

help and ok uwe tedu deraadt

Revision 1.23 / (download) - annotate - [select for diffs], Tue May 5 19:35:30 2009 UTC (15 years ago) by martynas
Branch: MAIN
CVS Tags: OPENBSD_4_7_BASE, OPENBSD_4_7, OPENBSD_4_6_BASE, OPENBSD_4_6
Changes since 1.22: +2 -3 lines
Diff to previous 1.22 (colored)

make it clean removing the ifdef SMALL maze.  separate cmds and
small stuff.  make it a fetcher.  shrinks quite a bit
agreed by millert@, krw@
ok theo, sthen@

Revision 1.22 / (download) - annotate - [select for diffs], Mon Apr 27 21:37:13 2009 UTC (15 years ago) by deraadt
Branch: MAIN
Changes since 1.21: +1 -4 lines
Diff to previous 1.21 (colored)

toast the rcsid strings which just get in the way

Revision 1.21 / (download) - annotate - [select for diffs], Tue Jul 8 21:07:57 2008 UTC (15 years, 10 months ago) by martynas
Branch: MAIN
CVS Tags: OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4
Changes since 1.20: +4 -2 lines
Diff to previous 1.20 (colored)

- add support for recursive transfers (but not for floppies), e.g.
'mget -cr 4.*' would recursively fetch (-r), and resume the previous
transfers (-c) of 4.X release directories
uses local matching (fnmatch), but only for recursive transfers.
current behavior is not changed in any way.
- while here, ifndef SMALL debugging stuff, this saves some space,
for floppies
- some debugging code was enabled for non-debugging mode, checks
assume debug is set to zero, but it's not initially set
- all "Confirm with" prompts are forced, remove redundant argument
- fix usage: -C and -c are not available for SMALL

discussed a year ago w/ pyr@
looks good to millert@
previous version looked good to pyr@
man page tweaks & ok jmc@

Revision 1.20 / (download) - annotate - [select for diffs], Thu Jun 26 05:42:20 2008 UTC (15 years, 10 months ago) by ray
Branch: MAIN
Changes since 1.19: +2 -9 lines
Diff to previous 1.19 (colored)

First pass at removing clauses 3 and 4 from NetBSD licenses.

Not sure what's more surprising: how long it took for NetBSD to
catch up to the rest of the BSDs (including UCB), or the amount of
code that NetBSD has claimed for itself without attributing to the
actual authors.

OK deraadt@

Revision 1.19 / (download) - annotate - [select for diffs], Fri Jun 23 20:35:25 2006 UTC (17 years, 10 months ago) by steven
Branch: MAIN
CVS Tags: OPENBSD_4_3_BASE, OPENBSD_4_3, OPENBSD_4_2_BASE, OPENBSD_4_2, OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0
Changes since 1.18: +3 -4 lines
Diff to previous 1.18 (colored)

free and sl_free already check against NULL, remove a few unneeded ifs.

ok otto

Revision 1.18 / (download) - annotate - [select for diffs], Tue Apr 25 05:45:20 2006 UTC (18 years ago) by tedu
Branch: MAIN
Changes since 1.17: +2 -2 lines
Diff to previous 1.17 (colored)

two strtol calls that were begging to be converted to strtonum

Revision 1.17 / (download) - annotate - [select for diffs], Thu Sep 16 04:39:16 2004 UTC (19 years, 8 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7
Changes since 1.16: +18 -19 lines
Diff to previous 1.16 (colored)

type corrections and other delinting

Revision 1.16 / (download) - annotate - [select for diffs], Tue Jul 20 03:50:25 2004 UTC (19 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_6_BASE, OPENBSD_3_6
Changes since 1.15: +8 -20 lines
Diff to previous 1.15 (colored)

ansi; khalek@linuxgamers.net

Revision 1.15 / (download) - annotate - [select for diffs], Fri Jul 9 17:11:22 2004 UTC (19 years, 10 months ago) by millert
Branch: MAIN
Changes since 1.14: +4 -3 lines
Diff to previous 1.14 (colored)

You can only use strlcpy() on real C strings, which lf->buffer is not.
Use memcpy() instead and NUL terminate.

Revision 1.14 / (download) - annotate - [select for diffs], Sat Apr 5 17:19:47 2003 UTC (21 years, 1 month ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_5_BASE, OPENBSD_3_5, OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.13: +4 -4 lines
Diff to previous 1.13 (colored)

string fixes; ok miod henning

Revision 1.13 / (download) - annotate - [select for diffs], Sat Feb 16 21:27:46 2002 UTC (22 years, 3 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3, OPENBSD_3_2_BASE, OPENBSD_3_2, OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.12: +7 -7 lines
Diff to previous 1.12 (colored)

Part one of userland __P removal.  Done with a simple regexp with some minor hand editing to make comments line up correctly.  Another pass is forthcoming that handles the cases that could not be done automatically.

Revision 1.12 / (download) - annotate - [select for diffs], Fri Aug 3 22:43:16 2001 UTC (22 years, 9 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0
Changes since 1.11: +5 -4 lines
Diff to previous 1.11 (colored)

Add back NUL termination of 'word' in complete() that was erroneously
removed in strlcpy() conversion.  Previously we were trying to
strlcpy() a pointer that could be NULL.  Now we check that the
length != 0 and use memcpy() instead, then NUL terminate by hand
to catch the other cases.  Core dump noticed by fgs@

Revision 1.11 / (download) - annotate - [select for diffs], Tue Jun 26 23:44:00 2001 UTC (22 years, 10 months ago) by lebel
Branch: MAIN
Changes since 1.10: +7 -12 lines
Diff to previous 1.10 (colored)

use strlcpy vs strncpy+a[len-1]='\0'.  millert@ ok.

Revision 1.10 / (download) - annotate - [select for diffs], Fri Mar 9 17:01:02 2001 UTC (23 years, 2 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_9_BASE, OPENBSD_2_9
Changes since 1.9: +4 -2 lines
Diff to previous 1.9 (colored)

Add a missing newline in debug mode to separate debug output from
line containing command completion; "Brian J. Kifiak" <bk@rt.fm>

Revision 1.9 / (download) - annotate - [select for diffs], Thu Sep 4 04:37:14 1997 UTC (26 years, 8 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_8_BASE, OPENBSD_2_8, OPENBSD_2_7_BASE, OPENBSD_2_7, OPENBSD_2_6_BASE, OPENBSD_2_6, OPENBSD_2_5_BASE, OPENBSD_2_5, OPENBSD_2_4_BASE, OPENBSD_2_4, OPENBSD_2_3_BASE, OPENBSD_2_3, OPENBSD_2_2_BASE, OPENBSD_2_2
Changes since 1.8: +5 -5 lines
Diff to previous 1.8 (colored)

Updtaes from NetBSD (lukem)
    bugs fixed:
      * don't interpret '-' or '|' when a local filename is determined from
        the remote name (i.e, in mget, and in get with only one argument).
        This is implemented using an extra argument to recvrequest().
        Fixes a major security hole.
      * clean up memory leak when using globulize()
      * clean up a couple of comments
      * fix wording in TNF copyright

    features added:
      * support for TIS fwtk gate-ftp servers:
        * read defaults from $FTPSERVER && $FTPSERVERPORT
        * start in gate-ftp mode if invoked as 'gate-ftp'
        * toggle or set with 'gate [host [port]]'

Other changes:
    * use symbolic flags in access(2)
    * Use USHRT_MAX, not 0xffff

Revision 1.8 / (download) - annotate - [select for diffs], Fri Jul 25 21:56:18 1997 UTC (26 years, 10 months ago) by millert
Branch: MAIN
Changes since 1.7: +25 -33 lines
Diff to previous 1.7 (colored)

Updates from NetBSD (lukem) include -Wall cleanup.
More -W* cleanup and in_port_t usage by me.

Revision 1.7 / (download) - annotate - [select for diffs], Wed Apr 23 20:33:00 1997 UTC (27 years, 1 month ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_1_BASE, OPENBSD_2_1
Changes since 1.6: +5 -5 lines
Diff to previous 1.6 (colored)

allow "ftp -aV ftp://host/foo.tar.gz | tar xvfpz -" to work

Revision 1.6 / (download) - annotate - [select for diffs], Wed Apr 16 05:02:43 1997 UTC (27 years, 1 month ago) by millert
Branch: MAIN
Changes since 1.5: +5 -5 lines
Diff to previous 1.5 (colored)

Sync with NetBSD (lukem):
 * differentiate between being connected, and being logged in
 * cleanup some text messages
 * support username & password ftp URLs (ftp://user:pass@host/) in non-proxy
   situations; assume proxy supports it for proxy situations.
 * cd to / before performing any autofetch transfers

Revision 1.5 / (download) - annotate - [select for diffs], Fri Mar 21 20:59:28 1997 UTC (27 years, 2 months ago) by millert
Branch: MAIN
Changes since 1.4: +19 -14 lines
Diff to previous 1.4 (colored)

Add in recent NetBSD changes we didn't already have:
    Always compile complete.c but ifdef out the bits if -DSMALL (christos)
    reset interactive mode correctly in auto_fetch() mget mode (lukem)

Revision 1.4 / (download) - annotate - [select for diffs], Fri Mar 14 04:32:13 1997 UTC (27 years, 2 months ago) by millert
Branch: MAIN
Changes since 1.3: +63 -50 lines
Diff to previous 1.3 (colored)

Sync with NetBSD and fix "get foo.txt /dev/tty" wrt progress meter
and setting times.

Revision 1.3 / (download) - annotate - [select for diffs], Wed Feb 5 04:55:14 1997 UTC (27 years, 3 months ago) by millert
Branch: MAIN
Changes since 1.2: +6 -6 lines
Diff to previous 1.2 (colored)

Include signal.h where reasonable and make signal handlers match
what signal(3)'s prototype says (and cast when not).
Also change MAXFOO+1 -> MAXFOO since MAXFOO includes the NULL.
Support $TMPDIR and use utime(3) not utimes(2) for portability's sake.
Don't spew "Passive mode enabled/disabled" unless verbose (this means
togglevar() needs to watch for a NULL 'message').

Revision 1.2 / (download) - annotate - [select for diffs], Mon Feb 3 01:05:35 1997 UTC (27 years, 3 months ago) by millert
Branch: MAIN
Changes since 1.1: +3 -2 lines
Diff to previous 1.1 (colored)

Add back ``-r'' option and fix strncpy() usage and other nits because
I'm anal.  Closer to KNF now.

Revision 1.1 / (download) - annotate - [select for diffs], Mon Feb 3 01:02:34 1997 UTC (27 years, 3 months ago) by millert
Branch: MAIN

Sync with NetBSD

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.