![[BACK]](/icons/back.gif){kind=icon}
Up to [local] / src / usr.bin / less
Request diff between arbitrary revisions
Default branch: MAIN
Revision 1.32 / (download) - annotate - [select for diffs], Tue Apr 16 10:19:00 2024 UTC (4 weeks, 5 days ago) by jsg
Branch: MAIN
CVS Tags: HEAD
Changes since 1.31: +0 -79 lines
Diff to previous 1.31 (colored)
remove unused functions; ok tb@
Revision 1.31 / (download) - annotate - [select for diffs], Sun Apr 14 18:11:54 2024 UTC (4 weeks, 6 days ago) by guenther
Branch: MAIN
Changes since 1.30: +0 -177 lines
Diff to previous 1.30 (colored)
Delete support for the LESSOPEN and LESSCLOSE environment variables aka the "Input Preprocessor": it's been a source for multiple security bugs in the past as everything has to deal with handling arbitrary filenames and generally resulted in multiple TOCTOU issues. The base system never included a default LESSOPEN setting like some Linux distributions did, but it's a suds-filled sink full of knives to try to use safely. ok tb@ deraadt@ millert@
Revision 1.30 / (download) - annotate - [select for diffs], Sun Apr 14 08:34:00 2024 UTC (5 weeks ago) by tb
Branch: MAIN
Changes since 1.29: +22 -5 lines
Diff to previous 1.29 (colored)
less: escape newlines in file names Newlines in a filename can lead to arbitrary code execution https://marc.info/?l=oss-security&m=171292433330233&w=2 via LESSOPEN. The diff is a straightforward adaptation of https://github.com/gwsw/less/commit/007521ac3c95bc76 The better fix is deleting the misfeatures that are LESSOPEN and LESSCLOSE which will happen in a separate commit. diff looks good to guenther
Revision 1.29 / (download) - annotate - [select for diffs], Fri Jun 28 13:35:01 2019 UTC (4 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE,
OPENBSD_7_5,
OPENBSD_7_4_BASE,
OPENBSD_7_4,
OPENBSD_7_3_BASE,
OPENBSD_7_3,
OPENBSD_7_2_BASE,
OPENBSD_7_2,
OPENBSD_7_1_BASE,
OPENBSD_7_1,
OPENBSD_7_0_BASE,
OPENBSD_7_0,
OPENBSD_6_9_BASE,
OPENBSD_6_9,
OPENBSD_6_8_BASE,
OPENBSD_6_8,
OPENBSD_6_7_BASE,
OPENBSD_6_7,
OPENBSD_6_6_BASE,
OPENBSD_6_6
Changes since 1.28: +2 -2 lines
Diff to previous 1.28 (colored)
When system calls indicate an error they return -1, not some arbitrary value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.
Revision 1.28 / (download) - annotate - [select for diffs], Tue May 7 14:26:38 2019 UTC (5 years ago) by schwarze
Branch: MAIN
Changes since 1.27: +12 -12 lines
Diff to previous 1.27 (colored)
Completely clean up UTF-8 handling in the file filename.c: Employ the usual form of an mbtowc(3) loop, eliminating two calls to the bad function step_char() and reducing the number of nested loops by one. This also removes the last caller of the bad function binary_char(), which is consequently deleted. While here, count ASCII C0 non-whitespace control characters as binary (except backspace and, with -R only, escape). OK millert@
Revision 1.27 / (download) - annotate - [select for diffs], Tue Feb 26 11:01:54 2019 UTC (5 years, 2 months ago) by schwarze
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE,
OPENBSD_6_5
Changes since 1.26: +1 -1 lines
Diff to previous 1.26 (colored)
To simplify the upcoming UTF-8 cleanup in less(1), delete support for ANSI escape sequences introduced by an 8-bit CSI (e.g. "\23343m") because these are neither compatible with UTF-8 nor strictly compatible with pure ASCII and for those introduced by an UTF-8 CSI (e.g. "\302\23343m") because not even xterm(1) supports them at all, not even with a non-default configuration, because both forms are very rarely used, if at all, and because the current code trying to support them doesn't even appear to work according to my tests. Full support for the ESC-[ CSI (e.g. "\033[43m") remains. Tweaks and OK millert@, OK nicm@, and sthen@ agrees with the general direction.
Revision 1.26 / (download) - annotate - [select for diffs], Sun Oct 29 17:10:55 2017 UTC (6 years, 6 months ago) by schwarze
Branch: MAIN
CVS Tags: OPENBSD_6_4_BASE,
OPENBSD_6_4,
OPENBSD_6_3_BASE,
OPENBSD_6_3
Changes since 1.25: +1 -16 lines
Diff to previous 1.25 (colored)
After fstat(2) failure, trying lseek(2) is useless, so delete it. Based on a smaller diff from Jesper Wallin <jesper at ifconfig dot se>. OK deraadt@
Revision 1.25 / (download) - annotate - [select for diffs], Sat Sep 17 15:06:41 2016 UTC (7 years, 8 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_2_BASE,
OPENBSD_6_2,
OPENBSD_6_1_BASE,
OPENBSD_6_1
Changes since 1.24: +4 -4 lines
Diff to previous 1.24 (colored)
little bit more KNF
Revision 1.24 / (download) - annotate - [select for diffs], Wed Mar 16 15:36:26 2016 UTC (8 years, 2 months ago) by mmcc
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE,
OPENBSD_6_0
Changes since 1.23: +3 -2 lines
Diff to previous 1.23 (colored)
style(9) includes ok nicm@
Revision 1.23 / (download) - annotate - [select for diffs], Fri Jan 29 04:51:26 2016 UTC (8 years, 3 months ago) by mmcc
Branch: MAIN
CVS Tags: OPENBSD_5_9_BASE,
OPENBSD_5_9
Changes since 1.22: +1 -1 lines
Diff to previous 1.22 (colored)
remove superfluous macro ok nicm
Revision 1.22 / (download) - annotate - [select for diffs], Mon Nov 9 16:46:42 2015 UTC (8 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.21: +3 -3 lines
Diff to previous 1.21 (colored)
NULL_IFILE has no weird use patterns. NULL is sufficient.
Revision 1.21 / (download) - annotate - [select for diffs], Mon Nov 9 16:42:35 2015 UTC (8 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.20: +2 -2 lines
Diff to previous 1.20 (colored)
use (off_t)-1 rather than a BAD_LSEEK wrapper
Revision 1.20 / (download) - annotate - [select for diffs], Mon Nov 9 16:39:13 2015 UTC (8 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.19: +2 -2 lines
Diff to previous 1.19 (colored)
error() is not a stdarg function, so there is no reason for NULL_PARG to be special. Simply use NULL.
Revision 1.19 / (download) - annotate - [select for diffs], Sat Nov 7 18:07:44 2015 UTC (8 years, 6 months ago) by tedu
Branch: MAIN
Changes since 1.18: +2 -2 lines
Diff to previous 1.18 (colored)
replace save() with estrdup() and make estrdup() exit like all the other ecalloc, etc. functions do. ok mmcc nicm
Revision 1.18 / (download) - annotate - [select for diffs], Fri Nov 6 15:50:33 2015 UTC (8 years, 6 months ago) by nicm
Branch: MAIN
Changes since 1.17: +2 -4 lines
Diff to previous 1.17 (colored)
Garrett D'Amore has agreed to moving his copyright line up above the terms with the existing copyright, so it is clear it applies the same terms.
Revision 1.17 / (download) - annotate - [select for diffs], Thu Nov 5 22:08:44 2015 UTC (8 years, 6 months ago) by nicm
Branch: MAIN
Changes since 1.16: +234 -588 lines
Diff to previous 1.16 (colored)
Replace less with the cleaned-up fork of less 458 maintained by Garrett D'Amore at https://github.com/gdamore/less-fork. This has significantly less portability goop, has a tidied up code style, uses terminfo instead of termcap, and is has stricter POSIX compliance. Many of our local changes have been accepted upstream: substantial remaining local changes are code to read help files from /usr/share rather than compiling them in, man page and help improvements, and some tweaks to the default options. Review and testing by millert, ok deraadt
Revision 1.16 / (download) - annotate - [select for diffs], Fri Apr 25 13:38:21 2014 UTC (10 years ago) by shadchin
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE,
OPENBSD_5_8,
OPENBSD_5_7_BASE,
OPENBSD_5_7,
OPENBSD_5_6_BASE,
OPENBSD_5_6
Changes since 1.15: +55 -39 lines
Diff to previous 1.15 (colored)
Merge Less 458 plus local patches ok guenther@, ok jmc@ for man bits
Revision 1.1.1.4 / (download) - annotate - [select for diffs] (vendor branch), Fri Apr 25 13:33:46 2014 UTC (10 years ago) by shadchin
Branch: markn,
MARK_NUDELMAN
CVS Tags: LESS_458
Changes since 1.1.1.3: +79 -32 lines
Diff to previous 1.1.1.3 (colored)
Import of Less 458 ok guenther@
Revision 1.15 / (download) - annotate - [select for diffs], Fri Sep 16 18:12:09 2011 UTC (12 years, 8 months ago) by shadchin
Branch: MAIN
CVS Tags: OPENBSD_5_5_BASE,
OPENBSD_5_5,
OPENBSD_5_4_BASE,
OPENBSD_5_4,
OPENBSD_5_3_BASE,
OPENBSD_5_3,
OPENBSD_5_2_BASE,
OPENBSD_5_2,
OPENBSD_5_1_BASE,
OPENBSD_5_1
Changes since 1.14: +75 -50 lines
Diff to previous 1.14 (colored)
Merge in less 444 plus local changes ok nicm@
Revision 1.1.1.3 / (download) - annotate - [select for diffs] (vendor branch), Fri Sep 16 17:47:04 2011 UTC (12 years, 8 months ago) by shadchin
Branch: markn,
MARK_NUDELMAN
CVS Tags: LESS_444
Changes since 1.1.1.2: +91 -37 lines
Diff to previous 1.1.1.2 (colored)
Import of Less 444 ok nicm@
Revision 1.14 / (download) - annotate - [select for diffs], Sat Jul 3 16:29:46 2010 UTC (13 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_0_BASE,
OPENBSD_5_0,
OPENBSD_4_9_BASE,
OPENBSD_4_9,
OPENBSD_4_8_BASE,
OPENBSD_4_8
Changes since 1.13: +2 -0 lines
Diff to previous 1.13 (colored)
use SMALL_PROGRAM to knock out some code
Revision 1.13 / (download) - annotate - [select for diffs], Wed Dec 6 05:03:29 2006 UTC (17 years, 5 months ago) by ray
Branch: MAIN
CVS Tags: OPENBSD_4_7_BASE,
OPENBSD_4_7,
OPENBSD_4_6_BASE,
OPENBSD_4_6,
OPENBSD_4_5_BASE,
OPENBSD_4_5,
OPENBSD_4_4_BASE,
OPENBSD_4_4,
OPENBSD_4_3_BASE,
OPENBSD_4_3,
OPENBSD_4_2_BASE,
OPENBSD_4_2,
OPENBSD_4_1_BASE,
OPENBSD_4_1
Changes since 1.12: +2 -1 lines
Diff to previous 1.12 (colored)
Don't access buf[strlen(buf) - 1] for zero-length strings. OK jaredy@.
Revision 1.12 / (download) - annotate - [select for diffs], Tue May 23 18:32:52 2006 UTC (18 years ago) by otto
Branch: MAIN
CVS Tags: OPENBSD_4_0_BASE,
OPENBSD_4_0
Changes since 1.11: +1 -1 lines
Diff to previous 1.11 (colored)
Fix removing of trailing space in file name completion list. From Matthew Haub; ok krw@
Revision 1.11 / (download) - annotate - [select for diffs], Sun Apr 2 00:55:32 2006 UTC (18 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.10: +2 -2 lines
Diff to previous 1.10 (colored)
use SEEK_* for lseek()
Revision 1.10 / (download) - annotate - [select for diffs], Mon Aug 23 17:56:20 2004 UTC (19 years, 8 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_9_BASE,
OPENBSD_3_9,
OPENBSD_3_8_BASE,
OPENBSD_3_8,
OPENBSD_3_7_BASE,
OPENBSD_3_7,
OPENBSD_3_6_BASE,
OPENBSD_3_6
Changes since 1.9: +32 -8 lines
Diff to previous 1.9 (colored)
Do %s replacement for LESSOPEN and LESSCLOSE ourselves instead of using snprintf(). Based on a patch from Brent Graveland. Ok tdeval@ and otto@
Revision 1.9 / (download) - annotate - [select for diffs], Mon Apr 14 14:33:57 2003 UTC (21 years, 1 month ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_5_BASE,
OPENBSD_3_5,
OPENBSD_3_4_BASE,
OPENBSD_3_4
Changes since 1.8: +19 -0 lines
Diff to previous 1.8 (colored)
o go back to using a help file instead of embedding it in the binary o deal with HELPFILE not being defined o add a SMALL definition to make a smaller less for the boot floppies This still needs to be pared down a bit for the SMALL case
Revision 1.8 / (download) - annotate - [select for diffs], Sun Apr 13 18:26:25 2003 UTC (21 years, 1 month ago) by millert
Branch: MAIN
Changes since 1.7: +604 -290 lines
Diff to previous 1.7 (colored)
Merge in less-381 w/ local changes and remove obsolete files.
Revision 1.1.1.2 / (download) - annotate - [select for diffs] (vendor branch), Sun Apr 13 18:21:21 2003 UTC (21 years, 1 month ago) by millert
Branch: markn,
MARK_NUDELMAN
CVS Tags: LESS_381
Changes since 1.1.1.1: +586 -276 lines
Diff to previous 1.1.1.1 (colored)
Stock less-390 with some unneeded DOS/Windoze files removed
Revision 1.7 / (download) - annotate - [select for diffs], Sun Apr 6 23:38:06 2003 UTC (21 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.6: +15 -11 lines
Diff to previous 1.6 (colored)
more strlcpy/strlcat/snprintf, less strcpy/strcat/sprintf reviewed by tdeval, millert, dhartmei and others. more bits coming here from some of them i think
Revision 1.6 / (download) - annotate - [select for diffs], Sun Apr 6 18:42:57 2003 UTC (21 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.5: +3 -3 lines
Diff to previous 1.5 (colored)
very simple strlcat calls
Revision 1.5 / (download) - annotate - [select for diffs], Sat Apr 5 01:03:35 2003 UTC (21 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.4: +15 -11 lines
Diff to previous 1.4 (colored)
some more string shit; krw ok
Revision 1.4 / (download) - annotate - [select for diffs], Thu Mar 13 09:09:32 2003 UTC (21 years, 2 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE,
OPENBSD_3_3
Changes since 1.3: +10 -10 lines
Diff to previous 1.3 (colored)
lots of sprintf -> snprintf and strcpy -> strlcpy; checked by tedu
Revision 1.3 / (download) - annotate - [select for diffs], Mon Nov 19 19:02:14 2001 UTC (22 years, 6 months ago) by mpech
Branch: MAIN
CVS Tags: OPENBSD_3_2_BASE,
OPENBSD_3_2,
OPENBSD_3_1_BASE,
OPENBSD_3_1
Changes since 1.2: +11 -11 lines
Diff to previous 1.2 (colored)
kill more registers millert@ ok
Revision 1.2 / (download) - annotate - [select for diffs], Mon Jan 29 01:58:01 2001 UTC (23 years, 3 months ago) by niklas
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE,
OPENBSD_3_0,
OPENBSD_2_9_BASE,
OPENBSD_2_9
Changes since 1.1: +2 -0 lines
Diff to previous 1.1 (colored)
$OpenBSD$
Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Sat Sep 21 05:39:42 1996 UTC (27 years, 8 months ago) by etheisen
Branch: markn,
MARK_NUDELMAN
CVS Tags: less_290,
OPENBSD_2_8_BASE,
OPENBSD_2_8,
OPENBSD_2_7_BASE,
OPENBSD_2_7,
OPENBSD_2_6_BASE,
OPENBSD_2_6,
OPENBSD_2_5_BASE,
OPENBSD_2_5,
OPENBSD_2_4_BASE,
OPENBSD_2_4,
OPENBSD_2_3_BASE,
OPENBSD_2_3,
OPENBSD_2_2_BASE,
OPENBSD_2_2,
OPENBSD_2_1_BASE,
OPENBSD_2_1,
OPENBSD_2_0_BASE,
OPENBSD_2_0
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)
Import of unmolested less-290.
Revision 1.1 / (download) - annotate - [select for diffs], Sat Sep 21 05:39:42 1996 UTC (27 years, 8 months ago) by etheisen
Branch: MAIN
Initial revision