OpenBSD CVS

CVS log for src/usr.bin/less/funcs.h


[BACK] Up to [local] / src / usr.bin / less

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.26 / (download) - annotate - [select for diffs], Sun Apr 14 18:11:54 2024 UTC (4 weeks, 6 days ago) by guenther
Branch: MAIN
CVS Tags: HEAD
Changes since 1.25: +0 -2 lines
Diff to previous 1.25 (colored)

Delete support for the LESSOPEN and LESSCLOSE environment variables
aka the "Input Preprocessor": it's been a source for multiple
security bugs in the past as everything has to deal with handling
arbitrary filenames and generally resulted in multiple TOCTOU issues.
The base system never included a default LESSOPEN setting like some
Linux distributions did, but it's a suds-filled sink full of knives
to try to use safely.

ok tb@ deraadt@ millert@

Revision 1.25 / (download) - annotate - [select for diffs], Mon Sep 2 14:07:45 2019 UTC (4 years, 8 months ago) by schwarze
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.24: +0 -1 lines
Diff to previous 1.24 (colored)

Delete what remains of the support for combining characters into
ligatures: it was incomplete (only for the Arabic script and only
for the single ligature LAM WITH ALEF) and it was implemented in a
way that is unsustainable (with a static table inside less).

If we ever want ligature support, we are better off making a fresh
start.  However, for languages like Arabic and Persian, even that
wouldn't really be useful without having bidirectional support first.

OK millert@
(and also considering comments from Mohammadreza Abdollahzadeh,
Evan Silberman, and benno@)

Revision 1.24 / (download) - annotate - [select for diffs], Sat Aug 31 13:44:29 2019 UTC (4 years, 8 months ago) by schwarze
Branch: MAIN
Changes since 1.23: +1 -0 lines
Diff to previous 1.23 (colored)

New utility function mbtowc_left() because this functionality -
decoding a UTF-8 multibyte character to the left of a given byte -
is already needed at three places in line.c and will also be needed
for cleanup work in cmdbuf.c in the future.
OK millert@

Revision 1.23 / (download) - annotate - [select for diffs], Wed May 15 19:36:20 2019 UTC (5 years ago) by schwarze
Branch: MAIN
Changes since 1.22: +0 -2 lines
Diff to previous 1.22 (colored)

trivial patch to at least make the buggy functions control_char()
and get_wchar() static for now - until they can be deleted

Revision 1.22 / (download) - annotate - [select for diffs], Wed May 15 18:18:08 2019 UTC (5 years ago) by schwarze
Branch: MAIN
Changes since 1.21: +0 -1 lines
Diff to previous 1.21 (colored)

Clean up all major UTF-8 issues in cvt.c.
This also allows to delete the buggy, now unused function put_wchar().
OK millert@

Revision 1.21 / (download) - annotate - [select for diffs], Tue May 7 14:26:38 2019 UTC (5 years ago) by schwarze
Branch: MAIN
Changes since 1.20: +0 -1 lines
Diff to previous 1.20 (colored)

Completely clean up UTF-8 handling in the file filename.c:
Employ the usual form of an mbtowc(3) loop, eliminating two calls
to the bad function step_char() and reducing the number of nested
loops by one.  This also removes the last caller of the bad function
binary_char(), which is consequently deleted.
While here, count ASCII C0 non-whitespace control characters as
binary (except backspace and, with -R only, escape).
OK millert@

Revision 1.20 / (download) - annotate - [select for diffs], Fri Mar 1 14:31:34 2019 UTC (5 years, 2 months ago) by schwarze
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5
Changes since 1.19: +0 -2 lines
Diff to previous 1.19 (colored)

Start UTF-8 cleanup of store_char(), in particular getting rid of
a call to the flawed function step_char(-1), using the standard
function mbtowc(3) instead.
Merge in in_ansi_esc_seq(), simplifying the code, and make the
related functions is_ansi_end() and is_ascii_char() static because
they are used in line.c only.

OK nicm@, and no opposition when shown on tech@

Revision 1.19 / (download) - annotate - [select for diffs], Sat Mar 17 14:03:36 2018 UTC (6 years, 2 months ago) by krw
Branch: MAIN
CVS Tags: OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3
Changes since 1.18: +1 -1 lines
Diff to previous 1.18 (colored)

Split only LESS on $.

As guenther@ said "STOP SPLITTING ANYTHING BUT $LESS ON '$' !".

anton@ came up with the same diff. ok nicm@

Revision 1.18 / (download) - annotate - [select for diffs], Tue Jan 19 06:14:54 2016 UTC (8 years, 4 months ago) by mmcc
Branch: MAIN
CVS Tags: OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.17: +0 -1 lines
Diff to previous 1.17 (colored)

Remove the lintism PRINTFLIKE1, don't replace it with an attribute so we
can keep it portable.

also noticed by Michael Reed, discussed with deraadt@

Revision 1.17 / (download) - annotate - [select for diffs], Fri Jan 15 22:22:38 2016 UTC (8 years, 4 months ago) by mmcc
Branch: MAIN
Changes since 1.16: +274 -274 lines
Diff to previous 1.16 (colored)

remove needless extern keywords, a vestige of pre-ANSI C

explained by and ok millert@

Revision 1.16 / (download) - annotate - [select for diffs], Tue Jan 12 17:48:04 2016 UTC (8 years, 4 months ago) by mmcc
Branch: MAIN
Changes since 1.15: +7 -7 lines
Diff to previous 1.15 (colored)

Remove LINUNUM, a needless alias for off_t. Also, remove a redundant
condition.

ok nicm@

Revision 1.15 / (download) - annotate - [select for diffs], Mon Nov 23 09:38:35 2015 UTC (8 years, 5 months ago) by nicm
Branch: MAIN
Changes since 1.14: +1 -0 lines
Diff to previous 1.14 (colored)

Missing prototype.

Revision 1.14 / (download) - annotate - [select for diffs], Sat Nov 21 13:29:12 2015 UTC (8 years, 5 months ago) by tedu
Branch: MAIN
Changes since 1.13: +0 -1 lines
Diff to previous 1.13 (colored)

remove fancy null check function in favor of checking for null.
from Ricardo Mestre

Revision 1.13 / (download) - annotate - [select for diffs], Fri Nov 13 16:48:48 2015 UTC (8 years, 6 months ago) by nicm
Branch: MAIN
Changes since 1.12: +1 -1 lines
Diff to previous 1.12 (colored)

Add a flag argument to flush() to stop it calling quit() on error, then
use this from quit() to stop less blowing up the stack looping through
quit()/flush() if stderr is closed (for example "less /missing
2</dev/null"). ok millert

Revision 1.12 / (download) - annotate - [select for diffs], Mon Nov 9 03:09:19 2015 UTC (8 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.11: +0 -1 lines
Diff to previous 1.11 (colored)

close_getchr() is now a noop

Revision 1.11 / (download) - annotate - [select for diffs], Sat Nov 7 18:07:44 2015 UTC (8 years, 6 months ago) by tedu
Branch: MAIN
Changes since 1.10: +0 -1 lines
Diff to previous 1.10 (colored)

replace save() with estrdup() and make estrdup() exit like all the other
ecalloc, etc. functions do.
ok mmcc nicm

Revision 1.10 / (download) - annotate - [select for diffs], Fri Nov 6 15:09:07 2015 UTC (8 years, 6 months ago) by tedu
Branch: MAIN
Changes since 1.9: +0 -1 lines
Diff to previous 1.9 (colored)

time_t is not a long. remove incorrect abstraction around time().
ok nicm

Revision 1.9 / (download) - annotate - [select for diffs], Thu Nov 5 22:08:44 2015 UTC (8 years, 6 months ago) by nicm
Branch: MAIN
Changes since 1.8: +290 -293 lines
Diff to previous 1.8 (colored)

Replace less with the cleaned-up fork of less 458 maintained by Garrett
D'Amore at https://github.com/gdamore/less-fork. This has significantly
less portability goop, has a tidied up code style, uses terminfo instead
of termcap, and is has stricter POSIX compliance.

Many of our local changes have been accepted upstream: substantial
remaining local changes are code to read help files from /usr/share
rather than compiling them in, man page and help improvements, and some
tweaks to the default options.

Review and testing by millert, ok deraadt

Revision 1.8 / (download) - annotate - [select for diffs], Sat May 10 16:45:23 2014 UTC (10 years ago) by schwarze
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7, OPENBSD_5_6_BASE, OPENBSD_5_6
Changes since 1.7: +1 -0 lines
Diff to previous 1.7 (colored)

Give more(1) its own help file, shorter than the one for less(1).
The helpfile itself was prepared by jmc@, the glue by me.
OK millert@ jmc@

Revision 1.7 / (download) - annotate - [select for diffs], Fri Apr 25 13:38:21 2014 UTC (10 years ago) by shadchin
Branch: MAIN
Changes since 1.6: +1 -0 lines
Diff to previous 1.6 (colored)

Merge Less 458 plus local patches

ok guenther@, ok jmc@ for man bits

Revision 1.1.1.4 / (download) - annotate - [select for diffs] (vendor branch), Fri Apr 25 13:33:47 2014 UTC (10 years ago) by shadchin
Branch: markn, MARK_NUDELMAN
CVS Tags: LESS_458
Changes since 1.1.1.3: +2 -1 lines
Diff to previous 1.1.1.3 (colored)

Import of Less 458

ok guenther@

Revision 1.6 / (download) - annotate - [select for diffs], Fri Sep 16 18:12:09 2011 UTC (12 years, 8 months ago) by shadchin
Branch: MAIN
CVS Tags: OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1
Changes since 1.5: +52 -12 lines
Diff to previous 1.5 (colored)

Merge in less 444 plus local changes

ok nicm@

Revision 1.1.1.3 / (download) - annotate - [select for diffs] (vendor branch), Fri Sep 16 17:47:04 2011 UTC (12 years, 8 months ago) by shadchin
Branch: markn, MARK_NUDELMAN
CVS Tags: LESS_444
Changes since 1.1.1.2: +52 -10 lines
Diff to previous 1.1.1.2 (colored)

Import of Less 444

ok nicm@

Revision 1.5 / (download) - annotate - [select for diffs], Sat Jun 7 03:35:19 2003 UTC (20 years, 11 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7, OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3, OPENBSD_4_2_BASE, OPENBSD_4_2, OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0, OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6, OPENBSD_3_5_BASE, OPENBSD_3_5, OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.4: +1 -1 lines
Diff to previous 1.4 (colored)

Use interruptible syscalls instead of setjmp/longjmp.  This makes
less's signal handlers safe.  No one has reported problems so far...

Revision 1.4 / (download) - annotate - [select for diffs], Mon Apr 14 14:33:57 2003 UTC (21 years, 1 month ago) by millert
Branch: MAIN
Changes since 1.3: +2 -0 lines
Diff to previous 1.3 (colored)

o go back to using a help file instead of embedding it in the binary
o deal with HELPFILE not being defined
o add a SMALL definition to make a smaller less for the boot floppies
This still needs to be pared down a bit for the SMALL case

Revision 1.3 / (download) - annotate - [select for diffs], Sun Apr 13 18:26:25 2003 UTC (21 years, 1 month ago) by millert
Branch: MAIN
Changes since 1.2: +47 -24 lines
Diff to previous 1.2 (colored)

Merge in less-381 w/ local changes and remove obsolete files.

Revision 1.1.1.2 / (download) - annotate - [select for diffs] (vendor branch), Sun Apr 13 18:21:21 2003 UTC (21 years, 1 month ago) by millert
Branch: markn, MARK_NUDELMAN
CVS Tags: LESS_381
Changes since 1.1.1.1: +47 -22 lines
Diff to previous 1.1.1.1 (colored)

Stock less-390 with some unneeded DOS/Windoze files removed

Revision 1.2 / (download) - annotate - [select for diffs], Mon Jan 29 01:58:01 2001 UTC (23 years, 3 months ago) by niklas
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3, OPENBSD_3_2_BASE, OPENBSD_3_2, OPENBSD_3_1_BASE, OPENBSD_3_1, OPENBSD_3_0_BASE, OPENBSD_3_0, OPENBSD_2_9_BASE, OPENBSD_2_9
Changes since 1.1: +2 -0 lines
Diff to previous 1.1 (colored)

$OpenBSD$

Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Sat Sep 21 05:39:44 1996 UTC (27 years, 8 months ago) by etheisen
Branch: markn, MARK_NUDELMAN
CVS Tags: less_290, OPENBSD_2_8_BASE, OPENBSD_2_8, OPENBSD_2_7_BASE, OPENBSD_2_7, OPENBSD_2_6_BASE, OPENBSD_2_6, OPENBSD_2_5_BASE, OPENBSD_2_5, OPENBSD_2_4_BASE, OPENBSD_2_4, OPENBSD_2_3_BASE, OPENBSD_2_3, OPENBSD_2_2_BASE, OPENBSD_2_2, OPENBSD_2_1_BASE, OPENBSD_2_1, OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)

Import of unmolested less-290.

Revision 1.1 / (download) - annotate - [select for diffs], Sat Sep 21 05:39:44 1996 UTC (27 years, 8 months ago) by etheisen
Branch: MAIN

Initial revision

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.