![[BACK]](/icons/back.gif){kind=icon}
Up to [local] / src / usr.bin / look
Request diff between arbitrary revisions
Default branch: MAIN
Revision 1.27 / (download) - annotate - [select for diffs], Sun Dec 4 23:50:48 2022 UTC (17 months, 2 weeks ago) by cheloha
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE,
OPENBSD_7_5,
OPENBSD_7_4_BASE,
OPENBSD_7_4,
OPENBSD_7_3_BASE,
OPENBSD_7_3,
HEAD
Changes since 1.26: +1 -2 lines
Diff to previous 1.26 (colored)
userspace: remove vestigial '?' cases from top-level getopt(3) loops getopt(3) returns '?' when it encounters a flag not present in the in the optstring or if a flag is missing its option argument. We can handle this case with the "default" failure case with no loss of legibility. Hence, remove all the redundant "case '?':" lines. Prompted by dlg@. With help from dlg@ and millert@. Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2 ok naddy@ millert@ dlg@
Revision 1.26 / (download) - annotate - [select for diffs], Thu Feb 10 14:55:43 2022 UTC (2 years, 3 months ago) by cheloha
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE,
OPENBSD_7_2,
OPENBSD_7_1_BASE,
OPENBSD_7_1
Changes since 1.25: +8 -6 lines
Diff to previous 1.25 (colored)
look(1): use a stricter pledge(2) in lieu of unveil(2) We're only reading one file here, so unveil(2) is overkill. We can achieve the same effect with just pledge(2): - Start with an initial pledge(2) of "stdio rpath" at the top of main(). We know we need to read a file at this point but don't yet know which one. - Drop the pledge(2) down to "stdio" after we open(2) and fstat(2) the chosen file. - Dropping "rpath" obviates unveil(2). Thread: https://marc.info/?l=openbsd-tech&m=164437072017248&w=2 ok millert@
Revision 1.25 / (download) - annotate - [select for diffs], Sun Oct 24 21:24:16 2021 UTC (2 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.24: +2 -2 lines
Diff to previous 1.24 (colored)
For open/openat, if the flags parameter does not contain O_CREAT, the 3rd (variadic) mode_t parameter is irrelevant. Many developers in the past have passed mode_t (0, 044, 0644, or such), which might lead future people to copy this broken idiom, and perhaps even believe this parameter has some meaning or implication or application. Delete them all. This comes out of a conversation where tb@ noticed that a strange (but intentional) pledge behaviour is to always knock-out high-bits from mode_t on a number of system calls as a safety factor, and his bewilderment that this appeared to be happening against valid modes (at least visually), but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef. ok millert
Revision 1.24 / (download) - annotate - [select for diffs], Mon Jul 12 15:09:20 2021 UTC (2 years, 10 months ago) by beck
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE,
OPENBSD_7_0
Changes since 1.23: +2 -2 lines
Diff to previous 1.23 (colored)
Change the error reporting pattern throughout the tree when unveil fails to report the path that the failure occured on. Suggested by deraadt@ after some tech discussion. Work done and verified by Ashton Fagg <ashton@fagg.id.au> ok deraadt@ semarie@ claudio@
Revision 1.23 / (download) - annotate - [select for diffs], Fri Jun 28 13:35:01 2019 UTC (4 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_9_BASE,
OPENBSD_6_9,
OPENBSD_6_8_BASE,
OPENBSD_6_8,
OPENBSD_6_7_BASE,
OPENBSD_6_7,
OPENBSD_6_6_BASE,
OPENBSD_6_6
Changes since 1.22: +2 -2 lines
Diff to previous 1.22 (colored)
When system calls indicate an error they return -1, not some arbitrary value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.
Revision 1.22 / (download) - annotate - [select for diffs], Sat Aug 11 11:00:34 2018 UTC (5 years, 9 months ago) by mestre
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE,
OPENBSD_6_5,
OPENBSD_6_4_BASE,
OPENBSD_6_4
Changes since 1.21: +6 -4 lines
Diff to previous 1.21 (colored)
look(1) will access /usr/share/dict/words to look for the string we want, or it may access another file instead if we mention it via argument. In order to know which file to unveil(2) we need to push down pledge(2) a little bit after getopt(3) and now that we know the name of the file we can unveil(2) it only with read permissions. OK deraadt@
Revision 1.21 / (download) - annotate - [select for diffs], Sat Jan 21 10:03:27 2017 UTC (7 years, 3 months ago) by krw
Branch: MAIN
CVS Tags: OPENBSD_6_3_BASE,
OPENBSD_6_3,
OPENBSD_6_2_BASE,
OPENBSD_6_2,
OPENBSD_6_1_BASE,
OPENBSD_6_1
Changes since 1.20: +32 -32 lines
Diff to previous 1.20 (colored)
Nuke more whitespace caught in the headlights of "warning:" rectification.
Revision 1.20 / (download) - annotate - [select for diffs], Sat Jan 21 08:51:00 2017 UTC (7 years, 3 months ago) by krw
Branch: MAIN
Changes since 1.19: +2 -2 lines
Diff to previous 1.19 (colored)
Accommodate gcc's suggestion that assignments used as truth values should be enclosed in parentheses. ok deraadt@
Revision 1.19 / (download) - annotate - [select for diffs], Tue Sep 13 15:27:47 2016 UTC (7 years, 8 months ago) by millert
Branch: MAIN
Changes since 1.18: +5 -21 lines
Diff to previous 1.18 (colored)
Eliminate the FOLD and DICT macros. There's no need to check for isascii() with ANSI ctype macros/functions. Eliminating the macros makes the code clearer. OK jca@
Revision 1.18 / (download) - annotate - [select for diffs], Fri Oct 9 01:37:08 2015 UTC (8 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE,
OPENBSD_6_0,
OPENBSD_5_9_BASE,
OPENBSD_5_9
Changes since 1.17: +3 -3 lines
Diff to previous 1.17 (colored)
Change all tame callers to namechange to pledge(2).
Revision 1.17 / (download) - annotate - [select for diffs], Wed Oct 7 14:13:23 2015 UTC (8 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.16: +4 -1 lines
Diff to previous 1.16 (colored)
tame "stdio rpath", for the open with O_RDONLY. ok semarie
Revision 1.16 / (download) - annotate - [select for diffs], Fri Feb 6 23:21:59 2015 UTC (9 years, 3 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE,
OPENBSD_5_8,
OPENBSD_5_7_BASE,
OPENBSD_5_7
Changes since 1.15: +3 -3 lines
Diff to previous 1.15 (colored)
SIZE_MAX is standard, we should be using it in preference to the obsolete SIZE_T_MAX. OK miod@ beck@
Revision 1.15 / (download) - annotate - [select for diffs], Tue May 20 01:25:23 2014 UTC (10 years ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE,
OPENBSD_5_6
Changes since 1.14: +2 -2 lines
Diff to previous 1.14 (colored)
Use errc/warnc to simplify code. Also, in 'ftp', always put the error message last, after the hostname/ipaddr. ok jsing@ krw@ millert@
Revision 1.14 / (download) - annotate - [select for diffs], Tue Nov 26 13:19:07 2013 UTC (10 years, 5 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_5_BASE,
OPENBSD_5_5
Changes since 1.13: +5 -5 lines
Diff to previous 1.13 (colored)
unsigned char casts for ctype ok krw
Revision 1.13 / (download) - annotate - [select for diffs], Tue Oct 27 23:59:40 2009 UTC (14 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_4_BASE,
OPENBSD_5_4,
OPENBSD_5_3_BASE,
OPENBSD_5_3,
OPENBSD_5_2_BASE,
OPENBSD_5_2,
OPENBSD_5_1_BASE,
OPENBSD_5_1,
OPENBSD_5_0_BASE,
OPENBSD_5_0,
OPENBSD_4_9_BASE,
OPENBSD_4_9,
OPENBSD_4_8_BASE,
OPENBSD_4_8,
OPENBSD_4_7_BASE,
OPENBSD_4_7
Changes since 1.12: +1 -14 lines
Diff to previous 1.12 (colored)
rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and unmaintainable). these days, people use source. these id's do not provide any benefit, and do hurt the small install media (the 33,000 line diff is essentially mechanical) ok with the idea millert, ok dms
Revision 1.12 / (download) - annotate - [select for diffs], Wed Jun 17 10:42:08 2009 UTC (14 years, 11 months ago) by sobrado
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE,
OPENBSD_4_6
Changes since 1.11: +4 -3 lines
Diff to previous 1.11 (colored)
synchronize synopsis and usage.
Revision 1.11 / (download) - annotate - [select for diffs], Sat Jun 25 17:00:35 2005 UTC (18 years, 10 months ago) by niallo
Branch: MAIN
CVS Tags: OPENBSD_4_5_BASE,
OPENBSD_4_5,
OPENBSD_4_4_BASE,
OPENBSD_4_4,
OPENBSD_4_3_BASE,
OPENBSD_4_3,
OPENBSD_4_2_BASE,
OPENBSD_4_2,
OPENBSD_4_1_BASE,
OPENBSD_4_1,
OPENBSD_4_0_BASE,
OPENBSD_4_0,
OPENBSD_3_9_BASE,
OPENBSD_3_9,
OPENBSD_3_8_BASE,
OPENBSD_3_8
Changes since 1.10: +3 -3 lines
Diff to previous 1.10 (colored)
Fix typo in a comment. ok jmc@
Revision 1.10 / (download) - annotate - [select for diffs], Tue Jun 10 22:20:47 2003 UTC (20 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_7_BASE,
OPENBSD_3_7,
OPENBSD_3_6_BASE,
OPENBSD_3_6,
OPENBSD_3_5_BASE,
OPENBSD_3_5,
OPENBSD_3_4_BASE,
OPENBSD_3_4
Changes since 1.9: +9 -16 lines
Diff to previous 1.9 (colored)
mostly ansi cleanup; pval ok
Revision 1.9 / (download) - annotate - [select for diffs], Tue Jun 3 02:56:10 2003 UTC (20 years, 11 months ago) by millert
Branch: MAIN
Changes since 1.8: +3 -7 lines
Diff to previous 1.8 (colored)
Remove the advertising clause in the UCB license which Berkeley rescinded 22 July 1999. Proofed by myself and Theo.
Revision 1.8 / (download) - annotate - [select for diffs], Fri Mar 1 00:51:08 2002 UTC (22 years, 2 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE,
OPENBSD_3_3,
OPENBSD_3_2_BASE,
OPENBSD_3_2,
OPENBSD_3_1_BASE,
OPENBSD_3_1
Changes since 1.7: +3 -3 lines
Diff to previous 1.7 (colored)
Fix an err() that should really be errx()
Revision 1.7 / (download) - annotate - [select for diffs], Sat Feb 16 21:27:48 2002 UTC (22 years, 3 months ago) by millert
Branch: MAIN
Changes since 1.6: +8 -8 lines
Diff to previous 1.6 (colored)
Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.
Revision 1.6 / (download) - annotate - [select for diffs], Mon Nov 19 19:02:15 2001 UTC (22 years, 6 months ago) by mpech
Branch: MAIN
Changes since 1.5: +9 -9 lines
Diff to previous 1.5 (colored)
kill more registers millert@ ok
Revision 1.5 / (download) - annotate - [select for diffs], Thu Oct 12 10:01:18 2000 UTC (23 years, 7 months ago) by art
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE,
OPENBSD_3_0,
OPENBSD_2_9_BASE,
OPENBSD_2_9,
OPENBSD_2_8_BASE,
OPENBSD_2_8
Changes since 1.4: +3 -3 lines
Diff to previous 1.4 (colored)
Check the mmap return value against MAP_FAILED, not NULL.
Revision 1.4 / (download) - annotate - [select for diffs], Tue Dec 21 05:52:46 1999 UTC (24 years, 5 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_7_BASE,
OPENBSD_2_7
Changes since 1.3: +3 -3 lines
Diff to previous 1.3 (colored)
Use MAP_PRIVATE for mmap() flags instead of 0. With UVM this defaults to MAP_PRIVATE anyway but we want to avoid the kernel complaining...
Revision 1.3 / (download) - annotate - [select for diffs], Wed Jan 15 23:42:48 1997 UTC (27 years, 4 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_6_BASE,
OPENBSD_2_6,
OPENBSD_2_5_BASE,
OPENBSD_2_5,
OPENBSD_2_4_BASE,
OPENBSD_2_4,
OPENBSD_2_3_BASE,
OPENBSD_2_3,
OPENBSD_2_2_BASE,
OPENBSD_2_2,
OPENBSD_2_1_BASE,
OPENBSD_2_1
Changes since 1.2: +3 -3 lines
Diff to previous 1.2 (colored)
getopt(3) returns -1 when out of args, not EOF, whee!
Revision 1.2 / (download) - annotate - [select for diffs], Wed Jun 26 05:36:06 1996 UTC (27 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_0_BASE,
OPENBSD_2_0
Changes since 1.1: +2 -1 lines
Diff to previous 1.1 (colored)
rcsid
Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Wed Oct 18 08:45:34 1995 UTC (28 years, 7 months ago) by deraadt
CVS Tags: netbsd_1_1
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)
initial import of NetBSD tree
Revision 1.1 / (download) - annotate - [select for diffs], Wed Oct 18 08:45:34 1995 UTC (28 years, 7 months ago) by deraadt
Branch: MAIN
Initial revision