OpenBSD CVS

CVS log for src/usr.bin/mail/cmd3.c


[BACK] Up to [local] / src / usr.bin / mail

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.30 / (download) - annotate - [select for diffs], Wed Mar 8 04:43:11 2023 UTC (14 months, 1 week ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, HEAD
Changes since 1.29: +1 -3 lines
Diff to previous 1.29 (colored)

Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

Revision 1.29 / (download) - annotate - [select for diffs], Wed Feb 8 08:24:29 2023 UTC (15 months, 1 week ago) by tb
Branch: MAIN
Changes since 1.28: +2 -3 lines
Diff to previous 1.28 (colored)

finger/mail: two trivial functions were missed in earlier ansi passes

Revision 1.28 / (download) - annotate - [select for diffs], Fri Jun 28 13:35:01 2019 UTC (4 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.27: +2 -2 lines
Diff to previous 1.27 (colored)

When system calls indicate an error they return -1, not some arbitrary
value < 0.  errno is only updated in this case.  Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Revision 1.27 / (download) - annotate - [select for diffs], Fri Oct 16 17:56:07 2015 UTC (8 years, 7 months ago) by mmcc
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.26: +8 -8 lines
Diff to previous 1.26 (colored)

Modernize allocation by:

 * removing unneeded casts of void* return values
 * replacing varied and creative error messages with the allocation
   function's name
 * replacing errx() with err() so that the errno string is reported

ok beck@, jung@, millert@

Revision 1.26 / (download) - annotate - [select for diffs], Tue Jan 20 16:59:07 2015 UTC (9 years, 4 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.25: +3 -1 lines
Diff to previous 1.25 (colored)

Add support for the "-r fromaddr" flag now that we don't support
sendmail flags on the command line.
Also allow "from" to be set in mailrc.
Use sendmail's "-t" flag when executing sendmail instead of specifying
the list of recipients in argv.  The "-f" flag will be used to set
the from address if specified.

Revision 1.25 / (download) - annotate - [select for diffs], Wed Apr 6 11:36:26 2011 UTC (13 years, 1 month ago) by miod
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0
Changes since 1.24: +5 -5 lines
Diff to previous 1.24 (colored)

Avoid using NULL in non-pointer contexts: use 0 for integer values and '\0'
for chars.

Revision 1.24 / (download) - annotate - [select for diffs], Tue Oct 27 23:59:40 2009 UTC (14 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.23: +1 -9 lines
Diff to previous 1.23 (colored)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable).  these days, people use source.  these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Revision 1.23 / (download) - annotate - [select for diffs], Sat Sep 5 10:49:45 2009 UTC (14 years, 8 months ago) by tobias
Branch: MAIN
Changes since 1.22: +3 -3 lines
Diff to previous 1.22 (colored)

Fixed typo in comment.

ok millert

Revision 1.22 / (download) - annotate - [select for diffs], Thu Jul 23 20:06:03 2009 UTC (14 years, 9 months ago) by martynas
Branch: MAIN
Changes since 1.21: +3 -3 lines
Diff to previous 1.21 (colored)

elide a little bit later, the final list, after From has been
appended.  properly removes if there's a dup in from & to.
ok millert@

Revision 1.21 / (download) - annotate - [select for diffs], Wed Jul 16 14:53:41 2008 UTC (15 years, 10 months ago) by martynas
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4
Changes since 1.20: +3 -5 lines
Diff to previous 1.20 (colored)

- use strncmp/strncasecmp instead of comparing by character
- simplify istrlcpy, no need to check for isupper
- line[0] is redundant, because strcasecmp will take care of it
ok millert@

Revision 1.20 / (download) - annotate - [select for diffs], Tue Jun 3 02:56:11 2003 UTC (20 years, 11 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_4_3_BASE, OPENBSD_4_3, OPENBSD_4_2_BASE, OPENBSD_4_2, OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0, OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6, OPENBSD_3_5_BASE, OPENBSD_3_5, OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.19: +3 -7 lines
Diff to previous 1.19 (colored)

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999.  Proofed by myself and Theo.

Revision 1.19 / (download) - annotate - [select for diffs], Mon Aug 12 00:42:56 2002 UTC (21 years, 9 months ago) by aaron
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3, OPENBSD_3_2_BASE, OPENBSD_3_2
Changes since 1.18: +4 -4 lines
Diff to previous 1.18 (colored)

Swap args to calloc(3) so they are in the correct order; art@ ok.

Revision 1.18 / (download) - annotate - [select for diffs], Wed Nov 21 20:41:55 2001 UTC (22 years, 6 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.17: +16 -12 lines
Diff to previous 1.17 (colored)

o kill strcpy()
o check return values of malloc and friends
o use strdup() when sensible

Revision 1.17 / (download) - annotate - [select for diffs], Wed Nov 21 15:26:39 2001 UTC (22 years, 6 months ago) by millert
Branch: MAIN
Changes since 1.16: +56 -82 lines
Diff to previous 1.16 (colored)

o ANSIfy
o Style nits
o Use const to silent stupid -Wall warnings
o strnc{py,at} -> strlc{py,at}
o Use strpbrk() instead of homegrown anyof()
o Use NULL instead of #defines with 0 cast to a pointer
This still could use a proper audit

Revision 1.16 / (download) - annotate - [select for diffs], Tue Nov 20 20:50:00 2001 UTC (22 years, 6 months ago) by millert
Branch: MAIN
Changes since 1.15: +13 -8 lines
Diff to previous 1.15 (colored)

Major signal overhaul.  We no longer longjmp all over the place.
Instead, routines responsible to gathering user input (or in some
cases outputting data) catch the signals and set flags as needed.
Because of this some handlers are install without the SA_RESTART
flag so syscalls are not restarted and we can check the flag.  All
signal handlers are now safe.

This should make the flow of control a bit more grokable but the
code is still ugly.

Revision 1.15 / (download) - annotate - [select for diffs], Fri Jan 19 04:11:28 2001 UTC (23 years, 4 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0, OPENBSD_2_9_BASE, OPENBSD_2_9
Changes since 1.14: +4 -4 lines
Diff to previous 1.14 (colored)

More fixes from Don Beusee:
- edit and other interactive commands have no stdin (making the
  command completely broken).
- messages with "From " line having date format with -0800 type of timezone
  are not recognized correctly.

Revision 1.14 / (download) - annotate - [select for diffs], Tue Jan 16 05:36:08 2001 UTC (23 years, 4 months ago) by millert
Branch: MAIN
Changes since 1.13: +25 -17 lines
Diff to previous 1.13 (colored)

Changes from Don Beusee:
o escape From line with a leading '>' when needed
o only print To: address and Subject lines if actually present
o new variable 'allnet' to treat user@foo and user@bar as the same "user"
o folders command now takes an optional argument like ls.
o new "pipe" (|) command to pipe the message through an arbitrary command
o make header display format the same as SunOS 4.1.3 /usr/ucb/mail
o tilde commands work regardless of interactive mode.
o fix "read: Interrupted system call" error by retrying if EINTR
o expanded help file
Changes by me:
o read the help file via the PAGER as it is now more than 24 lines long

Revision 1.11.2.1 / (download) - annotate - [select for diffs], Fri Oct 6 21:16:14 2000 UTC (23 years, 7 months ago) by jason
Branch: OPENBSD_2_7
Changes since 1.11: +3 -3 lines
Diff to previous 1.11 (colored) next main 1.12 (colored)

Pull in patch from current (even more to come):
Fix (millert):
warnx?/errx? paranoia (use "%s" not a bare string unless it is a
constant).  These are not security holes but it is worth fixing
them anyway both for robustness and so folks looking for examples
in the tree are not misled into doing something potentially dangerous.
Furthermore, it is a bad idea to assume that pathnames will not
include '%' in them and that error routines don't return strings
with '%' in them (especially in light of the possibility of locales).

Revision 1.13 / (download) - annotate - [select for diffs], Wed Aug 2 04:10:48 2000 UTC (23 years, 9 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_8_BASE, OPENBSD_2_8
Changes since 1.12: +7 -4 lines
Diff to previous 1.12 (colored)

$HOME paranoia: never use getenv("HOME") w/o checking for NULL and non-zero

Revision 1.12 / (download) - annotate - [select for diffs], Fri Jun 30 16:00:16 2000 UTC (23 years, 10 months ago) by millert
Branch: MAIN
Changes since 1.11: +3 -3 lines
Diff to previous 1.11 (colored)

warnx?/errx? paranoia (use "%s" not a bare string unless it is a
constant).  These are not security holes but it is worth fixing
them anyway both for robustness and so folks looking for examples
in the tree are not misled into doing something potentially dangerous.
Furthermore, it is a bad idea to assume that pathnames will not
include '%' in them and that error routines don't return strings
with '%' in them (especially in light of the possibility of locales).

Revision 1.11 / (download) - annotate - [select for diffs], Tue Apr 25 16:42:22 2000 UTC (24 years ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_7_BASE
Branch point for: OPENBSD_2_7
Changes since 1.10: +3 -2 lines
Diff to previous 1.10 (colored)

When incorporating new messages, clear the "new" count before the
inc so the count of new messages is useful afterwards.  This makes
mail behave more like the SunOS version in this respect.

Revision 1.10 / (download) - annotate - [select for diffs], Fri Nov 14 00:23:44 1997 UTC (26 years, 6 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_6_BASE, OPENBSD_2_6, OPENBSD_2_5_BASE, OPENBSD_2_5, OPENBSD_2_4_BASE, OPENBSD_2_4, OPENBSD_2_3_BASE, OPENBSD_2_3
Changes since 1.9: +25 -28 lines
Diff to previous 1.9 (colored)

NetBSD changes (mostly comsmetic):
    replace panic() with calls to err()/errx()
    use S_IS* instead of doing by hand with S_IF*.
    Use TIMESPEC_TO_TIMEVAL() and gettimeofday instead of time(2)
    Use _POSIX_VDISABLE, not 0
    Kill register

Revision 1.9 / (download) - annotate - [select for diffs], Wed Jul 30 07:19:30 1997 UTC (26 years, 9 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_2_BASE, OPENBSD_2_2
Changes since 1.8: +4 -3 lines
Diff to previous 1.8 (colored)

Make istrcpy() take a size (not length) field, now called istrncpy().
Change some strcpy() -> strncpy() out of paranoia.

Revision 1.8 / (download) - annotate - [select for diffs], Wed Jul 30 06:32:38 1997 UTC (26 years, 9 months ago) by millert
Branch: MAIN
Changes since 1.7: +13 -12 lines
Diff to previous 1.7 (colored)

Fix one possible oflow (not exploitable) and do a wee bit of KNF.
Much more remains to be done.

Revision 1.7 / (download) - annotate - [select for diffs], Mon Jul 14 00:24:25 1997 UTC (26 years, 10 months ago) by millert
Branch: MAIN
Changes since 1.6: +35 -35 lines
Diff to previous 1.6 (colored)

NOSTR -> NULL
Use sigsetjmp/siglongjmp instead of sigjmp/longjmp for portability.

Revision 1.6 / (download) - annotate - [select for diffs], Sun Jul 13 23:53:58 1997 UTC (26 years, 10 months ago) by millert
Branch: MAIN
Changes since 1.5: +16 -16 lines
Diff to previous 1.5 (colored)

bcopy() -> memcpy() and fix some casts.

Revision 1.5 / (download) - annotate - [select for diffs], Sun Jul 13 21:21:09 1997 UTC (26 years, 10 months ago) by millert
Branch: MAIN
Changes since 1.4: +46 -46 lines
Diff to previous 1.4 (colored)

Merge in NetBSD and 4.4BSD-lite2 changes as well as some of my own.
 - handle long lines safely (from NetBSD)
 - use puts/fputs and putchar/putc when it makes sense
 - use err/errx and warn/warnx when it makes sense
 - make return() and sizeof() style consisten
 - some more buffer safety

Revision 1.4 / (download) - annotate - [select for diffs], Fri May 30 08:51:35 1997 UTC (26 years, 11 months ago) by deraadt
Branch: MAIN
Changes since 1.3: +3 -3 lines
Diff to previous 1.3 (colored)

overflows abound

Revision 1.3 / (download) - annotate - [select for diffs], Sat Mar 29 03:01:44 1997 UTC (27 years, 1 month ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_1_BASE, OPENBSD_2_1
Changes since 1.2: +3 -3 lines
Diff to previous 1.2 (colored)

Use ``mail.local -H'' to do dot locking so we can have mode 755 mail
spool, change an occurrence of tempnam() to mkstemp(), change some
longs and shorts to ints.  Mail is now usable again.

Revision 1.2 / (download) - annotate - [select for diffs], Tue Jun 11 12:53:34 1996 UTC (27 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.1: +64 -41 lines
Diff to previous 1.1 (colored)

from christos;
- Fix PR/105: Implement dot locking protocol and check return value of flock.
- Fix PR/2247: Don't call unknown users "ubluit". Issue an error message.
- Fix/add prototypes.
- Fix warnings.
- Use POSIX signal mask calls.

Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Wed Oct 18 08:45:38 1995 UTC (28 years, 7 months ago) by deraadt
CVS Tags: netbsd_1_1
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)

initial import of NetBSD tree

Revision 1.1 / (download) - annotate - [select for diffs], Wed Oct 18 08:45:38 1995 UTC (28 years, 7 months ago) by deraadt
Branch: MAIN

Initial revision

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.