![[BACK]](/icons/back.gif){kind=icon}
Up to [local] / src / usr.bin / mail
Request diff between arbitrary revisions
Default branch: MAIN
Revision 1.43 / (download) - annotate - [select for diffs], Wed Mar 8 04:43:11 2023 UTC (14 months, 1 week ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE,
OPENBSD_7_5,
OPENBSD_7_4_BASE,
OPENBSD_7_4,
OPENBSD_7_3_BASE,
OPENBSD_7_3,
HEAD
Changes since 1.42: +1 -2 lines
Diff to previous 1.42 (colored)
Delete obsolete /* ARGSUSED */ lint comments. ok miod@ millert@
Revision 1.42 / (download) - annotate - [select for diffs], Sun Oct 24 21:24:16 2021 UTC (2 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE,
OPENBSD_7_2,
OPENBSD_7_1_BASE,
OPENBSD_7_1
Changes since 1.41: +2 -2 lines
Diff to previous 1.41 (colored)
For open/openat, if the flags parameter does not contain O_CREAT, the 3rd (variadic) mode_t parameter is irrelevant. Many developers in the past have passed mode_t (0, 044, 0644, or such), which might lead future people to copy this broken idiom, and perhaps even believe this parameter has some meaning or implication or application. Delete them all. This comes out of a conversation where tb@ noticed that a strange (but intentional) pledge behaviour is to always knock-out high-bits from mode_t on a number of system calls as a safety factor, and his bewilderment that this appeared to be happening against valid modes (at least visually), but no sorry, they are all irrelevant junk. They could all be 0xdeafbeef. ok millert
Revision 1.41 / (download) - annotate - [select for diffs], Fri Jun 28 13:35:01 2019 UTC (4 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE,
OPENBSD_7_0,
OPENBSD_6_9_BASE,
OPENBSD_6_9,
OPENBSD_6_8_BASE,
OPENBSD_6_8,
OPENBSD_6_7_BASE,
OPENBSD_6_7,
OPENBSD_6_6_BASE,
OPENBSD_6_6
Changes since 1.40: +3 -3 lines
Diff to previous 1.40 (colored)
When system calls indicate an error they return -1, not some arbitrary value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.
Revision 1.40 / (download) - annotate - [select for diffs], Sun Sep 16 02:38:57 2018 UTC (5 years, 8 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE,
OPENBSD_6_5,
OPENBSD_6_4_BASE,
OPENBSD_6_4
Changes since 1.39: +2 -2 lines
Diff to previous 1.39 (colored)
Replace the local getname() and getuserid() functions with calls to user_from_uid(3) and uid_from_user(3). This requires sprinkling const in a few places to match the return value of user_from_uid(3). OK tb@
Revision 1.39 / (download) - annotate - [select for diffs], Fri Oct 16 17:56:07 2015 UTC (8 years, 7 months ago) by mmcc
Branch: MAIN
CVS Tags: OPENBSD_6_3_BASE,
OPENBSD_6_3,
OPENBSD_6_2_BASE,
OPENBSD_6_2,
OPENBSD_6_1_BASE,
OPENBSD_6_1,
OPENBSD_6_0_BASE,
OPENBSD_6_0,
OPENBSD_5_9_BASE,
OPENBSD_5_9
Changes since 1.38: +2 -2 lines
Diff to previous 1.38 (colored)
Modernize allocation by: * removing unneeded casts of void* return values * replacing varied and creative error messages with the allocation function's name * replacing errx() with err() so that the errno string is reported ok beck@, jung@, millert@
Revision 1.38 / (download) - annotate - [select for diffs], Sun Oct 26 20:38:13 2014 UTC (9 years, 6 months ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE,
OPENBSD_5_8,
OPENBSD_5_7_BASE,
OPENBSD_5_7
Changes since 1.37: +3 -5 lines
Diff to previous 1.37 (colored)
Prefer mkostemp(O_CLOEXEC) over mkstemp()+fcntl(F_SETFD)
Prefer fopen("re") over fopen("r")+fcntl(F_SETFD)
ok otto@ millert@
Revision 1.37 / (download) - annotate - [select for diffs], Tue May 20 01:25:23 2014 UTC (10 years ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE,
OPENBSD_5_6
Changes since 1.36: +3 -5 lines
Diff to previous 1.36 (colored)
Use errc/warnc to simplify code. Also, in 'ftp', always put the error message last, after the hostname/ipaddr. ok jsing@ krw@ millert@
Revision 1.36 / (download) - annotate - [select for diffs], Fri Jan 17 18:42:30 2014 UTC (10 years, 4 months ago) by okan
Branch: MAIN
CVS Tags: OPENBSD_5_5_BASE,
OPENBSD_5_5
Changes since 1.35: +10 -9 lines
Diff to previous 1.35 (colored)
ctype and other sign extension fixes. with deraadt and millert, ok millert
Revision 1.35 / (download) - annotate - [select for diffs], Mon Apr 29 00:28:23 2013 UTC (11 years ago) by okan
Branch: MAIN
CVS Tags: OPENBSD_5_4_BASE,
OPENBSD_5_4
Changes since 1.34: +3 -3 lines
Diff to previous 1.34 (colored)
use FD_CLOEXEC instead of 1; from David Hill ok otto
Revision 1.34 / (download) - annotate - [select for diffs], Wed Apr 6 11:36:26 2011 UTC (13 years, 1 month ago) by miod
Branch: MAIN
CVS Tags: OPENBSD_5_3_BASE,
OPENBSD_5_3,
OPENBSD_5_2_BASE,
OPENBSD_5_2,
OPENBSD_5_1_BASE,
OPENBSD_5_1,
OPENBSD_5_0_BASE,
OPENBSD_5_0
Changes since 1.33: +3 -3 lines
Diff to previous 1.33 (colored)
Avoid using NULL in non-pointer contexts: use 0 for integer values and '\0' for chars.
Revision 1.33 / (download) - annotate - [select for diffs], Tue Oct 27 23:59:40 2009 UTC (14 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_9_BASE,
OPENBSD_4_9,
OPENBSD_4_8_BASE,
OPENBSD_4_8,
OPENBSD_4_7_BASE,
OPENBSD_4_7
Changes since 1.32: +1 -9 lines
Diff to previous 1.32 (colored)
rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and unmaintainable). these days, people use source. these id's do not provide any benefit, and do hurt the small install media (the 33,000 line diff is essentially mechanical) ok with the idea millert, ok dms
Revision 1.32 / (download) - annotate - [select for diffs], Mon May 10 15:25:51 2004 UTC (20 years ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE,
OPENBSD_4_6,
OPENBSD_4_5_BASE,
OPENBSD_4_5,
OPENBSD_4_4_BASE,
OPENBSD_4_4,
OPENBSD_4_3_BASE,
OPENBSD_4_3,
OPENBSD_4_2_BASE,
OPENBSD_4_2,
OPENBSD_4_1_BASE,
OPENBSD_4_1,
OPENBSD_4_0_BASE,
OPENBSD_4_0,
OPENBSD_3_9_BASE,
OPENBSD_3_9,
OPENBSD_3_8_BASE,
OPENBSD_3_8,
OPENBSD_3_7_BASE,
OPENBSD_3_7,
OPENBSD_3_6_BASE,
OPENBSD_3_6
Changes since 1.31: +3 -3 lines
Diff to previous 1.31 (colored)
delint; millert ok
Revision 1.31 / (download) - annotate - [select for diffs], Mon May 10 12:10:50 2004 UTC (20 years ago) by millert
Branch: MAIN
Changes since 1.30: +3 -3 lines
Diff to previous 1.30 (colored)
Get rid of the ancient "clobber" command. It was really only for debugging purposes. Noticed and OK by deraadt@
Revision 1.30 / (download) - annotate - [select for diffs], Fri Oct 24 20:32:06 2003 UTC (20 years, 6 months ago) by avsm
Branch: MAIN
CVS Tags: OPENBSD_3_5_BASE,
OPENBSD_3_5
Changes since 1.29: +4 -4 lines
Diff to previous 1.29 (colored)
dont compare int to NULL, millert@ ok
Revision 1.29 / (download) - annotate - [select for diffs], Mon Oct 13 00:46:08 2003 UTC (20 years, 7 months ago) by tedu
Branch: MAIN
Changes since 1.28: +5 -3 lines
Diff to previous 1.28 (colored)
better realloc. ok deraadt jose
Revision 1.28 / (download) - annotate - [select for diffs], Tue Jun 3 02:56:11 2003 UTC (20 years, 11 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_4_BASE,
OPENBSD_3_4
Changes since 1.27: +3 -7 lines
Diff to previous 1.27 (colored)
Remove the advertising clause in the UCB license which Berkeley rescinded 22 July 1999. Proofed by myself and Theo.
Revision 1.27 / (download) - annotate - [select for diffs], Wed Nov 21 20:41:55 2001 UTC (22 years, 6 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE,
OPENBSD_3_3,
OPENBSD_3_2_BASE,
OPENBSD_3_2,
OPENBSD_3_1_BASE,
OPENBSD_3_1
Changes since 1.26: +9 -7 lines
Diff to previous 1.26 (colored)
o kill strcpy() o check return values of malloc and friends o use strdup() when sensible
Revision 1.26 / (download) - annotate - [select for diffs], Wed Nov 21 15:26:39 2001 UTC (22 years, 6 months ago) by millert
Branch: MAIN
Changes since 1.25: +22 -41 lines
Diff to previous 1.25 (colored)
o ANSIfy
o Style nits
o Use const to silent stupid -Wall warnings
o strnc{py,at} -> strlc{py,at}
o Use strpbrk() instead of homegrown anyof()
o Use NULL instead of #defines with 0 cast to a pointer
This still could use a proper audit
Revision 1.25 / (download) - annotate - [select for diffs], Tue Nov 20 20:50:00 2001 UTC (22 years, 6 months ago) by millert
Branch: MAIN
Changes since 1.24: +24 -55 lines
Diff to previous 1.24 (colored)
Major signal overhaul. We no longer longjmp all over the place. Instead, routines responsible to gathering user input (or in some cases outputting data) catch the signals and set flags as needed. Because of this some handlers are install without the SA_RESTART flag so syscalls are not restarted and we can check the flag. All signal handlers are now safe. This should make the flow of control a bit more grokable but the code is still ugly.
Revision 1.24 / (download) - annotate - [select for diffs], Sat Nov 17 19:10:25 2001 UTC (22 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.23: +7 -3 lines
Diff to previous 1.23 (colored)
properly bail out of incfile(); millert ok
Revision 1.23 / (download) - annotate - [select for diffs], Sat Jun 23 23:04:23 2001 UTC (22 years, 11 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE,
OPENBSD_3_0
Changes since 1.22: +4 -7 lines
Diff to previous 1.22 (colored)
Remove evil #ifdef __GNUC__ garbage to avoid longjmp clobbering and use volatile instead.
Revision 1.22 / (download) - annotate - [select for diffs], Tue Jan 16 05:36:08 2001 UTC (23 years, 4 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_9_BASE,
OPENBSD_2_9
Changes since 1.21: +53 -4 lines
Diff to previous 1.21 (colored)
Changes from Don Beusee: o escape From line with a leading '>' when needed o only print To: address and Subject lines if actually present o new variable 'allnet' to treat user@foo and user@bar as the same "user" o folders command now takes an optional argument like ls. o new "pipe" (|) command to pipe the message through an arbitrary command o make header display format the same as SunOS 4.1.3 /usr/ucb/mail o tilde commands work regardless of interactive mode. o fix "read: Interrupted system call" error by retrying if EINTR o expanded help file Changes by me: o read the help file via the PAGER as it is now more than 24 lines long
Revision 1.19.2.1 / (download) - annotate - [select for diffs], Fri Oct 6 21:16:15 2000 UTC (23 years, 7 months ago) by jason
Branch: OPENBSD_2_7
Changes since 1.19: +7 -7 lines
Diff to previous 1.19 (colored) next main 1.20 (colored)
Pull in patch from current (even more to come): Fix (millert): warnx?/errx? paranoia (use "%s" not a bare string unless it is a constant). These are not security holes but it is worth fixing them anyway both for robustness and so folks looking for examples in the tree are not misled into doing something potentially dangerous. Furthermore, it is a bad idea to assume that pathnames will not include '%' in them and that error routines don't return strings with '%' in them (especially in light of the possibility of locales).
Revision 1.21 / (download) - annotate - [select for diffs], Thu Jul 6 06:24:21 2000 UTC (23 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_8_BASE,
OPENBSD_2_8
Changes since 1.20: +3 -3 lines
Diff to previous 1.20 (colored)
printf with % for the prompt
Revision 1.20 / (download) - annotate - [select for diffs], Fri Jun 30 16:00:19 2000 UTC (23 years, 10 months ago) by millert
Branch: MAIN
Changes since 1.19: +7 -7 lines
Diff to previous 1.19 (colored)
warnx?/errx? paranoia (use "%s" not a bare string unless it is a constant). These are not security holes but it is worth fixing them anyway both for robustness and so folks looking for examples in the tree are not misled into doing something potentially dangerous. Furthermore, it is a bad idea to assume that pathnames will not include '%' in them and that error routines don't return strings with '%' in them (especially in light of the possibility of locales).
Revision 1.19 / (download) - annotate - [select for diffs], Tue Apr 25 16:42:22 2000 UTC (24 years ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_7_BASE
Branch point for: OPENBSD_2_7
Changes since 1.18: +3 -2 lines
Diff to previous 1.18 (colored)
When incorporating new messages, clear the "new" count before the inc so the count of new messages is useful afterwards. This makes mail behave more like the SunOS version in this respect.
Revision 1.18 / (download) - annotate - [select for diffs], Tue Sep 8 14:59:12 1998 UTC (25 years, 8 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_6_BASE,
OPENBSD_2_6,
OPENBSD_2_5_BASE,
OPENBSD_2_5,
OPENBSD_2_4_BASE,
OPENBSD_2_4
Changes since 1.17: +4 -2 lines
Diff to previous 1.17 (colored)
Fix comments in .mailrc where there is no space after the hash (#). Noted by pjanzen@foatdi.harvard.edu
Revision 1.17 / (download) - annotate - [select for diffs], Fri Jun 12 18:07:57 1998 UTC (25 years, 11 months ago) by millert
Branch: MAIN
Changes since 1.16: +2 -6 lines
Diff to previous 1.16 (colored)
back out some signal changes that can cause mail to hang when quitting due to SIGCHLD blockage
Revision 1.16 / (download) - annotate - [select for diffs], Mon May 4 05:37:49 1998 UTC (26 years ago) by millert
Branch: MAIN
Changes since 1.15: +6 -2 lines
Diff to previous 1.15 (colored)
Never remove a mail spool, as we may not have proper prics, just truncate. Also block signals in a few critical areas
Revision 1.15 / (download) - annotate - [select for diffs], Fri Nov 14 00:23:48 1997 UTC (26 years, 6 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_3_BASE,
OPENBSD_2_3
Changes since 1.14: +11 -13 lines
Diff to previous 1.14 (colored)
NetBSD changes (mostly comsmetic):
replace panic() with calls to err()/errx()
use S_IS* instead of doing by hand with S_IF*.
Use TIMESPEC_TO_TIMEVAL() and gettimeofday instead of time(2)
Use _POSIX_VDISABLE, not 0
Kill register
Revision 1.14 / (download) - annotate - [select for diffs], Wed Jul 30 07:19:31 1997 UTC (26 years, 9 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_2_BASE,
OPENBSD_2_2
Changes since 1.13: +6 -4 lines
Diff to previous 1.13 (colored)
Make istrcpy() take a size (not length) field, now called istrncpy(). Change some strcpy() -> strncpy() out of paranoia.
Revision 1.13 / (download) - annotate - [select for diffs], Wed Jul 30 06:32:40 1997 UTC (26 years, 9 months ago) by millert
Branch: MAIN
Changes since 1.12: +13 -13 lines
Diff to previous 1.12 (colored)
Fix one possible oflow (not exploitable) and do a wee bit of KNF. Much more remains to be done.
Revision 1.12 / (download) - annotate - [select for diffs], Thu Jul 24 17:27:11 1997 UTC (26 years, 10 months ago) by millert
Branch: MAIN
Changes since 1.11: +5 -5 lines
Diff to previous 1.11 (colored)
tempnam(3) goes bye bye.
Revision 1.11 / (download) - annotate - [select for diffs], Thu Jul 24 16:23:38 1997 UTC (26 years, 10 months ago) by millert
Branch: MAIN
Changes since 1.10: +12 -9 lines
Diff to previous 1.10 (colored)
Replace 3 tempnam()'s with mkstemp. The two left look tricky.
Revision 1.10 / (download) - annotate - [select for diffs], Tue Jul 22 19:13:25 1997 UTC (26 years, 10 months ago) by millert
Branch: MAIN
Changes since 1.9: +6 -2 lines
Diff to previous 1.9 (colored)
incfile() needs to lock the mail spool so it doesn't get partial messages. Noticed by Theo.
Revision 1.9 / (download) - annotate - [select for diffs], Tue Jul 22 06:46:20 1997 UTC (26 years, 10 months ago) by millert
Branch: MAIN
Changes since 1.8: +7 -9 lines
Diff to previous 1.8 (colored)
Release signals when we get an error condition in incfile().
Revision 1.8 / (download) - annotate - [select for diffs], Mon Jul 14 00:24:27 1997 UTC (26 years, 10 months ago) by millert
Branch: MAIN
Changes since 1.7: +12 -12 lines
Diff to previous 1.7 (colored)
NOSTR -> NULL Use sigsetjmp/siglongjmp instead of sigjmp/longjmp for portability.
Revision 1.7 / (download) - annotate - [select for diffs], Sun Jul 13 23:54:00 1997 UTC (26 years, 10 months ago) by millert
Branch: MAIN
Changes since 1.6: +7 -7 lines
Diff to previous 1.6 (colored)
bcopy() -> memcpy() and fix some casts.
Revision 1.6 / (download) - annotate - [select for diffs], Sun Jul 13 21:21:13 1997 UTC (26 years, 10 months ago) by millert
Branch: MAIN
Changes since 1.5: +91 -54 lines
Diff to previous 1.5 (colored)
Merge in NetBSD and 4.4BSD-lite2 changes as well as some of my own. - handle long lines safely (from NetBSD) - use puts/fputs and putchar/putc when it makes sense - use err/errx and warn/warnx when it makes sense - make return() and sizeof() style consisten - some more buffer safety
Revision 1.5 / (download) - annotate - [select for diffs], Fri May 30 08:51:40 1997 UTC (26 years, 11 months ago) by deraadt
Branch: MAIN
Changes since 1.4: +5 -5 lines
Diff to previous 1.4 (colored)
overflows abound
Revision 1.4 / (download) - annotate - [select for diffs], Fri Jan 17 07:12:47 1997 UTC (27 years, 4 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_1_BASE,
OPENBSD_2_1
Changes since 1.3: +3 -3 lines
Diff to previous 1.3 (colored)
r?index -> strr?chr
Revision 1.3 / (download) - annotate - [select for diffs], Tue Jun 11 12:53:42 1996 UTC (27 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_0_BASE,
OPENBSD_2_0
Changes since 1.2: +22 -10 lines
Diff to previous 1.2 (colored)
from christos; - Fix PR/105: Implement dot locking protocol and check return value of flock. - Fix PR/2247: Don't call unknown users "ubluit". Issue an error message. - Fix/add prototypes. - Fix warnings. - Use POSIX signal mask calls.
Revision 1.2 / (download) - annotate - [select for diffs], Wed Mar 27 19:32:33 1996 UTC (28 years, 1 month ago) by niklas
Branch: MAIN
Changes since 1.1: +7 -5 lines
Diff to previous 1.1 (colored)
From NetBSD: merge of 960317
Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Wed Oct 18 08:45:39 1995 UTC (28 years, 7 months ago) by deraadt
CVS Tags: netbsd_1_1
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)
initial import of NetBSD tree
Revision 1.1 / (download) - annotate - [select for diffs], Wed Oct 18 08:45:39 1995 UTC (28 years, 7 months ago) by deraadt
Branch: MAIN
Initial revision