OpenBSD CVS

CVS log for src/usr.bin/mail/popen.c


[BACK] Up to [local] / src / usr.bin / mail

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.40 / (download) - annotate - [select for diffs], Wed Mar 8 04:43:11 2023 UTC (14 months, 1 week ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, HEAD
Changes since 1.39: +1 -2 lines
Diff to previous 1.39 (colored)

Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

Revision 1.39 / (download) - annotate - [select for diffs], Fri Jun 28 13:35:02 2019 UTC (4 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.38: +3 -3 lines
Diff to previous 1.38 (colored)

When system calls indicate an error they return -1, not some arbitrary
value < 0.  errno is only updated in this case.  Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Revision 1.38 / (download) - annotate - [select for diffs], Fri Oct 16 17:56:07 2015 UTC (8 years, 7 months ago) by mmcc
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.37: +5 -5 lines
Diff to previous 1.37 (colored)

Modernize allocation by:

 * removing unneeded casts of void* return values
 * replacing varied and creative error messages with the allocation
   function's name
 * replacing errx() with err() so that the errno string is reported

ok beck@, jung@, millert@

Revision 1.37 / (download) - annotate - [select for diffs], Fri Jan 16 06:40:09 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.36: +2 -2 lines
Diff to previous 1.36 (colored)

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible.  Annotate <sys/param.h> lines with their current reasons.  Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc.  Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution.  These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Revision 1.36 / (download) - annotate - [select for diffs], Mon Apr 29 00:28:23 2013 UTC (11 years ago) by okan
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4
Changes since 1.35: +5 -5 lines
Diff to previous 1.35 (colored)

use FD_CLOEXEC instead of 1; from David Hill

ok otto

Revision 1.35 / (download) - annotate - [select for diffs], Tue Oct 27 23:59:40 2009 UTC (14 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.34: +1 -9 lines
Diff to previous 1.34 (colored)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable).  these days, people use source.  these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Revision 1.34 / (download) - annotate - [select for diffs], Wed Sep 15 22:21:11 2004 UTC (19 years, 8 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3, OPENBSD_4_2_BASE, OPENBSD_4_2, OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0, OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7
Changes since 1.33: +4 -6 lines
Diff to previous 1.33 (colored)

unused variable

Revision 1.33 / (download) - annotate - [select for diffs], Tue Jun 3 02:56:11 2003 UTC (20 years, 11 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_6_BASE, OPENBSD_3_6, OPENBSD_3_5_BASE, OPENBSD_3_5, OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.32: +3 -7 lines
Diff to previous 1.32 (colored)

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999.  Proofed by myself and Theo.

Revision 1.32 / (download) - annotate - [select for diffs], Wed Jun 12 06:07:15 2002 UTC (21 years, 11 months ago) by mpech
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3, OPENBSD_3_2_BASE, OPENBSD_3_2
Changes since 1.31: +3 -3 lines
Diff to previous 1.31 (colored)

a real pid_t cleanup.

espie@ ok for make/,
deraadt@ one extra eye,
millert@ ok

Revision 1.31 / (download) - annotate - [select for diffs], Fri Nov 23 00:03:24 2001 UTC (22 years, 6 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.30: +3 -11 lines
Diff to previous 1.30 (colored)

Revert change to Popen() to only wrap command in a shell if it
contains meta characters since people may expect their aliases to
work.
Instead, just remove the "kill(lock_pid, SIGTERM);" since lockspool
now does the right thing when the pipe is closed.

Revision 1.30 / (download) - annotate - [select for diffs], Wed Nov 21 20:41:55 2001 UTC (22 years, 6 months ago) by millert
Branch: MAIN
Changes since 1.29: +6 -3 lines
Diff to previous 1.29 (colored)

o kill strcpy()
o check return values of malloc and friends
o use strdup() when sensible

Revision 1.29 / (download) - annotate - [select for diffs], Wed Nov 21 15:26:39 2001 UTC (22 years, 6 months ago) by millert
Branch: MAIN
Changes since 1.28: +40 -91 lines
Diff to previous 1.28 (colored)

o ANSIfy
o Style nits
o Use const to silent stupid -Wall warnings
o strnc{py,at} -> strlc{py,at}
o Use strpbrk() instead of homegrown anyof()
o Use NULL instead of #defines with 0 cast to a pointer
This still could use a proper audit

Revision 1.28 / (download) - annotate - [select for diffs], Tue Nov 20 23:19:44 2001 UTC (22 years, 6 months ago) by millert
Branch: MAIN
Changes since 1.27: +11 -4 lines
Diff to previous 1.27 (colored)

In private version of popen(), only wrap a command to be run in a
shell if it contains meta chars.  Sneaky hack to work around a ksh
bug.

Revision 1.27 / (download) - annotate - [select for diffs], Tue Sep 4 23:16:11 2001 UTC (22 years, 8 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0
Changes since 1.26: +10 -5 lines
Diff to previous 1.26 (colored)

Fix bogus use of snprintf return value.  Since we know the max
length of a username we can use that as part of the buffer size.

Revision 1.26 / (download) - annotate - [select for diffs], Fri Jan 19 04:11:29 2001 UTC (23 years, 4 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_9_BASE, OPENBSD_2_9
Changes since 1.25: +7 -6 lines
Diff to previous 1.25 (colored)

More fixes from Don Beusee:
- edit and other interactive commands have no stdin (making the
  command completely broken).
- messages with "From " line having date format with -0800 type of timezone
  are not recognized correctly.

Revision 1.25 / (download) - annotate - [select for diffs], Tue Jan 16 05:36:08 2001 UTC (23 years, 4 months ago) by millert
Branch: MAIN
Changes since 1.24: +80 -35 lines
Diff to previous 1.24 (colored)

Changes from Don Beusee:
o escape From line with a leading '>' when needed
o only print To: address and Subject lines if actually present
o new variable 'allnet' to treat user@foo and user@bar as the same "user"
o folders command now takes an optional argument like ls.
o new "pipe" (|) command to pipe the message through an arbitrary command
o make header display format the same as SunOS 4.1.3 /usr/ucb/mail
o tilde commands work regardless of interactive mode.
o fix "read: Interrupted system call" error by retrying if EINTR
o expanded help file
Changes by me:
o read the help file via the PAGER as it is now more than 24 lines long

Revision 1.23.8.1 / (download) - annotate - [select for diffs], Fri Oct 6 21:16:14 2000 UTC (23 years, 7 months ago) by jason
Branch: OPENBSD_2_7
Changes since 1.23: +3 -3 lines
Diff to previous 1.23 (colored) next main 1.24 (colored)

Pull in patch from current (even more to come):
Fix (millert):
warnx?/errx? paranoia (use "%s" not a bare string unless it is a
constant).  These are not security holes but it is worth fixing
them anyway both for robustness and so folks looking for examples
in the tree are not misled into doing something potentially dangerous.
Furthermore, it is a bad idea to assume that pathnames will not
include '%' in them and that error routines don't return strings
with '%' in them (especially in light of the possibility of locales).

Revision 1.24 / (download) - annotate - [select for diffs], Fri Jun 30 16:00:18 2000 UTC (23 years, 10 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_8_BASE, OPENBSD_2_8
Changes since 1.23: +3 -3 lines
Diff to previous 1.23 (colored)

warnx?/errx? paranoia (use "%s" not a bare string unless it is a
constant).  These are not security holes but it is worth fixing
them anyway both for robustness and so folks looking for examples
in the tree are not misled into doing something potentially dangerous.
Furthermore, it is a bad idea to assume that pathnames will not
include '%' in them and that error routines don't return strings
with '%' in them (especially in light of the possibility of locales).

Revision 1.23 / (download) - annotate - [select for diffs], Sun Sep 27 21:16:42 1998 UTC (25 years, 7 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_7_BASE, OPENBSD_2_6_BASE, OPENBSD_2_6, OPENBSD_2_5_BASE, OPENBSD_2_5, OPENBSD_2_4_BASE, OPENBSD_2_4
Branch point for: OPENBSD_2_7
Changes since 1.22: +13 -5 lines
Diff to previous 1.22 (colored)

Use new username option to lockspool for 'mail -u'.

Revision 1.22 / (download) - annotate - [select for diffs], Thu Sep 10 16:18:37 1998 UTC (25 years, 8 months ago) by millert
Branch: MAIN
Changes since 1.21: +3 -3 lines
Diff to previous 1.21 (colored)

Fix comments

Revision 1.21 / (download) - annotate - [select for diffs], Thu Sep 10 16:06:40 1998 UTC (25 years, 8 months ago) by millert
Branch: MAIN
Changes since 1.20: +25 -19 lines
Diff to previous 1.20 (colored)

If a child has not been waited on via the SIGCHLD handler, wait for it
ourselves instead of playing games with sigsuspend.  This may fix PR 588.

Revision 1.20 / (download) - annotate - [select for diffs], Tue Sep 8 15:24:38 1998 UTC (25 years, 8 months ago) by millert
Branch: MAIN
Changes since 1.19: +12 -12 lines
Diff to previous 1.19 (colored)

repair order of signal blocking that got changed in conversion to POSIX signals

Revision 1.19 / (download) - annotate - [select for diffs], Sat Aug 15 23:17:24 1998 UTC (25 years, 9 months ago) by millert
Branch: MAIN
Changes since 1.18: +5 -10 lines
Diff to previous 1.18 (colored)

use lockspool for locking, not 'mail.local -H'

Revision 1.18 / (download) - annotate - [select for diffs], Fri Jun 12 18:07:58 1998 UTC (25 years, 11 months ago) by millert
Branch: MAIN
Changes since 1.17: +2 -6 lines
Diff to previous 1.17 (colored)

back out some signal changes that can cause mail to hang when quitting due to SIGCHLD blockage

Revision 1.17 / (download) - annotate - [select for diffs], Fri Jun 12 17:51:53 1998 UTC (25 years, 11 months ago) by millert
Branch: MAIN
Changes since 1.16: +8 -2 lines
Diff to previous 1.16 (colored)

Don't call truncate() directly; have rm() do it if we get EPERM on unlink()
In popen.c, findchild() may return NULL so catch that case.

Revision 1.16 / (download) - annotate - [select for diffs], Mon May 4 05:37:52 1998 UTC (26 years ago) by millert
Branch: MAIN
Changes since 1.15: +6 -2 lines
Diff to previous 1.15 (colored)

Never remove a mail spool, as we may not have proper prics, just truncate.  Also block signals in a few critical areas

Revision 1.15 / (download) - annotate - [select for diffs], Sun Feb 15 21:20:02 1998 UTC (26 years, 3 months ago) by niklas
Branch: MAIN
CVS Tags: OPENBSD_2_3_BASE, OPENBSD_2_3
Changes since 1.14: +20 -10 lines
Diff to previous 1.14 (colored)

Remove one case of malloc call from sighandler

Revision 1.14 / (download) - annotate - [select for diffs], Fri Nov 14 00:23:54 1997 UTC (26 years, 6 months ago) by millert
Branch: MAIN
Changes since 1.13: +12 -12 lines
Diff to previous 1.13 (colored)

NetBSD changes (mostly comsmetic):
    replace panic() with calls to err()/errx()
    use S_IS* instead of doing by hand with S_IF*.
    Use TIMESPEC_TO_TIMEVAL() and gettimeofday instead of time(2)
    Use _POSIX_VDISABLE, not 0
    Kill register

Revision 1.13 / (download) - annotate - [select for diffs], Sun Aug 31 14:32:14 1997 UTC (26 years, 8 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_2_BASE, OPENBSD_2_2
Changes since 1.12: +7 -7 lines
Diff to previous 1.12 (colored)

Kill union wait.

Revision 1.12 / (download) - annotate - [select for diffs], Tue Aug 5 04:00:00 1997 UTC (26 years, 9 months ago) by deraadt
Branch: MAIN
Changes since 1.11: +3 -2 lines
Diff to previous 1.11 (colored)

pull errno.h in

Revision 1.11 / (download) - annotate - [select for diffs], Mon Aug 4 19:25:50 1997 UTC (26 years, 9 months ago) by deraadt
Branch: MAIN
Changes since 1.10: +4 -2 lines
Diff to previous 1.10 (colored)

save errno in sigchld handlers

Revision 1.10 / (download) - annotate - [select for diffs], Mon Jul 14 16:09:07 1997 UTC (26 years, 10 months ago) by millert
Branch: MAIN
Changes since 1.9: +10 -10 lines
Diff to previous 1.9 (colored)

Don't call it a mask when it is a sigset_t (cosmetic changes only).

Revision 1.9 / (download) - annotate - [select for diffs], Mon Jul 14 15:56:24 1997 UTC (26 years, 10 months ago) by millert
Branch: MAIN
Changes since 1.8: +7 -5 lines
Diff to previous 1.8 (colored)

Convert remaining sigsetmask() -> sigprocmask() (POSIX style)
in collect.c and fix up some signal botches elsewhere.

Revision 1.8 / (download) - annotate - [select for diffs], Mon Jul 14 00:24:29 1997 UTC (26 years, 10 months ago) by millert
Branch: MAIN
Changes since 1.7: +7 -7 lines
Diff to previous 1.7 (colored)

NOSTR -> NULL
Use sigsetjmp/siglongjmp instead of sigjmp/longjmp for portability.

Revision 1.7 / (download) - annotate - [select for diffs], Sun Jul 13 23:54:01 1997 UTC (26 years, 10 months ago) by millert
Branch: MAIN
Changes since 1.6: +16 -16 lines
Diff to previous 1.6 (colored)

bcopy() -> memcpy() and fix some casts.

Revision 1.6 / (download) - annotate - [select for diffs], Sun Jul 13 21:21:15 1997 UTC (26 years, 10 months ago) by millert
Branch: MAIN
Changes since 1.5: +43 -41 lines
Diff to previous 1.5 (colored)

Merge in NetBSD and 4.4BSD-lite2 changes as well as some of my own.
 - handle long lines safely (from NetBSD)
 - use puts/fputs and putchar/putc when it makes sense
 - use err/errx and warn/warnx when it makes sense
 - make return() and sizeof() style consisten
 - some more buffer safety

Revision 1.5 / (download) - annotate - [select for diffs], Fri May 30 08:51:43 1997 UTC (26 years, 11 months ago) by deraadt
Branch: MAIN
Changes since 1.4: +3 -3 lines
Diff to previous 1.4 (colored)

overflows abound

Revision 1.4 / (download) - annotate - [select for diffs], Sat Mar 29 03:01:47 1997 UTC (27 years, 1 month ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_1_BASE, OPENBSD_2_1
Changes since 1.3: +59 -2 lines
Diff to previous 1.3 (colored)

Use ``mail.local -H'' to do dot locking so we can have mode 755 mail
spool, change an occurrence of tempnam() to mkstemp(), change some
longs and shorts to ints.  Mail is now usable again.

Revision 1.3 / (download) - annotate - [select for diffs], Wed Jun 26 21:22:34 1996 UTC (27 years, 10 months ago) by dm
Branch: MAIN
CVS Tags: OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.2: +9 -7 lines
Diff to previous 1.2 (colored)

Accept NULL nset in prepare child (as run_editor will try to use one).

Revision 1.2 / (download) - annotate - [select for diffs], Tue Jun 11 12:53:47 1996 UTC (27 years, 11 months ago) by deraadt
Branch: MAIN
Changes since 1.1: +43 -19 lines
Diff to previous 1.1 (colored)

from christos;
- Fix PR/105: Implement dot locking protocol and check return value of flock.
- Fix PR/2247: Don't call unknown users "ubluit". Issue an error message.
- Fix/add prototypes.
- Fix warnings.
- Use POSIX signal mask calls.

Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Wed Oct 18 08:45:39 1995 UTC (28 years, 7 months ago) by deraadt
CVS Tags: netbsd_1_1
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)

initial import of NetBSD tree

Revision 1.1 / (download) - annotate - [select for diffs], Wed Oct 18 08:45:39 1995 UTC (28 years, 7 months ago) by deraadt
Branch: MAIN

Initial revision

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.