OpenBSD CVS

CVS log for src/usr.bin/make/compat.c


[BACK] Up to [local] / src / usr.bin / make

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.94 / (download) - annotate - [select for diffs], Mon Sep 4 11:35:11 2023 UTC (8 months, 2 weeks ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, HEAD
Changes since 1.93: +1 -2 lines
Diff to previous 1.93 (colored)

GC old code that was originally implemented to facilitate adoption by
other BSDs, which never happened, so make things simpler for further
development.

Ditches config.h entirely since it gets reduced to 2 defines.

okay tb@

Revision 1.93 / (download) - annotate - [select for diffs], Sun Jan 26 12:41:21 2020 UTC (4 years, 3 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7
Changes since 1.92: +6 -20 lines
Diff to previous 1.92 (colored)

remove OP_* for deprecated keywords (document that :: still uses
OP_INVISIBLE)

okay millert@

Revision 1.92 / (download) - annotate - [select for diffs], Sun Jan 26 12:35:57 2020 UTC (4 years, 3 months ago) by espie
Branch: MAIN
Changes since 1.91: +7 -10 lines
Diff to previous 1.91 (colored)

simplify logic in compat engine, we can set ABORTED directly instead of
waiting for the father to do so.
okay millert@

Revision 1.91 / (download) - annotate - [select for diffs], Mon Jan 13 15:41:53 2020 UTC (4 years, 4 months ago) by espie
Branch: MAIN
Changes since 1.90: +16 -13 lines
Diff to previous 1.90 (colored)

make the choice of engine explicit

simplify the running of .BEGIN/.END so that they pass through the engine
first (so they can now have dependencies). Error out properly if .BEGIN/.END
fails.

Revision 1.90 / (download) - annotate - [select for diffs], Mon Jan 13 15:24:31 2020 UTC (4 years, 4 months ago) by espie
Branch: MAIN
Changes since 1.89: +3 -5 lines
Diff to previous 1.89 (colored)

unify compat mode and parallelmode a bit: there's no longer a need for
handle_one_job, always go thru Job_Make now.

Revision 1.89 / (download) - annotate - [select for diffs], Wed Jan 8 14:09:29 2020 UTC (4 years, 4 months ago) by espie
Branch: MAIN
Changes since 1.88: +8 -3 lines
Diff to previous 1.88 (colored)

fix -q: in compatMode, compute and return outofdate just like parallel mode.
Also, never run .END in querymode (we don't actually care about updating
problem in that case).

okay millert@

Revision 1.88 / (download) - annotate - [select for diffs], Sat Dec 21 15:29:25 2019 UTC (4 years, 4 months ago) by espie
Branch: MAIN
Changes since 1.87: +11 -11 lines
Diff to previous 1.87 (colored)

rename a few variable/functions to have better names.
adjust comments to be more meaningful
reorder predecessors/successors fields in an order that
makes more sense to me.

okay millert@

Revision 1.87 / (download) - annotate - [select for diffs], Sat Dec 21 15:28:16 2019 UTC (4 years, 4 months ago) by espie
Branch: MAIN
Changes since 1.86: +7 -7 lines
Diff to previous 1.86 (colored)

rename built_status constants to be less quirky
fold back BEINGMADE and BUILDING which mean the same thing
GC CYCLE/ENDCYCLE

okay millert@

Revision 1.86 / (download) - annotate - [select for diffs], Fri Oct 21 16:12:38 2016 UTC (7 years, 6 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1
Changes since 1.85: +2 -2 lines
Diff to previous 1.85 (colored)

small obvious cleanups:
- remove a lot of unnecessary casts
- zap extra param that's no longer needed
- add proper prototype and make function static

okay natano@

Revision 1.85 / (download) - annotate - [select for diffs], Fri Jan 23 13:38:16 2015 UTC (9 years, 3 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9, OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.84: +2 -2 lines
Diff to previous 1.84 (colored)

typo

Revision 1.84 / (download) - annotate - [select for diffs], Fri Jan 23 13:18:40 2015 UTC (9 years, 3 months ago) by espie
Branch: MAIN
Changes since 1.83: +3 -3 lines
Diff to previous 1.83 (colored)

remove a bunch of dangerous casts (useless casts from void * to something
else, in some cases by adding extra temporary variables.
IMO, it's much better practice to do

void *a;
int *p = a;
*p = 42;

rather than
void *a;
*(int *)a = 42;

okay miod@... to be revisited for some possible const additions later.

Revision 1.83 / (download) - annotate - [select for diffs], Thu Jun 20 19:48:32 2013 UTC (10 years, 11 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4
Changes since 1.82: +2 -2 lines
Diff to previous 1.82 (colored)

fix typo
thx Caspar Schutijser

Revision 1.82 / (download) - annotate - [select for diffs], Thu May 30 08:58:38 2013 UTC (10 years, 11 months ago) by espie
Branch: MAIN
Changes since 1.81: +5 -5 lines
Diff to previous 1.81 (colored)

remove cmtime again, but with a proper test for nodes without children.

problem seen by aja,
make pointed by matthieu,
sleuthing by me,
okay by millert

(and you say OpenBSD developers don't work together)

Revision 1.81 / (download) - annotate - [select for diffs], Sat May 25 11:54:14 2013 UTC (10 years, 11 months ago) by espie
Branch: MAIN
Changes since 1.80: +5 -5 lines
Diff to previous 1.80 (colored)

obviously missed something, so revert.
(noticed by sthen@/matthieu@)

Revision 1.80 / (download) - annotate - [select for diffs], Wed May 22 12:14:08 2013 UTC (11 years ago) by espie
Branch: MAIN
Changes since 1.79: +12 -10 lines
Diff to previous 1.79 (colored)

as checked through thorough tests, youngest->mtime == ctime, so ditch
the extra field.

remove some extra abstraction layer: use clock_gettime directly
instead of ts_set_from_now (what is "now" anyways)

time_to_string takes param by pointer

rename "now" into starttime (more accurate term)

randomize queue uses arc4random_uniform (prompted by deraadt@)

display debug timestamp with ns too (it's debug, so it doesn't really
matter whichever way it's done, as long as it's done)

okay millert@

Revision 1.79 / (download) - annotate - [select for diffs], Tue Apr 23 14:32:53 2013 UTC (11 years ago) by espie
Branch: MAIN
Changes since 1.78: +2 -1 lines
Diff to previous 1.78 (colored)

remove TIMESTAMP abstraction layer, prodded by theo.
while there, clean up includes.
use strtoll for ar timestamps (pretty much unused in reality, more
standard conforming than anything)

use idea from Todd to adapt to time_t being 32 bits OR 64 bits
(pedantically correct: INT_MIN would work just fine up to 1910 or so...)

okay millert@, gone thru a make build.

Revision 1.78 / (download) - annotate - [select for diffs], Sat Nov 24 11:03:45 2012 UTC (11 years, 5 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_5_3_BASE, OPENBSD_5_3
Changes since 1.77: +28 -24 lines
Diff to previous 1.77 (colored)

clean-up: move up .USE handling, so that the rest becomes a simple switch()

okay beck@

Revision 1.77 / (download) - annotate - [select for diffs], Fri Sep 21 07:55:20 2012 UTC (11 years, 7 months ago) by espie
Branch: MAIN
Changes since 1.76: +5 -22 lines
Diff to previous 1.76 (colored)

major overhaul of the way make handle jobs, inspired by dpb:
instead of forking a "job" per target, and having that job further fork
separate commands, have make maintain a list of jobs, indexed by pid
of currently running commands, and handle process termination
continuation-style.  This has lots of benefits:
- make is responsible for most printing, so we no longer need pipes nor
job control: make -j jobs see the tty.
- no more special-casing for jobs that don't really execute anything.
- unify code for make -jn and make -B, including signal handlers and
job waiting.  So make -n, make -q, +cmd now run commands in the same
way in all cases.
- unified more accurate error-reporting, as make knows precisely which
command failed. Commands are tagged with their lines, and we display failing
commands in silent mode.
- fine-grained "expensive" command handling (recursion limiter). Do it
per-command instead of per-target.

Moreover, signal response is now simpler, as we just block the signals
in a small critical sections, test for events, and sigpause (thanks a lot
to guenther@ and millert@), so running make is now almost always paused
without any busy-waiting.

Thanks to everyone who tested and gave input.

Revision 1.76 / (download) - annotate - [select for diffs], Thu Mar 22 13:47:12 2012 UTC (12 years, 2 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_5_2_BASE, OPENBSD_5_2
Changes since 1.75: +4 -4 lines
Diff to previous 1.75 (colored)

minor cleanup: error messages include lineno and fileno together, so
recognize that and create a struct Location_ for it.

mostly from Jonathan Calmels, a few nits from me.

okay otto@

Revision 1.75 / (download) - annotate - [select for diffs], Tue Nov 2 19:47:22 2010 UTC (13 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9
Changes since 1.74: +2 -2 lines
Diff to previous 1.74 (colored)

exit 1 (not -1) for -q; PR 6494

Revision 1.74 / (download) - annotate - [select for diffs], Mon Jul 19 19:46:43 2010 UTC (13 years, 10 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_4_8_BASE, OPENBSD_4_8
Changes since 1.73: +1 -2 lines
Diff to previous 1.73 (colored)

Correct $OpenBSD$ stuff

Revision 1.73 / (download) - annotate - [select for diffs], Sun Apr 25 13:59:53 2010 UTC (14 years ago) by espie
Branch: MAIN
Changes since 1.72: +3 -3 lines
Diff to previous 1.72 (colored)

pure whitespace cleanup

Revision 1.72 / (download) - annotate - [select for diffs], Sun Aug 16 09:53:43 2009 UTC (14 years, 9 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.71: +3 -3 lines
Diff to previous 1.71 (colored)

modify timestamp handling to grab current time instead of relying on a
stale timestamp.

all those diffs sent to people ages ago, who didn't answer, except for
Theo, who said he ran it with no issues, so let's get this in...

Revision 1.71 / (download) - annotate - [select for diffs], Sun May 10 11:07:37 2009 UTC (15 years ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6
Changes since 1.70: +1 -1 lines
Diff to previous 1.70 (colored)

simplify job handling a great deal: we don't care when jobs get
stopped/continued, as we won't try to start new jobs when other stuff
is stopped.

Redo signal handling so that most stuff can be done directly in the handler.
This requires blocking/unblocking signals while creating new jobs, and creating
a small list that only contains job's pids.

Switch to pgrps for jobs, since that works.

Add a clamping heuristic that avoids starting new jobs while an expensive job
is running (expensive meaning "very likely to be a recursive make run"). This
idea is mostly from Theo, through the implementation is mine.

Revision 1.70 / (download) - annotate - [select for diffs], Tue Nov 4 07:22:35 2008 UTC (15 years, 6 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_4_5_BASE, OPENBSD_4_5
Changes since 1.69: +77 -16 lines
Diff to previous 1.69 (colored)

changes to get target equivalence to work better.
- add new file to create lists of equivalent targets (siblings)
- use that for sequential mode to have much better VPATH support
- separate checking commands from reporting error, for later.
- zap DieHorribly accordingly
- renumber existing flags
- signal_running_jobs() is simpler than pass_signal_to_jobs()
- new debug option -dn for name matching.

Similar code to handle parallel make is still missing.

thanks to Mark, Miod, Theo, Otto, Todd for tests and/or comments.

Revision 1.69 / (download) - annotate - [select for diffs], Tue Jan 29 22:23:10 2008 UTC (16 years, 3 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.68: +3 -3 lines
Diff to previous 1.68 (colored)

A few changes:
- expand commands earlier, so that we can eventually scan them to take
smarter decisions.
- clean up the select() mask code and rename variables to sensible things.
- quite a few minor renames for readability
- erecalloc
- clean up wait status handling, do not try to rebuild wait status, but
instead parse it early and deal with the parsed code.

tested by lots of people, thanks guys!

Revision 1.68 / (download) - annotate - [select for diffs], Sat Nov 10 13:59:48 2007 UTC (16 years, 6 months ago) by espie
Branch: MAIN
Changes since 1.67: +1 -1 lines
Diff to previous 1.67 (colored)

UNMADE -> UNKNOWN

Revision 1.67 / (download) - annotate - [select for diffs], Sat Nov 10 12:51:40 2007 UTC (16 years, 6 months ago) by espie
Branch: MAIN
Changes since 1.66: +24 -24 lines
Diff to previous 1.66 (colored)

rename make -> must_make, made -> built_status
to make them easier to find in source files.

Revision 1.66 / (download) - annotate - [select for diffs], Tue Nov 6 21:12:23 2007 UTC (16 years, 6 months ago) by espie
Branch: MAIN
Changes since 1.65: +0 -9 lines
Diff to previous 1.65 (colored)

simplify the way we deal with implicit rules and handle $<.

Having an `iParents' field is actually backwards, it's ways simpler to
store the pointer in the child, as an impliedsrc, and to set the variable
just in time along with all the rest in DoAllVar.

This is simpler, and it should allow us to call SuffFindDeps much later.

Revision 1.65 / (download) - annotate - [select for diffs], Sat Nov 3 14:05:39 2007 UTC (16 years, 6 months ago) by espie
Branch: MAIN
Changes since 1.64: +1 -1 lines
Diff to previous 1.64 (colored)

simplify: Job_CheckCommands deals with silent and ignerr now, so there's
no need to duplicate that info at the job level since we can just use
the gn->type.

Revision 1.64 / (download) - annotate - [select for diffs], Sat Nov 3 11:42:41 2007 UTC (16 years, 6 months ago) by espie
Branch: MAIN
Changes since 1.63: +0 -8 lines
Diff to previous 1.63 (colored)

do the silent/ignore check in Job_CheckCommands, so that make -j4 -s works

Revision 1.63 / (download) - annotate - [select for diffs], Fri Nov 2 17:27:24 2007 UTC (16 years, 6 months ago) by espie
Branch: MAIN
Changes since 1.62: +6 -277 lines
Diff to previous 1.62 (colored)

Work done at p2k7.


This is a really big step towards getting parallel make to work.


Note that this is not yet complete. There are still a few `details' to
fix before this works 100%.  Specifically: sequential make (compat) and
parallel make don't use the same engine, and the parallel engine still
has a few limitations. For instance, some known issues:
- parallel make does not deal with .phony targets correctly all the time.
- some errors are deadly in parallel make mode.
- parallel make NEEDS way more sturdy correspondance of file system paths
and target names, since it often needs to match dependencies to targets
before the corresponding files exist.
- some local variables like $* get set in a bogus way in some cases.
- suffix handling has issues, especially related to the NULL suffix.
So, if you find stuff that does NOT yet work with parallel make, don't go
blindly try to fix the Makefile. It's very likely you might have stumbled
into a make bug. (unless you really, really, understand Makefiles, DON'T
GO CHANGING THEM YET).



Tested by lots of people, thanks go to miod@, and robert@ among other people.

Quick summary of what this does:

- remove `saving commands' extension (it's not really usable, nor used)
- move compat job runner and parallel interrupt handling into engine.c
- tweak the code so that both compat and parallel mode use the same job runner
and the same interrupt handling. Remove the other one.
- optimize job runner so that, in parallel mode, the last command does not
fork if we can avoid it (as it's already running in a sub shell).
- scrape all the code that dealt with creating shell scripts from commands.
- scrape all the code that dealt with recognizing special sequences in
command output to print/not print output.
- fix the parallel job pipe to not keep around file descriptors that are not
needed.
- replace the parallel job buffering with a nicer one, that deals with
non-blocking descriptors to try to agregate as much output from one job in
one go (greed) to unconfuse the users.
- create two pipes per job, so that stdout and stderr stay separate.
- make job token printing a debug option.
- always use the parallel job-runner to `execute' commands, even if we just
print them out.
- store list of errors encountered during parallel make running, and print them
on exit, so that we know what went wrong.
- add a dirty hack to targ.c to deal with paths produced by gccmakedep.

Revision 1.62 / (download) - annotate - [select for diffs], Sat Oct 27 08:44:12 2007 UTC (16 years, 6 months ago) by espie
Branch: MAIN
Changes since 1.61: +6 -6 lines
Diff to previous 1.61 (colored)

fix indentation

Revision 1.61 / (download) - annotate - [select for diffs], Sun Oct 14 09:02:10 2007 UTC (16 years, 7 months ago) by espie
Branch: MAIN
Changes since 1.60: +1 -3 lines
Diff to previous 1.60 (colored)

allows node to be run twice, by not destroying the cmdnode contents.
This way, you can run `make .BEGIN'. Okay, this will run .BEGIN twice.

Revision 1.60 / (download) - annotate - [select for diffs], Mon Sep 17 12:42:09 2007 UTC (16 years, 8 months ago) by espie
Branch: MAIN
Changes since 1.59: +156 -199 lines
Diff to previous 1.59 (colored)

rewrite of the basic suffix/target parsing: use hash for suffixes.

Store special targets in target hash, and use them for the parsing.

Use OP_DUMMY flag to mark targets that don't really exist yet, such
as interrupt and default nodes.

Also, .PATHxxx is special in suffixes.

Small tweaks to compat.c, so that run_commands does more stuff after
the fork() (and thus no need to free things).

Remove distinction between local and global jobs.

Revision 1.59 / (download) - annotate - [select for diffs], Mon Sep 17 09:28:36 2007 UTC (16 years, 8 months ago) by espie
Branch: MAIN
Changes since 1.58: +11 -11 lines
Diff to previous 1.58 (colored)

kill extra spaces at end of line

Revision 1.58 / (download) - annotate - [select for diffs], Mon Sep 17 08:36:57 2007 UTC (16 years, 8 months ago) by espie
Branch: MAIN
Changes since 1.57: +2 -2 lines
Diff to previous 1.57 (colored)

kill += 1, -= 1     -> ++, --

Revision 1.57 / (download) - annotate - [select for diffs], Sun Sep 16 14:18:40 2007 UTC (16 years, 8 months ago) by espie
Branch: MAIN
Changes since 1.56: +395 -382 lines
Diff to previous 1.56 (colored)

reindent compat.c

Revision 1.56 / (download) - annotate - [select for diffs], Sun Sep 16 12:09:36 2007 UTC (16 years, 8 months ago) by espie
Branch: MAIN
Changes since 1.55: +2 -2 lines
Diff to previous 1.55 (colored)

rename Targ_FmtTime into time_to_string and move it, as it's not related
to target nodes at all (reduces modules inter-dependencies)

Revision 1.55 / (download) - annotate - [select for diffs], Sun Sep 16 10:39:07 2007 UTC (16 years, 8 months ago) by espie
Branch: MAIN
Changes since 1.54: +2 -2 lines
Diff to previous 1.54 (colored)

first step towards sanity: take the functions common to parallel/not parallel
make outside of make.c and job.c, and create an engine.c file to hold them.

Revision 1.54 / (download) - annotate - [select for diffs], Sun Sep 16 09:46:14 2007 UTC (16 years, 8 months ago) by espie
Branch: MAIN
Changes since 1.53: +0 -29 lines
Diff to previous 1.53 (colored)

remove dead code: #define RECHECK is always on

Revision 1.53 / (download) - annotate - [select for diffs], Mon Jul 30 09:51:53 2007 UTC (16 years, 9 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_4_2_BASE, OPENBSD_4_2
Changes since 1.52: +0 -0 lines
Diff to previous 1.52 (colored)

everywhere except in Var_Parse, we always add/append variables to the
VAR_GLOBAL context, so make it the common case: rename the basic functions
to Var_Set_with_ctxt/Var_Append_with_ctxt, define Var_Set and Var_Append
as macros that specify VAR_GLOBAL, and use these.

okay miod@

Revision 1.52 / (download) - annotate - [select for diffs], Mon Jul 30 09:49:00 2007 UTC (16 years, 9 months ago) by espie
Branch: MAIN
Changes since 1.51: +2 -9 lines
Diff to previous 1.51 (colored)

local is always true, so zap it.
okay miod@

Revision 1.51 / (download) - annotate - [select for diffs], Thu Jan 4 17:55:35 2007 UTC (17 years, 4 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_4_1_BASE, OPENBSD_4_1
Changes since 1.50: +8 -10 lines
Diff to previous 1.50 (colored)

having a function that iterates through node's datum so that we retrieve
the list item with lst_member is non-sensical, create a new function
(Lst_ForEachNodeWhile) that iterates through lstnodes directly and use
it.

Less obfuscated, slightly more efficient...

okay otto@

Revision 1.50 / (download) - annotate - [select for diffs], Wed Apr 7 13:11:35 2004 UTC (20 years, 1 month ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_4_0_BASE, OPENBSD_4_0, OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6
Changes since 1.49: +11 -16 lines
Diff to previous 1.49 (colored)

ISO function declarations, trim a few comments, rename a few variables to
more explicit/more consistent names.

okay otto@

Revision 1.49 / (download) - annotate - [select for diffs], Tue Jun 3 02:56:11 2003 UTC (20 years, 11 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_5_BASE, OPENBSD_3_5, OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.48: +2 -6 lines
Diff to previous 1.48 (colored)

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999.  Proofed by myself and Theo.

Revision 1.48 / (download) - annotate - [select for diffs], Wed Jul 31 19:29:20 2002 UTC (21 years, 9 months ago) by mickey
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3, OPENBSD_3_2_BASE, OPENBSD_3_2
Changes since 1.47: +2 -2 lines
Diff to previous 1.47 (colored)

use fork, not vfork. seems to fix misterious trapframe trashing on hppa; deraadt@ ok

Revision 1.47 / (download) - annotate - [select for diffs], Wed Jun 12 06:07:15 2002 UTC (21 years, 11 months ago) by mpech
Branch: MAIN
Changes since 1.46: +3 -3 lines
Diff to previous 1.46 (colored)

a real pid_t cleanup.

espie@ ok for make/,
deraadt@ one extra eye,
millert@ ok

Revision 1.46 / (download) - annotate - [select for diffs], Wed Jan 16 01:28:54 2002 UTC (22 years, 4 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.45: +3 -9 lines
Diff to previous 1.45 (colored)

Use the volatile specifier to fix warnings about variables being
clobbered by longjmp / vfork instead of the gcc "(void)&foo;" hack.

Revision 1.45 / (download) - annotate - [select for diffs], Sun Dec 2 00:13:16 2001 UTC (22 years, 5 months ago) by espie
Branch: MAIN
Changes since 1.44: +36 -46 lines
Diff to previous 1.44 (colored)

Put back the interrupt fixed code, since it's not the issue.

Revision 1.44 / (download) - annotate - [select for diffs], Fri Nov 23 23:42:45 2001 UTC (22 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.43: +52 -42 lines
Diff to previous 1.43 (colored)

back out changes that break kernel compiles.  good testing jobmk install!

Revision 1.43 / (download) - annotate - [select for diffs], Thu Nov 22 23:56:43 2001 UTC (22 years, 6 months ago) by espie
Branch: MAIN
Changes since 1.42: +36 -46 lines
Diff to previous 1.42 (colored)

Remove broken interrupt handler.
Nothing of what it did is allowed in an interrupt handler.
Rather, just mark that an interrupt occurred, and check for interrupts
in the wait of RunCommand (that's the correct point to check for interrupts
anyways).

Okay miod@, millert@ approves (as he's too tired to look at the code)

Revision 1.42 / (download) - annotate - [select for diffs], Thu Nov 22 21:18:10 2001 UTC (22 years, 6 months ago) by espie
Branch: MAIN
Changes since 1.41: +7 -7 lines
Diff to previous 1.41 (colored)

Explicitly mark nodes whose commands have been filled with
implicit (suffix) rules.  Then, only expand the IMPSRC/< variable
if the node has been marked.

This matches what Single Unix 2 and common sense say: implicit rules
shouldn't count when an explicit rule has been found (an explicit rule
being a full-scale dependency, with some associated commands)

Note that Single Unix leaves the `PREFIX' question open, so we leave
the PREFIX code as it is.

This fixes regression case mk14, which now fails as it should.

This is just a bug-fix. Some more correct (and faster) code should
probably be substituted. Namely, right now, the suffix code is too
greedy, whereas it should test for explicit rules earlier, and not
even bother instantiating implicit rules from templates when they
duplicate actual existing rules.

ok millert@

Revision 1.41 / (download) - annotate - [select for diffs], Sat Nov 17 19:37:53 2001 UTC (22 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.40: +2 -2 lines
Diff to previous 1.40 (colored)

do not exit() from signal handler

Revision 1.40 / (download) - annotate - [select for diffs], Sat Sep 15 18:43:41 2001 UTC (22 years, 8 months ago) by mickey
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0
Changes since 1.39: +2 -2 lines
Diff to previous 1.39 (colored)

fix a pasto, fix pr 1969

Revision 1.39 / (download) - annotate - [select for diffs], Tue May 29 12:53:39 2001 UTC (22 years, 11 months ago) by espie
Branch: MAIN
Changes since 1.38: +3 -1 lines
Diff to previous 1.38 (colored)

Take includes out of lst.h, re-add what's needed to separate files.
Removes remaining lint stuff from lst.lib.

Revision 1.38 / (download) - annotate - [select for diffs], Tue May 29 12:17:05 2001 UTC (22 years, 11 months ago) by espie
Branch: MAIN
Changes since 1.37: +2 -1 lines
Diff to previous 1.37 (colored)

Blech! gcc is a stupid program. Compiling with -fno-builtin shows lots
of missing function declarations.

Revision 1.37 / (download) - annotate - [select for diffs], Wed May 23 12:34:40 2001 UTC (23 years ago) by espie
Branch: MAIN
Changes since 1.36: +47 -64 lines
Diff to previous 1.36 (colored)

Mostly clean-up:
- cut up those huge include files into separate interfaces for all modules.
Put the interface documentation there, and not with the implementation.
- light-weight includes for needed concrete types (lst_t.h, timestamp_t.h).
- cut out some more logically separate parts: cmd_exec, varname, parsevar,
timestamp.
- put all error handling functions together, so that we will be able to
clean them up.
- more systematic naming: functioni  to handle interval, function to handle
string.
- put the init/end code apart to minimize coupling.
- kill weird types like ReturnStatus and Boolean. Use standard bool (with a
fallback for non-iso systems)
- better interface documentation for lots of subsystems.

As a result, make compilation goes somewhat faster (5%, even considering
the largish BSD copyrights to read). The corresponding preprocessed
source goes down from 1,5M to 1M.

A few minor code changes as well: Parse_DoVar is no longer destructive.
Parse_IsVar functionality is folded into Parse_DoVar (as it knows what an
assignment is), a few more interval handling functions. Avoid calling
XXX_End when they do nothing, just #define XXX_End   to nothing.

Parse_DoVar is slightly more general: it will handle compound assignments
as long as they make sense, e.g., VAR +!= cmd
will work.  As a side effect, VAR++=value now triggers an error
(two + in assignment).
- this stuff doesn't occur in portable Makefiles.
- writing VAR++ = value or VAR+ +=value  disambiguates it.
- this is a good thing, it uncovered a bug in bsd.port.mk.

Tested by naddy@. Okayed millert@. I'll handle the fallback if there is
any. This went through a full make build anyways, including isakmpd
(without mickey's custom binutils, as he didn't see fit to share it with me).

Revision 1.36 / (download) - annotate - [select for diffs], Thu May 3 13:41:02 2001 UTC (23 years ago) by espie
Branch: MAIN
Changes since 1.35: +193 -279 lines
Diff to previous 1.35 (colored)

Synch with my current work.
Numerous changes:
- generate can build several tables
- style cleanup
- statistics code
- use variable names throughout (struct Name)
- recursive variables everywhere
- faster parser (pass buffer along instead of allocating multiple copies)
- correct parser. Handles comments everywhere, and ; correctly
- more string intervals
- simplified dir.c, less recursion.
- extended for loops
- sinclude()
- finished removing extra junk from Lst_*
- handles ${@D} and friends in a simpler way
- cleaned up and modular VarModifiers handling.
- recognizes some gnu Makefile usages and errors out about them.

Additionally, some extra functionality is defined by FEATURES. The set of
functionalities is currently hardcoded to OpenBSD defaults, but this may
include support for some NetBSD extensions, like ODE modifiers.

Backed by miod@ and millert@, who finally got sick of my endless patches...

Revision 1.35 / (download) - annotate - [select for diffs], Thu Sep 14 13:52:41 2000 UTC (23 years, 8 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_2_9_BASE, OPENBSD_2_9, OPENBSD_2_8_BASE, OPENBSD_2_8
Changes since 1.34: +5 -6 lines
Diff to previous 1.34 (colored)

Introduce a few macros to handle timestamps in an abstract way.

Replace the time stamp hash in dir.c with an open hashing structure.

In doing so, remove some nasty casts, simplify code a bit:
Dir_MTime can return a modification time, since make does not make
a distinction between out-of-date and non-existent files.

Revision 1.34 / (download) - annotate - [select for diffs], Thu Sep 14 13:46:44 2000 UTC (23 years, 8 months ago) by espie
Branch: MAIN
Changes since 1.33: +4 -3 lines
Diff to previous 1.33 (colored)

Replace the old hash used to hold file names within a directory with
open hashing.

An interesting optimization is that the open hashing interface is more
fine-grained, hence we can compute the correct hash value at the start
of Dir_FindFile, and reuse it for each hash structure into which we look
(the effect is measurable on large directories along with objdir/VPATH).

Remove a few unnecessary Lst_Open/Lst_Close that serve no purpose except
obfuscating the code.

The interface to dir.h changes slightly, hence tedious includes changes...

Revision 1.33 / (download) - annotate - [select for diffs], Thu Sep 14 13:32:06 2000 UTC (23 years, 8 months ago) by espie
Branch: MAIN
Changes since 1.32: +10 -9 lines
Diff to previous 1.32 (colored)

Some systematic clean-up.
- UNUSED macro that expands to __attribute__((unused)) for gcc
- move rcsid around so that they can be tagged UNUSED.
- activate -Wunused.
- use UNUSED instead of kludgy junk for function arguments.
- add extern to all extern prototypes.
- update comments in lst.h.
- clean up var.c a little bit, constifying arguments, updating comments...

Revision 1.32 / (download) - annotate - [select for diffs], Fri Jun 30 23:26:25 2000 UTC (23 years, 10 months ago) by espie
Branch: MAIN
Changes since 1.31: +13 -9 lines
Diff to previous 1.31 (colored)

Recognize `+cmd' as a command that should always be executed, even in
make -n mode.

Currently works only in sequential make mode. In parallel make mode,
it's just a no-op.

Useful to debug recursive Makefiles, and part of POSIX.

Revision 1.31 / (download) - annotate - [select for diffs], Fri Jun 23 16:21:43 2000 UTC (23 years, 11 months ago) by espie
Branch: MAIN
Changes since 1.30: +4 -4 lines
Diff to previous 1.30 (colored)

In various places, VAR_CMD is used to actually mean `no real context',
since lookup will start with VAR_CMD in any case.
This fixes VarFind and Var_Parse to handle ctxt == NULL correctly, and
replace those confusing VAR_CMD with proper NULL pointers.

This patch also handles three small details:
- .CURDIR is necessarily set in VAR_GLOBAL,
- suffix handling for archives copies two hard-coded variables, for
which it can use a quick path,
- typos in TargFreeGN.

Reviewed millert@, miod@.

Revision 1.30 / (download) - annotate - [select for diffs], Fri Jun 23 16:20:01 2000 UTC (23 years, 11 months ago) by espie
Branch: MAIN
Changes since 1.29: +5 -5 lines
Diff to previous 1.29 (colored)

Once those special variable are taken care of, other Var functions can take
the GNode's context directly.  We rename that special Lst to `SymTable *'
in prevision of things to come.

Along the line, we lose the special GNodes affected to VAR_CMD, VAR_GLOBAL,
VAR_ENV, which become simple Lsts... This is not a problem, except when
getting to a context's name for debugging (handled very nicely by
offsetof).

Again, this is a preparatory patch, which does not gain anything except
for cleaning up issues...

Reviewed by millert@ and miod@, like the previous patch

Revision 1.29 / (download) - annotate - [select for diffs], Fri Jun 23 16:18:08 2000 UTC (23 years, 11 months ago) by espie
Branch: MAIN
Changes since 1.28: +6 -7 lines
Diff to previous 1.28 (colored)

Start of variable fixes and speed-ups.

This patch may seem a bit non-sensical at first. It simply introduces some
new interface. Specifically, recognizes that some variable names
(.TARGET/$@, .OODATE/$?, .ALLSRC/$>, .IMPSRC/$<, .PREFIX/$*, .ARCHIVE/$!,
.MEMBER/$%) are `special' (the actual variables which are local to a
target, e.g. GNode).

Currently, The Varq functions (for Varquick access) are only stubs to the
normal functions.

This fixes a very important detail before proceeding to turn variable lists
into hash tables: if every GNode holds a hash table, initialization times
for those will be very costly. But generic GNodes only hold those seven
special variables... which can be stored directly into a small array;
the only general cases are the environment, the command line and
global variables.

Revision 1.28 / (download) - annotate - [select for diffs], Sat Jun 17 14:38:14 2000 UTC (23 years, 11 months ago) by espie
Branch: MAIN
Changes since 1.27: +12 -12 lines
Diff to previous 1.27 (colored)

This patch introduces a distinction between
Lst_Init (constructor) and Lst_New (allocation + construction)
Lst_Destroy (destructor) and Lst_Delete (deallocation + destruction),
and uses that to turn most dynamic allocation of lists (Lst pointers)
into static structures (LIST).

Most of this is mundane, except for allGNs in targ.c, where the code must
be checked to verify that Targ_Init is called soon enough.

Lst_New is a temporary addition. All lists will soon be static.

Reviewed by millert@, like the previous patch.

Revision 1.27 / (download) - annotate - [select for diffs], Sat Jun 10 01:41:05 2000 UTC (23 years, 11 months ago) by espie
Branch: MAIN
Changes since 1.26: +8 -8 lines
Diff to previous 1.26 (colored)

Clean-up patch: use `void *' instead of old-fashioned ClientData/Address.

Revision 1.26 / (download) - annotate - [select for diffs], Sat Jun 10 01:32:22 2000 UTC (23 years, 11 months ago) by espie
Branch: MAIN
Changes since 1.25: +8 -13 lines
Diff to previous 1.25 (colored)

Thus, Lst_ForEach no longer needs returning a status.
In fact, it can become a macro based on Lst_ForEachFrom.
This also introduces Lst_Every, as a shortcut for the very common case where
Lst_ForEach does not need any user data.

Finally,  make consistent use of a few function typedefs, instead of having
explicit void (*)(Lst)  arguments all over the place.

Revision 1.25 / (download) - annotate - [select for diffs], Sat Jun 10 01:26:36 2000 UTC (23 years, 11 months ago) by espie
Branch: MAIN
Changes since 1.24: +14 -15 lines
Diff to previous 1.24 (colored)

Lst_Find and Lst_ForEach do the same thing, except that the comparison
sense is reversed (Lst_Find  returns when proc says 0, whereas Lst_ForEach
goes on while proc says 0).

This patch turns a number of Lst_ForEach into Lst_Find.
Specifically, all Lst_ForEach that actually may return quickly as proc
does not always returns zero.

Of course, the corresponding proc need to be tweaked to swap 0 and 1...

Revision 1.24 / (download) - annotate - [select for diffs], Mon Apr 17 23:54:47 2000 UTC (24 years, 1 month ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_2_7_BASE, OPENBSD_2_7
Changes since 1.23: +9 -3 lines
Diff to previous 1.23 (colored)

Record location in target node as well.
Indicate what went wrong for commands like
	@exit 1

Revision 1.23 / (download) - annotate - [select for diffs], Sun Mar 26 16:21:32 2000 UTC (24 years, 1 month ago) by espie
Branch: MAIN
Changes since 1.22: +11 -11 lines
Diff to previous 1.22 (colored)

Remove idiotic, braindead casts T* -> void*
They serve no purpose, except hiding potential bugs.

In particular, remove (ClientData) cast from macro, showing potentially
troublesome use of Hashes to store time_t.

Revision 1.22 / (download) - annotate - [select for diffs], Wed Feb 2 13:47:47 2000 UTC (24 years, 3 months ago) by espie
Branch: MAIN
Changes since 1.21: +3 -3 lines
Diff to previous 1.21 (colored)

Bug-fix: make should behave sensibly when presented with negative times...

- let *_MTime return booleans, as that's what they're used for, the time_t
is set as a side effect.

- use OUT_OF_DATE for a date starting point, set it at the origin of time.

Revision 1.21 / (download) - annotate - [select for diffs], Tue Feb 1 03:23:32 2000 UTC (24 years, 3 months ago) by deraadt
Branch: MAIN
Changes since 1.20: +2 -3 lines
Diff to previous 1.20 (colored)

no need to extern int errno if errno.h is included

Revision 1.20 / (download) - annotate - [select for diffs], Sat Dec 18 21:58:07 1999 UTC (24 years, 5 months ago) by espie
Branch: MAIN
Changes since 1.19: +4 -4 lines
Diff to previous 1.19 (colored)

Nothing ever checks ReturnStatus on Lst_Insert, Lst_Append, Lst_AtFront,
Lst_AtEnd, Lst_Concat, Lst_Remove, Lst_Replace.

Don't bother returning one.

Revision 1.19 / (download) - annotate - [select for diffs], Sat Dec 18 21:56:07 1999 UTC (24 years, 5 months ago) by espie
Branch: MAIN
Changes since 1.18: +3 -4 lines
Diff to previous 1.18 (colored)

Lst_DeQueue already checks for empty lists.

Revision 1.18 / (download) - annotate - [select for diffs], Sat Dec 18 21:53:32 1999 UTC (24 years, 5 months ago) by espie
Branch: MAIN
Changes since 1.17: +9 -9 lines
Diff to previous 1.17 (colored)

NIL, NILGNODE, etc, are only glorified NULL.
Get rid of them.

Get rid of list.h, nothing uses it anyway.

Revision 1.17 / (download) - annotate - [select for diffs], Thu Dec 16 17:31:51 1999 UTC (24 years, 5 months ago) by espie
Branch: MAIN
Changes since 1.16: +6 -4 lines
Diff to previous 1.16 (colored)

Bugfix: execvp might fail for many reasons.
Perform an explicit ENOENT check to keep the same error message
for known cases.

Revision 1.16 / (download) - annotate - [select for diffs], Thu Dec 16 17:27:18 1999 UTC (24 years, 5 months ago) by espie
Branch: MAIN
Changes since 1.15: +3 -3 lines
Diff to previous 1.15 (colored)

Var_Subst is actually two distinct functions folded into one:
split the function specific to for.c out, and give them more sensible
arguments at the same time.

This makes .for loop handling more efficient, as we have some heuristic
to evaluate the size of the buffer needed...

Revision 1.15 / (download) - annotate - [select for diffs], Mon Dec 6 22:28:44 1999 UTC (24 years, 5 months ago) by espie
Branch: MAIN
Changes since 1.14: +7 -17 lines
Diff to previous 1.14 (colored)

Extra parameter no longer needed, ditch.

Revision 1.14 / (download) - annotate - [select for diffs], Sun Nov 14 18:16:22 1999 UTC (24 years, 6 months ago) by espie
Branch: MAIN
Changes since 1.13: +5 -2 lines
Diff to previous 1.13 (colored)

Fix erroneous free of static storage.
Problem reported by fgsch@.

Revision 1.13 / (download) - annotate - [select for diffs], Wed Nov 10 14:11:49 1999 UTC (24 years, 6 months ago) by espie
Branch: MAIN
Changes since 1.12: +3 -2 lines
Diff to previous 1.12 (colored)

Turn on strict-prototypes, add missing prototypes.
Move main prototype to main.c, as this is not used
from any other file.

Close open bug.

Revision 1.12 / (download) - annotate - [select for diffs], Sat Dec 5 00:06:27 1998 UTC (25 years, 5 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_2_6_BASE, OPENBSD_2_6, OPENBSD_2_5_BASE, OPENBSD_2_5
Changes since 1.11: +52 -53 lines
Diff to previous 1.11 (colored)

Modifications from netbsd:
- don't interfere with MACHINE/MACHINE_ARCH defines for bootstrap
- type clean-up, time_t, and printing `unknown' ints
- fix TARGET/MEMBER bug in archive rules
- memmove...
- cleaner Error handler.
- reentrant brk_string
- .MAKE env variable
- preliminary scaffolding for .NOPATH

Other improvements:
- efree
- shellneed streamlined
- display Stop in .CURDIR after an error.
- document most features and misfeatures.
- add a few OpenBSD notes to the tutorial.

Revision 1.11 / (download) - annotate - [select for diffs], Wed May 13 06:54:58 1998 UTC (26 years ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_4_BASE, OPENBSD_2_4
Changes since 1.10: +14 -5 lines
Diff to previous 1.10 (colored)

catch more commands that require a shell

Revision 1.10 / (download) - annotate - [select for diffs], Tue May 12 07:10:01 1998 UTC (26 years ago) by deraadt
Branch: MAIN
Changes since 1.9: +65 -2 lines
Diff to previous 1.9 (colored)

emulate umask inside make, so that the value gets propogated; also ensure
that "exit" gets passed to the shell and make does not attempt to execve()
it.  Other commands will probably come later..

Revision 1.9 / (download) - annotate - [select for diffs], Fri Jan 2 05:56:33 1998 UTC (26 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_3_BASE, OPENBSD_2_3
Changes since 1.8: +3 -3 lines
Diff to previous 1.8 (colored)

use _exit()

Revision 1.8 / (download) - annotate - [select for diffs], Mon Apr 28 01:52:36 1997 UTC (27 years ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_2_BASE, OPENBSD_2_2, OPENBSD_2_1_BASE, OPENBSD_2_1
Changes since 1.7: +6 -10 lines
Diff to previous 1.7 (colored)

Back out newer .USE code as it caused problems.  I've done a "make build"
without problems and the problem Theo saw before is gone.

Revision 1.7 / (download) - annotate - [select for diffs], Mon Apr 21 08:37:49 1997 UTC (27 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.6: +12 -3 lines
Diff to previous 1.6 (colored)

nope, breaks other things

Revision 1.6 / (download) - annotate - [select for diffs], Sun Apr 20 22:28:25 1997 UTC (27 years, 1 month ago) by millert
Branch: MAIN
Changes since 1.5: +5 -14 lines
Diff to previous 1.5 (colored)

Back out the following change since it introduces an ordering problem:
    in compat mode, expand .USE before evaluating the list of targets,
    instead of doing .USE expansions on demand, because they can cause
    tree restructuring.

Revision 1.5 / (download) - annotate - [select for diffs], Tue Apr 1 07:28:09 1997 UTC (27 years, 1 month ago) by millert
Branch: MAIN
Changes since 1.4: +16 -6 lines
Diff to previous 1.4 (colored)

Sync with NetBSD (mostly by christos initial substitution/regexp from Der Mouse)

- fix the variable substitution code in make [PR/2748]
      1. change s/a/b/ so that it substitutes the first occurance of the
         pattern on each word, not only the first word.
      2. add flag '1' to the variable substitution so that the substitutions
         get performed only once.

  ***THIS IS AN INCOMPATIBLE CHANGE!***

  Unfortunately there was no way to make things consistent without
  modifying the current behavior. Fortunately none of our Makefiles
  depended on this.

            OLD:

                VAR      = aa1 aa2 aa3 aa4

                S/a/b/   = ba1 aa2 aa3 aa4
                S/a/b/g  = bb1 bb2 bb3 bb4

            NEW:
                VAR      = aa1 aa2 aa3 aa4

                S/a/b/   = ba1 ba2 ba3 ba4
                S/a/b/1  = ba1 aa2 aa3 aa4
                S/a/b/g  = bb1 bb2 bb3 bb4
                S/a/b/1g = bb1 aa2 aa3 aa4
- add regexp variable substitution via 'C/foo/bar/' [PR/2752]
- add variable quoting via the ${VAR:Q} modifier. This is useful when running
  recursive invocations of make(1):

        make VAR=${VAR:Q}

  will always work... (This may prove useful in the kernel builds...) [PR/2981]
- BSD did not traditionally have <sys/cdefs.h>; use BSD4_4 instead and include
  <sys/param.h> to grab it.
- Don't compile the regex code if MAKE_BOOTSTRAP (from gwr)
- Use explicit .c.o rule in Makefile.boot so that the bootstrap process works.
- Use only integral types in procedure arguments. [buf.c buf.h]
- Include <stdlib.h> to get getenv() prototype on SVR4
- if __STDC__ -> ifdef __STDC__ to appease SVR4
- Define const and volatile for non __STDC__
- Implement snprintf() and vsnprintf() for non BSD4_4 systems.
- Make $MACHINE_ARCH settable from the environment.
- Fix .USE directive problems: (reported by cgd)
    1. ${.*} variables did not get expanded in dependencies.
    2. expanded ${.*} variables in .USE dependencies can cause tree
       restructuring; handle it.
    3. in compat mode, expand .USE before evaluating the list of targets,
       instead of doing .USE expansions on demand, because they can cause
       tree restructuring.
- Add a .MADE directive to indicated that the children of a target are
  up-to-date, even when they are not. This is to simulate our current
  make install behavior with proper dependencies.
- Fix problems in the RE substitution error handling.
- Locate all the children of a node marked as MADE.
- Do not compile-in ${MACHINE} (as per NetBSD PR#3386)
- Disable globbing for targets/dependencies when POSIX is defined.
- Fix globbing so that patterns that don't have a matching number of [] or {}
  don't get expanded. (before the [ case got expanded to nothing!) This is
  disabled.
- Make sure that the children of nodes that are marked .MADE, are marked
  UPTODATE and their timestamps are consistent.
- Don't disable wildcards completely; they are used by other Makefiles.

Revision 1.4 / (download) - annotate - [select for diffs], Sat Nov 30 21:08:51 1996 UTC (27 years, 5 months ago) by millert
Branch: MAIN
Changes since 1.3: +21 -17 lines
Diff to previous 1.3 (colored)

Sync with NetBSD:
- Merge in FreeBSD and Lite2 changes.
- Fix bug where a non-archive target with a .a suffix would always
  be considered to be out of date, since it does not have a TOC.
- Fix NetBSD PR #2930: declare missing variable.

Revision 1.3 / (download) - annotate - [select for diffs], Wed Jun 26 05:36:27 1996 UTC (27 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.2: +2 -1 lines
Diff to previous 1.2 (colored)

rcsid

Revision 1.2 / (download) - annotate - [select for diffs], Thu Dec 14 03:23:28 1995 UTC (28 years, 5 months ago) by deraadt
Branch: MAIN
Changes since 1.1: +8 -10 lines
Diff to previous 1.1 (colored)

from christos@netbsd:
Minor:
    - ${.PREFIX} should never contain a full pathname
    - Fixed gcc -Wall warnings
Major:
    - compatMake is now FALSE. This means that we are now running in
      full pmake mode:
          * rules on dependency lines can be executed in parallel and or
            out of sequence:

            foo: bar baz

            can fire the rule for baz before the rule for bar is fired.
            To enforce bar to be fired before baz, another rule needs to be
            added. [bar: baz]
          * adjacent shell commands in a target are now executed by a single
            invocation of the shell, not one invocation of the shell per line
      (compatMake can be turned off using the -B flag)
    - The -j flag now works... I.e. make -j 4 will fork up to four jobs in
      parallel when it can. The target name is printed before each burst
      of output caused by the target execution as '--- target ---', when j > 1
    - I have changed all the Makefiles so that they work with make -j N, and
      I have tested the whole netbsd by:
          'make -j 4 cleandir; make -j 4 depend; make -j 4; make -j 4 install'
    - I have not compiled or tested this version of make with -DREMOTE.
- Turn compat mode on by default. It gets turned off when the -j without
  the -B flag is specified. [Thus you can use -j 1 to turn it off].
- Fix malloc -> emalloc as Gordon noted.
Updates for POSIX/SVR4 compiling:
arch.c:          Don't require ranlib stuff. Not everybody has it.
dir.c:           SunOS-4 != Solaris; change #ifdef sun to #if sun && !__svr4__
job.c, compat.c: Don't use 'union wait', use int and the W*() macros.
main.c:          Check for uname() == -1; some unames return > 0...
util.c, job.c:   Add signal() with BSD semantics for svr4, don't use bsd
                 sigmask and friends.

from cgd@netbsd:
pull in make.h.  (PAlloc() now uses emalloc(), which is prototyped in
make.h.  If the prototype is not in scope on the Alpha, I see lots
of "cast to pointer from integer of different size" warnings.)

Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Wed Oct 18 08:45:41 1995 UTC (28 years, 7 months ago) by deraadt
CVS Tags: netbsd_1_1
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)

initial import of NetBSD tree

Revision 1.1 / (download) - annotate - [select for diffs], Wed Oct 18 08:45:41 1995 UTC (28 years, 7 months ago) by deraadt
Branch: MAIN

Initial revision

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.