![[BACK]](/icons/back.gif){kind=icon}
Up to [local] / src / usr.bin / make
Request diff between arbitrary revisions
Default branch: MAIN
Revision 1.39 / (download) - annotate - [select for diffs], Sun Jan 26 12:41:21 2020 UTC (4 years, 3 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE,
OPENBSD_7_5,
OPENBSD_7_4_BASE,
OPENBSD_7_4,
OPENBSD_7_3_BASE,
OPENBSD_7_3,
OPENBSD_7_2_BASE,
OPENBSD_7_2,
OPENBSD_7_1_BASE,
OPENBSD_7_1,
OPENBSD_7_0_BASE,
OPENBSD_7_0,
OPENBSD_6_9_BASE,
OPENBSD_6_9,
OPENBSD_6_8_BASE,
OPENBSD_6_8,
OPENBSD_6_7_BASE,
OPENBSD_6_7,
HEAD
Changes since 1.38: +4 -11 lines
Diff to previous 1.38 (colored)
remove OP_* for deprecated keywords (document that :: still uses OP_INVISIBLE) okay millert@
Revision 1.38 / (download) - annotate - [select for diffs], Sun Jan 26 12:37:47 2020 UTC (4 years, 3 months ago) by espie
Branch: MAIN
Changes since 1.37: +3 -1 lines
Diff to previous 1.37 (colored)
deprecate old keywords, some already removed, some now hitting the bitbucket. okay on principle from millert@/schwarze@ The rationale is that those aren't even documented (apart from .MADE) and the corresponding code has never been maintained (just untouched when changing other things, so it probably doesn't work right if it ever did) This went through a full release/bulk to make sure nobody was using that stuff. okay millert@
Revision 1.37 / (download) - annotate - [select for diffs], Mon Jan 13 14:07:35 2020 UTC (4 years, 4 months ago) by espie
Branch: MAIN
Changes since 1.36: +2 -8 lines
Diff to previous 1.36 (colored)
concept borrowed from netbsd: turns out SPECIAL_SOURCE/TARGET is no longer needed, because if we're special it's a target, if we have special_op, it's a source. There's just SPECIAL_WAIT which requires funny handling anyhow
Revision 1.36 / (download) - annotate - [select for diffs], Mon Jan 13 13:59:24 2020 UTC (4 years, 4 months ago) by espie
Branch: MAIN
Changes since 1.35: +4 -2 lines
Diff to previous 1.35 (colored)
a lot of special keywors (.INCLUDE/.LIBRARIES) were removed a few releases ago. Document what's actually going on with special keywords (mostly .PATH has special semantics) and document that SPECIAL_NOTHING corresponds to ignoring former keywords.
Revision 1.35 / (download) - annotate - [select for diffs], Mon Jan 13 13:48:20 2020 UTC (4 years, 4 months ago) by espie
Branch: MAIN
Changes since 1.34: +14 -8 lines
Diff to previous 1.34 (colored)
document special values. unconfuse type/special field (first commit of a large patch that was ok'd tb@, millert@)
Revision 1.34 / (download) - annotate - [select for diffs], Sun Dec 22 16:53:40 2019 UTC (4 years, 4 months ago) by espie
Branch: MAIN
Changes since 1.33: +4 -3 lines
Diff to previous 1.33 (colored)
- give a specific value to OP_ERROR that doesn't occur in nature - define OP_ZERO as zero, to make some function calls obvious - split ParseDoOp into two functions: ParseDoOp that only deals with : :: ! and ParseDoSpecial that only deals with special nodes. This simplifies both functions accordingly - always initialize special_op okay millert@
Revision 1.33 / (download) - annotate - [select for diffs], Sat Dec 21 15:31:54 2019 UTC (4 years, 4 months ago) by espie
Branch: MAIN
Changes since 1.32: +40 -37 lines
Diff to previous 1.32 (colored)
yet another mostly cosmetic diff - rename context into localvars, which is more meaningful and less generic - instantiate the random rumbling at the start of gnode.h with actual variable names - explain and group gnode.h variables better - make some comments terser/more meaningful okay millert@
Revision 1.32 / (download) - annotate - [select for diffs], Sat Dec 21 15:29:59 2019 UTC (4 years, 4 months ago) by espie
Branch: MAIN
Changes since 1.31: +3 -3 lines
Diff to previous 1.31 (colored)
those fields only hold true/false value make it obvious okay millert@
Revision 1.31 / (download) - annotate - [select for diffs], Sat Dec 21 15:29:25 2019 UTC (4 years, 4 months ago) by espie
Branch: MAIN
Changes since 1.30: +32 -40 lines
Diff to previous 1.30 (colored)
rename a few variable/functions to have better names. adjust comments to be more meaningful reorder predecessors/successors fields in an order that makes more sense to me. okay millert@
Revision 1.30 / (download) - annotate - [select for diffs], Sat Dec 21 15:28:17 2019 UTC (4 years, 4 months ago) by espie
Branch: MAIN
Changes since 1.29: +8 -12 lines
Diff to previous 1.29 (colored)
rename built_status constants to be less quirky fold back BEINGMADE and BUILDING which mean the same thing GC CYCLE/ENDCYCLE okay millert@
Revision 1.29 / (download) - annotate - [select for diffs], Thu Jun 22 17:08:20 2017 UTC (6 years, 10 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_6_6_BASE,
OPENBSD_6_6,
OPENBSD_6_5_BASE,
OPENBSD_6_5,
OPENBSD_6_4_BASE,
OPENBSD_6_4,
OPENBSD_6_3_BASE,
OPENBSD_6_3,
OPENBSD_6_2_BASE,
OPENBSD_6_2
Changes since 1.28: +2 -8 lines
Diff to previous 1.28 (colored)
better display of cycles in -j mode. lots of tests by krw@ review and comments by pirofti@, more tweaks to come
Revision 1.28 / (download) - annotate - [select for diffs], Thu May 30 08:58:38 2013 UTC (10 years, 11 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_6_1_BASE,
OPENBSD_6_1,
OPENBSD_6_0_BASE,
OPENBSD_6_0,
OPENBSD_5_9_BASE,
OPENBSD_5_9,
OPENBSD_5_8_BASE,
OPENBSD_5_8,
OPENBSD_5_7_BASE,
OPENBSD_5_7,
OPENBSD_5_6_BASE,
OPENBSD_5_6,
OPENBSD_5_5_BASE,
OPENBSD_5_5,
OPENBSD_5_4_BASE,
OPENBSD_5_4
Changes since 1.27: +1 -3 lines
Diff to previous 1.27 (colored)
remove cmtime again, but with a proper test for nodes without children. problem seen by aja, make pointed by matthieu, sleuthing by me, okay by millert (and you say OpenBSD developers don't work together)
Revision 1.27 / (download) - annotate - [select for diffs], Sat May 25 11:54:14 2013 UTC (10 years, 11 months ago) by espie
Branch: MAIN
Changes since 1.26: +3 -1 lines
Diff to previous 1.26 (colored)
obviously missed something, so revert. (noticed by sthen@/matthieu@)
Revision 1.26 / (download) - annotate - [select for diffs], Wed May 22 12:14:08 2013 UTC (10 years, 11 months ago) by espie
Branch: MAIN
Changes since 1.25: +3 -4 lines
Diff to previous 1.25 (colored)
as checked through thorough tests, youngest->mtime == ctime, so ditch the extra field. remove some extra abstraction layer: use clock_gettime directly instead of ts_set_from_now (what is "now" anyways) time_to_string takes param by pointer rename "now" into starttime (more accurate term) randomize queue uses arc4random_uniform (prompted by deraadt@) display debug timestamp with ns too (it's debug, so it doesn't really matter whichever way it's done, as long as it's done) okay millert@
Revision 1.25 / (download) - annotate - [select for diffs], Tue May 14 18:47:40 2013 UTC (11 years ago) by espie
Branch: MAIN
Changes since 1.24: +2 -1 lines
Diff to previous 1.24 (colored)
keep track of the youngest child, helps a lot with out-of-date messages in -dm mode. okay millert@
Revision 1.24 / (download) - annotate - [select for diffs], Tue Apr 23 14:32:53 2013 UTC (11 years ago) by espie
Branch: MAIN
Changes since 1.23: +5 -7 lines
Diff to previous 1.23 (colored)
remove TIMESTAMP abstraction layer, prodded by theo. while there, clean up includes. use strtoll for ar timestamps (pretty much unused in reality, more standard conforming than anything) use idea from Todd to adapt to time_t being 32 bits OR 64 bits (pedantically correct: INT_MIN would work just fine up to 1910 or so...) okay millert@, gone thru a make build.
Revision 1.23 / (download) - annotate - [select for diffs], Tue Oct 9 19:45:34 2012 UTC (11 years, 7 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_5_3_BASE,
OPENBSD_5_3
Changes since 1.22: +9 -8 lines
Diff to previous 1.22 (colored)
- SPECIAL_DEPRECATED -> SPECIAL_NOTHING - nodes for .POSIX and .SCCS_GET (which don't do anything) - zap remaining suffix crud. new scaffolding: - groupling list and HELDBACK state to avoid races in engine. - parser recognizes lists of targets that shoul be grouped together - OP_DOUBLE to mark nodes that have multiple lists of commands
Revision 1.22 / (download) - annotate - [select for diffs], Sat Oct 6 09:32:40 2012 UTC (11 years, 7 months ago) by espie
Branch: MAIN
Changes since 1.21: +1 -2 lines
Diff to previous 1.21 (colored)
- extra juice for debugging signal passing. Note when we can't pass the signal because the process already bought it (pgroups will do that to you) (lots of discussion with Todd on that one) - tweak error handling some more to make it less verbose when just one job is running... - show signal name in case of signal interrupts. - zap OP_LIB, move that stuff to the location where we warn when we meet that bug. okay millert@
Revision 1.21 / (download) - annotate - [select for diffs], Tue Oct 2 10:29:30 2012 UTC (11 years, 7 months ago) by espie
Branch: MAIN
Changes since 1.20: +29 -2 lines
Diff to previous 1.20 (colored)
more changes, discussed and tested by various people. - put back some job control, turns out it's necessary when we don't run a shell. - zap old #ifdef CLEANUP code... probably doesn't even compile. - kill most of the OP_LIB code. Just keep a wee little bit for compatibility (deprecated .LIBS and .INCLUDES, warns for weird dependencies instead of erroring out). - much improved debugging and -p output: sort variables, targets, rules, output stuff in a nicer format mimicing input. - better error message when no command is found, explain where the target comes from. - sort final error list by file. - show system files in errors as <bsd.prog.mk> - reincorporate random delay, that was dropped - optimize siginfo output by not regenerating the whole string each time. - finish zapping old LocationInfo field that's no longer used.
Revision 1.20 / (download) - annotate - [select for diffs], Fri Sep 21 07:55:20 2012 UTC (11 years, 7 months ago) by espie
Branch: MAIN
Changes since 1.19: +7 -2 lines
Diff to previous 1.19 (colored)
major overhaul of the way make handle jobs, inspired by dpb: instead of forking a "job" per target, and having that job further fork separate commands, have make maintain a list of jobs, indexed by pid of currently running commands, and handle process termination continuation-style. This has lots of benefits: - make is responsible for most printing, so we no longer need pipes nor job control: make -j jobs see the tty. - no more special-casing for jobs that don't really execute anything. - unify code for make -jn and make -B, including signal handlers and job waiting. So make -n, make -q, +cmd now run commands in the same way in all cases. - unified more accurate error-reporting, as make knows precisely which command failed. Commands are tagged with their lines, and we display failing commands in silent mode. - fine-grained "expensive" command handling (recursion limiter). Do it per-command instead of per-target. Moreover, signal response is now simpler, as we just block the signals in a small critical sections, test for events, and sigpause (thanks a lot to guenther@ and millert@), so running make is now almost always paused without any busy-waiting. Thanks to everyone who tested and gave input.
Revision 1.19 / (download) - annotate - [select for diffs], Wed Apr 11 18:27:30 2012 UTC (12 years, 1 month ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_5_2_BASE,
OPENBSD_5_2
Changes since 1.18: +3 -1 lines
Diff to previous 1.18 (colored)
make has had heuristics to avoid parallel make recursion. Sometimes they mess up, so add .CHEAP/.EXPENSIVE to explicitly tell make 'hey this is not THAT bad' or 'worse than you think'. agreed by guenther@, millert@ (and some tweaks)
Revision 1.18 / (download) - annotate - [select for diffs], Thu Mar 22 13:47:12 2012 UTC (12 years, 1 month ago) by espie
Branch: MAIN
Changes since 1.17: +5 -3 lines
Diff to previous 1.17 (colored)
minor cleanup: error messages include lineno and fileno together, so recognize that and create a struct Location_ for it. mostly from Jonathan Calmels, a few nits from me. okay otto@
Revision 1.17 / (download) - annotate - [select for diffs], Mon Jul 19 19:46:44 2010 UTC (13 years, 10 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_5_1_BASE,
OPENBSD_5_1,
OPENBSD_5_0_BASE,
OPENBSD_5_0,
OPENBSD_4_9_BASE,
OPENBSD_4_9,
OPENBSD_4_8_BASE,
OPENBSD_4_8
Changes since 1.16: +1 -2 lines
Diff to previous 1.16 (colored)
Correct $OpenBSD$ stuff
Revision 1.16 / (download) - annotate - [select for diffs], Mon Jul 19 19:30:37 2010 UTC (13 years, 10 months ago) by espie
Branch: MAIN
Changes since 1.15: +0 -0 lines
Diff to previous 1.15 (colored)
two small changes:
- allow variables in SysV modifiers, as requested by matthieu@
(since recursive variables are an extension, this just extends the
extension)
- variation on :Q called :QL (quote list), which does quote every character
EXCEPT for whitespace. e.g.,
toto:
@for i in ${VAR:QL} ...
Revision 1.15 / (download) - annotate - [select for diffs], Sun Aug 16 09:51:12 2009 UTC (14 years, 9 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_4_7_BASE,
OPENBSD_4_7
Changes since 1.14: +8 -8 lines
Diff to previous 1.14 (colored)
use unsigned values where applicable
Revision 1.14 / (download) - annotate - [select for diffs], Tue Nov 4 07:22:35 2008 UTC (15 years, 6 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE,
OPENBSD_4_6,
OPENBSD_4_5_BASE,
OPENBSD_4_5
Changes since 1.13: +24 -15 lines
Diff to previous 1.13 (colored)
changes to get target equivalence to work better. - add new file to create lists of equivalent targets (siblings) - use that for sequential mode to have much better VPATH support - separate checking commands from reporting error, for later. - zap DieHorribly accordingly - renumber existing flags - signal_running_jobs() is simpler than pass_signal_to_jobs() - new debug option -dn for name matching. Similar code to handle parallel make is still missing. thanks to Mark, Miod, Theo, Otto, Todd for tests and/or comments.
Revision 1.13 / (download) - annotate - [select for diffs], Tue Jan 29 22:23:10 2008 UTC (16 years, 3 months ago) by espie
Branch: MAIN
CVS Tags: OPENBSD_4_4_BASE,
OPENBSD_4_4,
OPENBSD_4_3_BASE,
OPENBSD_4_3
Changes since 1.12: +1 -0 lines
Diff to previous 1.12 (colored)
A few changes: - expand commands earlier, so that we can eventually scan them to take smarter decisions. - clean up the select() mask code and rename variables to sensible things. - quite a few minor renames for readability - erecalloc - clean up wait status handling, do not try to rebuild wait status, but instead parse it early and deal with the parsed code. tested by lots of people, thanks guys!
Revision 1.12 / (download) - annotate - [select for diffs], Mon Dec 10 17:44:06 2007 UTC (16 years, 5 months ago) by espie
Branch: MAIN
Changes since 1.11: +0 -2 lines
Diff to previous 1.11 (colored)
zap field nothing uses.
Revision 1.11 / (download) - annotate - [select for diffs], Sat Nov 24 15:41:01 2007 UTC (16 years, 5 months ago) by espie
Branch: MAIN
Changes since 1.10: +1 -0 lines
Diff to previous 1.10 (colored)
more parallel make fixes. Preparations to fix the engine: - new function has_been_built(gn), that tells you what's the status of a given node. Allows us to run Suff_FindDeps later, by updating the number of unmade children correctly. - take out the code that handles shell expansions in an expand_children* set of functions, called by Suff_FindDeps, among others. These must be called early in the engine to avoid creating bogus nodes. Engine fixes: - take the predecessor/successor special handling out, deal with it in separate functions. - don't count nodes. Explicitly track them all in a hash table (better way to deal with non-built issues). - don't run Suff_FindDeps at start, but just before building an actual node. This allows make to find all dependencies correctly, as in groff. Pfiou! now it works.
Revision 1.10 / (download) - annotate - [select for diffs], Sat Nov 10 13:59:48 2007 UTC (16 years, 6 months ago) by espie
Branch: MAIN
Changes since 1.9: +4 -6 lines
Diff to previous 1.9 (colored)
UNMADE -> UNKNOWN
Revision 1.9 / (download) - annotate - [select for diffs], Sat Nov 10 12:51:40 2007 UTC (16 years, 6 months ago) by espie
Branch: MAIN
Changes since 1.8: +3 -3 lines
Diff to previous 1.8 (colored)
rename make -> must_make, made -> built_status to make them easier to find in source files.
Revision 1.8 / (download) - annotate - [select for diffs], Tue Nov 6 21:12:23 2007 UTC (16 years, 6 months ago) by espie
Branch: MAIN
Changes since 1.7: +1 -2 lines
Diff to previous 1.7 (colored)
simplify the way we deal with implicit rules and handle $<. Having an `iParents' field is actually backwards, it's ways simpler to store the pointer in the child, as an impliedsrc, and to set the variable just in time along with all the rest in DoAllVar. This is simpler, and it should allow us to call SuffFindDeps much later.
Revision 1.7 / (download) - annotate - [select for diffs], Fri Nov 2 17:27:24 2007 UTC (16 years, 6 months ago) by espie
Branch: MAIN
Changes since 1.6: +1 -1 lines
Diff to previous 1.6 (colored)
Work done at p2k7. This is a really big step towards getting parallel make to work. Note that this is not yet complete. There are still a few `details' to fix before this works 100%. Specifically: sequential make (compat) and parallel make don't use the same engine, and the parallel engine still has a few limitations. For instance, some known issues: - parallel make does not deal with .phony targets correctly all the time. - some errors are deadly in parallel make mode. - parallel make NEEDS way more sturdy correspondance of file system paths and target names, since it often needs to match dependencies to targets before the corresponding files exist. - some local variables like $* get set in a bogus way in some cases. - suffix handling has issues, especially related to the NULL suffix. So, if you find stuff that does NOT yet work with parallel make, don't go blindly try to fix the Makefile. It's very likely you might have stumbled into a make bug. (unless you really, really, understand Makefiles, DON'T GO CHANGING THEM YET). Tested by lots of people, thanks go to miod@, and robert@ among other people. Quick summary of what this does: - remove `saving commands' extension (it's not really usable, nor used) - move compat job runner and parallel interrupt handling into engine.c - tweak the code so that both compat and parallel mode use the same job runner and the same interrupt handling. Remove the other one. - optimize job runner so that, in parallel mode, the last command does not fork if we can avoid it (as it's already running in a sub shell). - scrape all the code that dealt with creating shell scripts from commands. - scrape all the code that dealt with recognizing special sequences in command output to print/not print output. - fix the parallel job pipe to not keep around file descriptors that are not needed. - replace the parallel job buffering with a nicer one, that deals with non-blocking descriptors to try to agregate as much output from one job in one go (greed) to unconfuse the users. - create two pipes per job, so that stdout and stderr stay separate. - make job token printing a debug option. - always use the parallel job-runner to `execute' commands, even if we just print them out. - store list of errors encountered during parallel make running, and print them on exit, so that we know what went wrong. - add a dirty hack to targ.c to deal with paths produced by gccmakedep.
Revision 1.6 / (download) - annotate - [select for diffs], Sun Sep 23 09:47:56 2007 UTC (16 years, 7 months ago) by espie
Branch: MAIN
Changes since 1.5: +2 -1 lines
Diff to previous 1.5 (colored)
put parsing of operator (:, ::, !) into its own function
Revision 1.5 / (download) - annotate - [select for diffs], Mon Sep 17 12:42:09 2007 UTC (16 years, 8 months ago) by espie
Branch: MAIN
Changes since 1.4: +77 -56 lines
Diff to previous 1.4 (colored)
rewrite of the basic suffix/target parsing: use hash for suffixes. Store special targets in target hash, and use them for the parsing. Use OP_DUMMY flag to mark targets that don't really exist yet, such as interrupt and default nodes. Also, .PATHxxx is special in suffixes. Small tweaks to compat.c, so that run_commands does more stuff after the fork() (and thus no need to free things). Remove distinction between local and global jobs.
Revision 1.4 / (download) - annotate - [select for diffs], Fri Nov 23 23:42:45 2001 UTC (22 years, 5 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_2_BASE,
OPENBSD_4_2,
OPENBSD_4_1_BASE,
OPENBSD_4_1,
OPENBSD_4_0_BASE,
OPENBSD_4_0,
OPENBSD_3_9_BASE,
OPENBSD_3_9,
OPENBSD_3_8_BASE,
OPENBSD_3_8,
OPENBSD_3_7_BASE,
OPENBSD_3_7,
OPENBSD_3_6_BASE,
OPENBSD_3_6,
OPENBSD_3_5_BASE,
OPENBSD_3_5,
OPENBSD_3_4_BASE,
OPENBSD_3_4,
OPENBSD_3_3_BASE,
OPENBSD_3_3,
OPENBSD_3_2_BASE,
OPENBSD_3_2,
OPENBSD_3_1_BASE,
OPENBSD_3_1
Changes since 1.3: +0 -1 lines
Diff to previous 1.3 (colored)
back out changes that break kernel compiles. good testing jobmk install!
Revision 1.3 / (download) - annotate - [select for diffs], Thu Nov 22 21:18:10 2001 UTC (22 years, 6 months ago) by espie
Branch: MAIN
Changes since 1.2: +2 -1 lines
Diff to previous 1.2 (colored)
Explicitly mark nodes whose commands have been filled with implicit (suffix) rules. Then, only expand the IMPSRC/< variable if the node has been marked. This matches what Single Unix 2 and common sense say: implicit rules shouldn't count when an explicit rule has been found (an explicit rule being a full-scale dependency, with some associated commands) Note that Single Unix leaves the `PREFIX' question open, so we leave the PREFIX code as it is. This fixes regression case mk14, which now fails as it should. This is just a bug-fix. Some more correct (and faster) code should probably be substituted. Namely, right now, the suffix code is too greedy, whereas it should test for explicit rules earlier, and not even bother instantiating implicit rules from templates when they duplicate actual existing rules. ok millert@
Revision 1.2 / (download) - annotate - [select for diffs], Wed Sep 19 10:58:07 2001 UTC (22 years, 8 months ago) by mpech
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE,
OPENBSD_3_0
Changes since 1.1: +2 -2 lines
Diff to previous 1.1 (colored)
occured->occurred idea from deraadt@ via NetBSD millert@ ok p.s. Next commit will fix a typo in the sys/
Revision 1.1 / (download) - annotate - [select for diffs], Wed May 23 12:34:43 2001 UTC (23 years ago) by espie
Branch: MAIN
Mostly clean-up: - cut up those huge include files into separate interfaces for all modules. Put the interface documentation there, and not with the implementation. - light-weight includes for needed concrete types (lst_t.h, timestamp_t.h). - cut out some more logically separate parts: cmd_exec, varname, parsevar, timestamp. - put all error handling functions together, so that we will be able to clean them up. - more systematic naming: functioni to handle interval, function to handle string. - put the init/end code apart to minimize coupling. - kill weird types like ReturnStatus and Boolean. Use standard bool (with a fallback for non-iso systems) - better interface documentation for lots of subsystems. As a result, make compilation goes somewhat faster (5%, even considering the largish BSD copyrights to read). The corresponding preprocessed source goes down from 1,5M to 1M. A few minor code changes as well: Parse_DoVar is no longer destructive. Parse_IsVar functionality is folded into Parse_DoVar (as it knows what an assignment is), a few more interval handling functions. Avoid calling XXX_End when they do nothing, just #define XXX_End to nothing. Parse_DoVar is slightly more general: it will handle compound assignments as long as they make sense, e.g., VAR +!= cmd will work. As a side effect, VAR++=value now triggers an error (two + in assignment). - this stuff doesn't occur in portable Makefiles. - writing VAR++ = value or VAR+ +=value disambiguates it. - this is a good thing, it uncovered a bug in bsd.port.mk. Tested by naddy@. Okayed millert@. I'll handle the fallback if there is any. This went through a full make build anyways, including isakmpd (without mickey's custom binutils, as he didn't see fit to share it with me).