OpenBSD CVS

CVS log for src/usr.bin/mg/tags.c


[BACK] Up to [local] / src / usr.bin / mg

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.27 / (download) - annotate - [select for diffs], Wed Mar 29 19:09:04 2023 UTC (13 months, 3 weeks ago) by op
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, HEAD
Changes since 1.26: +5 -2 lines
Diff to previous 1.26 (colored)

plug leak of tagpos in poptag() if loadbuffer() fails

Revision 1.26 / (download) - annotate - [select for diffs], Wed Mar 29 10:42:34 2023 UTC (13 months, 3 weeks ago) by op
Branch: MAIN
Changes since 1.25: +7 -34 lines
Diff to previous 1.25 (colored)

drop needless global tagsfn path

mg kept the path to the last loaded tag file in tagsfn which was used
for both the lazy loading (now removed) and as a flag to know if any
tags are currently loaded.  It's redundant and complicates the code:
just check if the tree is empty instead.

ok tb@

Revision 1.25 / (download) - annotate - [select for diffs], Wed Mar 29 07:29:17 2023 UTC (13 months, 3 weeks ago) by op
Branch: MAIN
Changes since 1.24: +23 -29 lines
Diff to previous 1.24 (colored)

change tagvisit (aka visit-tag-table) to immediately load the tag file

before it used to only record the path to the tag file which was loaded
on demand upon find-tag (M-.).  tagvisit did to do a stat + access dance
to know if the path was pointing to a regular, readable file and
loadtags (called lazily by find-tag) trusted those checks...

Instead, just load the tags in tagvisit and drop the lazy mechanics.

ok tb@

Revision 1.24 / (download) - annotate - [select for diffs], Tue Mar 28 21:33:21 2023 UTC (13 months, 3 weeks ago) by tb
Branch: MAIN
Changes since 1.23: +5 -3 lines
Diff to previous 1.23 (colored)

mg: fix parsing of tag files with duplicate entries

Instead of erroring out ignore duplicates. Fixes using /var/db/libc.tags
again.

ok op

Revision 1.23 / (download) - annotate - [select for diffs], Wed Mar 22 22:09:37 2023 UTC (13 months, 4 weeks ago) by op
Branch: MAIN
CVS Tags: OPENBSD_7_3_BASE, OPENBSD_7_3
Changes since 1.22: +3 -2 lines
Diff to previous 1.22 (colored)

plug another leak in addctag; found + ok tb@

Revision 1.22 / (download) - annotate - [select for diffs], Wed Mar 22 19:42:41 2023 UTC (13 months, 4 weeks ago) by op
Branch: MAIN
Changes since 1.21: +6 -5 lines
Diff to previous 1.21 (colored)

avoid memleak / crash in addctag

the l pointer is advanced, so if the line is malformed `goto cleanup'
will free(NULL) or a pointer inside l.

semplification and ok tb@

Revision 1.21 / (download) - annotate - [select for diffs], Wed Mar 22 18:18:35 2023 UTC (13 months, 4 weeks ago) by op
Branch: MAIN
Changes since 1.20: +3 -3 lines
Diff to previous 1.20 (colored)

plug memleak in error path

based on a diff by lux (lx [at] shellcodes [dot] org), thanks!
Diff via, tweak and ok tb@

Revision 1.20 / (download) - annotate - [select for diffs], Wed Mar 22 18:10:07 2023 UTC (13 months, 4 weeks ago) by op
Branch: MAIN
Changes since 1.19: +39 -39 lines
Diff to previous 1.19 (colored)

delete trailing whitespaces; no functional change

Revision 1.19 / (download) - annotate - [select for diffs], Wed Mar 8 04:43:11 2023 UTC (14 months, 1 week ago) by guenther
Branch: MAIN
Changes since 1.18: +1 -4 lines
Diff to previous 1.18 (colored)

Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

Revision 1.18 / (download) - annotate - [select for diffs], Mon Dec 26 19:16:02 2022 UTC (16 months, 3 weeks ago) by jmc
Branch: MAIN
Changes since 1.17: +2 -2 lines
Diff to previous 1.17 (colored)

spelling fixes; from paul tagliamonte
amendments to his diff are noted on tech

Revision 1.17 / (download) - annotate - [select for diffs], Fri Jan 28 06:18:41 2022 UTC (2 years, 3 months ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1
Changes since 1.16: +2 -2 lines
Diff to previous 1.16 (colored)

When it's the possessive of 'it', it's spelled "its", without the
apostrophe.

Revision 1.16 / (download) - annotate - [select for diffs], Sun Aug 6 04:39:45 2017 UTC (6 years, 9 months ago) by bcallah
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2
Changes since 1.15: +4 -4 lines
Diff to previous 1.15 (colored)

Present the default choice before the colon in prompts. Matches GNU Emacs
behavior.

From Scott Cheloha <scottcheloha@gmail.com>

ok florian@

Revision 1.15 / (download) - annotate - [select for diffs], Tue May 30 07:05:22 2017 UTC (6 years, 11 months ago) by florian
Branch: MAIN
Changes since 1.14: +4 -4 lines
Diff to previous 1.14 (colored)

fix -Wshadow warnings.
Found by bcallah, thanks!

Revision 1.14 / (download) - annotate - [select for diffs], Thu Sep 1 10:01:53 2016 UTC (7 years, 8 months ago) by sunil
Branch: MAIN
CVS Tags: OPENBSD_6_1_BASE, OPENBSD_6_1
Changes since 1.13: +4 -4 lines
Diff to previous 1.13 (colored)

Fix possible NULL pointer dereference.

Found by Coverity Scan.  The tagsvisit() function calls eread(),
which may return NULL.  This is then immediately passed to stat()
without a proper check.  This patch adds that check.

From Joachim Nilsson <troglobit@gmail.com> via lum@. Ok lum@

Revision 1.13 / (download) - annotate - [select for diffs], Tue Jan 19 11:39:06 2016 UTC (8 years, 4 months ago) by sunil
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.12: +2 -2 lines
Diff to previous 1.12 (colored)

Update my mail address.

Revision 1.12 / (download) - annotate - [select for diffs], Thu Dec 31 12:06:48 2015 UTC (8 years, 4 months ago) by sunil
Branch: MAIN
Changes since 1.11: +2 -2 lines
Diff to previous 1.11 (colored)

Return FALSE on parse errors.

Found by and Ok lum@.

Revision 1.11 / (download) - annotate - [select for diffs], Thu Mar 19 21:22:15 2015 UTC (9 years, 2 months ago) by bcallah
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8
Changes since 1.10: +5 -3 lines
Diff to previous 1.10 (colored)

Clean up the includes in mg.
This does the following:
Moves all POSIX headers from sysdef.h into the individual .c files so that
each file now only includes what it needs. All headers are properly sorted.
Moves the remainder of sysdef.h to other files (mostly def.h) and deletes
sysdef.h now that it's no longer contains anything.
Tweak a comment that references sysdef.h so that it no longer does that.
ok florian@

Revision 1.10 / (download) - annotate - [select for diffs], Sun Nov 16 00:59:25 2014 UTC (9 years, 6 months ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.9: +2 -2 lines
Diff to previous 1.9 (colored)

ctype macros/functions expect unsigned char values.  Note that the lgetc()
macro does the cast internally like getc() does, so its return should be
put an in int for the same reason.

based on a diff from Kamil Rytarowski (n54 (at) gmx.com)

Revision 1.9 / (download) - annotate - [select for diffs], Sat Mar 22 10:00:58 2014 UTC (10 years, 2 months ago) by lum
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6
Changes since 1.8: +7 -6 lines
Diff to previous 1.8 (colored)

If no default tag defined, still let user input a tag to find.
From Sunil Nimmagadda.

Revision 1.8 / (download) - annotate - [select for diffs], Thu Mar 20 07:47:29 2014 UTC (10 years, 2 months ago) by lum
Branch: MAIN
Changes since 1.7: +22 -5 lines
Diff to previous 1.7 (colored)

Add some missing dobeeps.
ok florian@

Revision 1.7 / (download) - annotate - [select for diffs], Thu Mar 6 14:51:48 2014 UTC (10 years, 2 months ago) by jasper
Branch: MAIN
Changes since 1.6: +2 -1 lines
Diff to previous 1.6 (colored)

add missing stdio.h include for fparseln().

from Ulrich Mueller, via Han Boetes
ok florian@

Revision 1.6 / (download) - annotate - [select for diffs], Sat Oct 20 09:05:33 2012 UTC (11 years, 7 months ago) by jasper
Branch: MAIN
CVS Tags: OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3
Changes since 1.5: +2 -1 lines
Diff to previous 1.5 (colored)

- fix a potential double free

ok florian@

Revision 1.5 / (download) - annotate - [select for diffs], Mon Jul 2 08:08:31 2012 UTC (11 years, 10 months ago) by lum
Branch: MAIN
CVS Tags: OPENBSD_5_2_BASE, OPENBSD_5_2
Changes since 1.4: +3 -13 lines
Diff to previous 1.4 (colored)

Maintain mg's Public Domain license heritage.

Sunil Nimmagadda agrees.

Revision 1.4 / (download) - annotate - [select for diffs], Tue Jun 26 16:59:23 2012 UTC (11 years, 10 months ago) by jasper
Branch: MAIN
Changes since 1.3: +2 -0 lines
Diff to previous 1.3 (colored)

add missing rcs ids

Revision 1.3 / (download) - annotate - [select for diffs], Thu Jun 7 15:15:04 2012 UTC (11 years, 11 months ago) by lum
Branch: MAIN
Changes since 1.2: +0 -2 lines
Diff to previous 1.2 (colored)

Add some cscope support to mg. From Sunil Nimmagadda.  Due to some
structural limitations in mg, mg doesn't behave exactly the same as
emacs cscope (see the README) but is still very usable.

man page bits reviewed by jmc@, otherwise tested and reviewed by
myself.

Revision 1.2 / (download) - annotate - [select for diffs], Mon Dec 5 07:17:02 2011 UTC (12 years, 5 months ago) by lum
Branch: MAIN
CVS Tags: OPENBSD_5_1_BASE, OPENBSD_5_1
Changes since 1.1: +14 -4 lines
Diff to previous 1.1 (colored)

Use absolute filenames while pushing and popping off the stack.

This fixes a segv discovered by Olivier A and reported to Sunil
Nimmagadda, who provided the actual fix. Tested by myself and
Oliver A.

Revision 1.1 / (download) - annotate - [select for diffs], Mon Nov 28 04:41:39 2011 UTC (12 years, 5 months ago) by lum
Branch: MAIN

Add some ctags support to mg. From Sunil Nimmagadda.

Man page review and suggestions from jmc@

Revewied and tested by myself, and ok deraadt@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.