OpenBSD CVS

CVS log for src/usr.bin/openssl/certhash.c


[BACK] Up to [local] / src / usr.bin / openssl

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.21 / (download) - annotate - [select for diffs], Mon Mar 6 14:32:05 2023 UTC (14 months, 2 weeks ago) by tb
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, HEAD
Changes since 1.20: +12 -12 lines
Diff to previous 1.20 (colored)

Rename struct ${app}_config to plain cfg

All the structs are static and we need to reach into them many times.
Having a shorter name is more concise and results in less visual clutter.
It also avoids many overlong lines and we will be able to get rid of some
unfortunate line wrapping down the road.

Discussed with jsing

Revision 1.20 / (download) - annotate - [select for diffs], Fri Nov 11 17:07:38 2022 UTC (18 months, 1 week ago) by joshua
Branch: MAIN
Changes since 1.19: +4 -6 lines
Diff to previous 1.19 (colored)

Remove the legacy interactive mode from openssl(1).

This removes the legacy interactive mode from openssl(1) since it is
rarely used, complicates the code, and has also been removed from
OpenSSL in version 3.x.x.

ok tb@ jsing@

Revision 1.19 / (download) - annotate - [select for diffs], Sat Oct 23 08:13:48 2021 UTC (2 years, 6 months ago) by tb
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1
Changes since 1.18: +5 -1 lines
Diff to previous 1.18 (colored)

Add a length check before NUL-terminating target.  From Jonas Termansen.

ok jsing

Revision 1.18 / (download) - annotate - [select for diffs], Sat Aug 28 08:16:39 2021 UTC (2 years, 8 months ago) by tb
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0
Changes since 1.17: +1 -0 lines
Diff to previous 1.17 (colored)

Add RCS marker

Revision 1.17 / (download) - annotate - [select for diffs], Sun Jul 14 03:30:45 2019 UTC (4 years, 10 months ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.16: +1 -1 lines
Diff to previous 1.16 (colored)

Mark the initialized struct options arrays as both static and const.
This moves them from .data to .data.rel.ro

ok deraadt@ inoguchi@

Revision 1.16 / (download) - annotate - [select for diffs], Wed Feb 7 05:47:55 2018 UTC (6 years, 3 months ago) by jsing
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3
Changes since 1.15: +8 -8 lines
Diff to previous 1.15 (colored)

Indent labels with a single space so that diff prototypes are more useful.

Revision 1.15 / (download) - annotate - [select for diffs], Fri Jan 20 08:57:11 2017 UTC (7 years, 3 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1
Changes since 1.14: +1 -1 lines
Diff to previous 1.14 (colored)

rearrange pledge promises into the canonical order; easier to eyeball

Revision 1.14 / (download) - annotate - [select for diffs], Fri Nov 20 16:16:59 2015 UTC (8 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.13: +0 -1 lines
Diff to previous 1.13 (colored)

do not need sys/param.h

Revision 1.13 / (download) - annotate - [select for diffs], Sat Oct 17 15:00:11 2015 UTC (8 years, 7 months ago) by doug
Branch: MAIN
Changes since 1.12: +3 -1 lines
Diff to previous 1.12 (colored)

Exit if a pledge call fails in non-interactive mode.

ok semarie@

Revision 1.12 / (download) - annotate - [select for diffs], Sat Oct 10 22:28:51 2015 UTC (8 years, 7 months ago) by doug
Branch: MAIN
Changes since 1.11: +5 -0 lines
Diff to previous 1.11 (colored)

Initial support for pledges in openssl(1) commands.

openssl(1) has two mechanisms for operating: either a single execution
of one command (looking at argv[0] or argv[1]) or as an interactive
session than may execute any number of commands.

We already have a top level pledge that should cover all commands
and that's what interactive mode must continue using.  However, we can
tighten up the pledges when only executing one command.

This is an initial stab at support and may contain regressions.  Most
commands only need "stdio rpath wpath cpath".  The pledges could be
further restricted by evaluating the situation after parsing options.

deraadt@ and beck@ are roughly fine with this approach.

Revision 1.11 / (download) - annotate - [select for diffs], Fri Oct 2 18:05:07 2015 UTC (8 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.10: +1 -1 lines
Diff to previous 1.10 (colored)

avoid sys/param.h, by using PATH_MAX

Revision 1.10 / (download) - annotate - [select for diffs], Sat Aug 22 16:36:05 2015 UTC (8 years, 8 months ago) by jsing
Branch: MAIN
Changes since 1.9: +0 -2 lines
Diff to previous 1.9 (colored)

Remove all duplicate prototypes for *_main functions (these are already
provided by progs.h). Also, move the FUNCTION type (and flags) into
openssl.c since that is the only place of use. Lastly, remove pointless
'extern' from the prototypes and use char **argv instead of char *argv[]
(the former is used elsewhere).

ok deraadt@ doug@

Revision 1.9 / (download) - annotate - [select for diffs], Sun Jul 19 03:05:32 2015 UTC (8 years, 10 months ago) by beck
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8
Changes since 1.8: +1 -1 lines
Diff to previous 1.8 (colored)

Fix coverity 105339, by correctly checking return from strtoll
ok miod@ bcook@

Revision 1.8 / (download) - annotate - [select for diffs], Thu Mar 5 17:15:48 2015 UTC (9 years, 2 months ago) by tedu
Branch: MAIN
CVS Tags: OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.7: +1 -1 lines
Diff to previous 1.7 (colored)

subtraction is not comparison. the difference of two longs is not good
to place in an int. from Christian Neukirchen
ok deraadt

Revision 1.7 / (download) - annotate - [select for diffs], Wed Feb 25 20:06:28 2015 UTC (9 years, 2 months ago) by millert
Branch: MAIN
Changes since 1.6: +1 -1 lines
Diff to previous 1.6 (colored)

No need to use O_DIRECTORY when opening ".", O_RDONLY will suffice.
OK guenther@

Revision 1.6 / (download) - annotate - [select for diffs], Wed Feb 25 04:56:41 2015 UTC (9 years, 2 months ago) by doug
Branch: MAIN
Changes since 1.5: +3 -2 lines
Diff to previous 1.5 (colored)

Avoid NULL pointer deref in hashinfo_free() when calling from error paths.

Also, nuke debugging printfs per jsing and bcook.

ok bcook@, jsing@

Revision 1.5 / (download) - annotate - [select for diffs], Sun Feb 22 22:29:40 2015 UTC (9 years, 2 months ago) by guenther
Branch: MAIN
Changes since 1.4: +35 -29 lines
Diff to previous 1.4 (colored)

While slick, this isn't accessing multiple directories concurrently, so
using *at functions is equivalent to chdir()ing, which eases portability.
Tested with mixes of absolute and relative paths.
Eliminate a FILE leak too.

prodded by jsing@

Revision 1.4 / (download) - annotate - [select for diffs], Wed Feb 18 05:48:54 2015 UTC (9 years, 3 months ago) by beck
Branch: MAIN
Changes since 1.3: +2 -1 lines
Diff to previous 1.3 (colored)

fix coverity 105350 and 10345
ok miod@, doug@

Revision 1.3 / (download) - annotate - [select for diffs], Thu Feb 12 04:26:46 2015 UTC (9 years, 3 months ago) by guenther
Branch: MAIN
Changes since 1.2: +4 -2 lines
Diff to previous 1.2 (colored)

qsort() compare functions MUST use memcmp() instead of bcmp() to have
the correct return value.  Prefer memcmp() anyway for portability.

ok jsing@ tedu@

Revision 1.2 / (download) - annotate - [select for diffs], Thu Feb 12 03:09:22 2015 UTC (9 years, 3 months ago) by bcook
Branch: MAIN
Changes since 1.1: +1 -1 lines
Diff to previous 1.1 (colored)

swap limits.h for sys/limits.h

ok jsing@

Revision 1.1 / (download) - annotate - [select for diffs], Tue Feb 10 15:29:34 2015 UTC (9 years, 3 months ago) by jsing
Branch: MAIN

Introduce an openssl(1) certhash command.

This is effectively a reimplementation of the functionality provided by
the previously removed c_rehash Perl script. The c_rehash script had a
number of known issues, including the fact that it needs to run openssl(1)
multiple times and that it starts by removing all symlinks before
putting them back, creating atomicity issues/race conditions, even when
nothing has changed.

certhash is self-contained and is intended to be stable - no changes
should be made unless something has actually changed. This means it can
be run regularly in a production environment without causing certificate
lookup failures.

Further testing and improvements will happen in tree.

Discussed with tedu@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.