OpenBSD CVS

CVS log for src/usr.bin/openssl/cms.c


[BACK] Up to [local] / src / usr.bin / openssl

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.35 / (download) - annotate - [select for diffs], Tue Nov 21 17:56:19 2023 UTC (5 months, 3 weeks ago) by tb
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, HEAD
Changes since 1.34: +2 -2 lines
Diff to previous 1.34 (colored)

Make a few purpose things const

This should allow us to constify a sizable table in libcrypto in an
upcoming bump.

Revision 1.34 / (download) - annotate - [select for diffs], Fri Apr 14 15:27:13 2023 UTC (13 months ago) by tb
Branch: MAIN
CVS Tags: OPENBSD_7_4_BASE, OPENBSD_7_4
Changes since 1.33: +1 -23 lines
Diff to previous 1.33 (colored)

Drop policy printing from openssl

Nothing really uses the policy tree. It's desgined with built-in DoS
capabilities directly from the RFC. It will be removed from the attack
surface and replaced with something equivalent that doesn't grow
exponentially with the depth.

This removes the only reason the policy tree itself ever leaked out of
the library.

ok jsing

Revision 1.33 / (download) - annotate - [select for diffs], Mon Mar 6 14:32:05 2023 UTC (14 months, 2 weeks ago) by tb
Branch: MAIN
CVS Tags: OPENBSD_7_3_BASE, OPENBSD_7_3
Changes since 1.32: +351 -351 lines
Diff to previous 1.32 (colored)

Rename struct ${app}_config to plain cfg

All the structs are static and we need to reach into them many times.
Having a shorter name is more concise and results in less visual clutter.
It also avoids many overlong lines and we will be able to get rid of some
unfortunate line wrapping down the road.

Discussed with jsing

Revision 1.32 / (download) - annotate - [select for diffs], Sun Mar 5 13:08:22 2023 UTC (14 months, 2 weeks ago) by tb
Branch: MAIN
Changes since 1.31: +3 -3 lines
Diff to previous 1.31 (colored)

openssl/cms: zap some trailing whitespace

Revision 1.31 / (download) - annotate - [select for diffs], Fri Nov 11 17:07:38 2022 UTC (18 months, 1 week ago) by joshua
Branch: MAIN
Changes since 1.30: +4 -6 lines
Diff to previous 1.30 (colored)

Remove the legacy interactive mode from openssl(1).

This removes the legacy interactive mode from openssl(1) since it is
rarely used, complicates the code, and has also been removed from
OpenSSL in version 3.x.x.

ok tb@ jsing@

Revision 1.30 / (download) - annotate - [select for diffs], Wed Mar 23 15:16:59 2022 UTC (2 years, 1 month ago) by tb
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1
Changes since 1.29: +3 -1 lines
Diff to previous 1.29 (colored)

openssl cms: avoid NULL derefs on option parsing

Two missing initializations in the new option handling cause a
segfault when -nodetach or -noindef is passed to openssl cms.

ok inoguchi jsing miod

Revision 1.29 / (download) - annotate - [select for diffs], Sun Jan 16 07:11:49 2022 UTC (2 years, 4 months ago) by inoguchi
Branch: MAIN
Changes since 1.28: +3 -1 lines
Diff to previous 1.28 (colored)

Avoid memory leak in error path with openssl(1) cms

CID 345314 345320

ok tb@

Revision 1.28 / (download) - annotate - [select for diffs], Sat Jan 8 06:05:39 2022 UTC (2 years, 4 months ago) by inoguchi
Branch: MAIN
Changes since 1.27: +3 -3 lines
Diff to previous 1.27 (colored)

Indicate current default cipher

Revision 1.27 / (download) - annotate - [select for diffs], Thu Jan 6 12:54:51 2022 UTC (2 years, 4 months ago) by inoguchi
Branch: MAIN
Changes since 1.26: +7 -1 lines
Diff to previous 1.26 (colored)

Free memory before assign to avoid leak

CID 313263 313301 313322

Revision 1.26 / (download) - annotate - [select for diffs], Thu Jan 6 11:46:05 2022 UTC (2 years, 4 months ago) by inoguchi
Branch: MAIN
Changes since 1.25: +4 -2 lines
Diff to previous 1.25 (colored)

Free memory if error occurred

Revision 1.25 / (download) - annotate - [select for diffs], Thu Jan 6 11:37:29 2022 UTC (2 years, 4 months ago) by inoguchi
Branch: MAIN
Changes since 1.24: +2 -3 lines
Diff to previous 1.24 (colored)

Remove NULL check before free

Revision 1.24 / (download) - annotate - [select for diffs], Wed Jan 5 13:41:12 2022 UTC (2 years, 4 months ago) by inoguchi
Branch: MAIN
Changes since 1.23: +129 -74 lines
Diff to previous 1.23 (colored)

Wrap long lines and add some braces

Revision 1.23 / (download) - annotate - [select for diffs], Wed Jan 5 12:51:49 2022 UTC (2 years, 4 months ago) by inoguchi
Branch: MAIN
Changes since 1.22: +18 -8 lines
Diff to previous 1.22 (colored)

Check function return value

Revision 1.22 / (download) - annotate - [select for diffs], Wed Jan 5 11:38:19 2022 UTC (2 years, 4 months ago) by inoguchi
Branch: MAIN
Changes since 1.21: +75 -74 lines
Diff to previous 1.21 (colored)

Checking pointer variable with NULL

Revision 1.21 / (download) - annotate - [select for diffs], Wed Jan 5 10:33:36 2022 UTC (2 years, 4 months ago) by inoguchi
Branch: MAIN
Changes since 1.20: +2 -2 lines
Diff to previous 1.20 (colored)

Use calloc instead of malloc

suggested by tb@

Revision 1.20 / (download) - annotate - [select for diffs], Wed Jan 5 10:29:08 2022 UTC (2 years, 4 months ago) by inoguchi
Branch: MAIN
Changes since 1.19: +45 -41 lines
Diff to previous 1.19 (colored)

Check NULL first and unindent the rest of the code

suggested by tb@

Revision 1.19 / (download) - annotate - [select for diffs], Wed Jan 5 10:01:39 2022 UTC (2 years, 4 months ago) by inoguchi
Branch: MAIN
Changes since 1.18: +1241 -621 lines
Diff to previous 1.18 (colored)

Convert openssl(1) cms option handling

Just applying new option handling and no functional changes.
Referred to verify.c and using 'verify_shared_options'.

ok and comments from jsing@ and tb@

Revision 1.18 / (download) - annotate - [select for diffs], Sun Dec 26 15:23:37 2021 UTC (2 years, 4 months ago) by tb
Branch: MAIN
Changes since 1.17: +4 -2 lines
Diff to previous 1.17 (colored)

Plug memleak

CID 345119

Revision 1.17 / (download) - annotate - [select for diffs], Sat Jan 4 14:17:55 2020 UTC (4 years, 4 months ago) by inoguchi
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7
Changes since 1.16: +21 -11 lines
Diff to previous 1.16 (colored)

Check CMS API return value in openssl(1) cms

ok jsing@

Revision 1.16 / (download) - annotate - [select for diffs], Tue Nov 19 10:28:18 2019 UTC (4 years, 6 months ago) by inoguchi
Branch: MAIN
Changes since 1.15: +29 -23 lines
Diff to previous 1.15 (colored)

More return value check in openssl(1) cms

Checking return value of sk_.*_new_null().

ok beck@ jsing@

Revision 1.15 / (download) - annotate - [select for diffs], Mon Nov 18 12:43:27 2019 UTC (4 years, 6 months ago) by inoguchi
Branch: MAIN
Changes since 1.14: +33 -23 lines
Diff to previous 1.14 (colored)

Remove typedef and check sk_push return value in openssl(1) cms

- Remove typedef and use 'struct cms_key_param' instead
- Check return value of sk_X509_push and sk_OPENSSL_STRING_push
- Add a blank line to separate variable declarations from code

comments from jsing@

Revision 1.14 / (download) - annotate - [select for diffs], Mon Nov 18 11:34:41 2019 UTC (4 years, 6 months ago) by inoguchi
Branch: MAIN
Changes since 1.13: +128 -8 lines
Diff to previous 1.13 (colored)

Add -keyopt opiton to openssl(1) cms subcommand

This provides rsa_padding_mode:oaep for cms -encrypt,
and rsa_padding_mode:pss for cms -sign.

ok jsing@

Revision 1.13 / (download) - annotate - [select for diffs], Mon Nov 4 15:34:27 2019 UTC (4 years, 6 months ago) by jsing
Branch: MAIN
Changes since 1.12: +5 -5 lines
Diff to previous 1.12 (colored)

Indent labels for diffability.

Revision 1.12 / (download) - annotate - [select for diffs], Mon Nov 4 15:33:48 2019 UTC (4 years, 6 months ago) by jsing
Branch: MAIN
Changes since 1.11: +25 -25 lines
Diff to previous 1.11 (colored)

Remove spaces between * and variable names.

Revision 1.11 / (download) - annotate - [select for diffs], Mon Nov 4 15:31:08 2019 UTC (4 years, 6 months ago) by jsing
Branch: MAIN
Changes since 1.10: +14 -21 lines
Diff to previous 1.10 (colored)

Remove explicit NULL checks before *_free() calls.

Revision 1.10 / (download) - annotate - [select for diffs], Mon Nov 4 15:18:45 2019 UTC (4 years, 6 months ago) by jsing
Branch: MAIN
Changes since 1.9: +3 -2 lines
Diff to previous 1.9 (colored)

Currently we need to include pem.h before cms.h...

Revision 1.9 / (download) - annotate - [select for diffs], Mon Nov 4 14:49:59 2019 UTC (4 years, 6 months ago) by jsing
Branch: MAIN
Changes since 1.8: +7 -7 lines
Diff to previous 1.8 (colored)

Remove engine argument from load_cert() calls.

This was cleaned up after cms went to the attic.

Revision 1.8 / (download) - annotate - [select for diffs], Mon Nov 4 14:47:43 2019 UTC (4 years, 6 months ago) by jsing
Branch: MAIN
Changes since 1.7: +1 -1 lines
Diff to previous 1.7 (colored)

Bring openssl(1) cms back from the attic.

Revision 1.7, Sun Sep 4 18:05:34 2016 UTC (7 years, 8 months ago) by beck
Branch: MAIN
Changes since 1.6: +1 -1 lines
FILE REMOVED

bye bye cms. send it to the attic
ok jsing@

Revision 1.6 / (download) - annotate - [select for diffs], Sat Oct 17 15:00:11 2015 UTC (8 years, 7 months ago) by doug
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.5: +4 -2 lines
Diff to previous 1.5 (colored)

Exit if a pledge call fails in non-interactive mode.

ok semarie@

Revision 1.5 / (download) - annotate - [select for diffs], Sat Oct 17 07:51:10 2015 UTC (8 years, 7 months ago) by semarie
Branch: MAIN
Changes since 1.4: +2 -2 lines
Diff to previous 1.4 (colored)

add "tty" for several subcommands of openssl

it is needed in order to let libssl UI_* function plays with echo on/off when
asking for password on terminal.

passwd subcommand needs additionnal "wpath cpath" in order to let it calls
fopen("/dev/tty", "w") (O_WRONLY with O_CREAT | O_TRUNC).

problem reported by several
with and ok doug@

Revision 1.4 / (download) - annotate - [select for diffs], Sat Oct 10 22:28:51 2015 UTC (8 years, 7 months ago) by doug
Branch: MAIN
Changes since 1.3: +6 -1 lines
Diff to previous 1.3 (colored)

Initial support for pledges in openssl(1) commands.

openssl(1) has two mechanisms for operating: either a single execution
of one command (looking at argv[0] or argv[1]) or as an interactive
session than may execute any number of commands.

We already have a top level pledge that should cover all commands
and that's what interactive mode must continue using.  However, we can
tighten up the pledges when only executing one command.

This is an initial stab at support and may contain regressions.  Most
commands only need "stdio rpath wpath cpath".  The pledges could be
further restricted by evaluating the situation after parsing options.

deraadt@ and beck@ are roughly fine with this approach.

Revision 1.3 / (download) - annotate - [select for diffs], Fri Sep 11 14:30:23 2015 UTC (8 years, 8 months ago) by bcook
Branch: MAIN
Changes since 1.2: +2 -19 lines
Diff to previous 1.2 (colored)

Remove engine command and parameters from openssl(1).

We do not have any builtin or dynamic engines, meaning openssl(1) has
no way to use the engine command or parameters at all.

ok jsing@

Revision 1.2 / (download) - annotate - [select for diffs], Sat Aug 22 16:36:05 2015 UTC (8 years, 8 months ago) by jsing
Branch: MAIN
Changes since 1.1: +1 -3 lines
Diff to previous 1.1 (colored)

Remove all duplicate prototypes for *_main functions (these are already
provided by progs.h). Also, move the FUNCTION type (and flags) into
openssl.c since that is the only place of use. Lastly, remove pointless
'extern' from the prototypes and use char **argv instead of char *argv[]
(the former is used elsewhere).

ok deraadt@ doug@

Revision 1.1 / (download) - annotate - [select for diffs], Tue Aug 26 17:47:24 2014 UTC (9 years, 8 months ago) by jsing
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7

Move openssl(1) from /usr/sbin/openssl to /usr/bin/openssl, since it is not
a system/superuser binary. At the same time, move the source code from its
current lib/libssl/src/apps location to a more appropriate home under
usr.bin/openssl.

ok deraadt@ miod@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.