OpenBSD CVS

CVS log for src/usr.bin/openssl/req.c


[BACK] Up to [local] / src / usr.bin / openssl

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.29 / (download) - annotate - [select for diffs], Wed Apr 17 01:24:43 2024 UTC (4 weeks, 4 days ago) by tb
Branch: MAIN
CVS Tags: HEAD
Changes since 1.28: +2 -1 lines
Diff to previous 1.28 (colored)

openssl req: plug obvious leak

CID 492603

Revision 1.28 / (download) - annotate - [select for diffs], Sun Jul 2 07:05:14 2023 UTC (10 months, 2 weeks ago) by tb
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4
Changes since 1.27: +8 -1 lines
Diff to previous 1.27 (colored)

Teach openssl req about EdDSA certs

After a few things in libcrypto were adjusted, this diff makes issuing
certificate requests with Ed25519 work.

ok beck

Revision 1.27 / (download) - annotate - [select for diffs], Mon Mar 6 14:32:06 2023 UTC (14 months, 1 week ago) by tb
Branch: MAIN
CVS Tags: OPENBSD_7_3_BASE, OPENBSD_7_3
Changes since 1.26: +179 -179 lines
Diff to previous 1.26 (colored)

Rename struct ${app}_config to plain cfg

All the structs are static and we need to reach into them many times.
Having a shorter name is more concise and results in less visual clutter.
It also avoids many overlong lines and we will be able to get rid of some
unfortunate line wrapping down the road.

Discussed with jsing

Revision 1.26 / (download) - annotate - [select for diffs], Sun Mar 5 13:12:53 2023 UTC (14 months, 2 weeks ago) by tb
Branch: MAIN
Changes since 1.25: +2 -2 lines
Diff to previous 1.25 (colored)

openssl: make all config structs static

These are per-app, so per-file. Most of them already are static, adjust
the rest of them.

Revision 1.25 / (download) - annotate - [select for diffs], Sat Mar 4 06:25:42 2023 UTC (14 months, 2 weeks ago) by tb
Branch: MAIN
Changes since 1.24: +2 -2 lines
Diff to previous 1.24 (colored)

openssl/req: garbage collect a pointless EVP_MD_CTX_init()

Before do_sign_init(), the ctx is always allocated by EVP_MD_CTX_new()
aka calloc(). There is no point in doing EVP_MD_CTX_init(), aka bzero().

ok jsing

Revision 1.24 / (download) - annotate - [select for diffs], Fri Nov 11 17:07:39 2022 UTC (18 months ago) by joshua
Branch: MAIN
Changes since 1.23: +4 -6 lines
Diff to previous 1.23 (colored)

Remove the legacy interactive mode from openssl(1).

This removes the legacy interactive mode from openssl(1) since it is
rarely used, complicates the code, and has also been removed from
OpenSSL in version 3.x.x.

ok tb@ jsing@

Revision 1.23 / (download) - annotate - [select for diffs], Thu Feb 3 17:44:04 2022 UTC (2 years, 3 months ago) by tb
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1
Changes since 1.22: +13 -19 lines
Diff to previous 1.22 (colored)

Use X509_*get0_pubkey() wherever possible to simplify and clean up
the code. Also add error checking where possible.

ok jsing

Revision 1.22 / (download) - annotate - [select for diffs], Sun Dec 12 20:42:37 2021 UTC (2 years, 5 months ago) by tb
Branch: MAIN
Changes since 1.21: +43 -25 lines
Diff to previous 1.21 (colored)

Convert req.c to compile with opaque EVP_MD_CTX.

ok inoguchi

Revision 1.21 / (download) - annotate - [select for diffs], Sat Oct 23 11:36:44 2021 UTC (2 years, 6 months ago) by tb
Branch: MAIN
Changes since 1.20: +3 -25 lines
Diff to previous 1.20 (colored)

Nuke the asn1-kludge. This was a workaround for CAs with broken PCKS#10
encoders many moons ago. OpenSSL removed it in 2015.

ok beck jsing

Revision 1.20 / (download) - annotate - [select for diffs], Fri Oct 22 09:44:30 2021 UTC (2 years, 6 months ago) by tb
Branch: MAIN
Changes since 1.19: +1 -2 lines
Diff to previous 1.19 (colored)

Stop setting enc.modified manually. It's no longer needed.

Revision 1.19 / (download) - annotate - [select for diffs], Sun Aug 9 16:38:24 2020 UTC (3 years, 9 months ago) by jsing
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8
Changes since 1.18: +572 -378 lines
Diff to previous 1.18 (colored)

Convert openssl req option handling.

With input from inoguchi@

ok beck@ inoguchi@

Revision 1.18 / (download) - annotate - [select for diffs], Wed Nov 6 11:16:16 2019 UTC (4 years, 6 months ago) by inoguchi
Branch: MAIN
CVS Tags: OPENBSD_6_7_BASE, OPENBSD_6_7
Changes since 1.17: +7 -7 lines
Diff to previous 1.17 (colored)

Check return value and remove unnecessary variable

- Check NCONF_new() return value
- Remove unnecessary 'i'

comments from jsing@

Revision 1.17 / (download) - annotate - [select for diffs], Wed Nov 6 10:35:40 2019 UTC (4 years, 6 months ago) by inoguchi
Branch: MAIN
Changes since 1.16: +133 -3 lines
Diff to previous 1.16 (colored)

Add -addext option to openssl(1) req subcommand

First step of adding -addext option to openssl(1) req from OpenSSL 1.1.1d.

ok jsing@

Revision 1.16 / (download) - annotate - [select for diffs], Wed Jul 3 03:24:02 2019 UTC (4 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.15: +9 -9 lines
Diff to previous 1.15 (colored)

snprintf/vsnprintf return < 0 on error, rather than -1.

Revision 1.15 / (download) - annotate - [select for diffs], Wed Feb 7 05:47:55 2018 UTC (6 years, 3 months ago) by jsing
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3
Changes since 1.14: +10 -10 lines
Diff to previous 1.14 (colored)

Indent labels with a single space so that diff prototypes are more useful.

Revision 1.14 / (download) - annotate - [select for diffs], Fri Jan 20 08:57:12 2017 UTC (7 years, 3 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1
Changes since 1.13: +2 -2 lines
Diff to previous 1.13 (colored)

rearrange pledge promises into the canonical order; easier to eyeball

Revision 1.13 / (download) - annotate - [select for diffs], Sat Nov 14 14:53:14 2015 UTC (8 years, 6 months ago) by miod
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.12: +2 -2 lines
Diff to previous 1.12 (colored)

mutli -> multi

Revision 1.12 / (download) - annotate - [select for diffs], Sat Oct 17 15:00:11 2015 UTC (8 years, 7 months ago) by doug
Branch: MAIN
Changes since 1.11: +4 -2 lines
Diff to previous 1.11 (colored)

Exit if a pledge call fails in non-interactive mode.

ok semarie@

Revision 1.11 / (download) - annotate - [select for diffs], Sat Oct 17 07:51:10 2015 UTC (8 years, 7 months ago) by semarie
Branch: MAIN
Changes since 1.10: +2 -2 lines
Diff to previous 1.10 (colored)

add "tty" for several subcommands of openssl

it is needed in order to let libssl UI_* function plays with echo on/off when
asking for password on terminal.

passwd subcommand needs additionnal "wpath cpath" in order to let it calls
fopen("/dev/tty", "w") (O_WRONLY with O_CREAT | O_TRUNC).

problem reported by several
with and ok doug@

Revision 1.10 / (download) - annotate - [select for diffs], Sat Oct 10 22:28:51 2015 UTC (8 years, 7 months ago) by doug
Branch: MAIN
Changes since 1.9: +6 -1 lines
Diff to previous 1.9 (colored)

Initial support for pledges in openssl(1) commands.

openssl(1) has two mechanisms for operating: either a single execution
of one command (looking at argv[0] or argv[1]) or as an interactive
session than may execute any number of commands.

We already have a top level pledge that should cover all commands
and that's what interactive mode must continue using.  However, we can
tighten up the pledges when only executing one command.

This is an initial stab at support and may contain regressions.  Most
commands only need "stdio rpath wpath cpath".  The pledges could be
further restricted by evaluating the situation after parsing options.

deraadt@ and beck@ are roughly fine with this approach.

Revision 1.9 / (download) - annotate - [select for diffs], Mon Sep 14 01:45:03 2015 UTC (8 years, 8 months ago) by doug
Branch: MAIN
Changes since 1.8: +2 -2 lines
Diff to previous 1.8 (colored)

Temporarily revive MD4 for MS CHAP support.

Revision 1.8 / (download) - annotate - [select for diffs], Sun Sep 13 23:36:21 2015 UTC (8 years, 8 months ago) by doug
Branch: MAIN
Changes since 1.7: +2 -2 lines
Diff to previous 1.7 (colored)

Remove MD4 support from LibreSSL.

MD4 should have been removed a long time ago.  Also, RFC 6150 moved it to
historic in 2011.  Rides the major crank from removing SHA-0.

Discussed with many including beck@, millert@, djm@, sthen@
ok jsing@, input + ok bcook@

Revision 1.7 / (download) - annotate - [select for diffs], Fri Sep 11 14:30:23 2015 UTC (8 years, 8 months ago) by bcook
Branch: MAIN
Changes since 1.6: +10 -56 lines
Diff to previous 1.6 (colored)

Remove engine command and parameters from openssl(1).

We do not have any builtin or dynamic engines, meaning openssl(1) has
no way to use the engine command or parameters at all.

ok jsing@

Revision 1.6 / (download) - annotate - [select for diffs], Sat Aug 22 16:36:05 2015 UTC (8 years, 8 months ago) by jsing
Branch: MAIN
Changes since 1.5: +1 -3 lines
Diff to previous 1.5 (colored)

Remove all duplicate prototypes for *_main functions (these are already
provided by progs.h). Also, move the FUNCTION type (and flags) into
openssl.c since that is the only place of use. Lastly, remove pointless
'extern' from the prototypes and use char **argv instead of char *argv[]
(the former is used elsewhere).

ok deraadt@ doug@

Revision 1.5 / (download) - annotate - [select for diffs], Sat Jun 20 01:07:25 2015 UTC (8 years, 11 months ago) by doug
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8
Changes since 1.4: +2 -2 lines
Diff to previous 1.4 (colored)

Remove obsolete MDC-2DES from libcrypto.

ok deraadt@ jsing@ miod@

Revision 1.4 / (download) - annotate - [select for diffs], Thu Oct 16 10:43:54 2014 UTC (9 years, 7 months ago) by jsing
Branch: MAIN
CVS Tags: OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.3: +2 -2 lines
Diff to previous 1.3 (colored)

Repair BUF_strdup() breakage.

Revision 1.3 / (download) - annotate - [select for diffs], Wed Oct 1 13:15:40 2014 UTC (9 years, 7 months ago) by sthen
Branch: MAIN
Changes since 1.2: +4 -5 lines
Diff to previous 1.2 (colored)

Switch "openssl req" to using SHA256 for hashes and AES256 to encrypt on-disk
keys by default (instead of SHA1/3DES) and update documentation to match.

Another way to do this is s/NID_sha1/NID_sha256/ in src/crypto/rsa/rsa_ameth.c
("case ASN1_PKEY_CTRL_DEFAULT_MD_NID") but going with the more targetted method
above that only affects "openssl req" for now.

Help/OK jsing@. OKs on earlier diffs changing openssl.cnf from phessler@ aja@

Revision 1.2 / (download) - annotate - [select for diffs], Thu Aug 28 14:23:52 2014 UTC (9 years, 8 months ago) by jsing
Branch: MAIN
Changes since 1.1: +2 -2 lines
Diff to previous 1.1 (colored)

openssl_setup() calls SSL_load_error_strings(), which happens to call
ERR_load_crypto_strings() - as such, we do not need to call the same
function from most of the applications.

Revision 1.1 / (download) - annotate - [select for diffs], Tue Aug 26 17:47:25 2014 UTC (9 years, 8 months ago) by jsing
Branch: MAIN

Move openssl(1) from /usr/sbin/openssl to /usr/bin/openssl, since it is not
a system/superuser binary. At the same time, move the source code from its
current lib/libssl/src/apps location to a more appropriate home under
usr.bin/openssl.

ok deraadt@ miod@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.