OpenBSD CVS

CVS log for src/usr.bin/rcs/rcs.c


[BACK] Up to [local] / src / usr.bin / rcs

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.89 / (download) - annotate - [select for diffs], Sun Nov 28 19:28:42 2021 UTC (2 years, 5 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, HEAD
Changes since 1.88: +6 -4 lines
Diff to previous 1.88 (colored)

Stop using MAXBSIZE to eliminate sys/param.h including (which injects a
ton of namespace intrusion).  Create local sizes, and refactor some code
along the way.
ok millert

Revision 1.88 / (download) - annotate - [select for diffs], Wed Jan 9 17:57:05 2019 UTC (5 years, 4 months ago) by joris
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5
Changes since 1.87: +5 -1 lines
Diff to previous 1.87 (colored)

When expanding $Log$ make sure a newline is added if rd_log has none.
This can happen on new RCS files.

Fixes $Log$ keyword expansion.

Revision 1.87 / (download) - annotate - [select for diffs], Wed Jan 9 17:55:28 2019 UTC (5 years, 4 months ago) by joris
Branch: MAIN
Changes since 1.86: +19 -1 lines
Diff to previous 1.86 (colored)

Make sure rcs_lock_add() and rcs_lock_remove() properly update the
rd_lock member of the matching delta.

Other keyword substitution will not properly work in cases where the
RCS file did not have a lock for the revision yet or if the lock is
being removed.

Revision 1.86 / (download) - annotate - [select for diffs], Sun Dec 30 23:09:58 2018 UTC (5 years, 4 months ago) by guenther
Branch: MAIN
Changes since 1.85: +1 -2 lines
Diff to previous 1.85 (colored)

Delete unnecessary <libgen.h> #includes

ok deraadt@

Revision 1.85 / (download) - annotate - [select for diffs], Mon May 9 13:03:55 2016 UTC (8 years ago) by schwarze
Branch: MAIN
CVS Tags: OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0
Changes since 1.84: +12 -1 lines
Diff to previous 1.84 (colored)

Implement Mdocdate keyword substitution.
In particular, this stops rcsdiff(1) and CVSweb from showing
wrong Mdocdate lines in diffs.
Problem originally reported by tj@.
OK tobias@ otto@ millert@

Revision 1.84 / (download) - annotate - [select for diffs], Mon Nov 2 16:45:21 2015 UTC (8 years, 6 months ago) by nicm
Branch: MAIN
CVS Tags: OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.83: +5 -9 lines
Diff to previous 1.83 (colored)

Allow rcsnum_free and buf_free to accept NULL and remove various NULL
checks that are now unnecessary, from Michael W Bombardieri. ok millert

Revision 1.83 / (download) - annotate - [select for diffs], Sat Jun 13 20:15:21 2015 UTC (8 years, 11 months ago) by nicm
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8
Changes since 1.82: +40 -57 lines
Diff to previous 1.82 (colored)

Convert xfree to free. From Fritjof Bornebusch. ok deraadt

Revision 1.82 / (download) - annotate - [select for diffs], Fri Jan 16 06:40:11 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.81: +6 -3 lines
Diff to previous 1.81 (colored)

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible.  Annotate <sys/param.h> lines with their current reasons.  Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc.  Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution.  These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Revision 1.81 / (download) - annotate - [select for diffs], Fri Oct 10 08:15:25 2014 UTC (9 years, 7 months ago) by otto
Branch: MAIN
Changes since 1.80: +1 -2 lines
Diff to previous 1.80 (colored)

Zap some stored values never read; From Fritjof Bornebusch; ok nicm@

Revision 1.80 / (download) - annotate - [select for diffs], Tue Jan 7 14:08:16 2014 UTC (10 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5
Changes since 1.79: +3 -3 lines
Diff to previous 1.79 (colored)

ctype cleanups; ok okan

Revision 1.79 / (download) - annotate - [select for diffs], Sat Mar 3 08:34:27 2012 UTC (12 years, 2 months ago) by nicm
Branch: MAIN
CVS Tags: OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2
Changes since 1.78: +2 -7 lines
Diff to previous 1.78 (colored)

Remove unused variable, from Michael W Bombardieri who also got an ok
from tobias@.

Revision 1.78 / (download) - annotate - [select for diffs], Thu Jul 14 16:38:39 2011 UTC (12 years, 10 months ago) by sobrado
Branch: MAIN
CVS Tags: OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0
Changes since 1.77: +1 -2 lines
Diff to previous 1.77 (colored)

spacing, no binary change.

Revision 1.77 / (download) - annotate - [select for diffs], Wed Jul 6 15:36:52 2011 UTC (12 years, 10 months ago) by nicm
Branch: MAIN
Changes since 1.76: +164 -175 lines
Diff to previous 1.76 (colored)

Replace the keyword expansion code with a faster, more readable version
which additionally also supports $Log$ and $Locker. Written by Joerg
Sonnenberger and tweaked by me.

ok ray

Revision 1.76 / (download) - annotate - [select for diffs], Fri May 20 19:21:10 2011 UTC (13 years ago) by nicm
Branch: MAIN
Changes since 1.75: +1 -194 lines
Diff to previous 1.75 (colored)

Remove a bunch of unused functions, from Michael W Bombardieri.

ok ray

Revision 1.75 / (download) - annotate - [select for diffs], Wed Apr 20 19:34:16 2011 UTC (13 years, 1 month ago) by nicm
Branch: MAIN
Changes since 1.74: +1 -4 lines
Diff to previous 1.74 (colored)

Remove some unneeded includes and dead code, from Michael W Bombardieri.

ok jasper xsa

Revision 1.74 / (download) - annotate - [select for diffs], Mon Apr 4 23:08:30 2011 UTC (13 years, 1 month ago) by djm
Branch: MAIN
Changes since 1.73: +2 -1 lines
Diff to previous 1.73 (colored)

previous commit introduced a crash: the removed strtol was being used to
skip past a value and it couldn't just be nuked

Revision 1.73 / (download) - annotate - [select for diffs], Sun Mar 27 18:22:50 2011 UTC (13 years, 1 month ago) by jasper
Branch: MAIN
Changes since 1.72: +2 -3 lines
Diff to previous 1.72 (colored)

- remove unused variables

from Michael W. Bombardieri
ok chl@ nicm@

Revision 1.72 / (download) - annotate - [select for diffs], Fri Dec 10 09:48:43 2010 UTC (13 years, 5 months ago) by jasper
Branch: MAIN
CVS Tags: OPENBSD_4_9_BASE, OPENBSD_4_9
Changes since 1.71: +6 -3 lines
Diff to previous 1.71 (colored)

- plug an fd leak

help/ok chl@ nicm@

Revision 1.71 / (download) - annotate - [select for diffs], Wed Oct 27 08:35:45 2010 UTC (13 years, 6 months ago) by tobias
Branch: MAIN
Changes since 1.70: +10 -8 lines
Diff to previous 1.70 (colored)

Merge -k and expand @@ parsing code between OpenCVS and OpenRCS, resulting
in a performance gain in OpenCVS in some "cvs update" scenarios.

ok zinovik

Revision 1.70 / (download) - annotate - [select for diffs], Wed Oct 20 19:55:46 2010 UTC (13 years, 7 months ago) by tobias
Branch: MAIN
Changes since 1.69: +4 -2 lines
Diff to previous 1.69 (colored)

Merge OpenCVS' rcs_deltatext_set into OpenRCS, fixing a memory leak.

ok nicm zinovik

Revision 1.69 / (download) - annotate - [select for diffs], Wed Oct 20 19:53:53 2010 UTC (13 years, 7 months ago) by tobias
Branch: MAIN
Changes since 1.68: +7 -2 lines
Diff to previous 1.68 (colored)

Remove the need for rp_file in parser structure, instead keep only one
FILE pointer in RCSFILE.  This fixes some ugliness in closing an
fdopen()ed FILE and its underlying file descriptor.

Notified by Joerg Sonnenberger <joerg at britannica dot bec to de>

discussed with and ok nicm

Revision 1.68 / (download) - annotate - [select for diffs], Fri Oct 15 08:44:12 2010 UTC (13 years, 7 months ago) by tobias
Branch: MAIN
Changes since 1.67: +18 -1001 lines
Diff to previous 1.67 (colored)

Replaced RCS parser code with new rcsparse.{c,h}:
- be very strict about things we parse
- print more information about errors if they occur
- do not fatal() directly in parser, give caller a chance to react
- fix an rcs design issue when it comes to login names

tested by many on tech@

ok xsa

Revision 1.67 / (download) - annotate - [select for diffs], Tue Oct 5 15:16:48 2010 UTC (13 years, 7 months ago) by tobias
Branch: MAIN
Changes since 1.66: +1 -19 lines
Diff to previous 1.66 (colored)

Zapped unused function rcs_tag_resolve.

ok xsa

Revision 1.66 / (download) - annotate - [select for diffs], Tue Oct 5 15:13:04 2010 UTC (13 years, 7 months ago) by tobias
Branch: MAIN
Changes since 1.65: +17 -3 lines
Diff to previous 1.65 (colored)

rcs_state_check must check for more invalid characters than just space.

ok nicm

Revision 1.65 / (download) - annotate - [select for diffs], Wed Sep 29 09:23:54 2010 UTC (13 years, 7 months ago) by tobias
Branch: MAIN
Changes since 1.64: +6 -6 lines
Diff to previous 1.64 (colored)

Ensure that we always parse all deltas before expecting "desc" keyword.

ok nicm, zinovik

Revision 1.64 / (download) - annotate - [select for diffs], Thu Sep 23 17:59:03 2010 UTC (13 years, 7 months ago) by nicm
Branch: MAIN
Changes since 1.63: +5 -2 lines
Diff to previous 1.63 (colored)

Plug memory leak in rcs_getrev, from zinovik.

ok me stsp

Revision 1.63 / (download) - annotate - [select for diffs], Sat Sep 11 07:26:00 2010 UTC (13 years, 8 months ago) by tobias
Branch: MAIN
Changes since 1.62: +2 -2 lines
Diff to previous 1.62 (colored)

Fixed typo.

ok ray, zinovik

Revision 1.62 / (download) - annotate - [select for diffs], Thu Sep 2 00:21:41 2010 UTC (13 years, 8 months ago) by tobias
Branch: MAIN
Changes since 1.61: +2 -3 lines
Diff to previous 1.61 (colored)

rcsnum_parse() allocates already an RCSNUM struct, so it's not needed to
copy it into a newly allocated one (which is even a memory leak).

ok zinovik

Revision 1.61 / (download) - annotate - [select for diffs], Tue Aug 31 20:43:45 2010 UTC (13 years, 8 months ago) by tobias
Branch: MAIN
Changes since 1.60: +2 -2 lines
Diff to previous 1.60 (colored)

style

Revision 1.60 / (download) - annotate - [select for diffs], Wed Jul 28 09:07:11 2010 UTC (13 years, 9 months ago) by ray
Branch: MAIN
CVS Tags: OPENBSD_4_8_BASE, OPENBSD_4_8
Changes since 1.59: +5 -5 lines
Diff to previous 1.59 (colored)

Make BUFs autoextend by default.  This was already done in OpenCVS
a while ago.

OK zinovik nicm

Revision 1.59 / (download) - annotate - [select for diffs], Fri Jul 23 21:46:05 2010 UTC (13 years, 9 months ago) by ray
Branch: MAIN
Changes since 1.58: +29 -28 lines
Diff to previous 1.58 (colored)

Reduce variable/function name and whitespace differences between
cvs/rcs.

OK xsa zinovik

Revision 1.58 / (download) - annotate - [select for diffs], Fri Jul 23 08:31:19 2010 UTC (13 years, 10 months ago) by ray
Branch: MAIN
Changes since 1.57: +5 -5 lines
Diff to previous 1.57 (colored)

Rename a bunch of variables and functions, removing the cvs_/rcs_
prefixes to reduce differences between cvs and rcs files.

"yes!" nicm

Revision 1.57 / (download) - annotate - [select for diffs], Wed Jul 21 09:22:19 2010 UTC (13 years, 10 months ago) by ray
Branch: MAIN
Changes since 1.56: +9 -15 lines
Diff to previous 1.56 (colored)

Only use username if author is NULL. Fixes "ci -wusername" when run
as root.

OK nicm

Revision 1.56 / (download) - annotate - [select for diffs], Tue Jul 13 20:07:24 2010 UTC (13 years, 10 months ago) by nicm
Branch: MAIN
Changes since 1.55: +2 -2 lines
Diff to previous 1.55 (colored)

Don't read before the beginning of the log message if it is zero-length
(possible when it comes from stdin).

Tweaked version of a fix from Peter Hendrickson in PR 6423.

ok deraadt

Revision 1.55 / (download) - annotate - [select for diffs], Fri Jul 9 20:07:05 2010 UTC (13 years, 10 months ago) by naddy
Branch: MAIN
Changes since 1.54: +4 -4 lines
Diff to previous 1.54 (colored)

Make cvs and rcs consistent in what characters they'll accept in
symbol/tag names: require the first character to be a letter and
allow any printable character (except the RCS specials $,.:;@)
afterwards.  This matches GNU cvs.

ok xsa@ zinovik@ stsp@

Revision 1.54 / (download) - annotate - [select for diffs], Tue Apr 14 21:16:40 2009 UTC (15 years, 1 month ago) by jj
Branch: MAIN
CVS Tags: OPENBSD_4_7_BASE, OPENBSD_4_7, OPENBSD_4_6_BASE, OPENBSD_4_6
Changes since 1.53: +3 -2 lines
Diff to previous 1.53 (colored)

tried to fix a the-the in the comment, ended up rewriting it. with/from joris@

Revision 1.53 / (download) - annotate - [select for diffs], Wed Feb 25 23:16:20 2009 UTC (15 years, 2 months ago) by ray
Branch: MAIN
CVS Tags: OPENBSD_4_5_BASE, OPENBSD_4_5
Changes since 1.52: +2 -2 lines
Diff to previous 1.52 (colored)

Checking if a file is ASCII should only be done when diffing, because
the non-ASCII characters could be printed to the screen.  For
checking in files, checking out files, merging files, and removing
revisions of files, we do so regardless of whether the files are
ASCII or binary.

Fixes PR6031.

OK joris and deraadt.

Revision 1.52 / (download) - annotate - [select for diffs], Sun Feb 15 13:40:33 2009 UTC (15 years, 3 months ago) by joris
Branch: MAIN
Changes since 1.51: +3 -1 lines
Diff to previous 1.51 (colored)

add our temporary RCS file to our temp_files worklist in case
for some reason we get interrupted before calling rename().

we hate leaving behind temporary files.

Revision 1.51 / (download) - annotate - [select for diffs], Sun Nov 9 08:51:43 2008 UTC (15 years, 6 months ago) by tobias
Branch: MAIN
Changes since 1.50: +2 -5 lines
Diff to previous 1.50 (colored)

Removed unneeded conversion from RCSNUM to string in rcs_rev_setlog.

oki joris@

Revision 1.50 / (download) - annotate - [select for diffs], Sat Nov 8 11:48:49 2008 UTC (15 years, 6 months ago) by tobias
Branch: MAIN
Changes since 1.49: +3 -2 lines
Diff to previous 1.49 (colored)

Support for retrieving revisions from branches in branches was missing.

Reported by chl@, ok joris@

Revision 1.49 / (download) - annotate - [select for diffs], Thu Oct 9 21:45:05 2008 UTC (15 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.48: +2 -1 lines
Diff to previous 1.48 (colored)

cvs(1) uses a config file to know about the $OpenBSD$ expansion keyword,
but unfortunately rcs is not so lucky, and it will have to encoded inside.
A bit gross, but what can we do? PR 5953, ok tobias

Revision 1.48 / (download) - annotate - [select for diffs], Wed Sep 17 06:47:57 2008 UTC (15 years, 8 months ago) by reyk
Branch: MAIN
Changes since 1.47: +7 -4 lines
Diff to previous 1.47 (colored)

try getlogin() to get the real username when comitting files as root.
this gives better information in log messages when the user logged in
with a different uid and used sudo or su to become root. matches the
behaviour of gcvs except that we don't fallback to LOGNAME or USER
since getlogin() should not lie.

ok tobias@

Revision 1.47 / (download) - annotate - [select for diffs], Sun May 11 12:13:41 2008 UTC (16 years ago) by tobias
Branch: MAIN
CVS Tags: OPENBSD_4_4_BASE, OPENBSD_4_4
Changes since 1.46: +3 -1 lines
Diff to previous 1.46 (colored)

Memory leak in rcs_delta_stats plugged.

ok joris

Revision 1.46 / (download) - annotate - [select for diffs], Sat Feb 2 16:21:38 2008 UTC (16 years, 3 months ago) by xsa
Branch: MAIN
CVS Tags: OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.45: +52 -1 lines
Diff to previous 1.45 (colored)

From src/usr.bin/cvs:

> add changed lines support to log and rlog (the + and - stuff)
> from Pierre Riteau;

Revision 1.45 / (download) - annotate - [select for diffs], Thu Jan 31 16:36:11 2008 UTC (16 years, 3 months ago) by tobias
Branch: MAIN
Changes since 1.44: +3 -1 lines
Diff to previous 1.44 (colored)

Revert last patch and add this magic branch number only during
output, this way we don't have to hassle in our internal brach handling.

OK joris@

Revision 1.44 / (download) - annotate - [select for diffs], Sun Jan 6 14:45:50 2008 UTC (16 years, 4 months ago) by tobias
Branch: MAIN
Changes since 1.43: +2 -2 lines
Diff to previous 1.43 (colored)

Branches are separated with \n\t in GNU rcs/cvs.
This makes regress tests easier to check with OpenCVS and GNU cvs.

OK xsa@

Revision 1.43 / (download) - annotate - [select for diffs], Sun Jan 6 09:12:17 2008 UTC (16 years, 4 months ago) by sturm
Branch: MAIN
Changes since 1.42: +9 -2 lines
Diff to previous 1.42 (colored)

gnu cvs added a new keyword 'commitid', this diff adds just enough code
to parse the commitid so that cvsweb (using rcs) continues to work on
those files

ok niallo@, xsa@

Revision 1.42 / (download) - annotate - [select for diffs], Mon Aug 27 19:18:05 2007 UTC (16 years, 8 months ago) by xsa
Branch: MAIN
Changes since 1.41: +2 -2 lines
Diff to previous 1.41 (colored)

typo in error msg; from Igor Zinovik.

Revision 1.41 / (download) - annotate - [select for diffs], Tue Jul 3 00:56:23 2007 UTC (16 years, 10 months ago) by ray
Branch: MAIN
CVS Tags: OPENBSD_4_2_BASE, OPENBSD_4_2
Changes since 1.40: +3 -3 lines
Diff to previous 1.40 (colored)

Rename rcs_diffreg() to diffreg().

OK joris@

Revision 1.40 / (download) - annotate - [select for diffs], Sat Jun 30 08:23:49 2007 UTC (16 years, 10 months ago) by xsa
Branch: MAIN
Changes since 1.39: +3 -3 lines
Diff to previous 1.39 (colored)

Sync revisions and time buffers size to be consistent with each others.
Simplifies further size tweaks if needed.
OK ray@.

Revision 1.39 / (download) - annotate - [select for diffs], Wed Jun 13 18:01:22 2007 UTC (16 years, 11 months ago) by niallo
Branch: MAIN
Changes since 1.38: +3 -3 lines
Diff to previous 1.38 (colored)

value of 'author' in an rcs file is effectively a system username.
therefore, we should allow it to contain the same characters as a username.

pointed out by jcs@
ok ray@ xsa@

Revision 1.38 / (download) - annotate - [select for diffs], Tue May 29 00:19:10 2007 UTC (16 years, 11 months ago) by ray
Branch: MAIN
Changes since 1.37: +3 -4 lines
Diff to previous 1.37 (colored)

Since xrealloc dies on failure it is safe to directly assign to the
original pointer.  Theo agrees, and so does the rest of the tree
(ssh, etc. all do this already).

Saves a bunch of variables and assignments.

OK niallo@

Revision 1.37 / (download) - annotate - [select for diffs], Thu May 17 03:33:24 2007 UTC (17 years ago) by ray
Branch: MAIN
Changes since 1.36: +1 -2 lines
Diff to previous 1.36 (colored)

Don't free unused variable, from tbert.

OK niallo && xsa

Revision 1.36 / (download) - annotate - [select for diffs], Tue Feb 27 07:59:13 2007 UTC (17 years, 2 months ago) by xsa
Branch: MAIN
CVS Tags: OPENBSD_4_1_BASE, OPENBSD_4_1
Changes since 1.35: +13 -2 lines
Diff to previous 1.35 (colored)

As done in OpenCVS, general includes cleanup sweep. OK otto@.

Revision 1.35 / (download) - annotate - [select for diffs], Tue Jan 2 16:43:45 2007 UTC (17 years, 4 months ago) by niallo
Branch: MAIN
Changes since 1.34: +19 -23 lines
Diff to previous 1.34 (colored)

- fix support for checking out binary files.

testing from xsa@ and Igor Sobrado <igor at string1.ciencias.uniovi.es>
ok xsa@

Revision 1.34 / (download) - annotate - [select for diffs], Thu Dec 21 15:37:44 2006 UTC (17 years, 5 months ago) by niallo
Branch: MAIN
Changes since 1.33: +9 -8 lines
Diff to previous 1.33 (colored)

- plug memleak in rcs_parse_delta()

same as opencvs diff, ok xsa@

Revision 1.33 / (download) - annotate - [select for diffs], Thu Sep 21 15:30:07 2006 UTC (17 years, 8 months ago) by millert
Branch: MAIN
Changes since 1.32: +2 -2 lines
Diff to previous 1.32 (colored)

Add support to rcsdiff for all the other diff flags that
are pertinent to files (not directories) and that do not
conflict with rcsdiff-specific flags.  OK xsa@

Revision 1.32 / (download) - annotate - [select for diffs], Wed Aug 23 11:49:49 2006 UTC (17 years, 9 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_4_0_BASE, OPENBSD_4_0
Changes since 1.31: +13 -3 lines
Diff to previous 1.31 (colored)

Add missing checks for EOF when parsing rcs file sections.
OK xsa@ joris@ niallo@

Revision 1.31 / (download) - annotate - [select for diffs], Mon Aug 7 20:55:28 2006 UTC (17 years, 9 months ago) by ray
Branch: MAIN
Changes since 1.30: +33 -19 lines
Diff to previous 1.30 (colored)

More strlcpy/strlcat -> snprintf/xasprintf cleanup.

OK joris@

Revision 1.30 / (download) - annotate - [select for diffs], Fri Aug 4 06:13:54 2006 UTC (17 years, 9 months ago) by ray
Branch: MAIN
Changes since 1.29: +3 -7 lines
Diff to previous 1.29 (colored)

Remove unnecessary strlcpy/strlcat.

``Oh man!'' xsa@

Revision 1.29 / (download) - annotate - [select for diffs], Fri Jul 28 05:41:45 2006 UTC (17 years, 9 months ago) by ray
Branch: MAIN
Changes since 1.28: +3 -1 lines
Diff to previous 1.28 (colored)

Recalculate buffer length after each expansion.

OK niallo@

Revision 1.28 / (download) - annotate - [select for diffs], Thu Jul 27 04:23:37 2006 UTC (17 years, 9 months ago) by ray
Branch: MAIN
Changes since 1.27: +46 -69 lines
Diff to previous 1.27 (colored)

Second try at adding binary file support to rcs_expand_keywords(),
using BUFs instead of C strings.  Also remove initial keyword search,
which is a premature optimization, slower, and apparently too hard for
me to get right.

OK niallo@

Revision 1.27 / (download) - annotate - [select for diffs], Thu Jul 27 02:58:31 2006 UTC (17 years, 9 months ago) by deraadt
Branch: MAIN
Changes since 1.26: +3 -3 lines
Diff to previous 1.26 (colored)

unused variable

Revision 1.26 / (download) - annotate - [select for diffs], Thu Jul 27 02:57:19 2006 UTC (17 years, 9 months ago) by deraadt
Branch: MAIN
Changes since 1.25: +2 -2 lines
Diff to previous 1.25 (colored)

spacing

Revision 1.25 / (download) - annotate - [select for diffs], Fri Jul 21 00:47:35 2006 UTC (17 years, 10 months ago) by ray
Branch: MAIN
Changes since 1.24: +54 -63 lines
Diff to previous 1.24 (colored)

Revert; keywords did not expand.

Revision 1.24 / (download) - annotate - [select for diffs], Fri Jul 21 00:21:52 2006 UTC (17 years, 10 months ago) by ray
Branch: MAIN
Changes since 1.23: +64 -55 lines
Diff to previous 1.23 (colored)

Add binary file support to rcs_expand_keywords(), using BUFs instead
of C strings.

OK niallo@

Revision 1.23 / (download) - annotate - [select for diffs], Tue Jul 11 18:36:32 2006 UTC (17 years, 10 months ago) by markus
Branch: MAIN
Changes since 1.22: +2 -2 lines
Diff to previous 1.22 (colored)

fix out of bound read in rcs_expand_keywords(); ok niallo

Revision 1.22 / (download) - annotate - [select for diffs], Sat Jul 8 09:25:44 2006 UTC (17 years, 10 months ago) by ray
Branch: MAIN
Changes since 1.21: +3 -3 lines
Diff to previous 1.21 (colored)

Remove file mode argument from {cvs|rcs}_buf_write_stmp().  We
always set the temporary file to mode 600, which is already done
by mkstemp().

OK joris@ and xsa@ over a month ago.

Revision 1.21 / (download) - annotate - [select for diffs], Sat Jul 8 07:48:58 2006 UTC (17 years, 10 months ago) by niallo
Branch: MAIN
Changes since 1.20: +4 -1 lines
Diff to previous 1.20 (colored)

- plug an old memory leak in patching code.

ok joris@

Revision 1.20 / (download) - annotate - [select for diffs], Sun Jun 11 22:25:35 2006 UTC (17 years, 11 months ago) by niallo
Branch: MAIN
Changes since 1.19: +1 -4 lines
Diff to previous 1.19 (colored)

- clean up rcs_expand_keywords() a little more.

Revision 1.19 / (download) - annotate - [select for diffs], Sun Jun 11 22:21:23 2006 UTC (17 years, 11 months ago) by niallo
Branch: MAIN
Changes since 1.18: +2 -3 lines
Diff to previous 1.18 (colored)

- zap unused variable

Revision 1.18 / (download) - annotate - [select for diffs], Fri Jun 9 22:09:33 2006 UTC (17 years, 11 months ago) by niallo
Branch: MAIN
Changes since 1.17: +8 -4 lines
Diff to previous 1.17 (colored)

- fix rcs_expand_keywords().

reported by Andreas Kahari <andreas.kahari at gmail>, input from joris@

Revision 1.17 / (download) - annotate - [select for diffs], Sun Jun 4 18:57:37 2006 UTC (17 years, 11 months ago) by niallo
Branch: MAIN
Changes since 1.16: +3 -1 lines
Diff to previous 1.16 (colored)

- explicitly set some pointers to NULL since they are tested on error.

Revision 1.16 / (download) - annotate - [select for diffs], Sun Jun 4 03:00:29 2006 UTC (17 years, 11 months ago) by niallo
Branch: MAIN
Changes since 1.15: +3 -3 lines
Diff to previous 1.15 (colored)

- we can just use the 'sizdiff' variable instead of calling strlen(expbuf);
  simplifies things a little.

Revision 1.15 / (download) - annotate - [select for diffs], Sun Jun 4 02:56:53 2006 UTC (17 years, 11 months ago) by niallo
Branch: MAIN
Changes since 1.14: +2 -1 lines
Diff to previous 1.14 (colored)

- ensure fin pointer is not invalidated after realloc

Revision 1.14 / (download) - annotate - [select for diffs], Sun Jun 4 02:54:59 2006 UTC (17 years, 11 months ago) by niallo
Branch: MAIN
Changes since 1.13: +2 -1 lines
Diff to previous 1.13 (colored)

- don't forget to free data in rcs_expand_keywords()

Revision 1.13 / (download) - annotate - [select for diffs], Sun Jun 4 02:54:07 2006 UTC (17 years, 11 months ago) by niallo
Branch: MAIN
Changes since 1.12: +3 -3 lines
Diff to previous 1.12 (colored)

- fix off-by-one in rcs_expand_keywords()

Revision 1.12 / (download) - annotate - [select for diffs], Sat Jun 3 03:05:10 2006 UTC (17 years, 11 months ago) by niallo
Branch: MAIN
Changes since 1.11: +76 -49 lines
Diff to previous 1.11 (colored)

- correctly handle binary files; say bye bye to using c strings for deltatexts.

"slap it in" joris@

Revision 1.11 / (download) - annotate - [select for diffs], Sun May 28 18:33:49 2006 UTC (17 years, 11 months ago) by ray
Branch: MAIN
Changes since 1.10: +10 -9 lines
Diff to previous 1.10 (colored)

Don't fill in the rd_locker if we are creating a new RCS file.

OK joris@

Revision 1.10 / (download) - annotate - [select for diffs], Sat May 27 08:12:29 2006 UTC (17 years, 11 months ago) by ray
Branch: MAIN
Changes since 1.9: +3 -3 lines
Diff to previous 1.9 (colored)

Rename RCSFILE.fd to RCSFILE.rf_fd, plus minor spacing nits.  No
binary change.

OK xsa@

Revision 1.9 / (download) - annotate - [select for diffs], Thu May 11 07:34:26 2006 UTC (18 years ago) by xsa
Branch: MAIN
Changes since 1.8: +74 -64 lines
Diff to previous 1.8 (colored)

first round of rcs_write() cleanup; prodded by joris@; input/OK ray@.

Revision 1.8 / (download) - annotate - [select for diffs], Mon May 8 16:56:40 2006 UTC (18 years ago) by xsa
Branch: MAIN
Changes since 1.7: +3 -2 lines
Diff to previous 1.7 (colored)

check for rcs_diffreg() return value; OK ray@.

Revision 1.7 / (download) - annotate - [select for diffs], Thu May 4 07:06:58 2006 UTC (18 years ago) by xsa
Branch: MAIN
Changes since 1.6: +30 -43 lines
Diff to previous 1.6 (colored)

finish work wrt TMPDIR; use xasprintf() to simplify code while in there;
"looks fine" ray@.

Revision 1.6 / (download) - annotate - [select for diffs], Mon May 1 18:17:39 2006 UTC (18 years ago) by niallo
Branch: MAIN
Changes since 1.5: +7 -2 lines
Diff to previous 1.5 (colored)

- fix a case in rcs_getrev() handling of branches where variant was not being
  increased and thus no progress could be made in the loop.

bug noticed in rcsdiff(1) by sturm@

ok joris@

Revision 1.5 / (download) - annotate - [select for diffs], Sat Apr 29 05:31:28 2006 UTC (18 years ago) by ray
Branch: MAIN
Changes since 1.4: +56 -39 lines
Diff to previous 1.4 (colored)

Check return values for all strlcpy, and strlcat calls.

OK xsa@ and probably others.

Revision 1.4 / (download) - annotate - [select for diffs], Thu Apr 27 07:59:33 2006 UTC (18 years ago) by xsa
Branch: MAIN
Changes since 1.3: +2 -2 lines
Diff to previous 1.3 (colored)

zap util.[ch] and move the content into rcsutil.[ch].
discussed with joris@.

Revision 1.3 / (download) - annotate - [select for diffs], Wed Apr 26 21:55:22 2006 UTC (18 years ago) by joris
Branch: MAIN
Changes since 1.2: +11 -31 lines
Diff to previous 1.2 (colored)

prevent file races by obtaining an fd for the RCS file and
do our operations on that, this is safe and guarantees we
can operate on the file until we close(2) it.

a fix is coming for the remaining races in our diff code.
okay niallo@ and ray@

Revision 1.2 / (download) - annotate - [select for diffs], Wed Apr 26 15:08:25 2006 UTC (18 years ago) by xsa
Branch: MAIN
Changes since 1.1: +5 -6 lines
Diff to previous 1.1 (colored)

err() cleanup;

Revision 1.1 / (download) - annotate - [select for diffs], Wed Apr 26 02:55:13 2006 UTC (18 years ago) by joris
Branch: MAIN

fork our code we shared between openrcs/cvs into the openrcs dir.

this was starting to become inhuman to maintain without
ugly ugly hacks in the shared code, and it will be easier
to make specific changes for openrcs without touching the
soon-to-be-replaced opencvs code.

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.