OpenBSD CVS

CVS log for src/usr.bin/rdist/common.c


[BACK] Up to [local] / src / usr.bin / rdist

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.41 / (download) - annotate - [select for diffs], Mon Dec 26 19:16:02 2022 UTC (16 months, 3 weeks ago) by jmc
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, HEAD
Changes since 1.40: +2 -2 lines
Diff to previous 1.40 (colored)

spelling fixes; from paul tagliamonte
amendments to his diff are noted on tech

Revision 1.40 / (download) - annotate - [select for diffs], Fri Jun 28 13:35:03 2019 UTC (4 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.39: +2 -2 lines
Diff to previous 1.39 (colored)

When system calls indicate an error they return -1, not some arbitrary
value < 0.  errno is only updated in this case.  Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Revision 1.39 / (download) - annotate - [select for diffs], Fri Sep 21 19:00:45 2018 UTC (5 years, 7 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4
Changes since 1.38: +24 -15 lines
Diff to previous 1.38 (colored)

Use password/group cache functions and avoid stashing a pointer to
the return value of getgrgid(3) or getgrnam(3) which relies on
undefined behavior.  The rdist server will now use getgroups(2) to
determine group membership of the invoking user.  In addition, there
is now one implementation of tilde expansion instead of two.
OK tb@ tim@

Revision 1.38 / (download) - annotate - [select for diffs], Sun Sep 9 13:53:11 2018 UTC (5 years, 8 months ago) by millert
Branch: MAIN
Changes since 1.37: +6 -6 lines
Diff to previous 1.37 (colored)

Fix a crash in rdistd triggered by the recent getpw{ent,nam,uid}
changes.  This stems from rdist stashing a pointer to the static
area used by getpw{ent,nam,uid} and using it to avoid repeating
passwd lookups when pw->pw_name matches the user to be looked up.

This relied on undefined behavior, and with the recent passwd
changes, is no longer possible as the old pointer will be invalidated.
A better approach is to use the upcoming uid_from_user(3) functions.
Found by and fix OK tim@

Revision 1.37 / (download) - annotate - [select for diffs], Tue Dec 22 08:48:39 2015 UTC (8 years, 4 months ago) by mmcc
Branch: MAIN
CVS Tags: OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.36: +2 -2 lines
Diff to previous 1.36 (colored)

remove needless allocation casts

Revision 1.36 / (download) - annotate - [select for diffs], Tue Jan 20 09:00:16 2015 UTC (9 years, 4 months ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.35: +16 -8 lines
Diff to previous 1.35 (colored)

Split out from rdist/defs.h the client-only and server-only bits into
 rdist/client.h and rdistd/server.h
Only put #includes in .h files that are necessary for the .h to be used;
 all other #includes go in the .c files
Move all extern variable declarations to the .h files, renaming local
 variables to avoid shadowing
Replace me_type member of mntent_t with an "is NFS?" flag bit

Revision 1.35 / (download) - annotate - [select for diffs], Tue Jan 20 04:45:43 2015 UTC (9 years, 4 months ago) by guenther
Branch: MAIN
Changes since 1.34: +1 -4 lines
Diff to previous 1.34 (colored)

Don't use utime(), so don't need <utime.h>

Revision 1.34 / (download) - annotate - [select for diffs], Fri Jan 16 06:40:11 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
Changes since 1.33: +2 -2 lines
Diff to previous 1.33 (colored)

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible.  Annotate <sys/param.h> lines with their current reasons.  Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc.  Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution.  These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Revision 1.33 / (download) - annotate - [select for diffs], Sat Jul 12 03:32:00 2014 UTC (9 years, 10 months ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6
Changes since 1.32: +4 -22 lines
Diff to previous 1.32 (colored)

Kill os-openbsd.h: we have <paths.h>, _PATH_RSH, and utimes()

Revision 1.32 / (download) - annotate - [select for diffs], Sat Jul 12 03:25:03 2014 UTC (9 years, 10 months ago) by guenther
Branch: MAIN
Changes since 1.31: +1 -5 lines
Diff to previous 1.31 (colored)

SETARGS and NEED_HASMNTOPT paths are dead; rshrcmd() and libz stuff are
no longer (were never?) used

Revision 1.31 / (download) - annotate - [select for diffs], Thu Jul 10 14:29:03 2014 UTC (9 years, 10 months ago) by guenther
Branch: MAIN
Changes since 1.30: +5 -5 lines
Diff to previous 1.30 (colored)

Assume POSIX: write() takes size_t and returns ssize_t

Revision 1.30 / (download) - annotate - [select for diffs], Sat Jul 5 07:22:18 2014 UTC (9 years, 10 months ago) by guenther
Branch: MAIN
Changes since 1.29: +1 -46 lines
Diff to previous 1.29 (colored)

Assume POSIX: lchown(), fchown(), fchmod(), fchmodat()
Assume we have rcmdsh()

Revision 1.29 / (download) - annotate - [select for diffs], Sat Jul 5 06:55:29 2014 UTC (9 years, 10 months ago) by guenther
Branch: MAIN
Changes since 1.28: +7 -7 lines
Diff to previous 1.28 (colored)

Assume POSIX: uid_t and gid_t

Revision 1.28 / (download) - annotate - [select for diffs], Sat Jul 5 06:18:58 2014 UTC (9 years, 10 months ago) by guenther
Branch: MAIN
Changes since 1.27: +3 -53 lines
Diff to previous 1.27 (colored)

Assume C89: stdargs, const, and setvbuf()
Assume POSIX: O_NONBLOCK and S_IS{DIR,REG,LNK}

Revision 1.27 / (download) - annotate - [select for diffs], Sat Jul 5 05:05:51 2014 UTC (9 years, 10 months ago) by guenther
Branch: MAIN
Changes since 1.26: +16 -19 lines
Diff to previous 1.26 (colored)

Use void* in malloc/realloc/calloc wrappers

Revision 1.26 / (download) - annotate - [select for diffs], Sun Apr 24 02:23:57 2011 UTC (13 years ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0
Changes since 1.25: +6 -28 lines
Diff to previous 1.25 (colored)

delete a stupid SIGSEGV handler (not used)

Revision 1.25 / (download) - annotate - [select for diffs], Mon Apr 18 12:29:59 2011 UTC (13 years, 1 month ago) by krw
Branch: MAIN
Changes since 1.24: +5 -5 lines
Diff to previous 1.24 (colored)

Print size_t with %zu and ssize_t with %zd in error/debug output.
Not %d or %u. May help some of the issues reported by Richard Toohey.
Tested by Steven R. Gerber.

Revision 1.24 / (download) - annotate - [select for diffs], Sun Apr 10 15:47:28 2011 UTC (13 years, 1 month ago) by krw
Branch: MAIN
Changes since 1.23: +7 -7 lines
Diff to previous 1.23 (colored)

Apply some tough type-love and give rdist a chance to handle files
larger than 2GB. Diff from Stephan R. Gerber via PR#6586, tweaks
by me.

ok deraadt@

Revision 1.23 / (download) - annotate - [select for diffs], Tue Oct 27 23:59:42 2009 UTC (14 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.22: +1 -17 lines
Diff to previous 1.22 (colored)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable).  these days, people use source.  these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Revision 1.22 / (download) - annotate - [select for diffs], Wed Jan 2 17:44:11 2008 UTC (16 years, 4 months ago) by chl
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.21: +2 -19 lines
Diff to previous 1.21 (colored)

remove unused function

from tobias@

ok millert@ tobias@

Revision 1.21 / (download) - annotate - [select for diffs], Tue Jun 3 02:56:14 2003 UTC (20 years, 11 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_4_2_BASE, OPENBSD_4_2, OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0, OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6, OPENBSD_3_5_BASE, OPENBSD_3_5, OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.20: +3 -7 lines
Diff to previous 1.20 (colored)

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999.  Proofed by myself and Theo.

Revision 1.20 / (download) - annotate - [select for diffs], Wed May 14 01:34:35 2003 UTC (21 years ago) by millert
Branch: MAIN
Changes since 1.19: +124 -164 lines
Diff to previous 1.19 (colored)

 o Sync w/ freerdist 0.92 minus the compress option
 o KNF and ANSIfy the function headers

Sparse file support is currently a no-op since it didn't work.
Proper sparse file support will be added later.

Revision 1.19 / (download) - annotate - [select for diffs], Tue May 6 21:52:25 2003 UTC (21 years ago) by millert
Branch: MAIN
Changes since 1.18: +11 -18 lines
Diff to previous 1.18 (colored)

Now that rcmdsh(3) can deal with an rsh command w/ args, deal with
-P path elements that have spaces.

Revision 1.18 / (download) - annotate - [select for diffs], Sat Apr 19 17:22:29 2003 UTC (21 years, 1 month ago) by millert
Branch: MAIN
Changes since 1.17: +45 -38 lines
Diff to previous 1.17 (colored)

strcpy/strcat/sprintf removal; krw@ OK

Revision 1.17 / (download) - annotate - [select for diffs], Sat Apr 5 20:31:58 2003 UTC (21 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.16: +10 -10 lines
Diff to previous 1.16 (colored)

strings; ok miod ho krw

Revision 1.16 / (download) - annotate - [select for diffs], Sun Jun 23 03:07:22 2002 UTC (21 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3, OPENBSD_3_2_BASE, OPENBSD_3_2
Changes since 1.15: +11 -11 lines
Diff to previous 1.15 (colored)

uid_t and gid_t are unsigned

Revision 1.15 / (download) - annotate - [select for diffs], Wed Jun 12 06:07:16 2002 UTC (21 years, 11 months ago) by mpech
Branch: MAIN
Changes since 1.14: +7 -6 lines
Diff to previous 1.14 (colored)

a real pid_t cleanup.

espie@ ok for make/,
deraadt@ one extra eye,
millert@ ok

Revision 1.14 / (download) - annotate - [select for diffs], Mon May 27 03:14:22 2002 UTC (21 years, 11 months ago) by deraadt
Branch: MAIN
Changes since 1.13: +4 -4 lines
Diff to previous 1.13 (colored)

unsigned vs unsigned int

Revision 1.13 / (download) - annotate - [select for diffs], Mon May 6 19:48:14 2002 UTC (22 years ago) by millert
Branch: MAIN
Changes since 1.12: +8 -2 lines
Diff to previous 1.12 (colored)

do not install a SIGSEGV handler

Revision 1.12 / (download) - annotate - [select for diffs], Mon Nov 19 19:02:15 2001 UTC (22 years, 6 months ago) by mpech
Branch: MAIN
CVS Tags: OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.11: +16 -16 lines
Diff to previous 1.11 (colored)

kill more registers

millert@ ok

Revision 1.11 / (download) - annotate - [select for diffs], Mon Jul 9 07:04:51 2001 UTC (22 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0
Changes since 1.10: +3 -3 lines
Diff to previous 1.10 (colored)

correct type on last arg to execl(); nordin@cse.ogi.edu

Revision 1.10 / (download) - annotate - [select for diffs], Fri Nov 10 15:33:12 2000 UTC (23 years, 6 months ago) by provos
Branch: MAIN
CVS Tags: OPENBSD_2_9_BASE, OPENBSD_2_9
Changes since 1.9: +3 -3 lines
Diff to previous 1.9 (colored)

seperate -> separate, okay aaron@

Revision 1.9 / (download) - annotate - [select for diffs], Fri May 14 20:19:11 1999 UTC (25 years ago) by aaron
Branch: MAIN
CVS Tags: OPENBSD_2_8_BASE, OPENBSD_2_8, OPENBSD_2_7_BASE, OPENBSD_2_7, OPENBSD_2_6_BASE, OPENBSD_2_6
Changes since 1.8: +3 -3 lines
Diff to previous 1.8 (colored)

correct error msg so it considers the terminating null byte

Revision 1.8 / (download) - annotate - [select for diffs], Thu Feb 4 23:18:57 1999 UTC (25 years, 3 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_5_BASE, OPENBSD_2_5
Changes since 1.7: +20 -6 lines
Diff to previous 1.7 (colored)

Fix a serious memory consumption problem when running over directories
that contain many hard-linked files; johnh@isi.edu
Also add an xstrdup() that behaves like xmalloc() on failure.

Revision 1.7 / (download) - annotate - [select for diffs], Fri Jun 26 21:29:13 1998 UTC (25 years, 10 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_4_BASE, OPENBSD_2_4
Changes since 1.6: +5 -2 lines
Diff to previous 1.6 (colored)

save_errno

Revision 1.6 / (download) - annotate - [select for diffs], Fri Jun 26 21:21:01 1998 UTC (25 years, 10 months ago) by millert
Branch: MAIN
Changes since 1.5: +23 -15 lines
Diff to previous 1.5 (colored)

rdist 6.1.4 + OpenBSD patches + some -Wall

Revision 1.5 / (download) - annotate - [select for diffs], Tue Oct 7 23:39:34 1997 UTC (26 years, 7 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_3_BASE, OPENBSD_2_3, OPENBSD_2_2_BASE, OPENBSD_2_2
Changes since 1.4: +4 -4 lines
Diff to previous 1.4 (colored)

Don't use cached name value for uid/gid if last lookup was by id (and not name).
Fix also sent to rdist-bugs@usc.edu

Revision 1.4 / (download) - annotate - [select for diffs], Sun Apr 27 13:01:28 1997 UTC (27 years ago) by downsj
Branch: MAIN
CVS Tags: OPENBSD_2_1_BASE, OPENBSD_2_1
Changes since 1.3: +3 -3 lines
Diff to previous 1.3 (colored)

Pull in more includes to properly prototype library functions, kill local
decls of library functions, kill local implementation of setproctitle().

This of course points out how utterly bad this code is and that someone needs
to come in here with a chainsaw sometime.

Revision 1.3 / (download) - annotate - [select for diffs], Wed Jun 26 05:38:09 1996 UTC (27 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.2: +3 -1 lines
Diff to previous 1.2 (colored)

rcsid

Revision 1.2 / (download) - annotate - [select for diffs], Tue Mar 5 03:15:58 1996 UTC (28 years, 2 months ago) by dm
Branch: MAIN
Changes since 1.1: +12 -1 lines
Diff to previous 1.1 (colored)

rdist 6.1.2

Revision 1.1 / (download) - annotate - [select for diffs], Sat Feb 3 12:12:12 1996 UTC (28 years, 3 months ago) by dm
Branch: MAIN

rdist 6.1.1

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.