OpenBSD CVS

CVS log for src/usr.bin/rev/rev.c


[BACK] Up to [local] / src / usr.bin / rev

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.16 / (download) - annotate - [select for diffs], Tue Feb 8 17:44:18 2022 UTC (2 years, 3 months ago) by cheloha
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, HEAD
Changes since 1.15: +4 -1 lines
Diff to previous 1.15 (colored)

rev(1): drop "rpath" promise in no-file branch.

We don't need "rpath" if we're only processing the standard input.

Thread: https://marc.info/?l=openbsd-tech&m=164433848419371&w=2

ok deraadt@ millert@

Revision 1.15 / (download) - annotate - [select for diffs], Sat Jan 29 00:11:54 2022 UTC (2 years, 3 months ago) by cheloha
Branch: MAIN
Changes since 1.14: +59 -39 lines
Diff to previous 1.14 (colored)

rev(1): refactor main loop

The main loop here is obfuscated.

Refactor the open/read/write/close portion of the loop out of main ()
and into a new function, rev_file().  Move "multibyte" out into global
storage.

The result is much easier to understand at a glance.

Thread: https://marc.info/?l=openbsd-tech&m=164329515201417&w=2

ok millert@

Revision 1.14 / (download) - annotate - [select for diffs], Thu Jan 13 05:10:46 2022 UTC (2 years, 4 months ago) by schwarze
Branch: MAIN
Changes since 1.13: +14 -11 lines
Diff to previous 1.13 (colored)

Calling MB_CUR_MAX is much more expensive than incrementing a pointer
and than testing and printing a byte, so do it once up front rather
than inside the inner loop.  This speeds up rev(1) by about a factor
of three for typical use cases.
Performance issue found by cheloha@, but my fix is a bit simpler
and more rigorous than Scott's original patch.

While here, also add the missing handling for write errors (making
them fatal, whereas read errors remain non-fatal and proceed to the
next input file) and also avoid testing each byte twice, making the
code more straightforward and more readable.

In part using ideas from millert@ and martijn@.
OK martijn@.

Revision 1.13 / (download) - annotate - [select for diffs], Sun Apr 10 17:06:52 2016 UTC (8 years, 1 month ago) by martijn
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0
Changes since 1.12: +24 -8 lines
Diff to previous 1.12 (colored)

Enable UTF-8 support in rev.
Some minor cleanups while here.

OK schwarze@

Revision 1.12 / (download) - annotate - [select for diffs], Fri Oct 9 01:37:08 2015 UTC (8 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.11: +3 -3 lines
Diff to previous 1.11 (colored)

Change all tame callers to namechange to pledge(2).

Revision 1.11 / (download) - annotate - [select for diffs], Wed Oct 7 06:18:00 2015 UTC (8 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.10: +4 -1 lines
Diff to previous 1.10 (colored)

tame "stdio rpath"

Revision 1.10 / (download) - annotate - [select for diffs], Tue Oct 27 23:59:42 2009 UTC (14 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7, OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.9: +1 -15 lines
Diff to previous 1.9 (colored)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable).  these days, people use source.  these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Revision 1.9 / (download) - annotate - [select for diffs], Fri Mar 16 17:16:28 2007 UTC (17 years, 2 months ago) by jasper
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3, OPENBSD_4_2_BASE, OPENBSD_4_2
Changes since 1.8: +5 -3 lines
Diff to previous 1.8 (colored)

use __progname

ok otto@

Revision 1.8 / (download) - annotate - [select for diffs], Sun Jul 30 06:25:43 2006 UTC (17 years, 9 months ago) by ray
Branch: MAIN
CVS Tags: OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0
Changes since 1.7: +2 -3 lines
Diff to previous 1.7 (colored)

Remove double variable assignment.

From Bret Lambert <bret dot lambert at gmail dot com>

OK krw@ and deraadt@.

Revision 1.7 / (download) - annotate - [select for diffs], Tue Jun 10 22:20:50 2003 UTC (20 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6, OPENBSD_3_5_BASE, OPENBSD_3_5, OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.6: +4 -6 lines
Diff to previous 1.6 (colored)

mostly ansi cleanup; pval ok

Revision 1.6 / (download) - annotate - [select for diffs], Tue Jun 3 02:56:15 2003 UTC (20 years, 11 months ago) by millert
Branch: MAIN
Changes since 1.5: +3 -7 lines
Diff to previous 1.5 (colored)

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999.  Proofed by myself and Theo.

Revision 1.5 / (download) - annotate - [select for diffs], Sat Feb 16 21:27:51 2002 UTC (22 years, 3 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3, OPENBSD_3_2_BASE, OPENBSD_3_2, OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.4: +3 -3 lines
Diff to previous 1.4 (colored)

Part one of userland __P removal.  Done with a simple regexp with some minor hand editing to make comments line up correctly.  Another pass is forthcoming that handles the cases that could not be done automatically.

Revision 1.4 / (download) - annotate - [select for diffs], Mon Nov 19 19:02:16 2001 UTC (22 years, 6 months ago) by mpech
Branch: MAIN
Changes since 1.3: +3 -3 lines
Diff to previous 1.3 (colored)

kill more registers

millert@ ok

Revision 1.3 / (download) - annotate - [select for diffs], Wed Jan 15 23:43:05 1997 UTC (27 years, 4 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0, OPENBSD_2_9_BASE, OPENBSD_2_9, OPENBSD_2_8_BASE, OPENBSD_2_8, OPENBSD_2_7_BASE, OPENBSD_2_7, OPENBSD_2_6_BASE, OPENBSD_2_6, OPENBSD_2_5_BASE, OPENBSD_2_5, OPENBSD_2_4_BASE, OPENBSD_2_4, OPENBSD_2_3_BASE, OPENBSD_2_3, OPENBSD_2_2_BASE, OPENBSD_2_2, OPENBSD_2_1_BASE, OPENBSD_2_1
Changes since 1.2: +3 -3 lines
Diff to previous 1.2 (colored)

getopt(3) returns -1 when out of args, not EOF, whee!

Revision 1.2 / (download) - annotate - [select for diffs], Wed Jun 26 05:38:29 1996 UTC (27 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.1: +2 -1 lines
Diff to previous 1.1 (colored)

rcsid

Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Wed Oct 18 08:46:00 1995 UTC (28 years, 7 months ago) by deraadt
CVS Tags: netbsd_1_1
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)

initial import of NetBSD tree

Revision 1.1 / (download) - annotate - [select for diffs], Wed Oct 18 08:46:00 1995 UTC (28 years, 7 months ago) by deraadt
Branch: MAIN

Initial revision

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.