OpenBSD CVS

CVS log for src/usr.bin/rsync/main.c


[BACK] Up to [local] / src / usr.bin / rsync

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.71 / (download) - annotate - [select for diffs], Mon Nov 27 11:30:49 2023 UTC (5 months, 3 weeks ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, HEAD
Changes since 1.70: +11 -5 lines
Diff to previous 1.70 (colored)

Implement --omit-link-times / -J based on the --omit-dir-times work
done by job@.
OK tb@

Revision 1.70 / (download) - annotate - [select for diffs], Mon Nov 27 10:14:19 2023 UTC (5 months, 3 weeks ago) by claudio
Branch: MAIN
Changes since 1.69: +3 -1 lines
Diff to previous 1.69 (colored)

Add --no-O and --no-omit-dir-times options. For some reason the real
rsync has these options and so should ours. These strange --no-XYZ
options are undocumented and are there just for compatibility.
OK tb@ job@

Revision 1.69 / (download) - annotate - [select for diffs], Thu Nov 23 11:59:53 2023 UTC (5 months, 3 weeks ago) by job
Branch: MAIN
Changes since 1.68: +7 -3 lines
Diff to previous 1.68 (colored)

Add --omit-dir-times / -O

OK claudio@

Revision 1.68 / (download) - annotate - [select for diffs], Fri Apr 28 10:24:38 2023 UTC (12 months, 3 weeks ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_4_BASE, OPENBSD_7_4
Changes since 1.67: +9 -4 lines
Diff to previous 1.67 (colored)

Implement --size-only and --ignore-times

Flags are passed to the remote system but --size-only is only set
if local system is sender since this is the behaviour of rsync.
Initial diff from Martin Cracauer but mostly reimplemented and extended
by myself.
OK kn@

Revision 1.67 / (download) - annotate - [select for diffs], Thu Apr 27 16:28:18 2023 UTC (12 months, 3 weeks ago) by claudio
Branch: MAIN
Changes since 1.66: +9 -10 lines
Diff to previous 1.66 (colored)

Implement -V as an alias to --version.
From Martin Cracauer
OK kn@

Revision 1.66 / (download) - annotate - [select for diffs], Tue Feb 14 17:15:15 2023 UTC (15 months ago) by job
Branch: MAIN
CVS Tags: OPENBSD_7_3_BASE, OPENBSD_7_3
Changes since 1.65: +9 -5 lines
Diff to previous 1.65 (colored)

Fix handling of port numbers in rsync://host[:port]/module URLs

With and OK tb@

Revision 1.65 / (download) - annotate - [select for diffs], Tue Aug 2 20:01:12 2022 UTC (21 months, 2 weeks ago) by tb
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2
Changes since 1.64: +2 -2 lines
Diff to previous 1.64 (colored)

Add missing closing bracket in usage

Revision 1.64 / (download) - annotate - [select for diffs], Tue Aug 2 18:09:20 2022 UTC (21 months, 2 weeks ago) by job
Branch: MAIN
Changes since 1.63: +23 -6 lines
Diff to previous 1.63 (colored)

Add --contimeout functionality.

Input from deraadt@

OK claudio@

Revision 1.53.2.1 / (download) - annotate - [select for diffs], Tue Nov 9 13:41:24 2021 UTC (2 years, 6 months ago) by benno
Branch: OPENBSD_6_9
Changes since 1.53: +194 -107 lines
Diff to previous 1.53 (colored) next main 1.54 (colored)

rpki-client(8) should handle CA misbehaviours as soft-errors.

This is a merge of usr.sbin/rpki-client and usr.bin/rsync from current
and includes all commits in rpki-client 7.5 up to Tue Nov 9 11:03:40
2021 and to openrsync up to Wed Nov 3 14:42:13 2021, including:

* Make rpki-client more resilient regarding untrusted input:
  - fail repository synchronisation after 15min runtime
  - limit the number of publication points per TAL
  - don't allow DOCTYPE definitions in RRDP XML files
  - fix detection of HTTP redirect loops.
* limit the number of concurrent rsync processes.
* fix CRLF in tal files.

This is patches/6.9/common/021_rpki.patch.sig

Revision 1.59.2.1 / (download) - annotate - [select for diffs], Tue Nov 9 13:40:41 2021 UTC (2 years, 6 months ago) by benno
Branch: OPENBSD_7_0
Changes since 1.59: +71 -13 lines
Diff to previous 1.59 (colored) next main 1.60 (colored)

rpki-client(8) should handle CA misbehaviours as soft-errors.

This is a merge of usr.sbin/rpki-client and usr.bin/rsync from current
and includes all commits in rpki-client 7.5 up to Tue Nov 9 11:03:40
2021 and to openrsync up to Wed Nov 3 14:42:13 2021, including:

* Make rpki-client more resilient regarding untrusted input:
  - fail repository synchronisation after 15min runtime
  - limit the number of publication points per TAL
  - don't allow DOCTYPE definitions in RRDP XML files
  - fix detection of HTTP redirect loops.
* limit the number of concurrent rsync processes.
* fix CRLF in tal files.

This is patches/7.0/common/004_rpki.patch.sig

Revision 1.63 / (download) - annotate - [select for diffs], Wed Nov 3 14:42:12 2021 UTC (2 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_1_BASE, OPENBSD_7_1
Changes since 1.62: +4 -4 lines
Diff to previous 1.62 (colored)

whitespace observed during a read-through

Revision 1.62 / (download) - annotate - [select for diffs], Fri Oct 29 08:00:59 2021 UTC (2 years, 6 months ago) by claudio
Branch: MAIN
Changes since 1.61: +10 -3 lines
Diff to previous 1.61 (colored)

Properly implement --max-size and --min-size.
This uses scan_scaled(3) from libutil which is very similar to how rsync
behaves. Not implemented are the +/-1 math and the 1000 vs 1024 multipliers.
OK benno@ job@

Revision 1.61 / (download) - annotate - [select for diffs], Thu Oct 28 13:07:43 2021 UTC (2 years, 6 months ago) by claudio
Branch: MAIN
Changes since 1.60: +9 -1 lines
Diff to previous 1.60 (colored)

Provide --max-size and --min-size arguments. Currently ignored but
rpki-client wants --max-size and this will unblock that work.
With job@

Revision 1.60 / (download) - annotate - [select for diffs], Fri Oct 22 11:10:34 2021 UTC (2 years, 6 months ago) by claudio
Branch: MAIN
Changes since 1.59: +52 -9 lines
Diff to previous 1.59 (colored)

Implement --compare-dest in openrsync. compare-dest allows you to add
additional directories to check for files to be available.
OK benno@

Revision 1.59 / (download) - annotate - [select for diffs], Wed Sep 1 09:48:08 2021 UTC (2 years, 8 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE
Branch point for: OPENBSD_7_0
Changes since 1.58: +4 -12 lines
Diff to previous 1.58 (colored)

Remove from0 support. openrsync will not implement all bad ideas that
were added to rsync. from0 is one of those and really not needed.
OK job@

Revision 1.58 / (download) - annotate - [select for diffs], Mon Aug 30 20:25:01 2021 UTC (2 years, 8 months ago) by job
Branch: MAIN
Changes since 1.57: +3 -1 lines
Diff to previous 1.57 (colored)

Add include/exclude to usage()

OK claudio@

Revision 1.57 / (download) - annotate - [select for diffs], Sun Aug 29 13:43:46 2021 UTC (2 years, 8 months ago) by claudio
Branch: MAIN
Changes since 1.56: +33 -1 lines
Diff to previous 1.56 (colored)

Implement --exclude/exclude-file and --include/include-file.
Currently only simple include and excludes work, the advanced filters
introduced later in rsync are not implemented. It is unclear if the per
directory filters are something we want to implement. This requires
more modern protocols which openrsync is not able to handle right now.

This adds a special matching function to allow the ** matching which behaves
mostly like rsyncs version with the exception of how bad [] patterns are
expanded. For bad patterns openrsync follows more how fnmatch behaves and
not the somewhat strange rsync behaviour.

Not perfect but committing now so people can test and provide feedback.

Revision 1.56 / (download) - annotate - [select for diffs], Wed Jul 14 11:14:27 2021 UTC (2 years, 10 months ago) by claudio
Branch: MAIN
Changes since 1.55: +57 -54 lines
Diff to previous 1.55 (colored)

Restructure the getopt_long options. Sort them mostly by name with the
exception of no-xyz options that are grouped with the coresponding xyz
option. Fix --no-motd to use the internal flag setting of getopt_long.
Also use some defines instead of numbers for pure long options that
need special handling.
OK benno@

Revision 1.55 / (download) - annotate - [select for diffs], Wed Jun 30 13:10:04 2021 UTC (2 years, 10 months ago) by claudio
Branch: MAIN
Changes since 1.54: +1 -1 lines
Diff to previous 1.54 (colored)

Replace Id: tags with OpenBSD: tags
OK deraadt@

Revision 1.54 / (download) - annotate - [select for diffs], Mon May 17 12:04:38 2021 UTC (3 years ago) by claudio
Branch: MAIN
Changes since 1.53: +47 -47 lines
Diff to previous 1.53 (colored)

Adjust exit codes in the main program to follow the ones from rsync.
OK benno@

Revision 1.53 / (download) - annotate - [select for diffs], Wed Mar 31 19:45:16 2021 UTC (3 years, 1 month ago) by job
Branch: MAIN
CVS Tags: OPENBSD_6_9_BASE
Branch point for: OPENBSD_6_9
Changes since 1.52: +8 -3 lines
Diff to previous 1.52 (colored)

Add option to suppress the Message of the Day

Fine deraadt@

Revision 1.52 / (download) - annotate - [select for diffs], Mon Mar 22 11:16:05 2021 UTC (3 years, 1 month ago) by claudio
Branch: MAIN
Changes since 1.51: +2 -2 lines
Diff to previous 1.51 (colored)

Compare explicitly against NULL.
From kristaps@

Revision 1.51 / (download) - annotate - [select for diffs], Tue Dec 15 08:20:42 2020 UTC (3 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.50: +7 -7 lines
Diff to previous 1.50 (colored)

Initialize the poll_timeout before rsync_server() is called.
Without this the server will immediatly fail because the poll timeout is 0.
Found and reported by Daniel Moch (daniel at danielmoch dot com)

Revision 1.50 / (download) - annotate - [select for diffs], Tue Nov 24 16:54:44 2020 UTC (3 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.49: +17 -3 lines
Diff to previous 1.49 (colored)

Simple implementation of --timeout to exit after specified seconds of I/O
inactivity. By default rsync will wait forever but this results in stuck
processes if the remote side does not answer properly as seen in rpki-client.
OK job@ benno@

Revision 1.49 / (download) - annotate - [select for diffs], Tue Feb 11 18:41:39 2020 UTC (4 years, 3 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7
Changes since 1.48: +2 -2 lines
Diff to previous 1.48 (colored)

Simplify and unify wording for the -I sourceaddr option in various places.
This is somewhat related to the "-b bind_addr" option some programs have,
which should get some cleanup also...
input florian claudio jmc

Revision 1.48 / (download) - annotate - [select for diffs], Fri Aug 9 05:28:01 2019 UTC (4 years, 9 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.47: +8 -4 lines
Diff to previous 1.47 (colored)

Add --address argument to openrsync to bind to the specified address
when connecting to a rsync daemon.
OK deraadt@ benno@ naddy@ sthen@

Revision 1.47 / (download) - annotate - [select for diffs], Mon Jun 3 15:37:48 2019 UTC (4 years, 11 months ago) by naddy
Branch: MAIN
Changes since 1.46: +5 -10 lines
Diff to previous 1.46 (colored)

Don't close the socket in rsync_socket() itself but after calling it.
Fixes a corner case where the socket was closed twice, reported by
Hiltjo Posthuma.
ok deraadt@

Revision 1.46 / (download) - annotate - [select for diffs], Tue May 28 18:20:30 2019 UTC (4 years, 11 months ago) by deraadt
Branch: MAIN
Changes since 1.45: +2 -2 lines
Diff to previous 1.45 (colored)

unintialized fd passed to close(), found by hiltjo posthuma

Revision 1.45 / (download) - annotate - [select for diffs], Wed May 8 20:00:25 2019 UTC (5 years ago) by benno
Branch: MAIN
Changes since 1.44: +10 -8 lines
Diff to previous 1.44 (colored)

remove sess argument from log functions. ok deraadt@

Revision 1.44 / (download) - annotate - [select for diffs], Thu Apr 4 04:19:54 2019 UTC (5 years, 1 month ago) by bket
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5
Changes since 1.43: +6 -3 lines
Diff to previous 1.43 (colored)

Add support for not crossing filesystem boundaries (-x) to rsync. Option
and behaviour is the same as GPL rsync.

Initial diff received feedback from benno@, schwarze@, deraadt@ and
florian@. Thanks!

OK deraadt@

Revision 1.43 / (download) - annotate - [select for diffs], Mon Apr 1 13:04:51 2019 UTC (5 years, 1 month ago) by schwarze
Branch: MAIN
Changes since 1.42: +4 -3 lines
Diff to previous 1.42 (colored)

many improvements to rsync(1) documentation:
tweaks and OK deraadt@ naddy@

Revision 1.42 / (download) - annotate - [select for diffs], Sun Mar 31 13:17:44 2019 UTC (5 years, 1 month ago) by schwarze
Branch: MAIN
Changes since 1.41: +4 -5 lines
Diff to previous 1.41 (colored)

Drop --devices and --specials from the synopsis because they are only
low-utility parts of the more useful and shorter -D.  Nice because it
brings the synopsis down to two lines, and because the approach buys us
additional time before the synopsis may grow disgustingly long again.
"Shrug. Probably helps." deraadt@

Revision 1.41 / (download) - annotate - [select for diffs], Sun Mar 31 08:47:46 2019 UTC (5 years, 1 month ago) by naddy
Branch: MAIN
Changes since 1.40: +13 -7 lines
Diff to previous 1.40 (colored)

Add ability to combine rsync:// and -e by splitting rsync_socket()
into two functions, rsync_connect() to establish a TCP connection
to the remote daemon, and rsync_socket() to run the actual protocol.

E.g.:
rsync -av --del -e 'ssh -W localhost:rsync -lanoncvs' \
rsync://anoncvs.spacehopper.org/OpenBSD-CVS/ /cvs

ok deraadt@

Revision 1.40 / (download) - annotate - [select for diffs], Sat Mar 30 23:48:24 2019 UTC (5 years, 1 month ago) by schwarze
Branch: MAIN
Changes since 1.39: +4 -6 lines
Diff to previous 1.39 (colored)

Make the synopsis more palatable by deleting useless long option
aliases where short or shorter forms exist; of course, the long
versions remain in the full option listing as well as in the code.
Also drop some redundant repetions of .Fl macros.
OK jmc@ deraadt@

Revision 1.39 / (download) - annotate - [select for diffs], Sat Mar 30 09:55:05 2019 UTC (5 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.38: +3 -2 lines
Diff to previous 1.38 (colored)

repair confusing "} if" indent; from naddy

Revision 1.38 / (download) - annotate - [select for diffs], Sat Mar 30 09:32:54 2019 UTC (5 years, 1 month ago) by naddy
Branch: MAIN
Changes since 1.37: +2 -2 lines
Diff to previous 1.37 (colored)

document --del, ok deraadt@

Revision 1.37 / (download) - annotate - [select for diffs], Sat Mar 30 07:24:42 2019 UTC (5 years, 1 month ago) by naddy
Branch: MAIN
Changes since 1.36: +2 -2 lines
Diff to previous 1.36 (colored)

Add --del as alias for --delete.

Drop --no-delete.  The "no-" prefix is only available for options
that are implied by other options.  --delete is never implied and
GPL rsync does not accept --no-delete.

ok deraadt@

Revision 1.36 / (download) - annotate - [select for diffs], Mon Mar 25 21:09:49 2019 UTC (5 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.35: +12 -7 lines
Diff to previous 1.35 (colored)

-z support isn't as trivial as linking -lz so it hasn't been written
yet.  In the meantime, make it a warning-no-op, as most usage cases
will be satisfied by this (and hopefully annoy someone to write support)
ok florian benno

Revision 1.35 / (download) - annotate - [select for diffs], Sat Mar 23 16:04:28 2019 UTC (5 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.34: +17 -21 lines
Diff to previous 1.34 (colored)

indents and reflows around ERR*() and LOG*(); ok benno

Revision 1.34 / (download) - annotate - [select for diffs], Sat Mar 23 00:20:55 2019 UTC (5 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.33: +15 -5 lines
Diff to previous 1.33 (colored)

repair exit codes, slightly broken after last commit (please do not go
to an enum, that's just alien).  Documents the return values in each
function and unifies the protocol incompatibility error message.
from kristaps

Revision 1.33 / (download) - annotate - [select for diffs], Mon Mar 18 08:11:11 2019 UTC (5 years, 2 months ago) by jmc
Branch: MAIN
Changes since 1.32: +6 -3 lines
Diff to previous 1.32 (colored)

flesh out SYNOPSIS and usage() somewhat;
ok deraadt benno

Revision 1.32 / (download) - annotate - [select for diffs], Wed Mar 6 18:37:22 2019 UTC (5 years, 2 months ago) by deraadt
Branch: MAIN
Changes since 1.31: +41 -61 lines
Diff to previous 1.31 (colored)

Simplify startup code, various phases are heading straight towards exit
so they don't need to be constructed to return errors.
ok benno florian

Revision 1.31 / (download) - annotate - [select for diffs], Thu Feb 21 22:06:26 2019 UTC (5 years, 2 months ago) by benno
Branch: MAIN
Changes since 1.30: +2 -1 lines
Diff to previous 1.30 (colored)

implement --numeric-ids, tweaked by kristaps

Revision 1.30 / (download) - annotate - [select for diffs], Mon Feb 18 22:47:34 2019 UTC (5 years, 3 months ago) by benno
Branch: MAIN
Changes since 1.29: +6 -5 lines
Diff to previous 1.29 (colored)

new attempt to sync with kristaps up to Sun Feb 17 2019

339cf5998c0c022623cd68de50722b6c14543952 Push "error trail" further into code.

baf58ce5fe1bc6ce431b3b0ac8264b83ae8c7d02 Document all arguments.  Add
common -av usage.  Remove bits about not supporting anything but
files/dirs.

821a811a8c80e52fb56b241fc65a16cae1b4fb2c Disambiguate as prodded by deraadt@

6c4475b8f226e9031ec0ec1b3f14f7d347132c87 Add -h to usage string

4d344ae6156873b44c95de0c1ed629e637c2d7ab Clarify error message
language, use service name instead of port, specify that the socket is
SOCK_STREAM.  From deraadt@.  Tweaked for lowercase messages.

f3ec049e76257fc96bcdc872f1d3b967b98f3eb6 In consideration to benno@'s
comments, let the mktemp functions propogate an errno handled by the
caller.  Also keep the original line lengths.  While in mktemp.c, make
some defines into an enum.

e116c2bd00e634b56e4276120135915ceaa31cf2 Put the FSM of the sender
into its own function.  Put dry_run ack and end of phase ack into the
send buffer too, further reducing the possibility of deadlock.

c7745aa4c7394ca89d841f8ee76782256d694340 Make the sender write loop be
fully non-blocking.  This frees us of deadlocking the protocol because
the sender will always be able to pull down data.

93c7b4843e80aeac2ec6ae6ffc395df4deaf4a31 Remove "yoda" notation to be
more in tune with OpenBSD.  Most found by deraadt@.

Revision 1.29 / (download) - annotate - [select for diffs], Mon Feb 18 21:55:27 2019 UTC (5 years, 3 months ago) by benno
Branch: MAIN
Changes since 1.28: +45 -55 lines
Diff to previous 1.28 (colored)

revert previous

Revision 1.28 / (download) - annotate - [select for diffs], Mon Feb 18 21:34:54 2019 UTC (5 years, 3 months ago) by benno
Branch: MAIN
Changes since 1.27: +55 -45 lines
Diff to previous 1.27 (colored)

sync with kristaps up to Sun Feb 17 2019

339cf5998c0c022623cd68de50722b6c14543952 Push "error trail" further into code.

baf58ce5fe1bc6ce431b3b0ac8264b83ae8c7d02 Document all arguments.  Add
  common -av usage.  Remove bits about not supporting anything but
  files/dirs.

821a811a8c80e52fb56b241fc65a16cae1b4fb2c Disambiguate as prodded by deraadt@

6c4475b8f226e9031ec0ec1b3f14f7d347132c87 Add -h to usage string

4d344ae6156873b44c95de0c1ed629e637c2d7ab Clarify error message
  language, use service name instead of port, specify that the socket is
  SOCK_STREAM.  From deraadt@.  Tweaked for lowercase messages.

f3ec049e76257fc96bcdc872f1d3b967b98f3eb6 In consideration to benno@'s
  comments, let the mktemp functions propogate an errno handled by the
  caller.  Also keep the original line lengths.  While in mktemp.c, make
  some defines into an enum.

e116c2bd00e634b56e4276120135915ceaa31cf2 Put the FSM of the sender
  into its own function.  Put dry_run ack and end of phase ack into the
  send buffer too, further reducing the possibility of deadlock.

c7745aa4c7394ca89d841f8ee76782256d694340 Make the sender write loop be
  fully non-blocking.  This frees us of deadlocking the protocol because
  the sender will always be able to pull down data.

93c7b4843e80aeac2ec6ae6ffc395df4deaf4a31 Remove "yoda" notation to be
  more in tune with OpenBSD.  Most found by deraadt@.

Revision 1.27 / (download) - annotate - [select for diffs], Sun Feb 17 20:11:42 2019 UTC (5 years, 3 months ago) by deraadt
Branch: MAIN
Changes since 1.26: +1 -2 lines
Diff to previous 1.26 (colored)

delete bogus comment

Revision 1.26 / (download) - annotate - [select for diffs], Sun Feb 17 18:11:50 2019 UTC (5 years, 3 months ago) by deraadt
Branch: MAIN
Changes since 1.25: +18 -4 lines
Diff to previous 1.25 (colored)

Add support for --port=PORT and ":port" in the rsync:// URL.
real rsync only supports numbers, but this supports service names also
ok florian benno

Revision 1.25 / (download) - annotate - [select for diffs], Sun Feb 17 17:19:05 2019 UTC (5 years, 3 months ago) by deraadt
Branch: MAIN
Changes since 1.24: +31 -31 lines
Diff to previous 1.24 (colored)

rsync has a large number of failure exit codes, so don't get used to this
weak sauce EXIT_SUCCESS / EXIT_FAILURE model (in our tree very few programs
use this failed concept, almost as bad as sysexits.h)

Revision 1.24 / (download) - annotate - [select for diffs], Sun Feb 17 15:59:09 2019 UTC (5 years, 3 months ago) by deraadt
Branch: MAIN
Changes since 1.23: +9 -10 lines
Diff to previous 1.23 (colored)

percolate exit code from deeper code, so that values other than 1 are
possible on failure.
looked at by florian

Revision 1.23 / (download) - annotate - [select for diffs], Sat Feb 16 17:59:33 2019 UTC (5 years, 3 months ago) by deraadt
Branch: MAIN
Changes since 1.22: +2 -2 lines
Diff to previous 1.22 (colored)

nasty ugly invisible spaces

Revision 1.22 / (download) - annotate - [select for diffs], Sat Feb 16 17:48:48 2019 UTC (5 years, 3 months ago) by deraadt
Branch: MAIN
Changes since 1.21: +2 -1 lines
Diff to previous 1.21 (colored)

--archive is same as -a

Revision 1.21 / (download) - annotate - [select for diffs], Sat Feb 16 17:36:07 2019 UTC (5 years, 3 months ago) by deraadt
Branch: MAIN
Changes since 1.20: +6 -4 lines
Diff to previous 1.20 (colored)

add --help option

Revision 1.20 / (download) - annotate - [select for diffs], Sat Feb 16 17:05:21 2019 UTC (5 years, 3 months ago) by deraadt
Branch: MAIN
Changes since 1.19: +18 -9 lines
Diff to previous 1.19 (colored)

add missing -no-OPT long options
ok florian

Revision 1.19 / (download) - annotate - [select for diffs], Sat Feb 16 10:48:05 2019 UTC (5 years, 3 months ago) by florian
Branch: MAIN
Changes since 1.18: +27 -9 lines
Diff to previous 1.18 (colored)

implement -D and in turn -a

"you snooze, you get collisions" deraadt@

Revision 1.18 / (download) - annotate - [select for diffs], Sat Feb 16 10:44:01 2019 UTC (5 years, 3 months ago) by florian
Branch: MAIN
Changes since 1.17: +7 -7 lines
Diff to previous 1.17 (colored)

Add chown pledge so that root can gift files to other uids.

"you snooze, you get collisions" deraadt@

Revision 1.17 / (download) - annotate - [select for diffs], Sat Feb 16 05:36:07 2019 UTC (5 years, 3 months ago) by deraadt
Branch: MAIN
Changes since 1.16: +6 -1 lines
Diff to previous 1.16 (colored)

a minimal --version long-option, so someone can unconfuse themselves

Revision 1.16 / (download) - annotate - [select for diffs], Thu Feb 14 18:32:00 2019 UTC (5 years, 3 months ago) by florian
Branch: MAIN
Changes since 1.15: +2 -2 lines
Diff to previous 1.15 (colored)

sync with kristaps, commit 438c1948c76a1ecd94e53e09ba88ec7e93004540

Put back stray -o passed into child and add missing pledge.

Revision 1.15 / (download) - annotate - [select for diffs], Thu Feb 14 18:31:01 2019 UTC (5 years, 3 months ago) by florian
Branch: MAIN
Changes since 1.14: +2 -3 lines
Diff to previous 1.14 (colored)

sync with kristaps, commit 71065b31649480ceb1ee6942232d673bf8ab70c8

Enable -o.

Revision 1.14 / (download) - annotate - [select for diffs], Thu Feb 14 18:28:23 2019 UTC (5 years, 3 months ago) by florian
Branch: MAIN
Changes since 1.13: +3 -2 lines
Diff to previous 1.13 (colored)

sync with kristaps, commit ab90d923f89b06308190d9fe371c7663c077e2bd

-o isn't finished yet...

Revision 1.13 / (download) - annotate - [select for diffs], Thu Feb 14 18:26:52 2019 UTC (5 years, 3 months ago) by florian
Branch: MAIN
Changes since 1.12: +6 -3 lines
Diff to previous 1.12 (colored)

sync with kristaps, commit c5350b9055c3921001778275bb808a5c811c21c1

Protocol-level support for -o.  The actual sharing itself is more or less a
copy of the existing -g code.  I've refactored a lot of the ids.c code to be
generic and only accept a "isgid", as the rest is the same.  So there's some
churn as I make all references to "group" be generic.

Revision 1.12 / (download) - annotate - [select for diffs], Tue Feb 12 22:19:05 2019 UTC (5 years, 3 months ago) by deraadt
Branch: MAIN
Changes since 1.11: +2 -1 lines
Diff to previous 1.11 (colored)

long option -group is same as -g; ok benno

Revision 1.11 / (download) - annotate - [select for diffs], Tue Feb 12 19:39:57 2019 UTC (5 years, 3 months ago) by benno
Branch: MAIN
Changes since 1.10: +4 -3 lines
Diff to previous 1.10 (colored)

whitespace and knf

Revision 1.10 / (download) - annotate - [select for diffs], Tue Feb 12 17:58:35 2019 UTC (5 years, 3 months ago) by benno
Branch: MAIN
Changes since 1.9: +11 -8 lines
Diff to previous 1.9 (colored)

sync, this also adds the -g option to the option parser.

commit c7818bfb17195fcd7b723889bb8652b9ea024b01
Author: kristaps <>
Date:   Mon Feb 11 23:26:55 2019 +0000

    Add getpw pledge for -g work.

Revision 1.9 / (download) - annotate - [select for diffs], Tue Feb 12 14:09:59 2019 UTC (5 years, 3 months ago) by deraadt
Branch: MAIN
Changes since 1.8: +4 -2 lines
Diff to previous 1.8 (colored)

complete support for -e and -rsh=name options
ok florian benno

Revision 1.8 / (download) - annotate - [select for diffs], Tue Feb 12 14:00:57 2019 UTC (5 years, 3 months ago) by deraadt
Branch: MAIN
Changes since 1.7: +12 -6 lines
Diff to previous 1.7 (colored)

add long-opts aliases for single-letter options already present
ok florian benno

Revision 1.7 / (download) - annotate - [select for diffs], Mon Feb 11 21:44:44 2019 UTC (5 years, 3 months ago) by deraadt
Branch: MAIN
Changes since 1.6: +1 -2 lines
Diff to previous 1.6 (colored)

premature bit snuck in

Revision 1.6 / (download) - annotate - [select for diffs], Mon Feb 11 21:41:22 2019 UTC (5 years, 3 months ago) by deraadt
Branch: MAIN
Changes since 1.5: +57 -61 lines
Diff to previous 1.5 (colored)

swap comparison arguments as needed, to match idiomatic C most of us
are familiar with.  Proofed by florian and benno

Revision 1.5 / (download) - annotate - [select for diffs], Mon Feb 11 20:11:42 2019 UTC (5 years, 3 months ago) by deraadt
Branch: MAIN
Changes since 1.4: +3 -5 lines
Diff to previous 1.4 (colored)

flags variable not needed

Revision 1.4 / (download) - annotate - [select for diffs], Mon Feb 11 19:18:36 2019 UTC (5 years, 3 months ago) by deraadt
Branch: MAIN
Changes since 1.3: +7 -7 lines
Diff to previous 1.3 (colored)

cleanup weird spaces around !.  (We normalize source-code to a standard
idiom because it is less error prone for a larger team.  kristaps idiom
is highly divergent)
ok benno

Revision 1.3 / (download) - annotate - [select for diffs], Sun Feb 10 23:43:31 2019 UTC (5 years, 3 months ago) by benno
Branch: MAIN
Changes since 1.2: +11 -8 lines
Diff to previous 1.2 (colored)

canonical order of pledge()s.
stop at 80 char line lenght.

Revision 1.2 / (download) - annotate - [select for diffs], Sun Feb 10 23:24:14 2019 UTC (5 years, 3 months ago) by benno
Branch: MAIN
Changes since 1.1: +2 -2 lines
Diff to previous 1.1 (colored)

fix whitespace

Revision 1.1 / (download) - annotate - [select for diffs], Sun Feb 10 23:18:28 2019 UTC (5 years, 3 months ago) by benno
Branch: MAIN

Import Kristaps' openrsync into the tree.
OK deraadt@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.