OpenBSD CVS

CVS log for src/usr.bin/sendbug/sendbug.c


[BACK] Up to [local] / src / usr.bin / sendbug

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.80 / (download) - annotate - [select for diffs], Sun Apr 10 17:47:54 2022 UTC (2 years, 1 month ago) by jca
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, HEAD
Changes since 1.79: +3 -2 lines
Diff to previous 1.79 (colored)

Add more missing archs to "categories": aarch64, mips64el and powerpc64

The categories listing is long and maybe adding archs in there isn't
very relevant (any more?).

Revision 1.79 / (download) - annotate - [select for diffs], Tue Mar 29 18:44:12 2022 UTC (2 years, 1 month ago) by jca
Branch: MAIN
CVS Tags: OPENBSD_7_1_BASE, OPENBSD_7_1
Changes since 1.78: +2 -2 lines
Diff to previous 1.78 (colored)

Update list ofarchitectures

Retire sparc (32 bits) and vax, add riscv64.
From Raf Czlonka

Revision 1.78 / (download) - annotate - [select for diffs], Mon Aug 21 21:41:13 2017 UTC (6 years, 8 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2
Changes since 1.77: +9 -4 lines
Diff to previous 1.77 (colored)

Use waitpid()/EINTR idiom for the specific pid, rather than generic wait(),
in case the parent process was started with a dangling child.  This style
ensures any potential parent:child interlock isn't disrupted due to the
"wrong" child being waited on first.  Then the other other childs can safely
zombie.
ok millert jca brynet

Revision 1.77 / (download) - annotate - [select for diffs], Tue Oct 18 20:07:35 2016 UTC (7 years, 7 months ago) by kettenis
Branch: MAIN
CVS Tags: OPENBSD_6_1_BASE, OPENBSD_6_1
Changes since 1.76: +3 -7 lines
Diff to previous 1.76 (colored)

Use the files in /var/db/acpi instead of trying to run acpidump.

ok brynet@

Revision 1.76 / (download) - annotate - [select for diffs], Wed May 18 19:10:26 2016 UTC (8 years ago) by jca
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE, OPENBSD_6_0
Changes since 1.75: +6 -2 lines
Diff to previous 1.75 (colored)

Also print a warning if the user doesn't fill the mail Subject

Alternative diff by Tim (trondd ! kagu-tsuchi . com), ok tedu@

Revision 1.75 / (download) - annotate - [select for diffs], Wed May 18 19:06:25 2016 UTC (8 years ago) by jca
Branch: MAIN
Changes since 1.74: +13 -7 lines
Diff to previous 1.74 (colored)

Print a user-friendly message if some fields are missing; ok tedu@

Revision 1.74 / (download) - annotate - [select for diffs], Thu Mar 17 19:40:43 2016 UTC (8 years, 2 months ago) by krw
Branch: MAIN
Changes since 1.73: +2 -2 lines
Diff to previous 1.73 (colored)

Last parameter to execl[e]() functions *must* be cast to a pointer.
Just NULL is not good practise as NULL is theoretically allowed to
be an integer rather than a pointer.

Use (char *)NULL consistently instead of scattering a few (char *)0
and (void *)NULL into the mix.

Prompted by and probably ok deraadt@ millert@ kettenis@

Definitely ok mestre@ ratchov@

Revision 1.73 / (download) - annotate - [select for diffs], Mon Oct 26 13:12:10 2015 UTC (8 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.72: +2 -5 lines
Diff to previous 1.72 (colored)

remove TMPDIR support

Revision 1.72 / (download) - annotate - [select for diffs], Sun Oct 11 21:23:15 2015 UTC (8 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.71: +3 -7 lines
Diff to previous 1.71 (colored)

-version options on commands like this make no sense; the version number
makes no promises about compatibility nor the lack of compatibility.
suggestion & diff from micheal reed

Revision 1.71 / (download) - annotate - [select for diffs], Sat Oct 10 20:35:01 2015 UTC (8 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.70: +2 -2 lines
Diff to previous 1.70 (colored)

normalize a few more tame request orderings, to help review

Revision 1.70 / (download) - annotate - [select for diffs], Sat Oct 10 19:10:20 2015 UTC (8 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.69: +4 -1 lines
Diff to previous 1.69 (colored)

pledge "stdio getpw rpath wpath cpath tmppath proc exec". doug pointed out
the need for getpw.  Not sure if I see ways to improve this program.
ok doug

Revision 1.69 / (download) - annotate - [select for diffs], Fri Jan 16 06:40:11 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.68: +1 -2 lines
Diff to previous 1.68 (colored)

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible.  Annotate <sys/param.h> lines with their current reasons.  Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc.  Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution.  These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Revision 1.68 / (download) - annotate - [select for diffs], Tue Mar 18 22:36:37 2014 UTC (10 years, 2 months ago) by miod
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6
Changes since 1.67: +3 -3 lines
Diff to previous 1.67 (colored)

Retire hp300, mvme68k and mvme88k ports. These ports have no users, keeping
this hardware alive is becoming increasingly difficult, and I should heed the
message sent by the three disks which have died on me over the last few days.

Noone sane will mourn these ports anyway. So long, and thanks for the fish.

Revision 1.67 / (download) - annotate - [select for diffs], Sat Jul 21 19:55:17 2012 UTC (11 years, 10 months ago) by phessler
Branch: MAIN
CVS Tags: OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2
Changes since 1.66: +2 -2 lines
Diff to previous 1.66 (colored)

Have sendbug(1) submit error reports to bugs@, instead of gnats@.

OK deraadt@

Revision 1.66 / (download) - annotate - [select for diffs], Tue Apr 20 21:33:25 2010 UTC (14 years, 1 month ago) by sthen
Branch: MAIN
CVS Tags: OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8
Changes since 1.65: +3 -5 lines
Diff to previous 1.65 (colored)

Fix some pclose() calls, spotted by Peter Philipp. ok deraadt@

Revision 1.65 / (download) - annotate - [select for diffs], Tue Apr 20 19:05:03 2010 UTC (14 years, 1 month ago) by sthen
Branch: MAIN
Changes since 1.64: +28 -5 lines
Diff to previous 1.64 (colored)

Include usbdevs -v output in the PR template, showing us device IDs which
cannot be deduced from the dmesg output.  Suggested by miod@, ok deraadt@

Revision 1.64 / (download) - annotate - [select for diffs], Tue Mar 23 19:19:53 2010 UTC (14 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.63: +3 -1 lines
Diff to previous 1.63 (colored)

fixes memory and FILE handle leaks.  `acpidir' is allocated via
asprintf(3) and `ifp' is opened via popen(3), but not closed.
from zinovik

Revision 1.63 / (download) - annotate - [select for diffs], Wed Aug 26 20:40:40 2009 UTC (14 years, 8 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.62: +4 -3 lines
Diff to previous 1.62 (colored)

initialize tmpdir before use; PR 6214

Revision 1.62 / (download) - annotate - [select for diffs], Sun Jun 7 15:36:45 2009 UTC (14 years, 11 months ago) by ray
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6
Changes since 1.61: +4 -38 lines
Diff to previous 1.61 (colored)

Remove gecos expanding code, since the expanded string is no longer
used.

Revision 1.61 / (download) - annotate - [select for diffs], Sat Jun 6 04:46:26 2009 UTC (14 years, 11 months ago) by ray
Branch: MAIN
Changes since 1.60: +90 -9 lines
Diff to previous 1.60 (colored)

Include pcidump and acpidump output when sendbug is run as root,
to aid ACPI development.  Output files are base64 encoded in the
report.

Add a -E flag to decode files from a report to the current directory.

Requested by deraadt, "Sweet!" marco, "Looks good to me." pirofti

Revision 1.60 / (download) - annotate - [select for diffs], Wed Jan 28 20:43:24 2009 UTC (15 years, 3 months ago) by ray
Branch: MAIN
CVS Tags: OPENBSD_4_5_BASE, OPENBSD_4_5
Changes since 1.59: +18 -9 lines
Diff to previous 1.59 (colored)

Re-add "Category" category to sendbug template. Without it, reports
were categorized as "pending" and the report was never acked.

Reported by RD Thrush and bernd@, OK miod

Revision 1.59 / (download) - annotate - [select for diffs], Sun Dec 14 07:46:24 2008 UTC (15 years, 5 months ago) by ray
Branch: MAIN
Changes since 1.58: +12 -51 lines
Diff to previous 1.58 (colored)

Remove useless fields from template, they just serve to confuse
users.

Idea okayed by art and deraadt, feedback from jmc.

Revision 1.58 / (download) - annotate - [select for diffs], Mon Oct 6 04:58:37 2008 UTC (15 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.57: +10 -5 lines
Diff to previous 1.57 (colored)

parse all arguments before going and doing the job requested by -P
(slight change made to check argc == 0)
from Daniel Dickman

Revision 1.57 / (download) - annotate - [select for diffs], Sat Jun 14 20:45:45 2008 UTC (15 years, 11 months ago) by pvalchev
Branch: MAIN
CVS Tags: OPENBSD_4_4_BASE, OPENBSD_4_4
Changes since 1.56: +3 -3 lines
Diff to previous 1.56 (colored)

- remove ports category after discussion w/ many
- sync architectures list with reality and fix a few names
ok theo

Revision 1.56 / (download) - annotate - [select for diffs], Thu May 8 00:10:46 2008 UTC (16 years ago) by chl
Branch: MAIN
Changes since 1.55: +2 -2 lines
Diff to previous 1.55 (colored)

replace "/usr/sbin/sendmail" with _PATH_SENDMAIL

no binary change

found by Daniel Dickman <didickman at gmail.com>

ok ray@

Revision 1.55 / (download) - annotate - [select for diffs], Sat Apr 19 09:22:31 2008 UTC (16 years, 1 month ago) by ray
Branch: MAIN
Changes since 1.54: +7 -5 lines
Diff to previous 1.54 (colored)

Decrement len variable after removing newline, prevents copying the
NUL at the end of a string into the mail.  Discovered by dasn.

Move newline printing into outer loop, prevents multiple newlines
from appearing if there are multiple comments in a line.  Discovered
by okan.

OK okan.

Revision 1.54 / (download) - annotate - [select for diffs], Fri Jan 4 00:50:09 2008 UTC (16 years, 4 months ago) by ray
Branch: MAIN
CVS Tags: OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.53: +37 -26 lines
Diff to previous 1.53 (colored)

Eliminate false positives from <> comments, avoiding mangling
#include <bleh.h> in diffs:
- Only match <> comments from the template.  No other text surrounded
by angle brackets is deleted.
- Simplify code by using C strings.  We no longer handle binary
data, but I don't think binary data belongs in a bug report anyway.
- Remove dmesg and header comment checks.

"That's a nice approach." deraadt, "seems ok for me" chl.

Revision 1.53 / (download) - annotate - [select for diffs], Thu Jan 3 03:19:36 2008 UTC (16 years, 4 months ago) by ray
Branch: MAIN
Changes since 1.52: +31 -23 lines
Diff to previous 1.52 (colored)

In preparation of eliminating <> comment false positives:
- Move <> comments in template to an array, for easier reference later.
- Rename "comment" variable to avoid shadowing.
- Change some <> comments to SENDBUG comments.

OK chl@

Revision 1.52 / (download) - annotate - [select for diffs], Wed Oct 17 20:02:33 2007 UTC (16 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.51: +9 -12 lines
Diff to previous 1.51 (colored)

- Be more careful about pre-existing SIGCHLD handlers (or SIG_IGN) by
  temporarily restoring default behaviour.  This is not 100% ideal.
  But this fixes editor handling in mail... bah, it is really unfortunate
  that got broken
- refactor the restoration code as well, to make it simpler
ok ray

Revision 1.51 / (download) - annotate - [select for diffs], Tue Sep 18 00:38:58 2007 UTC (16 years, 8 months ago) by ray
Branch: MAIN
Changes since 1.50: +15 -7 lines
Diff to previous 1.50 (colored)

Don't treat lines in angle brackets <...> as comments in dmesg.

Discovered and tested by deanna.

Revision 1.50 / (download) - annotate - [select for diffs], Tue Jul 31 03:44:21 2007 UTC (16 years, 9 months ago) by ray
Branch: MAIN
CVS Tags: OPENBSD_4_2_BASE, OPENBSD_4_2
Changes since 1.49: +1 -2 lines
Diff to previous 1.49 (colored)

Remove some unused headers, from Igor Zinovik.

Revision 1.49 / (download) - annotate - [select for diffs], Fri May 11 02:07:47 2007 UTC (17 years ago) by ray
Branch: MAIN
Changes since 1.48: +3 -6 lines
Diff to previous 1.48 (colored)

If fork fails with EAGAIN, ignore errno and fail.  Looping just
worsens the problem.

cloder@ and deraadt@ agree.

Revision 1.48 / (download) - annotate - [select for diffs], Fri May 11 02:00:49 2007 UTC (17 years ago) by ray
Branch: MAIN
Changes since 1.47: +11 -5 lines
Diff to previous 1.47 (colored)

Instead of returning -1 and setting errno to ECHILD if the editor
has a non-zero exit status, just return the exit status on success.
Hard errors still return -1.  If the editor is killed, return -1
and set EINTR.

Revision 1.47 / (download) - annotate - [select for diffs], Wed May 9 02:36:56 2007 UTC (17 years ago) by ray
Branch: MAIN
Changes since 1.46: +7 -7 lines
Diff to previous 1.46 (colored)

Be more consistent about when dmesg is attached to template.
Specifically, -V.

Revision 1.46 / (download) - annotate - [select for diffs], Mon May 7 02:11:12 2007 UTC (17 years ago) by ray
Branch: MAIN
Changes since 1.45: +17 -28 lines
Diff to previous 1.45 (colored)

Simplify some loops.

OK jaredy@ and moritz@.

Revision 1.45 / (download) - annotate - [select for diffs], Sun May 6 05:01:19 2007 UTC (17 years ago) by ray
Branch: MAIN
Changes since 1.44: +10 -4 lines
Diff to previous 1.44 (colored)

Restore signals before returning.

Revision 1.44 / (download) - annotate - [select for diffs], Sun May 6 04:50:26 2007 UTC (17 years ago) by ray
Branch: MAIN
Changes since 1.43: +5 -5 lines
Diff to previous 1.43 (colored)

Save and restore signals once instead of each time fork fails with
EAGAIN.

Revision 1.43 / (download) - annotate - [select for diffs], Wed Apr 25 04:56:14 2007 UTC (17 years ago) by ray
Branch: MAIN
Changes since 1.42: +3 -5 lines
Diff to previous 1.42 (colored)

Remove extra code that only applies to setuid/setgid programs.

``Slacker!  We'll burn your hands if you don't get going!'' deraadt@

Revision 1.42 / (download) - annotate - [select for diffs], Sat Apr 7 04:58:50 2007 UTC (17 years, 1 month ago) by ray
Branch: MAIN
Changes since 1.41: +5 -6 lines
Diff to previous 1.41 (colored)

Sprinkle const poison, remove unneeded variable.

Revision 1.41 / (download) - annotate - [select for diffs], Sat Apr 7 00:40:43 2007 UTC (17 years, 1 month ago) by ray
Branch: MAIN
Changes since 1.40: +6 -5 lines
Diff to previous 1.40 (colored)

Use __progname and warn instead of fprintf where appropriate.

Revision 1.40 / (download) - annotate - [select for diffs], Sat Apr 7 00:24:59 2007 UTC (17 years, 1 month ago) by ray
Branch: MAIN
Changes since 1.39: +5 -4 lines
Diff to previous 1.39 (colored)

De-lint.

Revision 1.39 / (download) - annotate - [select for diffs], Fri Apr 6 21:51:09 2007 UTC (17 years, 1 month ago) by ray
Branch: MAIN
Changes since 1.38: +74 -1 lines
Diff to previous 1.38 (colored)

Warn if one of the required fields is not filled out.  Requested
by millert@.

Revision 1.38 / (download) - annotate - [select for diffs], Fri Apr 6 20:29:18 2007 UTC (17 years, 1 month ago) by ray
Branch: MAIN
Changes since 1.37: +10 -10 lines
Diff to previous 1.37 (colored)

Don't shadow variables.  Enable -Wshadow.

Revision 1.37 / (download) - annotate - [select for diffs], Fri Apr 6 07:24:53 2007 UTC (17 years, 1 month ago) by ray
Branch: MAIN
Changes since 1.36: +2 -2 lines
Diff to previous 1.36 (colored)

argc does not include __progname after subtracting optind.

Revision 1.36 / (download) - annotate - [select for diffs], Fri Apr 6 03:24:08 2007 UTC (17 years, 1 month ago) by ray
Branch: MAIN
Changes since 1.35: +46 -24 lines
Diff to previous 1.35 (colored)

Only include newest dmesg.

``Come on, take some risks'' deraadt@.

Revision 1.35 / (download) - annotate - [select for diffs], Fri Apr 6 01:32:39 2007 UTC (17 years, 1 month ago) by ray
Branch: MAIN
Changes since 1.34: +38 -7 lines
Diff to previous 1.34 (colored)

Attach dmesg to sendbug reports by default.  Use -D flag to disable.

OK deraadt@ and millert@.

Revision 1.34 / (download) - annotate - [select for diffs], Wed Mar 28 04:05:52 2007 UTC (17 years, 1 month ago) by ray
Branch: MAIN
Changes since 1.33: +2 -2 lines
Diff to previous 1.33 (colored)

CC: a copy of the bug report to sender.  Requested by Travers Buda.

OK millert@.

Revision 1.33 / (download) - annotate - [select for diffs], Tue Mar 27 04:15:00 2007 UTC (17 years, 1 month ago) by ray
Branch: MAIN
Changes since 1.32: +28 -23 lines
Diff to previous 1.32 (colored)

Replace some scary pointer code.  The new code is O(n^2) for strings
of '&', but gecos fields are usually short and most do not have '&'
so the impact should be minimal.  In return we get clearer and safer
code.

OK moritz@.

Revision 1.32 / (download) - annotate - [select for diffs], Tue Mar 27 03:40:44 2007 UTC (17 years, 1 month ago) by ray
Branch: MAIN
Changes since 1.31: +2 -2 lines
Diff to previous 1.31 (colored)

Remove variable name from prototype.

Revision 1.31 / (download) - annotate - [select for diffs], Mon Mar 26 18:13:08 2007 UTC (17 years, 1 month ago) by moritz
Branch: MAIN
Changes since 1.30: +8 -12 lines
Diff to previous 1.30 (colored)

Simplify gecos parsing code and prevent buffer overflow
when gecos field contains multiple '&' characters with
other characters inbetween.

With and OK ray@

Revision 1.30 / (download) - annotate - [select for diffs], Mon Mar 26 07:16:11 2007 UTC (17 years, 1 month ago) by ray
Branch: MAIN
Changes since 1.29: +2 -2 lines
Diff to previous 1.29 (colored)

Remove pointless cast.  No binary change.

Revision 1.29 / (download) - annotate - [select for diffs], Mon Mar 26 07:06:03 2007 UTC (17 years, 1 month ago) by ray
Branch: MAIN
Changes since 1.28: +2 -2 lines
Diff to previous 1.28 (colored)

Break on waitpid success; we shouldn't continue on WIFSIGNALED, and
WIFCONTINUED can't happen in this case.

OK deraadt@.

Revision 1.28 / (download) - annotate - [select for diffs], Mon Mar 26 06:47:00 2007 UTC (17 years, 1 month ago) by ray
Branch: MAIN
Changes since 1.27: +3 -2 lines
Diff to previous 1.27 (colored)

Certain errors in editit() should be fatal.

Revision 1.27 / (download) - annotate - [select for diffs], Mon Mar 26 06:40:01 2007 UTC (17 years, 1 month ago) by ray
Branch: MAIN
Changes since 1.26: +6 -7 lines
Diff to previous 1.26 (colored)

Don't print warnings in editit(), instead make errno reliable on
failure.  If the editor exits non-zero, errno is set to ECHILD.

OK deraadt@.

Revision 1.26 / (download) - annotate - [select for diffs], Mon Mar 26 06:22:12 2007 UTC (17 years, 1 month ago) by ray
Branch: MAIN
Changes since 1.25: +5 -2 lines
Diff to previous 1.25 (colored)

Accept $VISUAL in addition to $EDITOR.

Revision 1.25 / (download) - annotate - [select for diffs], Mon Mar 26 05:50:18 2007 UTC (17 years, 1 month ago) by ray
Branch: MAIN
Changes since 1.24: +11 -10 lines
Diff to previous 1.24 (colored)

Save and restore signal handlers.  Although we do not install our
own signal handlers, this allows this code to be more easily reused
in other programs.

OK deraadt@

Revision 1.24 / (download) - annotate - [select for diffs], Mon Mar 26 05:39:51 2007 UTC (17 years, 1 month ago) by ray
Branch: MAIN
Changes since 1.23: +2 -1 lines
Diff to previous 1.23 (colored)

Restore errno before calling perror().

Revision 1.23 / (download) - annotate - [select for diffs], Mon Mar 26 05:34:30 2007 UTC (17 years, 1 month ago) by ray
Branch: MAIN
Changes since 1.22: +2 -2 lines
Diff to previous 1.22 (colored)

Check fork() == -1 instead of fork() < 0.

Revision 1.22 / (download) - annotate - [select for diffs], Mon Mar 26 05:17:53 2007 UTC (17 years, 1 month ago) by ray
Branch: MAIN
Changes since 1.21: +1 -4 lines
Diff to previous 1.21 (colored)

When someone hits ^C in an editor, the editor does exit(130), I
don't know why.  Something to do with the shell, says deraadt@.
Continuing to ignore these signals in the child fixes this.

Now editit()'s return value can be reliably checked.

OK deraadt@.

Revision 1.21 / (download) - annotate - [select for diffs], Mon Mar 26 01:35:36 2007 UTC (17 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.20: +19 -15 lines
Diff to previous 1.20 (colored)

more careful waitpid() discussed with ray (plus some knf)

Revision 1.20 / (download) - annotate - [select for diffs], Sun Mar 25 23:35:59 2007 UTC (17 years, 1 month ago) by ray
Branch: MAIN
Changes since 1.19: +1 -6 lines
Diff to previous 1.19 (colored)

fork() does not return EPROCLIM, so don't test for it.

Revision 1.19 / (download) - annotate - [select for diffs], Sun Mar 25 23:27:38 2007 UTC (17 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.18: +28 -35 lines
Diff to previous 1.18 (colored)

more cleaning :)

Revision 1.18 / (download) - annotate - [select for diffs], Sun Mar 25 23:23:29 2007 UTC (17 years, 1 month ago) by ray
Branch: MAIN
Changes since 1.17: +6 -6 lines
Diff to previous 1.17 (colored)

Change editit() to return -1 on error and 0 on success, like many
other C functions.  (Currently this return value is unchecked.)

Revision 1.17 / (download) - annotate - [select for diffs], Sun Mar 25 23:21:11 2007 UTC (17 years, 1 month ago) by ray
Branch: MAIN
Changes since 1.16: +5 -5 lines
Diff to previous 1.16 (colored)

KNF.

Revision 1.16 / (download) - annotate - [select for diffs], Sun Mar 25 23:18:56 2007 UTC (17 years, 1 month ago) by ray
Branch: MAIN
Changes since 1.15: +5 -3 lines
Diff to previous 1.15 (colored)

Save errno before calling signal().

Revision 1.15 / (download) - annotate - [select for diffs], Fri Mar 23 17:18:07 2007 UTC (17 years, 2 months ago) by deraadt
Branch: MAIN
Changes since 1.14: +63 -18 lines
Diff to previous 1.14 (colored)

correct signal handling and process waiting for the editor spawning
code, so that signals in the editor are handled right.  written by ray
after he started looking at other code that does this better

Revision 1.14 / (download) - annotate - [select for diffs], Fri Mar 23 15:46:40 2007 UTC (17 years, 2 months ago) by deraadt
Branch: MAIN
Changes since 1.13: +23 -4 lines
Diff to previous 1.13 (colored)

Since we now have our own program, we can export more things that
matter.  Include kern.version, which tells a hell of a lot. ok millert ray

Revision 1.13 / (download) - annotate - [select for diffs], Fri Mar 23 06:16:24 2007 UTC (17 years, 2 months ago) by ray
Branch: MAIN
Changes since 1.12: +33 -6 lines
Diff to previous 1.12 (colored)

Replace `&' in gecos field with login, prodded by deraadt@.

Revision 1.12 / (download) - annotate - [select for diffs], Fri Mar 23 05:08:03 2007 UTC (17 years, 2 months ago) by tedu
Branch: MAIN
Changes since 1.11: +36 -42 lines
Diff to previous 1.11 (colored)

simplify cleanup by using an atexit handler.  lets us use err() instead
of a series of warn()/gotos.
ok deraadt

Revision 1.11 / (download) - annotate - [select for diffs], Fri Mar 23 03:43:46 2007 UTC (17 years, 2 months ago) by deraadt
Branch: MAIN
Changes since 1.10: +5 -3 lines
Diff to previous 1.10 (colored)

re-org something for prettiness

Revision 1.10 / (download) - annotate - [select for diffs], Fri Mar 23 03:35:01 2007 UTC (17 years, 2 months ago) by deraadt
Branch: MAIN
Changes since 1.9: +26 -3 lines
Diff to previous 1.9 (colored)

support $PR_FORM environment variable

Revision 1.9 / (download) - annotate - [select for diffs], Fri Mar 23 03:30:52 2007 UTC (17 years, 2 months ago) by ray
Branch: MAIN
Changes since 1.8: +3 -2 lines
Diff to previous 1.8 (colored)

Don't insert double slashes ("/tmp//p.XXXXXXXXXX") if TMPDIR ends
in "/".  Helps emacs and deraadt@.

Revision 1.8 / (download) - annotate - [select for diffs], Fri Mar 23 03:19:30 2007 UTC (17 years, 2 months ago) by ray
Branch: MAIN
Changes since 1.7: +6 -4 lines
Diff to previous 1.7 (colored)

Support command-line arguments in $EDITOR.  Prodded by deraadt@.

Revision 1.7 / (download) - annotate - [select for diffs], Fri Mar 23 03:13:22 2007 UTC (17 years, 2 months ago) by deraadt
Branch: MAIN
Changes since 1.6: +3 -3 lines
Diff to previous 1.6 (colored)

spacing

Revision 1.6 / (download) - annotate - [select for diffs], Fri Mar 23 02:46:32 2007 UTC (17 years, 2 months ago) by deraadt
Branch: MAIN
Changes since 1.5: +2 -2 lines
Diff to previous 1.5 (colored)

-V in usage

Revision 1.5 / (download) - annotate - [select for diffs], Fri Mar 23 02:45:21 2007 UTC (17 years, 2 months ago) by deraadt
Branch: MAIN
Changes since 1.4: +9 -5 lines
Diff to previous 1.4 (colored)

add -V (version) support

Revision 1.4 / (download) - annotate - [select for diffs], Fri Mar 23 02:41:02 2007 UTC (17 years, 2 months ago) by ray
Branch: MAIN
Changes since 1.3: +5 -2 lines
Diff to previous 1.3 (colored)

Get rid of silly gcc warning.

OK deraadt@.

Revision 1.3 / (download) - annotate - [select for diffs], Fri Mar 23 02:28:14 2007 UTC (17 years, 2 months ago) by deraadt
Branch: MAIN
Changes since 1.2: +29 -2 lines
Diff to previous 1.2 (colored)

handle the -L and -P options; ok ray

Revision 1.2 / (download) - annotate - [select for diffs], Fri Mar 23 02:11:00 2007 UTC (17 years, 2 months ago) by deraadt
Branch: MAIN
Changes since 1.1: +9 -9 lines
Diff to previous 1.1 (colored)

some minor KNF, including sentinals; ok ray

Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Fri Mar 23 01:47:11 2007 UTC (17 years, 2 months ago) by ray
Branch: RAY_20070322
CVS Tags: SENDBUG_4_2
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)

Import public domain rewrite of sendbug, written by Ray Lai. =)
Replaces GNU sendbug/sendpr, the wonderful shell script that had
trouble dealing with signals, behaved differently depending on what
file it read upon startup, and suffered from issues plaguing most
large shell scripts.

OK deraadt@.

Revision 1.1 / (download) - annotate - [select for diffs], Fri Mar 23 01:47:11 2007 UTC (17 years, 2 months ago) by ray
Branch: MAIN

Initial revision

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.