OpenBSD CVS

CVS log for src/usr.bin/snmp/smi.c


[BACK] Up to [local] / src / usr.bin / snmp

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.15 / (download) - annotate - [select for diffs], Thu Oct 21 08:17:34 2021 UTC (2 years, 6 months ago) by martijn
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, HEAD
Changes since 1.14: +2 -2 lines
Diff to previous 1.14 (colored)

Sync ober_oid_cmp with ax_oid_cmp from libagentx.
This flips the returned signedness and adds the weight of 2 for
parent-child relationship in both direction.

This makes ober_oid_cmp consistent with the rest of the *_cmp based
functions.

OK tb@

Revision 1.14 / (download) - annotate - [select for diffs], Mon Jan 4 08:00:29 2021 UTC (3 years, 4 months ago) by martijn
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9
Changes since 1.13: +1 -19 lines
Diff to previous 1.13 (colored)

Remove BER_TYPE_BOOLEAN, it's not part of the spec and I haven't seen it
used anywhere.

OK jan@

Revision 1.13 / (download) - annotate - [select for diffs], Mon Dec 14 07:44:26 2020 UTC (3 years, 5 months ago) by martijn
Branch: MAIN
Changes since 1.12: +31 -1 lines
Diff to previous 1.12 (colored)

Implement displaying SMI enums as text.
For now limit to TruthValue implemented on ifPromiscuousMode and
ifConnectorPresent.

OK jan@

Revision 1.12 / (download) - annotate - [select for diffs], Sat Aug 8 13:02:54 2020 UTC (3 years, 9 months ago) by martijn
Branch: MAIN
CVS Tags: OPENBSD_6_8_BASE, OPENBSD_6_8
Changes since 1.11: +4 -10 lines
Diff to previous 1.11 (colored)

Clean up smi_mibtree.

It checks on o_oid[0] for 0, which prevents us from adding the ccitt oid
and its zeroDotZero subsidiary. Change this to check for o_name, which is
always set, because mibtree is filled by MIBDECL().

Revision 1.11 / (download) - annotate - [select for diffs], Sat Aug 8 07:18:08 2020 UTC (3 years, 9 months ago) by martijn
Branch: MAIN
Changes since 1.10: +13 -13 lines
Diff to previous 1.10 (colored)

Somewhere during working on UTF-8 support I thought it was a good idea to
use sysContact as a testcase, because it's readily available in snmpd, but
forgetting it's actual textual convention as time went by, which is
DisplayString (which is ASCII).

Add support for the DisplayString textual convention, which is similar to
having no textual convention, except that invalid bytes (value 128 and up)
are printed as UTF-8 replacement characters, or question mark, depending on
LC_CTYPE.

Feedback and OK schwarze@

Revision 1.10 / (download) - annotate - [select for diffs], Mon Aug 3 14:45:54 2020 UTC (3 years, 9 months ago) by martijn
Branch: MAIN
Changes since 1.9: +131 -8 lines
Diff to previous 1.9 (colored)

Add support for UTF-8 DISPLAY-HINTs with octet length. For now only
sysContact is supported with SnmpAdminString, but more shall follow
soon(tm).

Note that this will change output even in the C locale: Previously every
unprintable byte would be tranformed to a '.', with this diff a valid UTF-8
multibyte or unprintable character will be squished into a single dot to
give a better understanding of the intention of the original message.
Invalid bytes will now be printed as question marks.

Lot's of help and back and forth with schwarze@ who also kindly offered to
walk away when I mentioned looking through MIB files for more objects to
convert to this new code, which is understandable.

OK schwarze@

Revision 1.9 / (download) - annotate - [select for diffs], Sun May 31 20:38:28 2020 UTC (3 years, 11 months ago) by martijn
Branch: MAIN
Changes since 1.8: +2 -2 lines
Diff to previous 1.8 (colored)

OIDs are unsigned. Reflect this when printing them.

Revision 1.8 / (download) - annotate - [select for diffs], Tue May 19 13:41:01 2020 UTC (4 years ago) by martijn
Branch: MAIN
Changes since 1.7: +5 -36 lines
Diff to previous 1.7 (colored)

Shave of some leftovers from snmpd's MIB initialization that are not needed
for snmp. Minus 503 LoC and about 200KB on binary size.

OK denis@

Revision 1.7 / (download) - annotate - [select for diffs], Fri Jan 17 09:52:44 2020 UTC (4 years, 4 months ago) by martijn
Branch: MAIN
CVS Tags: OPENBSD_6_7_BASE, OPENBSD_6_7
Changes since 1.6: +14 -4 lines
Diff to previous 1.6 (colored)

Add better support for exception contexts.
Now we can see proper nosuchinstance and endofmibtree messages.

OK jan@

Revision 1.5.2.1 / (download) - annotate - [select for diffs], Sun Oct 27 20:05:12 2019 UTC (4 years, 6 months ago) by tb
Branch: OPENBSD_6_6
Changes since 1.5: +9 -9 lines
Diff to previous 1.5 (colored) next main 1.6 (colored)

The ber_* namespace is used by liblber since time immemorial,
so move our BER API to the unused ober_* prefix to avoid some
breakage in ports.

Problem diagnosed by jmatthew with ber_free() in samba, but
there are many others as pointed out by sthen.

tests & ok rob
ok sthen (who had an almost identical diff for libutil)
"go head hit it" deraadt

OpenBSD 6.6 errata 002

Revision 1.6 / (download) - annotate - [select for diffs], Thu Oct 24 12:39:26 2019 UTC (4 years, 6 months ago) by tb
Branch: MAIN
Changes since 1.5: +9 -9 lines
Diff to previous 1.5 (colored)

The ber_* namespace is used by liblber since time immemorial,
so move our BER API to the unused ober_* prefix to avoid some
breakage in ports.

Problem diagnosed by jmatthew with ber_free() in samba, but
there are many others as pointed out by sthen.

tests & ok rob
ok sthen (who had an almost identical diff for libutil)
"go head hit it" deraadt

Revision 1.5 / (download) - annotate - [select for diffs], Fri Oct 11 14:48:30 2019 UTC (4 years, 7 months ago) by jsg
Branch: MAIN
CVS Tags: OPENBSD_6_6_BASE
Branch point for: OPENBSD_6_6
Changes since 1.4: +5 -4 lines
Diff to previous 1.4 (colored)

don't use sizeof(pointer) to represent buffer size
ok martijn@ deraadt@

Revision 1.4 / (download) - annotate - [select for diffs], Wed Oct 9 05:44:06 2019 UTC (4 years, 7 months ago) by martijn
Branch: MAIN
Changes since 1.3: +27 -10 lines
Diff to previous 1.3 (colored)

Use snprintf instead of sprintf.

Requested by and OK deraadt@

Revision 1.3 / (download) - annotate - [select for diffs], Sun Aug 11 15:52:46 2019 UTC (4 years, 9 months ago) by deraadt
Branch: MAIN
Changes since 1.2: +5 -6 lines
Diff to previous 1.2 (colored)

whitespace issues like a knife in my eyes

Revision 1.2 / (download) - annotate - [select for diffs], Sun Aug 11 14:41:20 2019 UTC (4 years, 9 months ago) by deraadt
Branch: MAIN
Changes since 1.1: +2 -3 lines
Diff to previous 1.1 (colored)

ugly whitespaces

Revision 1.1 / (download) - annotate - [select for diffs], Fri Aug 9 06:17:59 2019 UTC (4 years, 9 months ago) by martijn
Branch: MAIN

Import snmp(1), a new snmp client which aims to be netsnmp compatible for
supported features.  It only supports get, getnext, walk, bulkget, bulkwalk,
trap, mibtree, and is SNMPv1 and SNMPv2c for now.

This will shortly replace snmpctl entirely. People using snmpctl are encouraged
to test and migrate to this code as soon as possible.

Much help with the manpage from schwarze@ and jmc@
No objections from reyk@
"Roll it in" deraadt@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.