=================================================================== RCS file: /cvsrepo/anoncvs/cvs/src/usr.bin/ssh/authfd.c,v retrieving revision 1.39.2.3 retrieving revision 1.40 diff -u -r1.39.2.3 -r1.40 --- src/usr.bin/ssh/authfd.c 2002/06/02 22:56:09 1.39.2.3 +++ src/usr.bin/ssh/authfd.c 2001/06/07 20:23:03 1.40 @@ -35,7 +35,7 @@ */ #include "includes.h" -RCSID("$OpenBSD: authfd.c,v 1.39.2.3 2002/06/02 22:56:09 miod Exp $"); +RCSID("$OpenBSD: authfd.c,v 1.40 2001/06/07 20:23:03 markus Exp $"); #include @@ -58,8 +58,7 @@ /* macro to check for "agent failure" message */ #define agent_failed(x) \ - ((x == SSH_AGENT_FAILURE) || (x == SSH_COM_AGENT2_FAILURE) || \ - (x == SSH2_AGENT_FAILURE)) + ((x == SSH_AGENT_FAILURE) || (x == SSH_COM_AGENT2_FAILURE)) /* Returns the number of the authentication fd, or -1 if there is none. */ @@ -67,7 +66,7 @@ ssh_get_authentication_socket(void) { const char *authsocket; - int sock; + int sock, len; struct sockaddr_un sunaddr; authsocket = getenv(SSH_AUTHSOCKET_ENV_NAME); @@ -76,6 +75,8 @@ sunaddr.sun_family = AF_UNIX; strlcpy(sunaddr.sun_path, authsocket, sizeof(sunaddr.sun_path)); + len = SUN_LEN(&sunaddr)+1; + sunaddr.sun_len = len; sock = socket(AF_UNIX, SOCK_STREAM, 0); if (sock < 0) @@ -86,14 +87,14 @@ close(sock); return -1; } - if (connect(sock, (struct sockaddr *) &sunaddr, sizeof sunaddr) < 0) { + if (connect(sock, (struct sockaddr *) & sunaddr, len) < 0) { close(sock); return -1; } return sock; } -static int +int ssh_request_reply(AuthenticationConnection *auth, Buffer *request, Buffer *reply) { int l, len; @@ -217,7 +218,7 @@ int type, code1 = 0, code2 = 0; Buffer request; - switch (version) { + switch(version){ case 1: code1 = SSH_AGENTC_REQUEST_RSA_IDENTITIES; code2 = SSH_AGENT_RSA_IDENTITIES_ANSWER; @@ -286,7 +287,7 @@ * Get the next entry from the packet. These will abort with a fatal * error if the packet is too short or contains corrupt data. */ - switch (version) { + switch(version){ case 1: key = key_new(KEY_RSA1); bits = buffer_get_int(&auth->identities); @@ -344,7 +345,7 @@ buffer_put_bignum(&buffer, key->rsa->e); buffer_put_bignum(&buffer, key->rsa->n); buffer_put_bignum(&buffer, challenge); - buffer_append(&buffer, session_id, 16); + buffer_append(&buffer, (char *) session_id, 16); buffer_put_int(&buffer, response_type); if (ssh_request_reply(auth, &buffer, &buffer) == 0) { @@ -374,8 +375,8 @@ int ssh_agent_sign(AuthenticationConnection *auth, Key *key, - u_char **sigp, u_int *lenp, - u_char *data, u_int datalen) + u_char **sigp, int *lenp, + u_char *data, int datalen) { extern int datafellows; Buffer msg; @@ -416,7 +417,7 @@ /* Encode key for a message to the agent. */ -static void +void ssh_encode_identity_rsa1(Buffer *b, RSA *key, const char *comment) { buffer_clear(b); @@ -432,13 +433,13 @@ buffer_put_cstring(b, comment); } -static void +void ssh_encode_identity_ssh2(Buffer *b, Key *key, const char *comment) { buffer_clear(b); buffer_put_char(b, SSH2_AGENTC_ADD_IDENTITY); buffer_put_cstring(b, key_ssh_name(key)); - switch (key->type) { + switch(key->type){ case KEY_RSA: buffer_put_bignum2(b, key->rsa->n); buffer_put_bignum2(b, key->rsa->e); @@ -531,26 +532,6 @@ return decode_reply(type); } -int -ssh_update_card(AuthenticationConnection *auth, int add, const char *reader_id, const char *pin) -{ - Buffer msg; - int type; - - buffer_init(&msg); - buffer_put_char(&msg, add ? SSH_AGENTC_ADD_SMARTCARD_KEY : - SSH_AGENTC_REMOVE_SMARTCARD_KEY); - buffer_put_cstring(&msg, reader_id); - buffer_put_cstring(&msg, pin); - if (ssh_request_reply(auth, &msg, &msg) == 0) { - buffer_free(&msg); - return 0; - } - type = buffer_get_char(&msg); - buffer_free(&msg); - return decode_reply(type); -} - /* * Removes all identities from the agent. This call is not meant to be used * by normal applications. @@ -583,7 +564,6 @@ switch (type) { case SSH_AGENT_FAILURE: case SSH_COM_AGENT2_FAILURE: - case SSH2_AGENT_FAILURE: log("SSH_AGENT_FAILURE"); return 0; case SSH_AGENT_SUCCESS: