=================================================================== RCS file: /cvsrepo/anoncvs/cvs/src/usr.bin/ssh/packet.c,v retrieving revision 1.209 retrieving revision 1.210 diff -u -r1.209 -r1.210 --- src/usr.bin/ssh/packet.c 2015/03/11 00:48:39 1.209 +++ src/usr.bin/ssh/packet.c 2015/03/24 20:10:08 1.210 @@ -1,4 +1,4 @@ -/* $OpenBSD: packet.c,v 1.209 2015/03/11 00:48:39 jsg Exp $ */ +/* $OpenBSD: packet.c,v 1.210 2015/03/24 20:10:08 markus Exp $ */ /* * Author: Tatu Ylonen * Copyright (c) 1995 Tatu Ylonen , Espoo, Finland @@ -1268,10 +1268,8 @@ * Since we are blocking, ensure that all written packets have * been sent. */ - if ((r = ssh_packet_write_wait(ssh)) != 0) { - free(setp); - return r; - } + if ((r = ssh_packet_write_wait(ssh)) != 0) + goto out; /* Stay in the loop until we have received a complete packet. */ for (;;) { @@ -1328,15 +1326,20 @@ len = roaming_read(state->connection_in, buf, sizeof(buf), &cont); } while (len == 0 && cont); - if (len == 0) - return SSH_ERR_CONN_CLOSED; - if (len < 0) - return SSH_ERR_SYSTEM_ERROR; + if (len == 0) { + r = SSH_ERR_CONN_CLOSED; + goto out; + } + if (len < 0) { + r = SSH_ERR_SYSTEM_ERROR; + goto out; + } /* Append it to the buffer. */ if ((r = ssh_packet_process_incoming(ssh, buf, len)) != 0) - return r; + goto out; } + out: free(setp); return r; }