=================================================================== RCS file: /cvsrepo/anoncvs/cvs/src/usr.bin/ssh/sftp-client.c,v retrieving revision 1.57.2.1 retrieving revision 1.57.2.2 diff -u -r1.57.2.1 -r1.57.2.2 --- src/usr.bin/ssh/sftp-client.c 2006/02/03 03:01:57 1.57.2.1 +++ src/usr.bin/ssh/sftp-client.c 2006/10/06 03:19:33 1.57.2.2 @@ -1,3 +1,4 @@ +/* $OpenBSD: sftp-client.c,v 1.57.2.2 2006/10/06 03:19:33 brad Exp $ */ /* * Copyright (c) 2001-2004 Damien Miller * @@ -19,18 +20,27 @@ /* XXX: remove all logging, only return status codes */ /* XXX: copy between two remote sites */ -#include "includes.h" -RCSID("$OpenBSD: sftp-client.c,v 1.57.2.1 2006/02/03 03:01:57 brad Exp $"); - +#include #include +#include +#include +#include +#include -#include "buffer.h" -#include "bufaux.h" -#include "getput.h" +#include +#include +#include +#include +#include +#include +#include + #include "xmalloc.h" +#include "buffer.h" #include "log.h" #include "atomicio.h" #include "progressmeter.h" +#include "misc.h" #include "sftp.h" #include "sftp-common.h" @@ -39,7 +49,7 @@ extern volatile sig_atomic_t interrupted; extern int showprogress; -/* Minimum amount of data to read at at time */ +/* Minimum amount of data to read at a time */ #define MIN_READ_SIZE 512 struct sftp_conn { @@ -55,16 +65,19 @@ send_msg(int fd, Buffer *m) { u_char mlen[4]; + struct iovec iov[2]; if (buffer_len(m) > SFTP_MAX_MSG_LENGTH) fatal("Outbound message too long %u", buffer_len(m)); /* Send length first */ - PUT_32BIT(mlen, buffer_len(m)); - if (atomicio(vwrite, fd, mlen, sizeof(mlen)) != sizeof(mlen)) - fatal("Couldn't send packet: %s", strerror(errno)); + put_u32(mlen, buffer_len(m)); + iov[0].iov_base = mlen; + iov[0].iov_len = sizeof(mlen); + iov[1].iov_base = buffer_ptr(m); + iov[1].iov_len = buffer_len(m); - if (atomicio(vwrite, fd, buffer_ptr(m), buffer_len(m)) != buffer_len(m)) + if (atomiciov(writev, fd, iov, 2) != buffer_len(m) + sizeof(mlen)) fatal("Couldn't send packet: %s", strerror(errno)); buffer_clear(m); @@ -388,8 +401,7 @@ printf("%s\n", longname); if (dir) { - *dir = xrealloc(*dir, sizeof(**dir) * - (ents + 2)); + *dir = xrealloc(*dir, ents + 2, sizeof(**dir)); (*dir)[ents] = xmalloc(sizeof(***dir)); (*dir)[ents]->filename = xstrdup(filename); (*dir)[ents]->longname = xstrdup(longname);